Re: [Libreoffice] Any interest in porting this to 3.3?

2010-12-15 Thread Kohei Yoshida
On Tue, 2010-12-14 at 17:38 -0500, Kohei Yoshida wrote: In my opinion this is generally a safe bug fix that affects only limited functionality, but I'd like to know if it's worth porting this to 3.3. Ok. I take the silence as a no, which is fine. I'll keep this fix on master only. Kohei

Re: [Libreoffice] Bug to confirm: 32427

2010-12-15 Thread Kohei Yoshida
, but I'll get back to you when I find out where the code is. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Bug to confirm: 32427

2010-12-15 Thread Kohei Yoshida
On Wed, 2010-12-15 at 18:12 -0500, Kohei Yoshida wrote: If my above assumption is right, then this should be an easy fix. I can't remember which code I modified, but I'll get back to you when I find out where the code is. It's in SfxApplication::OpenDocExec_Impl(). I modified here a bit

Re: [Libreoffice] LibreOffice 3.3 release blockers / stoppers

2010-12-15 Thread Kohei Yoshida
fixed there. BTW, our bugzilla is hosted on freedesktop.org: http://bugs.freedesktop.org/ To file a bug, use product name 'LibreOffice' (in case you are interested in filing it as a bug). HTH, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

[Libreoffice] feature/calc-dp-unlimited-fields merged to master

2010-12-15 Thread Kohei Yoshida
didn't have this 8-field limit, the change is mostly in the main data pilot dialog, though I had to modify some code in the core to replace c-style static arrays with dynamic arrays such as vector's. Anyway, testing appreciated. ;-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh

Re: [Libreoffice] Embedded parts and wikihelp/HC2

2010-12-16 Thread Kohei Yoshida
this part is very important. Direct translation from English does not always sound right in some languages. So, I appreciate having this possibility in the new wikihelp. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] [PATCH] EasyHack: soffice accepts -help/-h/-? in presence of the unix quickstart

2010-12-16 Thread Kohei Yoshida
people enough chance to re-write their scripts etc. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] EasyHack: soffice accepts -help/-h/-? in presence of the unix quickstart

2010-12-17 Thread Kohei Yoshida
Hi Takeshi, On Sat, 2010-12-18 at 01:20 +0900, Takeshi Abe wrote: Hi Kohei, On Thu, 16 Dec 2010 23:23:04 -0500, Kohei Yoshida kyosh...@novell.com wrote: On Fri, 2010-12-17 at 12:44 +0900, Takeshi Abe wrote: (snip) Although fixing the -help/-h/-? action in presence of the unix

Re: [Libreoffice] [PATCH] [PUSHED] EasyHack: soffice accepts -help/-h/-? in presence of the unix quickstart

2010-12-17 Thread Kohei Yoshida
for the patch. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Windows Build] Oh man, please, help-me.

2010-12-18 Thread Kohei Yoshida
, and keep at it, and eventually you'll succeed! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Heads-up on mdds 0.4.0 requirement on master

2010-12-20 Thread Kohei Yoshida
you will need 0.4.0 in order to build sc. I'm not entirely finished with it yet, so for now no action is necessary. But I'll give you guys a follow-up email when I'm through with it. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] Heads-up on mdds 0.4.0 requirement on master

2010-12-20 Thread Kohei Yoshida
On Mon, 2010-12-20 at 18:00 -0500, Kohei Yoshida wrote: I'm not entirely finished with it yet, so for now no action is necessary. But I'll give you guys a follow-up email when I'm through with it. Ok. I'm done testing the new build. Please update your build tree, and run /download

Re: [Libreoffice] [PATCH] [PUSHED] Remove callcatchers in sc + cppcheck postfix operator

2010-12-20 Thread Kohei Yoshida
On Mon, 2010-12-20 at 23:09 +0100, Julien Nabet wrote: Hello, Remove call-catcher / bloat removal with sc module + some cppcheck postfix operator Compiling sc was ok. All patches applied pushed. Thanks a lot. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] Better wording for 'Update links' question

2010-12-21 Thread Kohei Yoshida
is normally stored with the document, and may be outdated. -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks Leftover data after Undo

2010-12-21 Thread Kohei Yoshida
the logic of the original code. Cheers, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Better wording for 'Update links' question

2010-12-21 Thread Kohei Yoshida
On Tue, 2010-12-21 at 12:48 -0500, Kohei Yoshida wrote: On Tue, 2010-12-21 at 18:09 +0100, Jan Holesovsky wrote: Hi, https://bugs.freedesktop.org/show_bug.cgi?id=32548 The bug says: when I open a certain .odp document, I get a pop-up question asking Update all links? Yes

Re: [Libreoffice] [PATCH] [PUSHED] EasyHacks Leftover data after Undo

2010-12-21 Thread Kohei Yoshida
motivates you. :-) So, the macro editor task sounds good to me. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] [UX] [PATCH] EasyHacks 3.27 Change Sheet copy process

2010-12-22 Thread Kohei Yoshida
-time improvement. But I'd love you hear your thoughts on how it could be improved further. Am Freitag, den 10.12.2010, 20:31 -0500 schrieb Kohei Yoshida: [...] About UI I'll refer to your (Kohei's) pictures linked in another mail ... And these are the screenshots of the new dialog

Re: [Libreoffice] [UX] [PATCH] EasyHacks 3.27 Change Sheet copy process

2010-12-22 Thread Kohei Yoshida
on the user clicking on the sheet name in the list. To me 1) that makes more sense, and 2) is easier to implement than handling mouse click events on the list control. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice

[Libreoffice] Request for review

2010-12-22 Thread Kohei Yoshida
me a sign-off? Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Request for review

2010-12-22 Thread Kohei Yoshida
On Wed, 2010-12-22 at 12:39 -0500, Kohei Yoshida wrote: I just fixed this bug https://bugs.freedesktop.org/show_bug.cgi?id=32572 which originally came from Caolan. The fix is committed on master, but I think we can apply this to 3.3 branch as well. I feel confident that this change

Re: [Libreoffice] [UX] [PATCH] EasyHacks 3.27 Change Sheet copy process

2010-12-22 Thread Kohei Yoshida
On Wed, 2010-12-22 at 19:30 +0100, Joost Eekhoorn wrote: Hi all, If you now give for Sheet1 a new name, e.g.SheetA and that name exists, the new name will become SheetA_2 without a question for the user. Sure. I said I implemented some aspect of it, and this is one of those cases we still

Re: [Libreoffice] Better wording for 'Update links' question

2010-12-22 Thread Kohei Yoshida
have such dialog implemented yet (feel free to correct me here), and until we do I would favor showing a more verbose and informative warning message than the current terse message that leaves some users confused and clueless. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] Request review for 3.3

2010-12-23 Thread Kohei Yoshida
On Thu, 2010-12-23 at 13:46 +, Caolán McNamara wrote: On Wed, 2010-12-22 at 23:19 -0500, Kohei Yoshida wrote: Hi there, Just fixed the following bug on master https://bugs.freedesktop.org/show_bug.cgi?id=32523 The fix was rather simple, as this commit shows http

[Libreoffice] Request for review for 3.3

2010-12-23 Thread Kohei Yoshida
wrong in our code base. A review and a sign-off would be great. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] SfxDocTplService_Impl posable memory leek

2010-12-23 Thread Kohei Yoshida
in that neighborhood. But please do double-check. Beyond that, I don't know for sure. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] A file to show 8192 discontinuities crashes Calc

2010-12-23 Thread Kohei Yoshida
of work. Let me look into this. I already have some ideas to make the filtering faster, but I need to experiment a bit. Thanks for the use case. Performance issue happens to be my sore spot. :-) Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com

Re: [Libreoffice] make check fails in ScFiltersTest

2011-10-24 Thread Kohei Yoshida
, but I'll keep this in the back of my head in case this is still outstanding when I do my next windows build. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] [PUSHED] Re: [PATCH] fix for fdo#37129 - Dotted and Dashed table borders are not drawn correctly

2011-10-25 Thread Kohei Yoshida
On Mon, 2011-10-24 at 12:50 +0900, Tomofumi Yagi wrote: Hi, So many thanks for reviewing and pushing the patch. And,There is one more please. Please Consider backport the patch to 3.4, if possible. This broblem on LibleOffice 3.4 as stable version gives to user a very bad

Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed

2011-10-25 Thread Kohei Yoshida
). Does anyone know (Kohei Yoshida?) the current status of the work on this bug? Is it something where I can be of help? (I used to develop in C++, before I had a stroke, nowadays the complexity must be low for me to work on it. Also, I will need assistence to get started. I can make

Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed

2011-10-25 Thread Kohei Yoshida
Hello Eike, On Tue, 2011-10-25 at 19:36 +0200, Eike Rathke wrote: Hi Kohei, On Tuesday, 2011-10-25 10:55:33 -0400, Kohei Yoshida wrote: However, this one is a bit complex, as we would need to move the flags that tell you which sheets are selected, from ScMarkData to ScDocument

Re: [Libreoffice] [PUSHED 3-4] fix for fdo#37129 - Dotted and Dashed table borders are not drawn correctly

2011-10-26 Thread Kohei Yoshida
On Wed, 2011-10-26 at 14:17 +0200, Cedric Bosdonnat wrote: Hi Kohei, all, On Tue, 2011-10-25 at 09:46 -0400, Kohei Yoshida wrote: The patch looks safe to me. Cedric, if it's okay with you, I'd like to backport this to the 3.4 branch with my sign-off. What do you think? I'm all

[Libreoffice] (real) Windows build, needs help.

2011-10-26 Thread Kohei Yoshida
I've been trying to build master on Windows with MSVC, and could use some help. Multiple git pull -r, and multiple clean builds over the past several days, and my build always fails in desktop with the following message: (lots of WARN prior to this similar to the one below)

Re: [Libreoffice] (real) Windows build, needs help.

2011-10-27 Thread Kohei Yoshida
Hi Fridrich, On Thu, 2011-10-27 at 10:41 +0200, Fridrich Strba wrote: This manifest problem arises on the first build and then when you do a new build in the desktop module, it is gone. Yup, that's exactly what I am seeing! Good to hear your confirmation. If there is an idea in the crowd

Re: [Libreoffice] (real) Windows build, needs help.

2011-10-28 Thread Kohei Yoshida
On Thu, 2011-10-27 at 11:49 -0400, Kohei Yoshida wrote: If there is an idea in the crowd what can be the problem, a patch will be integrated swiftly. No idea at the moment. I'm on to fixing another bug at the moment, but I may poke at this later if no one else hasn't by that time. So

Re: [Libreoffice] (real) Windows build, needs help.

2011-10-28 Thread Kohei Yoshida
On Fri, Oct 28, 2011 at 9:59 PM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: I dont have the patch here, Perhaps I shall attach your patch here for your perusal. :-) Kohei 0001-very-very-ugly-hack-to-get-the-soffice.bin-name.patch Description: Binary data

Re: [Libreoffice] [PUSHED][PATCH] eliminate SvUShorts type

2011-11-01 Thread Kohei Yoshida
On Tue, Nov 1, 2011 at 8:30 AM, Caolán McNamara caol...@redhat.com wrote: So, that's finally an end to SvUShorts, gone, dead as a parrot, pretty cool. That's very cool indeed! I was dreaming of this day for a long time. Kohei ___ LibreOffice

[Libreoffice] [REVIEW 3-4] Fix incorrect mapping of external ranges

2011-11-01 Thread Kohei Yoshida
for the stable branch. Reviews sign-off's appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#40967: or and and won't work correctly in array formulas

2011-11-01 Thread Kohei Yoshida
On Tue, Nov 1, 2011 at 12:18 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey, this patch fixes a problem with OR and AND in array formulas. The 3.3 code explicitly allowed boolean values and this patch allows them again. I think it is an extremely safe fix and should be

Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

2011-11-01 Thread Kohei Yoshida
), but I will agree that 1) it's much much better than crashing, and 2) the change only affects very rare corner cases that it's a safe change. Pushed to the 3-4 branch with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice

Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

2011-11-02 Thread Kohei Yoshida
really be Eike's). And as Eike said, I'd be also curious why the matrix is empty in the first place (when it gets pushed to the stack)... P.S. the commit message should be silly mistake by me Yup, I caught that too. Fixed. ;-) -- Kohei Yoshida, LibreOffice hacker, Calc

[Libreoffice] feature/cell-format-data-bar

2011-11-02 Thread Kohei Yoshida
. Anyway, this is just FYI. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] feature/cell-format-data-bar

2011-11-02 Thread Kohei Yoshida
On Wed, 2011-11-02 at 14:38 -0400, Kohei Yoshida wrote: Hi there, I just created a new branch named feature/cell-format-data-bar, to (for now) house a nice proof-of-concept patch I received from Michael during the conference in Paris. The goal of this branch is to eventually implement

[Libreoffice] feature/new-autofilter-popup

2011-11-02 Thread Kohei Yoshida
be in the final 1.2 spec. But I need to double-check this to be sure. I'd like to integrate the first phase of this feature in time for 3.5, but as always, the code freeze date approaching, it's not really a guarantee subject to change without notice. Best, Kohei -- Kohei Yoshida, LibreOffice

[Libreoffice] [REVIEW 3-4] Fix for pivot table's number output

2011-11-07 Thread Kohei Yoshida
Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEWED 3-4] [PUSHED] Fix for pivot table's number output

2011-11-07 Thread Kohei Yoshida
On Mon, 2011-11-07 at 11:17 -0500, Kohei Yoshida wrote: I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=18bff2c2e95218ff629e07369fd8bf2335544aac backported to the 3-4 branch for 3.4.5 inclusion. Markus has signed off on this on IRC, and I have pushed to the 3-4

[Libreoffice] [REVIEW 3-4] Fixing keyboard navigation of range selection in reference mode

2011-11-08 Thread Kohei Yoshida
the range to get extended to A3, but it in fact goes all the way down to the last row. The above commit fixes this. Review sign-off to the 3-4 branch appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] [REVIEW 3-4] Fixing keyboard navigation of range selection in reference mode

2011-11-10 Thread Kohei Yoshida
On Tue, 2011-11-08 at 21:25 -0500, Kohei Yoshida wrote: 1. put some numbers in A1:A3. 2. move the cursor to C1. 3. type =sum( 4. hit ctrl-left arrow to move the cursor to A1 (you should see the red rectangle encompassing the A1 cell). 5. hit ctrl-down arrow. Actually 5. should've been 5

Re: [Libreoffice] build fail: workdir/wntmsci12.pro/Dep/SdiTarget/basctl/sdi/basslots.d:1: *** target pattern contains no `%'

2011-11-10 Thread Kohei Yoshida
On Thu, 2011-11-10 at 10:02 +0200, Noel Grandin wrote: Any ideas? Yeah I got the same error and I'm doing the git pull -r clean build as we speak. Sorry, no help here, but just a confirmation. -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] [Libreoffice-commits] .: sc/inc sc/source

2011-11-11 Thread Kohei Yoshida
On Fri, 2011-11-11 at 15:41 +0100, Eike Rathke wrote: Hi Kohei, On Thursday, 2011-11-10 12:49:29 -0800, Kohei Yoshida wrote: commit eaea417bfdf8d06df2b7f2e42c904c32ce77e871 Author: Kohei Yoshida kohei.yosh...@suse.com Date: Thu Nov 10 15:45:53 2011 -0500 Removing the mixed

Re: [Libreoffice] [Libreoffice-commits] .: sc/inc sc/source

2011-11-15 Thread Kohei Yoshida
Hi Kevin, On Wed, Nov 16, 2011 at 12:21 AM, Kevin Hunter hunt...@earlham.edu wrote: From the curious cat: why? Because that made it easier to debug whatever I was debugging. Plus, I don't believe in those implicitly inline methods, especially in headers that are included by millions. Imagine

Re: [Libreoffice] [Libreoffice-commits] .: sc/inc sc/source

2011-11-15 Thread Kohei Yoshida
a bunch of headers just for the sake of it. This is not a definite rule; use your best judgment is what I would say. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [Libreoffice] [PATCH] fdo 42286 in calc solved ?

2011-11-16 Thread Kohei Yoshida
will not be the way to go. Sorry. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED, partial] Remove NULL checks from delete

2011-11-16 Thread Kohei Yoshida
pointless to set the pointer value to NULL after delete. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] .: bin/get-bugzilla-attachments-by-mimetype

2011-11-21 Thread Kohei Yoshida
On Mon, 2011-11-21 at 13:14 +0100, Markus Mohrhard wrote: If everyone is fine with the idea of putting the informatio in bugzilla I'll do that later today. Yes, that's my preferred workflow as well. Thanks a lot, Markus. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

[Libreoffice] Windows build breakage

2011-11-22 Thread Kohei Yoshida
Hi there, So, not having been able to build master on Windows for almost 2 months, I've decided to give it another go. But it fails in scripting this time, and I have no clue. The build log is attached. Hopefully this will ring a bell for someone... Kohei build.log.bz2 Description: BZip2

Re: [Libreoffice] Windows build breakage

2011-11-23 Thread Kohei Yoshida
On Wed, Nov 23, 2011 at 4:37 AM, Noel Power nopo...@suse.com wrote: On 23/11/11 09:27, Noel Power wrote: in my case a (full) clean build solved it has to be said this was on linux though Well, that was a full clean build when I saw that error message. Each time I build on windows I do a

Re: [Libreoffice] Windows build breakage

2011-11-23 Thread Kohei Yoshida
On Wed, Nov 23, 2011 at 1:18 AM, Noel Grandin n...@peralex.com wrote: Hi I tried to debug this with Michael Stahl's help, and I came to the conclusion that it is some kind of timing bug in make. Sometimes it works, sometimes not. In the end I gave up and disabled java. (--without-java).

[Libreoffice] [REVIEW 3-4] Fix for fdo#39589

2011-11-23 Thread Kohei Yoshida
Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=0215f8b19451ab67c7fdaf91f2da8298a9b89c47 cherry-picked to the 3-4 branch. It fixes https://bugs.freedesktop.org/show_bug.cgi?id=39589 which is one of the 3.4 most annoying bugs. Thanks! Kohei -- Kohei

Re: [Libreoffice] how to acquire an ScDocument reference from scratch

2011-11-23 Thread Kohei Yoshida
), and what end result you want to see would give us more context of what you are doing. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Libreoffice] [REVIEW 3-4] Fix for fdo#39589

2011-11-23 Thread Kohei Yoshida
On Thu, 2011-11-24 at 07:50 +0100, Lionel Elie Mamane wrote: On Wed, Nov 23, 2011 at 06:53:53PM -0500, Kohei Yoshida wrote: I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=0215f8b19451ab67c7fdaf91f2da8298a9b89c47 cherry-picked to the 3-4 branch. It fixes

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Kohei Yoshida
someone else knows the work that Oracle has done to the chart2 module after 3.3 give us some background? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] I need some advice to fix fdo#40363

2011-11-28 Thread Kohei Yoshida
On Mon, 2011-11-28 at 21:56 +0100, Regina Henschel wrote: Hi Kohei, Kohei Yoshida schrieb: [..] My conclusion? No idea what advice I should give you to get it fixed just yet. Maybe someone else knows the work that Oracle has done to the chart2 module after 3.3 give us some

Re: [Libreoffice] bug 32826 - Printing in Preview mode causes all sheets to be printed

2011-11-29 Thread Kohei Yoshida
On Tue, 2011-10-25 at 14:02 -0400, Kohei Yoshida wrote: The state what sheets are selected is clearly view related and does not belong to the document. In fact two different views can have different sheets selected. Well, I wouldn't say clearly, since I had the same idea about tab

Re: [Libreoffice] concept for c++ based subsequenttests

2011-11-30 Thread Kohei Yoshida
presence among us). :-) I personally do love and use python in some of our projects, but I would stick with C++ for this specific use case as Markus pointed out. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list

Re: [Libreoffice] concept for c++ based subsequenttests

2011-11-30 Thread Kohei Yoshida
On Thu, 2011-12-01 at 00:15 +0100, Bjoern Michaelsen wrote: Hi Kohei, On Wed, Nov 30, 2011 at 05:35:33PM -0500, Kohei Yoshida wrote: Also, by funky garbage collection if you are referring to the ref-counted cssu::Reference memory management that UNO API uses (since C ++ doesn't even have

Re: [Libreoffice] concept for c++ based subsequenttests

2011-11-30 Thread Kohei Yoshida
On Thu, 2011-12-01 at 01:17 +0100, Bjoern Michaelsen wrote: Hi, On Wed, Nov 30, 2011 at 06:22:11PM -0500, Kohei Yoshida wrote: So, this suggests that we first write test in python, then later rewrite it in C++, or would python tests stay in python? It wouldnt scare me if quite a few

Re: [Libreoffice] [PATCH] fdo#42286, do not shrink the selected area (2)

2011-11-30 Thread Kohei Yoshida
here funny. That would explain some of the inconsistencies you may be seeing in this neighborhood. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

[Libreoffice] Windows (MSVC) incremental build is broken.

2011-11-30 Thread Kohei Yoshida
Hi there, Windows build is broken once again, and this time it fails during incremental build only. After a full build succeeds, Doing e.g. source Env.Host.sh cd sc edit some file make fails 100% of the time. It doesn't matter which module you are in, or which file you touch. It always

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-11-30 Thread Kohei Yoshida
On Thu, Dec 1, 2011 at 1:17 AM, Kohei Yoshida kohei.yosh...@gmail.com wrote: Hi there, Windows build is broken once again, And reverting http://cgit.freedesktop.org/libreoffice/core/commit/?id=28275d470f3a062cfa27d72bbf89328af1e83c68 fixes it. I haven't pushed the revert yet since I don't

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-01 Thread Kohei Yoshida
Hi Bjoern, On Thu, 2011-12-01 at 09:21 +0100, Bjoern Michaelsen wrote: On Thu, Dec 01, 2011 at 01:36:14AM -0500, Kohei Yoshida wrote: And reverting http://cgit.freedesktop.org/libreoffice/core/commit/?id=28275d470f3a062cfa27d72bbf89328af1e83c68 fixes it. I haven't pushed the revert yet

[Libreoffice] Clipboard handling on Windows

2011-12-02 Thread Kohei Yoshida
Bug 33100, s/he will be more than welcome. :-) Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Clipboard handling on Windows

2011-12-02 Thread Kohei Yoshida
, when you use the second API. So, I'm still not understanding this fully. Why is it that, when you use the 2nd API, you only see some of the formats, not all? More importantly, if we want to have access to those formats that the 2nd API doesn't return, what are we to do? Kohei -- Kohei Yoshida

Re: [Libreoffice] Clipboard handling on Windows

2011-12-02 Thread Kohei Yoshida
On Fri, 2011-12-02 at 11:52 -0500, Kohei Yoshida wrote: Hi Noel, On Fri, 2011-12-02 at 18:40 +0200, Noel Grandin wrote: I think the second one is the newer one, and Windows provides some support for interfacing applications using the first one with applications using the second one

Re: [Libreoffice] Clipboard handling on Windows

2011-12-02 Thread Kohei Yoshida
of pre-filtering. I'll look into that class to see if it's doing something funny there. Thanks a lot everyone. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] Clipboard handling on Windows

2011-12-02 Thread Kohei Yoshida
On Fri, Dec 2, 2011 at 3:33 PM, Kohei Yoshida kohei.yosh...@suse.com wrote: As a test, I wrote another quick program to retrieve the clipboard format info using the IDataObject API, And here is the code (attached) that I used to retrieve the clipboard format info via IDataObject, in case

Re: [Libreoffice] Windows (MSVC) incremental build is broken.

2011-12-02 Thread Kohei Yoshida
On Thu, Dec 1, 2011 at 9:12 AM, Kohei Yoshida kohei.yosh...@suse.com wrote: Hi Bjoern, On Thu, 2011-12-01 at 09:21 +0100, Bjoern Michaelsen wrote: On Thu, Dec 01, 2011 at 01:36:14AM -0500, Kohei Yoshida wrote: And reverting http://cgit.freedesktop.org/libreoffice/core/commit/?id

Re: [Libreoffice] setting the background color of an Edit

2011-12-03 Thread Kohei Yoshida
Hi Markus, On Sat, Dec 3, 2011 at 5:30 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Do you have any ideas? You are almost there. IIRC there is some quirk with setting a background color with the Edit control; you need to set fore ground color before setting the background color

Re: [Libreoffice] Developing new built-in functions within LibreCalc

2011-12-06 Thread Kohei Yoshida
for LibreOffice. The problem is, I did a quick search on OOo's wiki site, and couldn't find that page. Eike, do you still remember where that article of yours is located? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list

Re: [Libreoffice] Developing new built-in functions within LibreCalc

2011-12-07 Thread Kohei Yoshida
it as a download to those who are interested in using it. We have an extension repository where users can find the extensions they want to download and use. What do you think? Would that be feasible for you? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] Developing new built-in functions within LibreCalc

2011-12-07 Thread Kohei Yoshida
On Wed, 2011-12-07 at 15:23 -0500, Kohei Yoshida wrote: Now, I wouldn't say that we can never include new functions that are not yet specified in the standard, since we still need to continue to push the envelope and add innovative functionality even if that requires extending the ODF format

Re: [Libreoffice] Calc : add carriage return via Ctrl+Enter in the Formula bar

2011-12-09 Thread Kohei Yoshida
in this code is very well let's say interesting. Either way you should sync with him to see where we are currently. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limitsint::min

2011-12-12 Thread Kohei Yoshida
would've thought that, if nExp 0 is true, -nExp 0 is automatically true. Anyway, if you have a code snippet that can make this code to segfault, that would help me understand this better. Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] [PATCH] fix for crash in math.cxx for std::numeric_limitsint::min

2011-12-13 Thread Kohei Yoshida
in this specific moment. As Staphan suggested, some clarifying comment would make it a little less surprising for the occasional unsuspecting visitors. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice

[Libreoffice] make dev-install hangs

2011-12-13 Thread Kohei Yoshida
StaticLibrary/libvclmain.a [ WARN ] !!! I didn't have this problem at yesterday's clean build make dev-install combo. Does it ring a bell to anyone? Regards, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list

Re: [Libreoffice] make dev-install hangs

2011-12-13 Thread Kohei Yoshida
On Tue, 2011-12-13 at 15:46 +0100, Tomáš Chvátal wrote: From what I could see it is not hung. It just does something for quite long. Indeed. It took 6 minutes on my machine for make dev-install to finish, but it did finish eventually. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] [Patch] [Review 3.5 - Late Feature] Improved copying between different calc documents

2012-01-04 Thread Kohei Yoshida
On Wed, 2012-01-04 at 12:33 -0500, Kohei Yoshida wrote: On Wed, 2012-01-04 at 17:04 +0100, Markus Mohrhard wrote: I propose this patch as a late feature. Just as a matter of record, I have already provided some feedback in his proposed patch on IRC. As far as the behavior goes, you

Re: [Libreoffice] [Patch] [Review 3.5 - Late Feature] Improved copying between different calc documents

2012-01-04 Thread Kohei Yoshida
On Wed, 2012-01-04 at 13:44 -0500, Kohei Yoshida wrote: On Wed, 2012-01-04 at 12:33 -0500, Kohei Yoshida wrote: As far as the behavior goes, you have my approval. Actually I take that back. There are some weird behaviors that I don't like. I'm playing with it right now using the master

[Libreoffice] Problem building the 3.5 branch on Windows, postgresql related.

2012-01-04 Thread Kohei Yoshida
Hi there, I'm having trouble building the latest 3.5 branch on Windows. First, the postgresql module failed to build due to it not finding ldap.h from mozilla. I had mozilla entirely disabled (I always had). So I decided to enable it to see if it would solve this. But because I didn't want to

Re: [Libreoffice] Problem building the 3.5 branch on Windows, postgresql related.

2012-01-05 Thread Kohei Yoshida
Hi Kendy, On Thu, Jan 5, 2012 at 5:14 AM, Jan Holesovsky ke...@suse.cz wrote: On 2012-01-05 at 02:28 -0500, Kohei Yoshida wrote: I'm having trouble building the latest 3.5 branch on Windows.  First, the postgresql module failed to build due to it not finding ldap.h from mozilla.  I had

Re: [Libreoffice] limiting maximum sheet number to 10000 in 32 bit builds

2012-01-06 Thread Kohei Yoshida
more feedback later on. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] limiting maximum sheet number to 10000 in 32 bit builds

2012-01-06 Thread Kohei Yoshida
even on a lower spec machine. I'll look into this, since Markus is heavily loaded with other stuff at the moment. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] [REVIEW] Problem with data - form dialog in Calc

2012-01-06 Thread Kohei Yoshida
to do with your patch) where the code assumed that the data range always starts at row 1. I fixed that as well. I've pushed your patch and my follow-up change to both the 3.5 branch and master (since we are still before the string freeze). Kohei -- Kohei Yoshida, LibreOffice hacker, Calc

Re: [Libreoffice] [PUSHED] [REVIEW] Problem with data - form dialog in Calc

2012-01-06 Thread Kohei Yoshida
Setting PUSHED tag. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [REVIEW] Problem with data - form dialog in Calc

2012-01-06 Thread Kohei Yoshida
Setting PUSHED tag to this duplicate as well. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] limiting maximum sheet number to 10000 in 32 bit builds

2012-01-06 Thread Kohei Yoshida
On Fri, 2012-01-06 at 09:53 -0500, Kohei Yoshida wrote: I'll look into this, Done. Now the upper limit is set to 1024 in the Options dialog. http://cgit.freedesktop.org/libreoffice/core/commit/?id=a687d554774eba1c4bf5a4825e8730cb0114bd3c (cherry-picked to the -3-5 branch as well

Re: [Libreoffice] [REVIEW] fix for fdo#44442, crash in ScInterpreter::GetDBParam with specific document

2012-01-07 Thread Kohei Yoshida
Hi Markus, On Sat, Jan 7, 2012 at 10:40 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: I think it is a simple patch fixing a crash and should be pushed to 3-4. Simple and makes sense. You have my approval. Kohei ___ LibreOffice mailing

Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#44442, crash in ScInterpreter::GetDBParam with specific document

2012-01-08 Thread Kohei Yoshida
On Sat, Jan 7, 2012 at 11:44 PM, Kohei Yoshida kohei.yosh...@gmail.com wrote: Hi Markus, On Sat, Jan 7, 2012 at 10:40 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: I think it is a simple patch fixing a crash and should be pushed to 3-4. Simple and makes sense.  You have my

Re: [Libreoffice] [PATCH] fdo#44616 - webkit won't render frames of table borders of Calc/HTML

2012-01-10 Thread Kohei Yoshida
the Beta3 is already tagged, the fix will be in the one after Beta3, which will probably be RC1? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] [PATCH] [PUSHED] fdo#44616 - webkit won't render frames of table borders of Calc/HTML

2012-01-10 Thread Kohei Yoshida
PUSHED -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

<    1   2   3   4   5   6   7   8   9   10   >