ead of decrease compared to y coordinate of M
plain: M (250, 443), N (542, 559)-> the delta in x is 292 compared
to 161 in the rotated case, which is too small.
Armin, do you have a code pointer for me, where these numbers are
calculated?
Regards,
Christina
Am 29.10.2017 um 13:40 schrieb Chr
Hi,
I'm having a look at bug tdf96324. The problem is that when exporting an
ODG to SVG the subscript 'N' from a rotated axis label isn't visible in
the exported SVG. It is exported but with coordinates which are way off.
As far as I understand the ODG document is converted to a metafile and
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
for quite a while I have the following problem:
branch: master
./g pull -r
make fails in postprocess/qa/services.cxx with error message:
services.cxx:231:Assertion
Test name: (anonymous namespace)::Test::test
forced failure
- - creating
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
opening homenet.svg (attached to the bug) shows the circles without a
filling but filled circles would be correct. The reason (I guess) is
that each circle is represented as 4 bezier curves which make it a
manually closed polygon but not a closed
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 30.04.2014 22:22, schrieb julien2412:
Hello,
Reading bugtrackers about SVG, I noticed there were 2 locations
with svgreader: - filter/source/svg/svgreader.cxx
This is used for File-Open and then choosing the svg file.
- svgio/source/svgreader
Hi Laurent,
thank you for your patch! It has been merged to LibreOffice.
Christina
On 14/09/13 15:54, Laurent BP wrote:
Hello,
Here is a patch to translate German comments on the file I'm working on.
0001-fdo-39468-Translate-German-comments-in-itemwin.cxx.patch
Hi,
the problem described here -
https://bugs.freedesktop.org/show_bug.cgi?id=64125 is caused by a
missing width and height attribute of the SVG given as an example. So,
what would we expect given a ViewBox attribute when importing a graphic?
What I'd expect is that the aspect ratio is kept
Hi,
commit abb6f47bd3941ec63a41a9b9fa4c7de620b5177d causes the crash when
saving as ppt (see bug description). I'm having a look at it but I'm not
sure if I can figure out what is going wrong.
Christina
___
LibreOffice mailing list
Hi,
some questions arise during git bisect:
1. Will each build get an unique build id? Is this id related to the
most recent commit?
2. Does make tail_build.clean; make tail_build require make
dev-install afterwards?
3. Do get a faster build: How can I get rid of slowcheck?
Christina
Hi,
I've completed my first bibisect successfully. Now I have a range of
commits to have a closer look at. I thought to create a branch
reflecting the last good point and cherry-pick commits to see when the
bug occurs again. But that branch does not build, it fails somewhere in
libxmlsec so
Hi,
if you add text (e.g. abc) to a shape like a smiley, save the
document, delete the text and save again the text is still present in
the saved file. Closing the drawing isn't necessary.
If you don't save the drawing after adding the text but delete the text
and save the drawing
Hi,
GetTextBreak() returns STRING_LENGTH if text breaking isn't necessary
(if I get it right). indexOf() returns -1 if searching failed. Would
that be a choice for GetTextBreak() as well? What would be a useful
return value? sal_Int16, sal_Int32? In GenericSalLayout int is chosen as
return
Please ignore this one. https://gerrit.libreoffice.org/#/c/2229/ is the
one I'd like to get reviewed.
Christina
Am 01.03.2013 21:55, schrieb Christina Roßmanith (via Code Review):
Hello LibreOffice gerrit bot, Norbert Thiebaud,
I'd like you to reexamine a change. Please visit
https
Hi,
when changing (Xub)String to OUString I came across a strange for-loop.
You find it at the end of the quotation. I've kept some context...
(continue below the quotation)
diff --git a/vcl/source/control/field.cxx b/vcl/source/control/field.cxx
index 387acea..e632b4a 100644
---
Hi Eike,
Am 06.02.2013 13:38, schrieb Eike Rathke:
Hi Christina,
On Wednesday, 2013-02-06 12:36:33 +0100, Christina Roßmanith wrote:
-for (xub_StrLen i = (xub_StrLen)(aStr.Len()-1); i 0; i++ )
+for (sal_Int32 i = aStr.getLength()-1; i 0; i
Hi,
I had a look at cui/source/tabpages/tpline.cxx and found two identical
blocks in
sal_Bool SvxLineTabPage::FillItemSet( SfxItemSet rAttrs ) around lines
767 and 871. Could someone confirm (and maybe explain) that this is
intentional.
And code like if( nDlgType != 0 || nPageType != 3 ) is
Hi,
during RTL_CONSTASCII... cleaning I came across this lines in
vcl/source/filter/igif/gifread.cxx:
if( (aAppId == NETSCAPE) (aAppCode == 2.0) (cSize == 3) )...
Will this condition ever be true?
Christina
___
LibreOffice mailing list
Hi,
there is some progress in svg:linearGradient import. But that gradient
type is more flexible than the existing draw:gradient.
That rises the question: Should I extend the existing data structure or
add a SvgGradient data structure?
Christina Rossmanith
Am 17.09.2012 09:04, schrieb Fridrich Strba:
Hello, Christina,
On 14/09/12 22:12, Christina Roßmanith wrote:
1. Created by LibreOffice (create rectangle in Draw, fill with a blue to
green gradient, save as fodg)
draw:gradient draw:name=Gradient_20_7 draw:display-name=Gradient 7
draw:style
Hi,
I'll have a look at gradients again. Could someone please have a look at
the following two gradient specifications and tell me if they are
supposed to look the same:
1. Created by LibreOffice (create rectangle in Draw, fill with a blue to
green gradient, save as fodg)
draw:gradient
Hi Regina,
to make sure we are talking about the same page borders: there are
slightly thicker lines in normal view indicating what is printed on a
page. But they appear only after print preview for a sheet was executed.
If the bug reporter confirmes that print preview works for him I'll
Hi,
I had a look at fdo52327 and have some questions:
1. Should page preview trigger the calculation of page borders?
2. If so, should it be a trigger for the current sheet only or for all
sheets?
Christina Rossmanith
___
Libreoffice-ux-advise
Hi,
obviously I'm working with gradients at the moment :-) and I'm in
need of a code pointer again.
I've created a rectangle in Draw (manually - no svg import this time),
filled it with a linear gradient with a constant 50% opacity and saved
the file as fodg. Then I saw that opacity is
Hi,
just to be sure before I continue my work:
SVG gradient with angle=0° changes color from left to right
(I'm taking this from
http://www.w3.org/TR/SVG/pservers.html#LinearGradientElement)
ODF gradient with angle=0° changes color from top to bottom
(I can't find any meaning of
Am 29.07.2012 18:25, schrieb Regina Henschel:
Hi Christina,
I'm not sure about what you want to know.
Christina Roßmanith schrieb:
Hi,
just to be sure before I continue my work:
SVG gradient with angle=0° changes color from left to right
(I'm taking this from
http://www.w3.org/TR/SVG
Hi,
a gradient angle given without a unith should be interpreted as degrees,
but in my example a value of draw:angle=90 shows up in LibO as 9
degrees. If I change it to draw:angle=90deg the value is read correctly.
Thus the question is: Where do I have to look to fix it?
Thank you for any
Hi,
finally a patch is ready for handling of dashes. I've removed all
polygon emulation stuff. Svg has a more flexible way to define dashes.
1. ODF only permits one constant distance between dashes. Currently the
average of all distances is taken.
2. The svg dash array is parsed up to the
Am 13.06.2012 19:57, schrieb Tom Tromey:
Michael == Michael Meeksmichael.me...@suse.com writes:
Michael #2 0xb784d6f1 in SfxFrame::Create (i_rFrame=warning: RTTI symbol not
Michael found for class 'framework::Frame'
Michael warning: RTTI symbol not found for class 'framework::Frame'
Hi,
there is simian. Quoted from the wiki:
A good copy and paste detector is [http://www.harukizaemon.com/simian/
Simian].
The use is free for non-commercial projects. To get a space separated
list of
.cxx files in a directory, run:
find directory -name *.cxx | grep -v unxlng | tr '\n' ' '
Hi,
in a svg path H 40.5.6 should be parsed in the same way as H 40.5 .6
commit bef8e358b6940fd4a976cb346dfd829643e581b8 makes the double parser
stop if a second separator '.' is seen. Furthermore the test wether we
are on a number returns 'true' for a '.' that parsing starts even
without a
Hi,
I've made clean and still can't build LibO (error messages see below).
Any idea what might be my problem? Tinderboxes are green, so master
should be buildable?!?
Christina
home/cr/Software/LibO3/core/workdir/unxlngx6.pro/CxxObject/vcl/generic/print/printerjob.o:
In function
Hi,
I've changed lcl_importNumberAndSpaces to lcl_importFlagAndSpaces
because it is only used to import flags (single digit). Values != 0 or
=! 1 return false as does a '-'. Now missing white space between flags
isn't a problem any longer.
commit 508fcf698ec7cd97af1eb8936ab30b257143bc1b
Hi,
commit 79a6e40e6f19a896dbc25640deb3d4507eddad95 clamps FillOpacity to 1
and
commit 7c11471666f92e9dfecbec23ebe73bcb0177a963 enables parsing of
percent color specifications like rgb(50%,20%,10%)
Christina
___
LibreOffice mailing list
Oops, that's my fault...easiest would be to remove SAL_INFO (I've
introduced it during debugging). I could do this during my next code
cleaning step. Would that be ok?
Christina
Am 08.05.2012 11:31, schrieb julien2412:
Hello,
I've got a WaE in master sources with the file
Hi,
what influence is anisotropic scaling supposed to have on stroke-width?
Given a line
g transform=translate(60,-30) scale(8,2)
path d=M 20 40 H 40 stroke-width=4 stroke=black /
/g
Currently stroke-width in this example get scaled to 8*4=32 which seems
to be incorrect to me. If it gets
Then let's bury ShapeRenderingVisitor as well...(already commited locally)
Christina
Am 03.05.2012 11:40, schrieb Thorsten Behrens:
Christina Roßmanith wrote:
@Thorsten: The method importSVG which calls the
ShapeRenderingVisitor is used for magic file type detection?
Hi Christina,
nah
Hi,
consider the following SVG example:
svgtexttspanq/tspan/text/svg
which is rendered blank instead of showing the letter 'q'.
tspan prevents q being added to sText here (svgreader.cxx):
visitChildren(boost::bind(
(rtl::OUStringBuffer
Hi,
what influence does a scale
g transform=scale(sx,sy) textfoo/text /g
have on font size of foo if sx!=sy?
(I'm close to render coords-trans-03-t.svg as expected :-) )
Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
...because the text style gets some properties added after style id
lookup. That leads to a stroke=none and fill=none style for a
rectangle following a text element with identical style.
With this patch the rectangle gets its own styleid and is rendered
correctly :-)
This is another step
Hi,
in createPolygonFromRect the interval [0,1] is scaled to
[width/2,height/2]. Hence rx and ry have to be divided by width/2 and
height/2 respectively - I totally agree with Marco (cf. Re:
svgreader.cxx: XML_RECT question).
The attached rounded_rect.svg tests the case that rx=width/2 and
Hi,
text without attributes is displayed now.
Christina
From 6eb292d4c3e64f686b4d6c9ad43ae101228e6941 Mon Sep 17 00:00:00 2001
From: Chr. Rossmanith chr.rossman...@gmx.de
Date: Sat, 28 Apr 2012 20:36:54 +0200
Subject: [PATCH] enable rendering of text without any attributes
---
Hi,
there are two case XML_RECT blocks in svgreader.cxx in two different
visitors. The ShapeWritingVisitor scales rx and ry with width and
height, the ShapeRenderingVisitor does not apply any scaling. I guess
both visitors should treat rx and ry the same way?
Christina
That hint helped :-) Now text without any attributes is rendered as well.
Christina
Am 25.04.2012 13:23, schrieb Marco Cecchetti:
After giving a better look, I could have found where the problem is:
look at the begin of visitElements routine (line 101):
if( xElem-hasAttributes() )
Hi,
an easyhack, to get a feeling of success while trying to understand
import of SVGs.
Christina
From 5b90ab4c0053c09bbd49f1bf3024d70cfb32af6e Mon Sep 17 00:00:00 2001
From: Chr. Rossmanith chr.rossman...@gmx.de
Date: Tue, 24 Apr 2012 20:09:33 +0200
Subject: [PATCH] Removed unused methods
Hi,
I've created a small svg sample file just containing some text. If I
remove the x and y attribute this has influence on the value of the
internal-style-ref attribute. Maybe this is a hint where some problems
might have their origin.
To get a better understanding:
What is the intent of
Hi,
could
throw RuntimeException(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(XListener is not
equal to 1))...
be written as
throw RuntimeException(XListener is not equal to 1,...
?
Christina
Am 11.04.2012 21:20, schrieb Abeer Sethi:
I'm attaching the patch for namecont.cxx, I hope this is
Hi,
after replacing string data types I looked for duplicated code in vcl
with simian. Could someone please review it? It builds successfully but
I'm unsure about where to use const...
Thank you,
Christina
From 94b9a014e07133fef3f7432d4d6945cd76e66d4d Mon Sep 17 00:00:00 2001
From: Christina
Hi,
after removing all redundant #defines from file.hxx (last change not yet
pushed - build is going on) I had a look at the enum RC. At a first
glance it seems that e.g. E_None is used only in pyuno_module.cxx (and
in some comments in file.hxx) and could be replaced by the value
Pushed.
Christina
Am 13.04.2011 22:19, schrieb Christina Roßmanith:
Build was fine. I'll push on next Tuesday because there is no time
slot for LO earlier.
Christina
Am 12.04.2011 22:03, schrieb Christina Roßmanith:
Am 11.04.2011 23:30, schrieb Michaël Lefèvre:
Actually, this was part
I've made the changes and pushed them.
Christina
Am 12.04.2011 11:20, schrieb Noel Power:
Hi Christina
On 09/04/11 22:08, Christina Roßmanith wrote:
[...]
So I'll remove the definition of PRE_CONDITION and POST_CONDITION and
replace the latter with OSL_POSTCOND (the former isn't used). ENSURE
Build was fine. I'll push on next Tuesday because there is no time slot
for LO earlier.
Christina
Am 12.04.2011 22:03, schrieb Christina Roßmanith:
Am 11.04.2011 23:30, schrieb Michaël Lefèvre:
Actually, this was part of the easy hack hunt and destroy obsolete
macros. As I have very little
_USE_UNO: I thought, that I had removed everything #ifdef'ed with
_USE_UNO. BUT I've found some occurences in ./basic. Is there a way to
search for all commits I've done so far? I'll finish that, of course!
Christina
Am 12.04.2011 10:49, schrieb Noel Power:
On 11/04/11 15:55, Thorsten
Removed last occurences of _USE_UNO, built successfully and pushed.
Christina
Am 12.04.2011 10:49, schrieb Noel Power:
On 11/04/11 15:55, Thorsten Behrens wrote:
Noel Power wrote:
As far as I understand the code it consists merely of test calls
to functions in order to see if they return a
Am 11.04.2011 23:30, schrieb Michaël Lefèvre:
Actually, this was part of the easy hack hunt and destroy obsolete
macros. As I have very little time (2h/week) to join the fun, and
taking some vacation for a month, I didn't apply to this on the
wiki. To any one, fill free to complete the task.
Hi Julien,
I forgot to search in the whole code tree. Could you please push your
additional changes?
Thank you,
Christina
Am 10.04.2011 22:55, schrieb Julien Nabet:
Hello Christina,
Compilation failed in padmin (even after a make -r clean make -sr).
So here is a simple patch to validate.
Hi,
in docholder.cxx in DocumentHolder::FreeOffice most of the code is
commented out with a remark
// the following code is commented out since for now there is
still no completely correct way to detect
// whether the office can be terminated, so it is better to
have
Finished and pushed. Next step: remove duplicates from vclenum.h and add
#include fontenum.h from tools?
Christina
Am 08.04.2011 17:37, schrieb Caolán McNamara:
On Wed, 2011-04-06 at 22:11 +0200, Christina Roßmanith wrote:
Hi Caolan,
I've continued to remove psp::weight::type. At the end
Am 05.04.2011 10:50, schrieb Noel Power:
Hi Christina
\On 05/04/11 09:11, Christina Roßmanith wrote:
Hi,
after removal of comments it becomes clear that DbgAssert() is empty.
It is used for the definition of PRE_CONDITION (unused),
POST_CONDITION (used in classfactory.cxx and propertyhdl.cxx
?
And what about the FW_NORMAL, FW_BLACK etc. from sft.h? Shall they be
replaced as well?
Christina
Am 05.04.2011 21:18, schrieb Caolán McNamara:
On Tue, 2011-04-05 at 21:01 +0200, Christina Roßmanith wrote:
removed some methods ToFontWidth() which aren't needed anymore.
Yup, looks good
Hi Anurag,
this patch was fine. I've additionally removed some lines you've missed.
And skipped this deletion:
-sal_uInt32 exportDoc(enum ::xmloff::token::XMLTokenEnum /*eClass*/)
{return 0;}
+sal_uInt32 exportDoc(enum ::xmloff::token::XMLTokenEnum) {return 0;}
Pushed!
Christina
Hi,
after removal of comments it becomes clear that DbgAssert() is empty. It
is used for the definition of PRE_CONDITION (unused), POST_CONDITION
(used in classfactory.cxx and propertyhdl.cxx) and ENSURE (used at
several places).
I think PRE_CONDITION, POST_CONDITION and ENSURE can be
shell part pushed.
Christina
Am 20.03.2011 00:52, schrieb Xisco Faulí:
Here we go with the first round of patches.
Whitespaces are not deleted anymore and all the bogus have been
deleted. Everything builds allright.
Part 1 --
by the compiler.
If someone could please review this patch. If it is fine I'll go on.
Would you recommend a huge push at the end of this work or one for each
removed enum?
Christina
Am 05.04.2011 11:57, schrieb Caolán McNamara:
On Mon, 2011-04-04 at 23:18 +0200, Christina Roßmanith wrote:
As far
Pushed the linguistic part.
Christina
Am 20.03.2011 00:52, schrieb Xisco Faulí:
Here we go with the first round of patches.
Whitespaces are not deleted anymore and all the bogus have been
deleted. Everything builds allright.
Part 1 --
Hi,
I need some more information for the easy hack expunge duplicate
enumerations in vcl. For ultra condensed font width there are three
places with different names:
psp::width::UltraCondensed (fontmanager.hxx)
FWIDTH_ULTRA_CONDENSED (sft.hxx) and
WIDTH_ULTRA_CONDENSED (vclenum.hxx)
and if
Hi Julien,
I've executed the modified strip-guards script in the clone directory,
not in a module subdirectory. Afterwards your pcregrep command (see
below in your first message) only found two guards not stripped:
clone/ure/jurt/test/com/sun/star/lib/uno/protocols/urp/interfaces.idl:#ifndef
Hi,
is anybody else having trouble to compile osl_old_test_file.cxx? I have
to comment out lines 133 and 263, then everything is fine:
133: CPPUNIT_ASSERT_MESSAGE(failure #1.1, target.equalsAscii(
aSource1[i+1] ) );
263: CPPUNIT_ASSERT_MESSAGE(failure #10.1, target.equalsAscii(
Hi,
I found that HID_STATUSBAR is #defined as 1212 in
sw/source/ui/inc/hidfunc.h and #defined as SW_HID_STATUSBAR in
sw/inc/helpid.h
Strange - but hidfunc.h never seems to be included. Could someone please
check this? I've grok'ed and ./g grep'ed with no result.
How can a file be removed
Hi,
pushed the framework part. Again a lot of files changed their place so
it was quite a lot of work to apply the patch. Additionally I removed
lots of dates, comments above removed commented methods, {} not needed
anymore after the if () has gone and changed
if ( bState = sal_True) to if
are not deleted anymore and all the bogus have been
deleted. Everything builds allright.
Part 1 --
http://dl.dropbox.com/u/1274885/removed-commented-code-part1.tar.gz
I'll post the second part soon
Greetings
2011/3/18 Christina Roßmanith chrrossman...@web.de
mailto:chrrossman...@web.de
Hi,
there are some places where _USE_UNO is #defined and some lines later it
is queried via #ifdef. It seems that _USE_UNO could be removed in that
context.
Veto or go?
Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Sorry,
Please move my last e-mail to /dev/null...only .idl files were changed
Christina
Am 27.03.2011 00:20, schrieb Julien Nabet:
Hello,
Concerning the easyhack Strip include guards in idl files, I pushed
2 patches for the directory ure/udkapi.
For the first patch I only used the
Hi,
I've continued code cleanup and removed #ifdef'ed blocks because
_ENABLE_CUR_DIR is never #defined.
Christina
From 81a17913da2c94e0cde5c14f4de933de1913b04c Mon Sep 17 00:00:00 2001
From: Christina Rossmanith chrrossman...@web.de
Date: Tue, 22 Mar 2011 19:26:46 +0100
Subject: [PATCH]
Hi,
I think it should read some packagers may wish (instead of with) to
build without. and template (instead of temaplte). Is configure built
from configure.in? Or where should the modification be made?
Christina
___
LibreOffice mailing list
Am 21.03.2011 18:10, schrieb Michael Meeks:
On Mon, 2011-03-21 at 13:44 +0100, Christina Roßmanith wrote:
I've removed all blocks of code #ifdef'ed by _OLD_FILE_IMPL because it
was never defined. It builds successfully. Could someone please review
to make sure that nothing was deleted
Am 21.03.2011 18:10, schrieb Michael Meeks:
On Mon, 2011-03-21 at 13:44 +0100, Christina Roßmanith wrote:
I've removed all blocks of code #ifdef'ed by _OLD_FILE_IMPL because it
was never defined. It builds successfully. Could someone please review
to make sure that nothing was deleted
Hi,
I did a ./g pull -r yesterday (Saturday). After applying patches I'd
like to build basic. It fails with
/bin/bash: /Amanda/LibreOffice3/libo/solver/300/unxlngi6.pro/bin/rscdep:
No such file or directory
The error message is correct, but instead there is
Hi,
during removal of comments it became obvious that
SwItemPropertySet::FillItem always returns sal_FALSE. Further searching
for SwItemPropertySet with grok only finds it in unomap.hxx and
unomap.cxx, ./g grep additionally finds it in binfilter. Does binfilter
use the binfilter definition
Hi,
I've edited parhtml.cxx in ./svtools and now I'd like to test if the
modification fixes bug 34666. What do I have to do? Is a partial build
in directory ./svtools enough? Or is there some install-step needed?
Or do I have to do a toplevel make?
Christina Rossmanith
Hi,
I've pushed your patch with minor modifications (some typos, some
translations changed the meaning of the German comment).
Thank you for your contribution!
Christina Rossmanith
Am 14.03.2011 20:35, schrieb Albert Thuswaldner:
Hi,
Now I have fixed the patch.
You can commit the patch
Hi,
I've removed the unused constant PORTIONKIND_EXTRASPACE, built editeng
successfully and pushed the patch by myself.
Christina Rossmanith
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Am 10.03.2011 19:24, schrieb Nicolas Christener:
Hi all
This translates the remaining german code comments in /sc/inc and
removes some IMHO unused comments like
// [...]
The changes are commited per file to avoid a single large patch which is
probably a pain to
Hi,
can I treat .src files like .cxx or .hxx files and remove commented code?
Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi,
I thought, I could start replacing some BOOL by bool. But when I started
to edit docuno.{hxx,cxx} I saw that there is not only BOOL and bool but
also sal_Bool. When do I use which of the boolean types?
Christina Rossmanith
___
LibreOffice
Yes - 0001 - 0003 are pushed as I wrote yesterday. I'll continue as time
permits.
Christina Rossmanith
Am 11.03.2011 17:20, schrieb Kayo Hamid:
just to remember: some patchs translating german comments to english
are not pushed, 0044 is one and we have others inside this list of
patchs.
Pushed up to 0011
Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi,
I've pushed patch 1-3. Patch 4 only removes structuring
//--- lines. I'm not sure if this is wanted. Maybe
someone of the experts can comment on this? Then I'll go on with reviewing.
Thank you for your contribution!
Christina Rossmanith
Am 10.03.2011 19:24, schrieb
Hi,
I've applied your monster patch locally, waiting for a complete build
before pushing it. Please break you patches in smaller parts in the
future (c.f.
http://wiki.documentfoundation.org/Development/Patch_Handling_Guideline)
Thank you,
Christina Rossmanith
Am 03.03.2011 03:10, schrieb
Hi David,
I'm reviewing the patch. You should keep bugids like #i12345# (see the
developers wiki - easy hacks - translation of German comments - there
you find some details about bugids) and keep comments belonging to
bugids. That is what I can tell so far...
But nevertheless: Thank you for
Pushed partially modified (a few bugids were found inside a sentence -
modified those that they are still complete meaningful sentences without
the bugid / found some additional bugids and removed them as well).
Thank you,
Christina Rossmanith
Am 28.02.2011 00:05, schrieb Guillaume Poussel:
Hi Guillaume,
partly pushed - only waiting for an information how to handle #n123456#
bugids (i.e. ~1% not yet pushed). Thank you.
Christina Rossmanith
Am 28.02.2011 00:06, schrieb Guillaume Poussel:
And then, the same job in calc (3/3)
Hi,
Please find attached 2 patches in base/ which
Sorry - forgot the [PUSHED] tag.
Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Pushed - thank you.
Christina Rossmanith
Am 28.02.2011 00:06, schrieb Guillaume Poussel:
And then, the same job in calc (2/3)
Hi,
Please find attached 2 patches in base/ which clean useless comments up.
Regards,
Guillaume
(still under LGPLv3+/MPL)
To summarize:
Andras isn't interested in keeping the comments.
Christian could tell the meaning of '~'.
Nobody votes for keeping the ACHTUNG/ATTENTION comments. So I conclude,
we can start to remove them. I guess they aren't of any help if gettext
might be used someday?!?
Christina
Am
Hi,
reviewed and pushed. Changed your translation of Textbaustein = text
block to auto text because I think that is what LibreOffice uses as term.
Christina
Am 27.02.2011 21:21, schrieb Martin Kepplinger:
Hi,
This translates all german code comments in writer/sw/source/ui/dochdl to
low-level explanation :-)
Christina
Am 27.02.2011 10:27, schrieb Andras Timar:
Hi,
2011/2/25 Caolán McNamaracaol...@redhat.com:
On Fri, 2011-02-25 at 20:37 +0100, Christina Roßmanith wrote:
timar: po files can have translator-comments in them to help translators
about ambiguous terms/words
Hi,
I've removed BMP_FEHLT in two files. Build was successful.
Christina Rossmanith
From 83e4b188a4655bf55c43161ca1501917b4bb44a1 Mon Sep 17 00:00:00 2001
From: Christina Rossmanith chrrossman...@web.de
Date: Fri, 25 Feb 2011 18:19:26 +0100
Subject: [PATCH] removed BMP_FEHLT
---
Commented it first, then treated it as commented code, removed it and
interpreted Thomas Arnold's reply Why don't you commit this by your
self? as the license to push it on my own...any objections :-)
Christina
Am 25.02.2011 18:21, schrieb Christina Roßmanith:
Hi,
I've removed BMP_FEHLT
Pushed - thank you.
Christina
Am 25.02.2011 11:18, schrieb Martin Kepplinger:
This translates all code comments in this directory from german to english.
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
thanks,
martin
---
Hi,
while reviewing a patch I came across a lot of comments like
CheckBox CB_USE_PASSWD
{
/* ### ATTENTION: New text in resource? ~password : ~password */
Text [ en-US ] = ~Password ;
};
String STR_LINKEDIT_TEXT
{
/* ### ATTENTION: New text in resource? edit links : edit links */
1 - 100 of 156 matches
Mail list logo
