Re: [PATCH v3 1/4] migration: migrate 'inc' command option is deprecated.

2023-10-12 Thread Markus Armbruster
Juan Quintela writes: > Set the 'block_incremental' migration parameter to 'true' instead. > > Reviewed-by: Thomas Huth > Signed-off-by: Juan Quintela > --- > docs/about/deprecated.rst | 7 +++ > qapi/migration.json | 12 ++-- > migration/migration.c | 6 ++ > 3

Re: [PATCH v3 3/4] migration: Deprecate block migration

2023-10-12 Thread Markus Armbruster
Juan Quintela writes: > It is obsolete. It is better to use driver-mirror with NBD instead. drive-mirror Several more below. > > CC: Kevin Wolf > CC: Eric Blake > CC: Stefan Hajnoczi > CC: Hanna Czenczek > > Signed-off-by: Juan Quintela > --- > docs/about/deprecated.rst | 10 ++

Re: [PATCH v3 3/4] migration: Deprecate block migration

2023-10-12 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> It is obsolete. It is better to use driver-mirror with NBD instead. > > drive-mirror > > Several more below. Done. >> +# Features: >> +# >> +# @deprecated: @disk migration is deprecated. Use driver-mirror >> +# with NBD instead. >> +#

[PATCH 3/7] virDomainDiskTranslateSourcePool: Don't re-translate already translated defs

2023-10-12 Thread Peter Krempa
If a disk definition was already translated re-doing it makes no sense. Skip the translation if the 'actualtype' is already populated. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c

Re: [PATCH v3 1/4] migration: migrate 'inc' command option is deprecated.

2023-10-12 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Set the 'block_incremental' migration parameter to 'true' instead. >> >> # @blk: do block migration (full disk copy) >> # >> -# @inc: incremental disk copy migration >> +# @inc: incremental disk copy migration. This option is deprecated.

Re: [PATCH v3 4/4] migration: Deprecate old compression method

2023-10-12 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> -# @deprecated: @disk migration is deprecated. Use driver-mirror >> -# with NBD instead. >> +# @deprecated: @disk migration is deprecated. Use driver-mirror with >> +# NBD instead. @compression is unreliable and untested. It is >>

Re: [PATCH v3 4/4] migration: Deprecate old compression method

2023-10-12 Thread Markus Armbruster
Juan Quintela writes: > Signed-off-by: Juan Quintela > Acked-by: Peter Xu > --- > docs/about/deprecated.rst | 8 +++ > qapi/migration.json | 102 -- > migration/options.c | 13 + > 3 files changed, 86 insertions(+), 37 deletions(-) > >

[PATCH 7/7] security: apparmor: Use translated disk definitions for disk type=volume

2023-10-12 Thread Peter Krempa
The 'virt-aa-helper' process gets a XML of the VM it needs to create a profile for. For a disk type='volume' this XML contained only the pool and volume name. The 'virt-aa-helper' needs a local path though for anything it needs to label. This means that we'd either need to invoke connection to

Re: [PATCH v3 3/4] migration: Deprecate block migration

2023-10-12 Thread Kevin Wolf
Am 12.10.2023 um 12:01 hat Markus Armbruster geschrieben: > Juan Quintela writes: > > > It is obsolete. It is better to use driver-mirror with NBD instead. > > drive-mirror > > Several more below. Actually, blockdev-mirror, please. We don't want to move people from the oldest way to the next

[PATCH 5/7] qemustatusxml2xmltest: Demonstrate use of VIR_DOMAIN_DEF_(PARSE|FORMAT)_VOLUME_TRANSLATED

2023-10-12 Thread Peter Krempa
Enable the flags in the status xml2xmtest and add an exaple to the test data. Signed-off-by: Peter Krempa --- tests/qemustatusxml2xmldata/modern-in.xml | 4 ++-- tests/qemustatusxml2xmltest.c | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH 0/7] qemu: Fix two pool-translation related bugs

2023-10-12 Thread Peter Krempa
Fix following problems: - fix disk type='volume' disks resolving to local images on apparmor-protected hosts - VMs are killed if pool is not available after libvirtd/virtqemud restart The first one will be annoying for users of Cockpit on apparmor based boxes. NOTE: I didn't test it though as

[PATCH 4/7] qemu: domain: Allow preserving translated disk type='volume' data into XML if needed

2023-10-12 Thread Peter Krempa
Re-translating a disk type='volume' definition from a storage pool is not a good idea in cases when the volume might have changed or we might not have access to the storage driver. Specific cases are if a storage pool is not activated on daemon restart, then re-connecting to a VM fails, or if the

[PATCH 6/7] conf: Save translated disk definition for disk type='volume' to status XML

2023-10-12 Thread Peter Krempa
Re-translating the disk source pools when reconnecting to a VM makes no sense as the volume might have changed or pool became inactive. The VM still uses the original volume though. Failing to re-translate the pool also causes the VM to be killed. Fix this by storing the original translation in

[PATCH 1/7] virStorageSourcePoolDef: Turn 'mode' member into proper enum type

2023-10-12 Thread Peter Krempa
Use proper enum type and refactor the formatter accordingly. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 12 src/conf/storage_source_conf.h | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

[PATCH 2/7] virDomainDiskSourcePoolDefParse: Refactor cleanup

2023-10-12 Thread Peter Krempa
Register autoptr cleanup function for virStorageSourcePoolDef and refactor the parser to simplify the logic. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 35 +++--- src/conf/storage_source_conf.h | 1 + 2 files changed, 12 insertions(+), 24

[libvirt PATCH] hypervisor: Move interface mgmt methods to hypervisor

2023-10-12 Thread Praveen K Paladugu
Move guest interface management methods from qemu to hypervisor. These methods will be shared by networking support in ch driver. Signed-off-by: Praveen K Paladugu --- po/POTFILES | 1 + src/hypervisor/domain_interface.c | 279 ++