Reviewers: ,
Message:
Please review.
Description:
Add documentation for the music function \alterBroken to the NR.
Issue 3458: Document \alterBroken
Please review this at https://codereview.appspot.com/15060044/
Affected files (+104, -0 lines):
On 2013/10/06 06:06:40, lemzwerg wrote:
LGTM.
Maybe you can somewhere add a sentence like
Note that \tweak and friends provide absolute positioning, not
relative.
to the documentation. It took me a while to recognize the difference.
OK--will do. (I just made some changes to the
https://codereview.appspot.com/8647044/diff/35001/input/regression/offsets.ly
File input/regression/offsets.ly (right):
https://codereview.appspot.com/8647044/diff/35001/input/regression/offsets.ly#newcode31
input/regression/offsets.ly:31:
On 2013/10/07 14:10:32, dak wrote:
Spurious space in
On 2013/10/07 14:10:09, dak wrote:
On 2013/10/06 01:15:12, david.nalesnik wrote:
There is a major problem with this patch set which I don't know how
to
address.
The examples below represent my efforts to test the effects of
multiple
applications of \offset. You can see that some
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly
File input/regression/offsets.ly (right):
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly#newcode5
input/regression/offsets.ly:5: the @code{\\offset} command. These
properties are limited
https://codereview.appspot.com/8647044/diff/5001/scm/c++.scm
File scm/c++.scm (right):
https://codereview.appspot.com/8647044/diff/5001/scm/c++.scm#newcode30
scm/c++.scm:30: (every number-pair? x)))
On 2013/04/23 20:24:57, dak wrote:
Isn't it dangerous to call every on something that is not
**Arghh** This should have gone to -devel in the first place!
-- Forwarded message --
From: David Nalesnik david.nales...@gmail.com
Date: Thu, Sep 5, 2013 at 8:09 AM
Subject: Fwd: implementing roman numeral harmonic analysis?
To: markpole...@yahoo.com, lilypond-user lilypond-u
Enhancement
David Nalesnik Push Patch: input/regression/scheme-text-spanner.ly: fix
problem with constants
I don't have push privileges; would someone be willing to push this for me
if I send along a formatted patch?
Thanks,
David
___
lilypond-devel
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode117
input/regression/scheme-text-spanner.ly:117: (event-drul
Instead, complete-grob-entry (or whatever it was
called)
needs to be changed in order to work non-destructively. It does not
make sense to do this separately from the original code.
OK, I won't bother yet with add-grob-definition here, but I wonder: if I
use copy-tree on a literal
Reviewers: ,
Message:
Please review.
Thanks,
David
Description:
input/regression/scheme-text-spanner.ly: fix problem with constants
The file `input/regression/scheme-text-spanner.ly' assigns a constant
pair to the variable `event-drul' and subsequently attempts to modify
the pair. This can
Thank you, David.
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly
File input/regression/scheme-text-spanner.ly (right):
https://codereview.appspot.com/11614044/diff/1/input/regression/scheme-text-spanner.ly#newcode28
On 2013/07/23 13:27:49, dak wrote:
On 2013/07/23 13:05:47, david.nalesnik wrote:
On 2013/07/23 12:31:25, dak wrote:
Frankly, just throw out the crap event-drul and current-event, and
instead
use
event-start and event-stop instead of (car event-drul) and (cdr
event-drul).
OK, will do.
On 2013/07/23 15:06:51, dak wrote:
On 2013/07/23 13:52:13, david.nalesnik wrote:
Sorry, replied a bit hastily!
[...]
I've thought some more about the issue of trying to change constants
elsewhere
in the file.
Specifically, regarding the addition of the new grob description to
On 2013/07/23 20:16:24, dak wrote:
On 2013/07/23 20:05:40, david.nalesnik wrote:
I hesitate to do something like the following!
#(add-grob-definition
'SchemeTextSpanner
(list
(cons
'bound-details
(list
[...]
No, that's nonsensical. Instead, complete-grob-entry
Hi,
Attached is a version of the regression test scheme-text-spanner.ly which
shows that problems arise when the engraver is used simultaneously in
different contexts. I've smply created a StaffGroup in which both Staff
contexts contain the same material as in the original reg test.
You can see
On Mon, Jul 22, 2013 at 12:06 PM, David Kastrup d...@gnu.org wrote:
David Nalesnik david.nales...@gmail.com writes:
All spanners appear when I replace the variable definition
(event-drul '(() . ()))
with
(cons (list) (list))
and later (line 157):
(set! event-drul
On Mon, Jul 22, 2013 at 2:02 PM, David Kastrup d...@gnu.org wrote:
David Nalesnik david.nales...@gmail.com writes:
(set! all-grob-descriptions (sort all-grob-descriptions alist?))
is perfectly fine since it does not touch the original list. sort!
however would be a problem.
In a similar
LGTM
Thanks for adding these, Harm.
https://codereview.appspot.com/11427044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm
File scm/music-functions.scm (right):
https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm#newcode2103
scm/music-functions.scm:2103: ; head of the alist. We reverse the alist
so our search will return
David,
Thank you for your reviews. It will take me some time to make the
changes you propose, so I've changed the status of the patch to needs
work.
https://codereview.appspot.com/8647044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2013/04/23 13:14:23, janek wrote:
anyway, this patch LTGM.
Thanks, Janek!
The patch has passed countdown, but in view of the fact that a stable
release is on the horizon, it may not be appropriate to push it at this
time.
On the other hand, an argument for pushing it right away might be
On 2013/04/23 19:38:09, dak wrote:
On 2013/04/23 19:03:18, david.nalesnik wrote:
On 2013/04/23 13:14:23, janek wrote:
anyway, this patch LTGM.
Thanks, Janek!
The patch has passed countdown, but in view of the fact that a
stable release
is
on the horizon, it may not be appropriate to
I've considerably shortened the regtests, removing redundancies and
unnecessary line breaks. Thanks for the comments!
https://codereview.appspot.com/8647044/diff/1/input/regression/offsets.ly
File input/regression/offsets.ly (right):
On 2013/04/13 21:39:40, janek wrote:
There's one thing that puzzles me. Current syntax is
\offset property offset-value grob-name
I understand that grob-name is at the end because it's optional, and
we want to
omit it when we're using \offset as a tweak.
However, i find this syntax
Reviewers: ,
Message:
Please review.
Thanks,
David
Description:
Add the command \offset to LilyPond
The ability to offset default values of various properties would be a
useful enhancement of LilyPond. Currently, this is possible for the
property 'control-points using the \shape command.
%20Patch%20Needs%20Summary%20Modified
Documentation
David Nalesnik Push Doc: \startMeasureCount and \stopMeasureCount needs
documenting
I don't have push privileges--could someone push the patch for issue 2924
for me?
Thanks,
David
___
lilypond
Thank you all for the reviews!
https://codereview.appspot.com/7678047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2013/03/17 10:35:40, PhilEHolmes wrote:
I've not tested the snippets, but otherwise the patch LGTM. I'm
assuming the
only files you actually created were the ones in snippets/new/ - the
rest came
from makelsr and make doc?
Yes, exactly.
https://codereview.appspot.com/7678047/
Hi all,
I'm attempting to put two snippets dealing with the measure counter up for
review, but I'm running into problems when I run make doc. Here's the tail
end of the terminal output:
make[3]: Entering directory
`/home/david/lilypond-git/build/Documentation/cs'
/usr/bin/python -tt
Reviewers: ,
Message:
Please review.
Thanks!
David
Description:
Issue 2924: Doc: \startMeasureCount and \stopMeasureCount needs
documenting
The following patch is a preliminary step towards documenting the
Measure_counter_engraver added in version 2.17.7. The patch consists of
two snippets,
Julien,
On Sat, Mar 16, 2013 at 7:31 PM, Julien Rioux jri...@lyx.org wrote:
On 16/03/2013 6:27 PM, David Nalesnik wrote:
/usr/bin/python -tt
/home/david/lilypond-git/**scripts/build/create-weblinks-**itexi.py
out-www/weblinks.itexi
make[3]: *** No rule to make target
`/home/david
2013/2/12 Janek Warchoł janek.lilyp...@gmail.com:
Hi all,
i hope to get back to lilypond hacking now. I miss it a lot...
Welcome back, Janek!
--David
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Harm--
This looks great! Thank you for the 'full-length option. I can't be
alone in hating lines ending with incomplete dashes.
All I have is a suggestion or two, and some quibbles.
Besides what I've pointed out inline, I should mention that I got a
number of whitespace errors when I applied
On Mon, Dec 24, 2012 at 7:22 AM, m...@mikesolomon.org
m...@mikesolomon.org wrote:
On 24 déc. 2012, at 10:36, d...@gnu.org wrote:
On 2012/12/24 07:28:17, mike7 wrote:
On 24 déc. 2012, at 01:10, mailto:d...@gnu.org wrote:
All of this is absolutely devastatingly horrible code that is not
On Mon, Dec 10, 2012 at 11:30 PM, David Kastrup d...@gnu.org wrote:
The behavior is undefined if I remember correctly: an error is not
guaranteed by the standard. I think Guilev2 will produce an error, but
LilyPond is still at Guilev1.
OK, thanks!
-David
On Sat, Dec 8, 2012 at 7:21 PM, David Nalesnik david.nales...@gmail.com wrote:
[...]
Trying to work out the problem, I've done a little rewriting so I'll
include the engraver here. You can just substitute this in the
problematic file.
Well, I did break something. Here's the fix
David,
On Sun, Dec 9, 2012 at 12:34 AM, David Kastrup d...@gnu.org wrote:
David Nalesnik david.nales...@gmail.com writes:
It turns out that the my definition of event-drul as '(() . ()) was
the problem. I substituted (cons '() '()) and everything works just
fine...even with the file
Hi Jeffrey,
I'm copying this to the list since I myself am not sure about something here.
On Sat, Dec 8, 2012 at 5:13 AM, Jeffrey Trevino
jeffrey.trevi...@gmail.com wrote:
Hi David,
Thanks for revising this more for me. I really appreciate your efforts, and
I will take a look at this asap
Hi again,
On Sat, Dec 8, 2012 at 7:21 AM, David Nalesnik david.nales...@gmail.com wrote:
Hi Jeffrey,
I'm copying this to the list since I myself am not sure about something here.
On Sat, Dec 8, 2012 at 5:13 AM, Jeffrey Trevino
jeffrey.trevi...@gmail.com wrote:
Hi David,
Thanks
Hi Harm,
On Thu, Nov 1, 2012 at 9:57 AM, Thomas Morley
thomasmorle...@googlemail.com wrote:
Hi David (N),
attached my first try.
If the markup-property full-length is set #t, some calculations ensure
that no space occurs at line-end/begin. Some dashes will only be
partly visible, but I
David,
I don't mind making the changes, but I'm running into some problems. I
used git pull -r before making a patch set and uploading to rietveld,
but looking over the patch set there I see that other changes have found
their way in--including your check-grob-path function.
I'm probably
Thank you--I am a bit worried!
Speaking of patch, when I run git format-patch I get six separate
patches. Is there any way to compress them into one so this is more
convenient for you?
-David
https://codereview.appspot.com/6730044/
___
LGTM!
Thanks very much for doing this, David.
https://codereview.appspot.com/6784063/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2012/10/24 20:28:36, janek wrote:
On Wed, Oct 24, 2012 at 4:10 PM, mailto:pkx1...@gmail.com wrote:
Also, should we include
Measure_counter_engraver
in the Staff context by default?
(it'd make documenting it simpler in the @lilypond if nothing else
:) )
+1 from me :)
Janek
Thanks for your review, Janek!
https://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly
File input/regression/measure-counter-broken.ly (right):
https://codereview.appspot.com/6730044/diff/10001/input/regression/measure-counter-broken.ly#newcode6
David,
On Wed, Oct 17, 2012 at 12:44 AM, David Kastrup d...@gnu.org wrote:
Try git rebase origin first
I tried this, and this is what happened:
david@david-desktop ~/lilypond-git (dev/measure_counter)$ git rebase origin
fatal: Needed a single revision
invalid upstream origin
Should I try
Julien,
On Wed, Oct 17, 2012 at 1:33 AM, Julien Rioux
jri...@physics.utoronto.ca wrote:
On 16/10/2012 4:36 PM, David Nalesnik wrote:
david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl issue
2445
Issue number: 2445 (http://codereview.appspot.com/2445)
This should be the issue
Reviewers: ,
Message:
Please review.
Thanks!
-David
Description:
Issue 2445: Add measure counter to LilyPond
This patch allows the user to number groups of successive measures,
which
is useful as an aid to the performer in keeping track of repetitions.
There
is no requirement that the
David,
On Wed, Oct 17, 2012 at 8:04 AM, David Kastrup d...@gnu.org wrote:
David Nalesnik david.nales...@gmail.com writes:
Julien,
On Wed, Oct 17, 2012 at 1:33 AM, Julien Rioux
jri...@physics.utoronto.ca wrote:
On 16/10/2012 4:36 PM, David Nalesnik wrote:
david@david-desktop ~/lilypond
Julien,
On Wed, Oct 17, 2012 at 9:25 AM, Julien Rioux
jri...@physics.utoronto.ca wrote:
$ git cl issue 0
to reset (remove any association to a Rietveld issue)
$ git cl upload origin/master
to upload (given that the branch is no longer associated to a Rietveld
issue, it will create a new
Hi,
I'm trying to upload a patch created in a branch to Rietveld, but I
seem to be creating an unholy mess. I attempted to run
git-cl upload master
within my branch, but I end up with a huge list of recent commits not
my own. The same thing happened when I ran
git format-patch master
and
Hi Phil,
On Tue, Oct 16, 2012 at 3:11 PM, Phil Holmes
[...]
If you have a record of changes you've made, then I tend to use
git reset --hard origin/master
which takes you back to the current state of master, and then
git am your.patch
which applies the patch you have. Follow this
Hi Phil.
david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl issue 2445
Issue number: 2445 (http://codereview.appspot.com/2445)
david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl upload
Unable to determine default branch to diff against.
Either pass complete git
On Sat, Oct 13, 2012 at 8:15 AM, David Kastrup d...@gnu.org wrote:
David Nalesnik david.nales...@gmail.com writes:
Buildup of unwanted data or no, it would be useful to be able to write
something like
\toLast Accidental #'color
to restore the previous override
But which is the previous
On Thu, Oct 11, 2012 at 6:11 PM, Valentin Villenave
valen...@villenave.net wrote:
On Tue, Oct 9, 2012 at 8:19 AM, m...@mikesolomon.org
m...@mikesolomon.org wrote:
Just a quick ping to let you know that I'm not dead - I've been swamped w/
work recently and just got engaged so I'm planning out
On Mon, Oct 8, 2012 at 7:19 AM, Joseph Rushton Wakeling
joseph.wakel...@webdrake.net wrote:
-
This version contains work in progress. You will have access to the very
latest features, but some may be incomplete, and you may encounter bugs and
crashes. If you
LGTM.
And thanks again for doing this!
-David
https://codereview.appspot.com/6561064/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Trevor--
This looks great to me. I like the reordering, and I think the
explanations are very clear.
I've tweaked the curves a little in the examples (do what you like with
my suggestions!), but otherwise:
LGTM.
On 2012/10/03 13:57:25, dak wrote:
[...]
To those suggestions let me answer with the famous answer to the
question Mr
Gandhi, what do you think of Western civilization?, namely with I
would
consider it a good idea.
Oh, for just one zinger like that...
So the best I think I can do at
On 2012/10/03 15:17:26, dak wrote:
[...]
and I am currently immersed in parser work to make the
Context.GrobName thing
fly.
Thank you very much for working on this! I am looking forward to being
able to fix the mess at the beginning of \alterBroken (and a general
offsetting function I
LGTM
https://codereview.appspot.com/6585052/diff/1/input/regression/shape-other-curves.ly
File input/regression/shape-other-curves.ly (right):
https://codereview.appspot.com/6585052/diff/1/input/regression/shape-other-curves.ly#newcode18
input/regression/shape-other-curves.ly:18: \override
Trevor--
Thank you so much for taking this on! I've been pecking at documenting
this for awhile, but got hung up on finding the perfect examples... What
you have is clearer than what I cam up with.
https://codereview.appspot.com/6561064/diff/1/Documentation/notation/changing-defaults.itely
On Wed, Sep 12, 2012 at 3:38 AM, David Kastrup d...@gnu.org wrote:
[...]
Basically, if a music function wants to provide a shorthand for an
override, not being able to specify an optional context is a nuisance.
I currently have just the same problem writing a \hide function that is
supposed
Hi all,
I'm trying to compile the latest master within LilyDev, and I'm
running into a problem when I try to prepare the build directory. I
get the following error:
ERROR: Please install required programs: lh CTAN package
(texlive-lang-cyrillic or texlive-texmf-fonts)
Can someone give me
Phil,
On Sun, Sep 9, 2012 at 10:24 AM, Phil Holmes m...@philholmes.net wrote:
I suspect this might be relevant:
http://code.google.com/p/lilypond/issues/detail?id=2742
Piece of cake!
Thank you very much,
David
___
lilypond-devel mailing list
Hi,
I don't have push ability, so would someone who does please push my patch
for issue 2679 (Add function for overriding broken spanners to LilyPond)
for me?
Thanks so much,
David
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On Tue, Jul 24, 2012 at 8:56 AM, David Kastrup d...@gnu.org wrote:
Phil Holmes m...@philholmes.net writes:
I get the patch fails to apply - presumably because
music-functions.scm has been updated twice since the patch was
created? Does this mean it needs rebasing, or somesuch?
Likely.
David,
So, in this case, would I do something like:
git pull -r
then submit a new patch set?
That's probably the easiest way. You'll likely get a merge conflict
with instructions. Personally, I use Emacs and
M-x smerge-ediff RET
on the problematic file(s) for fixing the
David,
Is there any reason I can't manually remove the markers for the merge
conflict, namely the lines:
HEAD
===
Function for overriding broken spanners
If the result is the intended result, sure. You are getting the merge
conflict because the history introduced
OK, I succeeded in doing this and uploaded a new patch set. I'm going to
redo this now as I see I failed to delete two newlines...
OK, all should be well now. Patch corrected.
-David
___
lilypond-devel mailing list
lilypond-devel@gnu.org
use it as a reviewing tool, not a
patch management tool.
David Nalesnik should send you the file he gets from
git format-patch, after he fixed all merge conflicts etc.
Arggh...sorry for making a hash of this :( Hopefully, this patch will be
properly formatted...
-David
0001-Function
David,
On Tue, Jul 24, 2012 at 11:50 AM, David Kastrup d...@gnu.org wrote:
David Nalesnik david.nales...@gmail.com writes:
On Tue, Jul 24, 2012 at 11:34 AM, Graham Percival
gra...@percival-music.ca wrote:
On Tue, Jul 24, 2012 at 05:26:01PM +0100, Phil Holmes wrote:
I'd
On Tue, Jul 24, 2012 at 12:05 PM, David Kastrup d...@gnu.org wrote:
David Nalesnik david.nales...@gmail.com writes:
Arggh...sorry for making a hash of this :(
By the way, you aren't. You are dealing with flexible and powerful
tools in action, and keeping up surprisingly well. That's
Phil,
On Tue, Jul 24, 2012 at 12:07 PM, Phil Holmes m...@philholmes.net wrote:
**
Pushed as
f7085cf9b2ff111b7d30c8a59e367c771a7e3c52http://git.savannah.gnu.org/cgit/lilypond.git/commit/?h=stagingid=f7085cf9b2ff111b7d30c8a59e367c771a7e3c52.
Patchy is now running.
Thank you very much for
On Tue, Jul 24, 2012 at 12:57 PM, David Kastrup d...@gnu.org wrote:
Phil Holmes m...@philholmes.net writes:
BTW - apologies for top-posting and that, but my Windows email system
takes your mails as HTML and does this with them.
His mails contain HTML and plain text as alternatives, and
David,
This use of \default for skipping optional arguments even in end
position may appear a bit contrived.
However, \key \default and \mark \default existed (hardwired in the
parser) even before music functions ever heard of optional arguments, so
I consider it an accomplishment to have
David,
On Fri, Jul 20, 2012 at 12:38 AM, David Kastrup d...@gnu.org wrote:
David Nalesnik david.nales...@gmail.com writes:
David,
Why does this have to be a list? Why not just make it two
separate
arguments?
If, for whatever reason, you really really really have
2012/7/18 Janek Warchoł janek.lilyp...@gmail.com:
(however, it would be even more awesome if it was one general
function
for all purposes ;) )
Considering this some more, I think it's best at the moment to restrict
the function to spanners. The expanded function encompassing spanners
Hi Janek,
The only thing that
worries me is the indentation - there are some tabs used and
Frescobaldi displays them wrong (i suppose you meant 1 tab to be equal
to 4 spaces, not 8).
Oops! Usually I remember to convert tabs to spaces (and trim whitespace
from the ends of lines), but
not
David,
Why does this have to be a list? Why not just make it two separate
arguments?
If, for whatever reason, you really really really have this information
in a two-element list called whatever, you can still write
\once \alterBroken Staff.BarLine #'color #@whatever
It certainly makes
Hi Janek,
On Wed, Jul 18, 2012 at 12:22 AM, Janek Warchoł janek.lilyp...@gmail.comwrote:
On Wed, Jul 18, 2012 at 12:43 AM, david.nales...@gmail.com wrote:
The function will override unbroken spanners, but it will ignore
non-spanners with a warning.
What about things like clef change at a
On Wed, Jul 18, 2012 at 3:18 PM, David Kastrup d...@gnu.org wrote:
Thomas Morley thomasmorle...@googlemail.com writes:
2012/7/18 Janek Warchoł janek.lilyp...@gmail.com:
On Wed, Jul 18, 2012 at 8:18 PM, Thomas Morley
thomasmorle...@googlemail.com wrote:
2012/7/18 Janek Warchoł
Reviewers: ,
Description:
Add function for overriding broken spanners to LilyPond.
The music function \alterBroken is intended to facilitate overrides
applied independently to the pieces of broken spanners--one of the
perennial difficulties faced by users of LilyPond (addressed in
Extending
Hi Harm,
On Tue, Jul 10, 2012 at 3:07 PM, Thomas Morley
thomasmorle...@googlemail.com wrote:
(2) The code using the regexp library does not work with windows so
far (perhaps never).
Unfortunately, I'm still having no luck with Windows XP. (@David Kastrup:
thank you for your suggestions and
Hi Harm,
I managed to drop about 300 lines, reducing
it to a quarter of the original.
Unfortunately, I'm getting Invalid UTF-8 string... warnings when I run
your revised file. (I don't with the original...)
-David
___
lilypond-devel mailing list
On Sun, Jul 8, 2012 at 8:00 AM, David Kastrup d...@gnu.org wrote:
Thomas Morley thomasmorle...@googlemail.com writes:
2012/7/8 David Nalesnik david.nales...@gmail.com:
Hi Harm,
I managed to drop about 300 lines, reducing
it to a quarter of the original.
Unfortunately, I'm
On Sun, Jul 8, 2012 at 6:21 PM, Thomas Morley thomasmorle...@googlemail.com
wrote:
2012/7/9 David Kastrup d...@gnu.org:
David Nalesnik david.nales...@gmail.com writes:
On Sun, Jul 8, 2012 at 8:00 AM, David Kastrup d...@gnu.org wrote:
Thomas Morley thomasmorle...@googlemail.com
Hi Jan-Peter,
First of all, I agree with David Kastrup that this is a situation where a
deep fix is in order so that simultaneous ties may be tweaked directly.
Your example is working as expected :)
Glad to hear it!
To make it (more) usable, I think, we need wrapper functions, to avoid
Hi Jan-Peter,
On Mon, Jun 25, 2012 at 4:47 AM, Jan-Peter Voigt jp.vo...@gmx.de wrote:
Now the broken siblings are found, but only the first one is shaped.
But it seems possible ... I will have another look after lunch ;-)
I tried to fix what was amiss in your adaptation of \shape, but I
Hi Jan-Peter,
On Wed, Jun 20, 2012 at 2:46 AM, Jan-Peter Voigt jp.vo...@gmx.de wrote:
Hi David,
... moving this to devel ...
I had a look into tie-column.cc:
In the scheme-callback calc_positioning_done all ties in a chord are
assigned control-points in a loop. So it might be possible to
, for an illustration of such modifying functions see this
email from David Nalesnik:
http://lists.gnu.org/archive/html/lilypond-devel/2012-06/msg00102.html
http://codereview.appspot.com/6294086/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https
Hi Janek,
On Tue, Jun 5, 2012 at 12:55 AM, Janek Warchoł janek.lilyp...@gmail.comwrote:
David already knows my opinion ;) - i'd just like to share with you
how this function made my day yesterday!
I have a song with piano accompaniment which contains loads of portato
passages, and they were
On 2012/06/03 19:39:35, janek wrote:
Hi David,
please close this Rietveld issue (crossed circle next to its name).
OK, done.
Thanks!
David
http://codereview.appspot.com/6255056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Thank you for reviewing this, Neil!
On 2012/05/31 16:22:53, Neil Puttock wrote:
http://codereview.appspot.com/6255056/diff/5001/input/regression/shape-slurs.ly
File input/regression/shape-slurs.ly (right):
Reviewers: ,
Message:
Add \shape as a method of modifying the control points of bezier curves.
Description:
add \shape
add \shape as a method of altering bezier curves by offsetting their
control-points.
Please review this at http://codereview.appspot.com/6255056/
Affected files:
A
On 2012/05/28 20:23:37, janek wrote:
generally LGTM.
What about coloring the \shaped curves? This would make checking
regtests more
obvious to an ordinary person who may be not familiar with this stuff.
Good idea! I did this for both regression tests.
Hi Mike,
On Wed, May 23, 2012 at 12:47 AM, m...@mikesolomon.org m...@mikesolomon.org
wrote:
[ ... ] Your patch is a post-processing corrective for when this fails.
However, the goal of LilyPond is twofold:
1) Provide users with the ability to tweak LilyPond's output when for some
reason
Hi José,
On Mon, May 21, 2012 at 9:09 AM, padovani zepadovani.li...@gmail.comwrote:
Hello,
I'm dealing with special noteheads I've designed and I need to move the
stem and the flag differently if stem direction is up or down.
I would like to create a guile lisp clause that sets the
Hi José,
On Mon, May 21, 2012 at 10:20 AM, padovani zepadovani.li...@gmail.comwrote:
Em 5/21/12 11:44 AM, David Nalesnik escreveu:
\override Stem #'extra-offset =
#(lambda (grob) (if (eqv? (ly:stem::calc-direction grob) UP)
'(-0.02 . -0.25) '(0.02 . 0.25)))
Hello David,
thank
301 - 400 of 424 matches
Mail list logo
