patch fails due to fixcc.
http://codereview.appspot.com/4626094/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
This patch is obsolete. Current patch is here
http://codereview.appspot.com/4800051/ and it is compatible with fixcc.
My bad... I should've closed this issue and sent a note.
http://codereview.appspot.com/4626094/
___
lilypond-devel mailing list
Hi all,
as acting Frog Meister i'm worried that nothing happens here :(
Wol, how can i help you?
Neil, Carl: do i understand correctly that Wol could've done this
using a more elegant solution, but nevertheless his patch doesn't
brake anything and works correctly (i don't remember any problems
On 2011/07/17 10:35:20, Janek Warchol wrote:
Hi all,
as acting Frog Meister i'm worried that nothing happens here :(
Wol, how can i help you?
Neil, Carl: do i understand correctly that Wol could've done this
using a more elegant solution, but nevertheless his patch doesn't
brake anything and
On 8 July 2011 04:37, Carl Sorensen c_soren...@byu.edu wrote:
The grob has everything that is necessary to create the printed output. You
can't apply a music function to a grob, but you can apply a scheme function
to the music contents of the grob. So rather than translate the chord (a
Sorry for being silent for some time, i got distracted by other things...
2011/7/7 Wols Lists antli...@youngman.org.uk:
On 07/07/11 08:59, Janek Warchoł wrote:
2011/7/7 Wols Lists antli...@youngman.org.uk:
On 06/07/11 20:31, lemniskata.bernoull...@gmail.com wrote:
And it's the one supplied
2011/7/8 Wols Lists antli...@youngman.org.uk:
It's certainly muddied the waters! :-) I'll try baling the bilges and
see what comes of it :-)
Wol,
i'm sorry that i cannot help you here - i'm not familiar enough in
internals and also don't handle scheme well.
However, i can say that what Carl
2011/7/7 Wols Lists antli...@youngman.org.uk:
On 06/07/11 20:31, lemniskata.bernoull...@gmail.com wrote:
New patch set uploaded.
Hmm, Wol, did you use some code formatting tool on a whole file? I see a
lot of style changes, and not all of them are for the good.
On 07/07/11 08:59, Janek Warchoł wrote:
2011/7/7 Wols Lists antli...@youngman.org.uk:
On 06/07/11 20:31, lemniskata.bernoull...@gmail.com wrote:
And it's the one supplied with lilypond - I assumed it formatted the
code as per lilypond guidelines ...
It isn't, mostly because there were no
On 07/07/11 03:21, carl.d.soren...@gmail.com wrote:
Looks nice!
I have a few suggestions.
As far as running things through the formatter goes, the current
formatter in git master is *not* the one that we are trying to get
approved. So it shouldn't be run on current files.
Ummm. In that
Mmmm...
Do we have generic procedures for combine markup and stack markup?
If not, there'll be a flurry of frog emails as I try and write them :-)
(note to self - ly:stencil-combine-at-edge)
line and column
(see line 1074 and line 1426 of scm/define-markup-commands.scm)
Because the
On 7/7/11 7:30 AM, m...@apollinemike.com m...@apollinemike.com wrote:
Mmmm...
Do we have generic procedures for combine markup and stack markup?
If not, there'll be a flurry of frog emails as I try and write them :-)
(note to self - ly:stencil-combine-at-edge)
line and column
(see
Hi Anthony,
When we discussed this last year, I argued that it shouldn't be part of
the Chord_name_engraver. I still think this approach is misguided since
we already have a convenient way of generating chord name markup via the
formatter function.
If you check the archives, you'll see a
On 7 July 2011 19:09, Wols Lists antli...@youngman.org.uk wrote:
Which I probably didn't understand :-) BUT from what I remember did you
think that feeding a chord of, say, C into the formatter should chuck
out A as its result? Which is NOT what this does - it has to chuck out
both C *and* A.
On 07/07/11 18:08, n.putt...@gmail.com wrote:
Hi Anthony,
When we discussed this last year, I argued that it shouldn't be part of
the Chord_name_engraver. I still think this approach is misguided since
we already have a convenient way of generating chord name markup via the
formatter
On 7/7/11 12:26 PM, Neil Puttock n.putt...@gmail.com wrote:
On 7 July 2011 19:09, Wols Lists antli...@youngman.org.uk wrote:
Which I probably didn't understand :-) BUT from what I remember did you
think that feeding a chord of, say, C into the formatter should chuck
out A as its result?
On 08/07/11 00:23, Carl Sorensen wrote:
On 7/7/11 12:26 PM, Neil Puttock n.putt...@gmail.com wrote:
On 7 July 2011 19:09, Wols Lists antli...@youngman.org.uk wrote:
Which I probably didn't understand :-) BUT from what I remember did you
think that feeding a chord of, say, C into the
On 7/7/11 6:58 PM, Wols Lists antli...@youngman.org.uk wrote:
On 08/07/11 00:23, Carl Sorensen wrote:
On 7/7/11 12:26 PM, Neil Puttock n.putt...@gmail.com wrote:
On 7 July 2011 19:09, Wols Lists antli...@youngman.org.uk wrote:
Which I probably didn't understand :-) BUT from what I
Passes Make and reg tests
James
http://codereview.appspot.com/4626094/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
New patch set uploaded.
Hmm, Wol, did you use some code formatting tool on a whole file? I see a
lot of style changes, and not all of them are for the good.
http://codereview.appspot.com/4626094/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 06/07/11 20:31, lemniskata.bernoull...@gmail.com wrote:
New patch set uploaded.
Hmm, Wol, did you use some code formatting tool on a whole file? I see a
lot of style changes, and not all of them are for the good.
http://codereview.appspot.com/4626094/
Did I use a formatting tool? Yes I
Looks nice!
I have a few suggestions.
As far as running things through the formatter goes, the current
formatter in git master is *not* the one that we are trying to get
approved. So it shouldn't be run on current files.
Thanks for your work!
Carl
Reviewers: antlists_youngman.org.uk, carl.d.sorensen_gmail.com,
Message:
Modify chord-name-engraver to print transposed guitar chords on piano
sheets
Add associated properties capoPitch and capoVertical to
define-context-properties
Description:
print transposed guitar chords on pia
Please
23 matches
Mail list logo