LGTM, apart from one minor change
http://codereview.appspot.com/6353081/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/6353081/diff/1/Documentation/notation/spacing.itely#newcode906
Patch pushed
91ca3dbe2cd40f8eedce48ee02c7c98a2ec89413
http://codereview.appspot.com/6347062/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patch pushed
73255e50558a62841500aa947ff7cad28636d144
http://codereview.appspot.com/6354085/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patch pushed
bcd9d85bfc1dd6cc2dd3e98901b4df33fd6d0989
http://codereview.appspot.com/6353079/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Graham Percival gra...@percival-music.ca writes:
On Tue, Jul 10, 2012 at 11:51:11PM +0200, David Kastrup wrote:
Graham Percival gra...@percival-music.ca writes:
I'll only address meta-discussion points here.
What about the next one? Phil has been learning how to do it, and I
certainly
Reviewers: ,
Message:
This is a substantial change. I took the opportunity to
deal with a TODO in the file - document \with - as
this made for a more sensible organisation of the section.
I'd like reviewers to consider in particular
- factual accuracy (I was not confident about some parts)
http://codereview.appspot.com/6345086/diff/1/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/6345086/diff/1/Documentation/notation/changing-defaults.itely#newcode698
I'm doing a little project to get rid of all the black bars on the right
side of the PDF of the NR - these indicate material that is too wide to be
properly accommodated on the page. One of the things that causes this is
text like:
Fret diagrams for the ukulele are contained in the file
Phil Holmes em...@philholmes.net writes:
I'm doing a little project to get rid of all the black bars on the
right side of the PDF of the NR - these indicate material that is too
wide to be properly accommodated on the page. One of the things that
causes this is text like:
Fret diagrams for
- Original Message -
From: David Kastrup d...@gnu.org
To: lilypond-devel@gnu.org
Sent: Wednesday, July 11, 2012 12:22 PM
Subject: Re: Texinfo help, please
Phil Holmes em...@philholmes.net writes:
I'm doing a little project to get rid of all the black bars on the
right side of the
Reviewers: lemzwerg,
Message:
On 2012/07/11 04:15:47, lemzwerg wrote:
http://codereview.appspot.com/6351083/diff/1/Documentation/contributor/lsr-work.itexi
File Documentation/contributor/lsr-work.itexi (right):
Phil Holmes m...@philholmes.net writes:
- Original Message -
From: David Kastrup d...@gnu.org
To: lilypond-devel@gnu.org
Sent: Wednesday, July 11, 2012 12:22 PM
Subject: Re: Texinfo help, please
Phil Holmes em...@philholmes.net writes:
I'm doing a little project to get rid of
- Original Message -
From: David Kastrup d...@gnu.org
To: Phil Holmes m...@philholmes.net
Cc: lilypond-devel@gnu.org
Sent: Wednesday, July 11, 2012 12:56 PM
Subject: Re: Texinfo help, please
Phil Holmes m...@philholmes.net writes:
- Original Message -
From: David Kastrup
On Wed, Jul 11, 2012 at 1:56 PM, David Kastrup d...@gnu.org wrote:
Phil Holmes m...@philholmes.net writes:
It should wrap between the words the file and the filename.
Obviously not enough stretchability for that to fit. You can try
@tex
\global\emergencystretch=5in
@end tex
and see
Janek Warchoł janek.lilyp...@gmail.com writes:
On Wed, Jul 11, 2012 at 1:56 PM, David Kastrup d...@gnu.org wrote:
Phil Holmes m...@philholmes.net writes:
It should wrap between the words the file and the filename.
Obviously not enough stretchability for that to fit. You can try
@tex
Reviewers: Graham Percival, Trevor Daniels, J_lowe,
Message:
Lots of changes here. The NR still builds successfully following them
all, so I'm fairly confident, but please review if you have time.
Description:
Just a few changed files. A number of these are in /snippets and I have
updated the
LGTM
Trevor
http://codereview.appspot.com/6345088/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Also if you want to give more details about your database, e.g., which SQL
implementation, how the tables are organised, and the code you tried, maybe
someone here can improve it.
On Jul 10, 2012 4:54 PM, Trevor Daniels t.dani...@treda.co.uk wrote:
Phil Holmes wrote Tuesday, July 10, 2012 12:03
I have a Lilypond 'Cloud' web service to announce shortly as well, if
anyone wants to have a look.
It's at http://cloud.blackstockweb.ca - email login 'guest' password 'guest'
It's functional enough for people to be able to upload their Lilypond
projects and be able to work on them and show them
LGTM. Thanks a lot!
http://codereview.appspot.com/6345088/diff/1/Documentation/snippets/simultaneous-headword.ly
File Documentation/snippets/simultaneous-headword.ly (right):
http://codereview.appspot.com/6345088/diff/1/Documentation/snippets/simultaneous-headword.ly#newcode16
- Original Message -
From: lemzw...@googlemail.com
To: philehol...@googlemail.com; gra...@percival-music.ca;
tdanielsmu...@googlemail.com; pkx1...@gmail.com
Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com
Sent: Wednesday, July 11, 2012 4:23 PM
Subject: Re: Fixes all
Hi All, Graham,
first, let me apologise for not responding promptly.
Secondly, here's my reply to Graham's almost-original proposition;
i'll send a reply to current discussion (Clear policy discussions)
separately.
On Tue, Jun 26, 2012 at 10:55 PM, Graham Percival
gra...@percival-music.ca wrote:
Janek Warchoł janek.lilyp...@gmail.com writes:
On Tue, Jul 10, 2012 at 11:50 PM, Trevor Daniels t.dani...@treda.co.uk
wrote:
So far there have been c. 75 critical regressions under the
current definition of 'critical' since 2.14. All but one have been
fixed, many of them promptly. This
This prompted me to check my indexing and it was mostly OK, but I found that
adding an index on RateUsername improves the speed of this query by a factor of
about 4. I think we're back to pretty much OK now.
If it gets bad, I'll ask for help with my SQL.
--
Phil Holmes
- Original
On Wed, Jul 11, 2012 at 6:07 PM, David Kastrup d...@gnu.org wrote:
Janek Warchoł janek.lilyp...@gmail.com writes:
What about something like this:
when a regression against latest stable is found, it's not marked as
critical (as Graham suggests). However, when we make a stable
release, all
On Wed, Jul 11, 2012 at 6:57 PM, Phil Holmes m...@philholmes.net wrote:
This prompted me to check my indexing and it was mostly OK, but I found that
adding an index on RateUsername improves the speed of this query by a factor
of about 4. I think we're back to pretty much OK now.
Yeah,
LGTM
http://codereview.appspot.com/6353081/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Wed, Jul 11, 2012 at 03:50:21PM +0200, David Kastrup wrote:
Janek Warchoł janek.lilyp...@gmail.com writes:
On Wed, Jul 11, 2012 at 1:56 PM, David Kastrup d...@gnu.org wrote:
Phil Holmes m...@philholmes.net writes:
It should wrap between the words the file and the filename.
+1
It
On Mon, Jul 9, 2012 at 7:10 PM, Werner LEMBERG w...@gnu.org wrote:
I suggest that we adopt this as an official policy: fixes for
easy-to-overlook things should be documented by regtests using
big/enormous font-size (e.g. between 30 and 100, depending on
issue). So, everyone checking regtests
I've only looked at the first few files, but I have grave concerns with
this patch.
I feel terrible about it, though. Please, PLEASE, anybody who wants to
make lots of changes to the docs -- spend *at most* one hour working on
your changes, then submit them to get feedback. It must have taken
Graham Percival gra...@percival-music.ca writes:
On Wed, Jul 11, 2012 at 03:50:21PM +0200, David Kastrup wrote:
Janek Warchoł janek.lilyp...@gmail.com writes:
On Wed, Jul 11, 2012 at 1:56 PM, David Kastrup d...@gnu.org wrote:
Phil Holmes m...@philholmes.net writes:
It should wrap
On Wed, Jul 11, 2012 at 9:45 PM, David Kastrup d...@gnu.org wrote:
Graham Percival gra...@percival-music.ca writes:
Sure. So we're asking if TeX can be tweaked to consider
additional solutions. (namely, always add a line-break before
anything with an overfull hbox, regardless of what that
Janek Warchoł janek.lilyp...@gmail.com writes:
On Wed, Jul 11, 2012 at 9:45 PM, David Kastrup d...@gnu.org wrote:
Graham Percival gra...@percival-music.ca writes:
Sure. So we're asking if TeX can be tweaked to consider
additional solutions. (namely, always add a line-break before
anything
On Wed, Jul 11, 2012 at 09:45:49PM +0200, David Kastrup wrote:
Graham Percival gra...@percival-music.ca writes:
Sure. So we're asking if TeX can be tweaked to consider
additional solutions. (namely, always add a line-break before
anything with an overfull hbox, regardless of what that
From what i understand (based on David's description) the result in
second case would rather be
--- linewidth --
This is a paragraph which
has a really long word and
has benefitted from some
kind of
emergency-stretch-tweak
which isn't IMO exactly what
we
- Original Message -
From: gra...@percival-music.ca
To: philehol...@googlemail.com; tdanielsmu...@googlemail.com;
pkx1...@gmail.com; lemzw...@googlemail.com; em...@philholmes.net
Cc: lilypond-devel@gnu.org; re...@codereview-hr.appspotmail.com
Sent: Wednesday, July 11, 2012 8:45 PM
Janek Warchoł janek.lilyp...@gmail.com writes:
From what i understand (based on David's description) the result in
second case would rather be
--- linewidth --
This is a paragraph which
has a really long word and
has benefitted from some
kind of
Phil Holmes em...@philholmes.net writes:
@*
@file{blah}
David doesn't like @* so I avoided it. I'll use @*
@* is awful. It cuts the current line _short_ unconditionally which
means that we may get abysmally bad breaks when the paragraph content
changes. It makes more sense to use @/ which
On Wed, Jul 11, 2012 at 10:28:35PM +0200, David Kastrup wrote:
More like
--- linewidth --
Thisisaparagraph
which has a really long
word and has benefitted
from some kind of
emergency-stretch-tweak
which isn't IMO exactly what
we want in
On Wed, Jul 11, 2012 at 10:32:28PM +0200, David Kastrup wrote:
Phil Holmes em...@philholmes.net writes:
David doesn't like @* so I avoided it. I'll use @*
@* is awful. It cuts the current line _short_ unconditionally which
means that we may get abysmally bad breaks when the paragraph
Graham Percival gra...@percival-music.ca writes:
On Wed, Jul 11, 2012 at 10:28:35PM +0200, David Kastrup wrote:
More like
--- linewidth --
Thisisaparagraph
which has a really long
word and has benefitted
from some kind of
Graham Percival gra...@percival-music.ca writes:
On Wed, Jul 11, 2012 at 10:32:28PM +0200, David Kastrup wrote:
Phil Holmes em...@philholmes.net writes:
David doesn't like @* so I avoided it. I'll use @*
@* is awful. It cuts the current line _short_ unconditionally which
means that we
On 11/07/12 15:38, Mike Blackstock wrote:
I have a Lilypond 'Cloud' web service to announce shortly as well, if anyone
wants to have a look.
It's at http://cloud.blackstockweb.ca - email login 'guest' password 'guest'
It's functional enough for people to be able to upload their Lilypond
Correct typo
http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changing-defaults.itely#newcode843
http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
http://codereview.appspot.com/6345086/diff/5001/Documentation/notation/changing-defaults.itely#newcode844
Hmm, that brings to mind a different possible solution:
@macro lilyfile{\FILENAME\}
@/@file{\FILENAME\}
@end macro
if there's no way to automate our desired behaviour (assuming we
can agree on a desired formatting in the output!), this might be
an alternate solution?
It is very
46 matches
Mail list logo
