Re: [PATCH] xfstests: test for atime-related mount options

2014-02-17 Thread Koen De Wit
Thanks for the review, Eric! Comments inline. On 02/13/2014 05:42 PM, Eric Sandeen wrote: On 2/13/14, 9:23 AM, Koen De Wit wrote: Tests the noatime, relatime, strictatime and nodiratime mount options. There is an extra check for Btrfs to ensure that the access time is never updated on

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-15 Thread Dave Chinner
On Fri, Feb 14, 2014 at 09:02:08PM -0600, Eric Sandeen wrote: On 2/14/14, 7:39 PM, Dave Chinner wrote: On Fri, Feb 14, 2014 at 05:48:59PM -0600, Eric Sandeen wrote: On 2/14/14, 4:24 PM, Dave Chinner wrote: On Fri, Feb 14, 2014 at 10:41:16AM -0600, Eric Sandeen wrote: On 2/14/14, 10:39 AM,

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-14 Thread David Sterba
On Thu, Feb 13, 2014 at 10:42:55AM -0600, Eric Sandeen wrote: +cat /proc/mounts | grep $SCRATCH_MNT | grep relatime $seqres.full +[ $? -ne 0 ] echo The relatime mount option should be the default. Ok, I guess relatime in /proc/mounts is from core vfs code and should be there for the

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-14 Thread Eric Sandeen
On 2/14/14, 10:39 AM, David Sterba wrote: On Thu, Feb 13, 2014 at 10:42:55AM -0600, Eric Sandeen wrote: +cat /proc/mounts | grep $SCRATCH_MNT | grep relatime $seqres.full +[ $? -ne 0 ] echo The relatime mount option should be the default. Ok, I guess relatime in /proc/mounts is from core

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-14 Thread David Sterba
On Fri, Feb 14, 2014 at 10:41:16AM -0600, Eric Sandeen wrote: I don't know that it's been discussed - selfishly, I know our QE uses xfstests on RHEL5, which is 2.6.18-based. Ok then. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-14 Thread Dave Chinner
On Fri, Feb 14, 2014 at 10:41:16AM -0600, Eric Sandeen wrote: On 2/14/14, 10:39 AM, David Sterba wrote: On Thu, Feb 13, 2014 at 10:42:55AM -0600, Eric Sandeen wrote: +cat /proc/mounts | grep $SCRATCH_MNT | grep relatime $seqres.full +[ $? -ne 0 ] echo The relatime mount option should be

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-14 Thread Eric Sandeen
On 2/14/14, 4:24 PM, Dave Chinner wrote: On Fri, Feb 14, 2014 at 10:41:16AM -0600, Eric Sandeen wrote: On 2/14/14, 10:39 AM, David Sterba wrote: On Thu, Feb 13, 2014 at 10:42:55AM -0600, Eric Sandeen wrote: +cat /proc/mounts | grep $SCRATCH_MNT | grep relatime $seqres.full +[ $? -ne 0 ]

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-14 Thread Dave Chinner
On Fri, Feb 14, 2014 at 05:48:59PM -0600, Eric Sandeen wrote: On 2/14/14, 4:24 PM, Dave Chinner wrote: On Fri, Feb 14, 2014 at 10:41:16AM -0600, Eric Sandeen wrote: On 2/14/14, 10:39 AM, David Sterba wrote: On Thu, Feb 13, 2014 at 10:42:55AM -0600, Eric Sandeen wrote: +cat /proc/mounts |

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-14 Thread Eric Sandeen
On 2/14/14, 7:39 PM, Dave Chinner wrote: On Fri, Feb 14, 2014 at 05:48:59PM -0600, Eric Sandeen wrote: On 2/14/14, 4:24 PM, Dave Chinner wrote: On Fri, Feb 14, 2014 at 10:41:16AM -0600, Eric Sandeen wrote: On 2/14/14, 10:39 AM, David Sterba wrote: On Thu, Feb 13, 2014 at 10:42:55AM -0600,

[PATCH] xfstests: test for atime-related mount options

2014-02-13 Thread Koen De Wit
Tests the noatime, relatime, strictatime and nodiratime mount options. There is an extra check for Btrfs to ensure that the access time is never updated on read-only subvolumes. (Regression test for bug fixed with commit 93fd63c2f001ca6797c6b15b696a484b165b4800) Signed-off-by: Koen De Wit

Re: [PATCH] xfstests: test for atime-related mount options

2014-02-13 Thread Eric Sandeen
On 2/13/14, 9:23 AM, Koen De Wit wrote: Tests the noatime, relatime, strictatime and nodiratime mount options. There is an extra check for Btrfs to ensure that the access time is never updated on read-only subvolumes. (Regression test for bug fixed with commit