Re: Does btrfs use crc32 for error correction?

2017-09-20 Thread Timofey Titovets
2017-09-19 19:51 GMT+03:00 Eric Sandeen <sand...@redhat.com>: > On 9/19/17 10:35 AM, Timofey Titovets wrote: >> Stupid question: >> Does btrfs use crc32 for error correction? >> If no, why? >> >> (AFAIK if using CRC that possible to fix 1 bit flip) >

Re: Does btrfs use crc32 for error correction?

2017-09-19 Thread Timofey Titovets
2017-09-19 21:04 GMT+03:00 Marat Khalili : > Would be cool, but probably not wise IMHO, since on modern hardware you > almost never get one-bit errors (usually it's a whole sector of garbage), and > therefore you'd more often see an incorrect recovery than actually fixed bit. > -- >

Re: Does btrfs use crc32 for error correction?

2017-09-19 Thread Marat Khalili
Would be cool, but probably not wise IMHO, since on modern hardware you almost never get one-bit errors (usually it's a whole sector of garbage), and therefore you'd more often see an incorrect recovery than actually fixed bit. -- With Best Regards, Marat Khalili -- To unsubscribe from this

Re: Does btrfs use crc32 for error correction?

2017-09-19 Thread Eric Sandeen
On 9/19/17 10:35 AM, Timofey Titovets wrote: > Stupid question: > Does btrfs use crc32 for error correction? > If no, why? > > (AFAIK if using CRC that possible to fix 1 bit flip) > > P.S. I try check that (i create image, create text file, flip bit, try > read

Re: Does btrfs use crc32 for error correction?

2017-09-19 Thread Hugo Mills
On Tue, Sep 19, 2017 at 06:35:48PM +0300, Timofey Titovets wrote: > Stupid question: > Does btrfs use crc32 for error correction? It uses it for error _detection_. On read, it'll verify the data (or metadata) against the checksum. With no reduncancy (single, RAID-0), a bad csum

Does btrfs use crc32 for error correction?

2017-09-19 Thread Timofey Titovets
Stupid question: Does btrfs use crc32 for error correction? If no, why? (AFAIK if using CRC that possible to fix 1 bit flip) P.S. I try check that (i create image, create text file, flip bit, try read and btrfs show IO-error) Thanks! -- Have a nice day, Timofey. -- To unsubscribe from