Re: [PATCH -v3 3/4 cifs] NTLMv2/NTLMSSP define crypto hash functions and create and send keys needed for key exchange

2010-09-14 Thread Jeff Layton
On Mon, 13 Sep 2010 14:15:39 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Mark dependency on crypto modules in Kconfig. Defining per structures sdesc and cifs_secmech which are used to store crypto hash functions and contexts. They are

Re: [PATCH] cifs: fix potential double put of TCP session reference

2010-09-14 Thread Jeff Layton
On Tue, 14 Sep 2010 15:18:32 +0530 Suresh Jayaraman sjayara...@suse.de wrote: On 09/13/2010 11:32 PM, Jeff Layton wrote: cifs_get_smb_ses must be called on a server pointer on which it holds an active reference. It first does a search for an existing SMB session. If it finds one, it'll put

Re: [PATCH -v3 3/4 cifs] NTLMv2/NTLMSSP define crypto hash functions and create and send keys needed for key exchange

2010-09-14 Thread Shirish Pargaonkar
On Tue, Sep 14, 2010 at 7:33 AM, Jeff Layton jlay...@redhat.com wrote: On Mon, 13 Sep 2010 14:15:39 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Mark dependency on crypto modules in Kconfig. Defining per structures sdesc and cifs_secmech

Re: [PATCH -v3 3/4 cifs] NTLMv2/NTLMSSP define crypto hash functions and create and send keys needed for key exchange

2010-09-14 Thread Jeff Layton
On Tue, 14 Sep 2010 09:15:38 -0500 Shirish Pargaonkar shirishpargaon...@gmail.com wrote: +                             /* 5 is an empirical value, large enought to +                              * hold authenticate message, max 10 of +                              * av paris,

Re: [PATCH -v3 3/4 cifs] NTLMv2/NTLMSSP define crypto hash functions and create and send keys needed for key exchange

2010-09-14 Thread Shirish Pargaonkar
On Tue, Sep 14, 2010 at 9:33 AM, Jeff Layton jlay...@redhat.com wrote: On Tue, 14 Sep 2010 09:15:38 -0500 Shirish Pargaonkar shirishpargaon...@gmail.com wrote: +                             /* 5 is an empirical value, large enought to +                              * hold authenticate

Re: [PATCH] cifs: fix potential double put of TCP session reference

2010-09-14 Thread Jeff Layton
On Tue, 14 Sep 2010 10:19:56 -0500 Steve French smfre...@gmail.com wrote: On Tue, Sep 14, 2010 at 6:39 AM, Jeff Layton jlay...@redhat.com wrote: On Tue, 14 Sep 2010 15:18:32 +0530 Suresh Jayaraman sjayara...@suse.de wrote: On 09/13/2010 11:32 PM, Jeff Layton wrote: cifs_get_smb_ses

[PATCH] cifs: fix potential double put of TCP session reference

2010-09-14 Thread Jeff Layton
cifs_get_smb_ses must be called on a server pointer on which it holds an active reference. It first does a search for an existing SMB session. If it finds one, it'll put the server reference and then try to ensure that the negprot is done, etc. If it encounters an error at that point then it'll

Re: [PATCH -v3 3/4 cifs] NTLMv2/NTLMSSP define crypto hash functions and create and send keys needed for key exchange

2010-09-14 Thread Shirish Pargaonkar
On Tue, Sep 14, 2010 at 7:33 AM, Jeff Layton jlay...@redhat.com wrote: On Mon, 13 Sep 2010 14:15:39 -0500 shirishpargaon...@gmail.com wrote: From: Shirish Pargaonkar shirishpargaon...@gmail.com Mark dependency on crypto modules in Kconfig. Defining per structures sdesc and cifs_secmech