virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

The patch for commit: 5c06273401f2eb7b290cadbae18ee00f8f65e893 Author: Amit Shah Date: Sun Jul 27 07:34:01 2014 +0930 virtio: rng: delay hwrng_register() till driver is ready moved the call to hwrng_register() out of the probe routine into the scan routine. We need

Re: [Part2 PATCH v7 14/38] crypto: ccp: Implement SEV_FACTORY_RESET ioctl command

On Wed, Nov 01, 2017 at 04:15:59PM -0500, Brijesh Singh wrote: > The SEV_FACTORY_RESET command can be used by the platform owner to > reset the non-volatile SEV related data. The command is defined in > SEV spec section 5.4 > > Cc: Paolo Bonzini > Cc: "Radim Krčmář"

Re: [PATCH 1/2] crypto: tcrypt - fix S/G table for test_aead_speed()

On Tue, Oct 10, 2017 at 01:21:59PM +0300, Robert Baronescu wrote: > In case buffer length is a multiple of PAGE_SIZE, > the S/G table is incorrectly generated. > Fix this by handling buflen = k * PAGE_SIZE separately. > > Signed-off-by: Robert Baronescu > --- >

Re: [PATCH 1/2] x86/crypto/sha256-mb: fix panic due to unaligned access

On Mon, Oct 16, 2017 at 06:51:30PM +0300, Andrey Ryabinin wrote: > struct sha256_ctx_mgr allocated in sha256_mb_mod_init() via kzalloc() > and later passed in sha256_mb_flusher_mgr_flush_avx2() function where > instructions vmovdqa used to access the struct. vmovdqa requires > 16-bytes aligned

Re: [PATCH] crypto: ccm - preserve the IV buffer

On Tue, Oct 31, 2017 at 03:42:35PM +0100, Romain Izard wrote: > The IV buffer used during CCM operations is used twice, during both the > hashing step and the ciphering step. > > When using a hardware accelerator that updates the contents of the IV > buffer at the end of ciphering operations, the

Re: [PATCH 1/3] crypto: atmel-aes/tdes/sha - return appropriate error code

On Mon, Oct 23, 2017 at 06:34:39PM +0300, Tudor Ambarus wrote: > Return -ENODEV when dma_request_slave_channel_compat() fails. > > Signed-off-by: Tudor Ambarus Patch applied. Thanks. -- Email: Herbert Xu Home Page:

Re: [PATCH] crypto: caam/qi - abort algorithm setup on DPAA2 parts

On Tue, Oct 24, 2017 at 09:27:31AM +0300, Horia Geantă wrote: > caam/qi frontend (i.e. caamalg_qi) mustn't be used in case it runs on a > DPAA2 part (this could happen when using a multiplatform kernel). > > Fixes: 297b9cebd2fc ("crypto: caam/jr - add support for DPAA2 parts") > Signed-off-by:

Re: [PATCH v10 00/20] simplify crypto wait for async op

On Wed, Oct 18, 2017 at 08:00:32AM +0100, Gilad Ben-Yossef wrote: > Many users of kernel async. crypto services have a pattern of > starting an async. crypto op and than using a completion > to wait for it to end. > > This patch set simplifies this common use case in two ways: > > First, by

Re: [PATCH] crypto: caam - fix incorrect define

On Tue, Oct 24, 2017 at 09:27:30AM +0300, Horia Geantă wrote: > From: Radu Alexe > > Fixes: 3ebfa92f49a6 ("crypto: caam - Add new macros for building extended SEC > descriptors (> 64 words)") > Signed-off-by: Radu Alexe > Signed-off-by: Horia Geantă

Re: [PATCH 3/3] crypto: atmel-aes/tdes/sha - remove useless irq init

On Mon, Oct 23, 2017 at 06:34:41PM +0300, Tudor Ambarus wrote: > irq would be set to -1 and then unused, if we failed to get IORESOURCE_MEM. > > Signed-off-by: Tudor Ambarus Patch applied. Thanks. -- Email: Herbert Xu Home Page:

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

On 03/11/2017 13:06, PrasannaKumar Muralidharan wrote: Hi Jim, On 3 November 2017 at 15:27, Jim Quigley wrote: The patch for commit: 5c06273401f2eb7b290cadbae18ee00f8f65e893 Author: Amit Shah Date: Sun Jul 27 07:34:01 2014 +0930

Re: [PATCH] crypto: ccp: remove unused variable qim

On Thu, Oct 12, 2017 at 05:55:41PM +0100, Colin King wrote: > From: Colin Ian King > > Variable qim is assigned but never read, it is redundant and can > be removed. > > Cleans up clang warning: Value stored to 'qim' is never read > > Fixes: 4b394a232df7 ("crypto: ccp

Re: [PATCH] crypto: qat: remove unused and redundant pointer vf_info

On Thu, Oct 12, 2017 at 06:04:56PM +0100, Colin King wrote: > From: Colin Ian King > > The pointer vf_info is being assigned but never read, it is redundant > and therefore can be removed. > > Cleans up clang warning: Value stored to 'vf_info' is never read > > Fixes:

Re: [PATCH] MAINTAINERS: update caam crypto driver maintainers list

On Fri, Oct 13, 2017 at 03:01:23PM +0300, Horia Geantă wrote: > Dan steps down as caam maintainer, being replaced by Aymen. > > Signed-off-by: Horia Geantă Patch applied. Thanks. -- Email: Herbert Xu Home Page:

Re: [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs

On Thu, Oct 12, 2017 at 05:55:29PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH 0/3] crypto: marvell - Remove the old CESA driver

On Wed, Oct 11, 2017 at 03:16:16PM +0200, Boris Brezillon wrote: > Hello, > > It's been several releases since we added a new driver to support the > CESA IP (the new driver was introduced in 4.2). It seems most major > bugs have been discovered and fixed and now is probably a good time to > kill

Re: [PATCH] crypto: cavium: clean up clang warning on unread variable offset

On Thu, Oct 12, 2017 at 05:44:06PM +0100, Colin King wrote: > From: Colin Ian King > > The variable offset is being assigned and not being used; it should > be passed as the 2nd argument to call to function nitrox_write_csr > but has been omitted. Fix this. > > Cleans

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

Hi Jim, On 3 November 2017 at 15:27, Jim Quigley wrote: > The patch for > > commit: 5c06273401f2eb7b290cadbae18ee00f8f65e893 > Author: Amit Shah > Date: Sun Jul 27 07:34:01 2014 +0930 > > virtio: rng: delay hwrng_register() till driver is

Re: [PATCH v2 1/7] crypto:chelsio: Remove unused parameter

On Sun, Oct 08, 2017 at 01:37:18PM +0530, Harsh Jain wrote: > From: Yeshaswi M R Gowda > > Remove unused parameter sent to latest fw. > > Signed-off-by: Harsh Jain All applied. Thanks. -- Email: Herbert Xu Home Page:

Re: [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs

Quoting Herbert Xu : On Thu, Oct 12, 2017 at 05:55:29PM -0500, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva

Fwd: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

Did reply instead of reply all. Forwarding my previous message. -- Forwarded message -- From: PrasannaKumar Muralidharan Date: 3 November 2017 at 20:19 Subject: Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume To: Jim

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

Hi Jim, Have second thoughts on this. On 3 November 2017 at 20:55, PrasannaKumar Muralidharan wrote: >> >> It would be cleaner to just get rid of probe_common() altogether in that >> case, and do whatever >> needs to be done in

Re: [PATCH] crypto: marvell - Switch cipher algs to the skcipher interface

On Fri, Oct 13, 2017 at 03:30:32PM +0200, Boris Brezillon wrote: > crypto_alg is not supposed to be directly implemented by crypto engine > driver. Drivers should instead implement specialized interfaces like > ahash_alg or skcipher_alg. > > Migrate to all cipher algorithms to the skcipher_alg

Re: [PATCH 2/2] crypto: tcrypt - fix buffer lengths in test_aead_speed()

On Tue, Oct 10, 2017 at 01:22:00PM +0300, Robert Baronescu wrote: > Fix the way the length of the buffers used for > encryption / decryption are computed. > For e.g. in case of encryption, input buffer does not contain > an authentication tag. > > Signed-off-by: Robert Baronescu

Re: [PATCH] crypto: tcrypt: mark expected switch fall-throughs in do_test()

On Mon, Oct 09, 2017 at 02:43:21PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Cc: Herbert Xu > Cc: "David S. Miller" > Cc:

Re: [PATCH v8 0/2] crypto: s5p-sss: Add HASH support for Exynos

On Wed, Oct 25, 2017 at 05:27:33PM +0200, Kamil Konieczny wrote: > First patch change spaces to tabs, second adds HASH support for Exynos. > Changes: > > version 8: > - fixes suggested by Vladimir Zapolskiy: drop first condition check in > s5p_hash_import, delete unused include delay.h, fix

Re: [PATCH] drivers/crypto: Convert timers to use timer_setup()

On Wed, Oct 25, 2017 at 03:18:42AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Herbert Xu

Re: [PATCH 0/2] Fixes for the Atmel AES crypto module

On Tue, Oct 31, 2017 at 04:25:22PM +0100, Romain Izard wrote: > After encountering an issue with cts(cbc(aes)) in the Atmel AES module, > I have used tcrypt and libkcapi's test suite to validate my fix. This led > me to observe some other issues. > > This series includes the IV issue correction

Re: [PATCH] hw_random: core: Reset user selected rng by writing "" to rng_current

On Fri, Oct 27, 2017 at 10:34:04PM +0530, PrasannaKumar Muralidharan wrote: > User is able to select a chosen rng by writing its name to rng_current > but there is no way to reset it without unbinding the rng. Let user > write "" to rng_current and delesect the chosen rng. > > Signed-off-by:

Re: [PATCH] crypto: AF_ALG - remove locking in async callback

On Sun, Oct 29, 2017 at 09:39:30PM +0100, Stephan Müller wrote: > Am Mittwoch, 25. Oktober 2017, 17:26:31 CET schrieb Romain Izard: > > Hi Romain, > > the patch below should cover the issue you see. Would you mind testing it? > > Thanks > Stephan > > ---8<--- > > The code paths protected by

Re: [PATCH] crypto: AF_ALG - remove locking in async callback

Am Freitag, 3. November 2017, 14:20:16 CET schrieb Herbert Xu: Hi Herbert, > On Sun, Oct 29, 2017 at 09:39:30PM +0100, Stephan Müller wrote: > > Am Mittwoch, 25. Oktober 2017, 17:26:31 CET schrieb Romain Izard: > > > > Hi Romain, > > > > the patch below should cover the issue you see. Would

Business

I have a rather important business proposal for you, I shall provide you with details upon your response to my email.

[PATCH] crypto: chcr - Replace _manual_ swap with swap macro

Make use of the swap macro and remove unnecessary variable temp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/crypto/chelsio/chcr_algo.c | 5 + 1 file changed, 1

[cryptodev:master 125/166] FATAL: drivers/crypto/marvell/marvell-cesa: struct platform_device_id is not terminated with a NULL entry!

tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 7a373fd74a8d1c4882e0236cc38345cec1393505 commit: 7b0c3d693ce65900dd3c79766185f539fa37a29a [125/166] crypto: marvell - Add a platform_device_id table config: arm-multi_v7_defconfig (attached as

Re: [cryptodev:master 125/166] FATAL: drivers/crypto/marvell/marvell-cesa: struct platform_device_id is not terminated with a NULL entry!

Hi Herbert, On Sat, 4 Nov 2017 00:38:26 +0800 kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git > master > head: 7a373fd74a8d1c4882e0236cc38345cec1393505 > commit: 7b0c3d693ce65900dd3c79766185f539fa37a29a

Re: [Part2 PATCH v7 18/38] crypto: ccp: Implement SEV_PEK_CSR ioctl command

On Wed, Nov 01, 2017 at 04:16:03PM -0500, Brijesh Singh wrote: > The SEV_PEK_CSR command can be used to generate a PEK certificate > signing request. The command is defined in SEV spec section 5.7. > > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc:

Re: [PATCH] crypto: vmx - Use skcipher for ctr fallback

On Mon, Oct 16, 2017 at 08:54:19PM -0200, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH 2/4] crypto: dh - don't permit 'p' to be 0

On 11/02/2017 12:25 AM, Eric Biggers wrote: From: Eric Biggers If 'p' is 0 for the software Diffie-Hellman implementation, then dh_max_size() returns 0. In the case of KEYCTL_DH_COMPUTE, this causes ZERO_SIZE_POINTER to be passed to sg_init_one(), which with

Re: [Part2 PATCH v7 18/38] crypto: ccp: Implement SEV_PEK_CSR ioctl command

On 11/3/17 2:42 PM, Borislav Petkov wrote: ... >> +if (psp_master->sev_state == SEV_STATE_UNINIT) { >> +ret = __sev_platform_init_locked(psp_master->sev_init, >> >error); > Right, you're passing psp_master->sev_init (or whatever you're going to > end up calling it) down but

Re: [PATCH 12/12] hwrng: bcm63xx-rng: Remove since bcm2835-rng takes over

Florian Fainelli writes: > bcm2835-rng is now capable of supporting the BCM63xx hardware, so remove > the driver which duplicates the same functionality. > > Signed-off-by: Florian Fainelli > --- > drivers/char/hw_random/Kconfig | 13 --- >

Re: [PATCH 08/12] hwrng: bcm2835-rng: Abstract I/O accessors

Florian Fainelli writes: > In preparation for allowing BCM63xx to use this driver, we abstract I/O > accessors such that we can easily change those later on. > > Signed-off-by: Florian Fainelli > --- > drivers/char/hw_random/bcm2835-rng.c | 27

Re: [PATCH 12/12] hwrng: bcm63xx-rng: Remove since bcm2835-rng takes over

On 11/03/2017 01:18 PM, Eric Anholt wrote: > Florian Fainelli writes: > >> bcm2835-rng is now capable of supporting the BCM63xx hardware, so remove >> the driver which duplicates the same functionality. >> >> Signed-off-by: Florian Fainelli >> --- >>

Re: [PATCH 08/12] hwrng: bcm2835-rng: Abstract I/O accessors

On 11/03/2017 01:19 PM, Eric Anholt wrote: > Florian Fainelli writes: > >> In preparation for allowing BCM63xx to use this driver, we abstract I/O >> accessors such that we can easily change those later on. >> >> Signed-off-by: Florian Fainelli >> ---