Re: [RFC PATCH v1 0/1] *** crypto: AF_ALG: add compression support ***

2017-04-20 Thread abed mohammad kamaluddin
Hi Herbert, > I think we should convert ipcomp over to the new interface first > in order to make sure that we don't need to change the interface > which would be hard to do once we export it to user-space. Would it be acceptable if we export an algif interface using alg_type_compress, which is b

Re: [PATCH 4/8] crypto: KPP - add API crypto_kpp_set_params

2017-04-20 Thread Stephan Müller
Am Mittwoch, 19. April 2017, 16:51:54 CEST schrieb Benedetto, Salvatore: Hi Salvatore, > Hi Stephan, > > > -Original Message- > > From: keyrings-ow...@vger.kernel.org [mailto:keyrings- > > ow...@vger.kernel.org] On Behalf Of Stephan Müller > > Sent: Wednesday, April 19, 2017 12:06 AM > >

Re: [RFC PATCH v1 0/1] *** crypto: AF_ALG: add compression support ***

2017-04-20 Thread Herbert Xu
On Thu, Apr 20, 2017 at 12:39:58PM +0530, abed mohammad kamaluddin wrote: > Hi Herbert, > > > I think we should convert ipcomp over to the new interface first > > in order to make sure that we don't need to change the interface > > which would be hard to do once we export it to user-space. > > Wo

Re: [PATCH 3/6] ima: Simplify policy_func_show.

2017-04-20 Thread Mimi Zohar
On Tue, 2017-04-18 at 17:17 -0300, Thiago Jung Bauermann wrote: > If the func_tokens array uses the same indices as enum ima_hooks, > policy_func_show can be a lot simpler, and the func_* enum becomes > unnecessary. My main concern with separating the enumeration from the string definition is that

Re: [PATCH 5/6] MODSIGN: Export module signature definitions.

2017-04-20 Thread Mimi Zohar
On Tue, 2017-04-18 at 17:17 -0300, Thiago Jung Bauermann wrote: > IMA will use the module_signature format for append signatures, so export > the relevant definitions and factor out the code which verifies that the > appended signature trailer is valid. > > Also, create a CONFIG_MODULE_SIG_FORMAT

[PATCH v2 0/9] staging: ccree: add Arm TrustZone CryptoCell REE driver

2017-04-20 Thread Gilad Ben-Yossef
Arm TrustZone CryptoCell 700 is a family of cryptographic hardware accelerators. It is supported by a long lived series of out of tree drivers, which I am now in the process of unifying and upstreaming. This is the first drop, supporting the new CryptoCell 712 REE. The code still needs some cleanu

[PATCH v2 8/9] staging: ccree: add DT bindings for Arm CryptoCell

2017-04-20 Thread Gilad Ben-Yossef
This adds DT bindings for the Arm TrustZone CryptoCell cryptographic accelerator IP. Signed-off-by: Gilad Ben-Yossef --- .../devicetree/bindings/crypto/arm-cryptocell.txt | 27 ++ 1 file changed, 27 insertions(+) create mode 100644 drivers/staging/ccree/Documentation/devic

[PATCH v2 4/9] staging: ccree: add IV generation support

2017-04-20 Thread Gilad Ben-Yossef
Add CryptoCell IV hardware generation support. This patch adds the needed support to drive the HW but does not expose the ability via the kernel crypto API yet. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Makefile | 2 +- drivers/staging/ccree/ssi_buffer_mgr.c | 2 +

[PATCH v2 7/9] staging: ccree: add TODO list

2017-04-20 Thread Gilad Ben-Yossef
Add TODO list for moving out of staging tree for ccree crypto driver Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/TODO | 28 1 file changed, 28 insertions(+) create mode 100644 drivers/staging/ccree/TODO diff --git a/drivers/staging/ccree/TODO b/driver

[PATCH v2 5/9] staging: ccree: add AEAD support

2017-04-20 Thread Gilad Ben-Yossef
Add CryptoCell AEAD support Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig |1 + drivers/staging/ccree/Makefile |2 +- drivers/staging/ccree/cc_crypto_ctx.h | 21 + drivers/staging/ccree/ssi_aead.c | 2826 driv

[PATCH v2 6/9] staging: ccree: add FIPS support

2017-04-20 Thread Gilad Ben-Yossef
Add FIPS mode support to CryptoCell driver Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig |9 + drivers/staging/ccree/Makefile |1 + drivers/staging/ccree/ssi_aead.c|6 + drivers/staging/ccree/ssi_cipher.c | 52 + drivers/staging/c

[PATCH v2 9/9] MAINTAINERS: add Gilad BY as ccree maintainer

2017-04-20 Thread Gilad Ben-Yossef
I work for Arm on maintaining the TrustZone CryptoCell driver. Signed-off-by: Gilad Ben-Yossef --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 676c139..f21caa1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3066,6 +3066,13 @@ F: dr

[PATCH v2 3/9] staging: ccree: add skcipher support

2017-04-20 Thread Gilad Ben-Yossef
Add CryptoCell skcipher support Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig |8 + drivers/staging/ccree/Makefile |2 +- drivers/staging/ccree/cc_crypto_ctx.h | 21 + drivers/staging/ccree/ssi_buffer_mgr.c | 147 drivers/staging/ccree/ssi_bu

[PATCH v2 2/9] staging: ccree: add ahash support

2017-04-20 Thread Gilad Ben-Yossef
Add CryptoCell async. hash and HMAC support. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig |6 + drivers/staging/ccree/Makefile |2 +- drivers/staging/ccree/cc_crypto_ctx.h | 22 + drivers/staging/ccree/hash_defs.h | 78 + drivers/staging/cc

Re: [PATCH 3/5] KEYS: DH: don't feed uninitialized result memory into KDF

2017-04-20 Thread Stephan Müller
Am Donnerstag, 20. April 2017, 07:46:31 CEST schrieb Eric Biggers: Hi Eric, > From: Eric Biggers > > The result of the Diffie-Hellman computation may be shorter than the > input prime number. Only calculate the KDF over the actual result; > don't include additional uninitialized memory. Thank

Re: [PATCH v2 0/9] staging: ccree: add Arm TrustZone CryptoCell REE driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:12:54PM +0300, Gilad Ben-Yossef wrote: > Arm TrustZone CryptoCell 700 is a family of cryptographic hardware > accelerators. It is supported by a long lived series of out of tree > drivers, which I am now in the process of unifying and upstreaming. > This is the first drop

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > +++ b/drivers/staging/ccree/bsp.h > @@ -0,0 +1,21 @@ > +/* > + * Copyright (C) 2012-2016 ARM Limited or its affiliates. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of t

Re: [PATCH v2 0/9] staging: ccree: add Arm TrustZone CryptoCell REE driver

2017-04-20 Thread Gilad Ben-Yossef
On Thu, Apr 20, 2017 at 4:30 PM, Greg Kroah-Hartman wrote: > On Thu, Apr 20, 2017 at 04:12:54PM +0300, Gilad Ben-Yossef wrote: >> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware >> accelerators. It is supported by a long lived series of out of tree >> drivers, which I am now in

Re: [PATCH v2 6/9] staging: ccree: add FIPS support

2017-04-20 Thread Stephan Müller
Am Donnerstag, 20. April 2017, 15:13:00 CEST schrieb Gilad Ben-Yossef: Hi Gilad, > +/* The function verifies that tdes keys are not weak.*/ > +static int ssi_fips_verify_3des_keys(const u8 *key, unsigned int keylen) > +{ > +#ifdef CCREE_FIPS_SUPPORT > +tdes_keys_t *tdes_key = (tdes_keys_t

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread Gilad Ben-Yossef
On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartman wrote: > On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: >> +++ b/drivers/staging/ccree/bsp.h >> @@ -0,0 +1,21 @@ >> +/* >> + * Copyright (C) 2012-2016 ARM Limited or its affiliates. >> + * >> + * This program is free software;

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:40:56PM +0300, Gilad Ben-Yossef wrote: > On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartman > wrote: > > On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > >> +++ b/drivers/staging/ccree/bsp.h > >> @@ -0,0 +1,21 @@ > >> +/* > >> + * Copyright (C) 2012-2

Re: [PATCH 5/6] MODSIGN: Export module signature definitions.

2017-04-20 Thread David Howells
Mimi Zohar wrote: > On Tue, 2017-04-18 at 17:17 -0300, Thiago Jung Bauermann wrote: > > IMA will use the module_signature format for append signatures, so export > > the relevant definitions and factor out the code which verifies that the > > appended signature trailer is valid. > > > > Also, cr

Re: [RFC PATCH v1 0/1] *** crypto: AF_ALG: add compression support ***

2017-04-20 Thread abed mohammad kamaluddin
Hi Herbert, >> > I think we should convert ipcomp over to the new interface first >> > in order to make sure that we don't need to change the interface >> > which would be hard to do once we export it to user-space. >> >> Would it be acceptable if we export an algif interface using >> alg_type_co

[PATCH v2 0/2] hwrng: mtk: add support for hardware random generator on MT7623 SoC

2017-04-20 Thread sean.wang
From: Sean Wang This patchset introduces support for Mediatek hardware random generator (RNG) Currently, the driver is already tested successfully with rng-tools on MT7623 SoC. And it should also be workable on other similar Mediatek SoCs. Changes since v1: - remove unnecessary warning message -

[PATCH v2 1/2] dt-bindings: hwrng: Add Mediatek hardware random generator bindings

2017-04-20 Thread sean.wang
From: Sean Wang Document the devicetree bindings for Mediatek random number generator which could be found on MT7623 SoC or other similar Mediatek SoCs. Signed-off-by: Sean Wang Acked-by: Rob Herring --- Documentation/devicetree/bindings/rng/mtk-rng.txt | 18 ++ 1 file changed

[PATCH v2 2/2] hwrng: mtk: Add driver for hardware random generator on MT7623 SoC

2017-04-20 Thread sean.wang
From: Sean Wang This patch adds support for hardware random generator on MT7623 SoC and should also work on other similar Mediatek SoCs. Currently, the driver is already tested successfully with rng-tools. Signed-off-by: Sean Wang Reviewed-by: PrasannaKumar Muralidharan --- drivers/char/hw_ra

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread kbuild test robot
Hi Gilad, [auto build test ERROR on linus/master] [also build test ERROR on v4.11-rc7] [cannot apply to staging/staging-testing next-20170420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH] staging: ccree: fix array_size.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/staging/ccree/ssi_sysfs.c:319:34-35: WARNING: Use ARRAY_SIZE drivers/staging/ccree/ssi_sysfs.c:429:34-35: WARNING: Use ARRAY_SIZE Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element Semantic patch information: This makes an effort to find cases where ARRAY_SIZE can be

[PATCH] staging: ccree: fix semicolon.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/staging/ccree/ssi_request_mgr.c:623:3-4: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Gilad Ben-Yossef Signed-off-by: Fengguang Wu --- ssi_request_mgr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/driver

[PATCH] staging: ccree: fix ifnullfree.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/staging/ccree/ssi_buffer_mgr.c:530:3-19: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is

[PATCH] staging: ccree: fix platform_no_drv_owner.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/staging/ccree/ssi_driver.c:484:6-11: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Gilad Ben-Yossef Signed-off-by: Fengguang Wu --- ssi_driver.c

Re: [PATCH 3/5] KEYS: DH: don't feed uninitialized result memory into KDF

2017-04-20 Thread Eric Biggers
Hi Stephan, On Thu, Apr 20, 2017 at 03:27:17PM +0200, Stephan Müller wrote: > Am Donnerstag, 20. April 2017, 07:46:31 CEST schrieb Eric Biggers: > > Hi Eric, > > > From: Eric Biggers > > > > The result of the Diffie-Hellman computation may be shorter than the > > input prime number. Only calc

Re: [PATCH v2 2/9] staging: ccree: add ahash support

2017-04-20 Thread kbuild test robot
Hi Gilad, [auto build test WARNING on linus/master] [also build test WARNING on v4.11-rc7] [cannot apply to staging/staging-testing next-20170420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH] staging: ccree: fix ifnullfree.cocci warnings

2017-04-20 Thread kbuild test robot
drivers/staging/ccree/ssi_hash.c:317:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. drivers/staging/ccree/ssi_hash.c:320:2-7: WARNING: NU

Re: [PATCH 3/5] KEYS: DH: don't feed uninitialized result memory into KDF

2017-04-20 Thread Stephan Müller
Am Donnerstag, 20. April 2017, 19:46:02 CEST schrieb Eric Biggers: Hi Eric, > Hi Stephan, > > On Thu, Apr 20, 2017 at 03:27:17PM +0200, Stephan Müller wrote: > > Am Donnerstag, 20. April 2017, 07:46:31 CEST schrieb Eric Biggers: > > > > Hi Eric, > > > > > From: Eric Biggers > > > > > > The r

Re: [PATCH v2 5/9] staging: ccree: add AEAD support

2017-04-20 Thread kbuild test robot
Hi Gilad, [auto build test WARNING on linus/master] [also build test WARNING on v4.11-rc7] [cannot apply to staging/staging-testing next-20170420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH V3 1/2] crypto: ccp - Use only the relevant interrupt bits

2017-04-20 Thread Gary R Hook
Each CCP queue can product interrupts for 4 conditions: operation complete, queue empty, error, and queue stopped. This driver only works with completion and error events. Cc: # 4.9.x- Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-dev-v5.c |9 + drivers/crypto/ccp/ccp-dev.h

[PATCH V3 0/2] Interrupt management fixes

2017-04-20 Thread Gary R Hook
Correct the driver to attend to only relevant interrupt bits, and ensure that interrupts are managed properly at module unload. Changes from V2: - Apply patches to relevant stable branches Changes from V1: - Changed the #define to "SUPPORTED_INTERRUPTS" --- Gary R Hook (2): crypto: ccp -

[PATCH V3 1/2] crypto: ccp - Use only the relevant interrupt bits

2017-04-20 Thread Gary R Hook
Each CCP queue can product interrupts for 4 conditions: operation complete, queue empty, error, and queue stopped. This driver only works with completion and error events. Cc: # 4.9.x+ Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-dev-v5.c |9 + drivers/crypto/ccp/ccp-dev.h

[PATCH V3 2/2] crypto: ccp - Disable interrupts early on unload

2017-04-20 Thread Gary R Hook
From: Gary R Hook Ensure that we disable interrupts first when shutting down the driver. Cc: # 4.9.x+ Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-dev-v5.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp

[Patch V5 0/7] crypto: AES CBC multibuffer implementation

2017-04-20 Thread Megha Dey
In this patch series, we introduce AES CBC encryption that is parallelized on x86_64 cpu with XMM registers. The multi-buffer technique encrypt 8 data streams in parallel with SIMD instructions. Decryption is handled as in the existing AESNI Intel CBC implementation which can already parallelize de

[Patch V5 4/7] crypto: AES CBC by8 encryption

2017-04-20 Thread Megha Dey
This patch introduces the assembly routine to do a by8 AES CBC encryption in support of the AES CBC multi-buffer implementation. It encrypts 8 data streams of the same key size simultaneously. Originally-by: Chandramouli Narayanan Signed-off-by: Megha Dey Acked-by: Tim Chen --- arch/x86/crypt

[Patch V5 7/7] crypto: AES CBC multi-buffer tcrypt

2017-04-20 Thread Megha Dey
The tcrypt test framework for CBC multi-buffer testing is laid out in this patch. Tcrypt has been extended to validate the functionality and performance of AES CBC multi-buffer support. A new test(mode=600) has been added to test the speed of the multibuffer case, as multi-buffer encrypt will wait

Re: [PATCH 3/6] ima: Simplify policy_func_show.

2017-04-20 Thread Thiago Jung Bauermann
Am Donnerstag, 20. April 2017, 08:13:23 BRT schrieb Mimi Zohar: > On Tue, 2017-04-18 at 17:17 -0300, Thiago Jung Bauermann wrote: > > If the func_tokens array uses the same indices as enum ima_hooks, > > policy_func_show can be a lot simpler, and the func_* enum becomes > > unnecessary. > > My mai

[Patch V5 6/7] crypto: AES vectors for AES CBC multibuffer testing

2017-04-20 Thread Megha Dey
For more robust testing of AES CBC multibuffer support, additional test vectors have been added to the AES CBC encrypt/decrypt test case. Originally-by: Chandramouli Narayanan Signed-off-by: Megha Dey Acked-by: Tim Chen --- crypto/testmgr.h | 1456 ++

[Patch V5 5/7] crypto: AES CBC multi-buffer glue code

2017-04-20 Thread Megha Dey
This patch introduces the multi-buffer job manager which is responsible for submitting scatter-gather buffers from several AES CBC jobs to the multi-buffer algorithm. The glue code interfaces with the underlying algorithm that handles 8 data streams of AES CBC encryption in parallel. AES key expans

[Patch V5 3/7] crypto: AES CBC multi-buffer scheduler

2017-04-20 Thread Megha Dey
This patch implements in-order scheduler for encrypting multiple buffers in parallel supporting AES CBC encryption with key sizes of 128, 192 and 256 bits. It uses 8 data lanes by taking advantage of the SIMD instructions with XMM registers. The multibuffer manager and scheduler is mostly written

[Patch V5 2/7] crypto: AES CBC multi-buffer data structures

2017-04-20 Thread Megha Dey
This patch introduces the data structures and prototypes of functions needed for doing AES CBC encryption using multi-buffer. Included are the structures of the multi-buffer AES CBC job, job scheduler in C and data structure defines in x86 assembly code. Originally-by: Chandramouli Narayanan Sign

[Patch V5 1/7] crypto: Multi-buffer encryption infrastructure support

2017-04-20 Thread Megha Dey
In this patch, the infrastructure needed to support multibuffer encryption implementation is added: a) Enhance mcryptd daemon to support skcipher requests. b) Add multi-buffer simd skcipher helper which presents the top-level algorithm as an skcipher. b) Update configuration to include multi-

Re: [PATCH 5/6] MODSIGN: Export module signature definitions.

2017-04-20 Thread Thiago Jung Bauermann
Am Donnerstag, 20. April 2017, 15:37:37 BRT schrieb David Howells: > Mimi Zohar wrote: > > On Tue, 2017-04-18 at 17:17 -0300, Thiago Jung Bauermann wrote: > > > IMA will use the module_signature format for append signatures, so > > > export > > > the relevant definitions and factor out the code wh

Re: [PATCH V3 1/2] crypto: ccp - Use only the relevant interrupt bits

2017-04-20 Thread Gary R Hook
On 04/20/2017 03:20 PM, Hook, Gary wrote: Each CCP queue can product interrupts for 4 conditions: operation complete, queue empty, error, and queue stopped. This driver only works with completion and error events. Apologies for this errant submission. Please ignore one of these (V3 1/2); the p

Re: [PATCH 6/6] ima: Support appended signatures for appraisal

2017-04-20 Thread Thiago Jung Bauermann
Am Donnerstag, 20. April 2017, 11:04:40 BRT schrieb kbuild test robot: >In file included from security/integrity/ima/ima_appraise.c:19:0: > >include/keys/asymmetric-type.h: In function 'asymmetric_key_ids': > >> include/keys/asymmetric-type.h:76:12: error: dereferencing pointer to > >> inc

Re: [Patch V5 1/7] crypto: Multi-buffer encryption infrastructure support

2017-04-20 Thread kbuild test robot
Hi Megha, [auto build test ERROR on next-20170420] [also build test ERROR on v4.11-rc7] [cannot apply to crypto/master sparc-next/master v4.9-rc8 v4.9-rc7 v4.9-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [Patch V5 7/7] crypto: AES CBC multi-buffer tcrypt

2017-04-20 Thread kbuild test robot
Hi Megha, [auto build test WARNING on next-20170420] [also build test WARNING on v4.11-rc7] [cannot apply to crypto/master sparc-next/master v4.9-rc8 v4.9-rc7 v4.9-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [Patch V5 7/7] crypto: AES CBC multi-buffer tcrypt

2017-04-20 Thread kbuild test robot
Hi Megha, [auto build test WARNING on next-20170420] [also build test WARNING on v4.11-rc7] [cannot apply to crypto/master sparc-next/master v4.9-rc8 v4.9-rc7 v4.9-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [Patch V5 1/7] crypto: Multi-buffer encryption infrastructure support

2017-04-20 Thread kbuild test robot
Hi Megha, [auto build test ERROR on next-20170420] [also build test ERROR on v4.11-rc7] [cannot apply to crypto/master sparc-next/master v4.9-rc8 v4.9-rc7 v4.9-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH 3/5] KEYS: DH: don't feed uninitialized result memory into KDF

2017-04-20 Thread Eric Biggers
Hi Stephan, On Thu, Apr 20, 2017 at 08:38:30PM +0200, Stephan Müller wrote: > > > > By the way: do we really need this in the kernel at all, given that it's > > just doing some math on data which userspace has access to? > > It is the question about how we want the keys subsystem to operate. The

[PATCH 0/3] Add more algorithms and some misc cleanups

2017-04-20 Thread George Cherian
This series adds more algorithem support for CPT. Add support for -ecb(aes) -cfb(aes) -ecb(des3_ede) Some cleanups too. George Cherian (3): crypto: cavium: Downgrade the annoying misc interrupt print from dev_err to dev_dbg crypto: cavium: Remove the individual e

[PATCH 2/3] crypto: cavium: Remove the individual encrypt/decrypt function for each algorithm

2017-04-20 Thread George Cherian
Remove the individual encrypt/decrypt function for easch algorithm. This is in prepration of adding more crypto algorithms supported by hardware. While at that simplify create_ctx_hdr/create_input_list function interfaces. Signed-off-by: George Cherian --- drivers/crypto/cavium/cpt/cptvf_algs.c

[PATCH 3/3] crypto: cavium: Add more algorithms

2017-04-20 Thread George Cherian
Add more algorithm support for the driver. Add support for ecb(aes), cfb(aes) and ecb(des3_ede). Signed-off-by: George Cherian --- drivers/crypto/cavium/cpt/cptvf_algs.c | 63 ++ 1 file changed, 63 insertions(+) diff --git a/drivers/crypto/cavium/cpt/cptvf_algs.c

[PATCH 1/3] crypto: cavium: Downgrade the annoying misc interrupt print from dev_err to dev_dbg

2017-04-20 Thread George Cherian
Mailbox interrupt is common and it is not an error interrupt. So downgrade the print from dev_err to dev_dbg. Signed-off-by: George Cherian --- drivers/crypto/cavium/cpt/cptvf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cavium/cpt/cptvf_main.c b/dr