On Fri, Apr 21, 2017 at 01:36:45PM +0200, Corentin Labbe wrote:
> > > > + memset(ipad + keylen, 0, blocksize - keylen);
> > > > + memcpy(opad, ipad, blocksize);
> > > > +
> > > > + for (i = 0; i < blocksize; i++) {
> > > > + ipad[i] ^= 0x36;
> > > > + o
> > > + memset(ipad + keylen, 0, blocksize - keylen);
> > > + memcpy(opad, ipad, blocksize);
> > > +
> > > + for (i = 0; i < blocksize; i++) {
> > > + ipad[i] ^= 0x36;
> > > + opad[i] ^= 0x5c;
> >
> > What are these constant ?
>
> They are defined in the HMAC RFC, as ipad and opad
Hi Corentin,
On Fri, Apr 21, 2017 at 09:30:56AM +0200, Corentin Labbe wrote:
>
> I have some minor comment below
[…]
> > + /*
> > +* Result Descriptor Ring prepare
> > +*/
>
> This is not preferred comment format for one line
Sure.
>
> [...]
>
> > +static int safexcel_probe(struc
Hello
I have some minor comment below
On Wed, Apr 19, 2017 at 09:14:17AM +0200, Antoine Tenart wrote:
> Add support for Inside Secure SafeXcel EIP197 cryptographic engine,
> which can be found on Marvell Armada 7k and 8k boards. This driver
> currently implements: ecb(aes), cbc(aes), sha1, sha224