for determining the dirty-page
capabilities available on backing devices directly or on the backing devices
associated with a mapping. These are provided to keep line length down when
checking for the capabilities.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
diff -uNrp /warthog/kernels/linux-2.6.11-rc4
Andrew Morton [EMAIL PROTECTED] wrote:
The attached patch replaces backing_dev_info::memory_backed with
capabilitied bitmap.
Looks sane to me, thanks.
I hope you got all the conversions correct - breakage in the writeback
dirty accounting manifests in subtle ways. I'll double-check
We've come across an interesting problem with NFS4 mount on a PPC64 box. If
the mount program is compiled as PPC32, then the mount() syscall is returned
EFAULT.
It turns out that NFS4 requires potentially more data than can be put in a
single page, something sys_mount() enforces as a hard limit.
Benjamin LaHaise [EMAIL PROTECTED] wrote:
Oh dear, this is going to take a while. In any case, here is such a
first step in creating such a sequence of patches. Located at
http://www.kvack.org/~bcrl/patches/mutex-A0/ are the following patches:
...
10_new_mutex.diff - Replaces the
Trond Myklebust [EMAIL PROTECTED] wrote:
AFAICS You grab the wait_queue_t lock once in down()/__mutex_lock()
order to try to take the lock (or queue the waiter if that fails), then
once more in order to pass the mutex on to the next waiter on
up()/mutex_unlock(). That is more or less the
Benjamin LaHaise [EMAIL PROTECTED] wrote:
What about the use of atomic operations on frv? Are they more lightweight
than a semaphore, making for a better fastpath?
What do you mean? Atomic ops don't compare to semaphores.
On FRV atomic ops don't disable interrupts; they reserve one of the
Trond Myklebust [EMAIL PROTECTED] wrote:
We've come across an interesting problem with NFS4 mount on a PPC64 box. If
the mount program is compiled as PPC32, then the mount() syscall is returned
EFAULT.
So, why is this not a case of Doctor it hurts...?
Because:
(1) The kernel is
Christoph Hellwig [EMAIL PROTECTED] wrote:
I don't think we should encourage filesystem writers to do such stupid
things as ncfps/smbfs do. In fact I'm totally unhappy thay nfs4 went
down that road.
The problem with NFS4, I think, is that the mount syscall sets a hard limit on
the amount of
Trond Myklebust [EMAIL PROTECTED] wrote:
Without such a library, it is pointless to contemplate other callers.
With such a library, you will have a single point for switching between
32bit and 64 bit.
Other callers include such as busybox, sash and uClinux. I'm not sure about
such as Perl,
Al Viro [EMAIL PROTECTED] wrote:
Architecture-dependent blob passed to mount(2) (aka nfs4_mount_data).
If you want it to be a blob, at least have a decency to use encoding
that would not depend on alignment rules and word size. Hell, you
could use XDR - it's not that nfs would need
Randy Dunlap [EMAIL PROTECTED] wrote:
CACHEFILES uses PROC_FS, so make it a Kconfig depends.
Thanks, but the new and improved CacheFiles doesn't use procfs as Christoph
Hellwig objects to such a practice. In any case, Andrew Morton has dropped it
from -mm as it's now obsolete.
David
-
To
Acked-By: David Howells [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
, on the other hand, is done through the
scatter-gather list interface as the amount of data is sufficient that the
expense of doing virtual address to page calculations is sufficiently small by
comparison.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
crypto/blkcipher.c |2 +
crypto/pcbc.c
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can
use it too.
The kdoc comments I've attached to the functions needs to be checked by whoever
wrote them as I had to make some guesses about the workings of these functions.
Signed-Off-By: David Howells [EMAIL PROTECTED
The first of these patches together provide secure client-side RxRPC
connectivity as a Linux kernel socket family. Only the RxRPC transport/session
side is supplied - the presentation side (marshalling the data) is left to the
client. Copies of the patches can be found here:
-Off-By: David Howells [EMAIL PROTECTED]
---
Documentation/keys.txt | 12
include/linux/key.h |2 ++
security/keys/keyring.c |2 ++
3 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/Documentation/keys.txt b/Documentation/keys.txt
index 60c665d..81d9aa0
Export try_to_del_timer_sync() for use by the RxRPC module.
Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to
cancel a delayed work timer.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
include/linux/workqueue.h | 21 +
kernel/timer.c
the error number from a local or network error message.
int rxrpc_kernel_get_error_number(struct sk_buff *skb);
This is used to extract the error number from a message indicating either
a local error occurred or a network error occurred.
Signed-Off-By: David Howells [EMAIL PROTECTED
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can
use it too.
The kdoc comments I've attached to the functions needs to be checked by whoever
wrote them as I had to make some guesses about the workings of these functions.
Signed-Off-By: David Howells [EMAIL PROTECTED
-Off-By: David Howells [EMAIL PROTECTED]
---
Documentation/keys.txt | 12
include/linux/key.h |2 ++
security/keys/keyring.c |2 ++
3 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/Documentation/keys.txt b/Documentation/keys.txt
index 60c665d..81d9aa0
Export try_to_del_timer_sync() for use by the RxRPC module.
Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to
cancel a delayed work timer.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
include/linux/workqueue.h | 21 +
kernel/timer.c
the error number from a local or network error message.
int rxrpc_kernel_get_error_number(struct sk_buff *skb);
This is used to extract the error number from a message indicating either
a local error occurred or a network error occurred.
Signed-Off-By: David Howells [EMAIL PROTECTED
The first of these patches together provide secure client-side RxRPC
connectivity as a Linux kernel socket family. Only the RxRPC transport/session
side is supplied - the presentation side (marshalling the data) is left to the
client. Copies of the patches can be found here:
These patches build on the patchset labelled AF_RXRPC socket family and AFS
rewrite. The patches are also available for http download.
Firstly, the patches fix a number of bugs in AF_RXRPC:
http://people.redhat.com/~dhowells/rxrpc/09-af_rxrpc-own-workqueues.diff
-By: David Howells [EMAIL PROTECTED]
---
net/rxrpc/af_rxrpc.c | 17 ++---
net/rxrpc/ar-accept.c | 12 ++--
net/rxrpc/ar-ack.c| 10 +-
net/rxrpc/ar-call.c | 16
net/rxrpc/ar-connection.c |8
net/rxrpc/ar
that was supposed
to have one available and didn't.
In association with this, more assertions have been added to check this.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
net/rxrpc/ar-call.c | 59 +
net/rxrpc/ar-connection.c | 20
Fix a deadlock in the give-up-callback aggregator dispatcher work item whereby
the aggregator runs on keventd as does timed autounmount, thus leading to the
unmount blocking keventd whilst waiting for keventd to run the aggregator when
the give-up-callback buffer is full.
Signed-Off-By: David
-By: David Howells [EMAIL PROTECTED]
---
include/keys/rxrpc-type.h | 22 ++
net/rxrpc/af_rxrpc.c |2 ++
net/rxrpc/ar-key.c| 10 +-
net/rxrpc/ar-output.c |6 +-
4 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/include/keys/rxrpc
from sb-s_flags.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/afs/super.c | 26 --
1 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/fs/afs/super.c b/fs/afs/super.c
index efc4fe6..77e6875 100644
--- a/fs/afs/super.c
+++ b/fs/afs/super.c
@@ -212,7
Correctly alter the relocation state after update is complete by switching it
from Updating to Valid.
Also display the record state in the vlocation database proc file.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/afs/proc.c | 15 +--
fs/afs/vlocation.c |4
J. Bruce Fields [EMAIL PROTECTED] wrote:
Just curious--when is the actual crypto done? There doesn't seem to be
any in this patch.
See AF_RXRPC patch:
http://people.redhat.com/~dhowells/rxrpc/04-af_rxrpc.diff
You turn on CONFIG_RXKAD and load the rxkad module thus built (assuming
Nate Diller [EMAIL PROTECTED] wrote:
-static struct page *afs_dir_get_page(struct inode *dir, unsigned long index)
NAK. This conflicts with my AFS security patches, and eliminates any way of
passing the key through to readpage().
David
-
To unsubscribe from this list: send the line
Nate Diller [EMAIL PROTECTED] wrote:
Hmmm you're right. Is your security work going into the next -mm?
I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it
to go through DaveM's networking tree?
If so, I'll just re-base this cleanup patch on that ... at the very least
Andrew Morton [EMAIL PROTECTED] wrote:
Hmmm you're right. Is your security work going into the next -mm?
I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it
to go through DaveM's networking tree?
AF_RXRPC is a davem thing and AFS: Add security support and
Nate Diller [EMAIL PROTECTED] wrote:
but that's a lot of code to avoid a single stack allocation. The
whole fake file pointer thing still strikes me as a little ugly, and
you're definitely not the first one who needed this sort of hackery.
ugh
A better way might be to stick a void * in
Hi Al,
I think there might be a problem in the VFS with d_revalidate() not being
called enough on mountpoints. As far as I can tell from the printks in my AFS
stuff, it's only called on the mounted-on dentry, and not the vfsmount-root
dentry. However, with NFS at least (not so much AFS), can
Hi Al,
What d_xxx() functions should I call at the end of a filesystem mkdir() op?
It would seem that I've got two choices:
(1) just d_instantiate() (as ext2), or
(2) d_instantiate() and d_rehash() both (as NFS).
If I pick (1), then if I do:
mkdir
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can
use it too.
The kdoc comments I've attached to the functions needs to be checked by whoever
wrote them as I had to make some guesses about the workings of these functions.
Signed-Off-By: David Howells [EMAIL PROTECTED
The first of these patches together provide secure client-side RxRPC
connectivity as a Linux kernel socket family. Only the RxRPC transport/session
side is supplied - the presentation side (marshalling the data) is left to the
client. Copies of the patches can be found here:
-By: David Howells [EMAIL PROTECTED]
---
include/linux/workqueue.h |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 2a7b38d..b8abfc7 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
Export try_to_del_timer_sync() for use by the AF_RXRPC module.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
kernel/timer.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/timer.c b/kernel/timer.c
index dd6c2c1..b22bd39 100644
--- a/kernel/timer.c
+++ b
-Off-By: David Howells [EMAIL PROTECTED]
---
Documentation/keys.txt | 12
include/linux/key.h |2 ++
security/keys/keyring.c |2 ++
3 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/Documentation/keys.txt b/Documentation/keys.txt
index 60c665d..81d9aa0
from sb-s_flags.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/afs/super.c | 26 --
1 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/fs/afs/super.c b/fs/afs/super.c
index efc4fe6..77e6875 100644
--- a/fs/afs/super.c
+++ b/fs/afs/super.c
@@ -212,7
[NETLINK]: Mirror UDP MSG_TRUNC semantics.
If the user passes MSG_TRUNC in via msg_flags, return
the full packet size not the truncated size.
Idea from Herbert Xu and Thomas Graf.
Signed-off-by: David S. Miller [EMAIL PROTECTED]
---
net/netlink/af_netlink.c |3 +++
1 files
Implement the CB.InitCallBackState3 operation for the fileserver to call.
This reduces the amount of network traffic because if this op is aborted, the
fileserver will then attempt an CB.InitCallBackState operation.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/afs/AFS_CM.h|1
through all the network interfaces using RTNETLINK
to pull out the MAC address of the lowest index interface to use in UUID
construction.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/afs/AFS_CM.h|3
fs/afs/Makefile|1
fs/afs/cmservice.c | 98
Update the AFS fs documentation.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
Documentation/filesystems/afs.txt | 214 +++--
1 files changed, 154 insertions(+), 60 deletions(-)
diff --git a/Documentation/filesystems/afs.txt
b/Documentation/filesystems
The first of these patches together provide secure client-side RxRPC
connectivity as a Linux kernel socket family. Only the RxRPC transport/session
side is supplied - the presentation side (marshalling the data) is left to the
client. Copies of the patches can be found here:
-By: David Howells [EMAIL PROTECTED]
---
include/linux/workqueue.h |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 2a7b38d..b8abfc7 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
from sb-s_flags.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/afs/super.c | 26 --
1 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/fs/afs/super.c b/fs/afs/super.c
index efc4fe6..77e6875 100644
--- a/fs/afs/super.c
+++ b/fs/afs/super.c
@@ -212,7
Implement the CB.InitCallBackState3 operation for the fileserver to call.
This reduces the amount of network traffic because if this op is aborted, the
fileserver will then attempt an CB.InitCallBackState operation.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/afs/afs_cm.h|1
[NETLINK]: Mirror UDP MSG_TRUNC semantics.
If the user passes MSG_TRUNC in via msg_flags, return
the full packet size not the truncated size.
Idea from Herbert Xu and Thomas Graf.
Signed-off-by: David S. Miller [EMAIL PROTECTED]
---
net/netlink/af_netlink.c |3 +++
1 files
through all the network interfaces using RTNETLINK
to pull out the MAC address of the lowest index interface to use in UUID
construction.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/afs/Makefile|1
fs/afs/afs_cm.h|3
fs/afs/cmservice.c | 98
-Off-By: David Howells [EMAIL PROTECTED]
---
Documentation/keys.txt | 12
include/linux/key.h |2 ++
security/keys/keyring.c |2 ++
3 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/Documentation/keys.txt b/Documentation/keys.txt
index 60c665d..81d9aa0
Export try_to_del_timer_sync() for use by the AF_RXRPC module.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
kernel/timer.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/timer.c b/kernel/timer.c
index dd6c2c1..b22bd39 100644
--- a/kernel/timer.c
+++ b
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can
use it too.
The kdoc comments I've attached to the functions needs to be checked by whoever
wrote them as I had to make some guesses about the workings of these functions.
Signed-Off-By: David Howells [EMAIL PROTECTED
David Miller [EMAIL PROTECTED] wrote:
Then please generate your patches against my net-2.6.21 GIT
tree. Most of your initial patches in the series (the SKB
routine one for example) are already in my tree.
Do you mean your net-2.6.22 GIT tree?
Do you want me to make it available as a GIT
Make the match_*() functions take a const pointer to the options table and
make strings pointers in the options table const too.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
include/linux/parser.h |8
lib/parser.c | 10 +-
2 files changed, 9 insertions
() as this
breaks on m68k. Patch from Geert Uytterhoeven [EMAIL PROTECTED].
(*) Use match_*() functions rather than doing my own parsing.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/Kconfig|1 -
fs/afs/fsclient.c |3 +-
fs/afs/super.c| 100
Geert Uytterhoeven [EMAIL PROTECTED] wrote:
I've just noticed another issue: if CONFIG_AFS_FS=y, the kernel build fails
with
Can you send me the config you're using please?
David
-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to [EMAIL
Fix use of __exit functions from __init path.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/afs/callback.c |2 +-
fs/afs/internal.h |4 ++--
fs/afs/vlocation.c |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/afs/callback.c b/fs/afs/callback.c
index
Add __dev_getfirstbyhwtype for callers that don't want a reference but
some data from the device and thus need to take the rtnl anyway.
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
Signed-off-by: David Howells [EMAIL PROTECTED]
---
include/linux/netdevice.h |1 +
net/core/dev.c
The interface array is not freed on exit.
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/afs/cmservice.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/afs/cmservice.c b/fs/afs/cmservice.c
index 6685f4c
Replace the large and complicated rtnetlink client by two simple
functions for getting the MAC address for the first ethernet device
and building a list of IPv4 addresses.
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/afs/Makefile
.
This means, for example, that if AFS does a large StoreData op, all the
packets barring the last will be filled to the maximum unfragmented size.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
net/rxrpc/ar-ack.c| 80 ++---
net/rxrpc/ar-error.c
).
(4) Rename some afs_file_*() functions to afs_*() where they apply to
non-regular files too.
(5) Be consistent about the presentation of volume ID:vnode ID in debugging
output.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/afs/callback.c |9 ++
fs/afs/dir.c
Andrew Morton [EMAIL PROTECTED] wrote:
+ BUG_ON(i_size 0x); // TODO: use 64-bit store
You're sure this isn't user-triggerable?
Hmmm... I'm not. I'll whip up a patch for this.
kmap_atomic() could be used here and is better.
Yeah. It used to have something that slept in the
) Similarly, the outer loop in afs_pages_written_back() must also do an
extra iteration if it ends with 'first == last', otherwise it fails to
clear PG_writeback on the last page under some circumstances.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/afs/rxrpc.c |2 +-
fs/afs
Reduce debugging noise generated by AF_RXRPC.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
net/rxrpc/ar-peer.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/rxrpc/ar-peer.c b/net/rxrpc/ar-peer.c
index ce08b78..90fa107 100644
--- a/net/rxrpc/ar-peer.c
can
see. Trival fix attached (compile tested only).
Signed-Off-By: Mika Kukkonen [EMAIL PROTECTED]
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/afs/write.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/afs/write.c b/fs/afs/write.c
index 67ae4db..28f3751
invalidate_inode_pages2() instead on non-regular files.
(2) afs_vnode_deleted_remotely() should handle vnodes that don't have a
source server recorded without oopsing.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/afs/file.c |2 +-
fs/afs/inode.c | 10 +++---
fs
Andrew Morton [EMAIL PROTECTED] wrote:
Yes, it's a shame that there doesn't seem to be a fine-grained way of
turning on -W's useful bits.
You can turn off -W's undesirable bits. For net/rxrpc/ and fs/afs/ at least,
adding:
CFLAGS += -W -Wno-unused-parameter
to the Makefile generates
Andrew Morton [EMAIL PROTECTED] wrote:
More than one would expect, given that it is recommended in
Documentation/SubmitChecklist, which everyone reads ;)
Which states incorrectly:
| 22: Newly-added code has been compiled with `gcc -W'. This will generate
| lots of noise, but is good for
Add a dependency for CONFIG_AF_RXRPC on CONFIG_INET. This fixes this error:
net/built-in.o: In function `rxrpc_get_peer':
(.text+0x42824): undefined reference to `ip_route_output_key'
Signed-off-by: David Howells [EMAIL PROTECTED]
---
net/rxrpc/Kconfig |2 +-
1 files changed, 1 insertions
Make the call state names array available even if CONFIG_PROC_FS is disabled
as it's used in other places (such as debugging statements) too.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
net/rxrpc/ar-call.c | 19 +++
net/rxrpc/ar-proc.c | 19 ---
2
, then
page_mkwrite() will flush it before attaching a record of the new key.
[try #2] Only flush the page if the page is still part of the mapping (truncate
may have discarded it).
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/afs/file.c | 22 --
fs/afs/internal.h |1 +
fs
David Chinner [EMAIL PROTECTED] wrote:
+ ret = block_prepare_write(page, 0, end, get_block);
As I understand the way prepare_write() works, this is incorrect.
The start and end points passed to block_prepare_write() delimit the region of
the page that is going to be modified. This means
Nick Piggin [EMAIL PROTECTED] wrote:
I would strongly suggest you used (0, PAGE_CACHE_SIZE) for the range,
That tells prepare_write() that the region to be modified is the whole page -
which is incorrect. We're going to change a little bit of it.
Hmmm... Thinking about it again, I probably
David Woodhouse [EMAIL PROTECTED] wrote:
Really? Is it _really_ going to be modified?
Well, generic_file_buffered_write() doesn't check the success of the copy
before calling commit_write(), presumably because it uses
fault_in_pages_readable() first.
David
-
To unsubscribe from this list: send
Nick Piggin [EMAIL PROTECTED] wrote:
In general (modulo bugs and crazy filesystems), you're not allowed to have
!uptodate pages mapped into user addresses because that implies the user
would be allowed to see garbage.
Ths situation I have to deal with is a tricky one. Consider:
(1) User A
Nick Piggin [EMAIL PROTECTED] wrote:
I can't call invalidate_inode_pages() or similar because that might
incorrectly kill one of B's writes (or someone else's writes); besides,
the on-server file hasn't changed.
Why would that kill anyone's writes?
Because invalidate_inode_pages()
Nick Piggin [EMAIL PROTECTED] wrote:
How do you do a write-through cache for shared-writable mmap?
For shared writable mmap? I don't know...
You can't do write-through caching for shared-writable mmap because the writes
go directly into the pagecache once the page is made writable, at
Hugh Dickins [EMAIL PROTECTED] wrote:
VM in a way that people are not unhappy with :)
I'm hoping you intended one less negative ;)
Or did you mean one fewer negative? :-)
David
-
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to [EMAIL
Nick Piggin [EMAIL PROTECTED] wrote:
No, you shouldn't. We could theoretically introduce a new API for this,
but I think it would be preferable if you can fix the race in the fs.
Actually, I might be able to do better.
When making a StoreData call to the AFS server, I send all the parameters
J. Bruce Fields [EMAIL PROTECTED] wrote:
+ if (!afs_lock_manager) {
+ afs_lock_manager = create_singlethread_workqueue(kafs_lockd);
+ if (!afs_lock_manager)
+ return -ENOMEM;
+ }
+ return 0;
Doesn't this need some locking?
Oops. Yes.
Kyle Moffett [EMAIL PROTECTED] wrote:
I was actually under the impression that OpenAFS had support for byte-
range locking (as well as lock upgrade/downgrade);
As far as I know, there is no support for byte-range locking at all in the AFS
protocol itself. The client can try to emulate
Randy Dunlap [EMAIL PROTECTED] wrote:
Don't use explicit extern specifier and quieten sparse warning:
fs/afs/vnode.c:564:12: warning: function 'afs_vnode_link' with external
linkage has definition
Acked-By: David Howells [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line
J. Bruce Fields [EMAIL PROTECTED] wrote:
Do you allow upgrades and downgrades? (Just curious.)
AFS does not, as far as I know.
So if I request a write lock while holding a read lock, my request will
be denied?
At the moment, yes. Don't the POSIX and flock lock-handling routines in
J. Bruce Fields [EMAIL PROTECTED] wrote:
At the moment, yes. Don't the POSIX and flock lock-handling routines in the
kernel normally do that anyway?
No, they'd upgrade in that case.
I just checked. The OpenAFS server supports neither lock upgrading nor lock
downgrading. Attempts to do
locking.
Regrading of locks is not currently supported as this is not supported by the
server. Byte-range locking is also not currently supported for the same
reason.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/afs/Makefile|1
fs/afs/afs.h |8 +
fs/afs/afs_fs.h
J. Bruce Fields [EMAIL PROTECTED] wrote:
--without having tried to understand how they're actually used, these
data structures (like the pending_locks and granted_locks lists) seem to
duplicate stuff that's already kept in fs/locks.c. Is there a reason
they're required?
Yes. I need to get
J. Bruce Fields [EMAIL PROTECTED] wrote:
Yes. I need to get the server lock first, before going to the VFS locking
routines.
That doesn't really answer the question. The NFS client has similar
requirements, but it doesn't have to duplicate the per-inode lists of
granted locks, for
Make NFS root work by creating a /root directory to satisfy the mount,
otherwise the path lookup for the mount fails with ENOENT.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
init/do_mounts.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/init/do_mounts.c b
Andrew Morton [EMAIL PROTECTED] wrote:
What is not working, and how does this patch fix it?
It turns out that this patch is unnecessary. The problem had to do with the
initcalling of default_rootfs() (or lack of initcalling in this case). I
fixed vmlinux.lds.S and it works now.
David
-
To
) to do the honours.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
mm/readahead.c | 40 ++--
1 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/mm/readahead.c b/mm/readahead.c
index 39bf45d..12d1378 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
to detect this.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/splice.c|2 +-
include/linux/page-flags.h | 30 +-
include/linux/pagemap.h| 11 +++
mm/filemap.c | 16
mm/migrate.c
Provide an add_wait_queue_tail() function to add a waiter to the back of a
wait queue instead of the front.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
include/linux/wait.h |1 +
kernel/wait.c| 18 ++
2 files changed, 19 insertions(+), 0 deletions(-)
diff
This one-line patch fixes the missing export of copy_page introduced
by the cachefile patches. This patch is not yet upstream, but is required
for cachefile on ia64. It will be pushed upstream when cachefile goes
upstream.
Signed-off-by: Prarit Bhargava [EMAIL PROTECTED]
Signed-Off-By: David
for this that uses the prepare_write() and
commit_write() address_space operations to bound a copy directly into the page
cache.
Hook the Ext2 and Ext3 operations to the generic implementation.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/ext2/inode.c|2 +
fs/ext3/inode.c|3
-Off-By: David Howells [EMAIL PROTECTED]
---
include/linux/pagemap.h |5 +
mm/filemap.c| 19 +++
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index d1049b6..452fdcf 100644
--- a/include/linux
1 - 100 of 417 matches
Mail list logo
