force the access with
option -f. But then there are plenty of ways to corrupt any device that
way, regardless of the driver (or even without any driver bound to the
device, if you run multiple i2c-dev-based user-space tools in
parallel.) So I'd say this is not relevant.
--
Jean Delvare
SUSE L3 Suppo
Hi Corentin,
On Wed, 18 Nov 2015 13:55:56 +0100, LABBE Corentin wrote:
> The simple_strtoul function is marked as obsolete.
> This patch replace it by kstrtou8.
>
> Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com>
Reviewed-by: Jean Delvare <jdelv...@suse.de>
t; return 0;
> }
> }
Thanks for the patch. Note that you don't strictly need the "err"
variable as you never use its value.
Reviewed-by: Jean Delvare <jdelv...@suse.de>
Tested-by: Jean Delvare <jdelv...@suse.de>
--
Jean De
with 1-byte page (default)
> 3.9 KB/s with 128-byte* page (via platform data)
>
> *limited to 31-bytes by I2C_SMBUS_BLOCK_MAX - 1.
>
> Signed-off-by: Nate Case <nc...@xes-inc.com>
> Signed-off-by: Aaron Sierra <asie...@xes-inc.c
I2C_SMBUS_BLOCK_MAX;
if (use_smbus && write_max > smbus_limit)
write_max = smbus_limit;
This might not even be slower, and IMHO it is easier to understand.
> at24->wri
On Thu, 5 Nov 2015 11:40:25 -0800, Alexandra Yates wrote:
> Adding Intel codename Lewisburg platform device IDs for SMBus.
>
> Signed-off-by: Alexandra Yates <alexandra.ya...@linux.intel.com>
> Reviewed-by: Jean Delvare <jdelv...@suse.de>
> ---
> Documen
POINT_H_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
... and now in the middle of the last list? I would appreciate more
consistency.
These are all details of course, overall the changes look good, so you
can add:
Reviewed-by: J
use_smbus_write = I2C_SMBUS_BYTE_DATA;
> chip.page_size = 1;
> @@ -599,7 +692,8 @@ static int at24_probe(struct i2c_client *client, const
> struct i2c_device_id *id)
> if (write_max > io_limit)
>
return err;
While in general I am in favor of passing error values down the stack,
here I'm not sure. kstrtou8 could return -ERANGE or -EINVAL which makes
no sense as an i2c adapter fault code. According to
Documentation/i2c/fault-codes, -EPROTO or -EIO would be more
appropriate.
>
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BAYTRAIL_SMBUS) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LBG_SMBUS) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LBG_SSKU_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID
Hi Aaron,
On Mon, 2 Nov 2015 10:35:22 -0600 (CST), Aaron Sierra wrote:
> - Original Message -
> > From: "Jean Delvare" <jdelv...@suse.de>
> > Sent: Monday, November 2, 2015 7:42:09 AM
> > On Thu, 3 Sep 2015 14:52:35 -0500 (CDT), Aaron Sierra wrote:
i2c_check_functionality(client->adapter,
> I2C_FUNC_SMBUS_WRITE_BYTE_DATA)) {
> use_smbus_write = I2C_SMBUS_BYTE_DATA;
> chip.page_size = 1;
Like patch 1/3, the code you are adding in this patch can't be tested.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ter than nothing
> + * (e.g. read @ 1.4 KiB/s).
> + */
> + use_smbus = I2C_SMBUS_BYTE_DATA;
> + } else if (i2c_check_functionality(client->adapter,
> I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
> use_smbus = I2C_SMBUS_I2C_BLOCK_DATA;
> } else if (i2c_check_functionality(client->adapter,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
slave I2C address if you want to be able to talk to them
from the Pi. Check the python code and the hardware documentation, the
slave address is certainly mentioned there.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body o
>> 1 in the first place? You only need to
steal one byte from the data buffer for the extra address byte, so
I'd expect write_max to be capped at I2C_SMBUS_BLOCK_MAX - 1.
> at24->write_max = write_max;
>
> /* buffer (data + address at
e exact list of commands included in your specific case depends what
the packager decided to do. I suppose that commands that are not
relevant on the Raspberry Pi are not included in the package.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux
Le Monday 26 October 2015 à 13:31 +0200, Mika Westerberg a écrit :
> On Mon, Oct 26, 2015 at 01:26:56PM +0200, Jarkko Nikula wrote:
> > Add missing entries into i2c-i801 documentation and Kconfig about recently
> > added Intel DNV and Broxton.
> >
> > Suggested-by: Jea
priv->features |= FEATURE_IRQ;
> priv->features |= FEATURE_SMBUS_PEC;
Looks good, but please also update Documentation/i2c/busses/i2c-i801
and drivers/i2c/busses/Kconfig.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
it in the switch block in i801_probe().
Please also update Documentation/i2c/busses/i2c-i801 and
drivers/i2c/busses/Kconfig.
Thanks,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
r the late reply. The error is caused by the following
combination of options:
CONFIG_I2C=m
CONFIG_I2C_I801=y
I can reproduce it even with mainline now. This is caused by
CONFIG_ITCO_WDT=y, which selects CONFIG_I2C_I801=y without selecting
its dependencies (CONFIG_I2C.)
Thanks for reporting, I'll po
<jim.ep...@gmail.com>
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Fixes: 2a7a0e9bf7 ("watchdog: iTCO_wdt: Add support for TCO on Intel
Sunrisepoint")
Cc: Matt Fleming <matt.flem...@intel.com>
Cc: Guenter Roeck <li...@roeck-us.net>
Cc: Lee Jones <lee.jo..
Hi Guenter,
Le Friday 25 September 2015 à 06:29 -0700, Guenter Roeck a écrit :
> On 09/25/2015 01:10 AM, Jean Delvare wrote:
> > ITCO_WDT selects I2C_I801 but does not select its dependencies (I2C.)
> > This can result in link-time failures:
> >
> > drivers/built-in.
Le Friday 25 September 2015 à 14:37 +0100, Matt Fleming a écrit :
> On Fri, 25 Sep, at 09:36:10AM, Jean Delvare wrote:
> > On Wed, 12 Aug 2015 08:42:18 -0700, Jim Davis wrote:
> > > Building with the attached random configuration file,
> > >
> >
PEC 0x0008
> #define I2C_FUNC_NOSTART 0x0010 /* I2C_M_NOSTART */
> #define I2C_FUNC_SLAVE 0x0020
> +#define I2C_FUNC_NO_CLK_STRETCH 0x0040 /* No check for SCL
> low */
> #define I2C_FUNC_SMBUS_BLOCK_PROC_CALL
On Tue, 22 Sep 2015 13:41:27 -0400, Benjamin Tissoires wrote:
> Hi All,
>
> any estimate when anybody will be able to review this series?
It's on my to-do list, hopefully this week or early next week. For the
core part it's probably better if Wolfram can do the review.
--
Jean Delvar
s/i2ctransfer.c
> new file mode 100644
> index 000..27f4d7a
> --- /dev/null
> +++ b/tools/i2ctransfer.c
> @@ -0,0 +1,320 @@
> +/*
> +i2ctransfer.c - A user-space program to send concatenated i2c messages
> +Copyright (C) 2015 Wolfram Sang <w...@sang-enginee
The first part of the comment is wrong since November 2007, delete it.
The second part of the comment is related to I2C_PEC, not I2C_SLAVE, so
move it where it belongs.
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Cc: Wolfram Sang <w...@the-dreams.de>
---
drivers/i2c/i2c-
On Thu, 10 Sep 2015 20:00:12 +0200, Wolfram Sang wrote:
> On Tue, Sep 08, 2015 at 11:05:49AM +0200, Jean Delvare wrote:
> > The ioctl is named I2C_RDWR for "I2C read/write". But references to it
> > were misspelled "rdrw". Fix them.
> >
> > Signed
;> even
> >> if the usage cli API is still a moving target.
> >
> > I don't think it is anymore TBH. Not more than any other tool.
> >
> > Waiving to Jean \o_ :)
>
> OK, let me wave as well \\O//
Review in progress, will continue tomorrow.
--
Jean Delvare
On Wed, 29 Jul 2015 10:58:13 -0400, Benjamin Tissoires wrote:
On Sat, Jul 25, 2015 at 5:38 PM, Jean Delvare jdelv...@suse.de wrote:
On Sat, 25 Jul 2015 12:22:02 -0400, Benjamin Tissoires wrote:
On Sat, Jul 25, 2015 at 12:11 PM, Jean Delvare jdelv...@suse.de wrote:
Hi Benjamin,
On Tue
Hi Benjamin,
On Tue, 21 Jul 2015 17:24:55 -0400, Benjamin Tissoires wrote:
So please disregard this series, I will send a v4 hopefully soonish.
From v2 directly to v4? Did I miss something?
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c
On Sat, 25 Jul 2015 12:22:02 -0400, Benjamin Tissoires wrote:
On Sat, Jul 25, 2015 at 12:11 PM, Jean Delvare jdelv...@suse.de wrote:
Hi Benjamin,
On Tue, 21 Jul 2015 17:24:55 -0400, Benjamin Tissoires wrote:
So please disregard this series, I will send a v4 hopefully soonish.
From v2
= ADM1025, ADM1030 and ADM1031 evaluation boards\n
6 = Barco LPT-DVI (K5800236) adapter\n
7 = One For All JP1 parallel port adapter\n
+ 8 = VCT-jig\n
);
Looks good.
Reviewed-by: Jean Delvare jdelv...@suse.de
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send
On Tue, 7 Jul 2015 17:22:33 +0200, Jean Delvare wrote:
Hi Matwey,
On Mon, 29 Jun 2015 21:14:47 +0300, Matwey V. Kornilov wrote:
Move eeprog to separate subdir and implement Module.mk for it
Signed-off-by: Matwey V. Kornilov matwey.korni...@gmail.com
---
eeprog/24cXX.c | 185
On Tue, 7 Jul 2015 10:23:33 -0400, Benjamin Tissoires wrote:
Hi Jean,
On Jun 29 2015 or thereabouts, Jean Delvare wrote:
Hi Benjamin,
On Tue, 23 Jun 2015 14:58:18 -0400, Benjamin Tissoires wrote:
SMBus Host Notify allows a slave device to act as a master on a bus to
notify
*client, unsigned int data);
+
/* This is the very generalized SMBus access routine. You probably do not
want to use this, though; one of the functions below may be much easier,
and probably just as fast.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line
need to set different
CFLAGS (or LDFLAGS) for different parts of i2c-tools? Seems overkill to
me.
If you really need that then this should be done consistently for all
modules: not just tools but also lib and now eeprog.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line
On Tue, 7 Jul 2015 16:16:38 -0400, Benjamin Tissoires wrote:
On Jul 07 2015 or thereabouts, Jean Delvare wrote:
So you use the same driver callback for SMBus Alert and SMBus Host
Notify. This makes some sense, but if a given driver supports both, how
does it know which event happened
.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
)
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
directory would be integrated into the build system while the rest of
the eepromer directory would be left alone (and ultimately deleted.)
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More
and is already looking at the problem.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
let's add a switch which will
only link functions from libi2c statically.
Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com
---
Makefile| 4
tools/Module.mk | 4
2 files changed, 8 insertions(+)
(...)
Applied, thanks!
--
Jean Delvare
SUSE L3 Support
. Not recursive.
external projects if embrace it or no. Honestly I think that a
minuscule file with really low maintenance should be added.
I'm glad to prepare a new patch if maintainership is interested!
I'm not.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line
is set when
BUILD_STATIC_LIB isn't and complain about it?
TOOLS_TARGETS:= i2cdetect i2cdump i2cset i2cget
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo
On Wed, 17 Jun 2015 11:23:38 +0200, Angelo Compagnucci wrote:
Please, please, find that time! I really would like to package
i2c-tools 3.1 with python3 support in buildroot!
OK, releasing i2c-tools 3.1.2 was easy after all, it's done now.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from
Hi Angelo,
On Tue, 26 May 2015 09:56:47 +0200, Angelo Compagnucci wrote:
Dear Jean Delvare,
Now that python3 support was added to python-smbus, could you release
a new stable version with it?
This way, py-smbus with python3 support could be included in
distributions that usually don't
that USE_STATIC_LIB = 1 would silently imply
BUILD_STATIC_LIB = 1? Yes, that's much better than my proposal.
I'm wondering if we should make it even more flexible, but I'm not sure
if it's worth the effort... Are you calling make install after that?
I guess not.
--
Jean Delvare
SUSE L3 Support
Delvare jdelv...@suse.de
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the code is not completely safe, as
we still don't check for ($code 0x7F) being 0, nor do we verify that
$count 0x7F does not exceed the number of elements in @vendors. I'll
fix that.
Thanks,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c
]};
$manufacturer = $vendors[$count 0x7F][($code 0x7F) - 1];
$manufacturer =~ s/ \(former .*\)$// if $opt_side_by_side;
$manufacturer .= ? (Invalid parity) if parity($count) != 1;
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c
Microelectronics,
Phyworks, MediaTek, Non-cents Productions, US Modular,
Wintegra Ltd, Mathstar, StarCore, Oplus Technologies,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info
) if parity($count) != 1;
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
($ai, $first), \@bytes);
}
sub manufacturer_data(@)
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Semiconductor, Socionext Inc., HGST, EVGA,
+ Audience Inc., EpicGear, Vitesse Enterprise Co.,
+ Foxtronn International Corporation, Bretelon Inc.,
+ Zbit Semiconductor Inc.]
);
$use_sysfs = -d '/sys/bus';
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe
in the future and still readable IMO.
It was having space originally. I changed that into tab as it was
looking good with them as aligned.
As the driver maintainer, I am fine with both unaligned or tab-aligned.
Space-aligned as I did originally was not a good idea, I admit.
--
Jean Delvare
100644 Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
create mode 100644 drivers/i2c/busses/i2c-mt65xx.c
Why have you sent me this?
Mind you, I was wondering exactly the same ;-)
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c
that
code to the i2c-i801 driver. Daniel, any comment on this?
Equally mysterious to me is:
priv-status |= status;
in i801_isr() where it would seem that a simple = would suffice.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux
I2C controllers.
Jean, my tests went well and so I want to brush it up for inclusion into
i2c-tools upstream. Any show-stoppers you see from a high-level point of
view?
I think it is a good idea, just I couldn't find the time to review it,
sorry :(
--
Jean Delvare
SUSE L3 Support
Hi Ellen,
On Wed, 15 Apr 2015 13:46:17 -0700, Ellen Wang wrote:
On 4/15/2015 5:08 AM, Jean Delvare wrote:
On Mon, 13 Apr 2015 17:11:59 -0700, Ellen Wang wrote:
On a CRC error while using hardware-supported PEC, an additional
error bit is set in the auxiliary status register. If this bit
into this ASAP. A
quick comparison between our patches suggests that yours only clears
the PEC status bit while mine also reports the error properly to the
caller, so mine might be a better working base. Maybe you could review
and/or test my patch as a replacement of yours?
Thanks,
--
Jean Delvare
Acked-by: Wolfram Sang w...@the-dreams.de
I don't know if I should take it. If so, let me know.
Don't, the series was nacked meanwhile.
Thanks,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord
, and the manual pages too.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
/pci_ids.h,
and then add a case for your subdevice ID at the right place in
drivers/pci/quirks.c. Then please give it very good testing, to make sure
that the unhidden SMBus doesn't conflict with e.g. ACPI.
No objection from me.
Reviewed-by: Jean Delvare jdelv...@suse.de
--
Jean Delvare
SUSE L3
.)
Thanks,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
/drivers/i2c/busses/i2c-i801.c
@@ -1324,7 +1324,7 @@ static int i801_resume(struct pci_dev *dev)
{
pci_set_power_state(dev, PCI_D0);
pci_restore_state(dev);
- return pci_enable_device(dev);
+ return 0;
}
#else
#define i801_suspend NULL
Reviewed-by: Jean Delvare jdelv
long pcim_iomap_regions line splitted
- gotos and error labels removed
---
drivers/i2c/busses/i2c-i801.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
(...)
Reviewed-by: Jean Delvare jdelv...@suse.de
Wolfram, please commit this series, I have reviewed all
Hi Jarkko,
On Fri, 13 Feb 2015 13:13:18 +0200, Jarkko Nikula wrote:
On 02/13/2015 12:33 PM, Jean Delvare wrote:
This looks reasonable but have you tested this change on a range of
actual laptops to make sure it has no unexpected side effect?
Unfortunately I have only limited amount of test
long long)pci_resource_end(dev, SMBBAR));
goto exit;
}
Looks good.
Reviewed-by: Jean Delvare jdelv...@suse.de
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More
);
pci_release_region(dev, SMBBAR);
- kfree(priv);
/*
* do not call pci_disable_device(dev) since it can cause hard hangs on
* some systems during power-off (eg. Fujitsu-Siemens Lifebook E8010)
Reviewed-by: Jean Delvare jdelv...@suse.de
--
Jean Delvare
SUSE L3 Support
);
- pci_release_region(dev, SMBBAR);
-
/*
* do not call pci_disable_device(dev) since it can cause hard hangs on
* some systems during power-off (eg. Fujitsu-Siemens Lifebook E8010)
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux
On Fri, 13 Feb 2015 13:47:07 +0200, Jarkko Nikula wrote:
On 02/13/2015 12:47 PM, Jean Delvare wrote:
On Wed, 11 Feb 2015 14:32:08 +0200, Jarkko Nikula wrote:
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 5fb35464f693..9f7b69743233 100644
--- a/drivers
to
devm_request_region?
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to make that
two separate patches with better descriptions.
And if I'm wrong then the patch needs a better description too ;-)
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Mon, 26 Jan 2015 19:05:09 +0100, Wolfram Sang wrote:
On Mon, Jan 26, 2015 at 07:00:47PM +0100, Jean Delvare wrote:
Make the slave support depend on CONFIG_I2C_SLAVE. Otherwise it gets
included unconditionally, even when it is not needed.
Signed-off-by: Jean Delvare jdelv...@suse.de
Make the slave support depend on CONFIG_I2C_SLAVE. Otherwise it gets
included unconditionally, even when it is not needed.
I2C bus drivers which implement slave support must select
I2C_SLAVE.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Wolfram Sang w...@the-dreams.de
---
Changes since v2
Make the slave support depend on CONFIG_I2C_SLAVE. Otherwise it gets
included unconditionally, even when it is not needed.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Wolfram Sang w...@the-dreams.de
---
Changes since v1:
* Let I2C_RCAR select I2C_SLAVE
Wolfram, you mentioned i2c-sh_mobile
it
will become messy if these are required in device drivers as well.
Hmm, what about bus drivers with slave mode support must select
CONFIG_I2C_SLAVE? This solves my problem nicely, and makes no change
compared to the current situation for people using slave mode.
Thanks,
--
Jean Delvare
SUSE L3
On Thu, 22 Jan 2015 14:28:10 +0100, Michael Mercier wrote:
I have only tested read_i2c_block_data write_i2c_block_data for python
3.2 and python 2.7.
I think you can push these patchs upstream.
I committed both patches. I also added python 3 support to the stable
branch.
--
Jean Delvare
it when
CONFIG_I2C_SLAVE is set. Alternatively the code could be moved to a
separate module altogether. What do you think?
Thanks,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More
, thanks for testing :)
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-32mu.so: undefined
symbol: i2c_smbus_process_call
Any idea?
Not really, again I know nothing about python. But didn't you have the
same problem with Angelo's patch?
Maybe Angelo has an idea.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c
$(DISTUTILS) build
But please keep in mind that my python knowledge is non-existent so it
might be plain wrong. Hopefully Angelo can comment on this.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord
Hi Angelo,
On Mon, 19 Jan 2015 16:13:26 +0100, Angelo Compagnucci wrote:
Dear Jean Delvare,
Attached you can find a patch that implements py-smbus for python3
with python2 backward compatibility.
This patch is not heavily tested, but it wors well for me.
Thanks a lot for your work. I
Hi Wolfram,
On Mon, 19 Jan 2015 10:31:38 +0100, Wolfram Sang wrote:
Having the maintainer on CC helps to see i2c-tools related messages in
the bulk of messages for the Linux kernel I2C subsystem.
Signed-off-by: Wolfram Sang w...@the-dreams.de
Cc: Jean Delvare jdelv...@suse.de
---
README
can't imagine that this is not
possible.
Unfortunately, as long as nobody contributes a patch which makes
py-smbus work for both python version 2 and version 3, I can't apply
it. I don't think it makes sense to break compatibility with one
version to make the other one work.
--
Jean Delvare
SUSE
be grateful ;-)
That being said, if this completion serves no other purpose then it
can go away, I don't mind.
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Wed, 14 Jan 2015 15:54:52 +0200, Pantelis Antoniou wrote:
On Jan 14, 2015, at 15:49 , Jean Delvare jdelv...@suse.de wrote:
That being said, nobody complained about this in 11 years, so I would
be surprised if it was plain wrong. I'd rather question the test code.
Where is it?
No-one
Hi Guenter,
On Wed, 14 Jan 2015 08:24:43 -0800, Guenter Roeck wrote:
On Wed, Jan 14, 2015 at 04:15:25PM +0100, Jean Delvare wrote:
I did that. On my system the i2c-i801 driver instantiates an
i2c-mux-gpio device. Unloading the i2c-i801 driver removes that device
and it works fine. Note
takes a reference to the underlying i2c_adapter.
That being said, nobody complained about this in 11 years, so I would
be surprised if it was plain wrong. I'd rather question the test code.
Where is it?
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux
Hi Uwe,
On Tue, 25 Nov 2014 22:14:32 +0100, Uwe Kleine-König wrote:
On Wed, Jan 08, 2014 at 02:28:49PM +0100, Jean Delvare wrote:
Having looked at the code in deeper detail, I think I understand what
is going on. The problem is with:
i2c_set_adapdata(priv-adapter, priv
the actual problem is.
i2c-i801: Use wait_event_timeout to wait for interrupts
i2c-i801: Fallback to polling if request_irq() fails
i2c-i801: Check if interrupts are disabled
i2c-i801: Drop useless debug message
Changes since v1:
* Updated according to Wolfram's review. Thanks!
--
Jean Delvare
SUSE L3
Some systems have been reported to have trouble with interrupts. Use
wait_event_timeout() instead of wait_event() so we don't get stuck in
that case, and log the problem.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Wolfram Sang w...@the-dreams.de
---
No change since v1.
drivers/i2c/busses
The i2c-i801 driver can work without interrupts, so there is no reason
to make a request_irq failure fatal. Instead we can simply fallback
to polling.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Wolfram Sang w...@the-dreams.de
---
Changes since v1:
* Always log whether the driver is using
There is a control bit in the PCI configuration space which disables
interrupts. If this bit is set, the driver should not try to make use
of interrupts, it won't receive any.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Wolfram Sang w...@the-dreams.de
---
Changes since v1:
* Turned warning
Don't log the host status register value in i801_isr(), it has very
little value and fills up the log when debugging is enabled.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Wolfram Sang w...@the-dreams.de
---
No change since v1.
drivers/i2c/busses/i2c-i801.c |3 ---
1 file changed, 3
Hi Wolfram,
Thanks for the quick review, very appreciated.
On Tue, 11 Nov 2014 11:57:34 +0100, Wolfram Sang wrote:
On Mon, Nov 10, 2014 at 10:31:04PM +0100, Jean Delvare wrote:
The i2c-i801 driver can work without interrupts, so there is no reason
to make a request_irq failure fatal
Hi Wolfram,
On Tue, 11 Nov 2014 11:58:54 +0100, Wolfram Sang wrote:
On Mon, Nov 10, 2014 at 10:31:39PM +0100, Jean Delvare wrote:
There is a control bit in the PCI configuration space which disables
interrupts. If this bit is set, the driver should not try to make use
of interrupts
intrusive,
spit the warning, and wait for somebody to show up with this message in
the logs.
That was my intent, yes. We can always add an action later when we
understand the situation better. If we ever get such a report, which
might in fact never happen.
Thanks,
--
Jean Delvare
SUSE L3 Support
Initialize devices in configuration file
-r, --remove Remove devices in configuration file
-k, --kmodTry to initialize i2c_dev kernel module
Use `-' after `-c' to read the config file from stdin.
Is the source code of this tool available somewhere?
Thanks,
--
Jean
1 - 100 of 1275 matches
Mail list logo
