I think the yield()s in the device driver code means I need a small
delay before the hardware is ready which might translate to some
arbitrary let me msleep() or do not select this task in the next
scheduler run, EVEN IF this task is highest priority.
Yield() in a driver is almost always a
Well, I guess only people monitoring system latency would notice, as
this is the only thing yield() was supposed to help with in the first
place.
if (need_resched())
schedule();
will make non-rt tasks act politely at the right moments. RT tasks will
likely immediately
From: Kalhan Trisal kalhan.tri...@intel.com
The LS driver will read the latest Lux measurement based upon the
light brightness and will report the LUX output through sysfs interface.
Signed-off-by: Kalhan Trisal kalhan.tri...@intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers
From: Kalhan Trisal kalhan.tri...@intel.com
The acceleremeter driver reads the x,y,z coordinate registers and provides
the information to user through the input layer
Conversion to input device, clean up and porting of retry fixes needed
for AAVA done by Alan Cox.
Signed-off-by: Kalhan Trisal
Subject: [FOR COMMENT] cy8ctmg110 for review
From: Samuli Konttila samuli.kontt...@aavamobile.com
Add support for the cy8ctmg110 capacitive touchscreen used on some embedded
devices.
(Some clean up by Alan Cox)
(No signed off, not yet ready to go in)
---
drivers/input/touchscreen/Kconfig
If you like, feel free to (re)start an argument with Linus on the ambient
light
sensor front. Or see that thread for yet another round about discussion of
where these sensors should be.
http://lkml.org/lkml/2010/3/1/367
Basically if it is primarily an input device for human
This is in no way a hwmon chip. Surely misc is a better location for now
(pending the usual discussion about all singing all dancing sensors
frameworks).
Yep it's moving at the moment
+#include linux/module.h
+#include linux/init.h
+#include linux/slab.h
+#include linux/i2c.h
for the HMC6352 compass
From: Kalhan Trisal kalhan.tri...@intel.com
This driver will report the heading values in degrees to the sysfs interface.
The values returned are headings . e.g. 245.6
(Some cleanups from Alan Cox)
Signed-off-by: Kalhan Trisal kalhan.tri...@intel.com
Signed-off-by: Alan Cox
quite the same as the ISL29003 so has a different driver.
Signed-off-by: Kalhan Trisal kalhan.tri...@intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/misc/Kconfig| 10 ++
drivers/misc/Makefile |1
drivers/misc/isl29020.c | 210
lux- illuminance0_input (or I guess lux0_input would also work, I can change
the iio abi to match this as well).
It also occurs to me that we might want to associate the calibration with the
particular channel? There's sure to be a dual ALS chip along at some point.
Obviously the
On Thu, 15 Apr 2010 13:26:43 +0200
Jean Delvare kh...@linux-fr.org wrote:
On Thu, 15 Apr 2010 13:34:07 +0300, Samu Onkalo wrote:
This patch introduces driver for Rohm BH1770GLC and Osram SFH7770
combined ambient light and proximity sensor.
I fail to see why this is being sent to the
Argument alignment
Makes it take more space
Spacing
Mostly dropped
Make chars static
Not sure I see the point (compiler generates good code anyway)
Remove prefixes from dev_level logging
Good point.
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a
...@intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
.../ABI/testing/sysfs-bus-i2c-devices-hm6352 | 21 ++
drivers/misc/Kconfig |7 +
drivers/misc/Makefile |1
drivers/misc/hmc6352.c | 199
On Wed, 16 Jun 2010 14:43:45 +0200
Oliver Neukum oneu...@suse.de wrote:
Am Mittwoch, 16. Juni 2010 14:16:14 schrieb Alan Cox:
+ msleep(10); /* sending 0x41 cmd we need to wait for 7-10 milli
seconds */
+ ret = i2c_transfer(client-adapter, msg1, 1);
+ if (ret != 1
folded in and a sysfs description to keep Andrew
happy.
Signed-off-by: Kalhan Trisal kalhan.tri...@intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
.../ABI/testing/sysfs-bus-i2c-devices-hm6352 | 21 +++
drivers/misc/Kconfig |7 +
drivers/misc
Its an array anyway - there isn't as such a 'correct macro' nor
does it need to be using one.
So why does he use this unstructured data? Do we just hope the
compiler is good enough on big endian architectures?
Its an array because it comes from an i2c bus which is a bytestream.
There is
are headings . e.g. 245.6
Alan: Cleanups requested now all folded in and a sysfs description to keep
Andrew happy. The sysfs description now resembles hwmon.
Signed-off-by: Kalhan Trisal kalhan.tri...@intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
.../ABI/testing/sysfs-bus-i2c
This series enables the I2C on the Intel MID platforms. I've kept it as a
series of five patches to keep ownership and history. The first two add the
x86 irq handling and the driver, the rest then polish it up.
Alan
---
Alan Cox (2):
intel_mid_i2c: minor cleanups
intel_mid_i2c: Do
From: Alek Du alek...@intel.com
Signed-off-by: Alek Du alek...@intel.com
Signed-off-by: Jacob Pan jacob.jun@intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
arch/x86/include/asm/gpio.h |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include
Squash down the switches into tables, and use the PCI ident field. We
could perhaps take this further and put the platform and port numbr into
this.
Check the speed (which is now 0/1/2) is valid and ignore otherwise.
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/i2c/busses/i2c
From: Wen Wang wen.w.w...@intel.com
Initial release of the driver.
Signed-off-by: Wen Wang wen.w.w...@intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/i2c/busses/Kconfig|9
drivers/i2c/busses/Makefile |1
drivers/i2c/busses/i2c-mrst.c | 970
From: Wen Wang wen.w.w...@intel.com
Added some minor changes/fixes after verification on the board.
Signed-off-by: Wen Wang wen.w.w...@intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/i2c/busses/i2c-mrst.c |9 +
1 files changed, 5 insertions(+), 4 deletions
These functions are supposed to return count on success. Instead, you
are returning 1.
Ah yes - I only tested with 1 byte sized I/O.
Fixed - do you want this to go via the I2C tree ?
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to
From: Wen Wang wen.w.w...@intel.com
Initial release of the driver.
Some clean up table removal by Alan Cox
Signed-off-by: Wen Wang wen.w.w...@intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/i2c/busses/Kconfig|9
drivers/i2c/busses/Makefile |1
drivers/i2c
From: Wen Wang wen.w.w...@intel.com
Initial release of the driver.
Major clean up by Alan Cox. This fixes the points raised in the initial
review except that
- some were no longer relevant
- speed is left 0/1/2 as specifying exact frequencies uses more command line
and makes it more complex
(And the correct patch attached this time)
From: Wen Wang wen.w.w...@intel.com
Initial release of the driver. Updated and verified on hardware.
Cleaned up as follows
Alan Cox:
Squash down the switches into tables, and use the PCI ident field. We
could perhaps take this further and put
I would much prefer this to be called i2c-moorsetown, we have modern
systems which can handle 8 character names.
Moorestown. Everything else in the kernel uses 'mrst' so this would
make the driver differ from the rest of the tree. I don't care too much
what its called. Given its now for
+ If you say yes here you get support for Asahi Kasei's
+ orientation sensor AK8975.
Should it be in drivers/hwmon?
Who knows - Linus needs to settle that mess at KS for all these
sensors. It's not hwmon however. Some acceleromters are in hwmon for
historical reasons. Input
+config PCH_I2C_CH_COUNT
+ int PCH I2C the number of channel count
+ range 1 2
+ depends on PCH_I2C
+ help
+ This driver is for PCH(Platform controller Hub) I2C of Topcliff which
+ is an IOH(Input/Output Hub) for x86 embedded processor.
+ The number of I2C
From: Hong Liu hong@intel.com
The 4K and 64K in the hw spec acutally means 4095 (12bit) and 65535 (16bit).
Signed-off-by: Hong Liu hong@intel.com
---
drivers/misc/apds9802als.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/apds9802als.c
On Tue, 28 Sep 2010 11:00:20 +0200
Linus Walleij linus.ml.wall...@gmail.com wrote:
2010/9/27 samu.p.onk...@nokia.com:
I haven't got any mails or comments from Richard about this driver.
Also led tree here:
http://git.o-hand.com/cgit.cgi/linux-rpurdie-leds/
is not updated in 4
From: anantha anantha.naraya...@intel.com
This adds support for the ADPS9802ALS sensor.
Cleanup by Alan Cox
- move mutexes to cover more things
- report I/O errors back to user space
- report range and values in LUX
Signed-off-by: Anantha Narayanan anantha.naraya
From: anantha anantha.naraya...@intel.com
This adds support for the ADPS9802ALS sensor.
Cleanup by Alan Cox
- move mutexes to cover more things
- report I/O errors back to user space
- report range and values in LUX
Signed-off-by: Anantha Narayanan anantha.naraya
From: anantha anantha.naraya...@intel.com
This adds support for the ADPS9802ALS sensor.
Cleanup by Alan Cox
- move mutexes to cover more things
- report I/O errors back to user space
- report range and values in LUX
Signed-off-by: Anantha Narayanan anantha.naraya
On Tue, 5 Oct 2010 12:42:55 +0300
Samu Onkalo samu.p.onk...@nokia.com wrote:
This is a driver for ROHM BH1770GLC and OSRAM SFH7770 combined
ALS and proximity sensor.
Same comment about regulators.
+/* Supported stand alone rates in ms from chip data sheet */
+static s16 prox_rates[] =
+static int apds990x_refresh_athres(struct apds990x_chip *chip)
+{
+ int ret;
+ /* If the chip is not in use, don't try to access it */
+ if (pm_runtime_suspended(chip-client-dev))
+ return 0;
+
+ ret = apds990x_write_word(chip, APDS990X_AILTL,
+
On Tue, 05 Oct 2010 14:29:50 +0300
Onkalo Samu samu.p.onk...@nokia.com wrote:
Alan, thanks for comments
-Samu
On Tue, 2010-10-05 at 13:21 +0200, ext Alan Cox wrote:
On Tue, 5 Oct 2010 12:42:55 +0300
Samu Onkalo samu.p.onk...@nokia.com wrote:
This is a driver for ROHM BH1770GLC
- not clear how power_state and runtime pm interact - do we in fact need
power state ?
power_state turns chip on or off. In off state runtime pm is used to
handle bookkeeping and also handling chip state transitions including
regulators. Other ideas than separate power_state for this
From: Wen Wang wen.w.w...@intel.com
Initial release of the driver. Updated and verified on hardware.
Cleaned up as follows and with fixes backported out of the internal tree for
Meego.
Alan Cox:
Squash down the switches into tables, and use the PCI ident field. We
could perhaps take
From: Wen Wang wen.w.w...@intel.com
Initial release of the driver. Updated and verified on hardware.
Cleaned up as follows and with bits backported from the internal Meego tree
Alan Cox:
Squash down the switches into tables, and use the PCI ident field. We
could perhaps take this further
I think this now addresses all the points raised in previous review, as well
as adding runtime power management support which is needed for MID
platforms.
From: Wen Wang wen.w.w...@intel.com
Initial release of the driver. Updated and verified on hardware.
Cleaned up as follows
Alan Cox
Initial release of the driver. Updated and verified on hardware.
Cleaned up as follows
Alan Cox:
Squash down the switches into tables, and use the PCI ident field. We
could perhaps take this further and put the platform and port number into
this.
uint32t - u32
bracketing of case
--- a/drivers/misc/apds9802als.c
+++ b/drivers/misc/apds9802als.c
@@ -251,7 +251,6 @@ static int apds9802als_probe(struct i2c_client
*client,
return res;
als_error1:
- i2c_set_clientdata(client, NULL);
kfree(data);
return res;
}
Acked-by: Alan Cox
...@linux.intel.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/spi/Kconfig|4 +
drivers/spi/Makefile |3 -
drivers/spi/dw_spi.c | 48 +
drivers/spi/dw_spi_mid.c | 246
drivers/spi/dw_spi_pci.c | 14
Err, why is this being sent to the linux-i2c list?
Because I'm an idiot 8)
Doh
Alan
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
info to
each error message.
Signed-off-by: Bin Yang bin.y...@intel.com
[Ported to upstream driver branch and tidied a spot]
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/i2c/busses/i2c-intel-mid.c | 16
1 files changed, 12 insertions(+), 4 deletions(-)
diff --git
.
Signed-off-by: Bin Yang bin.y...@intel.com
[Ported to the upstream branch and extracted as a helper function]
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/i2c/busses/i2c-intel-mid.c | 31 +++
1 files changed, 27 insertions(+), 4 deletions(-)
diff --git
New sanity check of what? Where's the code?
Slashes in path names - it was added to the sysfs code
Using the adapter name to request the IRQ is silly. The very same issue
was fixed in i2c-pca-platform recently:
info to
each error message.
Signed-off-by: Bin Yang bin.y...@intel.com
[Ported to upstream driver branch and tidied a spot]
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/i2c/busses/i2c-intel-mid.c | 16
1 files changed, 12 insertions(+), 4 deletions(-)
diff --git
.
Signed-off-by: Bin Yang bin.y...@intel.com
[Ported to the upstream branch and extracted as a helper function]
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/i2c/busses/i2c-intel-mid.c | 31 +++
1 files changed, 27 insertions(+), 4 deletions(-)
diff --git
after every access. If a device driver
accesses I2C frequently, it will not go to suspend and will keep high
performance. After a long time idle, it will go to suspend auto.
Signed-off-by: Bin Yang bin.y...@intel.com
[Ported to upstream driver version]
Signed-off-by: Alan Cox a...@linux.intel.com
slave device drivers need not to be modified or to know about the
limits.
Signed-off-by: Major Lee major_...@wistron.com
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/i2c/busses/i2c-intel-mid.c | 95 +---
1 files changed, 46 insertions(+), 49 deletions
On Fri, 18 Mar 2011 11:40:24 +0100
Waldemar Rymarkiewicz waldemar.rymarkiew...@tieto.com wrote:
Add new driver for MicroRead NFC chip connected to i2c bus.
Ok we now have two devices and they have differing APIs and own device
names and both from the same company. This has to stop right now and
Would it not be lighter to use atomic bit ops ?
Do you mean in order to remove rx_mutex?
mutex_lock(info-rx_mutex);
atomic_set(info-irq_state ,1);
mutex_unlock(info-rx_mutex);
looks a bit strange. I still need the rx_mutex to protect irq_state while
reading i2c.
On Tue, 22 Mar 2011 20:43:47 -0700
Guenter Roeck guenter.ro...@ericsson.com wrote:
This patch adds support for the I2C interface of the Devantech USB-ISS
Multifunction adapter.
Signed-off-by: Guenter Roeck guenter.ro...@ericsson.com
---
The driver has one problem: It competes with the
+ /* setup i2c adapter description */
+ dev-adapter.owner = THIS_MODULE;
+ dev-adapter.class = I2C_CLASS_HWMON;
Doesn't seem to be HWMON ?
You lost me there. Why not ? Many if not all I2C bus drivers register as
I2C_CLASS_HWMON.
Would you expect platform hardware monitoring
But, if this just duplicates the cdc-acm interface, and it looks like it
does, I don't think you need a kernel driver at all for it. Just use
userspace commands to the serial port, like you do on Windows, and all
should be fine, right?
You want a kernel driver because you've got kernel I²C
The difference between the two is where you keep the common
NFC logic:
I think I'd disagree on that
If you have a character device, it will be like a serial port
connecting to a modem. Any higher-level protocols live in the
user space and are limited to a single application then, which
is
I was under the impression that NFC was peer-to-peer, so the driver
would already be handling both sides potentially.
Your security requirements each side are going to be very different. A
phone or handheld device is generally single user at a time, the other
end may well be interacting with
From: Kristen Carlson Accardi kris...@linux.intel.com
Don't call i2c_enable on resume because it causes a spurious
interrupt.
Signed-off-by: Kristen Carlson Accardi kris...@linux.intel.com
Signed-off-by: Kirill A. Shutemov kirill.shute...@linux.intel.com
Signed-off-by: Alan Cox
On Mon, 13 Feb 2012 23:28:57 +
Ben Dooks ben-...@fluff.org wrote:
On Thu, Jan 26, 2012 at 04:13:34PM +, Alan Cox wrote:
From: Kristen Carlson Accardi kris...@linux.intel.com
Don't call i2c_enable on resume because it causes a spurious
interrupt.
Signed-off-by: Kristen
On Fri, 28 Sep 2012 15:40:32 +0800
Zhang Rui rui.zh...@intel.com wrote:
From 6077a62f2865201ab6727ca7d628ee5e43aa57e1 Mon Sep 17 00:00:00 2001
From: Zhang Rui rui.zh...@intel.com
Date: Fri, 24 Aug 2012 15:18:25 +0800
Subject: [RFC PATCH 5/6] ACPI: Introduce ACPI I2C controller enumeration
On Tue, 13 Nov 2012 21:52:20 +0100
Alexander Holler hol...@ahsoftware.de wrote:
Make it possible to define i2c-devices at the kernel command line
or as a module parameter.
Format is devname1@addr1,devname2@addr2,...
Why not do this with your initrd, you can deal with your rtc
before
This may appear as PCI or ACPI depending upon the firmware so we
have to list both. All share the same ACPI identifier but not
the same PCI identifier.
Signed-off-by: Alan Cox a...@linux.intel.com
---
drivers/i2c/busses/i2c-designware-pcidrv.c |9 +
drivers/i2c/busses/i2c-designware
On Fri, 2014-08-01 at 19:52 +0200, Wolfram Sang wrote:
Hi Alan,
On Wed, Jul 23, 2014 at 01:06:57PM +0100, Alan Cox wrote:
This may appear as PCI or ACPI depending upon the firmware so we
have to list both. All share the same ACPI identifier but not
the same PCI identifier.
Signed
This follows on from the discussion in late March before Srinivas got
busy on other things.
This is just an RFC for a next generation set of patches. The idea is as
follows
- If an adapter knows about its ARA and smbus alerts then the adapter
creates its own interrupt handler as before
- If a
66 matches
Mail list logo
