Hello,
The bugs listed are over a month old, and haven't been addressed yet.
It would be appreciated if corresponding maintainers identify whether
the bugs have been fixed, or need to be worked on, and take
appropriate action.
In most cases, reporters are standing by and ready to provide
Hello, all.
This is the second take of cleanup-sht-ops patchset. As the name
suggests it reorganizes and cleans up scsi_host_template and
ata_port_operation tables used by libata core and low level drivers.
Please read the head message of the last take[L] for more info.
Changes from the last
Over the time, port info, ops and sht structures developed quite a bit
of inconsistencies. This patch updates drivers.
* Enable/disable_pm callbacks added to all ahci ops tables.
* Every driver for SFF controllers now uses ata_sff_port_start()
instead of ata_port_start() unless the driver has
PCI device should be powered up or powered up before its PCI regsiters
are accessed. Although PCI configuration register access is allowed
in D3hot, PCI device is free to reset its status when transiting from
D3hot to D0 causing configuration data to change.
Many libata SFF drivers which use
Over the time, ops in ata_port_operations has become a bit confusing.
Reorganize. SFF/BMDMA ops are separated into separate a group as they
will be taken out of ata_port_operations later.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
include/linux/libata.h | 117
-irq_clear() is used to clear IRQ bit of a SFF controller and isn't
useful for drivers which don't use libata SFF HSM implementation.
However, it's a required callback and many drivers implement their own
noop version as placeholder. This patch implements ata_noop_irq_clear
and use it to replace
libata core layer doesn't care about sht or -irq_handler. Those are
only of interest to the LLD during initialization. This is confusing
and has caused several drivers to have duplicate unused initializers
for these fields.
Currently only sata_nv uses these fields. Make sata_nv use
port_info-private_data is currently used for two purposes - to record
private data about the port_info or to specify host-private_data to
use when allocating ata_host.
This overloading is confusing and counter-intuitive in that
port_info-private_data becomes host-private_data instead of
ata_pci_init_one() is the only function which uses ops-irq_handler
and pi-sht. Other initialization functions take the same information
as arguments. This causes confusion and duplicate unused entries in
structures.
Make ata_pci_init_one() take sht as an argument and use ata_interrupt
Tejun Heo [EMAIL PROTECTED] wrote:
Elias Oltmanns wrote:
+static int piix_qc_defer(struct ata_queued_cmd *qc)
+{
+static struct ata_port *ap = NULL;
+struct ata_queued_cmd qcmd[ATA_MAX_QUEUE];
missing static?
Oh well, I must have been too tired already yesterday. There are a few
Bartlomiej Zolnierkiewicz wrote:
Hi,
On Monday 11 February 2008, Kamalesh Babulal wrote:
Nish Aravamudan wrote:
On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
On Thursday 07 February 2008, Kamalesh Babulal wrote:
Bartlomiej Zolnierkiewicz wrote:
Hi,
On Wednesday 06
Elias Oltmanns wrote:
Tejun Heo [EMAIL PROTECTED] wrote:
Elias Oltmanns wrote:
+static int piix_qc_defer(struct ata_queued_cmd *qc)
+{
+ static struct ata_port *ap = NULL;
+ struct ata_queued_cmd qcmd[ATA_MAX_QUEUE];
missing static?
Oh well, I must have been too tired already
Jeff Garzik wrote:
Tejun Heo wrote:
This patch implements libata.force module parameter which can
selectively override ATA port, link and device configurations
including cable type, SATA PHY SPD limit, transfer mode and NCQ.
For example, you can say use 1.5Gbps for all fan-out ports attached
Hi,
I suffer from unreliable cdrom operations (failing DAE and burn sessions)
with the openSUSE 2.6.18.8-0.7-bigsmp kernel.
Additionally, the syslog is continuesly spammed with:
Feb 12 00:03:22 kernel: hdc: cdrom_pc_intr: The drive appears confused (ireason
= 0x01).
Trying to recover by
Tejun Heo [EMAIL PROTECTED] wrote:
Elias Oltmanns wrote:
This proves that piix_qc_defer() has declined the same command 100
times in succession. However, this will only happen if the status of
all the commands enqueued for one port hasn't changed in the
meantime. This suggests to me that the
Hi list,
I seem to have a bug with JMicron controller in a Gigabyte GA-N680SLI-DQ6
motherboard.
http://www.gigabyte.com.tw/Support/Motherboard/BIOS_Model.aspx?ProductID=2460
Kernel is 2.6.24.
10 on-board SATA connectors, 2+4*JMicron 20360/20363 + 4*nVidia MCP55
2*200GB disks (System - SW
On Tue, Feb 12 2008 at 19:45 +0200, Christoph Hellwig [EMAIL PROTECTED] wrote:
On Sun, Feb 10, 2008 at 09:05:17PM +0200, Boaz Harrosh wrote:
- Lots of drivers still use MAX_COMMAND_SIZE. So I have left
that #define but equate it to BLK_MAX_CDB. The way I see it
and is reflected in the
On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote:
I understand what you are trying to do - I guess I just doubt the value
you've added by doing this. I think that there's going to be so much
customization that system vendors will want to add, that they are going
to wind up
On Feb 12, 2008 9:57 AM, James Bottomley
[EMAIL PROTECTED] wrote:
Added linux-scsi for the SCSI ones
On Tue, 2008-02-12 at 00:18 -0800, Natalie Protasevich wrote:
Hello,
The bugs listed are over a month old, and haven't been addressed yet.
It would be appreciated if corresponding
Tejun Heo wrote:
* pata_scc should now have NULL thaw after conversion.
I'm sorry. This is a bug.
Please use default thaw (ata_bmdma_thaw) for pata_scc.
Cheers
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Hi,
I'm reworking the pci device list logic (we currently keep all PCI
devices in 2 lists, which isn't the nicest, we should be able to get
away with only 1 list.)
The only bother I've found so far is the pci_get_device_reverse()
function, it's used in 2 places, IDE and the calgary driver.
I'm
This patch adds default thaw ops and fixes the freeze/thaw inconsistency.
Signed-off-by: Kou Ishizaki [EMAIL PROTECTED]
Signed-off-by: Akira Iguchi [EMAIL PROTECTED]
---
diff -pu linux-2.6.25-rc1/drivers/ata/pata_scc.c
linux-2.6.25-rc1_mod/drivers/ata/pata_scc.c
---
On Tue, Feb 12, 2008 at 04:15:07PM -0800, Greg KH wrote:
I'm curious if we really still support the ide=reverse option? It's a
config option that I don't think the distros still enable (SuSE does
not). Is this still needed these days?
My server has a consumer-grade desktop amd64 mobo,
Why does the calgary driver need this? Can we just use pci_get_device()
instead? Why do you need to walk the device list backwards? Do you get
false positives going forward?
It doesn't look to be performance critical so the driver can
pci_get_device until the end and use the final hit
I tell you what ... find me a parisc box that actually has IDE and we
might have told you ...
The NS87415 variant IDE has been tested on parisc and didn't blow up -
must just be lucky.
(actually, the pa8800's have IDE CD's on a cmd640 chip, but that oopses
on boot for no reason we've tracked
This patch implements libata.force module parameter which can
selectively override ATA port, link and device configurations
including cable type, SATA PHY SPD limit, transfer mode and NCQ.
For example, you can say use 1.5Gbps for all fan-out ports attached
to the second port but allow 3.0Gbps for
Hello,
Gabor FUNK wrote:
What I said was that timeouts occurring due to transmission errors
should be recoverable. It seems like IRQ delivery didn't work probably
due to screaming IRQ. I need to see the messages before the first
relevant error message. It's always a good idea to post full
Akira Iguchi wrote:
Tejun Heo wrote:
* pata_scc should now have NULL thaw after conversion.
I'm sorry. This is a bug.
Please use default thaw (ata_bmdma_thaw) for pata_scc.
That change should be a separate patch. This patchset shouldn't change
any actual behavior but adding ata_bmdma_thaw
On Tuesday 12 February 2008, Benjamin Herrenschmidt wrote:
On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote:
On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote:
- couple of fixes and preparatory patches
- rework of PowerMac media-bay support
Hi Borislav,
On Tuesday 12 February 2008, Borislav Petkov wrote:
Hi Bart,
here's a first go at converting ide-floppy to using rq-cmd for packet
commands.
The code below is pretty rough and from what i can tell needs to be hammered a
lot more, for it raises a lot of issues:
I think that
On Tuesday 12 February 2008, Borislav Petkov wrote:
commit 272976f0f5754707f9e41da315717a6eb8d9d536
Author: Borislav Petkov [EMAIL PROTECTED]
Date: Tue Feb 12 16:22:44 2008 +0100
ide-scsi: do non-atomic pc-flags testing
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
diff
On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote:
On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote:
- couple of fixes and preparatory patches
- rework of PowerMac media-bay support ([un]register IDE devices instead of
[un]registering IDE interface) [
On Tue, 2008-02-12 at 12:49 +0100, Gabriel Paubert wrote:
On Fri, Feb 08, 2008 at 07:40:43PM +1100, Benjamin Herrenschmidt wrote:
On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote:
- couple of fixes and preparatory patches
- rework of PowerMac media-bay support
On Sun, 2008-02-10 at 21:05 +0200, Boaz Harrosh wrote:
- struct scsi_cmnd had a 16 bytes command buffer of its own.
This is an unnecessary duplication and copy of request's
cmd. It is probably left overs from the time that scsi_cmnd
could function without a request attached. So clean
On Tue, 12 Feb 2008 12:45:35 -0600
James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2008-02-12 at 10:22 -0800, Kristen Carlson Accardi wrote:
I apologize for taking so long to review this patch. I obviously
agree wholeheartedly with Luben. The problem I ran into while
trying to design an
Hi All,
I've implemented the Linux PCI support for a new architecture, and
have run into what appears to be a bug in libata, but I don't
understand why it wouldn't have been seen on other architectures.
The processor is a Tile64, which is a 64 core, 64 bit VLIW processor
with non-coherent DMA -
On Tue, 2008-02-12 at 10:22 -0800, Kristen Carlson Accardi wrote:
I apologize for taking so long to review this patch. I obviously agree
wholeheartedly with Luben. The problem I ran into while trying to
design an enclosure management interface for the SATA devices is that
there is all this
On Mon, 4 Feb 2008 18:01:36 -0800 (PST)
Luben Tuikov [EMAIL PROTECTED] wrote:
--- On Mon, 2/4/08, James Bottomley
[EMAIL PROTECTED] wrote:
The enclosure misc device is really just a
library providing
sysfs
support for physical enclosure devices and their
components.
Who
On Tue, Feb 12 2008 at 19:54 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Tue, Feb 12 2008 at 19:48 +0200, Christoph Hellwig [EMAIL PROTECTED]
wrote:
On Sun, Feb 10, 2008 at 09:09:41PM +0200, Boaz Harrosh wrote:
- add varlen_cdb and varlen_cdb_len to hold a large user cdb
if needed.
On Wed, 2008-02-13 at 02:13 +, Alan Cox wrote:
I tell you what ... find me a parisc box that actually has IDE and we
might have told you ...
The NS87415 variant IDE has been tested on parisc and didn't blow up -
must just be lucky.
Actually, it's only a specific class of machines:
On Tue, Feb 12, 2008 at 04:15:06PM -0800, Greg KH wrote:
Hi,
I'm reworking the pci device list logic (we currently keep all PCI
devices in 2 lists, which isn't the nicest, we should be able to get
away with only 1 list.)
The only bother I've found so far is the pci_get_device_reverse()
Added linux-scsi for the SCSI ones
On Tue, 2008-02-12 at 00:18 -0800, Natalie Protasevich wrote:
Hello,
The bugs listed are over a month old, and haven't been addressed yet.
It would be appreciated if corresponding maintainers identify whether
the bugs have been fixed, or need to be worked
On Tue, Feb 12 2008 at 19:48 +0200, Christoph Hellwig [EMAIL PROTECTED] wrote:
On Sun, Feb 10, 2008 at 09:09:41PM +0200, Boaz Harrosh wrote:
- add varlen_cdb and varlen_cdb_len to hold a large user cdb
if needed. They start as empty. Allocation of buffer must
be done by user and held until
Has anyone else reported a problem like this? It requires
non-coherent DMA, and a lack of a cache invalidate instruction, and
one of the drivers that has this problem (it looks like sata_qstor
does too, I haven't looked at others), so maybe that doesn't cover
any other architectures.
Nobody
On Sun, Feb 10, 2008 at 09:05:17PM +0200, Boaz Harrosh wrote:
- Lots of drivers still use MAX_COMMAND_SIZE. So I have left
that #define but equate it to BLK_MAX_CDB. The way I see it
and is reflected in the patch below is.
MAX_COMMAND_SIZE - means: The longest fixed-length (*) SCSI CDB
What I said was that timeouts occurring due to transmission errors
should be recoverable. It seems like IRQ delivery didn't work probably
due to screaming IRQ. I need to see the messages before the first
relevant error message. It's always a good idea to post full kernel log
from boot till
On Tue, Feb 12, 2008 at 10:26:17AM +0100, Hans-Peter Jansen wrote:
Hi,
I suffer from unreliable cdrom operations (failing DAE and burn sessions)
with the openSUSE 2.6.18.8-0.7-bigsmp kernel.
Hi,
can please you test this with a more recent kernel. Yours is
On Wed, Feb 13, 2008 at 02:41:07AM +0100, Rene Herman wrote:
On 13-02-08 01:15, Greg KH wrote:
I'm reworking the pci device list logic (we currently keep all PCI
devices in 2 lists, which isn't the nicest, we should be able to get
away with only 1 list.)
The only bother I've found so far is
On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote:
Why does the calgary driver need this? Can we just use pci_get_device()
instead? Why do you need to walk the device list backwards? Do you get
false positives going forward?
It doesn't look to be performance critical so the
On Wed, Feb 13, 2008 at 02:43:29AM +, Ken Moffat wrote:
On Tue, Feb 12, 2008 at 04:15:07PM -0800, Greg KH wrote:
I'm curious if we really still support the ide=reverse option? It's a
config option that I don't think the distros still enable (SuSE does
not). Is this still needed
I wonder if this may be what I am seeing with the Si3124 on my Alpha
based setup.
I'm not sure if Alpha meets all the criteria, but the thing refuses to
recognize any drivers when they are connected and I see what are
supposed pci parity failures.
maybe not ...
...tom
Mark Mason wrote:
On Sun, Feb 10, 2008 at 09:09:41PM +0200, Boaz Harrosh wrote:
- add varlen_cdb and varlen_cdb_len to hold a large user cdb
if needed. They start as empty. Allocation of buffer must
be done by user and held until request execution is done.
- Since there can be either a fix_length command up
Fix speed negotiation for secondary device.
Signed-off-by: Martin K. Petersen [EMAIL PROTECTED]
---
diff -r 9f5ca67cc28f drivers/ata/pata_cs5536.c
--- a/drivers/ata/pata_cs5536.c Mon Feb 11 20:52:01 2008 -0800
+++ b/drivers/ata/pata_cs5536.c Tue Feb 12 08:52:43 2008 -0500
@@ -40,7 +40,7 @@
commit 272976f0f5754707f9e41da315717a6eb8d9d536
Author: Borislav Petkov [EMAIL PROTECTED]
Date: Tue Feb 12 16:22:44 2008 +0100
ide-scsi: do non-atomic pc-flags testing
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
index
Gabor FUNK wrote:
It shouldn't kill the RAID. Hmmm... The log is truncated. Can you
please post full kernel log spanning from boot to array death?
RAID dies because controller dies, then it loses 4 disks out of 8...
Actually, the server last time was up and running for 2 months.
Then when
I seem to have a bug with JMicron controller in a Gigabyte
GA-N680SLI-DQ6 motherboard.
http://www.gigabyte.com.tw/Support/Motherboard/BIOS_Model.aspx?ProductID=2460
Kernel is 2.6.24.
10 on-board SATA connectors, 2+4*JMicron 20360/20363 + 4*nVidia MCP55
2*200GB disks (System - SW RAID1) on the
Hi Bart,
here's a first go at converting ide-floppy to using rq-cmd for packet commands.
The code below is pretty rough and from what i can tell needs to be hammered a
lot more, for it raises a lot of issues:
1. The command control (pc-callback, request type, etc) is still done using
the pc
commit 48f9b88d491aa478ffcf21e2f523e3665db0770b
Author: Borislav Petkov [EMAIL PROTECTED]
Date: Tue Feb 12 09:42:19 2008 +0100
ide-floppy: rename end_request handler properly
mv idefloppy_do_end_request - idefloppy_end_request as is the case with
ide-cd
Signed-off-by:
Gabor FUNK wrote:
Hi list,
I seem to have a bug with JMicron controller in a Gigabyte
GA-N680SLI-DQ6 motherboard.
http://www.gigabyte.com.tw/Support/Motherboard/BIOS_Model.aspx?ProductID=2460
Kernel is 2.6.24.
10 on-board SATA connectors, 2+4*JMicron 20360/20363 + 4*nVidia MCP55
2*200GB
Elias Oltmanns wrote:
Tejun Heo [EMAIL PROTECTED] wrote:
Elias Oltmanns wrote:
This proves that piix_qc_defer() has declined the same command 100
times in succession. However, this will only happen if the status of
all the commands enqueued for one port hasn't changed in the
meantime. This
On Fri, Feb 08, 2008 at 07:40:43PM +1100, Benjamin Herrenschmidt wrote:
On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote:
- couple of fixes and preparatory patches
- rework of PowerMac media-bay support ([un]register IDE devices instead of
[un]registering IDE
On Tue, Feb 12, 2008 at 12:49:05PM +0100, Gabriel Paubert wrote:
On Fri, Feb 08, 2008 at 07:40:43PM +1100, Benjamin Herrenschmidt wrote:
On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote:
- couple of fixes and preparatory patches
- rework of PowerMac media-bay
--- On Tue, 2/12/08, Kristen Carlson Accardi [EMAIL PROTECTED] wrote:
Hi,
I apologize for taking so long to review this patch. I
obviously agree
wholeheartedly with Luben. The problem I ran into while
trying to
design an enclosure management interface for the SATA
devices is that
there
On Tuesday 12 February 2008, Borislav Petkov wrote:
commit 48f9b88d491aa478ffcf21e2f523e3665db0770b
Author: Borislav Petkov [EMAIL PROTECTED]
Date: Tue Feb 12 09:42:19 2008 +0100
ide-floppy: rename end_request handler properly
mv idefloppy_do_end_request -
64 matches
Mail list logo
