Re: sata_sil on amd64

2005-01-23 Thread Bartlomiej Zolnierkiewicz
On Sat, 22 Jan 2005 19:19:35 -0600, Tyler Montbriand [EMAIL PROTECTED] wrote: I have been stuck using kernel 2.6.4 for the last year or so for various reasons, and now I'm in a vicious catch-22. If I don't upgrade, I can't use NPTL, therefore my system will continue to be susceptible to the

Re: simple use wcache from drive (was)Re: [RFC/PATCH 0/7] enable honoring write cache setting of IDE drive

2005-01-28 Thread Bartlomiej Zolnierkiewicz
On Fri, 28 Jan 2005 23:56:41 +0100, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Fri, 28 Jan 2005 16:54:49 -0600, Doug Maxey [EMAIL PROTECTED] wrote: On Fri, 28 Jan 2005 23:32:53 +0100, Bartlomiej Zolnierkiewicz wrote: The datacenters/server folks that would be using these drives

Re: [PATCH 2.6.11-rc2 11/29] ide: add ide_drive_t.sleeping

2005-02-03 Thread Bartlomiej Zolnierkiewicz
On Thu, 3 Feb 2005 14:32:29 +0100, Jens Axboe [EMAIL PROTECTED] wrote: On Thu, Feb 03 2005, Bartlomiej Zolnierkiewicz wrote: On Thu, 3 Feb 2005 12:37:10 +0100, Jens Axboe [EMAIL PROTECTED] wrote: On Thu, Feb 03 2005, Bartlomiej Zolnierkiewicz wrote: On Wed, 2 Feb 2005 11:54:48 +0900

Re: [PATCH 2.6.11-rc2 12/29] ide: add ide_hwgroup_t.polling

2005-02-03 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Feb 2005 11:55:38 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 12_ide_hwgroup_t_polling.patch ide_hwgroup_t.polling field added. 0 in poll_timeout field used to indicate inactive polling but because 0 is a valid jiffy value, though slim, there's a chance that

Re: [PATCH 2.6.11-rc2 25/29] ide: convert REQ_DRIVE_CMD to REQ_DRIVE_TASKFILE

2005-02-03 Thread Bartlomiej Zolnierkiewicz
On Fri, 04 Feb 2005 10:06:29 +0900, Tejun Heo [EMAIL PROTECTED] wrote: Hello, Bartlomiej Zolnierkiewicz wrote: On Wed, 2 Feb 2005 12:15:59 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 25_ide_taskfile_cmd.patch All in-kernel REQ_DRIVE_CMD users except for ide_cmd_ioctl

Re: [PATCH 2.6.11-rc2 05/29] ide: merge pci driver .h's into .c's

2005-02-03 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Feb 2005 11:47:12 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 05_ide_merge_pci_driver_hc.patch Merges drivers/ide/pci/*.h files into their corresponding *.c files. Rationales are 1. There's no reason to separate pci drivers into header and body. No

[patch 8/9] kill ide-default

2005-02-03 Thread Bartlomiej Zolnierkiewicz
* add ide_drives list to list devices without a driver * add __ide_add_setting() and use it for adding no auto remove entries * kill ide-default pseudo-driver diff -Nru a/drivers/ide/Makefile b/drivers/ide/Makefile --- a/drivers/ide/Makefile 2005-02-04 03:32:17 +01:00 +++

Re: [PATCH 2.6.11-rc2 11/14] ide_pci: Merges pdc202xx_old.h into pdc202xx_old.c

2005-02-06 Thread Bartlomiej Zolnierkiewicz
On Fri, 4 Feb 2005 16:13:19 +0900 (KST), Tejun Heo [EMAIL PROTECTED] wrote: 11_ide_pci_pdc202xx_old_merge.patch Merges ide/pci/pdc202xx_old.h into pdc202xx_old.c. Signed-off-by: Tejun Heo [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2.6.11-rc2 12/14] ide_pci: Merges piix.h into piix.c

2005-02-06 Thread Bartlomiej Zolnierkiewicz
On Fri, 4 Feb 2005 16:13:19 +0900 (KST), Tejun Heo [EMAIL PROTECTED] wrote: 12_ide_pci_piix_merge.patch Merges ide/pci/piix.h into piix.c. Signed-off-by: Tejun Heo [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

Re: [PATCH 2.6.11-rc2 13/14] ide_pci: Removes unused SVWKS_DEBUG_DRIVE_INFO

2005-02-06 Thread Bartlomiej Zolnierkiewicz
On Fri, 4 Feb 2005 16:13:19 +0900 (KST), Tejun Heo [EMAIL PROTECTED] wrote: 13_ide_pci_serverworks_cleanup.patch Removes unused SVWKS_DEBUG_DRIVE_INFO from ide/pci/serverworks driver. Signed-off-by: Tejun Heo [EMAIL PROTECTED] applied - To unsubscribe from this list:

Re: [PATCH 2.6.11-rc2 01/09] ide: kill unused pkt_task_t

2005-02-06 Thread Bartlomiej Zolnierkiewicz
applied, thanks - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC: 2.6 patch] IDE: unsexport 3 functions

2005-02-06 Thread Bartlomiej Zolnierkiewicz
@@ -161,8 +161,6 @@ return ide_stopped; } -EXPORT_SYMBOL(do_rw_taskfile); - Is this patch against -mm or ide-dev-2.6? do_rw_taskfile() is still needed for ide-disk.c in linus' tree, the other two exports can be removed - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2.6.11-rc2 04/09] ide: convert REQ_DRIVE_TASK to REQ_DRIVE_TASKFILE

2005-02-06 Thread Bartlomiej Zolnierkiewicz
I put some more thought into this change... details below... On Sat, 5 Feb 2005 11:15:56 +0900 (KST), Tejun Heo [EMAIL PROTECTED] wrote: @@ -705,24 +705,17 @@ static int idedisk_issue_flush(request_q { ide_drive_t *drive = q-queuedata; struct request *rq; +

[BK PATCHES] ide-dev-2.6 update

2005-02-06 Thread Bartlomiej Zolnierkiewicz
Hi, ChangeLog: * sync with linux-2.6 tree * merge convert IDE device drivers to driver model serie (except the last patch which is the actual conversion :) * fix ATAPI Power Management BK users: bk pull bk://bart.bkbits.net/ide-dev-2.6 This will update the following files:

Re: [2.6 patch] IDE: possible cleanups

2005-02-02 Thread Bartlomiej Zolnierkiewicz
On Mon, 31 Jan 2005 20:01:54 +0100, Adrian Bunk [EMAIL PROTECTED] wrote: This patch contains the following possible cleanups: - make some needlessly global code static - ide-dma.c: remove the unneeded EXPORT_SYMBOL(__ide_dma_test_irq) Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied -

Re: [PATCH 2.6.11-rc2 02/29] ide: cleanup it8172

2005-02-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Feb 2005 11:44:54 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 02_ide_cleanup_it8172.patch In drivers/ide/pci/it8172.h, it8172_ratefilter() and init_setup_it8172() are declared and the latter is referenced in it8172_chipsets. Both functions are not defined or

Re: [PATCH 2.6.11-rc2 10/29] ide: __ide_do_rw_disk() return value fix

2005-02-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Feb 2005 11:52:48 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 10_ide_do_rw_disk_pre_task_out_intr_return_fix.patch In __ide_do_rw_disk(), ide_started used to be returned blindly after issusing PIO write. This can cause hang if pre_task_out_intr() returns

Re: [PATCH 2.6.11-rc2 12/29] ide: add ide_hwgroup_t.polling

2005-02-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Feb 2005 11:55:38 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 12_ide_hwgroup_t_polling.patch ide_hwgroup_t.polling field added. 0 in poll_timeout field used to indicate inactive polling but because 0 is a valid jiffy value, though slim, there's a chance that

Re: [PATCH 2.6.11-rc2 11/29] ide: add ide_drive_t.sleeping

2005-02-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Feb 2005 11:54:48 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 11_ide_drive_sleeping_fix.patch ide_drive_t.sleeping field added. 0 in sleep field used to indicate inactive sleeping but because 0 is a valid jiffy value, though slim, there's a chance that

Re: [PATCH 2.6.11-rc2 09/29] ide: __ide_do_rw_disk() lba48 dma check fix

2005-02-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Feb 2005 11:51:42 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 09_ide_do_rw_disk_lba48_dma_check_fix.patch In __ide_do_rw_disk(), the shifted block, instead of the original rq-sector, should be used when checking range for lba48 dma. Signed-off-by: Tejun Heo

Re: [PATCH 2.6.11-rc2 13/29] ide: use time_after() macro

2005-02-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Feb 2005 11:56:49 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 13_ide_tape_time_after.patch Explicit jiffy comparision converted to time_after() macro. Signed-off-by: Tejun Heo [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in

Re: [PATCH 2.6.11-rc2 14/29] ide: remove NULL checking in ide_error()

2005-02-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Feb 2005 11:57:28 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 14_ide_error_remove_NULL_test.patch In ide_error(), drive cannot be NULL. ide_dump_status() can't handle NULL drive. applied, you missed Signed-off-by line - To unsubscribe from this list: send the line

Re: [PATCH]: [RFC] Fix error handlnig in hwif-init and sgiioc4 driver

2005-02-08 Thread Bartlomiej Zolnierkiewicz
On Tue, 08 Feb 2005 10:53:56 -0500, Prarit Bhargava [EMAIL PROTECTED] wrote: Bartlomiej pointed out that the sgiioc4.c changes have made their way all changes into Linus' tree. Here's an updated change set. Thanks, P.

Re: Sata_promise.c queries

2005-02-09 Thread Bartlomiej Zolnierkiewicz
On Wed, 9 Feb 2005 08:51:47 -0700, Gary Poppitz [EMAIL PROTECTED] wrote: First off, I have the libdata-2.6 pull. The version of sata_promise.c is 1.58 . Is this the latest one available? Next question, in function pdc_qc_issue_prot, there is a BUG() call in the case of

Re: [PATCH 2.6.11-rc3 05/11] ide: fixes io_32bit race in ide_taskfile_ioctl()

2005-02-11 Thread Bartlomiej Zolnierkiewicz
applied to ide-dev-2.6, thanks I need some more time for the other patches - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[BK PATCHES] ide-dev-2.6 update

2005-02-11 Thread Bartlomiej Zolnierkiewicz
Hi Andrew, ide-dev-2.6 is fixed now and can be added back to -mm. ChangeLog: * fix OOPS in task_end_request() * add VIA VT6410 support (Mathias Kretschmer) * fix unneeded LBA48 taskfile registers access * fix io_32bit race in ide_taskfile_ioctl() (Tejun Heo) BK users: bk pull

[patch ide] fix ide_get_error_location() for LBA28

2005-02-20 Thread Bartlomiej Zolnierkiewicz
Higher bits (16-23) of the address were ignored Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] diff -Nru a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c --- a/drivers/ide/ide-io.c 2005-02-19 17:38:53 +01:00 +++ b/drivers/ide/ide-io.c 2005-02-19 17:38:53 +01:00 @@ -238,9

[patch ide-dev 2/9] add ide_tf_get_address() helper

2005-02-24 Thread Bartlomiej Zolnierkiewicz
* add ide_tf_get_address() helper * use it in idedisk_read_native_max_address[_ext]() and idedisk_set_max_address[_ext]() diff -Nru a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c --- a/drivers/ide/ide-disk.c2005-02-19 17:22:32 +01:00 +++ b/drivers/ide/ide-disk.c2005-02-19 17:22:32

Re: [patch ide-dev 4/9] add ide_task_init_flush() helper

2005-02-28 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 27 February 2005 05:56, Tejun Heo wrote: Hello, Just one minor thing. Doesn't moving ide_task_s upward belong to patch #7? It is needed for ide_task_init_flush() prototype. +void ide_task_init_flush(ide_drive_t *, ide_task_t *); - To unsubscribe from this list: send the

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-02-28 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 February 2005 08:36, Tejun Heo wrote: Hello, Bartlomiej. This patch should be modified to use flagged taskfile if the task_end_request_fix patch isn't applied. As non-flagged taskfile won't return valid result registers, TASK ioctl users won't get the correct register

Re: [patch ide-dev 1/9] use struct ata_taskfile in ide_task_t

2005-02-28 Thread Bartlomiej Zolnierkiewicz
On Thu, Feb 24, 2005 at 03:36:44PM +0100, Bartlomiej Zolnierkiewicz wrote: + tf-device = 0x40; Wouldn't ATA_LBA be clearer? I will change it, thanks. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-02-28 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 28 February 2005 16:24, Tejun Heo wrote: Hi, Bartlomiej Zolnierkiewicz wrote: On Sunday 27 February 2005 08:36, Tejun Heo wrote: Hello, Bartlomiej. This patch should be modified to use flagged taskfile if the task_end_request_fix patch isn't applied. As non

Re: [patch ide-dev 7/9] convert disk flush functions to use REQ_DRIVE_TASKFILE

2005-02-28 Thread Bartlomiej Zolnierkiewicz
On Monday 28 February 2005 16:12, Tejun Heo wrote: Bartlomiej Zolnierkiewicz wrote: On Sunday 27 February 2005 05:51, Tejun Heo wrote: Hello, Bartlomiej, On Thu, Feb 24, 2005 at 03:45:39PM +0100, Bartlomiej Zolnierkiewicz wrote: Original patch from Tejun Heo [EMAIL PROTECTED

Re: [patch ide-dev 8/9] make ide_task_ioctl() use REQ_DRIVE_TASKFILE

2005-03-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 02 Mar 2005 01:08:56 -0500, Jeff Garzik [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: Yes but it seems that you've assumed that ioctl == flagged taskfile and fs/internal == normal taskfile which is _not_ what I aim for. I want fully-flagged taskfile handling like

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 02 Mar 2005 00:56:18 -0500, Jeff Garzik [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: If somebody implements SG_IO ioctl and SCSI command pass-through from libata for IDE driver (and add possibility for discrete taskfiles), we can just deprecate HDIO_DRIVE_TASKFILE

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Mar 2005 01:49:52 +0900, Tejun Heo [EMAIL PROTECTED] wrote: Hello, Bartlomiej. On Tue, Mar 01, 2005 at 03:30:32PM +0100, Bartlomiej Zolnierkiewicz wrote: On Sun, 27 Feb 2005 15:49:22 +0900, Tejun Heo [EMAIL PROTECTED] wrote: Taskfile DMA path is still broken. Also calling

Re: [PATCH ide-dev-2.6] ide: ide_dma_intr oops fix

2005-03-03 Thread Bartlomiej Zolnierkiewicz
On Thu, 03 Mar 2005 15:57:18 +0900, Tejun Heo [EMAIL PROTECTED] wrote: Hello, Jens. Jens Axboe wrote: On Thu, Mar 03 2005, Tejun Heo wrote: Hello, Bartlomiej. This patch fixes ide_dma_intr() oops which occurs for TASKFILE ioctl using DMA dataphses. This is against the latest

Re: [PATCH] ide/amd74xx: fix section references

2005-03-04 Thread Bartlomiej Zolnierkiewicz
On Fri, 4 Mar 2005 09:03:07 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Thu, Mar 03, 2005 at 07:48:21PM -0800, Randy.Dunlap wrote: ide/pci/amd74xx: data structs point to __init text which should be __devinit; unless (a) these are going away real soon, or (b) this just can't

Re: [PATCH] ide/amd74xx: fix section references

2005-03-04 Thread Bartlomiej Zolnierkiewicz
On Fri, 04 Mar 2005 07:33:20 -0800, Randy.Dunlap [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: On Fri, 4 Mar 2005 09:03:07 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Thu, Mar 03, 2005 at 07:48:21PM -0800, Randy.Dunlap wrote: ide/pci/amd74xx: data structs point

Re: get-identity ioctl in libata?

2005-03-08 Thread Bartlomiej Zolnierkiewicz
Hi Jeff, My concerns are following: * it is not complete HDIO_GET_IDENTIFY implementation (applications may assume otherwise) * you may need to add byte-swapping of the fields in the future (currently it is fine) * same info is available via pass-thru inteface Bartlomiej On Mon, 07 Mar 2005

Re: PATCH: ALI15x3, 200GB HD, dma broken, no_lba48_dma

2005-03-10 Thread Bartlomiej Zolnierkiewicz
good catch, I overlooked lba48 flag when introducing no_lba48_dma I slightly modified your patch: diff -Nru a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c --- a/drivers/ide/ide-disk.c2005-03-10 16:07:50 +01:00 +++ b/drivers/ide/ide-disk.c2005-03-10 16:07:50 +01:00 @@ -168,6 +168,8 @@

Re: [PATCH] ide: hdio.txt update

2005-03-10 Thread Bartlomiej Zolnierkiewicz
Hi, On Thu, 3 Mar 2005 11:16:38 +0900, Tejun Heo [EMAIL PROTECTED] wrote: + [2] Both the input and output buffers are copied from the + user and written back to the user, even when not used. The + out_flags and in_flags are written back to the user after +

Re: PATCH libata-2.6 4/5] Prevent the device from overrunning the buffer in __atapi_pio_bytes()

2005-03-18 Thread Bartlomiej Zolnierkiewicz
On Fri, 18 Mar 2005 16:00:36 +0800, Albert Lee [EMAIL PROTECTED] wrote: Hi Jeff, Problem: Some bad behaved CD-ROM drives will return more data than ask to. (I have such CD-RW drive and it crashed the kernel.) These devices are compliant with original ATAPI spec. Such condition shouldn't

Re: [PATCH] ide: hdio.txt update

2005-03-18 Thread Bartlomiej Zolnierkiewicz
Hi, On Fri, 11 Mar 2005 15:29:08 +0900, Tejun Heo [EMAIL PROTECTED] wrote: Greetings Bartlomiej, I've updated the following * in_flags modification when out_flags != 0 in_flags == 0 * more than one - one or more than one * tf_{in|out}_flags - {in|out}_flags as tf_* are in-kernel

Re: hdregs.h puts csfo at word 129 - wrong, that's vendor specific

2005-03-25 Thread Bartlomiej Zolnierkiewicz
On Fri, 25 Mar 2005 20:48:21 -0500, Brett Russ [EMAIL PROTECTED] wrote: Jeff Garzik wrote: Chris Hann wrote: ide-disk.c checks csfo bit 0 to see if the cache is available on a device hdregs.h maps csfo to word 129 of the Identify Device information the latest ATA documentation, e00159r3

Re: kernel history of ide performance

2005-04-05 Thread Bartlomiej Zolnierkiewicz
On Apr 5, 2005 11:02 AM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: kiu wrote: Hi ide team, i often heard uh, since kernel 2.6.bla the ide perfomance is soo bad. Because of that (and the joy of writing bash scripts noone else will understand *g*) i wrote an automated test script to

Re: [PATCH 2.6.11.6] ide-scsi: kmap scatter/gather before doing PIO

2005-04-05 Thread Bartlomiej Zolnierkiewicz
: * please don't disable/enable local IRQs for !HIGHMEM case (see ide_pio_sector() in ide-taskfile.c) * declare 'unsigned long flags' at the beginning of the function (I sent this patch to linux-scsi a few weeks ago, and I was finally told that it is maintained by the IDE folks (Bartlomiej

Re: [git patches] IDE update

2005-07-04 Thread Bartlomiej Zolnierkiewicz
On 7/4/05, Al Boldi [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: { Please pull from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6.git } Does it fix the idedriver int/dma problem? What is the int/dma problem? - To unsubscribe from this list: send the line

Re: [git patches] IDE update

2005-07-04 Thread Bartlomiej Zolnierkiewicz
On 7/4/05, Al Boldi [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: { What is the int/dma problem? } Hdparm -tT gives 38mb/s in 2.4.31 Cat /dev/hda /dev/null gives 2% user 33% sys 65% idle Hdparm -tT gives 28mb/s in 2.6.12 Cat /dev/hda /dev/null gives 2% user 25% sys 0% idle

Re: [git patches] IDE update

2005-07-04 Thread Bartlomiej Zolnierkiewicz
On 7/4/05, Ondrej Zary [EMAIL PROTECTED] wrote: Al Boldi wrote: Bartlomiej Zolnierkiewicz wrote: { On 7/4/05, Al Boldi [EMAIL PROTECTED] wrote: Hdparm -tT gives 38mb/s in 2.4.31 Cat /dev/hda /dev/null gives 2% user 33% sys 65% idle Hdparm -tT gives 28mb/s in 2.6.12 Cat /dev/hda /dev

Re: [git patches] IDE update

2005-07-04 Thread Bartlomiej Zolnierkiewicz
On 7/4/05, Al Boldi [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: { On 7/4/05, Al Boldi [EMAIL PROTECTED] wrote: Hdparm -tT gives 38mb/s in 2.4.31 Cat /dev/hda /dev/null gives 2% user 33% sys 65% idle Hdparm -tT gives 28mb/s in 2.6.12 Cat /dev/hda /dev/null gives 2

Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes

2005-07-06 Thread Bartlomiej Zolnierkiewicz
On 7/6/05, Andi Kleen [EMAIL PROTECTED] wrote: Without this patch a dual Xeon EM64T machine would oops on boot because the hwif pointer here was NULL. I also added a check for pci_dev because it's doubtful that all IDE devices have pci_devs. Signed-off-by: Andi Kleen [EMAIL PROTECTED]

Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes

2005-07-06 Thread Bartlomiej Zolnierkiewicz
On 7/6/05, Andi Kleen [EMAIL PROTECTED] wrote: drive-hwif check is redundant, please remove it It's not. My first version didn't have it but it still crashed. It's what actually prevents the crash. I also don't know why, but it's true. very weird as HWIF(drive) == drive-hwif:

Re: [git patches] IDE update

2005-07-07 Thread Bartlomiej Zolnierkiewicz
On 7/6/05, Bill Davidsen [EMAIL PROTECTED] wrote: Ondrej Zary wrote: Jens Axboe wrote: On Tue, Jul 05 2005, Ondrej Zary wrote: André Tomt wrote: Al Boldi wrote: Bartlomiej Zolnierkiewicz wrote: { On 7/4/05, Al Boldi [EMAIL PROTECTED] wrote: Hdparm -tT gives 38mb/s

Re: libata and PATA devices

2005-08-11 Thread Bartlomiej Zolnierkiewicz
On 8/11/05, Erik Slagter [EMAIL PROTECTED] wrote: On Wed, 2005-08-10 at 23:57 -0400, Jeff Garzik wrote: Most current laptops ship with a PATA hard drive, and a PATA ATAPI drive. The easiest way to make them usable under Linux-2.6 New laptops rather ship with: SATA (or PATA + bridge)

Re: libata and PATA devices

2005-08-11 Thread Bartlomiej Zolnierkiewicz
On 8/11/05, Erik Slagter [EMAIL PROTECTED] wrote: On Thu, 2005-08-11 at 12:03 +0200, Bartlomiej Zolnierkiewicz wrote: Most current laptops ship with a PATA hard drive, and a PATA ATAPI drive. The easiest way to make them usable under Linux-2.6 New laptops rather ship with: SATA

Re: libata and PATA devices

2005-08-11 Thread Bartlomiej Zolnierkiewicz
On 8/11/05, Erik Slagter [EMAIL PROTECTED] wrote: On Thu, 2005-08-11 at 12:26 +0200, Bartlomiej Zolnierkiewicz wrote: As ICH6M features both PATA and SATA connections, I don't see why they'd use a PATA bridge... The DVD drives use PATA anyway, btw. AFAIR ICH6M has only one PATA port

Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64

2005-08-16 Thread Bartlomiej Zolnierkiewicz
Hi, On 8/15/05, Bjorn Helgaas [EMAIL PROTECTED] wrote: On Friday 12 August 2005 2:40 am, Alan Cox wrote: Assuming all IA-64 boxes are PCI or better then you actually want to edit include/asm-ia64/ide.h and edit ide_default_io_base where someone years ago cut and pasted x86-32 values so

Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64

2005-08-16 Thread Bartlomiej Zolnierkiewicz
On 8/16/05, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Hi, On 8/15/05, Bjorn Helgaas [EMAIL PROTECTED] wrote: On Friday 12 August 2005 2:40 am, Alan Cox wrote: Assuming all IA-64 boxes are PCI or better then you actually want to edit include/asm-ia64/ide.h and edit

Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64

2005-08-16 Thread Bartlomiej Zolnierkiewicz
On 8/16/05, Alan Cox [EMAIL PROTECTED] wrote: * non-functional HDIO_REGISTER_HWIF ioctl (ain't really working either) HDIO_SCAN_HWIF - I don't know about this one. How are we supposed to follow the new ports shouldn't define IDE_ARCH_OBSOLETE_INIT injunction if we lose all this

Re: UDMA modes

2005-08-17 Thread Bartlomiej Zolnierkiewicz
On 8/17/05, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: I updated Kernel at 2.6.12-1.1372_FC3 by rpm package. Kernel reconized Controller IDE, infact dmesg command gets: Uniform Multi-PLatform E-IDE driver revision: 7.00alpha2 VP_IDE: IDE controller at PCI slot :00:07.1 VP_IDE: chipset

Re: when are buffers/caches flushed?

2005-08-18 Thread Bartlomiej Zolnierkiewicz
Hi, On 8/18/05, Tejun Heo [EMAIL PROTECTED] wrote: Steven Scholz wrote: Tejun Heo wrote: Steven Scholz wrote: Hi there, According to an (old) man page of sync(2) According to the standard specification (e.g., SVID), sync() schedules the writes, but may

Re: when are buffers/caches flushed?

2005-08-18 Thread Bartlomiej Zolnierkiewicz
On 8/18/05, Tejun Heo [EMAIL PROTECTED] wrote: Hmmm, disks are not removed on shutdown, so it's not called on shutdown. Yep, I got confused that you meant driver removal. from ide_device_shutdown()... above is called on device shutdown Thanks, Bartlomiej - To unsubscribe from this

[git patches] ide update

2005-08-18 Thread Bartlomiej Zolnierkiewicz
. Includes the Revolution in the list of simplex devices forced into DMA mode. Signed-off-by: Matt Gillette [EMAIL PROTECTED] Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] commit

Re: libata total system lockup fix

2005-08-19 Thread Bartlomiej Zolnierkiewicz
On 8/19/05, Mark Lord [EMAIL PROTECTED] wrote: Erik Slagter wrote: On Thu, 2005-08-18 at 20:46 -0400, Mark Lord wrote: After a week of further experience with this patch, .. I'm now reverting to the original broken patch .. What is exactly the broken patch and what is this patch?

Re: libata total system lockup fix

2005-08-19 Thread Bartlomiej Zolnierkiewicz
On 8/19/05, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On 8/19/05, Mark Lord [EMAIL PROTECTED] wrote: Erik Slagter wrote: On Thu, 2005-08-18 at 20:46 -0400, Mark Lord wrote: After a week of further experience with this patch, .. I'm now reverting to the original broken patch

Re: [git patches] ide update

2005-08-19 Thread Bartlomiej Zolnierkiewicz
On 8/19/05, Alan Cox [EMAIL PROTECTED] wrote: On Gwe, 2005-08-19 at 11:02 +0200, Bartlomiej Zolnierkiewicz wrote: lkml.org/lkml/2005/1/27/20 AFAIK CS5535 driver was never ported to 2.6.x. Somebody needs to port it to 2.6.x kernel, cleanup to match kernel coding standards and test

Re: PATCH: ide: ide-disk freeze support for hdaps

2005-08-25 Thread Bartlomiej Zolnierkiewicz
Hi, On 8/25/05, Yani Ioannou [EMAIL PROTECTED] wrote: Hi all, Attached below is a patch heavily based on Jon Escombe's patch, but implemented as a sysfs attribute as Jens described, with a timeout (configurable by module/kernel parameter) to ensure the queue isn't stopped forever. The

[RFH][PATCH] CS5535 driver

2005-08-29 Thread Bartlomiej Zolnierkiewicz
Hi, Alan Cox has sent me this driver recently. It needs a little bit of work to become acceptable into mainline kernel and as I don't have neither the hardware nor the time to work on it now, I'm posting it to you and linux-ide ML with a remaining TODO list (original patch attached to the mail).

Re: [PATCH] Add VIA VT6410 support

2005-08-30 Thread Bartlomiej Zolnierkiewicz
On 8/30/05, Daniel Drake [EMAIL PROTECTED] wrote: Jeff/Bart, Can of you please apply this to a git tree and get this included in 2.6.14. The patch is about 6 months old and has been included in Gentoo kernels for about 3 months, and we've recieved multiple success reports. I sent a mail

Re: [PATCH 2.6.13] ide: ide-dma.c should always check hwif-cds before hwif-cds-foo

2005-09-08 Thread Bartlomiej Zolnierkiewicz
Hi, On 9/8/05, Tom Rini [EMAIL PROTECTED] wrote: In some cases (such as the mips Toshiba TX4939 w/ onboard IDE, not PCI IDE), hwif-cds can be NULL, so test that prior to testing hwif-cds-foo Both ide_iomio_dma() and ide_mapped_mmio_dma() are only called from ide_dma_iobase(). ide_setup_dma()

Re: [PATCH] ide_scsi: allow it to be used for non CD only

2006-11-29 Thread Bartlomiej Zolnierkiewicz
Hi, Nowadays, you can dynamically change driver bound to a device using sysfs and it works just fine for IDE, ie: echo -n 1.0 /sys/bus/ide/drivers/ide-scsi/unbind echo -n 1.0 /sys/bus/ide/drivers/ide-cdrom/bind to unbind /dev/hdc from ide-scsi and bind to ide-cdrom That was one of the main

Re: [PATCH] ide_scsi: allow it to be used for non CD only

2006-11-29 Thread Bartlomiej Zolnierkiewicz
On 11/29/06, Alan [EMAIL PROTECTED] wrote: On Wed, 29 Nov 2006 23:05:56 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Hi, Nowadays, you can dynamically change driver bound to a device using sysfs and it works just fine for IDE, ie: This isn't the point of this change. The point

Re: [PATCH] winbond IDE depends on IDEDMA

2006-11-30 Thread Bartlomiej Zolnierkiewicz
Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] On 11/30/06, Olaf Hering [EMAIL PROTECTED] wrote: winbond ide depends on idedma. drivers/built-in.o: In function `.sl82c105_ide_dma_timeout': sl82c105.c:(.text+0x624d0): undefined reference to `.__ide_dma_timeout' drivers/built-in.o

Re: [PATCH] winbond IDE depends on IDEDMA

2006-11-30 Thread Bartlomiej Zolnierkiewicz
On 11/30/06, Olaf Hering [EMAIL PROTECTED] wrote: winbond ide depends on idedma. Move the option into the IDEDMA section. Yep, this is better solution. Andrew, please push upstream. Bart - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: [PATCH] ide-cd: Handle strange interrupt on the Intel ESB2

2006-12-05 Thread Bartlomiej Zolnierkiewicz
[ added Jeff and Tejun to cc: ] On 12/4/06, Alan [EMAIL PROTECTED] wrote: The ESB2 appears to emit spurious DMA interrupts when configured for native mode and handling ATAPI devices. Stratus were able to pin this bug down and produce a patch. This is a rework which applies the fixup only to the

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Bartlomiej Zolnierkiewicz
On 12/13/06, Alan [EMAIL PROTECTED] wrote: +static int tc86c001_busproc(ide_drive_t *drive, int state) +{ Waste of space having a busproc routine. The maintainer removed all the usable hotplug support from old IDE so this might as well be dropped. I took over IDE when hotplug was already

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-13 Thread Bartlomiej Zolnierkiewicz
On 12/13/06, Alan [EMAIL PROTECTED] wrote: Waste of space having a busproc routine. The maintainer removed all the usable hotplug support from old IDE so this might as well be dropped. I took over IDE when hotplug was already broken (late 2.5), moreover IDE hotplug support has been always

Re: [PATCH] via82cxxx: fix cable detection

2006-12-27 Thread Bartlomiej Zolnierkiewicz
On 12/27/06, Tejun Heo [EMAIL PROTECTED] wrote: Cable detection got broken probably while converting the driver to support multiple controllers. Cable detection is done by examining how BIOS configured the attached devices. The current code is broken in that it examines the status *after*

Re: hda on Via Epia-ML motherboard seen on 2.6.18, but not 2.6.19

2006-12-28 Thread Bartlomiej Zolnierkiewicz
On 12/28/06, Adam J. Richter [EMAIL PROTECTED] wrote: On Tue, 26 Dec 2006 06:36:45 +0800, Adam Richter wrote: On Fri, 22 Dec 2006 14:56:20 +0100, Bartlomiej Zolnierkiewicz wrote: On 12/22/06, Adam J. Richter [EMAIL PROTECTED] wrote: I have a 666MHz Via Epia-ML motherboard (using a Via

Re: hda on Via Epia-ML motherboard seen on 2.6.18, but not 2.6.19

2006-12-29 Thread Bartlomiej Zolnierkiewicz
On 12/29/06, Adam J. Richter [EMAIL PROTECTED] wrote: On 12/22/06, I wrote I have a 666MHz Via Epia-ML motherboard (using a Via Eden, I think). I am booting it from a CompactFlash card attached by an IDE-CF adapter. Everything works fine under 2.6.18. Under 2.6.19, 2.6.19.1 and

Re: [PATCH 2.6.20-rc2-mm1] PIIX tuneproc() fixes/cleanups

2007-01-06 Thread Bartlomiej Zolnierkiewicz
, so must pass the correct limit to ide_get_best_pio_mode(); - use min_t() macro instead of min(); - simplify slave vs master drive evaluation; - do come coding and formatting cleanups... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

Re: [PATCH 1/3] atiixp.c: remove unused code

2007-01-09 Thread Bartlomiej Zolnierkiewicz
On 1/9/07, Conke Hu [EMAIL PROTECTED] wrote: On 1/7/07, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On 1/6/07, Conke Hu [EMAIL PROTECTED] wrote: A previous patch to atiixp.c was removed but some code has not been This one? http://kernel.org/git/?p=linux/kernel/git/torvalds/linux

[PATCH] ia64: add pci_get_legacy_ide_irq() (was: [2.6 patch] let BLK_DEV_AMD74XX depend on X86)

2007-01-11 Thread Bartlomiej Zolnierkiewicz
kernel Bugzilla #6644. Does the following patch fix the problem? [PATCH] ia64: add pci_get_legacy_ide_irq() Add pci_get_legacy_ide_irq() identical to the one used by i386/x86_64. Fixes amd74xx driver build on ia64 (bugzilla bug #6644). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 0/19] new IDE quilt tree

2007-01-11 Thread Bartlomiej Zolnierkiewicz
Hi, My working IDE tree (against Linus' tree) now resides here: http://kernel.org/pub/linux/kernel/people/bart/pata-2.6/patches/ and is managed by quilt. Currently it contains the following changes: * all IDE patches from 2.6.20-rc3-mm1 (great work done by Sergei Shtylyov [EMAIL

[PATCH 2/19] ide: add it8213 driver

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: add it8213 driver From: Jack Lee [EMAIL PROTECTED] From: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |5 drivers/ide/pci/Makefile |2 drivers/ide/pci/it8213.c | 402

[PATCH 3/19] ide: it8213 driver update

2007-01-11 Thread Bartlomiej Zolnierkiewicz
* fix it8213_ratemask() and it8213_tuneproc() comments * simplify it8213_init_hwif() * remove init_chipset_it8213() * add missing Copyrights and update MODULE_AUTHOR() * CodingStyle cleanups * remove dead code Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/it8213.c

[PATCH 6/19] pdc202xx_old: remove dead code

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] pdc202xx_old: remove dead code CONFIG_PDC202XX_MASTER config option doesn't exist Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_old.c | 19 --- 1 file changed, 19 deletions(-) Index: a/drivers/ide/pci/pdc202xx_old.c

[PATCH 14/19] cs5530: small cleanup

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] cs5530: small cleanup * BUG() on unknown DMA mode in cs5530_config_dma() * there is no need to call hwif-ide_dma_host_{off,on}() in cs5530_config_dma() because hwif-ide_dma_host_{off,on}() is called by hwif-ide_dma_off_{quietly,on}() Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 12/19] ide: remove ide_drive_t.usage

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: remove ide_drive_t.usage This field is no longer used by the core IDE code so fix ide-{disk,floppy} drivers to keep openers count in the driver specific objects and remove it from ide-{cd,scsi,tape} drivers (it was write-only). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 16/19] sis5513: sis5513_config_xfer_rate() cleanup

2007-01-11 Thread Bartlomiej Zolnierkiewicz
tuning code) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sis5513.c | 41 +++-- 1 file changed, 3 insertions(+), 38 deletions(-) Index: a/drivers/ide/pci/sis5513.c

[PATCH 17/19] ide: unexport ide_set_xfer_rate()

2007-01-11 Thread Bartlomiej Zolnierkiewicz
-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-lib.c |2 -- drivers/ide/pci/cmd64x.c |7 ++- drivers/ide/pci/siimage.c |5 + 3 files changed, 3 insertions(+), 11 deletions(-) Index: a/drivers/ide/ide-lib.c

[PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: add ide_use_fast_pio() helper * add ide_use_fast_pio() helper for use by host drivers * add DMA capability and autodma checks to ide_use_dma() - au1xxx-ide/it8213/it821x drivers didn't check for (id-capability 1) - ide-cris driver didn't set -autodma Signed-off-by: Bartlomiej

[PATCH 9/19] ide: remove write-only ide_hwif_t.no_dsc flag

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: remove write-only ide_hwif_t.no_dsc flag Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |8 drivers/ide/ide.c |1 - drivers/ide/pci/aec62xx.c |4 +--- drivers/ide/pci/hpt34x.c |1 - include/linux/ide.h

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: On Fri, 12 Jan 2007 05:28:00 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: add ide_use_fast_pio() helper * add ide_use_fast_pio() helper for use by host drivers * add DMA capability and autodma checks to ide_use_dma

Re: [PATCH 19/19] ide: use PIO/MMIO operations directly where possible

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: On Fri, 12 Jan 2007 05:28:07 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: use PIO/MMIO operations directly where possible This results in smaller/faster/simpler code and allows future optimizations. Also remove no longer

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: if(strstr(id-model, Integrated Technology Express)) { /* In raid mode the ident block is slightly buggy We need to set the bits so that the IDE layer knows LBA28.

Re: [PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-12 Thread Bartlomiej Zolnierkiewicz
On 1/12/07, Alan [EMAIL PROTECTED] wrote: It seems that it821x_tune_chipset() is buggy since it sends SET FEATURES command even when in smart mode. Shouldn't there be don't tune flag in it812x_fixups() to tell it821x_tune_chipset() to not send SET FEATURES commands? It's itdev-smart but

[PATCH 11/15] ide: make ide_hwif_t.ide_dma_{host_off,off_quietly} void

2007-01-18 Thread Bartlomiej Zolnierkiewicz
__ prefix Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c | 10 -- drivers/ide/cris/ide-cris.c | 14 ++ drivers/ide/ide-cd.c |6 +++--- drivers/ide/ide-dma.c | 39

[PATCH 15/15] ide: add ide_tune_dma() helper

2007-01-18 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: add ide_tune_dma() helper After reworking the code responsible for selecting the best DMA transfer mode it is now possible to add generic ide_tune_dma() helper. Convert some IDE PCI host drivers to use it (the ones left need more work). Signed-off-by: Bartlomiej Zolnierkiewicz

  1   2   3   4   5   6   7   8   9   10   >