Re: High CPU Usage - bad output on hp6xx keyboard

2008-05-13 Thread Dmitry Torokhov
Hi Kristoffer, On Tue, May 13, 2008 at 10:53:56PM +0200, Kristoffer Ericson wrote: Hey Dmitry Paul Want your input on best way to handle this. As you know the HP 6xx keyboard is using the poll interrupt. I believe my current issue is due to the fact that it uses a fixed time (50ms) to

Re: [HP6xx/Patch] - update touchscreen driver

2008-04-28 Thread Dmitry Torokhov
Hi Kristoffer, On Sun, Apr 27, 2008 at 04:49:44PM +0200, Kristoffer Ericson wrote: - -static struct input_dev *hp680_ts_dev; +struct input_dev *dev; Why does it need to be global? dev a a name is ratehr non-descriptive too given that we are dealing with input devices, platform devices and

Re: [patch 2.6.25-rc8] omap-keypad: fix build warning

2008-04-14 Thread Dmitry Torokhov
On Fri, Apr 11, 2008 at 01:09:18AM -0700, David Brownell wrote: From: David Brownell [EMAIL PROTECTED] Build fixes: drivers/input/keyboard/omap-keypad.c: In function 'omap_kp_probe': drivers/input/keyboard/omap-keypad.c:418: warning: 'row_idx' is used uninitialized in this function

Re: [RESEND patch 2.6.25-rc8] gpio_keys irq handling

2008-04-14 Thread Dmitry Torokhov
PROTECTED] Cc: Dmitry Torokhov [EMAIL PROTECTED] Applied, thank you David. -- Dmitry

Re: [RESEND patch 2.6.25-rc8] ads7846 vref support (ads7843)

2008-04-11 Thread Dmitry Torokhov
On Fri, Apr 11, 2008 at 01:15:25AM -0700, David Brownell wrote: On Friday 11 April 2008, David Brownell wrote: Updated since the version sent 5-January (evidently bounced from list archives) ... to remove the warning fix that was merged (from someone else) on 10-March. Could you please

Re: [FIX / HP7xx] - Fix touchscreen to work without tsdev

2008-04-03 Thread Dmitry Torokhov
[Picking up old thread...] On Fri, Mar 21, 2008 at 10:43:14PM +, Richard Purdie wrote: Later on in the code, BTN_TOUCH should do that same job but that isn't looked for in the initial check_fd() code. tslib can be easily fixed to address that issue and if nobody else writes a patch I'll

Re: [FIX / HP7xx] - Fix touchscreen to work without tsdev

2008-03-21 Thread Dmitry Torokhov
Hi Kristoffer, On Fri, Mar 21, 2008 at 08:40:19PM -0700, Kristoffer Ericson wrote: This patch makes the jornada 7xx touchscreen work without tsdev. It changes the ABS values and makes sure the report_key is done in right order (for tslib). We also change the printk's to use ERR instead of

Re: [HP j6xx / FIX] - Fix so touchscreen driver works again

2008-03-10 Thread Dmitry Torokhov
On Thu, Mar 06, 2008 at 10:51:47PM +0100, Jiri Kosina wrote: On Thu, 6 Mar 2008, Kristoffer Ericson wrote: The general replies I've gotten when asking to change filenames is that they don't want to break back-portability or whatever. To tell you the truth im not fully in the clear what

Re: Question regarding input phys

2008-02-07 Thread Dmitry Torokhov
On Thu, Feb 07, 2008 at 11:05:04PM +0100, Kristoffer Ericson wrote: On Thu, 7 Feb 2008 16:50:55 -0500 Dmitry Torokhov [EMAIL PROTECTED] wrote: Hi Kristoffer, On Thu, Feb 07, 2008 at 10:33:34PM +0100, Kristoffer Ericson wrote: Dmitry, (or anyone else) in what way is the phys

Re: [PATCH 1/6] Core driver for WM97xx touchscreens

2008-02-07 Thread Dmitry Torokhov
Hi Mark, On Sat, Jan 26, 2008 at 05:28:31PM +, Mark Brown wrote: + + /* register our battery device */ + wm-battery_dev = platform_device_alloc(wm97xx-battery, 0); + if (!wm-battery_dev) + goto batt_err; ... + batt_err: +

Re: Question regarding input phys

2008-02-07 Thread Dmitry Torokhov
Hi Kristoffer, On Thu, Feb 07, 2008 at 10:33:34PM +0100, Kristoffer Ericson wrote: Dmitry, (or anyone else) in what way is the phys = blablabla/input0 important aside from placement in /sys? Im asking because all my keyboard/touchscreen end with input0 and wondering if I need to set one to

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-18 Thread Dmitry Torokhov
Hi Mark, On Fri, Jan 18, 2008 at 04:27:06PM +, Mark Brown wrote: This patch series adds support for the touchscreen controllers provided by Wolfson Microelectronics WM97xx series chips in both polled and streaming modes. Thank you for the patches. Some comments below. +static int

Re: {Jornada7xx} patches (keyboard fix driver Kconfig cleanup)

2008-01-14 Thread Dmitry Torokhov
Hi Kristoffer, On Jan 13, 2008 6:05 AM, Kristoffer Ericson [EMAIL PROTECTED] wrote: Greetings Dmitry, Seems like I've been sending to bad email adress. Was wondering of the status of my patches sent about a month ago (jornada keyboard). I've attached them just in case. The first one has

Re: [PATCH] Pass EV_PWR events to event handlers

2008-01-03 Thread Dmitry Torokhov
On Jan 1, 2008 7:22 PM, Richard Purdie [EMAIL PROTECTED] wrote: input_handle_event() used to pass EV_PWR events to event handlers but no longer does so in 2.6.23. Modules to trigger power management events based on input power events exist but rely on the EV_PWR events being passed to the

Re: [PATCH] Fix spitzkbd suspend key handling

2008-01-03 Thread Dmitry Torokhov
On Jan 1, 2008 7:17 PM, Richard Purdie [EMAIL PROTECTED] wrote: The spitz keyboard driver reports KEY_SUSPEND events but doesn't register its use of this event in the keybit bitfield, breaking input events for this key. This patch fixes that by registering the key in the keybit bitfield.

Re: keyfuzz... KEY_FN and keyboard with no Insert key

2008-01-03 Thread Dmitry Torokhov
Hi Federico, On Jan 1, 2008 5:50 PM, Federico Ferri [EMAIL PROTECTED] wrote: again it's me dealing with Apple Keyboards... I got the latest [1], which unfortunately lacks an Insert key (yes, I could type 'i' instead of hitting Intert inside vim, but I'd like to get my Ins key back... you

Re: [PATCH] Fujitsu application panel driver

2007-12-12 Thread Dmitry Torokhov
Hi Stephen, On Oct 23, 2007 2:55 PM, Stephen Hemminger [EMAIL PROTECTED] wrote: +static void mail_led_set(struct led_classdev *led, +enum led_brightness value) +{ + struct apanel *ap = container_of(led, struct apanel, mail_led); + if (value) +

Re: [PATCH] USB IDs for KBGear Pablo tablet for kbtab driver

2007-12-06 Thread Dmitry Torokhov
Hi John, On Dec 6, 2007 7:44 AM, John Pham [EMAIL PROTECTED] wrote: Ignore the above, looks like my xserver was reading off /dev/input/mice - the kernel kbtab driver appears to allow the tablet to emulate a mouse, but doesn't really work w/ pressure sensitivity, With kb_pressure_click=-1

Re: [PATCH 1/1] [INPUT/KEYPAD] Blackfin BF54x keypad driver: keypad does not exist on BF544 parts

2007-11-26 Thread Dmitry Torokhov
On Friday 23 November 2007, Bryan Wu wrote: From: Mike Frysinger [EMAIL PROTECTED] Signed-off-by: Mike Frysinger [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] Applied, thank you Mike Bryan. -- Dmitry

Re: [PATCH] ACPI: Put button input devices in correct place in sysfs

2007-11-14 Thread Dmitry Torokhov
On 11/11/07, Andrey Borzenkov [EMAIL PROTECTED] wrote: On Tuesday 06 November 2007, Dmitry Torokhov wrote: Hi Andrey, On Nov 6, 2007 12:51 PM, Andrey Borzenkov [EMAIL PROTECTED] wrote: Properly set up parent on input device registered by the button driver. Seems to be a popular

Re: [PATCH] Fix incorrect usage of strncpy and strncat in i8042_pnp_kbd_probe(); drivers/input/serio/i8042-x86ia64io.h

2007-11-05 Thread Dmitry Torokhov
Hi Roel, On Nov 5, 2007 3:24 PM, Roel Kluin [EMAIL PROTECTED] wrote: See http://www.gratisoft.us/todd/papers/strlcpy.html -- Fix incorrect length argument for strncpy and strncat by replacing them with What is incorrect about the argument? respectively strlcpy and strlcat I will gladly

[PATCH] HID: Don't access input_dev-private directly

2007-10-30 Thread Dmitry Torokhov
Hi Jiri, I'd like for the patch below to go to Linus rather sooner than later because I want to commit patch removing input_dev-private... ..Or I could push it through my tree if you give me your Acked-by. -- Dmitry Subject: HID: Don't access input_dev-private directly From: Dmitry Torokhov

Re: [RFC: 2.6 patch] remove the USB_STORAGE_ONETOUCH driver

2007-10-28 Thread Dmitry Torokhov
On Sunday 28 October 2007 16:39, Jiri Kosina wrote: On Sun, 28 Oct 2007, Torsten Kaiser wrote: But it looks like that uses another driver: hiddev0hidraw1: USB HID v1.10 Device [Western Digital External HDD] on usb-:00:02.1-5.2 Otherwise I would be willing to try to test this, if

Re: [PATCH] appletouch: add myself as maintainer

2007-10-27 Thread Dmitry Torokhov
On Wednesday 24 October 2007 07:46, Johannes Berg wrote: After the last patch that broke appletouch for powerbooks again (many more have previously been proposed), I'd like to take over maintainership of this driver to make sure it doesn't break again in the future. Signed-off-by: Johannes

Re: [PATCH] Fujitsu application panel driver

2007-10-27 Thread Dmitry Torokhov
Hi Stephen, On Tuesday 23 October 2007 15:55, Stephen Hemminger wrote: + +static int apanel_setkeycode(struct input_dev *idev, int scancode, int keycode) +{ + struct apanel *ap = idev-private; + + if (keycode 0 || keycode KEY_MAX) + return -EINVAL; + + if

Re: [PATCH] Input: Support for a less exclusive grab.

2007-10-26 Thread Dmitry Torokhov
On 10/26/07, Zephaniah E. Hull [EMAIL PROTECTED] wrote: On Thu, Oct 25, 2007 at 01:37:34AM -0400, Ryan Lortie wrote: On Wed, 2007-24-10 at 11:35 -0400, Zephaniah E. Hull wrote: We need a way to, at the absolute minimum, unbind the keyboard from the text console. The current solution

Re: [PATCH] input - Add Euro and Dollar keys

2007-10-25 Thread Dmitry Torokhov
On Thursday 25 October 2007, Carlos Corbacho wrote: From: Carlos Corbacho [EMAIL PROTECTED] Most newer Acer laptops (from 2005 onwards) now ship with an extra Dollar and Euro key either side of the 'Up' arrow. These cannot be mapped in the traditional way, since they are not combination

Re: [PATCH] Input: Support for a less exclusive grab.

2007-10-23 Thread Dmitry Torokhov
Hi Ryan, On 9/28/07, Ryan Lortie [EMAIL PROTECTED] wrote: Hello. I have been working on a more flexible system for blocking the delivery of input events to other agents in the system. My approach is basically summed up as follows: - split the current purpose of input_handle into two

Re: [PATCH] Input: Support for a less exclusive grab.

2007-10-23 Thread Dmitry Torokhov
On 10/23/07, Ryan Lortie [EMAIL PROTECTED] wrote: On Tue, 2007-23-10 at 09:21 -0400, Dmitry Torokhov wrote: Priority/filter idea is different matter. I don't think it is a giood solution. There will always be an arms race, new applications would like to get in front of the queue all

Re: [PATCH 1/1] INPUT/BF54x-KEYPAD driver: Remove useless line -errno returned by irq_request

2007-10-21 Thread Dmitry Torokhov
On Thursday 18 October 2007, Bryan Wu wrote: From: Michael Hennerich [EMAIL PROTECTED] Cc: Andrey Panin [EMAIL PROTECTED] Signed-off-by: Michael Hennerich [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] Applied, thank you Michael, Bryan. -- Dmitry

Re: Power button policy and mechanism

2007-10-16 Thread Dmitry Torokhov
Hi Kristoffer, On 10/16/07, Kristoffer Ericson [EMAIL PROTECTED] wrote: Greetings Dmitry, Is the suggested approach on handling powerbutton (in keyboard driver) to simply push out the event and let userland handle it? Yes. The reason Im asking this is because as you might know Im

Re: Enabling extra scancodes on some Acer laptops

2007-10-16 Thread Dmitry Torokhov
Hi Carlos, On 10/14/07, Carlos Corbacho [EMAIL PROTECTED] wrote: After calling set_keyboard_quirk(), the extra keys start generating proper scancodes, and can be mapped as normal via setkeycodes. At the moment, I've added this quirk to acer_acpi (it's currently only applied on the few

Re: Enabling extra scancodes on some Acer laptops

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Carlos Corbacho [EMAIL PROTECTED] wrote: Dimitry, On Tuesday 16 October 2007 15:37:37 you wrote: I think it could be added to i8042 driver to enable it. How messy is detection? I use simple DMI matching in acer_acpi to do this on known broken laptops. (acerhk calls directly

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Bryan Wu [EMAIL PROTECTED] wrote: On 10/16/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 10/15/07, Bryan Wu [EMAIL PROTECTED] wrote: On 10/15/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: Completion is just not a good abstraction here... Please use work abstraction

Re: Problem with appletouch driver in Linux version 2.6.23-rc7

2007-10-15 Thread Dmitry Torokhov
Hi Soeren, On 10/13/07, Soeren Sonnenburg [EMAIL PROTECTED] wrote: I am not sure whether it is worth fighting for. For the moment I think we should just use the attached patch (where I as you suggest set idlecount to 2). So if there are no objections, Dmity please apply. I already applied

Re: [patch 1/8] m68k: Atari input drivers cleanup

2007-10-15 Thread Dmitry Torokhov
Hi Geert, On 10/13/07, Geert Uytterhoeven [EMAIL PROTECTED] wrote: m68k: Atari input drivers cleanup: - memleak on failed init/register of input devices fixed - correct keycodes table (Atari keycodes are almost, but not entirely, equal to Linux keycodes). Signed-off-by: Michael Schmitz

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Dmitry Torokhov
Hi Bryan, On 10/15/07, Bryan Wu [EMAIL PROTECTED] wrote: + +static int ad7142_thread(void *nothing) +{ + do { + wait_for_completion(ad7142_completion); + ad7142_decode(); + enable_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX); + } while

Re: [PATCH 2/3] Input/Touchscreen Driver: add support AD7877 touchscreen driver

2007-10-15 Thread Dmitry Torokhov
Hi Michael, On 10/15/07, Hennerich, Michael [EMAIL PROTECTED] wrote: + +static int ad7877_read(struct device *dev, u16 reg) +{ + struct spi_device *spi = to_spi_device(dev); + struct ser_req *req = kzalloc(sizeof *req, GFP_KERNEL); How many reads can

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Dmitry Torokhov
On 10/15/07, Bryan Wu [EMAIL PROTECTED] wrote: On 10/15/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: Completion is just not a good abstraction here... Please use work abstraction and possibly a separate workqueue. Yes, I agree with you now, although I have a little concern about

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
Hi Ahmed, On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote: On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote: Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- Hi Bryan, Why creating module's own kthread to call ad7142_decode and process keycodes instead of using a tasklet ?

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 11:50 -0400, Dmitry Torokhov wrote: On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: Hi Bryan, On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: Hi Bryan, On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: + [snip] + +static void ad7142_close(struct input_dev *dev) +{ + free_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote: On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote: Isn't disabling device interrupts from the begining of the ISR ad7142_interrupt till the kthread ad7142_thread got waked-up and scheduled a long time, espicially

Re: GeneralTouch USB Touchscreen Support

2007-10-11 Thread Dmitry Torokhov
Hi Jiri, On Monday 08 October 2007, Jiri Kosina wrote: On Mon, 8 Oct 2007, Dmitry Torokhov wrote: The patch looks good, thanks a lot. Can I please have your Signed-off-by: so I can apply it? Thanks! Hi, my only concern with this patch is -- could we please keep the entries

Re: [PATCH 2/3] Input/Touchscreen Driver: add support AD7877 touchscreen driver

2007-10-11 Thread Dmitry Torokhov
Hi Bryan, Michael, On 10/11/07, Bryan Wu [EMAIL PROTECTED] wrote: + +static int gpio3 = 0; No need to initialize. + +static int ad7877_read(struct device *dev, u16 reg) +{ + struct spi_device *spi = to_spi_device(dev); + struct ser_req *req = kzalloc(sizeof

Re: [PATCH try #3] Blackfin BF54x Input Keypad controller driver

2007-10-11 Thread Dmitry Torokhov
;. Please let me know if you are OK with it. Thanks! Cc: Dmitry Torokhov [EMAIL PROTECTED] Signed-off-by: Michael Hennerich [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- arch/blackfin/mach-bf548/boards/ezkit.c |2 +- drivers/input/keyboard/Kconfig |9

Re: [PATCH] Generic, platform independent matrix keyboard support

2007-10-10 Thread Dmitry Torokhov
On 10/9/07, David Brownell [EMAIL PROTECTED] wrote: On Tuesday 09 October 2007, Pavel Pisa wrote: On the other hand I cannot imagine electronic designed wanting so many wires. Reduction of the wires counts is why matrix keyboards are used. The 32 bits limitation then means that maximal

Re: [PATCH] Generic, platform independent matrix keyboard support

2007-10-10 Thread Dmitry Torokhov
On 10/9/07, Pavel Pisa [EMAIL PROTECTED] wrote: Name of corresponding platform and PCI methods is probe. But name can be changed if new one is seen as more logical. There you indeed probing devices for supported functionality. But here you just register a new object with the system (note that

Re: [PATCH] Generic, platform independent matrix keyboard support

2007-10-09 Thread Dmitry Torokhov
Hi Pavel, On 10/9/07, Pavel Pisa [EMAIL PROTECTED] wrote: Subject: Generic, platform independent matrix keyboard support From: Pavel Pisa [EMAIL PROTECTED] The genmatrix_kbd module provides support for matrix keyboard where switches interconnects return lines with port driven scan lines.

Re: Handling transition into suspend through keyboard driver

2007-10-09 Thread Dmitry Torokhov
Hi Kristoffer, On 10/8/07, Kristoffer Ericson [EMAIL PROTECTED] wrote: Greetings, Dmitry, Im implementing suspend for hp7xx currently. I've added EV_PWR to bitflags and linked so POWER_KEY gets reported correctly. Is this the correct approach? Yes, it is. Keyboard drivers sghoudl just

Re: [PATCH try #2] Blackfin BF54x Input Keypad controller driver

2007-10-09 Thread Dmitry Torokhov
Hi Bryan, On 10/4/07, Bryan Wu [EMAIL PROTECTED] wrote: From: Michael Hennerich [EMAIL PROTECTED] Blackfin BF54x Input Keypad controller driver: [try #2] Changelog: - Coding style issue fixes - using a temp variable for bf54x_kpad-input - Other updates according to Dmitry's review I

Re: GeneralTouch USB Touchscreen Support

2007-10-08 Thread Dmitry Torokhov
Hi Ilya, On 10/8/07, if [EMAIL PROTECTED] wrote: Hello! Sending patch as told to. Formal notes: Patch made against 2.6.22.9 sources. Marketing is lying, quick google for model ( TL6B17S) shows they say it has 4096x4096 sensitivity, while device itself do not report more than 0x0470 (i set

Re: even newer version of USB HID autosuspend

2007-10-08 Thread Dmitry Torokhov
On 10/8/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Sonntag 07 Oktober 2007 schrieb Dmitry Torokhov: I'd say do not autosuspend keyboards (and other led-equipped input devices) unless user explicitely requested to do so and then turn the leds off. So your answer is that we shouldn't

Re: even newer version of USB HID autosuspend

2007-10-07 Thread Dmitry Torokhov
On Saturday 06 October 2007, Oliver Neukum wrote: This leaves me with a planning difficulty. For keyboards it is not fully transparent. The LEDs are switched off when then keyboard is suspended. Should I now implement a mode where active LEDs block suspension and if so, how do I

Re: [PATCH] input: move gameports out of SERIO menu

2007-10-02 Thread Dmitry Torokhov
Hi Randy, On Tuesday 02 October 2007, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Move the gameport support menu out of the SERIO menu and put it between touchscreens and misc. devices in the main input layer menu. Change it to use menuconfig instead of config. Or was it

Re: new version of usbhid autosuspend patch

2007-09-27 Thread Dmitry Torokhov
Hi Oliver, On 9/27/07, Oliver Neukum [EMAIL PROTECTED] wrote: +int hid_check_keys_pressed(struct hid_device *hid) +{ + struct hid_input *hidinput, *next; + int i; + + list_for_each_entry_safe(hidinput, next, hid-inputs, list) { + for (i = 0; i

Re: Problem with appletouch driver in Linux version 2.6.23-rc7

2007-09-26 Thread Dmitry Torokhov
On 9/26/07, Soeren Sonnenburg [EMAIL PROTECTED] wrote: On Mon, 2007-09-24 at 15:22 +0200, Thomas Rohwer wrote: Hello, could you please re-send the patch? I for some reason have yet to see it ... here it is again, adressing also the comments from Dmitry. Thomas, Matthew and

Re: [linux-usb-devel] detecting when keys are being pressed on a keyboard

2007-09-24 Thread Dmitry Torokhov
Hi Oliver, On 9/24/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Freitag 21 September 2007 schrieb Jiri Kosina: On Fri, 21 Sep 2007, Oliver Neukum wrote: I got the strange case of a keyboard going into autosuspend while a key was being pressed. The key release never arrived and I had

Re: [linux-usb-devel] detecting when keys are being pressed on a keyboard

2007-09-24 Thread Dmitry Torokhov
On 9/24/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Montag 24 September 2007 schrieb Dmitry Torokhov: Hi Oliver, On 9/24/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Freitag 21 September 2007 schrieb Jiri Kosina: Hi Oliver, HID doesn't keep any permanent state by itself

Re: Handling touchscreen buttons

2007-09-24 Thread Dmitry Torokhov
On Monday 24 September 2007, Kristoffer Ericson wrote: Greetings, On my jornada7xx I have 4 buttons on the rightside of the screen (going from Y-low - Y-high). They are part of the touchscreen. Since they aren't usually used in normal X window handling I was thinking that I should have

Re: [PATCH] xpad: fix Kconfig to avoid compile error

2007-09-19 Thread Dmitry Torokhov
On 9/19/07, Andreas Herrmann [EMAIL PROTECTED] wrote: On Tue, Sep 18, 2007 at 01:52:11PM -0400, Dmitry Torokhov wrote: To avoid this kernel configuration, do auto-select LEDS_CLASS for JOYSTCK_XPAD_LEDS. I'd rather it depend on LEDS_CLASS (but properly). I believe I posted a patch

Re: [HP7XX/PATCH] - HP720 Jornada Touchscreen (Updated, please use this one)

2007-09-19 Thread Dmitry Torokhov
On 9/20/07, Kristoffer Ericson [EMAIL PROTECTED] wrote: + if (jornada_ssp_inout(GETTOUCHSAMPLES == TXDUMMY)) { Are you sure? Looks like paren is pisplaced. + + ret = request_irq(IRQ_GPIO9, + jornada720_ts_interrupt, + IRQF_DISABLED |

Re: sysfs change of input/event devices in 2.6.23rc breaks udev

2007-09-10 Thread Dmitry Torokhov
On 9/10/07, Greg KH [EMAIL PROTECTED] wrote: On Mon, Sep 10, 2007 at 01:28:47AM -0400, Dmitry Torokhov wrote: On Sunday 09 September 2007 19:03, Kay Sievers wrote: On 9/8/07, Anssi Hannula [EMAIL PROTECTED] wrote: However, the change that broke id_path of udev is that /sys/class

Re: [2.6 patch] make the dummy touchkit_ps2_detect() static

2007-08-30 Thread Dmitry Torokhov
Hi Adrian, On Tuesday 14 August 2007 17:22, Adrian Bunk wrote: The dummy touchkit_ps2_detect() for the CONFIG_MOUSE_PS2_TOUCHKIT=n case shouldn't be a global function. Applied, thank you. Btw, sorry for the long silence - I had a hard drive crash and the day after I restored everything the

Re: [PATCH] Try harder to probe finicky rodents

2007-07-30 Thread Dmitry Torokhov
On Sunday 22 July 2007 13:24, Alon Ziv wrote: My rodent appears to be extra-finicky, and requires both a PSMOUSE_RESET_DIS and a PSMOUSE_RESET_BAT before it is unconfused enough to be probed. Signed-off-by: Alon Ziv [EMAIL PROTECTED] Applied, thank you. -- Dmitry

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-23 Thread Dmitry Torokhov
On Sunday 22 July 2007 08:51, Geert Uytterhoeven wrote: On Sun, 22 Jul 2007, Dmitry Torokhov wrote: On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote: On Fri, 20 Jul 2007, Dmitry Torokhov wrote: I am OK with adding a new header file. I was just saying that placing

Re: [PATCH][08/37] Clean up duplicate includes in drivers/input/

2007-07-23 Thread Dmitry Torokhov
On Saturday 21 July 2007 11:02, Jesper Juhl wrote: Hi, This patch cleans up duplicate includes in drivers/input/ Applied to for-linus branch of input tree, thank you. -- Dmitry

[RFC/RFT 5/5] Input: joydev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: joydev - implement proper locking Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/joydev.c | 745 - 1 files changed, 493 insertions(+), 252 deletions(-) Index: work/drivers/input/joydev.c

[RFC/RFT 2/5] evdev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: evdev - implement proper locking Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/evdev.c | 719 +- 1 files changed, 476 insertions(+), 243 deletions(-) Index: work/drivers/input/evdev.c

[RFC/RFT 4/5] Input: mousedev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: mousedev - implement proper locking Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/mousedev.c | 736 +-- 1 files changed, 464 insertions(+), 272 deletions(-) Index: work/drivers/input/mousedev.c

[RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Input: implement proper locking in input core Also add some kerneldoc documentation to input.h Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/input.c | 656 -- include/linux/input.h | 112 +++- 2 files changed, 585

Re: [RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Hi Jeff, On Tuesday 24 July 2007 01:35, Jeff Garzik wrote: spin_lock_irq() should generally be avoided. In cases like the first case -- input_repeat_key() -- you are making incorrect assumptions about the state of interrupts. The other cases are probably ok, but in general

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-21 Thread Dmitry Torokhov
Hi Geert, On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote: On Fri, 20 Jul 2007, Dmitry Torokhov wrote: I am OK with adding a new header file. I was just saying that placing that declaration in linux/hid.h makes about the same sense as putting it into linux/scsi.h At first I

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-21 Thread Dmitry Torokhov
: Kristoffer Ericson [EMAIL PROTECTED] Input: HP Jornada 7xx keyboard driver Signed-off-by: Kristoffer Ericson [EMAIL PROTECTED] Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/keyboard/Kconfig |7 + drivers/input/keyboard/Makefile |1 drivers/input

Re: [HP Jornada 6XX] - Onboard Keyboard support

2007-07-21 Thread Dmitry Torokhov
On Saturday 21 July 2007 21:15, Kristoffer Ericson wrote: Greetings, Here we go again with another keyboard patch (this time for hp6xx). It consists of three files, where one contains the generic scan_keyb routines with needed header and the third is the specific hp6xx driver. Please do not

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
Hi Geert, On 7/20/07, Geert Uytterhoeven [EMAIL PROTECTED] wrote: From: Geert Uytterhoeven [EMAIL PROTECTED] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible drivers/char/keyboard.c: In function 'kbd_keycode': drivers/char/keyboard.c:1142: error: implicit declaration of

Re: [PATCH] USB: driver for CM109 chipset

2007-07-20 Thread Dmitry Torokhov
On 7/12/07, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Thu, Jul 12, 2007 at 12:22:10PM -0400, Dmitry Torokhov wrote: Hmm, they use KEY_0 through KEY_9 now. Which results in the phone sending 'é+ěščřžýáí' instead of '0123456789' on a Czech keyboard, which is definitely not what's intended

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Dmitry Torokhov
Hi Kristoffer, On 7/18/07, Kristoffer Ericson [EMAIL PROTECTED] wrote: Try #2 Thanks for feedback, Ive tried a different approach to get it better handled. Thank you for making the changes I requested, however there is still an issue: + + ret = request_irq(IRQ_GPIO0, +

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Dmitry Torokhov
On 7/21/07, Kristoffer Ericson [EMAIL PROTECTED] wrote: Greetings, Ive added it to free IRQ as you said, a minor change is also that jornada720.h defines are set in CAPS (just changed that for Russell). Ive also added the Kconfig and Makefile. Btw, do you keep patchtracker (like Russell) or

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-19 Thread Dmitry Torokhov
On 7/19/07, federico ferri [EMAIL PROTECTED] wrote: Dmitry Torokhov ha scritto: # echo 84 183 | keyfuzz -s -d/dev/input/event1 EVIOCGKEYCODE: Invalid argument # echo 84 183 | keyfuzz -s -d/dev/input/event2 EVIOCGKEYCODE: Invalid argument # echo 0x05d 0x0b7 | keyfuzz -s -d/dev/input/event2

Re: [PATCH 2/3] leds-clevo-mail: hw accelerated LED blink extension

2007-07-17 Thread Dmitry Torokhov
On 7/17/07, Németh Márton [EMAIL PROTECTED] wrote: +Hardware accelerated blink of LEDs +== + +Some LEDs can be programmed to blink without any CPU interaction. To +support this feature, a LED driver can optionally implement the +blink_set() function (see

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-16 Thread Dmitry Torokhov
Hi Linus, On 7/15/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Mon, 16 Jul 2007, federico ferri wrote: Linus Torvalds ha scritto: Well, this is totally untested, and I won't guarantee that this works at all, but this is how to generally do these kinds of things.. YAY! it works

Re: Keyboard problem

2007-07-16 Thread Dmitry Torokhov
Hi Natalie, On 7/15/07, Natalie Protasevich [EMAIL PROTECTED] wrote: Hello, We have a problem with keybords here. It only hits several systems out of many, and really impossible to reproduce because it happens on different combinations of hardware/software and no one managed to find out what

Re: Force Feedback: Thrustmaster FGT Wheel quick-and-dirty in hid-lgff.c or hid-tmff.c

2007-07-16 Thread Dmitry Torokhov
On 7/16/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: OK, how about this then? Ignore it, it missing couple of bits; Anssi's is more complete I think. -- Dmitry

Re: Force Feedback: Thrustmaster FGT Wheel quick-and-dirty in hid-lgff.c or hid-tmff.c

2007-07-16 Thread Dmitry Torokhov
On 7/16/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 7/16/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: OK, how about this then? Ignore it, it missing couple of bits; Anssi's is more complete I think. Not quite what I wanted either, what about this one? -- Dmitry hid-add-thrustmaster

Re: [PATCH] Input: Support for a less exclusive grab.

2007-06-11 Thread Dmitry Torokhov
Hi Zephaniah, On Saturday 09 June 2007 04:48, Zephaniah E. Hull wrote: EVIOCGRAB is nice and very useful, however over time I've gotten multiple requests to make it possible for applications to get events straight from the event device while xf86-input-evdev is getting events from the same

Re: [PATCH] Input: Support for a less exclusive grab.

2007-06-11 Thread Dmitry Torokhov
On Tuesday 12 June 2007 01:12, Zephaniah E. Hull wrote: On Tue, Jun 12, 2007 at 01:07:13AM -0400, Dmitry Torokhov wrote: Hi Zephaniah, On Saturday 09 June 2007 04:48, Zephaniah E. Hull wrote: EVIOCGRAB is nice and very useful, however over time I've gotten multiple requests to make

Re: [PATCH] input: make 2 macros in gameport.c TSC-aware

2007-06-11 Thread Dmitry Torokhov
Hi, On Monday 11 June 2007 00:12, Miltiadis Margaronis wrote: This makes DELTA and GET_TIME in drivers/input/gameport/gameport.c similar to the ones in drivers/input/joystick/analog.c . Worked on 2.6.22-rc4-git2. I was told with the introduction of tickless kernels and such the best

Re: [PATCH] input: fix broken behaviour of Dell Latitude special keys

2007-06-11 Thread Dmitry Torokhov
Hi, On Sunday 10 June 2007 13:42, Giel de Nijs wrote: Hi, Following up on http://thread.gmane.org/gmane.linux.kernel.input/1375 here's a new patch to fix the fact that most Fn+F? special keys on (at least) the Dell Latitude laptops don't generate a key release event. Thank you for the

Re: [PATCH] Input: Support for a less exclusive grab.

2007-06-11 Thread Dmitry Torokhov
On Tuesday 12 June 2007 01:23, Zephaniah E. Hull wrote: On Tue, Jun 12, 2007 at 01:19:59AM -0400, Dmitry Torokhov wrote: Like I said I would love if xf86-input-evdev did not grab the device at all. We have to disable the legacy input handlers somehow, not doing so simply isn't

Re: [PATCH 1/1] gpio_mouse driver (rewritten to GIT kernel)

2007-06-01 Thread Dmitry Torokhov
microprocessor using the ATSTK1000 development board. Signed-off-by: Hans-Christian Egtvedt [EMAIL PROTECTED] Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/mouse/Kconfig | 17 +++ drivers/input/mouse/Makefile |1 drivers/input/mouse/gpio_mouse.c | 196

Re: Making KEY_UNKNOWN really useful to userland

2007-05-31 Thread Dmitry Torokhov
On 5/31/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Thu, 31 May 2007, Richard Hughes wrote: I am on it on the thinkpad-acpi side, so at least for that, you don't have to worry. I am still waiting an answer about which event is the correct one to output scancodes, but the

Re: [PATCH] Input: document the proper usage of EV_KEY and KEY_UNKNOWN

2007-05-31 Thread Dmitry Torokhov
On Thursday 31 May 2007 21:44, Matthew Garrett wrote: On Thu, May 31, 2007 at 10:29:28PM -0300, Henrique de Moraes Holschuh wrote: On Fri, 01 Jun 2007, Matthew Garrett wrote: Given existing userspace, it's never useful to generate KEY_UNKNOWN. Adding extra information to the event

Re: [PATCH 1/1] gpio_mouse driver

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Hans-Christian Egtvedt [EMAIL PROTECTED] wrote: On Tue, 2007-05-29 at 11:36 -0400, Dmitry Torokhov wrote: Hi, On 5/29/07, Hans-Christian Egtvedt [EMAIL PROTECTED] wrote: This patch adds support for simulating a mouse using GPIO lines. The driver needs a platform_data struct

Re: [PATCH] new driver for wireless xbox receiver for review

2007-05-30 Thread Dmitry Torokhov
Hi Brain, [Added Jan to CC list] On 5/29/07, Brian Magnuson [EMAIL PROTECTED] wrote: Hi Dimitri, Thanks for taking the time to review. My reponses are inline. -Brian * Dmitry Torokhov [EMAIL PROTECTED] [2007-05-29 20:03]: Thnk you for the patch. Looking at the code I do not see one

Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
On 5/29/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Mon, 28 May 2007, Dmitry Torokhov wrote: On Sunday 27 May 2007 08:15, Henrique de Moraes Holschuh wrote: On Sat, 26 May 2007, Dmitry Torokhov wrote: I am unconvinced that we need new keycodes. Isn't there a better default

Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
Hi Matthew, On 5/30/07, Matthew Garrett [EMAIL PROTECTED] wrote: On Wed, May 30, 2007 at 09:57:11AM -0400, Dmitry Torokhov wrote: I really don't like KEY_FN_F1..KEY_FN_BACKSPACE either. What are they supposed to do? Just being an unique value to be mapped onto something useful? But why

Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Matthew Garrett [EMAIL PROTECTED] wrote: On Wed, May 30, 2007 at 10:18:17AM -0400, Dmitry Torokhov wrote: Hi Matthew, We've already got KEY_PROG* - is this not the sort of situation they're for? (ie, keys that aren't mapped to a specific purpose but would be potentially useful

Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Wed, 30 May 2007, Dmitry Torokhov wrote: On 5/29/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: But I will still need to add keys, and I still think that a bunch of 32 or so HOSTSPECIFIC keys is a very very good

Re: [PATCH 1/1] gpio_mouse driver

2007-05-29 Thread Dmitry Torokhov
Hi, On 5/29/07, Hans-Christian Egtvedt [EMAIL PROTECTED] wrote: This patch adds support for simulating a mouse using GPIO lines. The driver needs a platform_data struct to be defined and registered with the appropriate platform_device. The driver has been tested on AT32AP7000 microprocessor

  1   2   >