Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-24 Thread Jiri Kosina
? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] HID: Delay opening HID device

2013-09-24 Thread Jiri Kosina
srinivas.pandruv...@linux.intel.com Signed-off-by: Jiri Kosina jkos...@suse.cz Jonathan, I'd be good if I pass this to you to apply the whole lot. Thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org

Re: [PATCH 0/3] Few cleanups

2013-09-24 Thread Jiri Kosina
come up with something that'd be substantially nicer. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid-elo: some systems cannot stomach work around

2013-09-24 Thread Jiri Kosina
*/ + case 0x4677: /*4820 51x Video*/ + case 0x4678: /*4820 2Lx Video*/ + case 0x4679: /*4820 5Lx Video*/ Here as well. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH v3 00/10] HID: validate report details

2013-09-13 Thread Jiri Kosina
On Wed, 11 Sep 2013, Benjamin Tissoires wrote: here is the v3 of the CVE fixes. Now applied, will be pushing to Linus for 3.12. Thanks everybody, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] update my generaltouch driver for linux by luosong

2013-09-09 Thread Jiri Kosina
the above and resubmit? Thanks a lot, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Input/HID: Guitar/Drums support

2013-09-04 Thread Jiri Kosina
On Mon, 26 Aug 2013, David Herrmann wrote: This series adds wiimote extension support for guitars and drums. Applied, thanks! -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] HID: Correct the USB IDs for the new Macbook Air 6

2013-09-04 Thread Jiri Kosina
. Will push it to Linus this merge window. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid: uhid: improve uhid example client

2013-09-04 Thread Jiri Kosina
:) ), but it contains a load of pre-defined example descriptors for various devices. No intention to modify it. Looks all good to me now. Now applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org

Re: [PATCH] hid-wiimote: print small buffers via %*ph

2013-09-04 Thread Jiri Kosina
On Tue, 3 Sep 2013, Andy Shevchenko wrote: Instead of passing each byte through stack let's use %*ph specifier to dump buffer as a hex string. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] hid-wiimote: print small buffers via %*ph

2013-09-04 Thread Jiri Kosina
On Wed, 4 Sep 2013, Jiri Kosina wrote: Instead of passing each byte through stack let's use %*ph specifier to dump buffer as a hex string. Applied, thanks. I acutally applied the phC one, but replied to wrong thread, sorry for the noise. -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH 11/14] HID: multitouch: validate feature report details

2013-09-04 Thread Jiri Kosina
to have the patchset polished before pushing it to Linus. Therefore putting the rest on hold now, and waiting for v2. Thanks a lot to both of you, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org

Re: [PATCH 06/14] HID: pantherlord: validate output report details

2013-09-04 Thread Jiri Kosina
On Wed, 28 Aug 2013, Jiri Kosina wrote: From: Kees Cook keesc...@chromium.org A HID device could send a malicious output report that would cause the pantherlord HID driver to write beyond the output report allocation during initialization, causing a heap overflow: [ 310.939483] usb 1-1

Re: [PATCH 10/14] HID: ntrig: validate feature report details

2013-09-04 Thread Jiri Kosina
On Thu, 29 Aug 2013, Rafi Rubin wrote: Signed-off-by: Rafi Rubin r...@seas.upenn.edu Applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 13/14] HID: picolcd_core: validate output report details

2013-09-04 Thread Jiri Kosina
On Sat, 31 Aug 2013, Bruno Prémont wrote: Hi Kees, Jiri, On Wed, 28 August 2013 Jiri Kosina jkos...@suse.cz wrote: From: Kees Cook keesc...@chromium.org A HID device could send a malicious output report that would cause the picolcd HID driver to trigger a NULL dereference during attr

Re: [PATCH 14/14] HID: check for NULL field when setting values

2013-09-04 Thread Jiri Kosina
On Wed, 28 Aug 2013, Jiri Kosina wrote: From: Kees Cook keesc...@chromium.org Defensively check that the field to be worked on is not NULL. Applied. Signed-off-by: Kees Cook keesc...@chromium.org Cc: sta...@kernel.org --- drivers/hid/hid-core.c |7 ++- 1 file changed, 6

Re: [PATCH 01/14] HID: validate HID report id size

2013-09-04 Thread Jiri Kosina
quite some valuable feedback. Thanks again, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] hid-sensor-hub: fix indentation accross the code

2013-09-04 Thread Jiri Kosina
. There is no functional change. Jiri, anything about this patch and the rest of the series? It seems you applied only patch 1/4. Do you have comments? The whole series is now applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH] i2c-hid: explicitly cast parametrs to follow specifiers

2013-09-04 Thread Jiri Kosina
); ret = hid_add_device(hid); if (ret) { -- 1.8.3.1 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/14] HID: sensor-hub: validate feature report details

2013-09-04 Thread Jiri Kosina
=for-3.12/upstreamid=9e8910257397372633e74b333ef891f20c800ee4 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: Correct the USB IDs for the new Macbook Air 6

2013-09-02 Thread Jiri Kosina
this change has been sufficiently tested now, in addition to making perfect sense. Jiri, would you mind taking it, if Dmitry approves? Absolutely ... waiting for Dmitry's Ack. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH] HID: uhid: add devname module alias

2013-09-02 Thread Jiri Kosina
On Sun, 1 Sep 2013, David Herrmann wrote: For simple device node creation, add the devname module alias. Yepp, looks good. uinput already has it, so: Reviewed-by: David Herrmann dh.herrm...@gmail.com Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: HID: picolcd: Prevent NULL pointer dereference on _remove()

2013-09-02 Thread Jiri Kosina
-picolcd_fb.c | 6 +- 2 files changed, 7 insertions(+), 2 deletions(-) Applied, thanks Bruno. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2] HID: usbhid: quirk for N-Trig DuoSense Touch Screen

2013-09-02 Thread Jiri Kosina
and applied, but please keep that in mind for your future submissions. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: roccat: Added support for KonePureOptical v2

2013-09-02 Thread Jiri Kosina
On Fri, 30 Aug 2013, Stefan Achatz wrote: KonePureOptical is a KonePure with different sensor. Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH 1/3] Input: introduce BTN/ABS bits for drums and guitars

2013-09-02 Thread Jiri Kosina
) */ + +#define ABS_MAX 0x4f #define ABS_CNT (ABS_MAX+1) /* -- 1.8.4 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 4/6] si4713 : HID blacklist Si4713 USB development board

2013-08-30 Thread Jiri Kosina
descriptor. This patch ignores this device as an HID device and hence loads the custom driver. Signed-off-by: Dinesh Ram din...@cisco.com Signed-off-by: Jiri Kosina jkos...@suse.cz Please feel free to take it together with my sigoff with the rest of the series. -- Jiri Kosina SUSE Labs

Re: [PATCH 01/14] HID: validate HID report id size

2013-08-29 Thread Jiri Kosina
On Wed, 28 Aug 2013, Jiri Kosina wrote: From: Kees Cook keesc...@chromium.org The Report ID field of a HID report is used to build indexes of reports. The kernel's index of these is limited to 256 entries, so any malicious device that sets a Report ID greater than 255 will trigger memory

Re: [PATCH 01/14] HID: validate HID report id size

2013-08-29 Thread Jiri Kosina
, with a specially crafted device, you can end up with item-size 1 coming out from fetch_item() for report ID, no? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH 02/14] HID: provide a helper for validating hid reports

2013-08-28 Thread Jiri Kosina
hid_device *device); int hid_check_keys_pressed(struct hid_device *hid); int hid_connect(struct hid_device *hid, unsigned int connect_mask); -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More

[PATCH 04/14] HID: sony: validate HID output report details

2013-08-28 Thread Jiri Kosina
); -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 03/14] HID: zeroplus: validate output report details

2013-08-28 Thread Jiri Kosina
hid_report, list); - - if (report-maxfield 4) { - hid_err(hid, not enough fields in report\n); - return -ENODEV; - } zpff = kzalloc(sizeof(struct zpff_device), GFP_KERNEL); if (!zpff) -- Jiri Kosina SUSE Labs -- To unsubscribe from this list

[PATCH 01/14] HID: validate HID report id size

2013-08-28 Thread Jiri Kosina
hid_report *report_id_hash[256]; + struct hid_report *report_id_hash[HID_MAX_IDS]; }; #define HID_REPORT_TYPES 3 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH 05/14] HID: steelseries: validate output report details

2013-08-28 Thread Jiri Kosina
, HID_OUTPUT_REPORT, 0, 1, 16)) { + ret = -ENODEV; + goto err_free; + } + ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT); if (ret) { hid_err(hdev, hw start failed\n); -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

[PATCH 10/14] HID: ntrig: validate feature report details

2013-08-28 Thread Jiri Kosina
[HID_FEATURE_REPORT]. report_id_hash[0x0d]; - if (!report) + if (!report || report-maxfield 1 || + report-field[0]-report_count 1) return -EINVAL; hid_hw_request(hdev, report, HID_REQ_GET_REPORT); -- Jiri Kosina SUSE Labs

[PATCH 06/14] HID: pantherlord: validate output report details

2013-08-28 Thread Jiri Kosina
]-report_count = 1 + report-field[3]-report_count = 1) { report-field[0]-value[0] = 0x00; report-field[1]-value[0] = 0x00; strong = report-field[2]-value[0]; -- Jiri Kosina SUSE Labs -- To unsubscribe

[PATCH 07/14] HID: LG: validate HID output report details

2013-08-28 Thread Jiri Kosina
].idVendor -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 08/14] HID: lenovo-tpkbd: validate output report details

2013-08-28 Thread Jiri Kosina
)) { hid_warn(hdev, Could not create sysfs group\n); -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 09/14] HID: logitech-dj: validate output report details

2013-08-28 Thread Jiri Kosina
to upper interfaces hiddev and * hidraw */ retval = hid_hw_start(hdev, HID_CONNECT_DEFAULT); -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH 12/14] HID: sensor-hub: validate feature report details

2013-08-28 Thread Jiri Kosina
-maxfield) || + report-field[field_index]-report_count 1) { ret = -EINVAL; goto done_proc; } -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More

[PATCH 13/14] HID: picolcd_core: validate output report details

2013-08-28 Thread Jiri Kosina
picolcd_operation_mode_store(struct device *dev, buf += 10; cnt -= 10; } - if (!report) + if (!report || report-maxfield 1) return -EINVAL; while (cnt 0 (buf[cnt-1] == '\n' || buf[cnt-1] == '\r')) -- Jiri Kosina SUSE Labs

Re: [PATCH v3 0/3] HID: Win 8 multitouch panels detection in core

2013-08-27 Thread Jiri Kosina
. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] HID: use module_hid_driver() to simplify the code

2013-08-26 Thread Jiri Kosina
, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 0/3] HID: Win 8 multitouch panels detection in core

2013-08-26 Thread Jiri Kosina
for Henrik to put his Reviewed-by before giving one last test. Here goes: Reviewed-by: Henrik Rydberg rydb...@euromail.se Thanks guys. Not applying this just yet, waiting for Tested-by: from Srinivas. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH v1 23/49] hid: usbhid: prepare for enabling irq in complete()

2013-08-26 Thread Jiri Kosina
On Sun, 18 Aug 2013, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Jiri Kosina jkos...@suse.cz Cc: linux-input@vger.kernel.org Signed-off-by: Ming Lei ming@canonical.com Acked-by: Jiri Kosina jkos...@suse.cz --- drivers/hid

Re: [PATCH 1/4] hid-sensor-hub: fix style of comments

2013-08-26 Thread Jiri Kosina
: (200083) */ #define HID_USAGE_SENSOR_COMPASS_3D 0x200083 #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING 0x200471 #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING_X 0x200472 -- 1.8.4.rc2 -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH] hid: Fix Speedlink VAD Cezanne support for some devices

2013-08-26 Thread Jiri Kosina
On Sun, 25 Aug 2013, Stefan Kriwanek wrote: Some devices of the Speedlink VAD Cezanne model need more aggressive fixing than already done. Applied, thanks Stefan. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH 1/1] HID: hidraw: Add spinlock in struct hidraw to protect list

2013-08-26 Thread Jiri Kosina
, which collides with your patch. Could you please check what changes are needed on top of it so that it makes sense for my 'for-next' branch, rebase, and resend to me? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH 1/1] HID: hidraw: Add spinlock in struct hidraw to protect list

2013-08-26 Thread Jiri Kosina
hidraw_report_event to touch a deleted list struct and panic. To prevent this, introduce a spinlock in struct hidraw to protect list from concurrent access. Signed-off-by: Yonghua Zheng younghua.zh...@gmail.com Applied now, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list

Re: [PATCH v2 1/2] input: document gamepad API and add extra keycodes

2013-08-20 Thread Jiri Kosina
horribly failed in this case, sorry for that. Now queued, thanks a lot for noticing. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set

2013-08-09 Thread Jiri Kosina
to put me down as a Tested-By. Okay, this is now queued, and I will be pushing it to Linus. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: List corruption in hidraw_release in 3.11-rc4

2013-08-07 Thread Jiri Kosina
(stderr, Usage: %s /dev/hidrawN usbN\n, *argv); return 1; } system(modprobe -v usbhid); system(modprobe -v hid-logitech-dj); dork(argv[1], argv[2]); return 0; } -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: List corruption in hidraw_release in 3.11-rc4

2013-08-06 Thread Jiri Kosina
); init_waitqueue_head(dev-wait); INIT_LIST_HEAD(dev-list); @@ -528,6 +527,7 @@ int hidraw_connect(struct hid_device *hid) dev-exist = 1; hid-hidraw = dev; + mutex_unlock(minors_lock); out: return result; -- Jiri Kosina SUSE Labs -- To unsubscribe from this list

Re: [PATCH 1/2] i2c-hid: don't push static constants on stack for %*ph

2013-08-05 Thread Jiri Kosina
benjamin.tissoi...@redhat.com Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid-holtekff: don't push static constants on stack for %*ph

2013-08-05 Thread Jiri Kosina
[i]; } - dbg_hid(sending %*ph\n, 7, data); + dbg_hid(sending %7ph\n, data); hid_hw_request(hid, holtekff-field-report, HID_REQ_SET_REPORT); Applied, thanks Andy. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH] HID: wiimote: work around broken DRM_KAI on GEN10

2013-08-05 Thread Jiri Kosina
-- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid: add driver for IBM/Lenovo ScrollPoint mice

2013-08-05 Thread Jiri Kosina
) +{ + hid_unregister_driver(scrollpoint_driver); +} + +module_init(scrollpoint_init); +module_exit(scrollpoint_exit); + +MODULE_AUTHOR(Peter De Wachter); +MODULE_DESCRIPTION(IBM/Lenovo ScrollPoint mouse driver); +MODULE_LICENSE(GPL); -- 1.8.3.2 -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set

2013-08-05 Thread Jiri Kosina
is not completely clear to me. To be more specific -- when exactly do we receive -EPIPE, why do we receive it and why do we not handle it properly? Thanks again, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [RFC 2/8] HID: usbhid: update LED fields unlocked

2013-07-31 Thread Jiri Kosina
, thanks Benjamin. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC 3/8] HID: input: generic hidinput_input_event handler

2013-07-31 Thread Jiri Kosina
. But I actually don't care, so I can change to normal CodingStyle. I once got grilled by Dave for submitting patch to netdev with such comment, but that didn't change my opinion, and I don't care for my subsystem :) -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [RFC 0/8] HID: Transport Driver Cleanup

2013-07-31 Thread Jiri Kosina
, brainfart on my side as well. You are right. I am now pulling 3/8 into the tree as well and pushing it out. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] HID: i2c-hid: add DT bindings

2013-07-31 Thread Jiri Kosina
this up. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH linux-next] hid/logitech-dj: Fix non-atomic kmalloc in logi_dj_ll_input_event()

2013-07-31 Thread Jiri Kosina
On Wed, 31 Jul 2013, Peter Hurley wrote: The ll_driver's .hidinput_input_event() method is called from atomic context [1]. Use GFP_ATOMIC for allocation of the synthesized hid report. Signed-off-by: Peter Hurley pe...@hurleysoftware.com Applied, thanks Peter. -- Jiri Kosina SUSE Labs

Re: [PATCH] hidraw: fix unproper mutex release

2013-07-30 Thread Jiri Kosina
to have it pushed to Linus for 3.11 still. However you patch is missing Signed-off-by: line, as documented in Documentation/SubmittingPatches. Could you please provide that, so that I can apply your patch? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] hid: Add new driver for non-compliant Xin-Mo devices.

2013-07-29 Thread Jiri Kosina
announces -1). It is needed because hid-input discards out of bounds values. Applied, thanks Olivier. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3.11-rc2] HID: sony: fix HID mapping for PS3 sixaxis controller

2013-07-24 Thread Jiri Kosina
, making it useless. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Hi Jiri, I have since yesterday a Sixaxis controller on my desk, and I noticed that it was broken in v3.11. Good catch, applied, thanks Benjamin. -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH] hid: replace strict_strtoul() with kstrtoul()

2013-07-23 Thread Jiri Kosina
On Fri, 19 Jul 2013, Jingoo Han wrote: The usage of strict_strtoul() is not preferred, because strict_strtoul() is obsolete. Thus, kstrtoul() should be used. Signed-off-by: Jingoo Han jg1@samsung.com Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH 1/2] Revert Revert HID: Fix logitech-dj: missing Unifying device issue

2013-07-22 Thread Jiri Kosina
, but not a complete one. Linus claims to have similar problem, but his receiver is not connected through xHCI (I got this as an off-list report, so can't really provide a pointer to ML archives). Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH 1/2] Revert Revert HID: Fix logitech-dj: missing Unifying device issue

2013-07-22 Thread Jiri Kosina
here, or not. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: kye: Add report fixup for Genius Gx Imperator Keyboard

2013-07-14 Thread Jiri Kosina
of hid_have_special_driver[] list? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: logitech-dj: use inlined helpers hid_hw_open/close

2013-07-12 Thread Jiri Kosina
On Fri, 12 Jul 2013, Benjamin Tissoires wrote: Use the inlined helpers hid_hw_open/close instead of direct calls to -ll_driver-open() and -ll_driver-close(). Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH 1/2] Bluetooth: hidp: implement hidinput_input_event callback

2013-07-11 Thread Jiri Kosina
...@redhat.com Acked-by: Jiri Kosina jkos...@suse.cz --- net/bluetooth/hidp/core.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index f13a8da..9c8b50d 100644 --- a/net/bluetooth/hidp/core.c +++ b/net

Re: [PATCH 2/2] Bluetooth: hidp: remove wrong send_report at init

2013-07-11 Thread Jiri Kosina
-by: Jiri Kosina jkos...@suse.cz Gustavo, could you please take it through your tree? Thanks Benjamin, thanks David. --- net/bluetooth/hidp/core.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index 9c8b50d..59d132a

Re: [PATCH] HID: fix data access in implement()

2013-07-10 Thread Jiri Kosina
() helper. Signed-off-by: Jiri Kosina jkos...@suse.cz --- Thanks for that. It should (I hope) fix the bugs we are seeing from time to times under Fedora and that I was not able to answer: https://bugzilla.redhat.com/show_bug.cgi?id=965280 https://bugzilla.redhat.com/show_bug.cgi?id=927488

[PATCH v2] HID: fix data access in implement()

2013-07-10 Thread Jiri Kosina
sure that the buffer is always of a proper size. Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Acked-by: Gustavo Padovan gustavo.pado...@collabora.co.uk Signed-off-by: Jiri Kosina jkos...@suse.cz --- drivers/hid/hid-core.c| 19 ++- drivers/hid/hid

[PATCH] HID: fix data access in implement()

2013-07-09 Thread Jiri Kosina
math operations happening in implement() and extract(). All callers of hid_output_report() are converted at the same time to allocate the buffer by newly introduced hid_alloc_report_buf() helper. Signed-off-by: Jiri Kosina jkos...@suse.cz --- drivers/hid/hid-core.c| 19

Re: Logitech M705: Thumb button (was Re: [PATCH v4] HID: Add full support for Logitech Unifying receivers)

2013-07-09 Thread Jiri Kosina
provided by uLogitech in the kernel? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: My logitech wireless keyboard and mouse stop working after 3.10 kernel

2013-07-07 Thread Jiri Kosina
: REL=40 B: ABS=1 B: MSC=10 B: LED=1f Please let me know if you need more debug info. Thanks. Best, Wujun Zhou -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] HID: kye: Add report fixup for Genius Gila Gaming mouse

2013-07-03 Thread Jiri Kosina
. This one is really easy enough to go into even post -rc1 :) Now applied for the Linus merge I am going to do shortly. Thanks a lot, Benjamin. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org

Re: [PATCH] hid: wacom: Intuos4 battery charging changes

2013-07-01 Thread Jiri Kosina
been connected, but it's not in use - the battery/ac status will be incorrect. Currently there is no mechanism to ask the device to send a report containing battery/ac status. Signed-off-by: Przemo Firszt prz...@firszt.eu Applied, thanks Przemo. -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH v2 1/2] input: document gamepad API and add extra keycodes

2013-06-27 Thread Jiri Kosina
, will do that modification. Otherwise: Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com Thanks Dmitry. Will be taking it (with the above modification) through my tree. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Logitech M705: Thumb button (was Re: [PATCH v4] HID: Add full support for Logitech Unifying receivers)

2013-06-27 Thread Jiri Kosina
thumb button. Question mostly to the Logitech guys: Nestor, Olivier, could you please provide us with the sequence that needs to be sent to (certain revisisons of) M705 to let enter the debug mode, making the thumb button actually emit a USB message? Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v2 1/2] input: document gamepad API and add extra keycodes

2013-06-26 Thread Jiri Kosina
On Wed, 19 Jun 2013, Jiri Kosina wrote: On Sat, 15 Jun 2013, David Herrmann wrote: Until today all gamepad input drivers report their data differently. It is nearly impossible to write applications for more than one device in a generic way. Therefore, this patch introduces a uniform

Re: Posiflex 0d3a:a000 touchscreen press not recognized in kernel 3.9.4

2013-06-19 Thread Jiri Kosina
a check on min max solves the problem. Reported-by: Jan Kandziora j...@gmx.de Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Thanks. I am applying this with Jan's Tested-by: (and I am also extending the comnent preceeding the condition to better explain this case). -- Jiri

Re: [PATCH v2 1/2] input: document gamepad API and add extra keycodes

2013-06-18 Thread Jiri Kosina
BTN_TRIGGER_HAPPY0x2c0 #define BTN_TRIGGER_HAPPY1 0x2c0 #define BTN_TRIGGER_HAPPY2 0x2c1 -- 1.8.3.1 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] HID: multitouch: prevent memleak with the allocated name

2013-06-12 Thread Jiri Kosina
, that will require much more throgough review of interaction with input subsystem, so definitely not a late -rc regression fix material. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org

Re: [PATCH 01/26] HID: wiimote: extend driver description

2013-06-03 Thread Jiri Kosina
reached conclusion with Todd on this one or not 2) [RFC 26/26] HID/ALSA: wiimote: add speaker support - It'd be nice to get Ack from sound people on this one. Thanks a lot, David. Good work. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux

Re: Fwd: Re: Fwd: Re: [PATCH] HID: hid-sensor-hub: do not process feature reports in raw_event

2013-06-03 Thread Jiri Kosina
On Wed, 29 May 2013, Srinivas Pandruvada wrote: Daniel has tested and confirmed that this patch fixes issue. Thanks for confirmation. I have now applied the patch. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH] HID: hyperv: Cocci spatch memdup.spatch

2013-06-03 Thread Jiri Kosina
and missing changelog :) I have fixed this for the hyperv patch and applied it, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH -next] HID: holtek-mouse: use module_hid_driver() to simplify the code

2013-05-29 Thread Jiri Kosina
(holtek_mouse_exit); -module_init(holtek_mouse_init); +module_hid_driver(holtek_mouse_driver); MODULE_LICENSE(GPL); Added Reported-by: Andy Shevchenko andy.shevche...@gmail.com and applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH] Bluetooth: hidp: register HID devices async

2013-05-29 Thread Jiri Kosina
On Tue, 28 May 2013, Gustavo Padovan wrote: Signed-off-by: David Herrmann dh.herrm...@gmail.com Acked-by: Jiri Kosina jkos...@suse.cz Gustavo, I think I'd like to take this patch together with the ENODATA change for hid-input, as they, in some sense, stick together. If you

Re: [PATCH] HID: input: return ENODATA if reading battery attrs fails

2013-05-29 Thread Jiri Kosina
On Fri, 24 May 2013, David Herrmann wrote: So I hope we can apply this for linux-next (probably after gustavo applied the HIDP fix)? Applied to my tree, together with the hidp fix. Thanks David, thanks Daniel! -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH] HID: hid-sensor-hub: do not process feature reports in raw_event

2013-05-29 Thread Jiri Kosina
(hid, report)) { ret = hdrv-raw_event(hid, report, data, size); - if (ret != 0) { + if (ret 0) { ret = ret 0 ? ret : 0; goto unlock; } -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH] hid: driver for PS2/3 Buzz controllers

2013-05-28 Thread Jiri Kosina
On Mon, 27 May 2013, Colin Leitner wrote: This patch adds support for PS2/3 Buzz controllers into hid-sony Thanks, now applied. As a followup, I think I'll merge hid-ps3remote into hid-sony as well. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] HID: add support for Huion 580 tablet

2013-05-28 Thread Jiri Kosina
necessary to make it work (the deviations from the HID standard) Thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Bluetooth: hidp: register HID devices async

2013-05-28 Thread Jiri Kosina
synchronously as we did before. Only HID devices are registered asynchronously. Signed-off-by: David Herrmann dh.herrm...@gmail.com Acked-by: Jiri Kosina jkos...@suse.cz Gustavo, I think I'd like to take this patch together with the ENODATA change for hid-input, as they, in some sense, stick

Re: [PATCH 0/2] Holtek gaming mouse driver, and the necessity for it instead of increasing HID_MAX_USAGES

2013-05-28 Thread Jiri Kosina
and could have been fixed by patching the report descriptor in order to reflect the real behavior of the device Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/2] HID: Add driver for Holtek gaming mouse 04d9:a067

2013-05-28 Thread Jiri Kosina
You also need an entry in hid_have_special_driver[] for the devices in order for the device - driver binding work properly. I have applied your patches and fixed that omission. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH] HID: fold ps3remote driver into generic Sony driver

2013-05-28 Thread Jiri Kosina
On Tue, 28 May 2013, David Dillow wrote: Let's follow the structure we are trying to keep for most of the specific HID drivers, and let the separation follow the producing vendor. Merge functionality provided by ps3remote driver into hid-sony. Signed-off-by: Jiri Kosina jkos

Re: [PATCH] hid: driver for PS2/3 Buzz controllers

2013-05-27 Thread Jiri Kosina
test the wireless version, but what can be gathered on information from the net, both should be identical in their report structure. Signed-off-by: Colin Leitner colin.leit...@gmail.com Cc: Jiri Kosina jkos...@suse.cz Cc: linux-input@vger.kernel.org Cc: linux-ker...@vger.kernel.org

<    2   3   4   5   6   7   8   9   10   >