Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Richard Knutsson [EMAIL PROTECTED] wrote: Milind Choudhary wrote: On 2/23/07, Richard Knutsson [EMAIL PROTECTED] wrote: +#define BITWRAP(nr)(1UL ((nr) % BITS_PER_LONG)) make the whole input subsystem use it The change is huge, more than 125 files using input.h

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Richard Knutsson [EMAIL PROTECTED] wrote: Dmitry Torokhov wrote: Hm, I thought as was clear, but apparently I messed up explaining my position: 1. I don't like BITWRAP name at all and I don't want anything like that near input code. I think BIT is just fine. Oh, I think I

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-24 Thread Dmitry Torokhov
On Saturday 24 February 2007 07:59, Richard Knutsson wrote: Vojtech Pavlik wrote: On Fri, Feb 23, 2007 at 11:43:44PM +0100, Richard Knutsson wrote: Is the reason for the modulo to put a bitmask larger then the variable into an array? The complementary LONG() macro will

Re: Fix locking in mousedev

2007-03-09 Thread Dmitry Torokhov
Hi Pete, On 2/28/07, Pete Zaitcev [EMAIL PROTECTED] wrote: If a process is closing /dev/input/mice and an mouse disconnects simulta- neously, the system is likely to oops. This usually happens when someone hits AltCtrlF1 or logs out from X, and flips a KVM while the system is reacting. I

Re: FF layer restrictions [Was: [PATCH 1/1] Input: add sensable phantom driver]

2007-03-14 Thread Dmitry Torokhov
On 3/13/07, Jiri Slaby [EMAIL PROTECTED] wrote: Why did you remove all Cced people? Anyway I filtered some of them out johann deneux napsal(a): You are right, the direction in ff_effect is meant to be an angle. A dirty solution would be to use the 16 bits as two 8-bits angles. Or That would

Re: [PATCH 0/2] wistron_btns: More keymaps

2007-03-14 Thread Dmitry Torokhov
On 3/14/07, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote: Hi Eric, On 3/13/07, Eric Piel [EMAIL PROTECTED] wrote: Hello, As a sequel to my patch Wistron button support for TravelMate 610 of last week, here is a bigger addition

Re: [PATCH] iforce: Use usb_kill_urb instead of usb_unlink_urb.

2007-03-19 Thread Dmitry Torokhov
Hi Johann, On Saturday 17 March 2007 17:43, johann deneux wrote: commit 0ba8785483c2ee7f56e8f242e000f6cd17a7da40 Author: Johann Deneux [EMAIL PROTECTED] Date: Sat Mar 17 22:23:44 2007 +0100 I tried applying your patch but it appears that your mailer mangled it. Could you please resend it?

Re: Fix sudden warps in mousedev

2007-03-27 Thread Dmitry Torokhov
On 3/27/07, Chuck Ebbert [EMAIL PROTECTED] wrote: Dmitry Torokhov wrote: And why did the mouse numbers all get rearranged in 2.6.20, e.g. mouse1 became mouse2 for many people? Input devices are not guaranteed to be stable. So people with z-axis mice need to redo their X config for each

Re: appletouch quirk doesn't run at resume

2007-03-28 Thread Dmitry Torokhov
On 3/28/07, Jiri Kosina [EMAIL PROTECTED] wrote: On Tue, 27 Mar 2007, Thomas Meyer wrote: It seems, that after the resume all usb devices gets removed and plug in again (virtually!). This results in a new input device name: Yes, this is what actually happens. JFYI see current thread on lkml

Re: FF layer restrictions [Was: [PATCH 1/1] Input: add sensable phantom driver]

2007-03-30 Thread Dmitry Torokhov
On 3/28/07, Jiri Slaby [EMAIL PROTECTED] wrote: Jiri Slaby napsal(a): Dmitry Torokhov napsal(a): On Tuesday 27 March 2007 17:34, johann deneux wrote: What about adding a member to ff_effect which would be the number of the motor? We can't change the layout of ff_effect too much though, so

Re: [PATCH] Make ati_remote button repeat sensitivity soft-configurable

2007-04-03 Thread Dmitry Torokhov
Hi Karl, On Tuesday 03 April 2007 20:34, Karl Pickett wrote: The ati_remote driver is a little too sensitive for my wife... if you do anything but barely tap the button you can get multiple events reported.  We prefer a more conservative no-repeat setting.  This is a pretty trivial patch

Re: linux-2.6.20.4-ck1 / evdev / hub crash

2007-04-03 Thread Dmitry Torokhov
On Thursday 29 March 2007 04:56, Jiri Kosina wrote: On Wed, 28 Mar 2007, Avuton Olrich wrote: I've been having problems lately with my mouse, and I know that the kernel is tainted. If that's a problem please just ignore this dump. I just restarted my computer with a ck[1] kernel, which I

Re: linux-2.6.20.4-ck1 / evdev / hub crash

2007-04-03 Thread Dmitry Torokhov
On Tuesday 03 April 2007 23:10, Avuton Olrich wrote: On 4/3/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: Could you please try 2.6.21-rc5-mm4? It has evdev locking patch that I believe should fix these kind of oopses. I'd have no problem testing it, but since that oops, it hasn't

Re: Getting touchscreen to work on Fujitsu B6210

2007-04-03 Thread Dmitry Torokhov
-series laptops. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/touchscreen/Kconfig | 17 ++ drivers/input/touchscreen/Makefile | 15 +- drivers/input/touchscreen/fujitsu_ts.c | 191 + 3 files changed, 214 insertions(+), 9 deletions

[PATCH] usbkbd/usbmouse - handle errors when registering devices

2007-04-03 Thread Dmitry Torokhov
Jiri, I have been sitting on this patch for some time, now you can have it ;) -- Dmitry Input: usbkbd/usbmouse - handle errors when registering input devices Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/usb/input/usbkbd.c | 11 +++ drivers/usb/input/usbmouse.c

Re: Getting touchscreen to work on Fujitsu B6210

2007-04-05 Thread Dmitry Torokhov
On 4/5/07, Stephen Hemminger [EMAIL PROTECTED] wrote: Here is a cleaned up version of the patch that at least builds Ahem, that will teach me to do quilt refersh before sending off patches... Still, more important question - does it work? -- Dmitry

Re: [PATCH] Make ati_remote button repeat sensitivity soft-configurable (V2)

2007-04-09 Thread Dmitry Torokhov
On Thursday 05 April 2007 10:23, Karl Pickett wrote: Dmitry, please use this instead of my previous patch.  Thanks to Vincent for the code review , fixes, and testing. Applied to the input tree; thank you Karl and Vincent. -- Dmitry

Re: Logitech Spring FF

2007-04-10 Thread Dmitry Torokhov
On Tuesday 10 April 2007 01:45, Richard Bolkey wrote: First off, I've never made a patch before, which I guess I better learn, but for now if anyone wants to add the device_type for the Logitech Force 3D Pro Joystick to hid-lgff.c, it's { 0x046d, 0xc286, ff_joystick }. That would be Jiri

Re: [PATCH] gpio_keys ev_sw support

2007-04-13 Thread Dmitry Torokhov
Hi Paul, On 4/13/07, Paul Sokolovsky [EMAIL PROTECTED] wrote: Hello Dmitry, I wonder if you're satisfied with Roman patch now. I guess it could just fall to the bottom of your queue due to bad formatting. So, here's resend, hopefully correct. One change is that we had to put type

Re: [PATCH] Add Cobalt button interface driver support

2007-04-24 Thread Dmitry Torokhov
Hi Yoichi, On Thursday 05 April 2007 01:02, Yoichi Yuasa wrote: Hi Dmitry, On Wed, 4 Apr 2007 00:01:41 -0400 Dmitry Torokhov [EMAIL PROTECTED] wrote: Hi Yoichi, Could you please try the patch below? It moves platform device creation code into cobalt arch code to belletr follow

Re: [PATCH] Add Cobalt button interface driver support

2007-04-26 Thread Dmitry Torokhov
On 4/26/07, Yoichi Yuasa [EMAIL PROTECTED] wrote: Dmitry Torokhov [EMAIL PROTECTED] wrote: Coudl you please try couple more patches, please? I wrote a generic stub for polled (as opposed to interrupt-driven) input devices and converting existing drivers to use it. Cobalt buttons seem

Re: [RFC 1/2] Input: ff, add FF_RAW effect

2007-04-26 Thread Dmitry Torokhov
Hi Jiri, On 4/23/07, Jiri Slaby [EMAIL PROTECTED] wrote: Dmitry Torokhov napsal(a): For devices that require tailored application (for example that glove - I am not sure how a generic application could control it) old phantom way of controlling via ioctl will suffice. The device may still

Re: [RFC 1/2] Input: ff, add FF_RAW effect

2007-04-26 Thread Dmitry Torokhov
On 4/22/07, Jiri Slaby [EMAIL PROTECTED] wrote: On 4/19/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 4/19/07, Jiri Slaby [EMAIL PROTECTED] wrote: Dmitry Torokhov napsal(a): If we are interested in using FF API we need to come up with a way to express this effect without exposing

Re: bug in evdev_disconnect

2007-04-27 Thread Dmitry Torokhov
Hi Johannes, On 4/27/07, Johannes Berg [EMAIL PROTECTED] wrote: Obviously there's a use-after-free condition, but I can't really make out where it is. The disassembly seems to point to list_for_each_entry(list, evdev-list, node) kill_fasync(list-fasync,

Re: Getting touchscreen to work on Fujitsu B6210

2007-05-01 Thread Dmitry Torokhov
On 5/1/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Tue, 1 May 2007 11:49:38 -0400 Dmitry Torokhov [EMAIL PROTECTED] wrote: Hi Stephen, On 4/5/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: Could ypou please load evbug module or run evtest utility and verify that the driver produces

Re: [PATCH] playing ff effect with code greater then FF_EFFECTS can cause buffer overflow

2007-05-01 Thread Dmitry Torokhov
Hi Jan, On Tuesday 01 May 2007 19:15, Jan Kratochvil wrote: From: Jan Kratochvil [EMAIL PROTECTED] To: Dmitry Torokhov [EMAIL PROTECTED] Cc: Jiri Kosina [EMAIL PROTECTED], Anssi Hannula [EMAIL PROTECTED], linux-input@atrey.karlin.mff.cuni.cz, [EMAIL PROTECTED] Subject: [PATCH] playing ff

Re: [PATCH] playing ff effect with code greater then FF_EFFECTS can cause buffer overflow

2007-05-01 Thread Dmitry Torokhov
On Tuesday 01 May 2007 19:20, Jiri Kosina wrote: On Wed, 2 May 2007, Jan Kratochvil wrote: i found a bug in ff-memless.c so i fixed it. As you can see I am doing check if effect_id is less then 0, but I am aware that it is useless because effect_id is actually input_event.code which

Re: [PATCH 1/3] xpad.c: Added flags into xpad_device structure and removed dpad_mapping.

2007-05-02 Thread Dmitry Torokhov
Hi Jan, On Wednesday 02 May 2007 11:01, Jan Kratochvil wrote: This changes are expected to simplify further improves of this driver, We will need to add information if the driver is xbox360 device or not. Second option was to simply add u8 is_360, but what if we'll need to know if device is

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

2007-05-02 Thread Dmitry Torokhov
On Wednesday 02 May 2007 11:05, Jan Kratochvil wrote: +config XPAD_FF + default n Please don't default to anything. +#ifdef CONFIG_XPAD_FF +/** + * xpad_irq_out + */ Comments are welcome when they say something... +static void xpad_irq_out(struct urb *urb) +{ +

Re: [PATCH] [RFC] Added USB_DEVICE_INTERFACE_PROTOCOL

2007-05-02 Thread Dmitry Torokhov
On Wednesday 02 May 2007 18:04, Greg KH wrote: On Wed, May 02, 2007 at 05:03:05PM +0200, Jan Kratochvil wrote: The USB_DEVICE_INTERFACE_PROTOCOL will allow to match one interface protocol of vendor specific device. This macro is used in patch adding support for xbox360 to xpad.c

[PATCH] HID: usb_buffer_free() cleanup

2007-05-02 Thread Dmitry Torokhov
Subject: HID: usb_buffer_free() cleanup From: Dmitry Torokhov [EMAIL PROTECTED] HID: usb_buffer_free() cleanup usb_buffer_free() now handles NULLs so remove unneeded chaecks form callers. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/hid/usbhid/hid-core.c | 12

Re: [PATCH] input: Add wireless and bluetooth keycodes

2007-05-03 Thread Dmitry Torokhov
Hi Carlos, On 5/3/07, Carlos Corbacho [EMAIL PROTECTED] wrote: Add wireless and bluetooth keycodes. Already have them: #define KEY_BLUETOOTH 237 #define KEY_WLAN238 Also, add keycodes for these keys having a separate off state (This is true on some machines, such

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

2007-05-08 Thread Dmitry Torokhov
On Thursday 03 May 2007 09:04, Jan Kratochvil wrote: Hi Dmitry, thanks for feedback. Improved version of this patch follows: It is enabled only if CONFIG_XPAD_FF is set to y. Implementation is using force feedback support for memoryless devices. Applied with couple cosmetic changes,

Re: [PATCH 3/3] xpad.c: Added Xbox360 gamepad rumble support.

2007-05-08 Thread Dmitry Torokhov
Hi Jan, On Thursday 03 May 2007 17:41, Jan Kratochvil wrote: Hi again, what do you think about this? (This patch will work only against last gamepad rumble support patch) Thanks for your time Jan Kratochvil BigX button on xbox360 gamepad is surrounded by 4 green leds. This

Re: [RFC] psmouse: add support for 4th button using the 4th bit

2007-05-09 Thread Dmitry Torokhov
Hi Aristeu, On 5/8/07, Aristeu Rozanski [EMAIL PROTECTED] wrote: Hi Dmitry, You'd need to add something like this to psmouse_protocols[]: { .type = PSMOUSE_CORTRON, .name = CortronPS/2, .alias = cortps,

Re: [PATCH] psmouse: add support for 4th button using the 4th bit

2007-05-09 Thread Dmitry Torokhov
On 5/9/07, Aristeu Rozanski [EMAIL PROTECTED] wrote: --- linus-2.6.orig/drivers/input/mouse/psmouse.h +++ linus-2.6/drivers/input/mouse/psmouse.h @@ -78,6 +78,7 @@ struct psmouse { enum psmouse_type { PSMOUSE_NONE, PSMOUSE_PS2, + PSMOUSE_CORTRON, PSMOUSE_PS2PP,

Re: evdev: Fix a buffer overflow on BIG_ENDIAN systems

2007-05-10 Thread Dmitry Torokhov
On Thursday 10 May 2007 20:54, [EMAIL PROTECTED] wrote: I found a little mistake. On TOSHIBA Cell refference system(BIG_ENDIAN systems) a buffer overflow was occured when I specified smaller buffers than maxlen. Thank you. -- Dmitry

Re: [PATCH] Fix spitzkbd compile warnings

2007-05-13 Thread Dmitry Torokhov
Hi Richard, On 5/13/07, Richard Purdie [EMAIL PROTECTED] wrote: Fix compile warnings from spitzkbd.c. Registration failure of these IRQs isn't fatal so just warn about it. Could we also print error codes returned by request_irq()? -- Dmitry

Re: [patch 0/2] [PATCH] input: correctly handle keys without hardware release event

2007-05-13 Thread Dmitry Torokhov
Hi Giel, On Friday 11 May 2007 13:23, Giel de Nijs wrote: Hi, This patch adds a soft release key mask to input_dev, to enable keyboard drivers to determine which keys never generate a hardware release event and hence add a release event after every press event of such keys. The mask is

Re: wistron_btns: x86_64 support for key mappings?

2007-05-22 Thread Dmitry Torokhov
Hi Carlos, On 5/22/07, Carlos Corbacho [EMAIL PROTECTED] wrote: Would it be possible and acceptable to tweak the wistron_btns driver to be at least partially useful to x86_64 users? e.g. Strip out the BIOS calls on x86_64 and just leave the key mappings (such as through ifdef's or whatever

Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-28 Thread Dmitry Torokhov
On Sunday 27 May 2007 08:15, Henrique de Moraes Holschuh wrote: On Sat, 26 May 2007, Dmitry Torokhov wrote: On Saturday 26 May 2007 13:31, Henrique de Moraes Holschuh wrote: Add hotkeys available in almost all ThinkPads manufactured in the last five years (more than one million

Re: [PATCH 1/1] gpio_mouse driver

2007-05-29 Thread Dmitry Torokhov
Hi, On 5/29/07, Hans-Christian Egtvedt [EMAIL PROTECTED] wrote: This patch adds support for simulating a mouse using GPIO lines. The driver needs a platform_data struct to be defined and registered with the appropriate platform_device. The driver has been tested on AT32AP7000 microprocessor

Re: Annoying keys on AT keyboards

2007-05-29 Thread Dmitry Torokhov
Hi, On Tuesday 29 May 2007 18:21, Bastien Nocera wrote: Heya, My Dell laptop has a good bunch of keys that show this behaviour: Apr 25 11:23:10 snoogens kernel: atkbd.c: Unknown key pressed (translated set 2, code 0x87 on isa0060/serio0). Apr 25 11:23:10 snoogens kernel: atkbd.c: Use

Re: [PATCH 1/1] gpio_mouse driver

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Hans-Christian Egtvedt [EMAIL PROTECTED] wrote: On Tue, 2007-05-29 at 11:36 -0400, Dmitry Torokhov wrote: Hi, On 5/29/07, Hans-Christian Egtvedt [EMAIL PROTECTED] wrote: This patch adds support for simulating a mouse using GPIO lines. The driver needs a platform_data struct

Re: [PATCH] new driver for wireless xbox receiver for review

2007-05-30 Thread Dmitry Torokhov
Hi Brain, [Added Jan to CC list] On 5/29/07, Brian Magnuson [EMAIL PROTECTED] wrote: Hi Dimitri, Thanks for taking the time to review. My reponses are inline. -Brian * Dmitry Torokhov [EMAIL PROTECTED] [2007-05-29 20:03]: Thnk you for the patch. Looking at the code I do not see one

Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
On 5/29/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Mon, 28 May 2007, Dmitry Torokhov wrote: On Sunday 27 May 2007 08:15, Henrique de Moraes Holschuh wrote: On Sat, 26 May 2007, Dmitry Torokhov wrote: I am unconvinced that we need new keycodes. Isn't there a better default

Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
Hi Matthew, On 5/30/07, Matthew Garrett [EMAIL PROTECTED] wrote: On Wed, May 30, 2007 at 09:57:11AM -0400, Dmitry Torokhov wrote: I really don't like KEY_FN_F1..KEY_FN_BACKSPACE either. What are they supposed to do? Just being an unique value to be mapped onto something useful? But why

Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Matthew Garrett [EMAIL PROTECTED] wrote: On Wed, May 30, 2007 at 10:18:17AM -0400, Dmitry Torokhov wrote: Hi Matthew, We've already got KEY_PROG* - is this not the sort of situation they're for? (ie, keys that aren't mapped to a specific purpose but would be potentially useful

Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h

2007-05-30 Thread Dmitry Torokhov
On 5/30/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Wed, 30 May 2007, Dmitry Torokhov wrote: On 5/29/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: But I will still need to add keys, and I still think that a bunch of 32 or so HOSTSPECIFIC keys is a very very good

Re: Making KEY_UNKNOWN really useful to userland

2007-05-31 Thread Dmitry Torokhov
On 5/31/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Thu, 31 May 2007, Richard Hughes wrote: I am on it on the thinkpad-acpi side, so at least for that, you don't have to worry. I am still waiting an answer about which event is the correct one to output scancodes, but the

Re: [PATCH] Input: document the proper usage of EV_KEY and KEY_UNKNOWN

2007-05-31 Thread Dmitry Torokhov
On Thursday 31 May 2007 21:44, Matthew Garrett wrote: On Thu, May 31, 2007 at 10:29:28PM -0300, Henrique de Moraes Holschuh wrote: On Fri, 01 Jun 2007, Matthew Garrett wrote: Given existing userspace, it's never useful to generate KEY_UNKNOWN. Adding extra information to the event

Re: [PATCH 1/1] gpio_mouse driver (rewritten to GIT kernel)

2007-06-01 Thread Dmitry Torokhov
microprocessor using the ATSTK1000 development board. Signed-off-by: Hans-Christian Egtvedt [EMAIL PROTECTED] Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/mouse/Kconfig | 17 +++ drivers/input/mouse/Makefile |1 drivers/input/mouse/gpio_mouse.c | 196

Re: [PATCH] Input: Support for a less exclusive grab.

2007-06-11 Thread Dmitry Torokhov
Hi Zephaniah, On Saturday 09 June 2007 04:48, Zephaniah E. Hull wrote: EVIOCGRAB is nice and very useful, however over time I've gotten multiple requests to make it possible for applications to get events straight from the event device while xf86-input-evdev is getting events from the same

Re: [PATCH] Input: Support for a less exclusive grab.

2007-06-11 Thread Dmitry Torokhov
On Tuesday 12 June 2007 01:12, Zephaniah E. Hull wrote: On Tue, Jun 12, 2007 at 01:07:13AM -0400, Dmitry Torokhov wrote: Hi Zephaniah, On Saturday 09 June 2007 04:48, Zephaniah E. Hull wrote: EVIOCGRAB is nice and very useful, however over time I've gotten multiple requests to make

Re: [PATCH] input: make 2 macros in gameport.c TSC-aware

2007-06-11 Thread Dmitry Torokhov
Hi, On Monday 11 June 2007 00:12, Miltiadis Margaronis wrote: This makes DELTA and GET_TIME in drivers/input/gameport/gameport.c similar to the ones in drivers/input/joystick/analog.c . Worked on 2.6.22-rc4-git2. I was told with the introduction of tickless kernels and such the best

Re: [PATCH] input: fix broken behaviour of Dell Latitude special keys

2007-06-11 Thread Dmitry Torokhov
Hi, On Sunday 10 June 2007 13:42, Giel de Nijs wrote: Hi, Following up on http://thread.gmane.org/gmane.linux.kernel.input/1375 here's a new patch to fix the fact that most Fn+F? special keys on (at least) the Dell Latitude laptops don't generate a key release event. Thank you for the

Re: [PATCH] Input: Support for a less exclusive grab.

2007-06-11 Thread Dmitry Torokhov
On Tuesday 12 June 2007 01:23, Zephaniah E. Hull wrote: On Tue, Jun 12, 2007 at 01:19:59AM -0400, Dmitry Torokhov wrote: Like I said I would love if xf86-input-evdev did not grab the device at all. We have to disable the legacy input handlers somehow, not doing so simply isn't

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-16 Thread Dmitry Torokhov
Hi Linus, On 7/15/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Mon, 16 Jul 2007, federico ferri wrote: Linus Torvalds ha scritto: Well, this is totally untested, and I won't guarantee that this works at all, but this is how to generally do these kinds of things.. YAY! it works

Re: Keyboard problem

2007-07-16 Thread Dmitry Torokhov
Hi Natalie, On 7/15/07, Natalie Protasevich [EMAIL PROTECTED] wrote: Hello, We have a problem with keybords here. It only hits several systems out of many, and really impossible to reproduce because it happens on different combinations of hardware/software and no one managed to find out what

Re: Force Feedback: Thrustmaster FGT Wheel quick-and-dirty in hid-lgff.c or hid-tmff.c

2007-07-16 Thread Dmitry Torokhov
On 7/16/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: OK, how about this then? Ignore it, it missing couple of bits; Anssi's is more complete I think. -- Dmitry

Re: Force Feedback: Thrustmaster FGT Wheel quick-and-dirty in hid-lgff.c or hid-tmff.c

2007-07-16 Thread Dmitry Torokhov
On 7/16/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 7/16/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: OK, how about this then? Ignore it, it missing couple of bits; Anssi's is more complete I think. Not quite what I wanted either, what about this one? -- Dmitry hid-add-thrustmaster

Re: [PATCH 2/3] leds-clevo-mail: hw accelerated LED blink extension

2007-07-17 Thread Dmitry Torokhov
On 7/17/07, Németh Márton [EMAIL PROTECTED] wrote: +Hardware accelerated blink of LEDs +== + +Some LEDs can be programmed to blink without any CPU interaction. To +support this feature, a LED driver can optionally implement the +blink_set() function (see

Re: [PATCH] input: change SysRq keycode for systems without SysRq key

2007-07-19 Thread Dmitry Torokhov
On 7/19/07, federico ferri [EMAIL PROTECTED] wrote: Dmitry Torokhov ha scritto: # echo 84 183 | keyfuzz -s -d/dev/input/event1 EVIOCGKEYCODE: Invalid argument # echo 84 183 | keyfuzz -s -d/dev/input/event2 EVIOCGKEYCODE: Invalid argument # echo 0x05d 0x0b7 | keyfuzz -s -d/dev/input/event2

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
Hi Geert, On 7/20/07, Geert Uytterhoeven [EMAIL PROTECTED] wrote: From: Geert Uytterhoeven [EMAIL PROTECTED] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible drivers/char/keyboard.c: In function 'kbd_keycode': drivers/char/keyboard.c:1142: error: implicit declaration of

Re: [PATCH] USB: driver for CM109 chipset

2007-07-20 Thread Dmitry Torokhov
On 7/12/07, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Thu, Jul 12, 2007 at 12:22:10PM -0400, Dmitry Torokhov wrote: Hmm, they use KEY_0 through KEY_9 now. Which results in the phone sending 'é+ěščřžýáí' instead of '0123456789' on a Czech keyboard, which is definitely not what's intended

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Dmitry Torokhov
Hi Kristoffer, On 7/18/07, Kristoffer Ericson [EMAIL PROTECTED] wrote: Try #2 Thanks for feedback, Ive tried a different approach to get it better handled. Thank you for making the changes I requested, however there is still an issue: + + ret = request_irq(IRQ_GPIO0, +

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-20 Thread Dmitry Torokhov
On 7/21/07, Kristoffer Ericson [EMAIL PROTECTED] wrote: Greetings, Ive added it to free IRQ as you said, a minor change is also that jornada720.h defines are set in CAPS (just changed that for Russell). Ive also added the Kconfig and Makefile. Btw, do you keep patchtracker (like Russell) or

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-21 Thread Dmitry Torokhov
Hi Geert, On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote: On Fri, 20 Jul 2007, Dmitry Torokhov wrote: I am OK with adding a new header file. I was just saying that placing that declaration in linux/hid.h makes about the same sense as putting it into linux/scsi.h At first I

Re: [PATCH] HP Jornada 7xx keyboard support

2007-07-21 Thread Dmitry Torokhov
: Kristoffer Ericson [EMAIL PROTECTED] Input: HP Jornada 7xx keyboard driver Signed-off-by: Kristoffer Ericson [EMAIL PROTECTED] Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/keyboard/Kconfig |7 + drivers/input/keyboard/Makefile |1 drivers/input

Re: [HP Jornada 6XX] - Onboard Keyboard support

2007-07-21 Thread Dmitry Torokhov
On Saturday 21 July 2007 21:15, Kristoffer Ericson wrote: Greetings, Here we go again with another keyboard patch (this time for hp6xx). It consists of three files, where one contains the generic scan_keyb routines with needed header and the third is the specific hp6xx driver. Please do not

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-23 Thread Dmitry Torokhov
On Sunday 22 July 2007 08:51, Geert Uytterhoeven wrote: On Sun, 22 Jul 2007, Dmitry Torokhov wrote: On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote: On Fri, 20 Jul 2007, Dmitry Torokhov wrote: I am OK with adding a new header file. I was just saying that placing

Re: [PATCH][08/37] Clean up duplicate includes in drivers/input/

2007-07-23 Thread Dmitry Torokhov
On Saturday 21 July 2007 11:02, Jesper Juhl wrote: Hi, This patch cleans up duplicate includes in drivers/input/ Applied to for-linus branch of input tree, thank you. -- Dmitry

[RFC/RFT 5/5] Input: joydev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: joydev - implement proper locking Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/joydev.c | 745 - 1 files changed, 493 insertions(+), 252 deletions(-) Index: work/drivers/input/joydev.c

[RFC/RFT 2/5] evdev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: evdev - implement proper locking Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/evdev.c | 719 +- 1 files changed, 476 insertions(+), 243 deletions(-) Index: work/drivers/input/evdev.c

[RFC/RFT 4/5] Input: mousedev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: mousedev - implement proper locking Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/mousedev.c | 736 +-- 1 files changed, 464 insertions(+), 272 deletions(-) Index: work/drivers/input/mousedev.c

[RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Input: implement proper locking in input core Also add some kerneldoc documentation to input.h Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/input.c | 656 -- include/linux/input.h | 112 +++- 2 files changed, 585

Re: [RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Hi Jeff, On Tuesday 24 July 2007 01:35, Jeff Garzik wrote: spin_lock_irq() should generally be avoided. In cases like the first case -- input_repeat_key() -- you are making incorrect assumptions about the state of interrupts. The other cases are probably ok, but in general

Re: [PATCH] Try harder to probe finicky rodents

2007-07-30 Thread Dmitry Torokhov
On Sunday 22 July 2007 13:24, Alon Ziv wrote: My rodent appears to be extra-finicky, and requires both a PSMOUSE_RESET_DIS and a PSMOUSE_RESET_BAT before it is unconfused enough to be probed. Signed-off-by: Alon Ziv [EMAIL PROTECTED] Applied, thank you. -- Dmitry

Re: [2.6 patch] make the dummy touchkit_ps2_detect() static

2007-08-30 Thread Dmitry Torokhov
Hi Adrian, On Tuesday 14 August 2007 17:22, Adrian Bunk wrote: The dummy touchkit_ps2_detect() for the CONFIG_MOUSE_PS2_TOUCHKIT=n case shouldn't be a global function. Applied, thank you. Btw, sorry for the long silence - I had a hard drive crash and the day after I restored everything the

Re: sysfs change of input/event devices in 2.6.23rc breaks udev

2007-09-10 Thread Dmitry Torokhov
On 9/10/07, Greg KH [EMAIL PROTECTED] wrote: On Mon, Sep 10, 2007 at 01:28:47AM -0400, Dmitry Torokhov wrote: On Sunday 09 September 2007 19:03, Kay Sievers wrote: On 9/8/07, Anssi Hannula [EMAIL PROTECTED] wrote: However, the change that broke id_path of udev is that /sys/class

Re: [PATCH] xpad: fix Kconfig to avoid compile error

2007-09-19 Thread Dmitry Torokhov
On 9/19/07, Andreas Herrmann [EMAIL PROTECTED] wrote: On Tue, Sep 18, 2007 at 01:52:11PM -0400, Dmitry Torokhov wrote: To avoid this kernel configuration, do auto-select LEDS_CLASS for JOYSTCK_XPAD_LEDS. I'd rather it depend on LEDS_CLASS (but properly). I believe I posted a patch

Re: [HP7XX/PATCH] - HP720 Jornada Touchscreen (Updated, please use this one)

2007-09-19 Thread Dmitry Torokhov
On 9/20/07, Kristoffer Ericson [EMAIL PROTECTED] wrote: + if (jornada_ssp_inout(GETTOUCHSAMPLES == TXDUMMY)) { Are you sure? Looks like paren is pisplaced. + + ret = request_irq(IRQ_GPIO9, + jornada720_ts_interrupt, + IRQF_DISABLED |

Re: [linux-usb-devel] detecting when keys are being pressed on a keyboard

2007-09-24 Thread Dmitry Torokhov
Hi Oliver, On 9/24/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Freitag 21 September 2007 schrieb Jiri Kosina: On Fri, 21 Sep 2007, Oliver Neukum wrote: I got the strange case of a keyboard going into autosuspend while a key was being pressed. The key release never arrived and I had

Re: [linux-usb-devel] detecting when keys are being pressed on a keyboard

2007-09-24 Thread Dmitry Torokhov
On 9/24/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Montag 24 September 2007 schrieb Dmitry Torokhov: Hi Oliver, On 9/24/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Freitag 21 September 2007 schrieb Jiri Kosina: Hi Oliver, HID doesn't keep any permanent state by itself

Re: Handling touchscreen buttons

2007-09-24 Thread Dmitry Torokhov
On Monday 24 September 2007, Kristoffer Ericson wrote: Greetings, On my jornada7xx I have 4 buttons on the rightside of the screen (going from Y-low - Y-high). They are part of the touchscreen. Since they aren't usually used in normal X window handling I was thinking that I should have

Re: Problem with appletouch driver in Linux version 2.6.23-rc7

2007-09-26 Thread Dmitry Torokhov
On 9/26/07, Soeren Sonnenburg [EMAIL PROTECTED] wrote: On Mon, 2007-09-24 at 15:22 +0200, Thomas Rohwer wrote: Hello, could you please re-send the patch? I for some reason have yet to see it ... here it is again, adressing also the comments from Dmitry. Thomas, Matthew and

Re: new version of usbhid autosuspend patch

2007-09-27 Thread Dmitry Torokhov
Hi Oliver, On 9/27/07, Oliver Neukum [EMAIL PROTECTED] wrote: +int hid_check_keys_pressed(struct hid_device *hid) +{ + struct hid_input *hidinput, *next; + int i; + + list_for_each_entry_safe(hidinput, next, hid-inputs, list) { + for (i = 0; i

Re: [PATCH] input: move gameports out of SERIO menu

2007-10-02 Thread Dmitry Torokhov
Hi Randy, On Tuesday 02 October 2007, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Move the gameport support menu out of the SERIO menu and put it between touchscreens and misc. devices in the main input layer menu. Change it to use menuconfig instead of config. Or was it

Re: even newer version of USB HID autosuspend

2007-10-07 Thread Dmitry Torokhov
On Saturday 06 October 2007, Oliver Neukum wrote: This leaves me with a planning difficulty. For keyboards it is not fully transparent. The LEDs are switched off when then keyboard is suspended. Should I now implement a mode where active LEDs block suspension and if so, how do I

Re: GeneralTouch USB Touchscreen Support

2007-10-08 Thread Dmitry Torokhov
Hi Ilya, On 10/8/07, if [EMAIL PROTECTED] wrote: Hello! Sending patch as told to. Formal notes: Patch made against 2.6.22.9 sources. Marketing is lying, quick google for model ( TL6B17S) shows they say it has 4096x4096 sensitivity, while device itself do not report more than 0x0470 (i set

Re: even newer version of USB HID autosuspend

2007-10-08 Thread Dmitry Torokhov
On 10/8/07, Oliver Neukum [EMAIL PROTECTED] wrote: Am Sonntag 07 Oktober 2007 schrieb Dmitry Torokhov: I'd say do not autosuspend keyboards (and other led-equipped input devices) unless user explicitely requested to do so and then turn the leds off. So your answer is that we shouldn't

Re: [PATCH] Generic, platform independent matrix keyboard support

2007-10-09 Thread Dmitry Torokhov
Hi Pavel, On 10/9/07, Pavel Pisa [EMAIL PROTECTED] wrote: Subject: Generic, platform independent matrix keyboard support From: Pavel Pisa [EMAIL PROTECTED] The genmatrix_kbd module provides support for matrix keyboard where switches interconnects return lines with port driven scan lines.

Re: Handling transition into suspend through keyboard driver

2007-10-09 Thread Dmitry Torokhov
Hi Kristoffer, On 10/8/07, Kristoffer Ericson [EMAIL PROTECTED] wrote: Greetings, Dmitry, Im implementing suspend for hp7xx currently. I've added EV_PWR to bitflags and linked so POWER_KEY gets reported correctly. Is this the correct approach? Yes, it is. Keyboard drivers sghoudl just

Re: [PATCH try #2] Blackfin BF54x Input Keypad controller driver

2007-10-09 Thread Dmitry Torokhov
Hi Bryan, On 10/4/07, Bryan Wu [EMAIL PROTECTED] wrote: From: Michael Hennerich [EMAIL PROTECTED] Blackfin BF54x Input Keypad controller driver: [try #2] Changelog: - Coding style issue fixes - using a temp variable for bf54x_kpad-input - Other updates according to Dmitry's review I

Re: [PATCH] Generic, platform independent matrix keyboard support

2007-10-10 Thread Dmitry Torokhov
On 10/9/07, David Brownell [EMAIL PROTECTED] wrote: On Tuesday 09 October 2007, Pavel Pisa wrote: On the other hand I cannot imagine electronic designed wanting so many wires. Reduction of the wires counts is why matrix keyboards are used. The 32 bits limitation then means that maximal

Re: [PATCH] Generic, platform independent matrix keyboard support

2007-10-10 Thread Dmitry Torokhov
On 10/9/07, Pavel Pisa [EMAIL PROTECTED] wrote: Name of corresponding platform and PCI methods is probe. But name can be changed if new one is seen as more logical. There you indeed probing devices for supported functionality. But here you just register a new object with the system (note that

Re: GeneralTouch USB Touchscreen Support

2007-10-11 Thread Dmitry Torokhov
Hi Jiri, On Monday 08 October 2007, Jiri Kosina wrote: On Mon, 8 Oct 2007, Dmitry Torokhov wrote: The patch looks good, thanks a lot. Can I please have your Signed-off-by: so I can apply it? Thanks! Hi, my only concern with this patch is -- could we please keep the entries

Re: [PATCH 2/3] Input/Touchscreen Driver: add support AD7877 touchscreen driver

2007-10-11 Thread Dmitry Torokhov
Hi Bryan, Michael, On 10/11/07, Bryan Wu [EMAIL PROTECTED] wrote: + +static int gpio3 = 0; No need to initialize. + +static int ad7877_read(struct device *dev, u16 reg) +{ + struct spi_device *spi = to_spi_device(dev); + struct ser_req *req = kzalloc(sizeof

Re: [PATCH try #3] Blackfin BF54x Input Keypad controller driver

2007-10-11 Thread Dmitry Torokhov
;. Please let me know if you are OK with it. Thanks! Cc: Dmitry Torokhov [EMAIL PROTECTED] Signed-off-by: Michael Hennerich [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- arch/blackfin/mach-bf548/boards/ezkit.c |2 +- drivers/input/keyboard/Kconfig |9

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
Hi Ahmed, On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote: On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote: Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- Hi Bryan, Why creating module's own kthread to call ad7142_decode and process keycodes instead of using a tasklet ?

  1   2   >