[PATCH] autofs - fix directory and symlink access

2018-06-14 Thread Ian Kent
Depending on how it is configured the autofs user space daemon can leave in use mounts mounted at exit and re-connect to them at start up. But for this to work best the state of the autofs file system needs to be left intact over the restart. Also, at system shutdown, mounts in an autofs file

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-06-01 Thread Ian Kent
On Fri, 2018-06-01 at 09:35 +0800, Ian Kent wrote: > On Thu, 2018-05-31 at 17:13 -0700, Andrew Morton wrote: > > On Wed, 30 May 2018 17:18:55 +0800 Ian Kent wrote: > > > > > > I actually had an alternative approach that I tried out successfully > > > > bu

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-06-01 Thread Ian Kent
On Fri, 2018-06-01 at 09:35 +0800, Ian Kent wrote: > On Thu, 2018-05-31 at 17:13 -0700, Andrew Morton wrote: > > On Wed, 30 May 2018 17:18:55 +0800 Ian Kent wrote: > > > > > > I actually had an alternative approach that I tried out successfully > > > > bu

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-05-31 Thread Ian Kent
On Thu, 2018-05-31 at 17:13 -0700, Andrew Morton wrote: > On Wed, 30 May 2018 17:18:55 +0800 Ian Kent wrote: > > > > I actually had an alternative approach that I tried out successfully > > > but discarded as being too different from the original code. Just for > &g

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-05-31 Thread Ian Kent
On Thu, 2018-05-31 at 17:13 -0700, Andrew Morton wrote: > On Wed, 30 May 2018 17:18:55 +0800 Ian Kent wrote: > > > > I actually had an alternative approach that I tried out successfully > > > but discarded as being too different from the original code. Just for > &g

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-05-30 Thread Ian Kent
On Wed, 2018-05-30 at 10:41 +0200, Arnd Bergmann wrote: > On Wed, May 30, 2018 at 2:48 AM, Ian Kent wrote: > > On Tue, 2018-05-29 at 11:46 +0200, Arnd Bergmann wrote: > > > The autofs4 implementation is just a redirect to autofs now, but that > > > also mea

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-05-30 Thread Ian Kent
On Wed, 2018-05-30 at 10:41 +0200, Arnd Bergmann wrote: > On Wed, May 30, 2018 at 2:48 AM, Ian Kent wrote: > > On Tue, 2018-05-29 at 11:46 +0200, Arnd Bergmann wrote: > > > The autofs4 implementation is just a redirect to autofs now, but that > > > also mea

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-05-29 Thread Ian Kent
On Tue, 2018-05-29 at 11:46 +0200, Arnd Bergmann wrote: > The autofs4 implementation is just a redirect to autofs now, but that > also means we can't have both built into the same kernel: > > fs/autofs/inode.o: In function `autofs_new_ino': > inode.c:(.text+0x1b8): multiple definition of

Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive

2018-05-29 Thread Ian Kent
On Tue, 2018-05-29 at 11:46 +0200, Arnd Bergmann wrote: > The autofs4 implementation is just a redirect to autofs now, but that > also means we can't have both built into the same kernel: > > fs/autofs/inode.o: In function `autofs_new_ino': > inode.c:(.text+0x1b8): multiple definition of

Re: [PATCH] mm-kasan-dont-vfree-nonexistent-vm_area-fix

2018-05-28 Thread Ian Kent
On Mon, 2018-05-28 at 12:39 +0800, Ian Kent wrote: > On Mon, 2018-05-28 at 12:13 +0800, Ian Kent wrote: > > On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > > > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot > > > wrote: > > > > > > &g

Re: [PATCH] mm-kasan-dont-vfree-nonexistent-vm_area-fix

2018-05-28 Thread Ian Kent
On Mon, 2018-05-28 at 12:39 +0800, Ian Kent wrote: > On Mon, 2018-05-28 at 12:13 +0800, Ian Kent wrote: > > On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > > > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot > > > wrote: > > > > > > &g

Re: [PATCH] mm-kasan-dont-vfree-nonexistent-vm_area-fix

2018-05-27 Thread Ian Kent
On Mon, 2018-05-28 at 12:13 +0800, Ian Kent wrote: > On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot <l...@intel.com> wrote: > > > > > Hi Andrey, > > > > > > I love your patch! Ye

Re: [PATCH] mm-kasan-dont-vfree-nonexistent-vm_area-fix

2018-05-27 Thread Ian Kent
On Mon, 2018-05-28 at 12:13 +0800, Ian Kent wrote: > On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot wrote: > > > > > Hi Andrey, > > > > > > I love your patch! Yet something to improve: &g

Re: [PATCH] mm-kasan-dont-vfree-nonexistent-vm_area-fix

2018-05-27 Thread Ian Kent
On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot wrote: > > > Hi Andrey, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on mmotm/master] > > [cannot apply to v4.17-rc6] > > [if

Re: [PATCH] mm-kasan-dont-vfree-nonexistent-vm_area-fix

2018-05-27 Thread Ian Kent
On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot wrote: > > > Hi Andrey, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on mmotm/master] > > [cannot apply to v4.17-rc6] > > [if your patch is

[REPOST PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
attention to it. It also results in AUTOFS4_FS being removed from .config for any setting of AUTOFS_FS except n. Adding a "NOTE" to the AUTOFS4_FS help text will hopefully raise awareness of the change to smooth the transition. Signed-off-by: Ian Kent <ra...@themaw.net> Reported-by: Randy Dun

[REPOST PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
attention to it. It also results in AUTOFS4_FS being removed from .config for any setting of AUTOFS_FS except n. Adding a "NOTE" to the AUTOFS4_FS help text will hopefully raise awareness of the change to smooth the transition. Signed-off-by: Ian Kent Reported-by: Randy Dunlap Tested-by: Randy Dun

Re: [PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
On 21/05/18 10:08, Randy Dunlap wrote: > On 05/20/2018 06:04 PM, Ian Kent wrote: >> Setting AUTOFS_FS and AUTOFS4_FS to y or m results in a compile >> failure. >> >> It isn't possible to unset one if the other is set because it >> introduces a circular depe

Re: [PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
On 21/05/18 10:08, Randy Dunlap wrote: > On 05/20/2018 06:04 PM, Ian Kent wrote: >> Setting AUTOFS_FS and AUTOFS4_FS to y or m results in a compile >> failure. >> >> It isn't possible to unset one if the other is set because it >> introduces a circular depe

[PATCH] autofs - comment on selinux changes needed for module autoload

2018-05-20 Thread Ian Kent
that prohibit autoloading of the autofs module which need to be changed. Add a comment about this to "possible changes" section of the autofs4 module help. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/Kconfig |6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/auto

[PATCH] autofs - comment on selinux changes needed for module autoload

2018-05-20 Thread Ian Kent
that prohibit autoloading of the autofs module which need to be changed. Add a comment about this to "possible changes" section of the autofs4 module help. Signed-off-by: Ian Kent --- fs/autofs4/Kconfig |6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/autofs4/Kconfig b/fs/autof

[PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
which should call attention to it. It also results in AUTOFS4_FS being removed from .config for any setting of AUTOFS_FS except n. Adding a "NOTE" to the AUTOFS4_FS help text will hopefully raise awareness of the change to smooth the transition. Signed-off-by: Ian Kent <ra...@the

[PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
which should call attention to it. It also results in AUTOFS4_FS being removed from .config for any setting of AUTOFS_FS except n. Adding a "NOTE" to the AUTOFS4_FS help text will hopefully raise awareness of the change to smooth the transition. Signed-off-by: Ian Kent Cc: Randy Dunlap --

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-20 Thread Ian Kent
On 21/05/18 08:43, Ian Kent wrote: >>> >>> It looks like adding: >>> depends on AUTOFS_FS = n && AUTOFS_FS != m >> >> Hi. Is there a typo on the line above? LOL, but your point is what does the AUTOFS_FS != m do! The answer should be no

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-20 Thread Ian Kent
On 21/05/18 08:43, Ian Kent wrote: >>> >>> It looks like adding: >>> depends on AUTOFS_FS = n && AUTOFS_FS != m >> >> Hi. Is there a typo on the line above? LOL, but your point is what does the AUTOFS_FS != m do! The answer should be no

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-20 Thread Ian Kent
On 19/05/18 00:22, Randy Dunlap wrote: > On 05/17/2018 11:09 PM, Ian Kent wrote: >> On 18/05/18 12:38, Ian Kent wrote: >>> On 18/05/18 12:23, Randy Dunlap wrote: >>>> On 05/17/2018 08:50 PM, Ian Kent wrote: >>>>> On 18/05/18 08:21, Randy Dunlap wro

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-20 Thread Ian Kent
On 19/05/18 00:22, Randy Dunlap wrote: > On 05/17/2018 11:09 PM, Ian Kent wrote: >> On 18/05/18 12:38, Ian Kent wrote: >>> On 18/05/18 12:23, Randy Dunlap wrote: >>>> On 05/17/2018 08:50 PM, Ian Kent wrote: >>>>> On 18/05/18 08:21, Randy Dunlap wro

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-18 Thread Ian Kent
On 18/05/18 12:38, Ian Kent wrote: > On 18/05/18 12:23, Randy Dunlap wrote: >> On 05/17/2018 08:50 PM, Ian Kent wrote: >>> On 18/05/18 08:21, Randy Dunlap wrote: >>>> On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote: >>>>> The mm-of-the-momen

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-18 Thread Ian Kent
On 18/05/18 12:38, Ian Kent wrote: > On 18/05/18 12:23, Randy Dunlap wrote: >> On 05/17/2018 08:50 PM, Ian Kent wrote: >>> On 18/05/18 08:21, Randy Dunlap wrote: >>>> On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote: >>>>> The mm-of-the-momen

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-17 Thread Ian Kent
On 18/05/18 12:23, Randy Dunlap wrote: > On 05/17/2018 08:50 PM, Ian Kent wrote: >> On 18/05/18 08:21, Randy Dunlap wrote: >>> On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote: >>>> The mm-of-the-moment snapshot 2018-05-17-16-26 has been uploaded to >>&g

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-17 Thread Ian Kent
On 18/05/18 12:23, Randy Dunlap wrote: > On 05/17/2018 08:50 PM, Ian Kent wrote: >> On 18/05/18 08:21, Randy Dunlap wrote: >>> On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote: >>>> The mm-of-the-moment snapshot 2018-05-17-16-26 has been uploaded to >>&g

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-17 Thread Ian Kent
On 18/05/18 08:21, Randy Dunlap wrote: > On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2018-05-17-16-26 has been uploaded to >> >>http://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >>

Re: mmotm 2018-05-17-16-26 uploaded (autofs)

2018-05-17 Thread Ian Kent
On 18/05/18 08:21, Randy Dunlap wrote: > On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2018-05-17-16-26 has been uploaded to >> >>http://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for mm-of-the-moment: >> >>

[PATCH] autofs - clean up includes

2018-05-14 Thread Ian Kent
Remove includes that aren't needed from autofs (and fs/compat_ioctl.c). Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs/autofs_i.h |2 +- fs/autofs/dev-ioctl.c | 13 - fs/autofs/inode.c |6 +- fs/autofs/root.c |6 -- fs/autofs/w

[PATCH] autofs - clean up includes

2018-05-14 Thread Ian Kent
Remove includes that aren't needed from autofs (and fs/compat_ioctl.c). Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |2 +- fs/autofs/dev-ioctl.c | 13 - fs/autofs/inode.c |6 +- fs/autofs/root.c |6 -- fs/autofs/waitq.c |4 fs

Re: [PATCH 01/10] autofs4 - merge auto_fs.h and auto_fs4.h

2018-05-13 Thread Ian Kent
On 14/05/18 11:15, Al Viro wrote: > On Mon, May 14, 2018 at 11:03:50AM +0800, Ian Kent wrote: >> The autofs module has long since been removed so there's no need to have >> two separate include files for autofs. > > Umm... Why does fs/compat_ioctl.c need either include, act

Re: [PATCH 01/10] autofs4 - merge auto_fs.h and auto_fs4.h

2018-05-13 Thread Ian Kent
On 14/05/18 11:15, Al Viro wrote: > On Mon, May 14, 2018 at 11:03:50AM +0800, Ian Kent wrote: >> The autofs module has long since been removed so there's no need to have >> two separate include files for autofs. > > Umm... Why does fs/compat_ioctl.c need either include, act

[PATCH 03/10] autofs - copy autofs4 to autofs

2018-05-13 Thread Ian Kent
Copy source files from the autofs4 directory to the autofs directory. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs/autofs_i.h | 273 ++ fs/autofs/dev-ioctl.c | 761 fs/autofs/expire.c

[PATCH 03/10] autofs - copy autofs4 to autofs

2018-05-13 Thread Ian Kent
Copy source files from the autofs4 directory to the autofs directory. Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h | 273 ++ fs/autofs/dev-ioctl.c | 761 fs/autofs/expire.c| 632 + fs/autofs/init.c

[PATCH 02/10] autofs4 - use autofs instead of autofs4 everywhere

2018-05-13 Thread Ian Kent
Update naming within autofs source to be consistent by changing occurrences of autofs4 to autofs. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/autofs_i.h | 88 fs/autofs4/dev-ioctl.c | 18 ++- fs/autofs4/expire.c| 132 --- fs/a

[PATCH 02/10] autofs4 - use autofs instead of autofs4 everywhere

2018-05-13 Thread Ian Kent
Update naming within autofs source to be consistent by changing occurrences of autofs4 to autofs. Signed-off-by: Ian Kent --- fs/autofs4/autofs_i.h | 88 fs/autofs4/dev-ioctl.c | 18 ++- fs/autofs4/expire.c| 132 --- fs/autofs4/init.c | 12

[PATCH 07/10] autofs - delete fs/autofs4 source files

2018-05-13 Thread Ian Kent
Delete the now unused autofs4 module files. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/autofs_i.h | 273 -- fs/autofs4/dev-ioctl.c | 761 --- fs/autofs4/expire.c| 632 fs/autofs4/

[PATCH 05/10] autofs - update fs/autofs4/Kconfig

2018-05-13 Thread Ian Kent
Update Kconfig and add a depricated warning. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/Kconfig | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig index 44727bf18297..53bc592a250d

[PATCH 09/10] autofs - use autofs instead of autofs4 in documentation

2018-05-13 Thread Ian Kent
Finally remove autofs4 references in the filesystems documentation. Signed-off-by: Ian Kent <ra...@themaw.net> --- Documentation/filesystems/00-INDEX |4 ++-- Documentation/filesystems/autofs-mount-control.txt |8 Documentation/filesystems/auto

[PATCH 04/10] autofs - create autofs Kconfig and Makefile

2018-05-13 Thread Ian Kent
Create Makefile and Kconfig for autofs module. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/Kconfig |1 + fs/Makefile|1 + fs/autofs/Kconfig | 20 fs/autofs/Makefile |7 +++ 4 files changed, 29 insertions(+) create mode 100

[PATCH 08/10] autofs - rename autofs documentation files

2018-05-13 Thread Ian Kent
There are two files in Documentation/filsystems that should now use autofs rather than autofs4 in their names. Signed-off-by: Ian Kent <ra...@themaw.net> --- Documentation/filesystems/autofs-mount-control.txt | 407 +++ Documentation/filesystems/autofs.txt

[PATCH 05/10] autofs - update fs/autofs4/Kconfig

2018-05-13 Thread Ian Kent
Update Kconfig and add a depricated warning. Signed-off-by: Ian Kent --- fs/autofs4/Kconfig | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig index 44727bf18297..53bc592a250d 100644 --- a/fs/autofs4

[PATCH 09/10] autofs - use autofs instead of autofs4 in documentation

2018-05-13 Thread Ian Kent
Finally remove autofs4 references in the filesystems documentation. Signed-off-by: Ian Kent --- Documentation/filesystems/00-INDEX |4 ++-- Documentation/filesystems/autofs-mount-control.txt |8 Documentation/filesystems/autofs.txt | 10

[PATCH 04/10] autofs - create autofs Kconfig and Makefile

2018-05-13 Thread Ian Kent
Create Makefile and Kconfig for autofs module. Signed-off-by: Ian Kent --- fs/Kconfig |1 + fs/Makefile|1 + fs/autofs/Kconfig | 20 fs/autofs/Makefile |7 +++ 4 files changed, 29 insertions(+) create mode 100644 fs/autofs/Kconfig create

[PATCH 08/10] autofs - rename autofs documentation files

2018-05-13 Thread Ian Kent
There are two files in Documentation/filsystems that should now use autofs rather than autofs4 in their names. Signed-off-by: Ian Kent --- Documentation/filesystems/autofs-mount-control.txt | 407 +++ Documentation/filesystems/autofs.txt | 529

[PATCH 07/10] autofs - delete fs/autofs4 source files

2018-05-13 Thread Ian Kent
Delete the now unused autofs4 module files. Signed-off-by: Ian Kent --- fs/autofs4/autofs_i.h | 273 -- fs/autofs4/dev-ioctl.c | 761 --- fs/autofs4/expire.c| 632 fs/autofs4/init.c | 48 -- fs

[PATCH 10/10] autofs - update MAINTAINERS entry for autofs

2018-05-13 Thread Ian Kent
Update the autofs entry in MAINTAINERS to reflect the rename of autofs4 to autofs. Signed-off-by: Ian Kent <ra...@themaw.net> --- MAINTAINERS |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 58b9861ccf99..6189ff91fda7

[PATCH 10/10] autofs - update MAINTAINERS entry for autofs

2018-05-13 Thread Ian Kent
Update the autofs entry in MAINTAINERS to reflect the rename of autofs4 to autofs. Signed-off-by: Ian Kent --- MAINTAINERS |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 58b9861ccf99..6189ff91fda7 100644 --- a/MAINTAINERS +++ b

[PATCH 01/10] autofs4 - merge auto_fs.h and auto_fs4.h

2018-05-13 Thread Ian Kent
The autofs module has long since been removed so there's no need to have two separate include files for autofs. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/autofs_i.h |2 fs/compat_ioctl.c |1 include/uapi/linux/auto_fs.h

[PATCH 01/10] autofs4 - merge auto_fs.h and auto_fs4.h

2018-05-13 Thread Ian Kent
The autofs module has long since been removed so there's no need to have two separate include files for autofs. Signed-off-by: Ian Kent --- fs/autofs4/autofs_i.h |2 fs/compat_ioctl.c |1 include/uapi/linux/auto_fs.h | 169

[PATCH 06/10] autofs - update fs/autofs4/Makefile

2018-05-13 Thread Ian Kent
Update Makefile to build from source in fs/autofs instead of fs/autofs4. Signed-off-by: Ian Kent <ra...@themaw.net> --- fs/autofs4/Makefile |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/autofs4/Makefile b/fs/autofs4/Makefile index a811c1f7d9ab..417dd726d9ef

[PATCH 06/10] autofs - update fs/autofs4/Makefile

2018-05-13 Thread Ian Kent
Update Makefile to build from source in fs/autofs instead of fs/autofs4. Signed-off-by: Ian Kent --- fs/autofs4/Makefile |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/autofs4/Makefile b/fs/autofs4/Makefile index a811c1f7d9ab..417dd726d9ef 100644 --- a/fs/autofs4

Re: [PATCH] autofs4: use wake_up() instead of wake_up_interruptible

2018-04-02 Thread Ian Kent
On 01/04/18 14:21, Andrei Vagin wrote: > On Sun, Apr 01, 2018 at 10:01:41AM +0800, Ian Kent wrote: >> On 01/04/18 09:31, Ian Kent wrote: >>> On 31/03/18 10:28, Andrei Vagin wrote: >>>> In "autofs4: use wait_event_killable", wait_event_interruptible()

Re: [PATCH] autofs4: use wake_up() instead of wake_up_interruptible

2018-04-02 Thread Ian Kent
On 01/04/18 14:21, Andrei Vagin wrote: > On Sun, Apr 01, 2018 at 10:01:41AM +0800, Ian Kent wrote: >> On 01/04/18 09:31, Ian Kent wrote: >>> On 31/03/18 10:28, Andrei Vagin wrote: >>>> In "autofs4: use wait_event_killable", wait_event_interruptible()

Re: [PATCH] autofs4: use wake_up() instead of wake_up_interruptible

2018-03-31 Thread Ian Kent
On 01/04/18 09:31, Ian Kent wrote: > On 31/03/18 10:28, Andrei Vagin wrote: >> In "autofs4: use wait_event_killable", wait_event_interruptible() was >> replaced by wait_event_killable(), but in this case we have to use >> wake_up() instead of wake_up_interrupt

Re: [PATCH] autofs4: use wake_up() instead of wake_up_interruptible

2018-03-31 Thread Ian Kent
On 01/04/18 09:31, Ian Kent wrote: > On 31/03/18 10:28, Andrei Vagin wrote: >> In "autofs4: use wait_event_killable", wait_event_interruptible() was >> replaced by wait_event_killable(), but in this case we have to use >> wake_up() instead of wake_up_interrupt

Re: [PATCH] autofs4: use wake_up() instead of wake_up_interruptible

2018-03-31 Thread Ian Kent
r a mount, they all should be woken up when the daemon signals mount completion. > > Cc: Matthew Wilcox <mawil...@microsoft.com> > Cc: Ian Kent <ra...@themaw.net> > Cc: Andrew Morton <a...@linux-foundation.org> > Cc: Stephen Rothwell <s...@canb.auug.org.au> >

Re: [PATCH] autofs4: use wake_up() instead of wake_up_interruptible

2018-03-31 Thread Ian Kent
r a mount, they all should be woken up when the daemon signals mount completion. > > Cc: Matthew Wilcox > Cc: Ian Kent > Cc: Andrew Morton > Cc: Stephen Rothwell > Signed-off-by: Andrei Vagin > --- > fs/autofs4/waitq.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH] autofs4: Use wait_event_killable

2018-03-19 Thread Ian Kent
On 20/03/18 03:25, David Rientjes wrote: > On Mon, 19 Mar 2018, Matthew Wilcox wrote: > >> diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c >> index a0c57c37fa21..c160e9b3aa0f 100644 >> --- a/fs/autofs4/waitq.c >> +++ b/fs/autofs4/waitq.c >> @@ -19,9 +19,6 @@ >> */ >> static autofs_wqt_t

Re: [PATCH] autofs4: Use wait_event_killable

2018-03-19 Thread Ian Kent
On 20/03/18 03:25, David Rientjes wrote: > On Mon, 19 Mar 2018, Matthew Wilcox wrote: > >> diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c >> index a0c57c37fa21..c160e9b3aa0f 100644 >> --- a/fs/autofs4/waitq.c >> +++ b/fs/autofs4/waitq.c >> @@ -19,9 +19,6 @@ >> */ >> static autofs_wqt_t

Re: [PATCH] autofs4: Use wait_event_killable

2018-03-19 Thread Ian Kent
ble is what was meant to happen here. Predates is an understatement, this is really, really old code. Do I need to forward this to Al or Andrew? > > Signed-off-by: Matthew Wilcox <mawil...@microsoft.com> Signed-off-by: Ian Kent <ra...@themaw.net> > --- > fs/autofs4/waitq.c | 27

Re: [PATCH] autofs4: Use wait_event_killable

2018-03-19 Thread Ian Kent
here. Predates is an understatement, this is really, really old code. Do I need to forward this to Al or Andrew? > > Signed-off-by: Matthew Wilcox Signed-off-by: Ian Kent > --- > fs/autofs4/waitq.c | 27 +-- > 1 file changed, 1 insertion(+), 26 deletions(-

Re: [ANNOUNCE] autofs 5.1.2 release

2018-01-17 Thread Ian Kent
On 21/12/17 09:09, NeilBrown wrote: > 8<--- > Subject: use_hostname_for_mounts shouldn't prevent selection among replica > > If several replicas have been specified for a mount point, and > use_hostname_for_mount is set to "yes", the selection between > these replicas is

Re: [ANNOUNCE] autofs 5.1.2 release

2018-01-17 Thread Ian Kent
On 21/12/17 09:09, NeilBrown wrote: > 8<--- > Subject: use_hostname_for_mounts shouldn't prevent selection among replica > > If several replicas have been specified for a mount point, and > use_hostname_for_mount is set to "yes", the selection between > these replicas is

Re: [ANNOUNCE] autofs 5.1.2 release

2018-01-17 Thread Ian Kent
On 03/01/18 06:14, NeilBrown wrote: > On Thu, Dec 21 2017, Ian Kent wrote: > >> On 21/12/17 19:06, Ian Kent wrote: >>> On 21/12/17 09:09, NeilBrown wrote: >>>> On Wed, Dec 20 2017, Ian Kent wrote: >>>> >>>>> On 20/12/17 13:5

Re: [ANNOUNCE] autofs 5.1.2 release

2018-01-17 Thread Ian Kent
On 03/01/18 06:14, NeilBrown wrote: > On Thu, Dec 21 2017, Ian Kent wrote: > >> On 21/12/17 19:06, Ian Kent wrote: >>> On 21/12/17 09:09, NeilBrown wrote: >>>> On Wed, Dec 20 2017, Ian Kent wrote: >>>> >>>>> On 20/12/17 13:5

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-21 Thread Ian Kent
On 21/12/17 19:06, Ian Kent wrote: > On 21/12/17 09:09, NeilBrown wrote: >> On Wed, Dec 20 2017, Ian Kent wrote: >> >>> On 20/12/17 13:52, Ian Kent wrote: >>>> On 20/12/17 11:29, NeilBrown wrote: >>>>> >>>>> Hi Ian, >>>&g

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-21 Thread Ian Kent
On 21/12/17 19:06, Ian Kent wrote: > On 21/12/17 09:09, NeilBrown wrote: >> On Wed, Dec 20 2017, Ian Kent wrote: >> >>> On 20/12/17 13:52, Ian Kent wrote: >>>> On 20/12/17 11:29, NeilBrown wrote: >>>>> >>>>> Hi Ian, >>>&g

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-21 Thread Ian Kent
On 21/12/17 09:09, NeilBrown wrote: > On Wed, Dec 20 2017, Ian Kent wrote: > >> On 20/12/17 13:52, Ian Kent wrote: >>> On 20/12/17 11:29, NeilBrown wrote: >>>> >>>> Hi Ian, >>>> I've been looking at: >>>> >>>>

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-21 Thread Ian Kent
On 21/12/17 09:09, NeilBrown wrote: > On Wed, Dec 20 2017, Ian Kent wrote: > >> On 20/12/17 13:52, Ian Kent wrote: >>> On 20/12/17 11:29, NeilBrown wrote: >>>> >>>> Hi Ian, >>>> I've been looking at: >>>> >>>>

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 13:52, Ian Kent wrote: > On 20/12/17 11:29, NeilBrown wrote: >> >> Hi Ian, >> I've been looking at: >> >>> - add configuration option to use fqdn in mounts. >> >> (commit 9aeef772604) because using this new option causes a regres

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 13:52, Ian Kent wrote: > On 20/12/17 11:29, NeilBrown wrote: >> >> Hi Ian, >> I've been looking at: >> >>> - add configuration option to use fqdn in mounts. >> >> (commit 9aeef772604) because using this new option causes a regres

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 14:10, Ian Kent wrote: > On 20/12/17 13:52, Ian Kent wrote: >> On 20/12/17 11:29, NeilBrown wrote: >>> >>> Hi Ian, >>> I've been looking at: >>> >>>> - add configuration option to use fqdn in mounts. >>> >>

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 14:10, Ian Kent wrote: > On 20/12/17 13:52, Ian Kent wrote: >> On 20/12/17 11:29, NeilBrown wrote: >>> >>> Hi Ian, >>> I've been looking at: >>> >>>> - add configuration option to use fqdn in mounts. >>> >>

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 13:52, Ian Kent wrote: > On 20/12/17 11:29, NeilBrown wrote: >> >> Hi Ian, >> I've been looking at: >> >>> - add configuration option to use fqdn in mounts. >> >> (commit 9aeef772604) because using this new option causes a regres

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 13:52, Ian Kent wrote: > On 20/12/17 11:29, NeilBrown wrote: >> >> Hi Ian, >> I've been looking at: >> >>> - add configuration option to use fqdn in mounts. >> >> (commit 9aeef772604) because using this new option causes a regres

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 11:29, NeilBrown wrote: > > Hi Ian, > I've been looking at: > >> - add configuration option to use fqdn in mounts. > > (commit 9aeef772604) because using this new option causes a regression. > If you are using the "replicated server" functionality, then > use_hostname_for_mounts

Re: [ANNOUNCE] autofs 5.1.2 release

2017-12-19 Thread Ian Kent
On 20/12/17 11:29, NeilBrown wrote: > > Hi Ian, > I've been looking at: > >> - add configuration option to use fqdn in mounts. > > (commit 9aeef772604) because using this new option causes a regression. > If you are using the "replicated server" functionality, then > use_hostname_for_mounts

Re: [ANNOUNCE] autofs 5.1.4 release

2017-12-19 Thread Ian Kent
On 19/12/17 17:45, Patrick Goetz wrote: > On 12/19/2017 02:29 AM, Ian Kent wrote: >> A new amd mount type has been added. The amd mount type "program" >> has been added which allows a user provided program to be given >> in a map entry that will be used for perform

Re: [ANNOUNCE] autofs 5.1.4 release

2017-12-19 Thread Ian Kent
On 19/12/17 17:45, Patrick Goetz wrote: > On 12/19/2017 02:29 AM, Ian Kent wrote: >> A new amd mount type has been added. The amd mount type "program" >> has been added which allows a user provided program to be given >> in a map entry that will be used for perform

[ANNOUNCE] autofs 5.1.4 release

2017-12-19 Thread Ian Kent
Hi all, It's finally time for a release, autofs-5.1.4. Unfortunately there were a couple of annoying regressions in 5.1.3. I believe they have been resolved in this release. Also, the startup retry on the master map not available logic has been improved so that should function properly now and

[ANNOUNCE] autofs 5.1.4 release

2017-12-19 Thread Ian Kent
Hi all, It's finally time for a release, autofs-5.1.4. Unfortunately there were a couple of annoying regressions in 5.1.3. I believe they have been resolved in this release. Also, the startup retry on the master map not available logic has been improved so that should function properly now and

Re: [PATCH 0/2] userns: automount cleanups

2017-11-30 Thread Ian Kent
On 30/11/17 13:21, Eric W. Biederman wrote: > Ian Kent <ra...@themaw.net> writes: > >> On 30/11/17 08:01, Eric W. Biederman wrote: >>> >>> While reviewing some code I realized that in getting d_automount working >>> with s_user_ns I had left behind so

Re: [PATCH 0/2] userns: automount cleanups

2017-11-30 Thread Ian Kent
On 30/11/17 13:21, Eric W. Biederman wrote: > Ian Kent writes: > >> On 30/11/17 08:01, Eric W. Biederman wrote: >>> >>> While reviewing some code I realized that in getting d_automount working >>> with s_user_ns I had left behind some unnecessary reli

Re: [PATCH 0/2] userns: automount cleanups

2017-11-29 Thread Ian Kent
On 30/11/17 08:01, Eric W. Biederman wrote: > > While reviewing some code I realized that in getting d_automount working > with s_user_ns I had left behind some unnecessary relics of the blind > path I started down. Here are two patches that remove those relics. > > Unless someone has another

Re: [PATCH 0/2] userns: automount cleanups

2017-11-29 Thread Ian Kent
On 30/11/17 08:01, Eric W. Biederman wrote: > > While reviewing some code I realized that in getting d_automount working > with s_user_ns I had left behind some unnecessary relics of the blind > path I started down. Here are two patches that remove those relics. > > Unless someone has another

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-29 Thread Ian Kent
On 29/11/17 15:39, NeilBrown wrote: > On Wed, Nov 29 2017, Ian Kent wrote: > >> On 29/11/17 11:45, NeilBrown wrote: >>> On Wed, Nov 29 2017, Ian Kent wrote: >>> >>>> Adding Al Viro to the Cc list as I believe Stephen Whitehouse and >>>>

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-29 Thread Ian Kent
On 29/11/17 15:39, NeilBrown wrote: > On Wed, Nov 29 2017, Ian Kent wrote: > >> On 29/11/17 11:45, NeilBrown wrote: >>> On Wed, Nov 29 2017, Ian Kent wrote: >>> >>>> Adding Al Viro to the Cc list as I believe Stephen Whitehouse and >>>>

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
On 29/11/17 11:45, NeilBrown wrote: > On Wed, Nov 29 2017, Ian Kent wrote: > >> Adding Al Viro to the Cc list as I believe Stephen Whitehouse and >> Al have discussed something similar, please feel free to chime in >> with your thoughts Al. >> >> On 29/11/1

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
On 29/11/17 11:45, NeilBrown wrote: > On Wed, Nov 29 2017, Ian Kent wrote: > >> Adding Al Viro to the Cc list as I believe Stephen Whitehouse and >> Al have discussed something similar, please feel free to chime in >> with your thoughts Al. >> >> On 29/11/1

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
On 29/11/17 10:48, NeilBrown wrote: > On Wed, Nov 29 2017, Ian Kent wrote: > >> On 29/11/17 10:13, Mike Marion wrote: >>> On Wed, Nov 29, 2017 at 12:17:27PM +1100, NeilBrown wrote: >>> >>>> How big do people see /proc/self/mount* getting? What size

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
On 29/11/17 10:48, NeilBrown wrote: > On Wed, Nov 29 2017, Ian Kent wrote: > >> On 29/11/17 10:13, Mike Marion wrote: >>> On Wed, Nov 29, 2017 at 12:17:27PM +1100, NeilBrown wrote: >>> >>>> How big do people see /proc/self/mount* getting? What size

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
Adding Al Viro to the Cc list as I believe Stephen Whitehouse and Al have discussed something similar, please feel free to chime in with your thoughts Al. On 29/11/17 09:17, NeilBrown wrote: > On Tue, Nov 28 2017, Mike Marion wrote: > >> On Tue, Nov 28, 2017 at 07:43:05AM +0800, Ia

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
Adding Al Viro to the Cc list as I believe Stephen Whitehouse and Al have discussed something similar, please feel free to chime in with your thoughts Al. On 29/11/17 09:17, NeilBrown wrote: > On Tue, Nov 28 2017, Mike Marion wrote: > >> On Tue, Nov 28, 2017 at 07:43:05AM +0800, Ia

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-28 Thread Ian Kent
On 29/11/17 10:13, Mike Marion wrote: > On Wed, Nov 29, 2017 at 12:17:27PM +1100, NeilBrown wrote: > >> How big do people see /proc/self/mount* getting? What size reads >> does 'strace' show the various programs using to read it? > > We already have line counts into 5 figures. This wasn't an

<    1   2   3   4   5   6   7   8   9   10   >