Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-25 Thread Lee Jones
On Thu, 25 Apr 2013, Linus Walleij wrote: > On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones wrote: > > > The current implementation of the DMA40's local MAX() macro evaluates > > its arguments more times than is necessary. This patch strips it > > optimises it to only evaluate what's appropriate. >

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-25 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones wrote: > The current implementation of the DMA40's local MAX() macro evaluates > its arguments more times than is necessary. This patch strips it > optimises it to only evaluate what's appropriate. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-25 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones lee.jo...@linaro.org wrote: The current implementation of the DMA40's local MAX() macro evaluates its arguments more times than is necessary. This patch strips it optimises it to only evaluate what's appropriate. Cc: Vinod Koul vinod.k...@intel.com

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-25 Thread Lee Jones
On Thu, 25 Apr 2013, Linus Walleij wrote: On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones lee.jo...@linaro.org wrote: The current implementation of the DMA40's local MAX() macro evaluates its arguments more times than is necessary. This patch strips it optimises it to only evaluate what's

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-22 Thread Lee Jones
On Mon, 22 Apr 2013, Vinod Koul wrote: > On Thu, Apr 18, 2013 at 11:11:50AM +0100, Lee Jones wrote: > > The current implementation of the DMA40's local MAX() macro evaluates > > its arguments more times than is necessary. This patch strips it > > optimises it to only evaluate what's appropriate.

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:11:50AM +0100, Lee Jones wrote: > The current implementation of the DMA40's local MAX() macro evaluates > its arguments more times than is necessary. This patch strips it > optimises it to only evaluate what's appropriate. > > Cc: Vinod Koul > Cc: Dan Williams > Cc:

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-22 Thread Vinod Koul
On Thu, Apr 18, 2013 at 11:11:50AM +0100, Lee Jones wrote: The current implementation of the DMA40's local MAX() macro evaluates its arguments more times than is necessary. This patch strips it optimises it to only evaluate what's appropriate. Cc: Vinod Koul vinod.k...@intel.com Cc: Dan

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-22 Thread Lee Jones
On Mon, 22 Apr 2013, Vinod Koul wrote: On Thu, Apr 18, 2013 at 11:11:50AM +0100, Lee Jones wrote: The current implementation of the DMA40's local MAX() macro evaluates its arguments more times than is necessary. This patch strips it optimises it to only evaluate what's appropriate.

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-18 Thread Arnd Bergmann
On Thursday 18 April 2013, Russell King - ARM Linux wrote: > Never got the original patch... > > A much better idea is to get rid of that buggy MAX() macro altogether > and use the macros already provided by the kernel, which are safe from > side effects - but more importantly are type _safe_.

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 12:46:03PM +0200, Arnd Bergmann wrote: > On Thursday 18 April 2013, Lee Jones wrote: > > The current implementation of the DMA40's local MAX() macro evaluates > > its arguments more times than is necessary. This patch strips it > > optimises it to only evaluate what's

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-18 Thread Arnd Bergmann
On Thursday 18 April 2013, Lee Jones wrote: > The current implementation of the DMA40's local MAX() macro evaluates > its arguments more times than is necessary. This patch strips it > optimises it to only evaluate what's appropriate. No, it does not. > index b21a8a3..7b451b2 100644 > ---

[PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-18 Thread Lee Jones
The current implementation of the DMA40's local MAX() macro evaluates its arguments more times than is necessary. This patch strips it optimises it to only evaluate what's appropriate. Cc: Vinod Koul Cc: Dan Williams Cc: Per Forlin Cc: Rabin Vincent Reported-by: Harvey Harrison

[PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-18 Thread Lee Jones
The current implementation of the DMA40's local MAX() macro evaluates its arguments more times than is necessary. This patch strips it optimises it to only evaluate what's appropriate. Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams d...@fb.com Cc: Per Forlin per.for...@stericsson.com Cc:

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-18 Thread Arnd Bergmann
On Thursday 18 April 2013, Lee Jones wrote: The current implementation of the DMA40's local MAX() macro evaluates its arguments more times than is necessary. This patch strips it optimises it to only evaluate what's appropriate. No, it does not. index b21a8a3..7b451b2 100644 ---

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 12:46:03PM +0200, Arnd Bergmann wrote: On Thursday 18 April 2013, Lee Jones wrote: The current implementation of the DMA40's local MAX() macro evaluates its arguments more times than is necessary. This patch strips it optimises it to only evaluate what's appropriate.

Re: [PATCH 08/32] dmaengine: ste_dma40: Optimise local MAX() macro

2013-04-18 Thread Arnd Bergmann
On Thursday 18 April 2013, Russell King - ARM Linux wrote: Never got the original patch... A much better idea is to get rid of that buggy MAX() macro altogether and use the macros already provided by the kernel, which are safe from side effects - but more importantly are type _safe_. The