[PATCH 3.16 06/61] slip: not call free_netdev before rtnl_unlock in slip_open

[Ben Hutchings]

3.16.85-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: yangerkun <yanger...@huawei.com>

commit f596c87005f7b1baeb7d62d9a9e25d68c3dfae10 upstream.

As the description before netdev_run_todo, we cannot call free_netdev
before rtnl_unlock, fix it by reorder the code.

Signed-off-by: yangerkun <yanger...@huawei.com>
Reviewed-by: Oliver Hartkopp <socket...@hartkopp.net>
Signed-off-by: David S. Miller <da...@davemloft.net>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <b...@decadent.org.uk>
---
 drivers/net/slip/slip.c | 3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/net/slip/slip.c
+++ b/drivers/net/slip/slip.c
@@ -867,7 +867,10 @@ err_free_chan:
        sl->tty = NULL;
        tty->disc_data = NULL;
        clear_bit(SLF_INUSE, &sl->flags);
+       /* do not call free_netdev before rtnl_unlock */
+       rtnl_unlock();
        sl_free_netdev(sl->dev);
+       return err;
 
 err_exit:
        rtnl_unlock();