Re: [PATCH 5/4] futex: silence uninitialized warnings

2014-01-06 Thread Davidlohr Bueso
On Tue, 2014-01-07 at 10:55 +0800, Linus Torvalds wrote: > On Mon, Jan 6, 2014 at 9:38 AM, Davidlohr Bueso wrote: > > { > > int lock_taken, ret, force_take = 0; > > - u32 uval, newval, curval, vpid = task_pid_vnr(task); > > + u32 uval, newval, uninitialized_var(curval), vpid

Re: [PATCH 5/4] futex: silence uninitialized warnings

2014-01-06 Thread Linus Torvalds
On Mon, Jan 6, 2014 at 9:38 AM, Davidlohr Bueso wrote: > { > int lock_taken, ret, force_take = 0; > - u32 uval, newval, curval, vpid = task_pid_vnr(task); > + u32 uval, newval, uninitialized_var(curval), vpid = > task_pid_vnr(task); Do you have some broken compiler? I

Re: [PATCH 5/4] futex: silence uninitialized warnings

2014-01-06 Thread Darren Hart
On Sun, 2014-01-05 at 17:38 -0800, Davidlohr Bueso wrote: > From: Davidlohr Bueso > > Callers of cmpxchg_futex_value_locked() can trigger the following: > > kernel/futex.c: In function ‘futex_lock_pi_atomic’: > kernel/futex.c:725: warning: ‘curval’ may be used uninitialized in this > function

Re: [PATCH 5/4] futex: silence uninitialized warnings

2014-01-06 Thread Darren Hart
On Sun, 2014-01-05 at 17:38 -0800, Davidlohr Bueso wrote: From: Davidlohr Bueso davidl...@hp.com Callers of cmpxchg_futex_value_locked() can trigger the following: kernel/futex.c: In function ‘futex_lock_pi_atomic’: kernel/futex.c:725: warning: ‘curval’ may be used uninitialized in this

Re: [PATCH 5/4] futex: silence uninitialized warnings

2014-01-06 Thread Linus Torvalds
On Mon, Jan 6, 2014 at 9:38 AM, Davidlohr Bueso davidl...@hp.com wrote: { int lock_taken, ret, force_take = 0; - u32 uval, newval, curval, vpid = task_pid_vnr(task); + u32 uval, newval, uninitialized_var(curval), vpid = task_pid_vnr(task); Do you have some broken

Re: [PATCH 5/4] futex: silence uninitialized warnings

2014-01-06 Thread Davidlohr Bueso
On Tue, 2014-01-07 at 10:55 +0800, Linus Torvalds wrote: On Mon, Jan 6, 2014 at 9:38 AM, Davidlohr Bueso davidl...@hp.com wrote: { int lock_taken, ret, force_take = 0; - u32 uval, newval, curval, vpid = task_pid_vnr(task); + u32 uval, newval,

[PATCH 5/4] futex: silence uninitialized warnings

2014-01-05 Thread Davidlohr Bueso
From: Davidlohr Bueso Callers of cmpxchg_futex_value_locked() can trigger the following: kernel/futex.c: In function ‘futex_lock_pi_atomic’: kernel/futex.c:725: warning: ‘curval’ may be used uninitialized in this function This was initially addressed by commit 7cfdaf38, but others still

[PATCH 5/4] futex: silence uninitialized warnings

2014-01-05 Thread Davidlohr Bueso
From: Davidlohr Bueso davidl...@hp.com Callers of cmpxchg_futex_value_locked() can trigger the following: kernel/futex.c: In function ‘futex_lock_pi_atomic’: kernel/futex.c:725: warning: ‘curval’ may be used uninitialized in this function This was initially addressed by commit 7cfdaf38, but