Re: [PATCH net-next v3 2/2] net: phy: tja11xx: add support for master-slave configuration

On Wed, Apr 29, 2020 at 08:20:53PM +0200, Andrew Lunn wrote: > > +static int tja11xx_config_aneg(struct phy_device *phydev) > > +{ > > + u16 ctl = 0; > > + int ret; > > + > > + switch (phydev->master_slave_set) { > > + case PORT_MODE_CFG_MASTER_FORCE: > > + case

Re: [PATCH net-next v3 2/2] net: phy: tja11xx: add support for master-slave configuration

> +static int tja11xx_config_aneg(struct phy_device *phydev) > +{ > + u16 ctl = 0; > + int ret; > + > + switch (phydev->master_slave_set) { > + case PORT_MODE_CFG_MASTER_FORCE: > + case PORT_MODE_CFG_MASTER_PREFERRED: > + ctl |= MII_CFG1_MASTER_SLAVE; > +

[PATCH net-next v3 2/2] net: phy: tja11xx: add support for master-slave configuration

The TJA11xx PHYs have a vendor specific Master/Slave configuration bit, which is not compatible with IEEE 803.2-2018 spec for 100Base-T1 devices. So, provide a custom config_ange call back to solve this problem. Signed-off-by: Oleksij Rempel --- drivers/net/phy/nxp-tja11xx.c | 58