Re: [PATCH v1 2/4] firmware loader: simplify holding module for request_firmware

2014-01-07 Thread Dmitry Torokhov
On Tue, Jan 07, 2014 at 10:53:57PM +0800, Ming Lei wrote: > Hi Dmitry, > > On Tue, Jan 7, 2014 at 3:56 PM, Dmitry Torokhov > wrote: > > Hi Ming, > > > > On Thu, Jun 06, 2013 at 08:01:48PM +0800, Ming Lei wrote: > >> module reference doesn't cover direct loading path, so this patch > >> simply

Re: [PATCH v1 2/4] firmware loader: simplify holding module for request_firmware

2014-01-07 Thread Ming Lei
Hi Dmitry, On Tue, Jan 7, 2014 at 3:56 PM, Dmitry Torokhov wrote: > Hi Ming, > > On Thu, Jun 06, 2013 at 08:01:48PM +0800, Ming Lei wrote: >> module reference doesn't cover direct loading path, so this patch >> simply holds the module in the whole life time of request_firmware() >> to fix the

Re: [PATCH v1 2/4] firmware loader: simplify holding module for request_firmware

2014-01-07 Thread Ming Lei
Hi Dmitry, On Tue, Jan 7, 2014 at 3:56 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Ming, On Thu, Jun 06, 2013 at 08:01:48PM +0800, Ming Lei wrote: module reference doesn't cover direct loading path, so this patch simply holds the module in the whole life time of

Re: [PATCH v1 2/4] firmware loader: simplify holding module for request_firmware

2014-01-07 Thread Dmitry Torokhov
On Tue, Jan 07, 2014 at 10:53:57PM +0800, Ming Lei wrote: Hi Dmitry, On Tue, Jan 7, 2014 at 3:56 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Ming, On Thu, Jun 06, 2013 at 08:01:48PM +0800, Ming Lei wrote: module reference doesn't cover direct loading path, so this patch

Re: [PATCH v1 2/4] firmware loader: simplify holding module for request_firmware

2014-01-06 Thread Dmitry Torokhov
Hi Ming, On Thu, Jun 06, 2013 at 08:01:48PM +0800, Ming Lei wrote: > module reference doesn't cover direct loading path, so this patch > simply holds the module in the whole life time of request_firmware() > to fix the problem. This does not make sense to me. If request_firmware() is executing

Re: [PATCH v1 2/4] firmware loader: simplify holding module for request_firmware

2014-01-06 Thread Dmitry Torokhov
Hi Ming, On Thu, Jun 06, 2013 at 08:01:48PM +0800, Ming Lei wrote: module reference doesn't cover direct loading path, so this patch simply holds the module in the whole life time of request_firmware() to fix the problem. This does not make sense to me. If request_firmware() is executing that

[PATCH v1 2/4] firmware loader: simplify holding module for request_firmware

2013-06-06 Thread Ming Lei
module reference doesn't cover direct loading path, so this patch simply holds the module in the whole life time of request_firmware() to fix the problem. Signed-off-by: Ming Lei --- drivers/base/firmware_class.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

[PATCH v1 2/4] firmware loader: simplify holding module for request_firmware

2013-06-06 Thread Ming Lei
module reference doesn't cover direct loading path, so this patch simply holds the module in the whole life time of request_firmware() to fix the problem. Signed-off-by: Ming Lei ming@canonical.com --- drivers/base/firmware_class.c | 13 +++-- 1 file changed, 7 insertions(+), 6