Re: [PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

2018-12-04 Thread Florian Eckert
/* * Multi-line comments * have this style */ fixed +#include kbuild bot complains for absence of #include here. fixed +static int gpio_apu_get_dir(struct gpio_chip *chip, unsigned int offset) +{ + u32 val; + struct apu_gpio_pdata *apu_gpio =

Re: [PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

2018-12-04 Thread Florian Eckert
/* * Multi-line comments * have this style */ fixed +#include kbuild bot complains for absence of #include here. fixed +static int gpio_apu_get_dir(struct gpio_chip *chip, unsigned int offset) +{ + u32 val; + struct apu_gpio_pdata *apu_gpio =

Re: [PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

2018-11-28 Thread Andy Shevchenko
On Tue, Nov 27, 2018 at 3:25 PM Florian Eckert wrote: > > Add a new device driver "gpio-apu" which will handle the GPIOs on APU2 > and APU3 devices from PC Engines. > > APU2 (https://pcengines.ch/schema/apu2c.pdf page 7): > - G32 is "button_reset" connected to the smd-button on the frontpanel > -

Re: [PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

2018-11-28 Thread Andy Shevchenko
On Tue, Nov 27, 2018 at 3:25 PM Florian Eckert wrote: > > Add a new device driver "gpio-apu" which will handle the GPIOs on APU2 > and APU3 devices from PC Engines. > > APU2 (https://pcengines.ch/schema/apu2c.pdf page 7): > - G32 is "button_reset" connected to the smd-button on the frontpanel > -

Re: [PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

2018-11-27 Thread kbuild test robot
Hi Florian, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.20-rc4 next-20181127] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

2018-11-27 Thread kbuild test robot
Hi Florian, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.20-rc4 next-20181127] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

2018-11-27 Thread Florian Eckert
Add a new device driver "gpio-apu" which will handle the GPIOs on APU2 and APU3 devices from PC Engines. APU2 (https://pcengines.ch/schema/apu2c.pdf page 7): - G32 is "button_reset" connected to the smd-button on the frontpanel - G50 is "mpcie2_reset" connected to mPCIe2 reset line - G51 is

[PATCH v5 1/2] gpio: Add driver for PC Engines APU boards

2018-11-27 Thread Florian Eckert
Add a new device driver "gpio-apu" which will handle the GPIOs on APU2 and APU3 devices from PC Engines. APU2 (https://pcengines.ch/schema/apu2c.pdf page 7): - G32 is "button_reset" connected to the smd-button on the frontpanel - G50 is "mpcie2_reset" connected to mPCIe2 reset line - G51 is