Re: [RFC] QoS params patch

2007-10-01 Thread Mark Gross
On Fri, Sep 28, 2007 at 11:51:41AM -0700, Andrew Morton wrote: > On Fri, 28 Sep 2007 10:19:21 -0700 Mark Gross <[EMAIL PROTECTED]> wrote: > > > On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: > > > On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross <[EMAIL PROTECTED]> wrote: > > > > >

Re: [RFC] QoS params patch

2007-10-01 Thread Mark Gross
On Fri, Sep 28, 2007 at 11:51:41AM -0700, Andrew Morton wrote: On Fri, 28 Sep 2007 10:19:21 -0700 Mark Gross [EMAIL PROTECTED] wrote: On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross [EMAIL PROTECTED] wrote: +#define

Re: [RFC] QoS params patch

2007-09-28 Thread Andrew Morton
On Fri, 28 Sep 2007 10:19:21 -0700 Mark Gross <[EMAIL PROTECTED]> wrote: > On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: > > On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross <[EMAIL PROTECTED]> wrote: > > > > > +#define QOS_RESERVED 0 > > > +#define QOS_CPU_DMA_LATENCY 1 > > >

Re: [RFC] QoS params patch

2007-09-28 Thread Mark Gross
On Fri, Sep 28, 2007 at 03:41:13PM +0900, Paul Mundt wrote: > On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: > > On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross <[EMAIL PROTECTED]> wrote: > > > +int qos_add_requirement(int qos, char *name, s32 value); > > > +int

Re: [RFC] QoS params patch

2007-09-28 Thread Mark Gross
On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: > On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross <[EMAIL PROTECTED]> wrote: > > > +#define QOS_RESERVED 0 > > +#define QOS_CPU_DMA_LATENCY 1 > > +#define QOS_NETWORK_LATENCY 2 > > +#define QOS_NETWORK_THROUGHPUT 3 > > + > > +#define

Re: [RFC] QoS params patch

2007-09-28 Thread Paul Mundt
On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: > On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross <[EMAIL PROTECTED]> wrote: > > +int qos_add_requirement(int qos, char *name, s32 value); > > +int qos_update_requirement(int qos, char *name, s32 new_value); > > +void

Re: [RFC] QoS params patch

2007-09-28 Thread Andrew Morton
On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross <[EMAIL PROTECTED]> wrote: > +#define QOS_RESERVED 0 > +#define QOS_CPU_DMA_LATENCY 1 > +#define QOS_NETWORK_LATENCY 2 > +#define QOS_NETWORK_THROUGHPUT 3 > + > +#define QOS_NUM_CLASSES 4 > +#define QOS_DEFAULT_VALUE -1 > + > +int

Re: [RFC] QoS params patch

2007-09-28 Thread Andrew Morton
On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross [EMAIL PROTECTED] wrote: +#define QOS_RESERVED 0 +#define QOS_CPU_DMA_LATENCY 1 +#define QOS_NETWORK_LATENCY 2 +#define QOS_NETWORK_THROUGHPUT 3 + +#define QOS_NUM_CLASSES 4 +#define QOS_DEFAULT_VALUE -1 + +int qos_add_requirement(int qos,

Re: [RFC] QoS params patch

2007-09-28 Thread Paul Mundt
On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross [EMAIL PROTECTED] wrote: +int qos_add_requirement(int qos, char *name, s32 value); +int qos_update_requirement(int qos, char *name, s32 new_value); +void qos_remove_requirement(int

Re: [RFC] QoS params patch

2007-09-28 Thread Mark Gross
On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross [EMAIL PROTECTED] wrote: +#define QOS_RESERVED 0 +#define QOS_CPU_DMA_LATENCY 1 +#define QOS_NETWORK_LATENCY 2 +#define QOS_NETWORK_THROUGHPUT 3 + +#define QOS_NUM_CLASSES 4

Re: [RFC] QoS params patch

2007-09-28 Thread Mark Gross
On Fri, Sep 28, 2007 at 03:41:13PM +0900, Paul Mundt wrote: On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross [EMAIL PROTECTED] wrote: +int qos_add_requirement(int qos, char *name, s32 value); +int qos_update_requirement(int qos,

Re: [RFC] QoS params patch

2007-09-28 Thread Andrew Morton
On Fri, 28 Sep 2007 10:19:21 -0700 Mark Gross [EMAIL PROTECTED] wrote: On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross [EMAIL PROTECTED] wrote: +#define QOS_RESERVED 0 +#define QOS_CPU_DMA_LATENCY 1 +#define

Re: [RFC] QoS params patch update.

2007-09-27 Thread Paul Mundt
On Thu, Sep 27, 2007 at 01:17:39PM -0700, Mark Gross wrote: > Updated qos PM parameter patch: > Note: the replacing of latency.c with this is a separate patch. > > this patch attempts to address the issues raised so far. > [snip] > +static int register_new_qos_misc(struct qos_object *qos) > +{

Re: [RFC] QoS params patch update.

2007-09-27 Thread Mark Gross
On Wed, Sep 26, 2007 at 09:05:15PM -0700, Randy Dunlap wrote: > On Thu, 27 Sep 2007 11:24:40 +0900 Paul Mundt wrote: > > > > +/* static helper functions */ > > > +static s32 max_compare(s32 v1, s32 v2) > > > +{ > > > + if (v1 < v2) > > > + return v2; > > > + else > > > + return

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Thu, Sep 27, 2007 at 11:24:40AM +0900, Paul Mundt wrote: > On Wed, Sep 26, 2007 at 03:40:26PM -0700, Mark Gross wrote: > > + struct list_head list; > > + union { > > + s32 value; > > + s32 usec; > > + s32 kbps; > > + }; > > + char *name; > > Your }

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Wed, Sep 26, 2007 at 09:05:15PM -0700, Randy Dunlap wrote: > On Thu, 27 Sep 2007 11:24:40 +0900 Paul Mundt wrote: > > > > +/* static helper functions */ > > > +static s32 max_compare(s32 v1, s32 v2) > > > +{ > > > + if (v1 < v2) > > > + return v2; > > > + else > > > + return

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Wed, Sep 26, 2007 at 10:53:03PM -0400, [EMAIL PROTECTED] wrote: > On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: > (others here are probably better at spotting leaks and races than I am, > so I'm skipping those and picking other nits. ;) > > > --- linux-2.6.23-rc8/kernel/Makefile

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Thu, Sep 27, 2007 at 12:18:21PM +0900, Paul Mundt wrote: > On Wed, Sep 26, 2007 at 10:53:03PM -0400, [EMAIL PROTECTED] wrote: > > On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: > > > --- linux-2.6.23-rc8/kernel/Makefile 2007-09-26 13:54:54.0 > > > -0700 > > > +++

Re: [RFC] QoS params patch

2007-09-27 Thread roel
Mark Gross wrote: > On Wed, Sep 26, 2007 at 04:41:59PM -0700, Randy Dunlap wrote: >> On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross wrote: >> >>> The following is the qos_param patch that implements a genralization of >>> latency.c. >>> >> Just some general comments (as on irc): >> >> - use

Re: [RFC] QoS params patch

2007-09-27 Thread roel
Mark Gross wrote: On Wed, Sep 26, 2007 at 04:41:59PM -0700, Randy Dunlap wrote: On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross wrote: The following is the qos_param patch that implements a genralization of latency.c. Just some general comments (as on irc): - use 'diffstat -p1 -w70' to

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Thu, Sep 27, 2007 at 12:18:21PM +0900, Paul Mundt wrote: On Wed, Sep 26, 2007 at 10:53:03PM -0400, [EMAIL PROTECTED] wrote: On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: --- linux-2.6.23-rc8/kernel/Makefile 2007-09-26 13:54:54.0 -0700 +++

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Wed, Sep 26, 2007 at 10:53:03PM -0400, [EMAIL PROTECTED] wrote: On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: (others here are probably better at spotting leaks and races than I am, so I'm skipping those and picking other nits. ;) --- linux-2.6.23-rc8/kernel/Makefile

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Wed, Sep 26, 2007 at 09:05:15PM -0700, Randy Dunlap wrote: On Thu, 27 Sep 2007 11:24:40 +0900 Paul Mundt wrote: +/* static helper functions */ +static s32 max_compare(s32 v1, s32 v2) +{ + if (v1 v2) + return v2; + else + return v1; +} + +static

Re: [RFC] QoS params patch

2007-09-27 Thread Mark Gross
On Thu, Sep 27, 2007 at 11:24:40AM +0900, Paul Mundt wrote: On Wed, Sep 26, 2007 at 03:40:26PM -0700, Mark Gross wrote: + struct list_head list; + union { + s32 value; + s32 usec; + s32 kbps; + }; + char *name; Your } is in a strange

Re: [RFC] QoS params patch update.

2007-09-27 Thread Mark Gross
On Wed, Sep 26, 2007 at 09:05:15PM -0700, Randy Dunlap wrote: On Thu, 27 Sep 2007 11:24:40 +0900 Paul Mundt wrote: +/* static helper functions */ +static s32 max_compare(s32 v1, s32 v2) +{ + if (v1 v2) + return v2; + else + return v1; +} + +static

Re: [RFC] QoS params patch update.

2007-09-27 Thread Paul Mundt
On Thu, Sep 27, 2007 at 01:17:39PM -0700, Mark Gross wrote: Updated qos PM parameter patch: Note: the replacing of latency.c with this is a separate patch. this patch attempts to address the issues raised so far. [snip] +static int register_new_qos_misc(struct qos_object *qos) +{ +

Re: [RFC] QoS params patch

2007-09-26 Thread Randy Dunlap
On Thu, 27 Sep 2007 11:24:40 +0900 Paul Mundt wrote: > > +/* static helper functions */ > > +static s32 max_compare(s32 v1, s32 v2) > > +{ > > + if (v1 < v2) > > + return v2; > > + else > > + return v1; > > +} > > + > > +static s32 min_compare(s32 v1, s32 v2) > > +{ > > +

Re: [RFC] QoS params patch

2007-09-26 Thread Paul Mundt
On Wed, Sep 26, 2007 at 10:53:03PM -0400, [EMAIL PROTECTED] wrote: > On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: > > --- linux-2.6.23-rc8/kernel/Makefile2007-09-26 13:54:54.0 > > -0700 > > +++ linux-2.6.23-rc8-qos/kernel/Makefile2007-09-26 14:06:38.0 - > 0700 >

Re: [RFC] QoS params patch

2007-09-26 Thread Valdis . Kletnieks
On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: (others here are probably better at spotting leaks and races than I am, so I'm skipping those and picking other nits. ;) > --- linux-2.6.23-rc8/kernel/Makefile 2007-09-26 13:54:54.0 -0700 > +++ linux-2.6.23-rc8-qos/kernel/Makefile

Re: [RFC] QoS params patch

2007-09-26 Thread Paul Mundt
On Wed, Sep 26, 2007 at 03:40:26PM -0700, Mark Gross wrote: > + struct list_head list; > + union { > + s32 value; > + s32 usec; > + s32 kbps; > + }; > + char *name; Your } is in a strange place. It looks like it wants to join its friends

Re: [RFC] QoS params patch

2007-09-26 Thread Mark Gross
On Wed, Sep 26, 2007 at 04:41:59PM -0700, Randy Dunlap wrote: > On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross wrote: > > > The following is the qos_param patch that implements a genralization of > > latency.c. > > > > Just some general comments (as on irc): > > - use 'diffstat -p1 -w70' to

Re: [RFC] QoS params patch

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross wrote: > The following is the qos_param patch that implements a genralization of > latency.c. > Just some general comments (as on irc): - use 'diffstat -p1 -w70' to summarize each patch - use checkpatch.pl to check for coding style and other

Re: [RFC] QoS params patch

2007-09-26 Thread Mark Gross
The following is the qos_param patch that implements a genralization of latency.c. Signed-off-by: Mark Gross <[EMAIL PROTECTED]> diff -urN -X linux-2.6.23-rc8/Documentation/dontdiff linux-2.6.23-rc8/include/linux/qos_params.h linux-2.6.23-rc8-qos/include/linux/qos_params.h ---

Re: [RFC] QoS params patch

2007-09-26 Thread Mark Gross
The following is the qos_param patch that implements a genralization of latency.c. Signed-off-by: Mark Gross [EMAIL PROTECTED] diff -urN -X linux-2.6.23-rc8/Documentation/dontdiff linux-2.6.23-rc8/include/linux/qos_params.h linux-2.6.23-rc8-qos/include/linux/qos_params.h ---

Re: [RFC] QoS params patch

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross wrote: The following is the qos_param patch that implements a genralization of latency.c. Just some general comments (as on irc): - use 'diffstat -p1 -w70' to summarize each patch - use checkpatch.pl to check for coding style and other buglets -

Re: [RFC] QoS params patch

2007-09-26 Thread Mark Gross
On Wed, Sep 26, 2007 at 04:41:59PM -0700, Randy Dunlap wrote: On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross wrote: The following is the qos_param patch that implements a genralization of latency.c. Just some general comments (as on irc): - use 'diffstat -p1 -w70' to summarize each

Re: [RFC] QoS params patch

2007-09-26 Thread Paul Mundt
On Wed, Sep 26, 2007 at 03:40:26PM -0700, Mark Gross wrote: + struct list_head list; + union { + s32 value; + s32 usec; + s32 kbps; + }; + char *name; Your } is in a strange place. It looks like it wants to join its friends closer

Re: [RFC] QoS params patch

2007-09-26 Thread Valdis . Kletnieks
On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: (others here are probably better at spotting leaks and races than I am, so I'm skipping those and picking other nits. ;) --- linux-2.6.23-rc8/kernel/Makefile 2007-09-26 13:54:54.0 -0700 +++ linux-2.6.23-rc8-qos/kernel/Makefile

Re: [RFC] QoS params patch

2007-09-26 Thread Paul Mundt
On Wed, Sep 26, 2007 at 10:53:03PM -0400, [EMAIL PROTECTED] wrote: On Wed, 26 Sep 2007 17:40:20 PDT, Mark Gross said: --- linux-2.6.23-rc8/kernel/Makefile2007-09-26 13:54:54.0 -0700 +++ linux-2.6.23-rc8-qos/kernel/Makefile2007-09-26 14:06:38.0 - 0700 @@ -9,7

Re: [RFC] QoS params patch

2007-09-26 Thread Randy Dunlap
On Thu, 27 Sep 2007 11:24:40 +0900 Paul Mundt wrote: +/* static helper functions */ +static s32 max_compare(s32 v1, s32 v2) +{ + if (v1 v2) + return v2; + else + return v1; +} + +static s32 min_compare(s32 v1, s32 v2) +{ + if (v1 v2) +