Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-16 Thread Raghavendra K T
On 07/13/2012 07:24 PM, Srikar Dronamraju wrote: On 12/07/12 21:18, Raghavendra K T wrote: +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT [...] + struct { + bool cpu_relax_intercepted; + bool dy_eligible; + } ple; +#endif [...] }

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-16 Thread Raghavendra K T
On 07/13/2012 07:24 PM, Srikar Dronamraju wrote: On 12/07/12 21:18, Raghavendra K T wrote: +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT [...] + struct { + bool cpu_relax_intercepted; + bool dy_eligible; + } ple; +#endif [...] } vcpu-run

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-13 Thread Srikar Dronamraju
> On 12/07/12 21:18, Raghavendra K T wrote: > > +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT > [...] > > + struct { > > + bool cpu_relax_intercepted; > > + bool dy_eligible; > > + } ple; > > +#endif > [...] > > } > > vcpu->run = page_address(page); > > +

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-13 Thread Raghavendra K T
On 07/13/2012 11:43 AM, Christian Borntraeger wrote: On 13/07/12 05:35, Raghavendra K T wrote: maybe define static inline access functions in kvm_host.h that are no-ops if CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT is not set. As I already said, can you have a look at using access functions? Yes.

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-13 Thread Christian Borntraeger
On 13/07/12 05:35, Raghavendra K T wrote: > Yes! I forgot about archs in init function. > How about having > #ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT > vcpu->ple.cpu_relax_intercepted = false; > vcpu->ple.dy_eligible = false; > #endif > > This would solve all the problem. No, you need to mask

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-13 Thread Christian Borntraeger
On 13/07/12 05:35, Raghavendra K T wrote: Yes! I forgot about archs in init function. How about having #ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT vcpu-ple.cpu_relax_intercepted = false; vcpu-ple.dy_eligible = false; #endif This would solve all the problem. No, you need to mask all

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-13 Thread Raghavendra K T
On 07/13/2012 11:43 AM, Christian Borntraeger wrote: On 13/07/12 05:35, Raghavendra K T wrote: maybe define static inline access functions in kvm_host.h that are no-ops if CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT is not set. As I already said, can you have a look at using access functions? Yes.

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-13 Thread Srikar Dronamraju
On 12/07/12 21:18, Raghavendra K T wrote: +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT [...] + struct { + bool cpu_relax_intercepted; + bool dy_eligible; + } ple; +#endif [...] } vcpu-run = page_address(page); + vcpu-ple.cpu_relax_intercepted =

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-12 Thread Raghavendra K T
On 07/13/2012 01:32 AM, Christian Borntraeger wrote: On 12/07/12 21:18, Raghavendra K T wrote: +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT [...] + struct { + bool cpu_relax_intercepted; + bool dy_eligible; + } ple; +#endif [...] }

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-12 Thread Christian Borntraeger
On 12/07/12 21:18, Raghavendra K T wrote: > +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT [...] > + struct { > + bool cpu_relax_intercepted; > + bool dy_eligible; > + } ple; > +#endif [...] > } > vcpu->run = page_address(page); > +

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-12 Thread Raghavendra K T
On 07/13/2012 01:32 AM, Christian Borntraeger wrote: On 12/07/12 21:18, Raghavendra K T wrote: +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT [...] + struct { + bool cpu_relax_intercepted; + bool dy_eligible; + } ple; +#endif [...] }

Re: [PATCH RFC V3 2/3] kvm: Note down when cpu relax intercepted or pause loop exited

2012-07-12 Thread Christian Borntraeger
On 12/07/12 21:18, Raghavendra K T wrote: +#ifdef CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT [...] + struct { + bool cpu_relax_intercepted; + bool dy_eligible; + } ple; +#endif [...] } vcpu-run = page_address(page); + vcpu-ple.cpu_relax_intercepted