Re: [PATCH] gfs2: Remove unneeded return variable

2021-03-03 Thread Bob Peterson
- Original Message - > This patch removes unneeded return variables, using only > '0' instead. > It fixes the following warning detected by coccinelle: > ./fs/gfs2/super.c:592:5-10: Unneeded variable: "error". Return "0" on > line 628 > > Reported-by: Abaci Robot > Signed-off-by: Yang Li

Re: [RFC v2 1/2] cgroup: sev: Add misc cgroup controller

2021-03-03 Thread Tejun Heo
Hello, On Tue, Mar 02, 2021 at 12:17:04AM -0800, Vipin Sharma wrote: > +/** > + * struct misc_res: Per cgroup per misc type resource > + * @max: Maximum count of the resource. > + * @usage: Current usage of the resource. > + */ > +struct misc_res { > + unsigned int max; > + atomic_t

RE: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

2021-03-03 Thread Don.Brace
-Original Message- From: Sergei Trofimovich [mailto:sly...@gmail.com] Sent: Tuesday, March 2, 2021 6:23 PM To: John Paul Adrian Glaubitz ; Don Brace - C33706 Cc: linux-i...@vger.kernel.org; linux-kernel@vger.kernel.org; Joe Szczypek ; Scott Benesh - C33703 ; Scott Teel - C33730 ;

KASAN: use-after-free Write in cipso_v4_doi_putdef

2021-03-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:7a7fd0de Merge branch 'kmap-conversion-for-5.12' of git://.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=164a74dad0 kernel config: https://syzkaller.appspot.com/x/.config?x=779a2568b654c1c6

Re: [PATCH] perf metric: remove unneeded semicolon

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 25, 2021 at 02:07:00PM +0800, Jiapeng Chong escreveu: > Fix the following coccicheck warnings: > > ./tools/perf/tests/parse-metric.c:101:2-3: Unneeded semicolon. Thanks, applied. - Arnaldo > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- >

[GIT PULL] TPM DEVICE DRIVER changes for v5.12-rc2

2021-03-03 Thread Jarkko Sakkinen
Hi Linus, Three urgent fixes for rc2. /Jarkko The following changes since commit c03c21ba6f4e95e406a1a7b4c34ef334b977c194: Merge tag 'keys-misc-20210126' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs (2021-02-23 16:09:23 -0800) are available in the Git repository at:

Re: exec error: BUG: Bad rss-counter

2021-03-03 Thread Ilya Lipnitskiy
On Wed, Mar 3, 2021 at 7:50 AM Eric W. Biederman wrote: > > Ilya Lipnitskiy writes: > > > On Tue, Mar 2, 2021 at 11:37 AM Eric W. Biederman > > wrote: > >> > >> Ilya Lipnitskiy writes: > >> > >> > On Mon, Mar 1, 2021 at 12:43 PM Eric W. Biederman > >> > wrote: > >> >> > >> >> Ilya

Re: [PATCH 1/2] perf archive: Fix filtering of empty build-ids

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2021 at 02:50:20PM +0100, Jiri Olsa escreveu: > On Fri, Feb 19, 2021 at 11:09:32AM -0500, Nicholas Fraser wrote: > > A non-existent build-id used to be treated as all-zero SHA-1 hash. > > Build-ids are now variable width. A non-existent build-id is an empty > > string and "perf

Re: [PATCH 2/2] mm: fs: Invalidate BH LRU during page migration

2021-03-03 Thread kernel test robot
Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on linux/master linus/master v5.12-rc1 next-20210303] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH] docs: conf.py: adjust the LaTeX document output

2021-03-03 Thread Mauro Carvalho Chehab
Changeset f546ff0c0c07 ("Move our minimum Sphinx version to 1.7") cleaned up some compatibility issues with previous Sphinx versions, but it also dropped the PDF margin sets. Without that, the media documentation won't build fine, as the margins are too wide to display texts with monospaced

Re: [RFC PATCH 15/18] cgroup: Introduce ioasids controller

2021-03-03 Thread Tejun Heo
On Sat, Feb 27, 2021 at 02:01:23PM -0800, Jacob Pan wrote: > IOASIDs are used to associate DMA requests with virtual address spaces. > They are a system-wide limited resource made available to the userspace > applications. Let it be VMs or user-space device drivers. > > This RFC patch introduces

Re: [PATCH] iwlwifi: fix ARCH=i386 compilation warnings

2021-03-03 Thread Kalle Valo
Pierre-Louis Bossart wrote: > An unsigned long variable should rely on '%lu' format strings, not '%zd' > > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI") > Signed-off-by: Pierre-Louis Bossart > Acked-by: Luca Coelho Patch applied to wireless-drivers.git, thanks.

Re: [External] Re: [PATCH v2 4/4] psi: Optimize task switch inside shared cgroups

2021-03-03 Thread Muchun Song
On Wed, Mar 3, 2021 at 11:53 PM Peter Zijlstra wrote: > > On Wed, Mar 03, 2021 at 11:46:59AM +0800, Chengming Zhou wrote: > > The commit 36b238d57172 ("psi: Optimize switching tasks inside shared > > cgroups") only update cgroups whose state actually changes during a > > task switch only in task

Re: [PATCH 4.9 000/134] 4.9.259-rc3 review

2021-03-03 Thread Naresh Kamboju
On Wed, 3 Mar 2021 at 00:58, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.259 release. > There are 134 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH v2] iwlwifi: don't call netif_napi_add() with rxq->lock held (was Re: Lockdep warning in iwl_pcie_rx_handle())

2021-03-03 Thread Kalle Valo
Jiri Kosina wrote: > From: Jiri Kosina > > We can't call netif_napi_add() with rxq-lock held, as there is a potential > for deadlock as spotted by lockdep (see below). rxq->lock is not > protecting anything over the netif_napi_add() codepath anyway, so let's > drop it just before calling into

[PATCH] mtd: require write permissions for locking and badblock ioctls

2021-03-03 Thread Michael Walle
MEMLOCK, MEMUNLOCK and OTPLOCK modify protection bits. Thus require write permission. Depending on the hardware MEMLOCK might even be write-once, e.g. for SPI-NOR flashes with their WP# tied to GND. OTPLOCK is always write-once. MEMSETBADBLOCK modifies the bad block table. Fixes: f7e6b19bc764

Re: [PATCH] selftests/bpf: Simplify the calculation of variables

2021-03-03 Thread Yonghong Song
On 3/2/21 11:52 PM, Jiapeng Chong wrote: Fix the following coccicheck warnings: ./tools/testing/selftests/bpf/test_sockmap.c:735:35-37: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Acked-by: Yonghong Song

Re: exec error: BUG: Bad rss-counter

2021-03-03 Thread Eric W. Biederman
Ilya Lipnitskiy writes: > On Wed, Mar 3, 2021 at 7:50 AM Eric W. Biederman > wrote: >> >> Ilya Lipnitskiy writes: >> >> > On Tue, Mar 2, 2021 at 11:37 AM Eric W. Biederman >> > wrote: >> >> >> >> Ilya Lipnitskiy writes: >> >> >> >> > On Mon, Mar 1, 2021 at 12:43 PM Eric W. Biederman >> >>

Re: [PATCH] perf daemon: Fix compile error with Asan

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2021 at 12:06:46PM +0100, Jiri Olsa escreveu: > On Wed, Feb 24, 2021 at 04:14:38PM +0900, Namhyung Kim wrote: > > I'm seeing a build failure when build with address sanitizer. > > It seems we could write to the name[100] if the var is longer. > > > > $ make

[PATCH net v2] net: l2tp: reduce log level of messages in receive path, add counter instead

2021-03-03 Thread Matthias Schiffer
Commit 5ee759cda51b ("l2tp: use standard API for warning log messages") changed a number of warnings about invalid packets in the receive path so that they are always shown, instead of only when a special L2TP debug flag is set. Even with rate limiting these warnings can easily cause significant

Re: [PATCH v2 0/4] psi: Add PSI_CPU_FULL state and some code optimization

2021-03-03 Thread Peter Zijlstra
On Wed, Mar 03, 2021 at 04:32:18PM +0100, Peter Zijlstra wrote: > Yes, I can do that. Thanks! Please double check the patches as found here: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=sched/core I've manually edited the tags.

Re: [PATCH v3 RFC 14/14] mm: speedup page alloc for MPOL_PREFERRED_MANY by adding a NO_SLOWPATH gfp bit

2021-03-03 Thread Ben Widawsky
On 21-03-03 14:59:35, Michal Hocko wrote: > On Wed 03-03-21 21:46:44, Feng Tang wrote: > > On Wed, Mar 03, 2021 at 09:18:32PM +0800, Tang, Feng wrote: > > > On Wed, Mar 03, 2021 at 01:32:11PM +0100, Michal Hocko wrote: > > > > On Wed 03-03-21 20:18:33, Feng Tang wrote: > [...] > > > > > One thing

[PATCH] net: mac802154: Fix null pointer dereference

2021-03-03 Thread Pavel Skripkin
syzbot found general protection fault in crypto_destroy_tfm()[1]. It was caused by wrong clean up loop in llsec_key_alloc(). If one of the tfm array members won't be initialized it will cause NULL dereference in crypto_destroy_tfm(). Call Trace: crypto_free_aead include/crypto/aead.h:191

Re: [PATCH v2] coccinelle: misc: add swap script

2021-03-03 Thread Julia Lawall
On Fri, 19 Feb 2021, Denis Efremov wrote: > Check for opencoded swap() implementation. > > Signed-off-by: Denis Efremov > --- > Changes in v2: > - additional patch rule to drop excessive {} > - fix indentation in patch mode by anchoring ; > > scripts/coccinelle/misc/swap.cocci | 101

[PATCH v4] net: phy: add Marvell 88X2222 transceiver support

2021-03-03 Thread Ivan Bornyakov
Add basic support for the Marvell 88X multi-speed ethernet transceiver. This PHY provides data transmission over fiber-optic as well as Twinax copper links. The 88X supports 2 ports of 10GBase-R and 1000Base-X on the line-side interface. The host-side interface supports 4 ports of

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Greg Kroah-Hartman
On Wed, Mar 03, 2021 at 05:33:46PM +0100, Arnd Bergmann wrote: > On Wed, Mar 3, 2021 at 4:46 PM Krzysztof Kozlowski wrote: > > On 03/03/2021 16:09, Greg Kroah-Hartman wrote: > > > On Wed, Mar 03, 2021 at 06:56:38AM -0800, Guenter Roeck wrote: > > >> On 3/3/21 6:05 AM, Greg Kroah-Hartman wrote: >

Re: [PATCH] perf record: Fix continue profiling after draining the buffer

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 22, 2021 at 09:31:51AM +0800, Yang Jihong escreveu: > Hello, > > On 2021/2/19 1:09, Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 18, 2021 at 10:20:53AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Fri, Feb 05, 2021 at 11:46:12AM +0100, Jiri Olsa escreveu: > > > > On Fri, Feb

Re: [PATCH v3 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks

2021-03-03 Thread Tony Krowiak
On 3/3/21 10:23 AM, Halil Pasic wrote: On Tue, 2 Mar 2021 15:43:22 -0500 Tony Krowiak wrote: This patch fixes a lockdep splat introduced by commit f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM pointer invalidated"). The lockdep splat only occurs when starting a Secure

Re: [RFC PATCH 1/12] x86/Hyper-V: Add visibility parameter for vmbus_establish_gpadl()

2021-03-03 Thread Vitaly Kuznetsov
Tianyu Lan writes: > From: Tianyu Lan > > Add visibility parameter for vmbus_establish_gpadl() and prepare > to change host visibility when create gpadl for buffer. > "No functional change" as you don't actually use the parameter. > Signed-off-by: Sunil Muthuswamy > Co-Developed-by: Sunil

Re: [PATCH 5/7] printk: Make %pS and friends print module build ID

2021-03-03 Thread Andy Shevchenko
On Wed, Mar 03, 2021 at 10:00:12AM -0500, Steven Rostedt wrote: > On Wed, 3 Mar 2021 11:25:58 +0100 > Petr Mladek wrote: > > > Alternative solution would be to minimize the information, for > > example, by printing only the modules that appear in the backtrace. > > But this might be complicated

Re: [PATCH v5 04/16] rpmsg: char: export eptdev create an destroy functions

2021-03-03 Thread Mathieu Poirier
On Wed, Mar 03, 2021 at 02:22:36PM +0100, Arnaud POULIQUEN wrote: > Hi Mathieu, > > On 3/2/21 6:57 PM, Mathieu Poirier wrote: > > Good morning, > > > > I have started to review this set - comments will be staggered over several > > days. > > > > On Fri, Feb 19, 2021 at 12:14:49PM +0100, Arnaud

Re: [PATCH] mtd: require write permissions for locking and badblock ioctls

2021-03-03 Thread Richard Weinberger
- Ursprüngliche Mail - >>> Thanks for auditing the rest of these from my original patch. If this >>> is ok with userspace tools, it's fine with me, but I don't even have >>> this hardware to test with :) >> >> That's my fear. Michael, did you verify? > > I don't know any tools except

Re: [PATCH 03/15] KVM: x86/mmu: Ensure MMU pages are available when allocating roots

2021-03-03 Thread Sean Christopherson
On Tue, Mar 02, 2021, Ben Gardon wrote: > > @@ -3241,16 +3237,10 @@ static int mmu_alloc_direct_roots(struct kvm_vcpu > > *vcpu) > > > > if (is_tdp_mmu_enabled(vcpu->kvm)) { > > root = kvm_tdp_mmu_get_vcpu_root_hpa(vcpu); > > - > > - if (!VALID_PAGE(root)) >

Re: [PATCH -next v2] fbdev: atyfb: use LCD management functions for PPC_PMAC also

2021-03-03 Thread Ville Syrjälä
On Fri, Feb 26, 2021 at 09:30:08AM -0800, Randy Dunlap wrote: > Include PPC_PMAC in the configs that use aty_ld_lcd() and > aty_st_lcd() implementations so that the PM code may work > correctly for PPC_PMAC. > > Suggested-by: Ville Syrjälä > Signed-off-by: Randy Dunlap > Cc: Daniel Vetter >

Re: [PATCH 08/11] arm64: dts: qcom: pm8994: Add RESIN node

2021-03-03 Thread Yassine Oudjana
In-Reply-To: <20210228130831.203765-8-konrad.dyb...@somainline.org> I've sent a similar patch[1] a while ago, although I didn't disable resin by default:

Re: [PATCH v3 1/1] Bluetooth: Remove unneeded commands for suspend

2021-03-03 Thread Marcel Holtmann
Hi Abhishek, > During suspend, there are a few scan enable and set event filter > commands that don't need to be sent unless there are actual BR/EDR > devices capable of waking the system. Check the HCI_PSCAN bit before > writing scan enable and use a new dev flag, HCI_EVENT_FILTER_CONFIGURED >

[PATCH v1 1/1] mfd: lpc_sch: Partially revert "Add support for Intel Quark X1000"

2021-03-03 Thread Andy Shevchenko
The IRQ support for SCH GPIO is not specific to the Intel Quark SoC. Moreover the IRQ routing is quite interesting there, so while it's needs a special support, the driver haven't it anyway yet. Due to above remove basically redundant code of IRQ support. This reverts commit

Re: XDP socket rings, and LKMM litmus tests

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 07:37:42AM +0100, maranget wrote: > Hi all, > > I agree that herd7 computation of control dependencies is problematic here. > > Thanks for reporting the problem. Paul kindly takes the responsibility for > the problem, but frankly do not remember having followed his

Re: [PATCH 17/53] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-03-03 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks! On Wed, 2021-03-03 at 13:42 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > >  drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous > prototype for ‘headc57d_olut’ [-Wmissing-prototypes] > > Cc: Ben Skeggs > Cc:

Re: [PATCH v1 0/3] driver core: Set fw_devlink=on take II

2021-03-03 Thread Saravana Kannan
On Wed, Mar 3, 2021 at 2:03 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Wed, Mar 3, 2021 at 10:24 AM Saravana Kannan wrote: > > On Wed, Mar 3, 2021 at 1:22 AM Geert Uytterhoeven > > wrote: > > > On Tue, Mar 2, 2021 at 10:11 PM Saravana Kannan > > > wrote: > > > > This series fixes

Re: [PATCH v3] net: phy: add Marvell 88X2222 transceiver support

2021-03-03 Thread Ivan Bornyakov
On Wed, Mar 03, 2021 at 11:36:55AM +, Russell King - ARM Linux admin wrote: > > > + linkmode_set_bit(ETHTOOL_LINK_MODE_1baseKR_Full_BIT, supported); > > Does the PHY support backplane links? > It looks like it does, but our hardware only have SFP cages, so I'll drop backplane link

Re: [PATCH v5 06/16] rpmsg: move the rpmsg control device from rpmsg_char to rpmsg_ctrl

2021-03-03 Thread Mathieu Poirier
On Wed, Mar 03, 2021 at 03:59:34PM +0100, Arnaud POULIQUEN wrote: > > > On 3/2/21 7:35 PM, Mathieu Poirier wrote: > > On Fri, Feb 19, 2021 at 12:14:51PM +0100, Arnaud Pouliquen wrote: > >> Move the code related to the rpmsg_ctrl char device to the new > >> rpmsg_ctrl.c module. > >> Manage the

Re: can the idle value of /proc/stat decrease?

2021-03-03 Thread Gioh Kim
Hi, We found the same problem on our production servers. For example, prometheus-node-exporter reported below message: daemon.info: Feb 8 17:43:12 ps601b-202 prometheus-node-exporter[2506]: level=warn ts=2021-02-08T17:43:12.052Z caller=cpu_linux.go:247 collector=cpu msg="CPU Idle counter jumped

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Arnd Bergmann
On Wed, Mar 3, 2021 at 4:46 PM Krzysztof Kozlowski wrote: > On 03/03/2021 16:09, Greg Kroah-Hartman wrote: > > On Wed, Mar 03, 2021 at 06:56:38AM -0800, Guenter Roeck wrote: > >> On 3/3/21 6:05 AM, Greg Kroah-Hartman wrote: > >> [ ... ] > Anyway, that's the convention or consensus so far for

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Krzysztof Kozlowski
On 03/03/2021 17:43, Greg Kroah-Hartman wrote: I don't think that will work in practice. Many ARCH_ symbols for various architectures contradict with each other. Almost all watchdog drivers only _build_ for specific platforms/architectures. Great, that's horrible to hear, so much for a

Re: [PATCH v2 4/4] psi: Optimize task switch inside shared cgroups

2021-03-03 Thread Peter Zijlstra
On Wed, Mar 03, 2021 at 11:46:59AM +0800, Chengming Zhou wrote: > The commit 36b238d57172 ("psi: Optimize switching tasks inside shared > cgroups") only update cgroups whose state actually changes during a > task switch only in task preempt case, not in task sleep case. > > We actually don't need

Re: [PATCH v3 1/9] perf/x86/intel: Fix a comment about guest LBR support

2021-03-03 Thread Sean Christopherson
On Wed, Mar 03, 2021, Like Xu wrote: > Starting from v5.12, KVM reports guest LBR and extra_regs > support when the host has relevant support. > > Cc: Peter Zijlstra > Reviewed-by: Kan Liang > Signed-off-by: Like Xu > --- > arch/x86/events/intel/core.c | 2 +- > 1 file changed, 1

Re: [PATCH v2 2/4] psi: Use ONCPU state tracking machinery to detect reclaim

2021-03-03 Thread Peter Zijlstra
On Wed, Mar 03, 2021 at 11:46:57AM +0800, Chengming Zhou wrote: > Move the reclaim detection from the timer tick to the task state > tracking machinery using the recently added ONCPU state. And we > also add task psi_flags changes checking in the psi_task_switch() > optimization to update the

Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent

2021-03-03 Thread Krzysztof Kozlowski
On 03/03/2021 17:49, Krzysztof Kozlowski wrote: And "new drivers" are almost always not really "new" as everyone uses much the same IP blocks.  As proof of this patch where the DWC3 IP block is being used by multiple SoC vendors.  To handle that, you split out the SoC-specific portions into

Re: [PATCH] ibmvnic: Fix possibly uninitialized old_num_tx_queues variable warning.

2021-03-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Mar 2021 20:47:47 +0100 you wrote: > GCC 7.5 reports: > ../drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_reset_init': > ../drivers/net/ethernet/ibm/ibmvnic.c:5373:51: warning: 'old_num_tx_queues' > may be

[PATCH v3 0/1] Bluetooth: Suspend improvements

2021-03-03 Thread Abhishek Pandit-Subedi
Hi Marcel (and linux bluetooth), Here are a few suspend improvements based on user reports we saw on ChromeOS and feedback from Hans de Goede on the mailing list. I have tested this using our ChromeOS suspend/resume automated tests (full SRHealth test coverage and some suspend resume stress

Re: [PATCH 1/2] perf test: Fix sample-parsing fails on non-x86 platforms

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 03, 2021 at 08:01:24AM -0800, kan.li...@linux.intel.com escreveu: > From: Kan Liang > > Executing perf test 27 fails on s390: > [root@t35lp46 perf]# ./perf test -Fv 27 > 27: Sample parsing > --- start --- > end > Sample parsing: FAILED! > [root@t35lp46 perf]# > > The

[PATCH v3 1/1] Bluetooth: Remove unneeded commands for suspend

2021-03-03 Thread Abhishek Pandit-Subedi
During suspend, there are a few scan enable and set event filter commands that don't need to be sent unless there are actual BR/EDR devices capable of waking the system. Check the HCI_PSCAN bit before writing scan enable and use a new dev flag, HCI_EVENT_FILTER_CONFIGURED to control whether to

Re: [PATCH v3 RFC 14/14] mm: speedup page alloc for MPOL_PREFERRED_MANY by adding a NO_SLOWPATH gfp bit

2021-03-03 Thread Ben Widawsky
On 21-03-03 18:14:30, Michal Hocko wrote: > On Wed 03-03-21 08:31:41, Ben Widawsky wrote: > > On 21-03-03 14:59:35, Michal Hocko wrote: > > > On Wed 03-03-21 21:46:44, Feng Tang wrote: > > > > On Wed, Mar 03, 2021 at 09:18:32PM +0800, Tang, Feng wrote: > > > > > On Wed, Mar 03, 2021 at 01:32:11PM

Re: [PATCH v4 1/2] dt-bindings: serial: Add rx-tx-swap to stm32-usart

2021-03-03 Thread Fabrice Gasnier
On 3/2/21 8:03 PM, Martin Devera wrote: > Add new rx-tx-swap property to allow for RX & TX pin swapping. > > Signed-off-by: Martin Devera > --- > .../devicetree/bindings/serial/st,stm32-uart.yaml | 32 > +++--- > 1 file changed, 22 insertions(+), 10 deletions(-) > Hi Martin,

Re: [PATCH] firewire: prevent integer overflow on 32bit systems

2021-03-03 Thread kernel test robot
Hi Dan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.12-rc1 next-20210303] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [PATCH] block: Suppress uevent for hidden device when removed

2021-03-03 Thread Martin Wilck
On Wed, 2021-03-03 at 18:12 +0100, Daniel Wagner wrote: > register_disk() suppress uevents for devices with the GENHD_FL_HIDDEN > but enables uevents at the end again in order to announce disk after > possible partitions are created. > > When the device is removed the uevents are still on and

[PATCH] habanalabs: debugfs access to user mapped host addresses

2021-03-03 Thread Oded Gabbay
From: Ofir Bitton In order to have a better debuggability we allow debugfs access to user mmu mapped host memory. Non-user host memory access will be rejected. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/debugfs.c| 88

Re: [PATCH 1/1] mmc: cqhci: fix random crash when remove mmc module

2021-03-03 Thread Zhi Li
On Tue, Mar 2, 2021 at 12:39 PM Zhi Li wrote: > > On Tue, Mar 2, 2021 at 10:25 AM Adrian Hunter wrote: > > > > On 2/03/21 5:12 pm, Zhi Li wrote: > > > > > > > > > On Tue, Mar 2, 2021 at 1:03 AM Adrian Hunter > > > wrote: > > > > > > On 1/03/21 7:21 pm, Frank

Re: [PATCH v3 8/9] KVM: x86: Expose Architectural LBR CPUID leaf

2021-03-03 Thread Sean Christopherson
On Wed, Mar 03, 2021, Like Xu wrote: > If CPUID.(EAX=07H, ECX=0):EDX[19] is set to 1, then KVM supports Arch > LBRs and CPUID leaf 01CH indicates details of the Arch LBRs capabilities. > Currently, KVM only supports the current host LBR depth for guests, > which is also the maximum supported depth

RE: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

2021-03-03 Thread Don.Brace
-Original Message- From: Sergei Trofimovich [mailto:sly...@gmail.com] Sent: Wednesday, March 3, 2021 2:56 AM To: John Paul Adrian Glaubitz ; Don Brace - C33706 ; storagedev ; linux-s...@vger.kernel.org Cc: linux-i...@vger.kernel.org; linux-kernel@vger.kernel.org; Joe Szczypek ; Scott

[PATCH v3] iommu: Check dev->iommu in iommu_dev_xxx functions

2021-03-03 Thread Shameer Kolothum
The device iommu probe/attach might have failed leaving dev->iommu to NULL and device drivers may still invoke these functions resulting in a crash in iommu vendor driver code. Hence make sure we check that. Fixes: a3a195929d40 ("iommu: Add APIs for multiple domains per device") Signed-off-by:

Re: [PATCH] PCI: iproc: Fix return value of iproc_msi_irq_domain_alloc()

2021-03-03 Thread Ray Jui
On 3/3/2021 6:22 AM, Pali Rohár wrote: > IRQ domain alloc function should return zero on success. Non-zero value > indicates failure. > > Signed-off-by: Pali Rohár > Fixes: fc54bae28818 ("PCI: iproc: Allow allocation of multiple MSIs") > --- > drivers/pci/controller/pcie-iproc-msi.c | 2 +- >

Re: [PATCH RFC v1 15/15] iommu/virtio: Update fault type and reason info for viommu fault

2021-03-03 Thread Jean-Philippe Brucker
On Fri, Jan 15, 2021 at 05:43:42PM +0530, Vivek Gautam wrote: > Fault type information can tell about a page request fault or > an unreceoverable fault, and further additions to fault reasons > and the related PASID information can help in handling faults > efficiently. > > Signed-off-by: Vivek

Re: [PATCH RFC v1 13/15] iommu/virtio: Attach Arm PASID tables when available

2021-03-03 Thread Jean-Philippe Brucker
On Fri, Jan 15, 2021 at 05:43:40PM +0530, Vivek Gautam wrote: [...] > +static int viommu_setup_pgtable(struct viommu_endpoint *vdev, > + struct viommu_domain *vdomain) > +{ > + int ret, id; > + u32 asid; > + enum io_pgtable_fmt fmt; > + struct

[PATCH v2] powerpc: Fix save_stack_trace_regs() to have running function as first entry

2021-03-03 Thread Christophe Leroy
It seems like other architectures, namely x86 and arm64 at least, include the running function as top entry when saving stack trace with save_stack_trace_regs(). Functionnalities like KFENCE expect it. Do the same on powerpc, it allows KFENCE to properly identify the faulting function as

Re: [PATCH v3 7/9] KVM: vmx/pmu: Add Arch LBR emulation and its VMCS field

2021-03-03 Thread Sean Christopherson
On Wed, Mar 03, 2021, Like Xu wrote: > New VMX controls bits for Arch LBR are added. When bit 21 in vmentry_ctrl > is set, VM entry will write the value from the "Guest IA32_LBR_CTL" guest > state field to IA32_LBR_CTL. When bit 26 in vmexit_ctrl is set, VM exit > will clear IA32_LBR_CTL after the

Re: [PATCH v21 08/26] x86/mm: Introduce _PAGE_COW

2021-03-03 Thread Borislav Petkov
On Tue, Mar 02, 2021 at 03:46:31PM -0800, Yu, Yu-cheng wrote: > There is a problem of doing that: pmd_write() is defined after this > function. Maybe we can declare it first, or leave this as-is? Or a third option: you lift those two functions in a prepatch and then in this patch use them

Re: [RFC PATCH 3/4] KVM: arm64: Install the block entry before unmapping the page mappings

2021-03-03 Thread Alexandru Elisei
Hi Yanan, On 3/3/21 11:04 AM, wangyanan (Y) wrote: > Hi Alex, > > On 2021/3/3 1:13, Alexandru Elisei wrote: >> Hello, >> >> On 2/8/21 11:22 AM, Yanan Wang wrote: >>> When KVM needs to coalesce the normal page mappings into a block mapping, >>> we currently invalidate the old table entry first

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-03 Thread Will Deacon
On Tue, Mar 02, 2021 at 05:25:17PM +, Christophe Leroy wrote: > This code provides architectures with a way to build command line > based on what is built in the kernel and what is handed over by the > bootloader, based on selected compile-time options. > > Signed-off-by: Christophe Leroy >

[git pull resend] habanalabs fixes for 5.12-rc2

2021-03-03 Thread Oded Gabbay
Hi Greg, This pull request contains some fixes of the habanalabs driver for 5.12-rc2. Nothing too scary, more details are in the tag. Thanks, Oded The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8: Linux 5.12-rc1 (2021-02-28 16:05:19 -0800) are available in the Git

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-03 Thread Henning Schild
Am Tue, 2 Mar 2021 21:54:52 +0100 schrieb Pavel Machek : > Hi! > > > This driver adds initial support for several devices from Siemens. > > It is based on a platform driver introduced in an earlier commit. > > Ok. > > > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile > > index

Re: XDP socket rings, and LKMM litmus tests

2021-03-03 Thread maranget
> On 3 Mar 2021, at 18:12, Alan Stern wrote: > > On Tue, Mar 02, 2021 at 03:50:19PM -0800, Paul E. McKenney wrote: >> On Tue, Mar 02, 2021 at 04:14:46PM -0500, Alan Stern wrote: > >>> This result is wrong, apparently because of a bug in herd7. There >>> should be control dependencies from

[PATCH v3 0/3] media: qcom: camss: V4L2_CID_PIXEL_RATE/LINK_FREQ fixes

2021-03-03 Thread Andrey Konovalov
The first patch adds printing a warning in v4l2_get_link_freq() if V4L2_CID_LINK_FREQ isn't implemented (this is a mandatory control for CSI-2 transmitter drivers [1], but many sensor drivers don't have it currently). The second patch is the start of the work discussed in the "[RFC] Repurpose

[PATCH v2 1/1] mmc: cqhci: fix random crash when remove mmc module

2021-03-03 Thread Frank Li
[ 6684.493350] Unable to handle kernel paging request at virtual address 800011c5b0f0 [ 6684.498531] mmc0: card 0001 removed [ 6684.501556] Mem abort info: [ 6684.509681] ESR = 0x9647 [ 6684.512786] EC = 0x25: DABT (current EL), IL = 32 bits [ 6684.518394] SET = 0, FnV = 0 [

Re: [PATCH 02/15] KVM: x86/mmu: Alloc page for PDPTEs when shadowing 32-bit NPT with 64-bit

2021-03-03 Thread Ben Gardon
On Tue, Mar 2, 2021 at 10:45 AM Sean Christopherson wrote: > > Allocate the so called pae_root page on-demand, along with the lm_root > page, when shadowing 32-bit NPT with 64-bit NPT, i.e. when running a > 32-bit L1. KVM currently only allocates the page when NPT is disabled, > or when L0 is

Re: [PATCH RFC v1 05/15] iommu/arm-smmu-v3: Set sync op from consumer driver of cd-lib

2021-03-03 Thread Jean-Philippe Brucker
On Fri, Jan 15, 2021 at 05:43:32PM +0530, Vivek Gautam wrote: > Te change allows different consumers of arm-smmu-v3-cd-lib to set > their respective sync op for pasid entries. > > Signed-off-by: Vivek Gautam > Cc: Joerg Roedel > Cc: Will Deacon > Cc: Robin Murphy > Cc: Jean-Philippe Brucker

Re: [PATCH RFC v1 09/15] iommu/virtio: Update table format probing header

2021-03-03 Thread Jean-Philippe Brucker
On Fri, Jan 15, 2021 at 05:43:36PM +0530, Vivek Gautam wrote: > Add info about asid_bits and additional flags to table format > probing header. > > Signed-off-by: Vivek Gautam > Cc: Joerg Roedel > Cc: Will Deacon > Cc: Michael S. Tsirkin > Cc: Robin Murphy > Cc: Jean-Philippe Brucker > Cc:

Re: [RFC PATCH 5/12] HV: Add ghcb hvcall support for SNP VM

2021-03-03 Thread Vitaly Kuznetsov
Tianyu Lan writes: > From: Tianyu Lan > > Hyper-V provides ghcb hvcall to handle VMBus > HVCALL_SIGNAL_EVENT and HVCALL_POST_MESSAGE > msg in SNP Isolation VM. Add such support. > > Signed-off-by: Tianyu Lan > --- > arch/x86/hyperv/ivm.c | 69 + >

Re: [PATCH rdma-rc 0/2] W=1 compilation fixes leftovers

2021-03-03 Thread Jason Gunthorpe
On Tue, Mar 02, 2021 at 09:42:12AM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Two extra fixes that were missed in Lee's W=1 cleanup. > > Leon Romanovsky (2): > RDMA/mlx5: Set correct kernel-doc identifier > RDMA/uverbs: Fix kernel-doc warning of _uverbs_alloc Applied to

Re: [PATCH 3/4] certs: Add ability to preload revocation certs

2021-03-03 Thread Nathan Chancellor
On Thu, Feb 25, 2021 at 08:58:55PM +, David Howells wrote: > From: Eric Snowberg > > Add a new Kconfig option called SYSTEM_REVOCATION_KEYS. If set, > this option should be the filename of a PEM-formated file containing > X.509 certificates to be included in the default blacklist keyring. >

Re: [PATCH] mm: Allow shmem mappings with MREMAP_DONTUNMAP

2021-03-03 Thread Brian Geffon
I apologize, this patch didn't include my signed off by, here it is: Signed-off-by: Brian Geffon On Wed, Mar 3, 2021 at 9:53 AM Brian Geffon wrote: > > Currently MREMAP_DONTUNMAP only accepts private anonymous mappings. This > change > will widen the support to include shmem mappings. The

Re: [PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-03 Thread kernel test robot
Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on linux/master linus/master v5.12-rc1 next-20210303] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

RE: [PATCH] mm/compaction: remove unused variable sysctl_compact_memory

2021-03-03 Thread Nitin Gupta
> -Original Message- > From: owner-linux...@kvack.org On Behalf > Of pi...@codeaurora.org > Sent: Wednesday, March 3, 2021 6:34 AM > To: Nitin Gupta > Cc: linux-kernel@vger.kernel.org; a...@linux-foundation.org; linux- > m...@kvack.org; linux-fsde...@vger.kernel.org;

Re: [PATCH 03/11] arm64: dts: intel: socfpga: override clocks by label

2021-03-03 Thread Krzysztof Kozlowski
On 10/02/2021 18:18, Krzysztof Kozlowski wrote: Using full paths to extend or override a device tree node is error prone. If there was a typo error, a new node will be created instead of extending the existing node. This will lead to run-time errors that could be hard to detect. A mistyped

Re: [PATCH drivers/net] #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend()

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 06:04:22PM +, Russell King - ARM Linux admin wrote: > On Wed, Mar 03, 2021 at 09:53:38AM -0800, Paul E. McKenney wrote: > > drivers/net: #ifdef mdio_bus_phy_suspend() and mdio_bus_phy_suspend() > > > > The following build error is emitted by rcutorture builds of

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-03 Thread Will Deacon
On Wed, Mar 03, 2021 at 06:57:09PM +0100, Christophe Leroy wrote: > Le 03/03/2021 à 18:46, Will Deacon a écrit : > > On Wed, Mar 03, 2021 at 06:38:16PM +0100, Christophe Leroy wrote: > > > Le 03/03/2021 à 18:28, Will Deacon a écrit : > > > > On Tue, Mar 02, 2021 at 05:25:17PM +, Christophe

[perf] perf_fuzzer causes unchecked MSR access error

2021-03-03 Thread Vince Weaver
Hello on my Haswell machine the perf_fuzzer managed to trigger this message: [117248.075892] unchecked MSR access error: WRMSR to 0x3f1 (tried to write 0x0400) at rIP: 0x8106e4f4 (native_write_msr+0x4/0x20) [117248.089957] Call Trace: [117248.092685]

[PATCH v3 2/3] media: camss: use v4l2_get_link_freq() to calculate the relevant clocks

2021-03-03 Thread Andrey Konovalov
There are places in the camss driver where camss_get_pixel_clock() is called to get the pixel rate (using V4L2_CID_PIXEL_RATE control) and to calculate the link frequency from it. There is a case when this would not work: when V4L2_CID_PIXEL_RATE gets the rate at which the pixels are read

[PATCH v3 1/3] v4l: common: v4l2_get_link_freq: add printing a warning

2021-03-03 Thread Andrey Konovalov
Print a warning if V4L2_CID_LINK_FREQ control is not implemented. Signed-off-by: Andrey Konovalov Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- drivers/media/v4l2-core/v4l2-common.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-common.c

[PATCH v3 3/3] media: qcom: camss: Fix overflows in clock rate calculations

2021-03-03 Thread Andrey Konovalov
From: Vladimir Lypak Because of u32 type being used to store pixel clock rate, expression used to calculate pipeline clocks (pixel_clock * bpp) produces wrong value due to integer overflow. This patch changes data type used to store, pass and retrieve pixel_clock from u32 to u64 to make this

Re: [PATCH] MIPS: BMIPS: Reserve exception base to prevent corruption

2021-03-03 Thread Maciej W. Rozycki
On Wed, 3 Mar 2021, Thomas Bogendoerfer wrote: > perfect, I only forgot about R3k... I'll submit a formal patch submission > later today. What's up with the R3k (the usual trigger for me) here? Maciej

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-03 Thread Pavel Machek
Hi! > > > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile > > > index 2a698df9da57..c15e1e3c5958 100644 > > > --- a/drivers/leds/Makefile > > > +++ b/drivers/leds/Makefile > > > @@ -93,6 +93,7 @@ obj-$(CONFIG_LEDS_TURRIS_OMNIA) += > > > leds-turris-omnia.o

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-03 Thread Will Deacon
On Wed, Mar 03, 2021 at 06:38:16PM +0100, Christophe Leroy wrote: > Le 03/03/2021 à 18:28, Will Deacon a écrit : > > On Tue, Mar 02, 2021 at 05:25:17PM +, Christophe Leroy wrote: > > > This code provides architectures with a way to build command line > > > based on what is built in the kernel

Re: [PATCH] mm/compaction: remove unused variable sysctl_compact_memory

2021-03-03 Thread pintu
On 2021-03-03 22:39, Vlastimil Babka wrote: On 3/2/21 6:56 PM, Pintu Kumar wrote: The sysctl_compact_memory is mostly unsed in mm/compaction.c It just acts as a place holder for sysctl. Thus we can remove it from here and move the declaration directly in kernel/sysctl.c itself. This will also

Re: [PATCH v5] i2c: virtio: add a virtio i2c frontend driver

2021-03-03 Thread Stefan Hajnoczi
On Tue, Mar 02, 2021 at 11:54:02AM +0100, Arnd Bergmann wrote: > On Tue, Mar 2, 2021 at 10:51 AM Stefan Hajnoczi wrote: > > On Tue, Mar 02, 2021 at 10:42:06AM +0800, Jie Deng wrote: > > > > > +/* > > > > > + * Definitions for virtio I2C Adpter > > > > > + * > > > > > + * Copyright (c) 2021 Intel

Re: [PATCH v2 1/1] mmc: cqhci: fix random crash when remove mmc module

2021-03-03 Thread Adrian Hunter
On 3/03/21 7:42 pm, Frank Li wrote: > [ 6684.493350] Unable to handle kernel paging request at virtual address > 800011c5b0f0 > [ 6684.498531] mmc0: card 0001 removed > [ 6684.501556] Mem abort info: > [ 6684.509681] ESR = 0x9647 > [ 6684.512786] EC = 0x25: DABT (current EL), IL = 32

Re: [PATCH v2 6/7] cmdline: Gives architectures opportunity to use generically defined boot cmdline manipulation

2021-03-03 Thread Will Deacon
On Tue, Mar 02, 2021 at 05:25:22PM +, Christophe Leroy wrote: > Most architectures have similar boot command line manipulation > options. This patchs adds the definition in init/Kconfig, gated by > CONFIG_HAVE_CMDLINE that the architectures can select to use them. > > In order to use this, a

Re: [PATCH v2 1/7] cmdline: Add generic function to build command line.

2021-03-03 Thread Christophe Leroy
Le 03/03/2021 à 18:46, Will Deacon a écrit : On Wed, Mar 03, 2021 at 06:38:16PM +0100, Christophe Leroy wrote: Le 03/03/2021 à 18:28, Will Deacon a écrit : On Tue, Mar 02, 2021 at 05:25:17PM +, Christophe Leroy wrote: This code provides architectures with a way to build command line

Re: possible deadlock in sk_clone_lock

2021-03-03 Thread Paul E. McKenney
On Wed, Mar 03, 2021 at 09:03:27AM +0100, Michal Hocko wrote: > [Add Paul] > > On Tue 02-03-21 13:19:34, Mike Kravetz wrote: > > On 3/2/21 6:29 AM, Michal Hocko wrote: > > > On Tue 02-03-21 06:11:51, Shakeel Butt wrote: > > >> On Tue, Mar 2, 2021 at 1:44 AM Michal Hocko wrote: > > >>> > > >>> On

<    1   2   3   4   5   6   7   8   9   10   >