Hi Minchan, I love your patch! Yet something to improve:
[auto build test ERROR on block/for-next] [also build test ERROR on linux/master linus/master v5.12-rc1 next-20210303] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Minchan-Kim/mm-disable-LRU-pagevec-during-the-migration-temporarily/20210303-191809 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: arm-randconfig-r021-20210303 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a7cad6680b4087eff8994f1f99ac40c661a6621f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/0day-ci/linux/commit/6e669beb75caae92c613a012734b1a2dc9485524 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Minchan-Kim/mm-disable-LRU-pagevec-during-the-migration-temporarily/20210303-191809 git checkout 6e669beb75caae92c613a012734b1a2dc9485524 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): In file included from fs/iomap/buffered-io.c:19: >> include/linux/migrate.h:70:41: error: void function 'migrate_prep' should >> not return a value [-Wreturn-type] static inline void migrate_prep(void) { return -ENOSYS; } ^ ~~~~~~~ >> include/linux/migrate.h:71:47: error: void function 'migrate_prep_local' >> should not return a value [-Wreturn-type] static inline void migrate_prep_local(void) { return -ENOSYS; } ^ ~~~~~~~ 2 errors generated. -- In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:40: In file included from drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu.h:86: In file included from drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu_mn.h:28: In file included from include/linux/hmm.h:16: >> include/linux/migrate.h:70:41: error: void function 'migrate_prep' should >> not return a value [-Wreturn-type] static inline void migrate_prep(void) { return -ENOSYS; } ^ ~~~~~~~ >> include/linux/migrate.h:71:47: error: void function 'migrate_prep_local' >> should not return a value [-Wreturn-type] static inline void migrate_prep_local(void) { return -ENOSYS; } ^ ~~~~~~~ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1143:18: warning: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare] res->start > 0x100000000ull) ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:86: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ include/linux/compiler.h:69:3: note: expanded from macro '__trace_if_value' (cond) ? \ ^~~~ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1143:18: warning: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare] res->start > 0x100000000ull) ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1143:18: warning: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare] res->start > 0x100000000ull) ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:61: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ 3 warnings and 2 errors generated. -- In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:36: In file included from drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu.h:86: In file included from drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgpu_mn.h:28: In file included from include/linux/hmm.h:16: >> include/linux/migrate.h:70:41: error: void function 'migrate_prep' should >> not return a value [-Wreturn-type] static inline void migrate_prep(void) { return -ENOSYS; } ^ ~~~~~~~ >> include/linux/migrate.h:71:47: error: void function 'migrate_prep_local' >> should not return a value [-Wreturn-type] static inline void migrate_prep_local(void) { return -ENOSYS; } ^ ~~~~~~~ drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:263:7: warning: format specifies type 'unsigned short' but the argument has type 'unsigned int' [-Wformat] version_major, version_minor); ^~~~~~~~~~~~~ include/drm/drm_print.h:498:19: note: expanded from macro 'DRM_ERROR' __drm_err(fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:263:22: warning: format specifies type 'unsigned short' but the argument has type 'unsigned int' [-Wformat] version_major, version_minor); ^~~~~~~~~~~~~ include/drm/drm_print.h:498:19: note: expanded from macro 'DRM_ERROR' __drm_err(fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ 2 warnings and 2 errors generated. -- In file included from mm/page_alloc.c:61: >> include/linux/migrate.h:70:41: error: void function 'migrate_prep' should >> not return a value [-Wreturn-type] static inline void migrate_prep(void) { return -ENOSYS; } ^ ~~~~~~~ >> include/linux/migrate.h:71:47: error: void function 'migrate_prep_local' >> should not return a value [-Wreturn-type] static inline void migrate_prep_local(void) { return -ENOSYS; } ^ ~~~~~~~ mm/page_alloc.c:2621:5: warning: no previous prototype for function 'find_suitable_fallback' [-Wmissing-prototypes] int find_suitable_fallback(struct free_area *area, unsigned int order, ^ mm/page_alloc.c:2621:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int find_suitable_fallback(struct free_area *area, unsigned int order, ^ static mm/page_alloc.c:3600:15: warning: no previous prototype for function 'should_fail_alloc_page' [-Wmissing-prototypes] noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) ^ mm/page_alloc.c:3600:10: note: declare 'static' if the function is not intended to be used outside of this translation unit noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) ^ static 2 warnings and 2 errors generated. -- In file included from kernel/sched/rt.c:6: In file included from kernel/sched/sched.h:53: >> include/linux/migrate.h:70:41: error: void function 'migrate_prep' should >> not return a value [-Wreturn-type] static inline void migrate_prep(void) { return -ENOSYS; } ^ ~~~~~~~ >> include/linux/migrate.h:71:47: error: void function 'migrate_prep_local' >> should not return a value [-Wreturn-type] static inline void migrate_prep_local(void) { return -ENOSYS; } ^ ~~~~~~~ kernel/sched/rt.c:669:6: warning: no previous prototype for function 'sched_rt_bandwidth_account' [-Wmissing-prototypes] bool sched_rt_bandwidth_account(struct rt_rq *rt_rq) ^ kernel/sched/rt.c:669:1: note: declare 'static' if the function is not intended to be used outside of this translation unit bool sched_rt_bandwidth_account(struct rt_rq *rt_rq) ^ static 1 warning and 2 errors generated. vim +/migrate_prep +70 include/linux/migrate.h 58 59 static inline void putback_movable_pages(struct list_head *l) {} 60 static inline int migrate_pages(struct list_head *l, new_page_t new, 61 free_page_t free, unsigned long private, enum migrate_mode mode, 62 int reason) 63 { return -ENOSYS; } 64 static inline struct page *alloc_migration_target(struct page *page, 65 unsigned long private) 66 { return NULL; } 67 static inline int isolate_movable_page(struct page *page, isolate_mode_t mode) 68 { return -EBUSY; } 69 > 70 static inline void migrate_prep(void) { return -ENOSYS; } > 71 static inline void migrate_prep_local(void) { return -ENOSYS; } 72 static inline void migrate_done(void) {} 73 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
