Re: [PATCH] memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]

2021-02-23 Thread Dan Carpenter
On Tue, Feb 23, 2021 at 07:38:21PM +, Colin King wrote: > From: Colin Ian King > > Currently the array gpmc_cs is indexed by cs before it cs is range checked > and the pointer read from this out-of-index read is dereferenced. Fix this > by performing the range check on cs before the read and

Re: [PATCH v21 10/10] fs/ntfs3: Add MAINTAINERS

2021-02-23 Thread Sebastian Gottschall
Am 12.02.2021 um 17:24 schrieb Konstantin Komarov: This adds MAINTAINERS Signed-off-by: Konstantin Komarov just for your info with latest ntfs3 driver kern.err kernel: ntfs3: sda1: ntfs_evict_inode r=fe1 failed, -22.

[PATCH] arch: powerpc: kernel: Change droping to dropping in the file traps.c

2021-02-23 Thread Bhaskar Chowdhury
s/droping/dropping/ Signed-off-by: Bhaskar Chowdhury --- arch/powerpc/kernel/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c index 1583fd1c6010..83a53b67412a 100644 --- a/arch/powerpc/kernel/traps.c +++

[PATCH] scsi: remove unneeded semicolon

2021-02-23 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/scsi/aha1542.c:300:2-3: Unneeded semicolon. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/scsi/aha1542.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c

Re: [GIT PULL] Modules updates for v5.12

2021-02-23 Thread Christoph Hellwig
On Tue, Feb 23, 2021 at 12:07:39PM -0800, Linus Torvalds wrote: > On Tue, Feb 23, 2021 at 12:03 PM Linus Torvalds > wrote: > > > > This is unacceptably slow. If that symbol trimming takes 30% of the > > whole kernel build time, it needs to be fixed or removed. > > I think I'm going to mark

Re: [PATCH v24 11/14] Documentation: Add documents for DAMON

2021-02-23 Thread SeongJae Park
On Thu, 4 Feb 2021 16:31:47 +0100 SeongJae Park wrote: > From: SeongJae Park > > This commit adds documents for DAMON under > `Documentation/admin-guide/mm/damon/` and `Documentation/vm/damon/`. > > Signed-off-by: SeongJae Park > --- > Documentation/admin-guide/mm/damon/guide.rst | 159

Re: [PATCH 5.11 00/12] 5.11.1-rc1 review

2021-02-23 Thread Greg Kroah-Hartman
On Tue, Feb 23, 2021 at 05:12:56PM -0700, Shuah Khan wrote: > On 2/23/21 2:05 PM, Shuah Khan wrote: > > On 2/22/21 5:12 AM, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 5.11.1 release. > > > There are 12 patches in this series, all will be posted as a

[GIT PULL] dma-mapping updates for 5.12

2021-02-23 Thread Christoph Hellwig
The following changes since commit 9f5f8ec50165630cfc49897410b30997d4d677b5: dma-mapping: benchmark: use u8 for reserved field in uAPI structure (2021-02-05 12:48:46 +0100) are available in the Git repository at: git://git.infradead.org/users/hch/dma-mapping.git tags/dma-mapping-5.12 for

Re: [RFC][PATCH 1/3] PM /devfreq: add user frequency limits into devfreq struct

2021-02-23 Thread Chanwoo Choi
On 2/16/21 7:41 PM, Lukasz Luba wrote: > Hi Chanwoo, > > On 2/15/21 3:00 PM, Chanwoo Choi wrote: >> Hi Lukasz, >> >> On Fri, Feb 12, 2021 at 7:28 AM Lukasz Luba wrote: >>> >>> >>> >>> On 2/11/21 11:07 AM, Lukasz Luba wrote: Hi Chanwoo, On 2/3/21 10:21 AM, Lukasz Luba wrote: >

Re: [PATCH 2/2] nds32: use get_kernel_nofault in dump_mem

2021-02-23 Thread Christoph Hellwig
On Thu, Jan 28, 2021 at 11:16:33AM +0100, Christoph Hellwig wrote: > On Tue, Jul 21, 2020 at 01:28:00PM +0200, Christoph Hellwig wrote: > > Can you pich the patches up in the nds32 tree for Linus? There are > > not short-term dependencies on them. > > It seems like these patches are still

Re: [PATCH] perf-probe: dso: Add symbols in .text.* subsections to text symbol map in kenrel modules

2021-02-23 Thread Evgenii Shatokhin
On 23.02.2021 23:11, Arnaldo Carvalho de Melo wrote: Em Tue, Feb 23, 2021 at 06:02:58PM +0300, Evgenii Shatokhin escreveu: On 23.02.2021 10:37, Masami Hiramatsu wrote: The kernel modules have .text.* subsections such as .text.unlikely. Since dso__process_kernel_symbol() only identify the

Re: [PATCH stable-rc queue/4.9 1/1] futex: Provide distinct return value when owner is exiting

2021-02-23 Thread Greg KH
On Wed, Feb 24, 2021 at 09:41:01AM +0800, Xiaoming Ni wrote: > On 2021/2/23 21:00, Greg KH wrote: > > On Mon, Feb 22, 2021 at 10:11:37PM +0800, Xiaoming Ni wrote: > > > On 2021/2/22 20:09, Greg KH wrote: > > > > On Mon, Feb 22, 2021 at 06:54:06PM +0800, Xiaoming Ni wrote: > > > > > On 2021/2/22

[PATCH v2 1/2] pstore: Add mem_type property DT parsing support

2021-02-23 Thread Mukesh Ojha
From: Mukesh Ojha There could be a sceanario where we define some region in normal memory and use them store to logs which is later retrieved by bootloader during warm reset. In this scenario, we wanted to treat this memory as normal cacheable memory instead of default behaviour which is an

[PATCH 2/2] pstore: Add buffer start check during init

2021-02-23 Thread Mukesh Ojha
From: Huang Yiwei In a scenario of panic, when we use DRAM to store log instead of persistant storage and during warm reset when we copy these data outside of ram. Missing check on prz->start(write position) can cause crash because it can be any value and can point outside the mapped region. So

Re: [PATCH 01/13] staging: rtl8192e: remove blank line in bss_ht struct

2021-02-23 Thread Dan Carpenter
On Sat, Feb 20, 2021 at 03:54:05PM +, William Durand wrote: > Fixes a checkpatch CHECK issue. > All these patches have the same vague commit message. It's okay if the commit message basically restates the commit one line summary. It should say something like: Fix a checkpatch warning

Re: [PATCH] nand: brcmnand: fix OOB R/W with Hamming ECC

2021-02-23 Thread Miquel Raynal
Hi Álvaro, Álvaro Fernández Rojas wrote on Wed, 24 Feb 2021 08:16:58 +0100: > Hi Florian, > > > El 24 feb 2021, a las 4:46, Florian Fainelli > > escribió: > > > > > > > > On 2/22/2021 12:16 PM, Álvaro Fernández Rojas wrote: > >> Hamming ECC doesn't cover the OOB data, so reading or

Re: [PATCH v5 2/2] counter: add IRQ or GPIO based event counter

2021-02-23 Thread Oleksij Rempel
Hello William, On Wed, Feb 24, 2021 at 11:34:06AM +0900, William Breathitt Gray wrote: > On Tue, Feb 23, 2021 at 06:45:16PM +0100, Oleksij Rempel wrote: > > Hello William, > > > > Here is cooled down technical answer. Excuse me for over reacting. > > Hello Oleksij, > > Let me apologize too if

[PATCH v2] mips: smp-bmips: fix CPU mappings

2021-02-23 Thread Álvaro Fernández Rojas
When booting bmips with SMP enabled on a BCM6358 running on CPU #1 instead of CPU #0, the current CPU mapping code produces the following: - smp_processor_id(): 0 - cpu_logical_map(0): 1 - cpu_number_map(0): 1 This is because SMP isn't supported on BCM6358 since it has a shared TLB, so it is

[PATCH v2] fs/cifs:simplify the return expression of cifs_swn_auth_info_krb

2021-02-23 Thread dingsenjie
From: dingsenjie simplify the return expression. Signed-off-by: dingsenjie --- fs/cifs/cifs_swn.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/cifs/cifs_swn.c b/fs/cifs/cifs_swn.c index d35f599..67b3f4e 100644 --- a/fs/cifs/cifs_swn.c +++ b/fs/cifs/cifs_swn.c

Re: [PATCH] drivers: staging: comedi: Fixed side effects from macro definition.

2021-02-23 Thread Greg Kroah-Hartman
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

[PATCH] powerpc: remove unneeded semicolon

2021-02-23 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./arch/powerpc/kernel/prom_init.c:2986:2-3: Unneeded semicolon. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- arch/powerpc/kernel/prom_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/prom_init.c

Re: [PATCH v1 2/4] clk: rockchip: add dt-binding header for rk3568

2021-02-23 Thread Heiko Stübner
Hi Elaine, Am Mittwoch, 24. Februar 2021, 07:35:30 CET schrieb elaine.zhang: > Hi, Heiko: > > 在 2021/2/23 下午6:45, Heiko Stübner 写道: > > Hi Elaine, > > > > Am Dienstag, 23. Februar 2021, 10:53:50 CET schrieb Elaine Zhang: > >> Add the dt-bindings header for the rk3568, that gets shared between >

[PATCH v2] vio: make remove callback return void

2021-02-23 Thread Uwe Kleine-König
The driver core ignores the return value of struct bus_type::remove() because there is only little that can be done. To simplify the quest to make this function return void, let struct vio_driver::remove() return void, too. All users already unconditionally return 0, this commit makes it obvious

Re: [PATCH v2] mm: vmstat: fix /proc/sys/vm/stat_refresh generating false warnings

2021-02-23 Thread Hugh Dickins
On Thu, 6 Aug 2020, Andrew Morton wrote: > On Thu, 6 Aug 2020 16:38:04 -0700 Roman Gushchin wrote: August, yikes, I thought it was much more recent. > > > it seems that Hugh and me haven't reached a consensus here. > > Can, you, please, not merge this patch into 5.9, so we would have > > more

Re: [PATCH v3 2/3] dt-bindings: usb: generic-ehci: document spurious-oc flag

2021-02-23 Thread Álvaro Fernández Rojas
I didn’t change this, but I missed Alan’s Acked-by, so: Acked-by: Alan Stern > El 23 feb 2021, a las 18:44, Álvaro Fernández Rojas > escribió: > > Over-current reporting isn't supported on some platforms such as bcm63xx. > These devices will incorrectly report over-current if this flag isn't

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Michael S. Tsirkin
On Wed, Feb 24, 2021 at 02:53:08PM +0800, Jason Wang wrote: > > On 2021/2/24 2:46 下午, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 02:04:36PM +0800, Jason Wang wrote: > > > On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: > > > > On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote:

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Eli Cohen
On Wed, Feb 24, 2021 at 02:55:13PM +0800, Jason Wang wrote: > > On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: > > > On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Feb 24, 2021 at 11:20:01AM

Re: linux-next: build warning after merge of the block tree

2021-02-23 Thread Chaitanya Kulkarni
On 2/23/21 21:33, Stephen Rothwell wrote: >>> 1f83bb4b4914 ("blktrace: add blk_fill_rwbs documentation comment") >>> >>> -- Cheers, Stephen Rothwell >> I've failed to understand this warning as rwbs is present in the doc header >> and in the function parameter :- > I presume it is the missing

Re: [PATCH] nand: brcmnand: fix OOB R/W with Hamming ECC

2021-02-23 Thread Álvaro Fernández Rojas
Hi Florian, > El 24 feb 2021, a las 4:46, Florian Fainelli escribió: > > > > On 2/22/2021 12:16 PM, Álvaro Fernández Rojas wrote: >> Hamming ECC doesn't cover the OOB data, so reading or writing OOB shall >> always be done without ECC enabled. >> This is a problem when adding JFFS2

[PATCH v2] kdb: Remove redundant function definitions/prototypes

2021-02-23 Thread Sumit Garg
Cleanup kdb code to get rid of unused function definitions/prototypes. Signed-off-by: Sumit Garg --- Changes in v2: - Keep kdbgetu64arg() the way it was. kernel/debug/kdb/kdb_private.h | 2 -- kernel/debug/kdb/kdb_support.c | 18 -- 2 files changed, 20 deletions(-) diff

[PATCH] mm,hwpoison: return -EBUSY when page already poisoned

2021-02-23 Thread Aili Yao
When the page is already poisoned, another memory_failure() call in the same page now return 0, meaning OK. For nested memory mce handling, this behavior may lead real serious problem, Example: 1.When LCME is enabled, and there are two processes A && B running on different core X && Y separately,

[PATCH] power: supply: max8997-charger: remove unneeded semicolon

2021-02-23 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/power/supply/max8997_charger.c:266:3-4: Unneeded semicolon. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/power/supply/max8997_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] perf daemon: Fix compile error with Asan

2021-02-23 Thread Namhyung Kim
I'm seeing a build failure when build with address sanitizer. It seems we could write to the name[100] if the var is longer. $ make EXTRA_CFLAGS=-fsanitize=address ... CC builtin-daemon.o In function ‘get_session_name’, inlined from ‘session_config’ at builtin-daemon.c:164:6,

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Michael S. Tsirkin
On Wed, Feb 24, 2021 at 02:55:13PM +0800, Jason Wang wrote: > > On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: > > > On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Feb 24, 2021 at 11:20:01AM

Re: [PATCH v3 1/1] arm64: mm: correct the inside linear map range during hotplug check

2021-02-23 Thread Anshuman Khandual
On 2/16/21 8:33 PM, Pavel Tatashin wrote: > Memory hotplug may fail on systems with CONFIG_RANDOMIZE_BASE because the > linear map range is not checked correctly. > > The start physical address that linear map covers can be actually at the > end of the range because of randomization. Check

Re: [PATCH -next] sound: n64: Fix return value check in n64audio_probe()

2021-02-23 Thread Lauri Kasanen
On Wed, 24 Feb 2021 01:38:03 + Wei Yongjun wrote: > In case of error, the function devm_platform_ioremap_resource() > returns ERR_PTR() and never returns NULL. The NULL test in the > return value check should be replaced with IS_ERR(). > > Fixes: 1448f8acf4cc ("sound: Add n64 driver") >

[PATCH 2/2] ASoC: ak5558: Add MODULE_DEVICE_TABLE

2021-02-23 Thread Shengjiu Wang
Add missed MODULE_DEVICE_TABLE for the driver can be loaded automatically at boot. Fixes: 920884777480 ("ASoC: ak5558: Add support for AK5558 ADC driver") Cc: Signed-off-by: Shengjiu Wang --- sound/soc/codecs/ak5558.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/2] ASoC: ak4458: Add MODULE_DEVICE_TABLE

2021-02-23 Thread Shengjiu Wang
Add missed MODULE_DEVICE_TABLE for the driver can be loaded automatically at boot. Fixes: 08660086eff9 ("ASoC: ak4458: Add support for AK4458 DAC driver") Cc: Signed-off-by: Shengjiu Wang --- sound/soc/codecs/ak4458.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2 2/2] irqchip: add support for BCM6345 external interrupt controller

2021-02-23 Thread Álvaro Fernández Rojas
Hi Florian, > El 24 feb 2021, a las 4:43, Florian Fainelli escribió: > > > > On 2/23/2021 12:43 PM, Álvaro Fernández Rojas wrote: >> This interrupt controller is present on bcm63xx SoCs in order to generate >> interrupts based on GPIO status changes. >> >> Signed-off-by: Álvaro Fernández

[PATCH v5] kdb: Simplify kdb commands registration

2021-02-23 Thread Sumit Garg
Simplify kdb commands registration via using linked list instead of static array for commands storage. Signed-off-by: Sumit Garg --- Changes in v5: - Introduce new method: kdb_register_table() to register static kdb main and breakpoint command tables instead of using statically allocated

Re: [PATCH] qtnfmac: remove meaningless labels

2021-02-23 Thread Sergey Matyukevich
> some function's label meaningless, the return statement follows > the goto statement, so just remove it. > > Signed-off-by: wengjianfeng > --- > drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 27 > +-- > 1 file changed, 6 insertions(+), 21 deletions(-) Thanks for

Re: [PATCH] mips: smp-bmips: fix CPU mappings

2021-02-23 Thread Álvaro Fernández Rojas
Hi Florian, > El 24 feb 2021, a las 4:45, Florian Fainelli escribió: > > > > On 2/23/2021 4:48 AM, Álvaro Fernández Rojas wrote: >> When booting bmips with SMP enabled on a BCM6358 running on CPU #1 instead of >> CPU #0, the current CPU mapping code produces the following: >> -

Re: [PATCH V8 1/1] i2c: i2c-qcom-geni: Add shutdown callback for i2c

2021-02-23 Thread Stephen Boyd
Quoting ro...@codeaurora.org (2021-02-18 06:15:17) > Hi Stephen, > > On 2021-01-13 12:24, Stephen Boyd wrote: > > Quoting Roja Rani Yarubandi (2021-01-08 07:05:45) > >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c > >> b/drivers/i2c/busses/i2c-qcom-geni.c > >> index 214b4c913a13..c3f584795911

Re: problems with memory allocation and the alignment check

2021-02-23 Thread Michael J. Baars
On Mon, 2021-02-22 at 01:41 -0800, Andrew Pinski wrote: > On Mon, Feb 22, 2021 at 1:37 AM Michael J. Baars > wrote: > > On Mon, 2021-02-22 at 01:29 -0800, Andrew Pinski wrote: > > > On Mon, Feb 22, 2021 at 1:17 AM Michael J. Baars > > > wrote: > > > > Hi, > > > > > > > > I just wrote this

Re: linux-next: Tree for Feb 24 [drivers/gpu/drm/amd/amdgpu/amdgpu.ko]

2021-02-23 Thread Randy Dunlap
On 2/23/21 7:36 PM, Stephen Rothwell wrote: > Hi all, > > Please do not add any changes destined for v5.13 to your linux-next > included branches until after v5.12-rc1 has been released. > > Changes since 20210223: > on i386: ERROR: modpost: "__udivdi3" [drive

Re: [PATCH] fs/cifs:simplify the return expression of cifs_swn_auth_info_krb

2021-02-23 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on cifs/for-next] [also build test ERROR on v5.11 next-20210223] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 2:47 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021

Re: [PATCH] crypto: testmgr - delete some redundant code

2021-02-23 Thread Eric Biggers
On Tue, Feb 23, 2021 at 11:42:04AM +0800, Kai Ye wrote: > Delete sg_data function, because sg_data function definition same as > sg_virt(), so need to delete it and use sg_virt() replace to sg_data(). > > Signed-off-by: Kai Ye > --- > crypto/testmgr.c | 11 +++ > 1 file changed, 3

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 2:46 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 02:04:36PM +0800, Jason Wang wrote: On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at

Re: [PATCH v1 2/4] clk: rockchip: add dt-binding header for rk3568

2021-02-23 Thread elaine.zhang
Hi, Heiko: 在 2021/2/23 下午6:45, Heiko Stübner 写道: Hi Elaine, Am Dienstag, 23. Februar 2021, 10:53:50 CET schrieb Elaine Zhang: Add the dt-bindings header for the rk3568, that gets shared between the clock controller and the clock references in the dts. Add softreset ID for rk3568.

Re: [PATCH] mtd: rawnand: qcom: update last code word register

2021-02-23 Thread Miquel Raynal
Hello, mda...@codeaurora.org wrote on Wed, 24 Feb 2021 10:09:48 +0530: > On 2021-02-24 01:13, mda...@codeaurora.org wrote: > > On 2021-02-23 22:04, Miquel Raynal wrote: > >> Hello, > >> >> Md Sadre Alam wrote on Tue, 23 Feb 2021 > >> 01:34:27 +0530: > >> >>> From QPIC version 2.0

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Michael S. Tsirkin
On Wed, Feb 24, 2021 at 08:45:20AM +0200, Eli Cohen wrote: > On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: > > > > > > On 2021/2/24 3:35 上午, Si-Wei Liu wrote: > > > > > > > > > > > > On 2/23/2021 5:26 AM,

Re: [PATCH v2] cpufreq: schedutil: Call sugov_update_next_freq() before check to fast_switch_enabled

2021-02-23 Thread Viresh Kumar
On 24-02-21, 14:39, Yue Hu wrote: > From: Yue Hu > > Note that sugov_update_next_freq() may return false, that means the > caller sugov_fast_switch() will do nothing except fast switch check. > > Similarly, sugov_deferred_update() also has unnecessary operations > of raw_spin_{lock,unlock} in

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Michael S. Tsirkin
On Wed, Feb 24, 2021 at 02:04:36PM +0800, Jason Wang wrote: > > On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: > > On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: > > > > > > On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: > > > > On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Eli Cohen
On Wed, Feb 24, 2021 at 12:17:58AM -0500, Michael S. Tsirkin wrote: > On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: > > > > On 2021/2/24 3:35 上午, Si-Wei Liu wrote: > > > > > > > > > On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: > > > > On Tue, Feb 23, 2021 at 10:03:57AM +0800,

Re: [RFC PATCH v5 11/19] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-02-23 Thread Michael S. Tsirkin
On Wed, Feb 24, 2021 at 08:07:48AM +0300, Arseny Krasnov wrote: > > On 23.02.2021 17:17, Michael S. Tsirkin wrote: > > On Thu, Feb 18, 2021 at 08:39:37AM +0300, Arseny Krasnov wrote: > >> This adds transport callback and it's logic for SEQPACKET dequeue. > >> Callback fetches RW packets from rx

[PATCH v2] cpufreq: schedutil: Call sugov_update_next_freq() before check to fast_switch_enabled

2021-02-23 Thread Yue Hu
From: Yue Hu Note that sugov_update_next_freq() may return false, that means the caller sugov_fast_switch() will do nothing except fast switch check. Similarly, sugov_deferred_update() also has unnecessary operations of raw_spin_{lock,unlock} in sugov_update_single_freq() for that case. So,

Re: [PATCH] ath11k: qmi: use %pad to format dma_addr_t

2021-02-23 Thread Kalle Valo
Geert Uytterhoeven wrote: > If CONFIG_ARCH_DMA_ADDR_T_64BIT=n: > > drivers/net/wireless/ath/ath11k/qmi.c: In function > ‘ath11k_qmi_respond_fw_mem_request’: > drivers/net/wireless/ath/ath11k/qmi.c:1690:8: warning: format ‘%llx’ > expects argument of type ‘long long unsigned int’, but

[PATCH] powerpc/syscall: Force inlining of __prep_irq_for_enabled_exit()

2021-02-23 Thread Christophe Leroy
As reported by kernel test robot, a randconfig with high amount of debuging options can lead to build failure for undefined reference to replay_soft_interrupts() on ppc32. This is due to gcc not seeing that __prep_irq_for_enabled_exit() always returns true on ppc32 because it doesn't inline it

Re: [PATCH v4 1/1] kernel/crash_core: Add crashkernel=auto for vmcore creation

2021-02-23 Thread Kairui Song
On Wed, Feb 24, 2021 at 1:45 AM Saeed Mirzamohammadi wrote: > > This adds crashkernel=auto feature to configure reserved memory for > vmcore creation. CONFIG_CRASH_AUTO_STR is defined to be set for > different kernel distributions and different archs based on their > needs. > > Signed-off-by:

Re: linux-next: Signed-off-by missing for commit in the kbuild tree

2021-02-23 Thread Masahiro Yamada
On Wed, Feb 24, 2021 at 12:46 PM Stephen Rothwell wrote: > > Hi all, > > Commit > > 67cbb9c55759 ("Makefile: reuse CC_VERSION_TEXT") > > is missing a Signed-off-by from its committer. Thanks for catching this. I will fix it for tomorrow's linux-next. > -- > Cheers, > Stephen Rothwell --

[PATCH v4 2/2] drm/bridge: anx7625: disable regulators when power off

2021-02-23 Thread Hsin-Yi Wang
When suspending the driver, anx7625_power_standby() will be called to turn off reset-gpios and enable-gpios. However, power supplies are not disabled. To save power, the driver can get the power supply regulators and turn off them in anx7625_power_standby(). Signed-off-by: Hsin-Yi Wang

[PATCH v4 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies

2021-02-23 Thread Hsin-Yi Wang
anx7625 requires 3 power supply regulators. Signed-off-by: Hsin-Yi Wang Reviewed-by: Rob Herring Reviewed-by: Robert Foss --- v3->v4: rebase to drm-misc/for-linux-next --- .../bindings/display/bridge/analogix,anx7625.yaml | 15 +++ 1 file changed, 15 insertions(+) diff --git

[v8,7/7] MAINTAINERS: Add Jianjun Wang as MediaTek PCI co-maintainer

2021-02-23 Thread Jianjun Wang
Update entry for MediaTek PCIe controller, add Jianjun Wang as MediaTek PCI co-maintainer. Signed-off-by: Jianjun Wang Acked-by: Ryder Lee --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 546aa66428c9..bef7f4017473 100644 --- a/MAINTAINERS +++

[v8,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192

2021-02-23 Thread Jianjun Wang
MediaTek's PCIe host controller has three generation HWs, the new generation HW is an individual bridge, it supports Gen3 speed and compatible with Gen2, Gen1 speed. Add support for new Gen3 controller which can be found on MT8192. Signed-off-by: Jianjun Wang Acked-by: Ryder Lee ---

[v8,5/7] PCI: mediatek-gen3: Add MSI support

2021-02-23 Thread Jianjun Wang
Add MSI support for MediaTek Gen3 PCIe controller. This PCIe controller supports up to 256 MSI vectors, the MSI hardware block diagram is as follows: +-+ | GIC | +-+ ^ |

[v8,4/7] PCI: mediatek-gen3: Add INTx support

2021-02-23 Thread Jianjun Wang
Add INTx support for MediaTek Gen3 PCIe controller. Signed-off-by: Jianjun Wang Acked-by: Ryder Lee --- drivers/pci/controller/pcie-mediatek-gen3.c | 176 1 file changed, 176 insertions(+) diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c

[v8,1/7] dt-bindings: PCI: mediatek-gen3: Add YAML schema

2021-02-23 Thread Jianjun Wang
Add YAML schemas documentation for Gen3 PCIe controller on MediaTek SoCs. Signed-off-by: Jianjun Wang Acked-by: Ryder Lee --- .../bindings/pci/mediatek-pcie-gen3.yaml | 181 ++ 1 file changed, 181 insertions(+) create mode 100644

[v8,2/7] PCI: Export pci_pio_to_address() for module use

2021-02-23 Thread Jianjun Wang
This interface will be used by PCI host drivers for PIO translation, export it to support compiling those drivers as kernel modules. Signed-off-by: Jianjun Wang --- drivers/pci/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index

[v8,6/7] PCI: mediatek-gen3: Add system PM support

2021-02-23 Thread Jianjun Wang
Add suspend_noirq and resume_noirq callback functions to implement PM system suspend hooks for MediaTek Gen3 PCIe controller. When system suspend, trigger the PCIe link to L2 state and pull down the PERST# pin, gating the clocks of MAC layer and power off the physical layer for the sake of power

[v8,0/7] PCI: mediatek: Add new generation controller support

2021-02-23 Thread Jianjun Wang
These series patches add pcie-mediatek-gen3.c and dt-bindings file to support new generation PCIe controller. Changes in v8: 1. Add irq_clock to protect IRQ register access; 2. Mask all INTx interrupt when startup port; 3. Remove activate/deactivate callbacks from bottom_domain_ops; 4. Add

[RFC net-next] net: dsa: rtl8366rb: support bridge offloading

2021-02-23 Thread DENG Qingfang
Use port isolation registers to configure bridge offloading. Remove the VLAN init, as we have proper CPU tag and bridge offloading support now. Signed-off-by: DENG Qingfang --- This is not tested, as I don't have a RTL8366RB board. And I think there is potential race condition in

Re: [PATCH 2/2] units: Use the HZ_PER_KHZ macro

2021-02-23 Thread Chanwoo Choi
On 2/24/21 5:30 AM, Daniel Lezcano wrote: > The HZ_PER_KHZ macro definition is duplicated in different subsystems. > > The macro now exists in include/linux/units.h, make use of it and > remove all the duplicated ones. > > Signed-off-by: Daniel Lezcano > --- > drivers/devfreq/devfreq.c

Re: [PATCH] cpufreq: schedutil: Call sugov_update_next_freq() before check to fast_switch_enabled

2021-02-23 Thread Yue Hu
On Wed, 24 Feb 2021 11:32:36 +0530 Viresh Kumar wrote: > On 24-02-21, 13:42, Yue Hu wrote: > > From: Yue Hu > > > > Note that sugov_update_next_freq() may return false, that means the > > caller sugov_fast_switch() will do nothing except fast switch check. > > > > Similarly,

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 1:04 下午, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu wrote: On 2/21/2021 11:34 PM, Michael S.

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Jason Wang
On 2021/2/24 1:17 下午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: On 2021/2/24 3:35 上午, Si-Wei Liu wrote: On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: On 2021/2/23 9:12 上午, Si-Wei Liu

Re: [PATCH] cpufreq: schedutil: Call sugov_update_next_freq() before check to fast_switch_enabled

2021-02-23 Thread Viresh Kumar
On 24-02-21, 13:42, Yue Hu wrote: > From: Yue Hu > > Note that sugov_update_next_freq() may return false, that means the > caller sugov_fast_switch() will do nothing except fast switch check. > > Similarly, sugov_deferred_update() also has unnecessary operations > of raw_spin_{lock,unlock} in

[PATCH] cpufreq: schedutil: Call sugov_update_next_freq() before check to fast_switch_enabled

2021-02-23 Thread Yue Hu
From: Yue Hu Note that sugov_update_next_freq() may return false, that means the caller sugov_fast_switch() will do nothing except fast switch check. Similarly, sugov_deferred_update() also has unnecessary operations of raw_spin_{lock,unlock} in sugov_update_single_freq() for that case. So,

Re: linux-next: build warning after merge of the block tree

2021-02-23 Thread Chaitanya Kulkarni
On 2/23/21 21:33, Stephen Rothwell wrote: >> I've failed to understand this warning as rwbs is present in the doc header >> and in the function parameter :- > I presume it is the missing ':' after @rwbs in the comment. Thanks, I was looking at the wrong places all this time, will send a fix. I'll

this is mail test since the mail also rejected

2021-02-23 Thread campion test

[PATCH v2 2/3] scsi: ufs-qcom: Disable interrupt in reset path

2021-02-23 Thread Can Guo
From: Nitin Rawat Disable interrupt in reset path to flush pending IRQ handler in order to avoid possible NoC issues. Signed-off-by: Nitin Rawat Signed-off-by: Can Guo --- drivers/scsi/ufs/ufs-qcom.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/ufs/ufs-qcom.c

[PATCH v2 1/3] scsi: ufs: Minor adjustments to error handling

2021-02-23 Thread Can Guo
In error handling prepare stage, after SCSI requests are blocked, do a down/up_write(clk_scaling_lock) to clean up the queuecommand() path. Meanwhile, stop eeh_work in case it disturbs error recovery. Moreover, reset ufshcd_state at the entrance of ufshcd_probe_hba(), since it may be called

[PATCH v2 3/3] scsi: ufs: Remove redundant checks of !hba in suspend/resume callbacks

2021-02-23 Thread Can Guo
Runtime and system suspend/resume can only come after hba probe invokes platform_set_drvdata(pdev, hba), meaning hba cannot be NULL in these PM callbacks, so remove the checks of !hba. Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 21 - 1 file changed, 21

Re: [PATCH v8 17/22] counter: Add character device interface

2021-02-23 Thread William Breathitt Gray
On Sun, Feb 14, 2021 at 06:06:12PM +, Jonathan Cameron wrote: > On Fri, 12 Feb 2021 21:13:41 +0900 > William Breathitt Gray wrote: > > > This patch introduces a character device interface for the Counter > > subsystem. Device data is exposed through standard character device read > >

Re: linux-next: build warning after merge of the block tree

2021-02-23 Thread Stephen Rothwell
Hi Chaitanya, On Wed, 24 Feb 2021 05:25:49 + Chaitanya Kulkarni wrote: > > On 2/23/21 18:31, Stephen Rothwell wrote: > > Hi all, > > > > After merging the block tree, today's linux-next build (htmldocs) > > produced this warning: > > > > kernel/trace/blktrace.c:1878: warning: Function

Re: [PATCH] kdb: Remove redundant function definitions/prototypes

2021-02-23 Thread Sumit Garg
On Tue, 23 Feb 2021 at 21:39, Doug Anderson wrote: > > Hi, > > On Tue, Feb 23, 2021 at 4:01 AM Sumit Garg wrote: > > > > @@ -103,7 +103,6 @@ extern int kdb_getword(unsigned long *, unsigned long, > > size_t); > > extern int kdb_putword(unsigned long, unsigned long, size_t); > > > > extern int

Re: [PATCH v2 03/10] mm: don't pass "enum lru_list" to lru list addition functions

2021-02-23 Thread Yu Zhao
On Tue, Feb 23, 2021 at 02:50:11PM -0800, Andrew Morton wrote: > On Tue, 26 Jan 2021 15:14:38 -0700 Yu Zhao wrote: > > > On Tue, Jan 26, 2021 at 10:01:11PM +, Matthew Wilcox wrote: > > > On Fri, Jan 22, 2021 at 03:05:53PM -0700, Yu Zhao wrote: > > > > +++ b/mm/swap.c > > > > @@ -231,7 +231,7

Re: [PATCH] kernel: debug: Handle breakpoints in kernel .init.text section

2021-02-23 Thread Sumit Garg
On Tue, 23 Feb 2021 at 18:24, Daniel Thompson wrote: > > On Tue, Feb 23, 2021 at 02:33:50PM +0530, Sumit Garg wrote: > > Thanks Doug for your comments. > > > > On Tue, 23 Feb 2021 at 05:28, Doug Anderson wrote: > > > > To be clear there is still a very small window between call to > > > >

Re: [PATCH] arm64: enable GENERIC_FIND_FIRST_BIT

2021-02-23 Thread Yury Norov
On Tue, Dec 08, 2020 at 10:35:50AM +, Will Deacon wrote: > On Mon, Dec 07, 2020 at 05:59:16PM -0800, Yury Norov wrote: > > (CC: Alexey Klimov) > > > > On Mon, Dec 7, 2020 at 3:25 AM Will Deacon wrote: > > > > > > On Sat, Dec 05, 2020 at 08:54:06AM -0800, Yury Norov wrote: > > > > ARM64

Re: linux-next: build warning after merge of the block tree

2021-02-23 Thread Chaitanya Kulkarni
Stephen, On 2/23/21 18:31, Stephen Rothwell wrote: > Hi all, > > After merging the block tree, today's linux-next build (htmldocs) > produced this warning: > > kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs' > not described in 'blk_fill_rwbs'` > > Introduced by commit

RE: [Linuxarm] Re: [PATCH for-next 00/32] spin lock usage optimization for SCSI drivers

2021-02-23 Thread Finn Thain
On Tue, 23 Feb 2021, Song Bao Hua (Barry Song) wrote: > > > > Regarding m68k, your analysis overlooks the timing issue. E.g. patch > > 11/32 could be a problem because removing the irqsave would allow PDMA > > transfers to be interrupted. Aside from the timing issues, I agree > > with your

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Michael S. Tsirkin
On Wed, Feb 24, 2021 at 11:20:01AM +0800, Jason Wang wrote: > > On 2021/2/24 3:35 上午, Si-Wei Liu wrote: > > > > > > On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: > > > On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: > > > > On 2021/2/23 9:12 上午, Si-Wei Liu wrote: > > > > > > > >

Re: [PATCH v10 2/5] sched: CGroup tagging interface for core scheduling

2021-02-23 Thread Josh Don
On Tue, Feb 23, 2021 at 11:26 AM Chris Hyser wrote: > > On 2/23/21 4:05 AM, Peter Zijlstra wrote: > > On Mon, Feb 22, 2021 at 11:00:37PM -0500, Chris Hyser wrote: > >> On 1/22/21 8:17 PM, Joel Fernandes (Google) wrote: > >> While trying to test the new prctl() code I'm working on, I ran into a

[PATCH v5 2/2] ufs: sysfs: Resume the proper scsi device

2021-02-23 Thread Asutosh Das
Resumes the actual scsi device the unit descriptor of which is being accessed instead of the hba alone. Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufs-sysfs.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/ufs/ufs-sysfs.c

[PATCH v5 1/2] scsi: ufs: Enable power management for wlun

2021-02-23 Thread Asutosh Das
During runtime-suspend of ufs host, the scsi devices are already suspended and so are the queues associated with them. But the ufs host sends SSU to wlun during its runtime-suspend. During the process blk_queue_enter checks if the queue is not in suspended state. If so, it waits for the queue to

Re: [RFC PATCH v5 11/19] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-02-23 Thread Arseny Krasnov
On 23.02.2021 17:17, Michael S. Tsirkin wrote: > On Thu, Feb 18, 2021 at 08:39:37AM +0300, Arseny Krasnov wrote: >> This adds transport callback and it's logic for SEQPACKET dequeue. >> Callback fetches RW packets from rx queue of socket until whole record >> is copied(if user's buffer is full,

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote: > > > On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote: > > On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote: > > > On 2021/2/23 9:12 上午, Si-Wei Liu wrote: > > > > > > > > On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote: > > >

Re: [PATCH 00/33] Network fs helper library & fscache kiocb API [ver #3]

2021-02-23 Thread Steve French
On Tue, Feb 23, 2021 at 2:28 PM Matthew Wilcox wrote: > > On Mon, Feb 15, 2021 at 11:22:20PM -0600, Steve French wrote: > > On Mon, Feb 15, 2021 at 8:10 PM Matthew Wilcox wrote: > > > The switch from readpages to readahead does help in a couple of corner > > > cases. For example, if you have

[PATCH v24 3/4] scsi: ufs: Prepare HPB read for cached sub-region

2021-02-23 Thread Daejun Park
This patch changes the read I/O to the HPB read I/O. If the logical address of the read I/O belongs to active sub-region, the HPB driver modifies the read I/O command to HPB read. It modifies the UPIU command of UFS instead of modifying the existing SCSI command. In the HPB version 1.0, the

[PATCH v24 4/4] scsi: ufs: Add HPB 2.0 support

2021-02-23 Thread Daejun Park
This patch supports the HPB 2.0. The HPB 2.0 supports read of varying sizes from 4KB to 512KB. In the case of Read (<= 32KB) is supported as single HPB read. In the case of Read (36KB ~ 512KB) is supported by as a combination of write buffer command and HPB read command to deliver more PPN. The

  1   2   3   4   5   6   7   8   9   10   >