[PATCH V3 2/2] It makes the code clearer and less error prone.

2017-08-02 Thread Federico Vaga
using it. Later it can be decided to use only POSIX functions, then we can easly replace all the `asprintf(3)` with a local implementation of that function. Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- event-plugin.c | 24 -- parse-filter.c

Re: [PATCH V3 2/2] It makes the code clearer and less error prone.

2017-08-15 Thread Federico Vaga
On Monday, August 14, 2017 7:33:41 PM CEST Steven Rostedt wrote: > On Thu, 3 Aug 2017 00:15:58 +0200 > Federico Vaga <federico.v...@vaga.pv.it> wrote: > > Why did you change the subject? The previous patch had a much better > one: "trace-cmd: Use asprintf when possib

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

2017-07-09 Thread Federico Vaga
On Friday, July 7, 2017 12:25:32 AM CEST Steven Rostedt wrote: > On Mon, 5 Jun 2017 11:31:17 +0200 > Federico Vaga <federico.v...@vaga.pv.it> wrote: > > Hi Federico, > > I finally got around to looking at these. Sorry for the really slow > reply, but I had a bunch of

Re: [PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file()

2017-07-09 Thread Federico Vaga
On Friday, July 7, 2017 12:29:35 AM CEST Steven Rostedt wrote: > On Mon, 5 Jun 2017 11:31:18 +0200 > > Federico Vaga <federico.v...@vaga.pv.it> wrote: > > show_file(name) and show_instance_file(_instance, name) are > > equivalent. > > > > Remove th

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

2017-07-25 Thread Federico Vaga
Hi Steven, I found some free time and unfortunately I can't enjoy the sun, so here I am on this patch. Before submitting the V2, one comment (inline) On Monday, July 10, 2017 2:08:41 AM CEST Federico Vaga wrote: > On Friday, July 7, 2017 12:25:32 AM CEST Steven Rostedt wrote: > > On Mo

[PATCH 1/2] trace-cmd: uniform command implementation

2017-04-26 Thread Federico Vaga
Most of the commands have the implementation in a dedicated file. Those commands without a dedicated file are implemented in the `main()` function. This patch uniform the code by moving the commands implemented in the `main()` function to dedicated files. Signed-off-by: Federico Vaga <federic

[PATCH 2/2] trace-cmd: improve main readability

2017-04-26 Thread Federico Vaga
Since now there is an uniform command implementation I can reduce the `main()` function to the minimum by using a lookup table. People can now directly focus on a command implementation because there is "nothing" in the `main()` function. Signed-off-by: Federico Vaga <federico.v.

trace-cmd improve main() function

2017-04-26 Thread Federico Vaga
In two steps I tried to improve the `main()` function. The reason for those patches is that the current `main()` function is doing much more than the necessary (implementing commands); this makes the code not uniform and less clear. Tests Since those patches are mainly, copy & paste and

Re: [PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file()

2017-07-31 Thread Federico Vaga
On Mon, Jul 31, 2017 at 03:35:39PM -0400, Steven Rostedt wrote: On Mon, 10 Jul 2017 02:15:35 +0200 Federico Vaga <federico.v...@vaga.pv.it> wrote: On Friday, July 7, 2017 12:29:35 AM CEST Steven Rostedt wrote: > On Mon, 5 Jun 2017 11:31:18 +0200 > > Federico Vaga <federi

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

2017-07-31 Thread Federico Vaga
Hi Steven, On Mon, Jul 31, 2017 at 03:33:40PM -0400, Steven Rostedt wrote: On Tue, 25 Jul 2017 16:21:11 +0200 Federico Vaga <federico.v...@vaga.pv.it> wrote: I found some free time and unfortunately I can't enjoy the sun, so here I am on this patch. Before submitting the V2, one c

[PATCH V2 1/2] trace-cmd: use asprintf when possible

2017-08-02 Thread Federico Vaga
` is not POSIX standard but the program was already using it. Later it can be decided to use only POSIX functions, then we can easly replace all the `asprintf(3)` with a local implementation of that function. Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- event-plugin.c

[PATCH 1/2] trace-cmd: use asprintf when possible

2017-06-05 Thread Federico Vaga
` is not POSIX standard but the program was already using it. Later it can be decided to use only POSIX functions, then we can easly replace all the `asprintf(3)` with a local implementation of that function. Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- event-plugin.c

Minor Code Clean Up

2017-06-05 Thread Federico Vaga
A couple of patches that try to make consistent the usage of `asprintf(3)` and `show_instance_file()`.

[PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file()

2017-06-05 Thread Federico Vaga
show_file(name) and show_instance_file(_instance, name) are equivalent. Remove the show_file() function in order to have a single function for this task. Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- trace-list.c | 21 ++--- trace-local.h| 2 --

kernFS/sysfs: mmap and vm_operations close

2017-09-26 Thread Federico Vaga
t;cannot" keep the device memory mapped when nobody is using it, that's why I would like to be able to use vm_ops->close(). In general, I would like to run my routine that release resources when the user does `munmap` or `close` thank you very much :) -- Federico Vaga http://www.federicovaga.it

Re: kernFS/sysfs: mmap and vm_operations close

2017-09-27 Thread Federico Vaga
On Tuesday, 26 September 2017 23:31:29 CEST Greg Kroah-Hartman wrote: > On Tue, Sep 26, 2017 at 05:50:55PM +0200, Federico Vaga wrote: > > Hello, > > > > I'm writing a sysfs binary attribute that makes use of the `mmap` > > operation. > Eeek, why? What are you usin

Re: kernFS/sysfs: mmap and vm_operations close

2017-09-27 Thread Federico Vaga
On Wednesday, 27 September 2017 09:45:51 CEST Greg Kroah-Hartman wrote: > On Wed, Sep 27, 2017 at 08:41:12AM +0200, Federico Vaga wrote: > > On Tuesday, 26 September 2017 23:31:29 CEST Greg Kroah-Hartman wrote: > > > On Tue, Sep 26, 2017 at 05:50:55PM +0200, Federico Vaga wrote:

[PATCH] trace-cmd:show: be picky on user argument 'cpu'

2017-12-05 Thread Federico Vaga
Before this patch the following command worked without errors: trace-cmd show -c b This command opens the CPU0 files. From `strace(1)`: openat(AT_FDCWD, "/sys/kernel/tracing/per_cpu/cpu0/trace", O_RDONLY) = 3 Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> ---

[PATCH 3/5] doc: add Italian translation skeleton

2018-05-27 Thread Federico Vaga
Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> Signed-off-by: Alessia Mantegazza <amantega...@vaga.pv.it> --- Documentation/index.rst| 8 ++ .../translations/it_IT/disclaimer-ita.rst | 11 +++ Documentation/translations/it_

[PATCH 4/5] doc:it_IT: add doc-guide translation

2018-05-27 Thread Federico Vaga
Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> Signed-off-by: Alessia Mantegazza <amantega...@vaga.pv.it> --- .../translations/it_IT/doc-guide/hello.dot | 3 + .../translations/it_IT/doc-guide/index.rst | 24 ++ .../translations/it_IT/doc-guide/kernel-doc.

Re: doc: Italian translation

2018-05-28 Thread Federico Vaga
On Monday, 28 May 2018 15:08:28 CEST Jonathan Corbet wrote: > On Sun, 27 May 2018 16:55:55 +0200 > > Federico Vaga <federico.v...@vaga.pv.it> wrote: > > here the doc-guide translated in Italian. This set of patches > > includes some minor changes to the main one. The

[PATCH] i2c: ocores: update HDL sources URL

2018-05-28 Thread Federico Vaga
The URL is broken. This patch fix it Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- drivers/i2c/busses/i2c-ocores.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index 8c42ca7107b2..14c5f6

[PATCH 1/5] doc: typos and minor fixes

2018-05-27 Thread Federico Vaga
Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- Documentation/doc-guide/kernel-doc.rst| 2 +- Documentation/doc-guide/parse-headers.rst | 4 ++-- Documentation/doc-guide/sphinx.rst| 4 ++-- Documentation/index.rst | 2 +- Documentation/sphinx

[PATCH 2/5] doc: add chapter labels

2018-05-27 Thread Federico Vaga
The idea is to make it easier to create references (doc-guide does the same). Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- Documentation/index.rst| 2 ++ Documentation/kernel-hacking/index.rst | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Documen

doc: Italian translation

2018-05-27 Thread Federico Vaga
Ciao Jonathan, here the doc-guide translated in Italian. This set of patches includes some minor changes to the main one. The idea of this first set of patches is also to adjust the structure and our expectations. We tried to translate everything in **Italian**; which means that we avoided

i2c: Open Core driver

2018-05-28 Thread Federico Vaga
Sorry for the SPAM, I re-send the patch because I missed the documentation file. This patch is (should) the good one :)

[PATCH V2] i2c: ocores: update HDL sources URL

2018-05-28 Thread Federico Vaga
The URL is broken. This patch fix it Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- Documentation/i2c/busses/i2c-ocores | 2 +- drivers/i2c/busses/i2c-ocores.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/i2c/busses/i2c-oco

[PATCH 2/3] i2c:ocores: do not handle IRQ if IF is not set

2018-06-25 Thread Federico Vaga
If the Interrupt Flag (IF) is not set, we should not handle the IRQ: - the line can be shared with other devices - it can be a spurious interrupt To avoid reading twice the status register, the ocores_process() function expects it to be read by the caller. Signed-off-by: Federico Vaga

[PATCH 1/3] i2c:ocores: stop transfer on timeout

2018-06-25 Thread Federico Vaga
is taken is because we are in timeout, so there is no need to process the IRQ. Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c

[PATCH 3/3] i2c:ocores: add polling interface

2018-06-25 Thread Federico Vaga
This driver assumes that an interrupt line is always available for the I2C master. This is not always the case and this patch adds support for a polling version based on workqueue. Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 94 ++--- 1

i2c:ocores: fixes and polling mechanism

2018-06-25 Thread Federico Vaga
The first two patches fix what I believe are bugs. The third patch add a polling mechanism for those systems where interrupts are not available. All these patches have been tested on a system without interrupt, this means that I used my third patch to validate also the other two. I would be nice

Re: fpga: fpga_mgr_get() buggy ?

2018-06-27 Thread Federico Vaga
Hi Alan, On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: > On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga > wrote: > > Hi Federico, > > >> > What is buggy is the function fpga_mgr_get(). > >> > That patch has been done to allow multiple FPGA manag

fpga: fpga_mgr_get() buggy ?

2018-06-21 Thread Federico Vaga
Hello, I believe that this patch fpga: manager: change api, don't use drvdata 7085e2a94f7df5f419e3cfb2fe809ce6564e9629 is incomplete and buggy. I completely agree that drvdata should not be used by the FPGA manager or any other subsystem like that. What is buggy is the function

Re: fpga: fpga_mgr_get() buggy ?

2018-06-22 Thread Federico Vaga
Hi Alan, inline comments On Friday, 22 June 2018 04:07:41 CEST Alan Tull wrote: > On Thu, Jun 21, 2018 at 8:13 AM, Federico Vaga > wrote: > > Hi Federico, > > Thanks for the analysis. I'll probably not be able to look into > this very much until next week. A few note

Re: [PATCH 1/2] fpga: Document when fpga_blah_free functions should be used

2018-07-26 Thread Federico Vaga
egistered, it > would be a bug to call fpga_(mgr|bridge|region)_free. > > Signed-off-by: Alan Tull > Suggested-by: Florian Fainelli > Suggested-by: Federico Vaga > --- > drivers/fpga/fpga-bridge.c | 10 +- > drivers/fpga/fpga-mgr.c| 10 +- &

Re: fpga: fpga_mgr_free usage

2018-07-26 Thread Federico Vaga
On Wednesday, July 25, 2018 6:33:44 PM CEST Alan Tull wrote: > On Wed, Jul 11, 2018 at 10:59 AM, Alan Tull wrote: > > On Wed, Jul 11, 2018 at 7:38 AM, Federico Vaga > > wrote: > > > > Hi Federico, > > > >> Hi Alan, > >> > >> I

Re: fpga: fpga_mgr_get() buggy ?

2018-08-16 Thread Federico Vaga
Hi alan, inline comments On Wednesday, August 15, 2018 11:02:12 PM CEST Alan Tull wrote: > On Wed, Jul 18, 2018 at 4:47 PM, Federico Vaga wrote: > > Hi Alan, > > > > Thanks for your time, comments below > > > > On Wednesday, July 18, 2018 9:47:24 PM CEST Ala

Re: i2c:ocores: fixes and polling mechanism

2018-08-11 Thread Federico Vaga
Hello, sorry to disturb you all but after one month and a half I never received any comment about this patch set and I fear it ended up in a forgotten corner. I would like to know if someone is considering it or not. Thanks :) On Monday, June 25, 2018 6:13:00 PM CEST Federico Vaga wrote

Re: fpga: fpga_mgr_get() buggy ?

2018-07-18 Thread Federico Vaga
Hi Alan, Thanks for your time, comments below On Wednesday, July 18, 2018 9:47:24 PM CEST Alan Tull wrote: > On Thu, Jun 28, 2018 at 2:50 AM, Federico Vaga wrote: > > On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: > >> On Wed, Jun 27, 2018 at 4:25 AM, Federico Va

fpga: fpga_mgr_free usage

2018-07-11 Thread Federico Vaga
Hi Alan, I have another point that I would like to discuss. It is about the usage of 'fpga_mgr_free()' which does not look like consistent. This function, according to the current implementation, can be used by an FPGA manager user and it is used by the FPGA manager itself on device release.

Re: fpga: fpga_mgr_get() buggy ?

2018-06-28 Thread Federico Vaga
On Wednesday, 27 June 2018 23:23:07 CEST Alan Tull wrote: > On Wed, Jun 27, 2018 at 4:25 AM, Federico Vaga wrote: > > Hi Alan, > > > > On Tuesday, 26 June 2018 23:00:46 CEST Alan Tull wrote: > >> On Fri, Jun 22, 2018 at 2:53 AM, Federico Vaga >

Re: [PATCH 3/3] i2c:ocores: add polling interface

2018-10-24 Thread Federico Vaga
On Sunday, October 21, 2018 4:39:07 PM CEST Peter Korsgaard wrote: > On Mon, Jun 25, 2018 at 6:14 PM Federico Vaga wrote: > > This driver assumes that an interrupt line is always available for > > the I2C master. This is not always the case and this patch adds support > >

Re: [PATCH 1/3] i2c:ocores: stop transfer on timeout

2018-10-24 Thread Federico Vaga
On Sunday, October 21, 2018 4:10:30 PM CEST Peter Korsgaard wrote: > On Mon, Jun 25, 2018 at 6:14 PM Federico Vaga wrote: > > Hi, and sorry for the slow response. > > > Detecting a timeout is ok, but we also need to assert a STOP command on > > the bus in order to pr

Re: [PATCH 3/3] i2c:ocores: add polling interface

2018-10-29 Thread Federico Vaga
Hi Peter, On Friday, October 26, 2018 7:45:29 PM CET Peter Korsgaard wrote: > >>>>> "Federico" == Federico Vaga writes: > Hi, > > >> > - } else > >> > + } else { > >> > &g

Re: [PATCH 3/3] i2c:ocores: add polling interface

2018-10-29 Thread Federico Vaga
On Monday, October 29, 2018 2:04:13 PM CET Peter Korsgaard wrote: > > I think that something like this could be better > > > > (2) usleep_range(sleep_min, sleep_min * XXX); > > > > But. > > Since it is better to make this patch ready for xfer_irqless, then I will > > definitively go for

Re: [PATCH 3/3] i2c:ocores: add polling interface

2018-10-25 Thread Federico Vaga
(sorry for the noise, peter's email I had does not exist, so I'm resending this email with the correct address) On Sunday, October 21, 2018 4:39:07 PM CEST Peter Korsgaard wrote: > On Mon, Jun 25, 2018 at 6:14 PM Federico Vaga wrote: > > This driver assumes that an interrupt line

[RFC] Proposal for FMC Subsystem Eradication

2018-10-29 Thread Federico Vaga
=== The fmc-bus Eradication === The *fmc-bus* Linux sub-system was developed under CERN supervision around 2012. During these years, the fmc-bus has evolved and drivers for particular FMC applications (FMC DEL, FMC ADC, FMC TDC, etc.) have been based on it.

Re: [PATCH 2/3] i2c:ocores: do not handle IRQ if IF is not set

2018-10-29 Thread Federico Vaga
On Monday, October 29, 2018 9:53:01 AM CET Wolfram Sang wrote: > On Sun, Oct 21, 2018 at 04:12:10PM +0200, Peter Korsgaard wrote: > > On Mon, Jun 25, 2018 at 6:14 PM Federico Vaga wrote: > > > If the Interrupt Flag (IF) is not set, we should not handle the IRQ: > > &g

[PATCH V2 0/5] i2c:ocores: improvements

2018-10-29 Thread Federico Vaga
This patch set provides improvements to the i2c-ocore driver. [V1 -> V2] - replaced usleep_range() with udelay() so that the polling version can be used in atomic context. - added dedicated patch for minor style issues - fixed delay computation - use spin_lock_irqsave(), instead of

[PATCH V2 1/5] i2c:ocores: stop transfer on timeout

2018-10-29 Thread Federico Vaga
a new function to handle timeout - modified the current ocores_process() function in order to be protected by the new spinlock Like this it is obvious at first sight that this locking serializes the execution of ocores_process() and ocores_process_timeout() Signed-off-by: Federico Vaga

[PATCH V2 4/5] i2c:ocores: add SPDX tag

2018-10-29 Thread Federico Vaga
It adds the SPDX tag and it removes the old text about the GPLv2. Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index 2d71f11..e48173b

[PATCH V2 3/5] i2c:ocores: add polling interface

2018-10-29 Thread Federico Vaga
This driver assumes that an interrupt line is always available for the I2C master. This is not always the case and this patch adds support for a polling version. Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 171 +++- 1 file changed, 151

[PATCH V2 2/5] i2c:ocores: do not handle IRQ if IF is not set

2018-10-29 Thread Federico Vaga
If the Interrupt Flag (IF) is not set, we should not handle the IRQ: - the line can be shared with other devices - it can be a spurious interrupt To avoid reading twice the status register, the ocores_process() function expects it to be read by the caller. Signed-off-by: Federico Vaga Acked

[PATCH V2 5/5] i2c:ocores: checkpatch fixes

2018-10-29 Thread Federico Vaga
Miscellaneous style fixes from checkpatch Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index e48173b..52c062b 100644

Re: [PATCH 1/3] i2c:ocores: stop transfer on timeout

2018-10-25 Thread Federico Vaga
(sorry for the noise, peter's email I had does not exist, so I'm resending this email with the correct address) On Sunday, October 21, 2018 4:10:30 PM CEST Peter Korsgaard wrote: > On Mon, Jun 25, 2018 at 6:14 PM Federico Vaga wrote: > > Hi, and sorry for the slow response. > &

[PATCH 1/2] doc:process: add links where missing

2018-11-20 Thread Federico Vaga
Some documents are refering to others without links. With this patch I add those missing links. This patch affects only documents under process/ and labels where necessary. Signed-off-by: Federico Vaga --- Documentation/admin-guide/devices.rst| 1 + Documentation/dev-tools

DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-16 Thread Federico Vaga
? Or it is work in progress right now (soon), so it is better to wait after the merge? In order to use the s3c-hsotg I must implement a PCI wrapper that uses this driver. It will be accepted in the kernel even if it will be removed sooner or later because of the driver merge? Thank you :) -- Federico Vaga

Re: DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-16 Thread Federico Vaga
Thank you Felipe [add CC Giancarlo from ST] On Tuesday 16 July 2013 15:04:25 Felipe Balbi wrote: > Hi, > > On Tue, Jul 16, 2013 at 02:01:33PM +0200, Federico Vaga wrote: > > Hello, > > > > I have an x86 board made by STMicroelectronics (STA2X11) with the Synops

[PATCH] dwc2/pci.c: add STMICRO vendor and device ID for STA2X11 board

2013-05-13 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/staging/dwc2/pci.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c index 69c65eb..7029b9f 100644 --- a/drivers/staging/dwc2/pci.c +++ b/drivers/staging/dwc2/pci.c

[RFC] assign some address families for local use

2013-05-16 Thread Federico Vaga
I attached to this email the patch that do these stuff. -- Federico Vaga>From 8ce4f2576aa8e95ea22921c31bdffd049460951d Mon Sep 17 00:00:00 2001 From: Federico Vaga Date: Wed, 15 May 2013 12:32:03 +0200 Subject: [PATCH] include/linux/socket.h: assign address families for local use The patch ass

[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-05 Thread Federico Vaga
ones from videobuf2 and v4l2_fh Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1073 +-- 2 file modificati, 434 inserzioni(+), 641 rimozioni(-) diff --git

Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-06 Thread Federico Vaga
you did that, right? Just checking...), that > these are really useful improvements, and that I reviewed the code > (as well as I could) and didn't see any problems, I'm giving my ack > anyway: Tested every time I sent a patch > Acked-by: Hans Verkuil Thank you again -- Federico Vaga -

drivers/base/core.c: about device_find_child() function

2013-04-11 Thread Federico Vaga
) and put_device(). If the driver do not need to get_device() on a child device, it simply does a device_search_child() to retrieve a pointer. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mo

[PATCH] base/core.c: improve comment of the function device_find_child()

2013-04-12 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/base/core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 016312437..eb0c6ea 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1372,6 +1372,10 @@ int device_for_each_child(struct

Re: drivers/base/core.c: about device_find_child() function

2013-04-12 Thread Federico Vaga
On Thursday 11 April 2013 06:48:44 Greg Kroah-Hartman wrote: > On Thu, Apr 11, 2013 at 01:52:36PM +0200, Federico Vaga wrote: > > Hello, > > > > I'm using the function device_find_child() [drivers/base/core.c] to > > retrieve a specific child of a device. I see

Re: [PATCH] base/core.c: improve comment of the function device_find_child()

2013-04-15 Thread Federico Vaga
On Friday 12 April 2013 14:51:25 Greg Kroah-Hartman wrote: > On Fri, Apr 12, 2013 at 01:59:32PM +0200, Federico Vaga wrote: > > Signed-off-by: Federico Vaga > > --- > > > > drivers/base/core.c | 4 > > 1 file changed, 4 insertions(+) > > > > di

Re: drivers/base/core.c: about device_find_child() function

2013-04-15 Thread Federico Vaga
not need to put_device(). But I think that is not a strong argumentation, and later in time someone will propose his own special use of device_for_each_child(). I think that device_for_each_child() is generic enough to cover this problem. -- Federico Vaga -- To unsubscribe from this list: send

Re: drivers/base/core.c: about device_find_child() function

2013-04-15 Thread Federico Vaga
> if (!enable_irq_wake(uport->irq)) > > > > uport->irq_wake = 1; > > > > put_device(tty_dev); > > mutex_unlock(>mutex); > > return 0; > > > > } > > > >

[PATCH v2] base/core.c: improve comment of the function device_find_child()

2013-04-15 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/base/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 016312437..3c8512f 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1372,6 +1372,8 @@ int device_for_each_child(struct device

[PATCH] serial_core.c: add put_device() after device_find_child()

2013-04-15 Thread Federico Vaga
The serial core uses device_find_child() but does not drop the reference to the retrieved child after using it. This patch add the missing put_device(). Signed-off-by: Federico Vaga --- What I have done to test this issue. I used a machine with an AMBA PL011 serial driver. I tested the patch

[RFC PATCH] sparc/kernel/vio.c: add put_device() after device_find_child()

2013-04-15 Thread Federico Vaga
The vio_remove() function uses device_find_child() but it does not drop the reference of the retrieved child. Signed-off-by: Federico Vaga --- I do not have a SPARC system (and I do not know it), so I cannot test this patch. Please test it. If I'm right, the device_unregister() does not work

Re: DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-22 Thread Federico Vaga
th wrapper (PCI, platform), but I do not know how much time does it takes because I am really busy at the moment You know the hardware better than me, so: have you other suggestion to point me on the right way? Thank you :) -- Federico Vaga -- To unsubscribe from this list: send the line "

[PATCH] net/core/sock.c: add missing VSOCK string in af_family_*_key_strings

2013-05-28 Thread Federico Vaga
The three arrays of strings: af_family_kay_strings, af_family_slock_key_strings and af_family_clock_key_strings have not VSOCK's string Signed-off-by: Federico Vaga --- net/core/sock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/core/sock.c b/net/core/sock.c

[PATCH] ipoctal: protect only the real critical section

2014-06-26 Thread Federico Vaga
ere; it means that it is not protected at all. Signed-off-by: Federico Vaga --- drivers/ipack/devices/ipoctal.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c index 141094e..69687f1 100644 --- a/drivers/ip

Re: PCIe bus enumeration

2014-07-07 Thread Federico Vaga
On Friday 04 July 2014 15:26:12 Bjorn Helgaas wrote: > On Fri, Jul 04, 2014 at 09:55:20AM +0200, Federico Vaga wrote: > > > I assume these ports don't support hotplug. If they *did* > > > support > > > hotplug, those ports would have to exist because they handle the

Re: PCIe bus enumeration

2014-07-08 Thread Federico Vaga
> There's a fair > amount of stuff in the PCI-to-PCI bridge spec about slot and chassis > numbering, including some about expansion chassis. I doubt that > Linux implements all that, so there's probably room for a lot of > improvement. I attached your lspci output to the bugz

Re: PCIe bus enumeration

2014-07-08 Thread Federico Vaga
On Tuesday 08 July 2014 12:23:39 Bjorn Helgaas wrote: > On Tue, Jul 8, 2014 at 1:15 AM, Federico Vaga wrote: > >> > So, It looks like that some BIOS disable the bridge when there > >> > is > >> > nothing behind it. Why? Power save? :/ > >> >

[PATCH] ipoctal: request_irq after configuration

2014-07-03 Thread Federico Vaga
handler. Signed-off-by: Federico Vaga --- drivers/ipack/devices/ipoctal.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c index a7ec6f9..72fd761 100644 --- a/drivers/ipack/devices/ipoctal.c

PCIe bus enumeration

2014-07-03 Thread Federico Vaga
to inspect everything. bfsort : because, maybe, for a bfsort it must assign a number to each bridge at the same level before inspect the next one. noacpi : in order to scan independently from BIOS information The result is always the same (empty buses are not enumerated). Thank you :) -- Fed

Re: PCIe bus enumeration

2014-07-03 Thread Federico Vaga
(Sorry for double emailing, a sw update changes my configuration to HTML email as default.So, the linux kernel mailing list complains that probably I'm spamming) On Thursday 03 July 2014 13:43:14 Bjorn Helgaas wrote: > On Thu, Jul 3, 2014 at 10:45 AM, Federico Vaga wrote: > &

Re: PCIe bus enumeration

2014-08-07 Thread Federico Vaga
On Tuesday 08 July 2014 14:27:00 Bjorn Helgaas wrote: > On Tue, Jul 8, 2014 at 1:20 PM, Federico Vaga wrote: > > On Tuesday 08 July 2014 12:23:39 Bjorn Helgaas wrote: > >> On Tue, Jul 8, 2014 at 1:15 AM, Federico Vaga > > > > wrote: > >> >> > So,

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

2017-07-25 Thread Federico Vaga
Hi Steven, I found some free time and unfortunately I can't enjoy the sun, so here I am on this patch. Before submitting the V2, one comment (inline) On Monday, July 10, 2017 2:08:41 AM CEST Federico Vaga wrote: > On Friday, July 7, 2017 12:25:32 AM CEST Steven Rostedt wrote: > > On Mo

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

2017-07-31 Thread Federico Vaga
Hi Steven, On Mon, Jul 31, 2017 at 03:33:40PM -0400, Steven Rostedt wrote: On Tue, 25 Jul 2017 16:21:11 +0200 Federico Vaga wrote: I found some free time and unfortunately I can't enjoy the sun, so here I am on this patch. Before submitting the V2, one comment (inline) Ah you caught me

Re: [PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file()

2017-07-31 Thread Federico Vaga
On Mon, Jul 31, 2017 at 03:35:39PM -0400, Steven Rostedt wrote: On Mon, 10 Jul 2017 02:15:35 +0200 Federico Vaga wrote: On Friday, July 7, 2017 12:29:35 AM CEST Steven Rostedt wrote: > On Mon, 5 Jun 2017 11:31:18 +0200 > > Federico Vaga wrote: > > show_file(name) and sho

[PATCH] trace-cmd:show: be picky on user argument 'cpu'

2017-12-05 Thread Federico Vaga
Before this patch the following command worked without errors: trace-cmd show -c b This command opens the CPU0 files. From `strace(1)`: openat(AT_FDCWD, "/sys/kernel/tracing/per_cpu/cpu0/trace", O_RDONLY) = 3 Signed-off-by: Federico Vaga --- trace-show.c | 9 - 1 fi

[PATCH V2 1/2] trace-cmd: use asprintf when possible

2017-08-02 Thread Federico Vaga
` is not POSIX standard but the program was already using it. Later it can be decided to use only POSIX functions, then we can easly replace all the `asprintf(3)` with a local implementation of that function. Signed-off-by: Federico Vaga --- event-plugin.c | 24 ++- parse-filter.c | 11

[PATCH V3 1/2] use direname instead of custom code

2017-08-02 Thread Federico Vaga
Prefer well known functions like `dirname(3)` instead of custom implementation for the same functionality Signed-off-by: Federico Vaga --- trace-record.c | 45 ++--- 1 file changed, 30 insertions(+), 15 deletions(-) diff --git a/trace-record.c b/trace

[PATCH V3 2/2] It makes the code clearer and less error prone.

2017-08-02 Thread Federico Vaga
using it. Later it can be decided to use only POSIX functions, then we can easly replace all the `asprintf(3)` with a local implementation of that function. Signed-off-by: Federico Vaga --- event-plugin.c | 24 -- parse-filter.c | 11 -- trace-list.c | 8

Re: [PATCH V3 2/2] It makes the code clearer and less error prone.

2017-08-15 Thread Federico Vaga
On Monday, August 14, 2017 7:33:41 PM CEST Steven Rostedt wrote: > On Thu, 3 Aug 2017 00:15:58 +0200 > Federico Vaga wrote: > > Why did you change the subject? The previous patch had a much better > one: "trace-cmd: Use asprintf when possible" > > Or was it the to

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

2017-07-09 Thread Federico Vaga
On Friday, July 7, 2017 12:25:32 AM CEST Steven Rostedt wrote: > On Mon, 5 Jun 2017 11:31:17 +0200 > Federico Vaga wrote: > > Hi Federico, > > I finally got around to looking at these. Sorry for the really slow > reply, but I had a bunch of kernel work I needed to get

Re: [PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file()

2017-07-09 Thread Federico Vaga
On Friday, July 7, 2017 12:29:35 AM CEST Steven Rostedt wrote: > On Mon, 5 Jun 2017 11:31:18 +0200 > > Federico Vaga wrote: > > show_file(name) and show_instance_file(_instance, name) are > > equivalent. > > > > Remove the show_file() function i

Re: [PATCH 17/18] drivers: Remove CONFIG_OPROFILE support

2021-01-15 Thread Federico Vaga
that's OK for the italian transation -- Federico Vaga

Re: [PATCH v4 46/52] docs: it_IT: hacking.rst: fix a typo on a markup

2020-10-01 Thread Federico Vaga
iante per la famiglia di conversioni "in-situ", come :c:func:`cpu_to_be32s --^ Signed-off-by: Mauro Carvalho Chehab Acked-by: Federico Vaga --- Documentation/translations/it_IT/kernel-hacking/hacking.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v4 24/52] docs: it_IT: fix namespace collisions at locking.rst

2020-10-01 Thread Federico Vaga
a namespace tag there, in order to prevent that. Signed-off-by: Mauro Carvalho Chehab Acked-by: Federico Vaga --- Documentation/translations/it_IT/kernel-hacking/locking.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/translations/it_IT/kernel-hacking/locking.rst b

[PATCH] doc:it_IT: align Italian documentation

2020-09-09 Thread Federico Vaga
for creating a fixes tag") commit 858e6845654d ("docs: dt: convert submitting-patches.txt to ReST format") commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning") commit cca73e4946c4 ("docs: Correct the release date of 5.2 stable") Signed-

[PATCH] doc: fix file references

2020-09-09 Thread Federico Vaga
Patch generated with ./scripts/documentation-file-ref-check --fix Signed-off-by: Federico Vaga --- .../bindings/display/tilcdc/tilcdc.txt | 2 +- .../devicetree/bindings/media/i2c/tvp5150.txt| 2 +- .../bindings/soc/qcom/qcom,smd-rpm.yaml | 2 +- Documentation

Re: [PATCH] doc:it_IT: align Italian documentation

2020-09-11 Thread Federico Vaga
sure, no problem On 2020-09-10 18:58, Jonathan Corbet wrote: On Thu, 10 Sep 2020 00:38:39 +0200 Federico Vaga wrote: Translation for the following patches commit 68e4cd17e218 ("docs: deprecated.rst: Add zero-length and one-element arrays") commit 5429ef62bcf3 ("compiler/gcc

[PATCH] doc:it_IT: align Italian documentation

2020-11-12 Thread Federico Vaga
n-off process") commit 7433ff33e8ba ("Documentation/process: expand plain-text advice") commit eb45fb2fb16d ("docs: process: Add cross-link to security-bugs") commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning") commit f67281a72b30 (&qu

[PATCH v2] doc:it_IT: align Italian documentation

2020-11-13 Thread Federico Vaga
n-off process") commit 7433ff33e8ba ("Documentation/process: expand plain-text advice") commit eb45fb2fb16d ("docs: process: Add cross-link to security-bugs") commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning") commit f67281a72b30 (&qu

Re: [PATCH v2] doc:it_IT: align Italian documentation

2020-11-14 Thread Federico Vaga
On 2020-11-13 22:53, Jonathan Corbet wrote: On Fri, 13 Nov 2020 14:36:38 +0100 Federico Vaga wrote: Translation for the following patches commit 905705a8fd43 ("docs: programming-languages: refresh blurb on clang support") commit 5ff4aa70bf34 ("docs: submitting-pa

<    1   2   3   4   5   >