On 16 December 2012 18:10, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Well, there's my comment against patch 2 which never got a reply:
Again, what about stuff not using drivers/clk/clk.c ?
Has this been addressed?
Hmm.. I misread it and thought it is same as breaking other
On 16 December 2012 18:34, Rafael J. Wysocki r...@sisk.pl wrote:
On Sunday, December 16, 2012 11:20:08 AM Viresh Kumar wrote:
cpufreq core doesn't manage offline cpus and if driver-init() has returned
mask including offline cpus, it may result in unwanted behavior by cpufreq
core
On 17 December 2012 19:37, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
From: Heikki Krogerus heikki.kroge...@linux.intel.com
Clear DWC_CFGL_CH_SUSP bit during termination if the channel
was paused.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Signed-off-by:
On 17 December 2012 19:37, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
We will use at least the dwc_chan_resume() later.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
For both patches:
Acked-by: Viresh Kumar viresh.ku...@linaro.org
Just fix the logs and repost
On 15 November 2012 14:53, Hongbo Zhang hongbo.zh...@linaro.org wrote:
this is a driver for ST-Ericsson u8500 board(Snowball), with a ARM core
inside.
so you should compile like this:
make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- u8500_defconfig
make ARCH=arm
On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
+static inline bool is_slave_direction(enum dma_transfer_direction direction)
+{
+ return (direction == DMA_MEM_TO_DEV) || (direction ==
On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
+static inline bool dwc_is_slave(struct dma_slave_config *sconfig)
+{
+ return is_slave_direction(sconfig-direction);
+}
I will not buy
On Thu, Nov 15, 2012 at 8:05 PM, viresh kumar viresh.ku...@linaro.org wrote:
On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
+static inline bool is_slave_direction(enum dma_transfer_direction
On 15 November 2012 20:51, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Thu, 2012-11-15 at 20:28 +0530, viresh kumar wrote:
On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
On 15 November 2012 20:57, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
Well, the prep_* should assign the value due to changes of check in the
dwc_descriptor_complete. Otherwise we will potentially skip some
important piece of code.
What i meant to say was, set_runtime_config()
On 15 November 2012 23:28, Andy Shevchenko andy.shevche...@gmail.com wrote:
On Thu, Nov 15, 2012 at 5:38 PM, Viresh Kumar viresh.ku...@linaro.org wrote:
On 15 November 2012 20:57, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
Well, the prep_* should assign the value due to changes
;
return irq_find_mapping(plgpio-irq_domain, offset);
Acked-by: Viresh Kumar viresh.ku...@linaro.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
direction)
+{
+ return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM);
+}
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
Though i still have vote to include DMA_DEV_TO_DEV in thist list :)
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
andriy.shevche...@linux.intel.com
Cc: Nicolas Ferre nicolas.fe...@atmel.com
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
andriy.shevche...@linux.intel.com
Acked-by: Viresh Kumar viresh.ku...@linaro.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
On 16 November 2012 19:29, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Mika Westerberg mika.westerb...@linux.intel.com
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
--
To unsubscribe from this list: send
On 16 November 2012 19:29, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de
Apart from missing commit log:
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
On 16 November 2012 19:29, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Missing log :)
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
--
To unsubscribe from this list
On 12 November 2012 09:03, Viresh Kumar viresh.ku...@linaro.org wrote:
On 12 November 2012 01:12, Rob Herring robherri...@gmail.com wrote:
I don't think the size is stored in the dtb. It is only in the dts. You
need to define the size in the binding definitions and use '/bits/'
annotation
On 19 November 2012 11:54, Rajanikanth HV rajanikanth...@linaro.org wrote:
data1 = /bits/ 8 0x50 0x60 0x70;
as per spec, format for data byte defines will be:
data1 = [ 0x50 0x60 0x70 ];
however, i see a parse error from device tree compiler when i tried.
Firstly you tried square braces [ ],
On 19 November 2012 12:05, Rajanikanth HV rajanikanth...@linaro.org wrote:
On 19 November 2012 12:00, Viresh Kumar viresh.ku...@linaro.org wrote:
Firstly you tried square braces [ ], I am not sure if that is allowed.
Can you point me to the specification?
http://www.devicetree.org
On 19 November 2012 21:58, Stephen Warren swar...@wwwdotorg.org wrote:
Support for byte- and word- properties is relatively recent I believe
(or at least, the /bits/ syntax is). Which dtc version are you using?
Ok, i was on a older version. I just saw this patch now:
commit
on it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
include/linux/timer.h | 1 +
kernel/timer.c| 58 +--
2 files changed, 34 insertions(+), 25 deletions(-)
diff --git a/include/linux/timer.h b/include/linux/timer.h
index 8c5a197
On 30 September 2012 14:24, Tejun Heo t...@kernel.org wrote:
On Thu, Sep 27, 2012 at 02:34:05PM +0530, Viresh Kumar wrote:
- A cpu has programmed a timer and is IDLE now.
- CPU gets into interrupt handler due to timer and queues a work. As the CPU
is
currently IDLE, we can queue this work
On 1 October 2012 06:02, Tejun Heo t...@kernel.org wrote:
It isn't about the CPU being actually idle?
No. Being idle only from scheduler's perspective. :)
Also, if it's only about timers, shouldn't it be enough to implement
it for timer and delayed_work?
What if we need a timer, which must
On Tue, Oct 2, 2012 at 5:11 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
There are few cleanups to the driver which already acked and reviewed.
I decide to split last series to two parts. This is first part.
Looks good.
Acked-by: Viresh Kumar viresh.ku...@linaro.org
On 12 January 2013 03:41, Rafael J. Wysocki r...@sisk.pl wrote:
Can any one of you two create a series of patches for me to take for v3.9
with all of the correct Tested-by and Reviewed-by etc. tags, because I've
already lost track of your multiple versions and threads?
:)
I will.
--
To
This patch fixes following sparse warning:
drivers/cpufreq/spear-cpufreq.c:33:5: warning: symbol 'spear_cpufreq_verify' was
not declared. Should it be static?
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/spear-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1
Hi Rafael,
As requested, i am resending all my cpufreq fixes together. I have added correct
Tested-by flags.
Viresh Kumar (5):
cpufreq: Manage only online cpus
cpufreq: Notify governors when cpus are hot-[un]plugged
cpufreq: Don't use cpu removed during cpufreq_driver_unregister
cpufreq
sense to do this at common place
and hence is done in core.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 1f93dbd..de99517 100644
--- a/drivers
cpufreq_remove_dev().
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index a0a33bd..034d183 100644
--- a/drivers/cpufreq
sibling cpus of policy-cpu. We
can check this to know if current cpu is already managed.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
Tested-by: Viresh Kumar viresh.ku...@linaro.org
Tested-by: Shawn Guo shawn@linaro.org
---
drivers/cpufreq/cpufreq.c | 150
.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index de99517..a0a33bd 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
this patch, which tries to implement the above theory. It is tested well
by myself on ARM big.LITTLE TC2 SoC, which has 5 cores (2 A15 and 3 A7). Both
A15's share same struct policy and all A7's share same policy structure.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
Tested-by: Viresh Kumar
On 12 January 2013 18:57, Rafael J. Wysocki r...@sisk.pl wrote:
There's no need to add a Tested-by for yourself if you sign-off a patch,
though. Tested-by is information that somebody *in* *addition* to the
original author has tested the patch, because we all should test the patches
we
this patch, which tries to implement the above theory. It is tested well
by myself on ARM big.LITTLE TC2 SoC, which has 5 cores (2 A15 and 3 A7). Both
A15's share same struct policy and all A7's share same policy structure.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
Tested-by: Shawn Guo shawn
sibling cpus of policy-cpu. We
can check this to know if current cpu is already managed.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
Tested-by: Shawn Guo shawn@linaro.org
---
V1-V2:
- #ifdef,endif CONFIG_HOTPLUG added across: cpufreq_add_policy_cpu() and its
usage.
drivers/cpufreq
On Mon, Jan 14, 2013 at 7:50 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
The driver's default assumes that hardware has two AHB masters which might be
not true. In such rare cases we have not to exceed a number of the AHB masters
present in the hardware. Thus, the AHB master
On Tue, Jan 15, 2013 at 12:35 PM, Andy Shevchenko
andy.shevche...@gmail.com wrote:
The details of the patch are fine, but i didn't get how do you get
master 1 selected
on a system where you have only 1 master?
min_t(..., nr_masters - 1, m) defines this. m is returned value with
default
On 15 January 2013 14:38, Andy Shevchenko andy.shevche...@gmail.com wrote:
You forgot the mem2mem type of transfers where we have no information
about masters except default settings. Otherwise there is the case of
custom slave config absence when we supply only request line via
slave_id.
Hi Tejun,
On 4 January 2013 20:39, Tejun Heo t...@kernel.org wrote:
I don't know either. Changing behavior subtly like this is hard. I
usually try to spot some problem cases and try to identify patterns
there. Once you identify a few of them, understanding and detecting
other problem cases
On 7 January 2013 18:58, Steven Rostedt rost...@goodmis.org wrote:
On Mon, 2013-01-07 at 15:28 +0530, Viresh Kumar wrote:
I have another idea that we can try:
queue_work_on_any_cpu().
I think this is a good idea.
:) :)
- the mask of cpus to schedule this work on
OR
- Sched Level
[Removed Suresh and Venki from discussion, they switched their companies
probably]
On 7 January 2013 20:34, Tejun Heo t...@kernel.org wrote:
The latter part not using idle cpu just for processing work does
apply to homogeneous systems too but as I wrote earlier work items
don't spontaneously
Hi Steven,
On 8 January 2013 03:59, Steven Rostedt rost...@goodmis.org wrote:
On Mon, 2013-01-07 at 23:29 +0530, Viresh Kumar wrote:
By default, I would suggest for cache locality,
that we try to keep it on the same CPU. But if there's a better CPU to
run on, it runs there.
That would
On Tue, Jan 8, 2013 at 4:05 AM, Stephen Rothwell s...@canb.auug.org.au wrote:
In commit 548860697046 (dmaengine: dw_dmac: Enhance device tree
support) (which was changed since yesterday :-(), an instance of
__devinit has been added. We are in the process of making CONFIG_HOTPLUG
always true,
this patch, which tries to implement the above theory. It is tested well
by myself on ARM big.LITTLE TC2 SoC, which has 5 cores (2 A15 and 3 A7). Both
A15's share same struct policy and all A7's share same policy structure.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
Tested-by: Viresh Kumar
n 9 January 2013 19:20, Vinod Koul vinod.k...@intel.com wrote:
+static inline bool is_slave_xfer(enum dma_transfer_direction direction)
+{
+ return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM);
+}
After reading the subsequent patch I understand what is intent here.
On 9 January 2013 16:50, Viresh Kumar viresh.ku...@linaro.org wrote:
[Probably need to simplify cpufreq_add_dev() too, but that can be done as next
step.]
I have tried that too, it is also pushed at:
https://lkml.org/lkml/2012/12/16/5
[Untested for now, will be doing it tomorrow]
From
On 10 January 2013 00:19, Tejun Heo t...@kernel.org wrote:
On Mon, Jan 07, 2013 at 11:37:22PM +0530, Viresh Kumar wrote:
We are talking about a core being idle from schedulers perspective :)
But it's not like cpu doesn't consume power if scheduler considers it
idle, right? Can you please
On 9 January 2013 21:09, Viresh Kumar viresh.ku...@linaro.org wrote:
On 9 January 2013 16:50, Viresh Kumar viresh.ku...@linaro.org wrote:
[Probably need to simplify cpufreq_add_dev() too, but that can be done as
next
step.]
I have tried that too, it is also pushed at:
https://lkml.org
On 9 January 2013 21:09, Viresh Kumar viresh.ku...@linaro.org wrote:
I have tried that too, it is also pushed at:
https://lkml.org/lkml/2012/12/16/5
Bad link :(
http://git.linaro.org/gitweb?p=arm/big.LITTLE/mp.git;a=shortlog;h=refs/heads/cpufreq-fixes-v2
--
To unsubscribe from this list: send
On 10 January 2013 13:24, Shawn Guo shawn@linaro.org wrote:
Yes, just played it and it works for me. However, I would have to keep
that little ugly code in my patch to save the dependency on your patch.
Will send a follow-up to clean that up once your patch hits mainline.
Good. Hopefully,
On 10 January 2013 13:24, Shawn Guo shawn@linaro.org wrote:
On Wed, Jan 09, 2013 at 04:50:44PM +0530, Viresh Kumar wrote:
@Shawn: I believe your driver don't require that ugly code anymore (Though i
know there is a situation for that to happen, if we have two cpus, you remove
second one
On 9 January 2013 21:08, Vinod Koul vinod.k...@intel.com wrote:
subsys_initcall(dw_init);
Viresh, Linus
We had this discussion sometime back. pl022 use dma and we need DMA before
SPI.
So if we have pl022 as late_init and dma as device_init. If we have one more
dependency then moving
On 9 January 2013 16:50, Viresh Kumar viresh.ku...@linaro.org wrote:
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
+static void update_policy_cpu(struct cpufreq_policy *policy, unsigned int
cpu)
+{
+ cpufreq_frequency_table_update_policy_cpu(old_cpu, cpu
.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
0001-cpufreq-Pass-policy-to-cpufreq_add_policy_cpu.patch
Description: Binary data
Export opp_add() so that modules can use it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/base/power/opp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index c8ec186..ef89897 100644
--- a/drivers/base/power/opp.c
+++ b
--
viresh
Lukasz Majewski (1):
cpufreq: Store cpufreq policies in a list
Viresh Kumar (9):
cpufreq: Cleanup header files included in core
cpufreq: Re-arrange declarations in cpufreq.h
cpufreq: Give consistent names for struct cpufreq_policy *
cpufreq: Use sizeof(*ptr) form for finding size
header files
- Don't include files already included by cpufreq.h or cpufreq_governor.h
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 20 ++--
drivers/cpufreq/cpufreq_conservative.c | 12
drivers/cpufreq
They are named as policy, cur_policy, new_policy, data, etc.. Just name them
poicy wherever possible.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 200 ++---
drivers/cpufreq/cpufreq_governor.h | 2 +-
drivers
Caller of cpufreq_add_policy_cpu() already has pointer to policy structure and
so there is no need to find it again in cpufreq_add_policy_cpu(). Lets pass it
directly.
Reviewed-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers
will use read sem.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 135 --
1 file changed, 57 insertions(+), 78 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 74d4969..70399ea
-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 11 +++
include/linux/cpufreq.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 496e31c..4c3aef0 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b
For iterating over all policies currently we are iterating over all CPUs and
then finding their policies. Lets use the newly created infrastructure
cpufreq_policy_list.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 10 +-
1 file changed, 5 insertions
Governor's owner refcount usage was broken. We should increment refcount only
when CPUFREQ_GOV_POLICY_INIT event has come and should decrement only if
CPUFREQ_GOV_POLICY_EXIT has come.
Lets fix it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 14
We don't need to set .owner = THIS_MODULE anymore in our code as this field
isn't used anymore by cpufreq core.
This patch removes it and fixes all dependent drivers.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
Documentation/cpu-freq/cpu-drivers.txt | 2 --
drivers/cpufreq/acpi
On 31 July 2013 19:49, Viresh Kumar viresh.ku...@linaro.org wrote:
CPUFreq core does following at multiple places:
module_{get|put}(cpufreq_driver-owner)).
This is done to make sure module doesn't get unloaded if it is currently in
use.
This will work only if the .owner field of cpufreq
is changed
but the corresponding sizeof that is passed to a memory allocator is not.
This wasn't followed consistently in drivers/cpufreq, lets make it more
consistent by always following this rule.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/acpi-cpufreq.c
They are pretty much mixed up. Although generic headers are present but
definitions/declarations are present outside them too..
This patch just moves stuff up and down to make it look better and consistent.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
include/linux/cpufreq.h | 370
On 3 August 2013 17:38, Rafael J. Wysocki r...@sisk.pl wrote:
On Saturday, August 03, 2013 05:19:26 PM Viresh Kumar wrote:
Governor's owner refcount usage was broken. We should increment refcount only
when CPUFREQ_GOV_POLICY_INIT event has come and should decrement only
On 3 August 2013 17:37, Rafael J. Wysocki r...@sisk.pl wrote:
On Saturday, August 03, 2013 05:19:18 PM Viresh Kumar wrote:
Hi Rafael,
This patchset tries to fix cleanup many existing cpufreq core issues. First
four patches tries to cleanup basic problems in cpufreq core. Its first patch
On 3 August 2013 17:19, Viresh Kumar viresh.ku...@linaro.org wrote:
They are pretty much mixed up. Although generic headers are present but
definitions/declarations are present outside them too..
This patch just moves stuff up and down to make it look better and consistent.
Signed-off
On 3 August 2013 17:19, Viresh Kumar viresh.ku...@linaro.org wrote:
This patch intends to cleanup following issues in the header files included in
cpufreq core layers:
- Include headers in ascending order, so that we don't add same multiple times
by mistake.
- asm/ must be included after
On 5 August 2013 18:17, Rafael J. Wysocki r...@sisk.pl wrote:
On Monday, August 05, 2013 07:29:09 AM Nishanth Menon wrote:
minor nitpick.
$subject: PM / OPP:
Stupid mistake.
Those are things I can easily fix up when I'm applying the patch.
Thanks :)
--
To unsubscribe from this list: send
On 3 August 2013 17:19, Viresh Kumar viresh.ku...@linaro.org wrote:
They are named as policy, cur_policy, new_policy, data, etc.. Just name them
poicy wherever possible.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 200
header files
- Don't include files already included by cpufreq.h or cpufreq_governor.h
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 19 ++-
drivers/cpufreq/cpufreq_conservative.c | 12
drivers/cpufreq/cpufreq_governor.c
in a list
Viresh Kumar (10):
cpufreq: Cleanup header files included in core
cpufreq: Re-arrange declarations in cpufreq.h
cpufreq: Give consistent names for struct cpufreq_policy *
cpufreq: Use sizeof(*ptr) form for finding size of a struct
cpufreq: Pass policy to cpufreq_add_policy_cpu
They are pretty much mixed up. Although generic headers are present but
definitions/declarations are present outside them too..
This patch just moves stuff up and down to make it look better and consistent.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
include/linux/cpufreq.h | 373
They are named as policy, cur_policy, new_policy, data, etc.. Just name them
poicy wherever possible.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 200 ++---
drivers/cpufreq/cpufreq_governor.h | 2 +-
drivers
place.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 48 +++
1 file changed, 36 insertions(+), 12 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index ccaf025..06f8671 100644
For iterating over all policies currently we are iterating over all CPUs and
then finding their policies. Lets use the newly created infrastructure
cpufreq_policy_list.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 10 +-
1 file changed, 5 insertions
is changed
but the corresponding sizeof that is passed to a memory allocator is not.
This wasn't followed consistently in drivers/cpufreq, lets make it more
consistent by always following this rule.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/acpi-cpufreq.c
will use read sem.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 135 --
1 file changed, 57 insertions(+), 78 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 62eddb6..ccaf025
We don't need to set .owner = THIS_MODULE anymore in our code as this field
isn't used anymore by cpufreq core.
This patch removes it and fixes all dependent drivers.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
Documentation/cpu-freq/cpu-drivers.txt | 2 --
drivers/cpufreq/acpi
Caller of cpufreq_add_policy_cpu() already has pointer to policy structure and
so there is no need to find it again in cpufreq_add_policy_cpu(). Lets pass it
directly.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 18 ++
1 file changed, 6
result in undefined behavior.
Lets fix it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index fe04b79..62eddb6 100644
-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 11 +++
include/linux/cpufreq.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 9e83d91..f5999c4 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b
On 24 July 2013 14:47, Viresh Kumar viresh.ku...@linaro.org wrote:
On 18 June 2013 10:21, Viresh Kumar viresh.ku...@linaro.org wrote:
Hi Thomas,
Do you still see some light of hope in this patch :) ?
Ping!!
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
as the
percentage of average frequency. This check is present in most of the cpufreq
driver.
Cc: Viresh Kumar viresh.ku...@linaro.org
Cc: Rafael J. Wysocki r...@sisk.pl
Cc: Kukjin Kim kgene@samsung.com
Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com
---
drivers/cpufreq
On 7 August 2013 17:00, Sudeep KarkadaNagesha
sudeep.karkadanage...@arm.com wrote:
Any particular reason we need this check in all drivers after your
commit: 5a1c0228 cpufreq: Avoid calling cpufreq driver's target()
routine if target_freq == policy-cur
I think it can removed from all drivers,
This patch adds CPU0's clk driver for Tegra. It will be used by the generic
cpufreq-cpu0 driver to get/set cpu clk.
Most of the platform specific bits are picked from tegra-cpufreq.c.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/clk/tegra/Makefile | 1 +
drivers/clk
may need your help getting
them fixed.
Once this is tested by you, I would like to take it through my ARM cpufreq tree
if nobody else has a problem with it.
Thanks
--
Viresh.
Viresh Kumar (6):
clk: Tegra: Add CPU0 clock driver
ARM: Tegra: Add CPU's OPPs for using cpufreq-cpu0 driver
ARM
cpufreq-cpu0 driver is dependent on OPP library and hence we need to enable it
for Tegra as we are going to use cpufreq-cpu0.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/mach-tegra/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-tegra/Kconfig b
there will not be any conflicts between two cpufreq drivers.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/mach-tegra/tegra.c | 2 ++
drivers/cpufreq/Kconfig.arm | 8
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-tegra/tegra.c b/arch/arm/mach-tegra/tegra.c
Tegra requires cpufreq-cpu0 driver to be compiled in and hence we select it from
the defconfig.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/configs/tegra_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs
We are using generic cpufreq-cpu0 driver, so lets get rid of platform specific
tegra-cpufreq.c driver.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/Makefile| 1 -
drivers/cpufreq/tegra-cpufreq.c | 291
2 files changed
to represent voltage.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/boot/dts/tegra114.dtsi | 12
arch/arm/boot/dts/tegra20.dtsi | 12
arch/arm/boot/dts/tegra30.dtsi | 12
3 files changed, 36 insertions(+)
diff --git a/arch/arm/boot/dts/tegra114
On 7 August 2013 23:08, Stephen Warren swar...@wwwdotorg.org wrote:
On 08/07/2013 08:46 AM, Viresh Kumar wrote:
This patch adds CPU0's clk driver for Tegra. It will be used by the generic
cpufreq-cpu0 driver to get/set cpu clk.
Most of the platform specific bits are picked from tegra
On 7 August 2013 23:16, Stephen Warren swar...@wwwdotorg.org wrote:
On 08/07/2013 08:46 AM, Viresh Kumar wrote:
cpufreq-cpu0 driver can be probed over DT only if a corresponding device
node is
created for the SoC which wants to use it. Lets create a platform device for
cpufreq-cpu0 driver
On 7 August 2013 23:18, Stephen Warren swar...@wwwdotorg.org wrote:
On 08/07/2013 11:45 AM, Viresh Kumar wrote:
On 7 August 2013 23:08, Stephen Warren swar...@wwwdotorg.org wrote:
On 08/07/2013 08:46 AM, Viresh Kumar wrote:
This patch adds CPU0's clk driver for Tegra. It will be used
901 - 1000 of 16408 matches
Mail list logo
