Re: [PATCH 7/9] arm64: dts: qcom: sc7280: Add CDSP node

Hi, On Mon, Oct 30, 2023 at 7:43 AM Luca Weiss wrote: > > On Mon Oct 30, 2023 at 3:11 PM CET, Doug Anderson wrote: > > Hi, > > > > On Mon, Oct 30, 2023 at 2:12 AM Luca Weiss wrote: > > > > > > On Mon Oct 30, 2023 at 10:04 AM CET, Mukesh Ojha wrote: >

Re: [PATCH 7/9] arm64: dts: qcom: sc7280: Add CDSP node

Hi, On Mon, Oct 30, 2023 at 2:12 AM Luca Weiss wrote: > > On Mon Oct 30, 2023 at 10:04 AM CET, Mukesh Ojha wrote: > > > > > > On 10/27/2023 7:50 PM, Luca Weiss wrote: > > > Add the node for the ADSP found on the SC7280 SoC, using standard > > > Qualcomm firmware. > > > > > > The memory region

Re: [PATCH v2 2/7] nvmem: qfprom: Mark core clk as optional

Hi, On Tue, Sep 19, 2023 at 5:46 AM Luca Weiss wrote: > > On some platforms like sc7280 on non-ChromeOS devices the core clock > cannot be touched by Linux so we cannot provide it. Mark it as optional > as accessing qfprom for reading works without it but we still prohibit > writing if we cannot

Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

Hi, On Tue, Apr 20, 2021 at 10:21 AM wrote: > > On 2021-04-15 01:55, Doug Anderson wrote: > > Hi, > > > > On Tue, Apr 13, 2021 at 3:59 AM wrote: > >> > >> >> >>> +

Re: [PATCH v4 00/27] drm: Fix EDID reading on ti-sn65dsi86; solve some chicken-and-egg problems

Hi, On Fri, Apr 16, 2021 at 3:40 PM Douglas Anderson wrote: > > The primary goal of this series is to try to properly fix EDID reading > for eDP panels using the ti-sn65dsi86 bridge. > > Previously we had a patch that added EDID reading but it turned out > not to work at bootup. This caused some

Re: [v1 0/3] drm: Add support for backlight control of eDP panel on ti-sn65dsi86 bridge

Hi, On Wed, Apr 14, 2021 at 9:41 AM Rajeev Nandan wrote: > > The backlight level of an eDP panel can be controlled through the AUX > channel using DPCD registers of the panel. > > The capability for the Source device to adjust backlight characteristics > within the panel, using the Sink device

Re: [PATCH v1] arm64: dts: qcom: sc7180: coachz: Add thermal config for skin temperature

Hi, On Wed, Apr 14, 2021 at 11:10 AM Matthias Kaehlcke wrote: > > Add ADC and thermal monitor configuration for skin temperature, > plus a thermal zone that monitors the skin temperature and uses > the big cores as cooling devices. > > CoachZ rev1 is stuffed with an incompatible thermistor for

Re: [PATCH v3 01/12] drm/bridge: Fix the stop condition of drm_bridge_chain_pre_enable()

Hi, On Wed, Apr 14, 2021 at 6:56 PM Laurent Pinchart wrote: > > Hi Doug, > > On Wed, Apr 14, 2021 at 06:19:13PM -0700, Doug Anderson wrote: > > On Sun, Apr 4, 2021 at 5:50 PM Laurent Pinchart wrote: > > > On Fri, Apr 02, 2021 at 03:28:35PM -0

Re: [PATCH v3 12/12] drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare

Hi, On Wed, Apr 14, 2021 at 5:58 PM Laurent Pinchart wrote: > > Hi Doug, > > Thank you for the patch. > > On Fri, Apr 02, 2021 at 03:28:46PM -0700, Douglas Anderson wrote: > > Unpreparing and re-preparing a panel can be a really heavy > > operation. Panels datasheets often specify something on

Re: [PATCH v3 01/12] drm/bridge: Fix the stop condition of drm_bridge_chain_pre_enable()

Hi, On Sun, Apr 4, 2021 at 5:50 PM Laurent Pinchart wrote: > > Hi Doug, > > Thank you for the patch. > > On Fri, Apr 02, 2021 at 03:28:35PM -0700, Douglas Anderson wrote: > > The drm_bridge_chain_pre_enable() is not the proper opposite of > > drm_bridge_chain_post_disable(). It continues along

Re: [PATCH v2 11/14] drm/bridge: ti-sn65dsi86: Power things properly for reading the EDID

f can work when these rails are turned on. The panel is on a separate power rail and you can't talk to the panel at all until it's powered on and then asserts HPD to us to say it finished its boot sequence. > W dniu 01.04.2021 o 16:57, Doug Anderson pisze: > > Hi, > > > > On Th

Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

Hi, On Tue, Apr 13, 2021 at 3:59 AM wrote: > > >> >>> + required-opps = > >> >>> <_opp_low_svs>; > >> >>> + opp-peak-kBps = <120 > >> >>> 76000>; > >> >>> + opp-avg-kBps =

Re: [PATCH] arm64: dts: qcom: sc7180: Fix sc7180-qmp-usb3-dp-phy reg sizes

Bjorn, On Mon, Mar 15, 2021 at 10:39 AM Douglas Anderson wrote: > > As per Dmitry Baryshkov [1]: > a) The 2nd "reg" should be 0x3c because "Offset 0x38 is >USB3_DP_COM_REVISION_ID3 (not used by the current driver though)." > b) The 3rd "reg" "is a serdes region and qmp_v3_dp_serdes_tbl

Re: [PATCH v3] HID: i2c-hid: Skip ELAN power-on command after reset

Hi, On Mon, Apr 12, 2021 at 6:20 PM Johnny Chuang wrote: > > Fixes: 43b7029f475e ("HID: i2c-hid: Send power-on command after reset"). Note that the "Fixes" tag actually belongs down at the end. It also shouldn't have a "." at the end. Presumably the maintainer can adjust this when landing? >

Re: [PATCH v2 1/2] arm64: dts: qcom: Add "dmic_clk_en" for sc7180-trogdor-coachz

Bjorn, On Mon, Mar 15, 2021 at 1:39 PM Douglas Anderson wrote: > > This was present downstream. Add upstream too. NOTE: upstream I > managed to get some sort of halfway state and got one pinctrl entry in > the coachz-r1 device tree. Remove that as part of this since it's now > in the dtsi. > >

Re: [PATCH v2] drm/msm: Drop mm_lock in scan loop

Hi, On Fri, Apr 2, 2021 at 2:08 PM Rob Clark wrote: > > From: Rob Clark > > lock_stat + mmm_donut[1] say that this reduces contention on mm_lock > significantly (~350x lower waittime-max, and ~100x lower waittime-avg) > > [1] >

Re: [PATCH v2 2/4] drm/msm: Avoid mutex in shrinker_count()

Hi, On Wed, Mar 31, 2021 at 6:24 PM Rob Clark wrote: > > @@ -45,6 +30,9 @@ msm_gem_shrinker_scan(struct shrinker *shrinker, struct > shrink_control *sc) > list_for_each_entry(msm_obj, >inactive_dontneed, mm_list) { > if (freed >= sc->nr_to_scan) >

Re: [PATCH v2 11/14] drm/bridge: ti-sn65dsi86: Power things properly for reading the EDID

Hi, On Thu, Apr 1, 2021 at 4:12 AM Andrzej Hajda wrote: > > > W dniu 31.03.2021 o 16:48, Doug Anderson pisze: > > Hi, > > > > On Wed, Mar 31, 2021 at 4:08 AM Andrzej Hajda wrote: > >> > >> W dniu 30.03.2021 o 04:53, Douglas Anderson pisze: >

Re: [PATCH v2 1/4] drm/msm: Remove unused freed llist node

Hi, On Wed, Mar 31, 2021 at 6:23 PM Rob Clark wrote: > > From: Rob Clark > > Unused since commit c951a9b284b9 ("drm/msm: Remove msm_gem_free_work") > > Signed-off-by: Rob Clark > Tested-by: Douglas Anderson > --- > drivers/gpu/drm/msm/msm_gem.h | 2 -- > 1 file changed, 2 deletions(-)

Re: [PATCH v2 3/4] drm/msm: Fix debugfs deadlock

Hi, On Wed, Mar 31, 2021 at 6:24 PM Rob Clark wrote: > > From: Rob Clark > > In normal cases the gem obj lock is acquired first before mm_lock. The > exception is iterating the various object lists. In the shrinker path, > deadlock is avoided by using msm_gem_trylock() and skipping over

Re: [PATCH 1/4] drm/msm: Remove unused freed llist node

Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > From: Rob Clark > > Unused since c951a9b284b907604759628d273901064c60d09f Not terribly important, but checkpatch always yells at me when I don't reference commits by saying: commit c951a9b284b9 ("drm/msm: Remove msm_gem_free_work") >

Re: [PATCH 0/4] drm/msm: Shrinker (and related) fixes

Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > From: Rob Clark > > I've been spending some time looking into how things behave under high > memory pressure. The first patch is a random cleanup I noticed along > the way. The second improves the situation significantly when we are >

Re: [PATCH 2/4] drm/msm: Avoid mutex in shrinker_count()

Hi, On Wed, Mar 31, 2021 at 4:23 PM Rob Clark wrote: > > On Wed, Mar 31, 2021 at 3:44 PM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > > > > > @@ -818,11 +820,19 @@ static void updat

Re: [PATCH 4/4] drm/msm: Improved debugfs gem stats

Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > From: Rob Clark > > The last patch lost the breakdown of active vs inactive GEM objects in > $debugfs/gem. But we can add some better stats to summarize not just > active vs inactive, but also purgable/purged to make up for that. > >

Re: [PATCH 3/4] drm/msm: Fix debugfs deadlock

Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > @@ -111,23 +111,15 @@ static const struct file_operations msm_gpu_fops = { > static int msm_gem_show(struct drm_device *dev, struct seq_file *m) > { > struct msm_drm_private *priv = dev->dev_private; > - struct msm_gpu *gpu

Re: [PATCH 2/4] drm/msm: Avoid mutex in shrinker_count()

Hi, On Wed, Mar 31, 2021 at 3:14 PM Rob Clark wrote: > > @@ -818,11 +820,19 @@ static void update_inactive(struct msm_gem_object > *msm_obj) > mutex_lock(>mm_lock); > WARN_ON(msm_obj->active_count != 0); > > + if (msm_obj->dontneed) > +

Re: [PATCH v2 05/14] drm/bridge: ti-sn65dsi86: Move MIPI detach() / unregister() to detach()

Hi, On Wed, Mar 31, 2021 at 2:53 AM Andrzej Hajda wrote: > > > W dniu 30.03.2021 o 04:53, Douglas Anderson pisze: > > The register() / attach() for MIPI happen in the bridge's > > attach(). That means that the inverse belongs in the bridge's > > detach(). > > > As I commented in previous patch,

Re: [v1] drm/msm/disp/dpu1: fix warn stack reported during dpu resume

Hi, On Wed, Mar 31, 2021 at 4:27 AM Kalyan Thota wrote: > > @@ -294,6 +294,9 @@ static int dpu_kms_parse_data_bus_icc_path(struct dpu_kms > *dpu_kms) > struct icc_path *path1; > struct drm_device *dev = dpu_kms->dev; > > + if (!dpu_supports_bw_scaling(dev)) > +

Re: [PATCH v2 11/14] drm/bridge: ti-sn65dsi86: Power things properly for reading the EDID

Hi, On Wed, Mar 31, 2021 at 4:08 AM Andrzej Hajda wrote: > > > W dniu 30.03.2021 o 04:53, Douglas Anderson pisze: > > eDP panels won't provide their EDID unless they're powered on. Let's > > chain a power-on before we read the EDID. This roughly matches what > > was done in 'parade-ps8640.c'. >

Re: [PATCH v2 10/14] drm/bridge: ti-sn65dsi86: Stop caching the EDID ourselves

Hi, On Wed, Mar 31, 2021 at 3:12 AM Andrzej Hajda wrote: > > > W dniu 30.03.2021 o 04:53, Douglas Anderson pisze: > > Now that we have the patch ("drm/edid: Use the cached EDID in > > drm_get_edid() if eDP") we no longer need to maintain our own > > cache. Drop this code. > > > > Signed-off-by:

Re: [PATCH v2 09/14] drm/edid: Use the cached EDID in drm_get_edid() if eDP

Hi, On Tue, Mar 30, 2021 at 7:01 AM Ville Syrjälä wrote: > > > @@ -2049,15 +2049,39 @@ struct edid *drm_get_edid(struct drm_connector > > *connector, > > struct i2c_adapter *adapter) > > { > > struct edid *edid; > > + size_t old_edid_size; > > + const

Re: [PATCH 2/2] nvmem: qfprom: Add support for fuse blowing on sc7280

Hi, On Wed, Mar 24, 2021 at 10:45 PM Rajendra Nayak wrote: > > @@ -111,6 +113,15 @@ static const struct qfprom_soc_compatible_data > sc7180_qfprom = { > .nkeepout = ARRAY_SIZE(sc7180_qfprom_keepout) > }; > > +static const struct nvmem_keepout sc7280_qfprom_keepout[] = { > +

Re: [PATCH] drm/msm: Fix removal of valid error case when checking speed_bin

Hi, On Mon, Mar 29, 2021 at 6:34 PM John Stultz wrote: > > Commit 7bf168c8fe8c ("drm/msm: Fix speed-bin support not to > access outside valid memory"), reworked the nvmem reading of > "speed_bin", but in doing so dropped handling of the -ENOENT > case which was previously documented as "fine".

Re: [PATCH 3/3] drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if refclk

Hi, On Tue, Mar 16, 2021 at 5:44 PM Doug Anderson wrote: > > Hi, > > On Tue, Mar 16, 2021 at 2:46 PM Laurent Pinchart > wrote: > > > > Hi Doug, > > > > On Mon, Mar 15, 2021 at 09:25:37AM -0700, Doug Anderson wrote: > > > On Sat, Mar 13, 2021 a

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

Hi, On Thu, Mar 25, 2021 at 5:09 PM Rob Herring wrote: > > On Tue, Mar 16, 2021 at 02:08:19PM -0700, Douglas Anderson wrote: > > The sc7180-trogdor-pompom board might be attached to any number of a > > pile of eDP panels. At the moment I'm told that the list might include: > > - KD

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

Hi, On Fri, Mar 26, 2021 at 5:38 AM Thierry Reding wrote: > > The point remains that unless we describe exactly which panel we're > dealing with, we ultimately have no way of properly quirking anything if > we ever have to. Just to clarify here: with my initial proposal we actually could still

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

Hi, On Fri, Mar 26, 2021 at 12:48 PM Rob Herring wrote: > > On Fri, Mar 26, 2021 at 9:20 AM Rob Clark wrote: > > > > On Fri, Mar 26, 2021 at 8:18 AM Rob Clark wrote: > > > > > > On Fri, Mar 26, 2021 at 5:38 AM Thierry Reding > > > wrote: > > > > > > > > On Wed, Mar 17, 2021 at 06:53:04PM

Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

Hi, On Thu, Mar 25, 2021 at 11:57 PM wrote: > > >>> + max-frequency = <19200>; > >> Why do you need to specify this? > This helps to avoid lower speed modes running in high clock rate, > and As Veerabhadrarao Badiganti mentioned Just to be clear, both Stephen and I

Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

Hi, On Wed, Mar 24, 2021 at 8:37 PM Veerabhadrarao Badiganti wrote: > > > On 3/24/2021 9:58 PM, Stephen Boyd wrote: > > Quoting Stephen Boyd (2021-03-24 08:57:33) > >> Quoting sbh...@codeaurora.org (2021-03-24 08:23:55) > >>> On 2021-03-23 12:31, Stephen Boyd wrote: > Quoting Shaik Sajida

Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

Hi, On Wed, Mar 24, 2021 at 8:59 PM Veerabhadrarao Badiganti wrote: > > >> + clocks = < GCC_SDCC1_APPS_CLK>, > >> + < GCC_SDCC1_AHB_CLK>, > >> + < RPMH_CXO_CLK>; > >> +

Re: [PATCH v2] arm64: dts: qcom: c630: Add no-hpd to DSI bridge node

Hi, On Wed, Mar 24, 2021 at 4:14 PM Stephen Boyd wrote: > > We should indicate that we're not using the HPD pin on this device, per > the binding document. Otherwise if code in the future wants to enable > HPD in the bridge when this property is absent we'll be enabling HPD > when it isn't

Re: [PATCH] arm64: dts: qcom: c630: Add no-hpd to DSI bridge node

Hi, On Wed, Mar 24, 2021 at 12:15 PM Stephen Boyd wrote: > > We should indicate that we're not using the HPD pin on this device, per > the binding document. Otherwise if code in the future wants to enable > HPD in the bridge when this property is absent we'll be wasting power > powering hpd when

Re: [PATCH] arm64: dts: qcom: trogdor: Add no-hpd to DSI bridge node

Hi, On Tue, Mar 23, 2021 at 7:55 PM Stephen Boyd wrote: > > We should indicate that we're not using the HPD pin on this device, per > the binding document. Otherwise if code in the future wants to enable > HPD in the bridge when this property is absent we'll be wasting power > powering hpd when

Re: [PATCH v3 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

Hi, On Mon, Mar 22, 2021 at 8:17 PM Stephen Boyd wrote: > > Quoting Laurent Pinchart (2021-03-17 17:20:43) > > Hi Stephen, > > > > Reviving a bit of an old thread, for a question. > > > > On Mon, Nov 02, 2020 at 10:11:43AM -0800, Stephen Boyd wrote: > > > @@ -265,6 +267,23 @@

Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card

Hi, On Sat, Mar 20, 2021 at 11:18 AM Shaik Sajida Bhanu wrote: > > Add nodes for eMMC and SD card on sc7280. > > Signed-off-by: Shaik Sajida Bhanu > > --- > This change is depends on the below patch series: > https://lore.kernel.org/patchwork/project/lkml/list/?series=488871 >

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

Hi, On Mon, Mar 22, 2021 at 11:19 AM Arnd Bergmann wrote: > > On Mon, Mar 22, 2021 at 6:07 PM Doug Anderson wrote: > > On Mon, Mar 22, 2021 at 9:43 AM Arnd Bergmann wrote: > > > > > > -#define v1printk(a...) do { \ > > > - if (verbose) \

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

Hi, On Mon, Mar 22, 2021 at 9:43 AM Arnd Bergmann wrote: > > -#define v1printk(a...) do { \ > - if (verbose) \ > - printk(KERN_INFO a); \ > - } while (0) > -#define v2printk(a...) do { \ > - if (verbose > 1) \ > - printk(KERN_INFO a); \ > -

Re: [v1] drm/msm/disp/dpu1: fix display underruns during modeset.

Hi, On Fri, Mar 19, 2021 at 5:54 AM Kalyan Thota wrote: > > During crtc disable, display perf structures are reset to 0 > which includes state varibles which are immutable. On crtc > enable, we use the same structures and they don't refelect > the actual values > > 1) Fix is to avoid updating

Re: [PATCH v3 2/3] arm64: dts: qcom: sc7180: Add pompom rev3

Hi, On Mon, Mar 15, 2021 at 6:15 PM Matthias Kaehlcke wrote: > > The only kernel visible change with respect to rev2 is that pompom > rev3 changed the charger thermistor from a 47k to a 100k NTC to use > a thermistor which is supported by the PM6150 ADC driver. > > Disable the charger thermal

Re: [PATCH] drm/msm: Ratelimit invalid-fence message

Hi, On Wed, Mar 17, 2021 at 9:40 AM Rob Clark wrote: > > From: Rob Clark > > We have seen a couple cases where low memory situations cause something > bad to happen, followed by a flood of these messages obscuring the root > cause. Lets ratelimit the dmesg spam so that next time it happens we

Re: [PATCH 3/3] drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if refclk

Hi, On Tue, Mar 16, 2021 at 2:46 PM Laurent Pinchart wrote: > > Hi Doug, > > On Mon, Mar 15, 2021 at 09:25:37AM -0700, Doug Anderson wrote: > > On Sat, Mar 13, 2021 at 1:17 PM Laurent Pinchart wrote: > > > On Thu, Mar 04, 2021 at 03:52:01PM -0800, Douglas Anders

Re: [PATCH v3 3/3] arm64: dts: qcom: sc7180: Add CoachZ rev3

Hi, On Mon, Mar 15, 2021 at 6:15 PM Matthias Kaehlcke wrote: > > CoachZ rev3 uses a 100k NTC thermistor for the charger temperatures, > instead of the 47k NTC that is stuffed in earlier revisions. Add .dts > files for rev3. > > The 47k NTC currently isn't supported by the PM6150 ADC driver. >

Re: [PATCH v3 2/3] arm64: dts: qcom: sc7180: Add pompom rev3

Hi, On Mon, Mar 15, 2021 at 6:15 PM Matthias Kaehlcke wrote: > > The only kernel visible change with respect to rev2 is that pompom > rev3 changed the charger thermistor from a 47k to a 100k NTC to use > a thermistor which is supported by the PM6150 ADC driver. > > Disable the charger thermal

Re: [PATCH v2 3/3] arm64: dts: qcom: sc7180: Add CoachZ rev3

Hi, On Fri, Mar 12, 2021 at 10:32 AM Matthias Kaehlcke wrote: > > CoachZ rev3 uses a 100k NTC thermistor for the charger temperatures, > instead of the 47k NTC that is stuffed in earlier revisions. Add .dts > files for rev3. > > The 47k NTC currently isn't supported by the PM6150 ADC driver. >

Re: [PATCH v2 2/3] arm64: dts: qcom: sc7180: Add pompom rev3

Hi, On Fri, Mar 12, 2021 at 10:32 AM Matthias Kaehlcke wrote: > > + linux,keymap = < > + MATRIX_KEY(0x00, 0x02, KEY_BACK) > + MATRIX_KEY(0x03, 0x02, KEY_REFRESH) > + MATRIX_KEY(0x02, 0x02, KEY_ZOOM) > + MATRIX_KEY(0x01, 0x02,

Re: [PATCH v2 1/3] arm64: dts: qcom: sc7180: lazor: Simplify disabling of charger thermal zone

Hi, On Fri, Mar 12, 2021 at 10:32 AM Matthias Kaehlcke wrote: > > Commit f73558cc83d1 ("arm64: dts: qcom: sc7180: Disable charger > thermal zone for lazor") disables the charger thermal zone for > specific lazor revisions due to an unsupported thermistor type. > The initial idea was to disable

Re: [PATCH 1/2] arm64: dts: qcom: Add "dmic_clk_en" for sc7180-trogdor-coachz

Hi, On Mon, Mar 15, 2021 at 1:23 PM Douglas Anderson wrote: > > This was present downstream. Add upstream too. > > Cc: Srinivasa Rao Mandadapu > Cc: Ajit Pandey > Cc: Judy Hsiao > Cc: Cheng-Yi Chiang > Cc: Stephen Boyd > Cc: Matthias Kaehlcke > Signed-off-by: Douglas Anderson > --- > This

Re: [PATCH v7 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz

Hi, On Sat, Mar 13, 2021 at 10:11 PM Srinivasa Rao Mandadapu wrote: > > This is a trgodor variant, required to have sound node variable > for coachz specific platform. > > Signed-off-by: Srinivasa Rao Mandadapu > Reviewed-by: Stephen Boyd > --- >

Re: [PATCH v7 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

Hi, On Sat, Mar 13, 2021 at 10:11 PM Srinivasa Rao Mandadapu wrote: > > From: Ajit Pandey > > Add dai link for supporting lpass I2S driver, which is used > for audio capture and playback. > Add lpass-cpu node with pin controls and i2s primary > and secondary dai-links You missed Stephen's

Re: [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy

Hi, On Sat, Mar 13, 2021 at 4:28 PM Dmitry Baryshkov wrote: > > > usb_1_qmpphy: phy-wrapper@88e9000 { > > - compatible = "qcom,sc7180-qmp-usb3-phy"; > > + compatible = "qcom,sc7180-qmp-usb3-dp-phy"; > > reg = <0

Re: [PATCH v2 1/2] arm64: dts: qcom: sdm845: Move reserved-memory to devices

Hi, On Fri, Mar 12, 2021 at 3:42 PM Bjorn Andersson wrote: > > The reserved-memory regions used for carrying firmware to be run on the > various cores and co-processors in a Qualcomm platform differs in size, > placement and presence based on each device's feature set and security >

Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: Move code in prep for EDID read fix

Hi, On Sat, Mar 13, 2021 at 1:13 PM Laurent Pinchart wrote: > > Hi Douglas, > > Thank you for the patch. > > On Thu, Mar 04, 2021 at 03:52:00PM -0800, Douglas Anderson wrote: > > This patch is _only_ code motion to prepare for the patch > > ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but

Re: [PATCH 3/3] drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if refclk

Hi, On Sat, Mar 13, 2021 at 1:17 PM Laurent Pinchart wrote: > > Hi Doug, > > Thank you for the patch. > > On Thu, Mar 04, 2021 at 03:52:01PM -0800, Douglas Anderson wrote: > > In commit 58074b08c04a ("drm/bridge: ti-sn65dsi86: Read EDID blob over > > DDC") we attempted to make the ti-sn65dsi86

Re: [PATCH v5 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz

Hi, On Fri, Mar 12, 2021 at 8:07 AM Srinivasa Rao Mandadapu wrote: > > This is a trgodor variant, required to have sound node variable > for coachz specific platform. > > Signed-off-by: Srinivasa Rao Mandadapu > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 ++ > 1

Re: [PATCH v5 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

Hi, On Fri, Mar 12, 2021 at 8:06 AM Srinivasa Rao Mandadapu wrote: > > + dai-link@0 { > + link-name = "MultiMedia0"; > + reg = ; > + cpu { > + sound-dai = <_cpu MI2S_PRIMARY>; > +

Re: [PATCH] arm64: dts: sc7280: Add qspi, qupv3_0 and qupv3_1 nodes

Hi, On Wed, Mar 10, 2021 at 7:41 PM Roja Rani Yarubandi wrote: > > +_cs0 { > + pinconf { > + pins = "gpio15"; > + bias-disable; > + }; The "pinconf" / "pinmux" subnode shouldn't be used for new SoCs. See:

Re: [PATCH v4 1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver

Hi, On Thu, Mar 11, 2021 at 8:49 AM Srinivasa Rao Mandadapu wrote: > > From: Ajit Pandey > > Add dai link for supporting lpass I2S driver, which is used > for audio capture and playback. > Add lpass-cpu node with pin controls and i2s primary > and secondary dai-links > > Signed-off-by: Ajit

Re: [PATCH v4 2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz

Hi, On Thu, Mar 11, 2021 at 8:48 AM Srinivasa Rao Mandadapu wrote: > > This is a trgodor variant, required to have sound node variable > for coachz specific platform. > > Signed-off-by: Srinivasa Rao Mandadapu > --- > .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 18 ++ > 1

Re: [PATCH][next] nvmem: core: Fix unintentional sign extension issue

Hi, On Thu, Mar 11, 2021 at 1:53 AM Colin King wrote: > > From: Colin Ian King > > The shifting of the u8 integer buf[3] by 24 bits to the left will > be promoted to a 32 bit signed int and then sign-extended to a > u64. In the event that the top bit of buf[3] is set then all > then all the

Re: [PATCH v2 0/5] drm/panel-simple: Patches for N116BCA-EA1

Hi, On Wed, Mar 10, 2021 at 4:57 PM Linus Walleij wrote: > > On Thu, Mar 11, 2021 at 12:47 AM Doug Anderson wrote: > > > I guess what I'd say in summary is: > > > > * If you object to the retries in simple panel, I still hope the rest > > of the series can land

Re: [PATCH v2 0/5] drm/panel-simple: Patches for N116BCA-EA1

Hi, On Wed, Mar 10, 2021 at 3:25 PM Linus Walleij wrote: > > On Fri, Jan 15, 2021 at 11:44 PM Douglas Anderson > wrote: > > > - ("drm/panel-simple: Don't wait longer for HPD...") new for v2. > > - ("drm/panel-simple: Retry if we timeout waiting for HPD") new for v2. > > I couldn't find these

Re: [PATCH] watchdog: qcom: Move suspend/resume to suspend_late/resume_early

Hi, On Wed, Mar 10, 2021 at 12:20 PM Sai Prakash Ranjan wrote: > > During suspend/resume usecases and tests, it is common to see issues > such as lockups either in suspend path or resume path because of the > bugs in the corresponding device driver pm handling code. In such cases, > it is

Re: [PATCH 1/3] nvmem: core: Add functions to make number reading easy

Hi, On Wed, Mar 10, 2021 at 2:37 AM Srinivas Kandagatla wrote: > > > > On 06/03/2021 00:26, Douglas Anderson wrote: > > Sometimes the clients of nvmem just want to get a number out of > > nvmem. They don't want to think about exactly how many bytes the nvmem > > cell took up. They just want the

Re: [PATCH 2/3] nvmem: core: Allow nvmem_cell_read_u16/32/64 to read smaller cells

Hi, On Fri, Mar 5, 2021 at 8:07 AM Srinivas Kandagatla wrote: > > > If you think it's confusing to change the behavior of the existing > > functions, would you be opposed to me adding a new function like > > nvmem_cell_read_le_u32_or_smaller() (or provide me a better name) that > > would be

Re: [PATCH 4/4] arm64: dts: qcom: sc7180: Disable charger thermal zone for coachz rev1 and rev2

Hi, On Thu, Mar 4, 2021 at 10:04 AM Matthias Kaehlcke wrote: > > CoachZ rev1 and rev2 are stuffed with a 47k NTC as thermistor for the > charger temperature which currently isn't supported by the PM6150 ADC > driver. Disable the charger thermal zone to avoid the use of bogus > temperature

Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Add pompom rev3

Hi, On Thu, Mar 4, 2021 at 10:04 AM Matthias Kaehlcke wrote: > > The only kernel visible change with respect to rev2 is that pompom > rev3 changed the charger thermistor from a 47k to a 100k NTC to use > a thermistor which is supported by the PM6150 ADC driver. > > Signed-off-by: Matthias

Re: [PATCH 1/4] arm64: dts: qcom: sc7180: lazor: Simplify disabling of charger thermal zone

Hi, On Thu, Mar 4, 2021 at 10:04 AM Matthias Kaehlcke wrote: > > Commit f73558cc83d1 ("arm64: dts: qcom: sc7180: Disable charger > thermal zone for lazor") disables the charger thermal zone for > specific lazor revisions due to an unsupported thermistor type. > The initial idea was to disable

Re: [PATCH v2 0/5] drm/panel-simple: Patches for N116BCA-EA1

Hi folks, On Fri, Jan 15, 2021 at 2:44 PM Douglas Anderson wrote: > > This series is to get the N116BCA-EA1 panel working. Most of the > patches are simple, but on hardware I have in front of me the panel > sometimes doesn't come up. I'm still working with the hardware > manufacturer to get to

Re: [PATCH 2/3] nvmem: core: Allow nvmem_cell_read_u16/32/64 to read smaller cells

Hi, On Fri, Mar 5, 2021 at 2:27 AM Srinivas Kandagatla wrote: > > > > On 27/02/2021 00:26, Douglas Anderson wrote: > > The current way that cell "length" is specified for nvmem cells is a > > little fuzzy. For instance, let's look at the gpu speed bin currently > > in sc7180.dtsi: > > > >

Re: [PATCH 1/3] drm/msm: Fix speed-bin support not to access outside valid memory

Hi, On Fri, Mar 5, 2021 at 2:28 AM Srinivas Kandagatla wrote: > > > > On 27/02/2021 00:26, Douglas Anderson wrote: > > When running the latest kernel on an sc7180 with KASAN I got this > > splat: > >BUG: KASAN: slab-out-of-bounds in a6xx_gpu_init+0x618/0x644 > >Read of size 4 at addr

Re: [PATCHv2 3/4] coresight: etm4x: Add support to exclude kernel mode tracing

Hi, On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan wrote: > > On production systems with ETMs enabled, it is preferred to exclude > kernel mode(NS EL1) tracing for security concerns and support only > userspace(NS EL0) tracing. Perf subsystem interface uses the newly > introduced kernel

Re: [PATCHv2 2/4] perf evsel: Print warning for excluding kernel mode instruction tracing

Hi, On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan wrote: > > Add a warning message to check CONFIG_EXCLUDE_KERNEL_HW_ITRACE kernel > config which excludes kernel mode instruction tracing to help perf tool > users identify the perf event open failure when they attempt kernel mode > tracing

Re: [PATCHv2 1/4] perf/core: Add support to exclude kernel mode PMU tracing

Hi, On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan wrote: > > Hardware assisted tracing families such as ARM Coresight, Intel PT > provides rich tracing capabilities including instruction level > tracing and accurate timestamps which are very useful for profiling > and also pose a

Re: [PATCHv2 4/4] coresight: etm3x: Add support to exclude kernel mode tracing

Hi, On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan wrote: > > On production systems with ETMs enabled, it is preferred to exclude > kernel mode(NS EL1) tracing for security concerns and support only > userspace(NS EL0) tracing. Perf subsystem interface uses the newly > introduced kernel

Re: [PATCH v5] kdb: Simplify kdb commands registration

Hi, On Tue, Feb 23, 2021 at 11:08 PM Sumit Garg wrote: > > Simplify kdb commands registration via using linked list instead of > static array for commands storage. > > Signed-off-by: Sumit Garg > --- > > Changes in v5: > - Introduce new method: kdb_register_table() to register static kdb >

Re: [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus

Hi, On Fri, Feb 26, 2021 at 10:45 AM Stephen Boyd wrote: > > Quoting Douglas Anderson (2021-02-25 14:13:10) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > > b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > > new file mode 100644 > > index

Re: [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown

Hi, On Thu, Feb 25, 2021 at 2:55 PM Konrad Dybcio wrote: > > Hi, > > > > > > +_mi2s_active { > > + pinconf { > > + pins = "gpio53", "gpio54", "gpio55", "gpio56"; > > + drive-strength = <2>; > > + bias-pull-down; > > + }; > > +}; > > + > > You can omit

Re: [PATCH v2 3/4] arm64: dts: qcom: sc7180: trogdor: Fix trip point config of charger thermal zone

Hi, On Thu, Feb 25, 2021 at 10:33 AM Matthias Kaehlcke wrote: > > The trip point configuration of the charger thermal zone for trogdor > is missing a node for the critical trip point. Add the missing node. > > Fixes: bb06eb3607e9 ("arm64: qcom: sc7180: trogdor: Add ADC nodes and thermal > zone

Re: [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus

Hi, On Thu, Feb 25, 2021 at 2:13 PM Douglas Anderson wrote: > > This is a trogdor variant. This is mostly a grab from the downstream > tree with notable exceptions: > - I skip -rev0. This was a super early build and there's no advantage > of long term support. > - In -rev1 I translate the

Re: [PATCH] Asoc: qcom: dts: Change MI2S GPIO configuration to pulldown

Hi, On Mon, Nov 16, 2020 at 3:35 AM Srinivasa Rao Mandadapu wrote: > > From: V Sujith Kumar Reddy > > Change LPASS MI2S gpio configuration to pull down from pull up. > > Fixes: 9b72f4e6a3f8 (arm64: dts: qcom: sc7180: Add lpass cpu node for I2S > driver) > > Signed-off-by: V Sujith Kumar Reddy

Re: [PATCH v4 4/5] arm64: dts: qcom: sc7180: Use pdc interrupts for USB instead of GIC interrupts

Hi, On Tue, Oct 27, 2020 at 1:38 PM Sandeep Maheswaram wrote: > > Using pdc interrupts for USB instead of GIC interrupts to > support wake up in case of XO shutdown. > > Signed-off-by: Sandeep Maheswaram > Reviewed-by: Stephen Boyd > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 >

Re: [PATCH] kgdb: Fix to kill breakpoints on initmem after boot

t prior to initmem > pages being freed. It might be worth it to mention that HW breakpoints aren't handled by this patch but it's probably not such a big deal. > Suggested-by: Doug Anderson > Signed-off-by: Sumit Garg > --- > include/linux/kgdb.h | 2 ++ > init/main.c

Re: [PATCH v2] kdb: Remove redundant function definitions/prototypes

Hi, On Tue, Feb 23, 2021 at 11:17 PM Sumit Garg wrote: > > Cleanup kdb code to get rid of unused function definitions/prototypes. > > Signed-off-by: Sumit Garg > --- > > Changes in v2: > - Keep kdbgetu64arg() the way it was. > > kernel/debug/kdb/kdb_private.h | 2 -- >

Re: [PATCH] kdb: Remove redundant function definitions/prototypes

Hi, On Tue, Feb 23, 2021 at 4:01 AM Sumit Garg wrote: > > @@ -103,7 +103,6 @@ extern int kdb_getword(unsigned long *, unsigned long, > size_t); > extern int kdb_putword(unsigned long, unsigned long, size_t); > > extern int kdbgetularg(const char *, unsigned long *); > -extern int

Re: [PATCH] kernel: debug: Handle breakpoints in kernel .init.text section

Hi, On Fri, Feb 19, 2021 at 12:03 AM Sumit Garg wrote: > > Currently breakpoints in kernel .init.text section are not handled > correctly while allowing to remove them even after corresponding pages > have been freed. > > In order to keep track of .init.text section breakpoints, add another >

Re: [PATCH 3/3] arm64: dts: qcom: sc7180: Delete charger thermal zone and ADC channel for lazor <= rev3

Hi, On Mon, Feb 22, 2021 at 12:45 PM Stephen Boyd wrote: > > Quoting Matthias Kaehlcke (2021-02-22 12:38:46) > > On Mon, Feb 22, 2021 at 12:20:04PM -0800, Stephen Boyd wrote: > > > Quoting Matthias Kaehlcke (2021-02-19 18:10:59) > > > > Lazor rev3 and older are stuffed with a 47k NTC as

Re: [PATCH 2/3] arm64: dts: qcom: sc7180: trogdor: Add labels to charger thermal zone and ADC channel

Hi, On Fri, Feb 19, 2021 at 6:11 PM Matthias Kaehlcke wrote: > > Some revisions of trogdor boards use a thermistor for the charger > temperature which currently isn't supported by the PM6150 ADC > driver. Add labels for the charger thermal zone and ADC channel > to allow the removal of these

Re: [PATCH 1/3] arm64: dts: qcom: sc7180: Add lazor rev4

Hi, On Fri, Feb 19, 2021 at 6:11 PM Matthias Kaehlcke wrote: > > Lazor rev3 and older are stuffed with a 47k NTC thermistor for the > charger temperature which currently isn't supported by the PM6150 ADC > driver. A supported thermistor is used in rev4 and later revisions. > Add rev4 .dts files

Re: [PATCH 3/4] coresight: etm4x: Add support to exclude kernel mode tracing

Hi, On Fri, Jan 29, 2021 at 11:08 AM Sai Prakash Ranjan wrote: > > @@ -1202,6 +1207,13 @@ void etm4_config_trace_mode(struct etmv4_config > *config) > /* excluding kernel AND user space doesn't make sense */ > WARN_ON_ONCE(mode == (ETM_MODE_EXCL_KERN | ETM_MODE_EXCL_USER)); > >

Re: [PATCH] arm64: dts: qcom: sc7180: Avoid glitching SPI CS at bootup on trogdor

Hi, On Thu, Feb 18, 2021 at 2:55 PM Douglas Anderson wrote: > > it's believed > that, under certain timing conditions, it could be getting the EC into > a confused state causing the EC driver to fail to probe. Believed => confirmed I _think_ is

  1   2   3   4   5   6   7   8   9   10   >