Re: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling

2015-02-19 Thread Tushar Behera
On 02/20/2015 12:48 AM, Andreas Färber wrote: > If master clock is provided through device tree, then update > the master clock frequency during set_sysclk. > > Cc: Tushar Behera > Signed-off-by: Andreas Färber > --- > sound/soc/codecs/max98088.c | 24 +

Re: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling

2015-02-19 Thread Tushar Behera
On 02/20/2015 12:48 AM, Andreas Färber wrote: If master clock is provided through device tree, then update the master clock frequency during set_sysclk. Cc: Tushar Behera tushar.beh...@linaro.org Signed-off-by: Andreas Färber afaer...@suse.de --- sound/soc/codecs/max98088.c | 24

Re: [alsa-devel] [PATCH 4/6] ASoC: samsung: Document binding for max98089 based Snow driver

2015-02-18 Thread Tushar Behera
- compatible : Can be one of the following, > + "google,snow-audio-max98089" or > "google,snow-audio-max98090" or > "google,snow-audio-max98091" or > "google,snow-audio-max98095" >

Re: [alsa-devel] [PATCH 4/6] ASoC: samsung: Document binding for max98089 based Snow driver

2015-02-18 Thread Tushar Behera
, + google,snow-audio-max98089 or google,snow-audio-max98090 or google,snow-audio-max98091 or google,snow-audio-max98095 Looks good. Acked-by: Tushar Behera trbli...@gmail.com -- Tushar Behera -- To unsubscribe from this list

Re: [PATCH V2 3/3] clk: exynos-audss: Use samsung clock APIs to register/unregister clocks

2014-07-14 Thread Tushar Behera
On Mon, Jul 14, 2014 at 9:04 PM, Sylwester Nawrocki wrote: > On 11/07/14 14:00, Tushar Behera wrote: >> @@ -103,17 +140,11 @@ static int exynos_audss_clk_probe(struct >> platform_device *pdev) >> return PTR_ERR(reg_base); >> } >> >&

Re: [PATCH V2 3/3] clk: exynos-audss: Use samsung clock APIs to register/unregister clocks

2014-07-14 Thread Tushar Behera
On Mon, Jul 14, 2014 at 9:04 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 11/07/14 14:00, Tushar Behera wrote: @@ -103,17 +140,11 @@ static int exynos_audss_clk_probe(struct platform_device *pdev) return PTR_ERR(reg_base); } - clk_table = devm_kzalloc

Re: [PATCH 2/2] clk: exynos-audss: Update as per existing framework

2014-07-11 Thread Tushar Behera
On 07/11/2014 04:10 PM, Sylwester Nawrocki wrote: > Hi Tushar, > > On 11/07/14 11:37, Tushar Behera wrote: >> Change exynos-audss clock driver as per existing clock framework from >> the existing module driver framework. > > Can you explain what's the actual i

[PATCH V2 3/3] clk: exynos-audss: Use samsung clock APIs to register/unregister clocks

2014-07-11 Thread Tushar Behera
Using samsung clock APIs to register/unregister clocks will save some lines of code. Signed-off-by: Tushar Behera --- Changes of v2: * Retain platform driver structure. drivers/clk/samsung/clk-exynos-audss.c | 146 1 file changed, 56 insertions(+), 90

[PATCH V2 2/3] clk: samsung: Add API to unregister clocks

2014-07-11 Thread Tushar Behera
Added an API to unregister all the clocks defined within a context. This is helpful in case where the clock is registered through a platform driver and we want to unregister the clocks during remove callback. Signed-off-by: Tushar Behera --- Changelog: This is new patch required because

[PATCH V2 0/3] clk: exynos-audss: Adapt to exising clock framework

2014-07-11 Thread Tushar Behera
Generic cleanup and usage of samsung clock register/unregister APIs. The patches are tested on Exynos5800 based Peach-Pi board. More tests are welcome. Tushar Behera (3): clk: exynos-audss: Simplify code to get clock names clk: samsung: Add API to unregister clocks clk: exynos-audss: Use

[PATCH V2 1/3] clk: exynos-audss: Simplify code to get clock names

2014-07-11 Thread Tushar Behera
Instead of getting the clock names individually, it would be good to put the logic within a loop. Signed-off-by: Tushar Behera --- Changes for V2: * Calling clk_put as soon as the clock is not required anymore drivers/clk/samsung/clk-exynos-audss.c | 35 +--- 1

Re: [PATCH 0/2] clk: exynos-audss: Adapt to exising clock framework

2014-07-11 Thread Tushar Behera
On 07/11/2014 03:21 PM, Tomasz Figa wrote: > Hi Tushar, > > On 11.07.2014 11:37, Tushar Behera wrote: >> The patchset is targetted as moving exising exynos-audss clock driver from >> being >> a module driver. The driver is now registered through CLK_OF_DECLARE and is &

[PATCH 0/2] clk: exynos-audss: Adapt to exising clock framework

2014-07-11 Thread Tushar Behera
The patchset is targetted as moving exising exynos-audss clock driver from being a module driver. The driver is now registered through CLK_OF_DECLARE and is inline with other Samsung clock drivers. The patches are tested on Exynos5800 based Peach-Pi board. More tests are welcome. Tushar Behera

[PATCH 1/2] clk: exynos-audss: Simplify code to get clock names

2014-07-11 Thread Tushar Behera
Instead of getting the clock names individually, it would be good to put the logic within a loop. Signed-off-by: Tushar Behera --- drivers/clk/samsung/clk-exynos-audss.c | 33 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/clk/samsung

[PATCH 2/2] clk: exynos-audss: Update as per existing framework

2014-07-11 Thread Tushar Behera
Change exynos-audss clock driver as per existing clock framework from the existing module driver framework. Signed-off-by: Tushar Behera --- drivers/clk/samsung/clk-exynos-audss.c | 239 1 file changed, 87 insertions(+), 152 deletions(-) diff --git a/drivers

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-07-11 Thread Tushar Behera
On 06/13/2014 02:39 AM, Mike Turquette wrote: > Quoting Tushar Behera (2014-06-12 00:29:23) >> On Wed, Jun 11, 2014 at 10:20 PM, Mike Turquette >> wrote: >>> Quoting Tushar Behera (2014-06-10 22:32:17) >>>> When the output clock of AUDSS mux is disabled, w

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-07-11 Thread Tushar Behera
On 06/13/2014 02:39 AM, Mike Turquette wrote: Quoting Tushar Behera (2014-06-12 00:29:23) On Wed, Jun 11, 2014 at 10:20 PM, Mike Turquette mturque...@linaro.org wrote: Quoting Tushar Behera (2014-06-10 22:32:17) When the output clock of AUDSS mux is disabled, we are getting kernel oops

[PATCH 2/2] clk: exynos-audss: Update as per existing framework

2014-07-11 Thread Tushar Behera
Change exynos-audss clock driver as per existing clock framework from the existing module driver framework. Signed-off-by: Tushar Behera tusha...@samsung.com --- drivers/clk/samsung/clk-exynos-audss.c | 239 1 file changed, 87 insertions(+), 152 deletions

[PATCH 0/2] clk: exynos-audss: Adapt to exising clock framework

2014-07-11 Thread Tushar Behera
The patchset is targetted as moving exising exynos-audss clock driver from being a module driver. The driver is now registered through CLK_OF_DECLARE and is inline with other Samsung clock drivers. The patches are tested on Exynos5800 based Peach-Pi board. More tests are welcome. Tushar Behera

[PATCH 1/2] clk: exynos-audss: Simplify code to get clock names

2014-07-11 Thread Tushar Behera
Instead of getting the clock names individually, it would be good to put the logic within a loop. Signed-off-by: Tushar Behera tusha...@samsung.com --- drivers/clk/samsung/clk-exynos-audss.c | 33 1 file changed, 17 insertions(+), 16 deletions(-) diff --git

Re: [PATCH 0/2] clk: exynos-audss: Adapt to exising clock framework

2014-07-11 Thread Tushar Behera
On 07/11/2014 03:21 PM, Tomasz Figa wrote: Hi Tushar, On 11.07.2014 11:37, Tushar Behera wrote: The patchset is targetted as moving exising exynos-audss clock driver from being a module driver. The driver is now registered through CLK_OF_DECLARE and is inline with other Samsung clock

[PATCH V2 0/3] clk: exynos-audss: Adapt to exising clock framework

2014-07-11 Thread Tushar Behera
Generic cleanup and usage of samsung clock register/unregister APIs. The patches are tested on Exynos5800 based Peach-Pi board. More tests are welcome. Tushar Behera (3): clk: exynos-audss: Simplify code to get clock names clk: samsung: Add API to unregister clocks clk: exynos-audss: Use

[PATCH V2 1/3] clk: exynos-audss: Simplify code to get clock names

2014-07-11 Thread Tushar Behera
Instead of getting the clock names individually, it would be good to put the logic within a loop. Signed-off-by: Tushar Behera tusha...@samsung.com --- Changes for V2: * Calling clk_put as soon as the clock is not required anymore drivers/clk/samsung/clk-exynos-audss.c | 35

[PATCH V2 2/3] clk: samsung: Add API to unregister clocks

2014-07-11 Thread Tushar Behera
Added an API to unregister all the clocks defined within a context. This is helpful in case where the clock is registered through a platform driver and we want to unregister the clocks during remove callback. Signed-off-by: Tushar Behera tusha...@samsung.com --- Changelog: This is new patch

[PATCH V2 3/3] clk: exynos-audss: Use samsung clock APIs to register/unregister clocks

2014-07-11 Thread Tushar Behera
Using samsung clock APIs to register/unregister clocks will save some lines of code. Signed-off-by: Tushar Behera tusha...@samsung.com --- Changes of v2: * Retain platform driver structure. drivers/clk/samsung/clk-exynos-audss.c | 146 1 file changed, 56

Re: [PATCH 2/2] clk: exynos-audss: Update as per existing framework

2014-07-11 Thread Tushar Behera
On 07/11/2014 04:10 PM, Sylwester Nawrocki wrote: Hi Tushar, On 11/07/14 11:37, Tushar Behera wrote: Change exynos-audss clock driver as per existing clock framework from the existing module driver framework. Can you explain what's the actual issue you're trying to solve with that patch

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-07-09 Thread Tushar Behera
On 07/09/2014 03:44 PM, Javier Martinez Canillas wrote: > Hello Tushar, > > On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera wrote: >>>> >>>> The u-boot version is a little different on my Peach-Pi as compared to >>>> the market release versi

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-07-09 Thread Tushar Behera
On 07/09/2014 03:44 PM, Javier Martinez Canillas wrote: Hello Tushar, On Tue, Jul 8, 2014 at 5:00 AM, Tushar Behera trbli...@gmail.com wrote: The u-boot version is a little different on my Peach-Pi as compared to the market release version. Not sure if that is making any difference. Peach

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-07-07 Thread Tushar Behera
On 07/08/2014 05:04 AM, Kukjin Kim wrote: > On 07/01/14 20:59, Tushar Behera wrote: >> On 06/27/2014 08:18 PM, Kevin Hilman wrote: >>> On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman >>> wrote: >>>> On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera >>>

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-07-07 Thread Tushar Behera
On 07/08/2014 05:04 AM, Kukjin Kim wrote: On 07/01/14 20:59, Tushar Behera wrote: On 06/27/2014 08:18 PM, Kevin Hilman wrote: On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilmankhil...@linaro.org wrote: On Thu, Jun 26, 2014 at 8:38 PM, Tushar Beheratrbli...@gmail.com wrote: Would you please

[PATCH] drm/exynos: fimd: Keep power enabled during fimd_bind

2014-07-04 Thread Tushar Behera
o keep power-domain enabled explicitly. Unhandled fault: external abort on non-linefetch (0x1008) at 0xf0180034 Internal error: : 1008 [#1] PREEMPT SMP ARM ... PC is at fimd_bind+0x84/0x134 LR is at component_bind_all+0xb4/0x1d8 Signed-off-by: Tushar Behera --- drivers/gpu/drm/exynos/exynos_drm_

[PATCH] gpiolib: of: Update debug messages for of_get_named_gpiod_flags

2014-07-04 Thread Tushar Behera
parse 'wp-gpios' property of node '/mmc@1222[0]' of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio-keys/power[0]' - status (0) Signed-off-by: Tushar Behera --- drivers/gpio/gpiolib-of.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpio

[PATCH] iommu/exynos: Select ARM_DMA_USE_IOMMU

2014-07-04 Thread Tushar Behera
For IOMMU to use on Exynos platforms, we need to enable ARM_DMA_USE_IOMMU. It would be better to select it by default when EXYNOS_IOMMU is enabled. Signed-off-by: Tushar Behera --- drivers/iommu/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/Kconfig b/drivers/iommu

[PATCH 1/2] ASoC: max98090: Add check for CODEC type

2014-07-04 Thread Tushar Behera
CODEC type (MAX98090/MAX98091) can be specified from device-tree file, it can also be obtained from the CODEC during runtime. Add an explicit check to figure out if both are matching, else print a message warning about the same. Signed-off-by: Tushar Behera --- sound/soc/codecs/max98090.c

[PATCH 2/2] ASoC: max98090: Remove redundant max98090_handle_pdata()

2014-07-04 Thread Tushar Behera
max98090_handle_pdata() is not doing anything other than printing a message if pdata is not valid. This can be removed. Signed-off-by: Tushar Behera --- sound/soc/codecs/max98090.c | 13 - 1 file changed, 13 deletions(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs

[PATCH 2/2] ASoC: core: Fix possible NULL pointer dereference

2014-07-04 Thread Tushar Behera
eck in snd_soc_of_parse_card_name() to take care of this case and print out a message in case of error. Signed-off-by: Tushar Behera --- sound/soc/soc-core.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index c4db07f..2e4bdc0 100

[PATCH 1/2] ASoC: samsung: Update sound-card name for Snow

2014-07-04 Thread Tushar Behera
Snow sound-card driver supports multiple boards with different audio codecs. Updating the sound card name per board basis would provide some more information to the end-user. Signed-off-by: Tushar Behera --- Documentation/devicetree/bindings/sound/snow.txt |4 sound/soc/samsung/snow.c

[PATCH 1/2] ASoC: samsung: Update sound-card name for Snow

2014-07-04 Thread Tushar Behera
Snow sound-card driver supports multiple boards with different audio codecs. Updating the sound card name per board basis would provide some more information to the end-user. Signed-off-by: Tushar Behera tusha...@samsung.com --- Documentation/devicetree/bindings/sound/snow.txt |4 sound

[PATCH 2/2] ASoC: core: Fix possible NULL pointer dereference

2014-07-04 Thread Tushar Behera
in snd_soc_of_parse_card_name() to take care of this case and print out a message in case of error. Signed-off-by: Tushar Behera tusha...@samsung.com --- sound/soc/soc-core.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index c4db07f

[PATCH 2/2] ASoC: max98090: Remove redundant max98090_handle_pdata()

2014-07-04 Thread Tushar Behera
max98090_handle_pdata() is not doing anything other than printing a message if pdata is not valid. This can be removed. Signed-off-by: Tushar Behera tusha...@samsung.com --- sound/soc/codecs/max98090.c | 13 - 1 file changed, 13 deletions(-) diff --git a/sound/soc/codecs/max98090

[PATCH 1/2] ASoC: max98090: Add check for CODEC type

2014-07-04 Thread Tushar Behera
CODEC type (MAX98090/MAX98091) can be specified from device-tree file, it can also be obtained from the CODEC during runtime. Add an explicit check to figure out if both are matching, else print a message warning about the same. Signed-off-by: Tushar Behera tusha...@samsung.com --- sound/soc

[PATCH] iommu/exynos: Select ARM_DMA_USE_IOMMU

2014-07-04 Thread Tushar Behera
For IOMMU to use on Exynos platforms, we need to enable ARM_DMA_USE_IOMMU. It would be better to select it by default when EXYNOS_IOMMU is enabled. Signed-off-by: Tushar Behera tusha...@samsung.com --- drivers/iommu/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu

[PATCH] gpiolib: of: Update debug messages for of_get_named_gpiod_flags

2014-07-04 Thread Tushar Behera
parse 'wp-gpios' property of node '/mmc@1222[0]' of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio-keys/power[0]' - status (0) Signed-off-by: Tushar Behera tusha...@samsung.com --- drivers/gpio/gpiolib-of.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[PATCH] drm/exynos: fimd: Keep power enabled during fimd_bind

2014-07-04 Thread Tushar Behera
power-domain enabled explicitly. Unhandled fault: external abort on non-linefetch (0x1008) at 0xf0180034 Internal error: : 1008 [#1] PREEMPT SMP ARM ... PC is at fimd_bind+0x84/0x134 LR is at component_bind_all+0xb4/0x1d8 Signed-off-by: Tushar Behera tusha...@samsung.com --- drivers/gpu/drm/exynos

Re: [PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi

2014-07-02 Thread Tushar Behera
t;180>; > + regulator-max-microvolt = <280>; > + regulator-always-on; > + Blank line, can be removed. > + }; [ ... ] > + ldo23_reg: LDO23 { > +

Re: [PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi

2014-07-02 Thread Tushar Behera
. + }; [ ... ] + ldo23_reg: LDO23 { + regulator-name = ld0_23; ldo_23, 'o' in place of '0'. Similar comments for peach-pi DTS file. -- Tushar Behera -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-07-01 Thread Tushar Behera
On 06/27/2014 08:18 PM, Kevin Hilman wrote: > On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman wrote: >> On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera wrote: >> >>> Would you please provide me the environment setting of your u-boot? >>> U-boot environment on my boa

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-07-01 Thread Tushar Behera
On 06/27/2014 08:18 PM, Kevin Hilman wrote: On Fri, Jun 27, 2014 at 7:18 AM, Kevin Hilman khil...@linaro.org wrote: On Thu, Jun 26, 2014 at 8:38 PM, Tushar Behera trbli...@gmail.com wrote: Would you please provide me the environment setting of your u-boot? U-boot environment on my board has

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-06-26 Thread Tushar Behera
On 06/26/2014 09:38 PM, Kevin Hilman wrote: > Tushar Behera writes: > >> On Thu, Jun 26, 2014 at 4:51 AM, Kevin Hilman wrote: >>> Doug Anderson writes: >>> >>>> Tushar, >>>> >>>> On Tue, Jun 10, 2014 at 10:32 PM, Tushar

[PATCH V2 2/2] serial: amba-pl010: Use devres APIs

2014-06-26 Thread Tushar Behera
Migrating to use devres managed APIs devm_kzalloc, devm_ioremap and devm_clk_get. Signed-off-by: Tushar Behera Reviewed-by: Daniel Thompson --- Changes for V2: * Added Reviewed-by tag * Removed redundant asm/io.h drivers/tty/serial/amba-pl010.c | 48

[PATCH V2 1/2] serial: amba-pl011: Remove redundant label

2014-06-26 Thread Tushar Behera
The label 'out' is only used to return the error code. We can return the error code directly and remove 'out' label. Signed-off-by: Tushar Behera Reviewed-by: Daniel Thompson --- Changes for V2: * Added Reviewed-by tag drivers/tty/serial/amba-pl011.c | 30 ++ 1

[PATCH 0/2] serial: amba-pl01x: Clean up patches

2014-06-26 Thread Tushar Behera
The patches are based next-20140626 and they have only been build tested. Tushar Behera (2): serial: amba-pl011: Remove redundant label serial: amba-pl010: Use devres APIs drivers/tty/serial/amba-pl010.c | 48 +-- drivers/tty/serial/amba-pl011.c | 30

Re: [PATCH 2/2] serial: amba-pl010: Use devres APIs

2014-06-26 Thread Tushar Behera
On 06/23/2014 06:16 PM, Daniel Thompson wrote: > On 23/06/14 06:59, Tushar Behera wrote: >> Migrating to use devres managed APIs devm_kzalloc, devm_ioremap and >> devm_clk_get. >> >> Signed-off-by: Tushar Behera >> --- >>

Re: [PATCH 2/2] serial: amba-pl010: Use devres APIs

2014-06-26 Thread Tushar Behera
On 06/23/2014 06:16 PM, Daniel Thompson wrote: On 23/06/14 06:59, Tushar Behera wrote: Migrating to use devres managed APIs devm_kzalloc, devm_ioremap and devm_clk_get. Signed-off-by: Tushar Behera tusha...@samsung.com --- drivers/tty/serial/amba-pl010.c | 46

[PATCH 0/2] serial: amba-pl01x: Clean up patches

2014-06-26 Thread Tushar Behera
The patches are based next-20140626 and they have only been build tested. Tushar Behera (2): serial: amba-pl011: Remove redundant label serial: amba-pl010: Use devres APIs drivers/tty/serial/amba-pl010.c | 48 +-- drivers/tty/serial/amba-pl011.c | 30

[PATCH V2 1/2] serial: amba-pl011: Remove redundant label

2014-06-26 Thread Tushar Behera
The label 'out' is only used to return the error code. We can return the error code directly and remove 'out' label. Signed-off-by: Tushar Behera tusha...@samsung.com Reviewed-by: Daniel Thompson daniel.thomp...@linaro.org --- Changes for V2: * Added Reviewed-by tag drivers/tty/serial/amba

[PATCH V2 2/2] serial: amba-pl010: Use devres APIs

2014-06-26 Thread Tushar Behera
Migrating to use devres managed APIs devm_kzalloc, devm_ioremap and devm_clk_get. Signed-off-by: Tushar Behera tusha...@samsung.com Reviewed-by: Daniel Thompson daniel.thomp...@linaro.org --- Changes for V2: * Added Reviewed-by tag * Removed redundant asm/io.h drivers/tty/serial/amba-pl010.c

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-06-26 Thread Tushar Behera
On 06/26/2014 09:38 PM, Kevin Hilman wrote: Tushar Behera trbli...@gmail.com writes: On Thu, Jun 26, 2014 at 4:51 AM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@google.com writes: Tushar, On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com wrote

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-06-25 Thread Tushar Behera
On Thu, Jun 26, 2014 at 4:51 AM, Kevin Hilman wrote: > Doug Anderson writes: > >> Tushar, >> >> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: >>> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. >>> As per

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-06-25 Thread Tushar Behera
On Thu, Jun 26, 2014 at 4:51 AM, Kevin Hilman khil...@linaro.org wrote: Doug Anderson diand...@google.com writes: Tushar, On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com wrote: Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. As per the user manual

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-24 Thread Tushar Behera
On 06/25/2014 04:29 AM, Doug Anderson wrote: > Tushar, > > On Thu, Jun 12, 2014 at 12:40 AM, Tushar Behera wrote: >> On Wed, Jun 11, 2014 at 10:20 PM, Kevin Hilman wrote: >>> Tushar Behera writes: >>> >>>> When the output clock of AUDSS mux is di

Re: [PATCH v2] ARM: dts: Add cros_ec to exynos5420-peach-pit and exynos5800-peach-pi

2014-06-24 Thread Tushar Behera
ier Martinez Canillas Along with the dependency patches on next-20140623, tested keyboard on Peach-Pi board. Tested-by: Tushar Behera Some comments below. > --- > Changes in v2: > - Now just one patch since mfd patch landed. > - Rebased to ToT linux-next > > arch/arm/boot

Re: [PATCH v2] ARM: dts: Add cros_ec to exynos5420-peach-pit and exynos5800-peach-pi

2014-06-24 Thread Tushar Behera
on next-20140623, tested keyboard on Peach-Pi board. Tested-by: Tushar Behera tusha...@samsung.com Some comments below. --- Changes in v2: - Now just one patch since mfd patch landed. - Rebased to ToT linux-next arch/arm/boot/dts/exynos5420-peach-pit.dts | 145

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-24 Thread Tushar Behera
On 06/25/2014 04:29 AM, Doug Anderson wrote: Tushar, On Thu, Jun 12, 2014 at 12:40 AM, Tushar Behera tusha...@samsung.com wrote: On Wed, Jun 11, 2014 at 10:20 PM, Kevin Hilman khil...@linaro.org wrote: Tushar Behera tusha...@samsung.com writes: When the output clock of AUDSS mux

Re: [PATCH 1/2] ASoC: max98090: Add max98091 compatible string

2014-06-23 Thread Tushar Behera
On 06/21/2014 02:02 AM, Doug Anderson wrote: > Tushar, > > On Fri, Jun 20, 2014 at 1:03 AM, Tushar Behera wrote: >> From: Wonjoon Lee >> >> The MAX98091 CODEC is the same as MAX98090 CODEC, but with an extra >> microphone. Existing driver for MAX98090 CODEC al

Re: [PATCH] usb: misc: usb3503: Update error code in print message

2014-06-23 Thread Tushar Behera
On 06/17/2014 04:54 PM, Marek Szyprowski wrote: > Hello, > > On 2014-06-17 13:08, Tushar Behera wrote: >> 'err' is uninitialized, rather print the error code directly. >> >> This also fixes following warning. >> drivers/usb/misc/usb3503.c: In function ‘usb3503_pr

[PATCH] serial: samsung: Remove redundant label

2014-06-23 Thread Tushar Behera
probe_err label only returns the error code. This label can be removed and the error code can be returned directly. Signed-off-by: Tushar Behera --- drivers/tty/serial/samsung.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/serial/samsung.c b/drivers/tty

[PATCH 0/2] serial: amba-pl01x: Clean up patches

2014-06-23 Thread Tushar Behera
The patches are based next-20140620 and they have only been build tested. Tushar Behera (2): serial: amba-pl011: Simplify goto statements serial: amba-pl010: Use devres APIs drivers/tty/serial/amba-pl010.c | 46 ++- drivers/tty/serial/amba-pl011.c

[PATCH 2/2] serial: amba-pl010: Use devres APIs

2014-06-23 Thread Tushar Behera
Migrating to use devres managed APIs devm_kzalloc, devm_ioremap and devm_clk_get. Signed-off-by: Tushar Behera --- drivers/tty/serial/amba-pl010.c | 46 ++- 1 file changed, 16 insertions(+), 30 deletions(-) diff --git a/drivers/tty/serial/amba-pl010.c b

[PATCH 1/2] serial: amba-pl011: Remove redundant label

2014-06-23 Thread Tushar Behera
The label 'out' is only used to return the error code. We can return the error code directly and remove 'out' label. Signed-off-by: Tushar Behera --- drivers/tty/serial/amba-pl011.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers

[PATCH 0/2] serial: amba-pl01x: Clean up patches

2014-06-23 Thread Tushar Behera
The patches are based next-20140620 and they have only been build tested. Tushar Behera (2): serial: amba-pl011: Simplify goto statements serial: amba-pl010: Use devres APIs drivers/tty/serial/amba-pl010.c | 46 ++- drivers/tty/serial/amba-pl011.c

[PATCH 2/2] serial: amba-pl010: Use devres APIs

2014-06-23 Thread Tushar Behera
Migrating to use devres managed APIs devm_kzalloc, devm_ioremap and devm_clk_get. Signed-off-by: Tushar Behera tusha...@samsung.com --- drivers/tty/serial/amba-pl010.c | 46 ++- 1 file changed, 16 insertions(+), 30 deletions(-) diff --git a/drivers/tty

[PATCH 1/2] serial: amba-pl011: Remove redundant label

2014-06-23 Thread Tushar Behera
The label 'out' is only used to return the error code. We can return the error code directly and remove 'out' label. Signed-off-by: Tushar Behera tusha...@samsung.com --- drivers/tty/serial/amba-pl011.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions

[PATCH] serial: samsung: Remove redundant label

2014-06-23 Thread Tushar Behera
probe_err label only returns the error code. This label can be removed and the error code can be returned directly. Signed-off-by: Tushar Behera tusha...@samsung.com --- drivers/tty/serial/samsung.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/serial

Re: [PATCH] usb: misc: usb3503: Update error code in print message

2014-06-23 Thread Tushar Behera
On 06/17/2014 04:54 PM, Marek Szyprowski wrote: Hello, On 2014-06-17 13:08, Tushar Behera wrote: 'err' is uninitialized, rather print the error code directly. This also fixes following warning. drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’: drivers/usb/misc/usb3503.c:195:11

Re: [PATCH 1/2] ASoC: max98090: Add max98091 compatible string

2014-06-23 Thread Tushar Behera
On 06/21/2014 02:02 AM, Doug Anderson wrote: Tushar, On Fri, Jun 20, 2014 at 1:03 AM, Tushar Behera tusha...@samsung.com wrote: From: Wonjoon Lee woojoo@samsung.com The MAX98091 CODEC is the same as MAX98090 CODEC, but with an extra microphone. Existing driver for MAX98090 CODEC

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-06-22 Thread Tushar Behera
On Mon, Jun 16, 2014 at 4:56 PM, Tushar Behera wrote: > On 06/11/2014 09:28 PM, Javier Martinez Canillas wrote: >> On Wed, Jun 11, 2014 at 7:32 AM, Tushar Behera wrote: >>> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. >>> As per the user manual

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-06-22 Thread Tushar Behera
On Mon, Jun 16, 2014 at 4:56 PM, Tushar Behera trbli...@gmail.com wrote: On 06/11/2014 09:28 PM, Javier Martinez Canillas wrote: On Wed, Jun 11, 2014 at 7:32 AM, Tushar Behera tusha...@samsung.com wrote: Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. As per the user manual

Re: [PATCH 0/3] Remove devm_request_and_ioremap()

2014-06-20 Thread Tushar Behera
;> Kroah-Hartman. [1] Also, it was accepted by Greg Kroah-Hartman. >>> [2] Thank you. >>> >>> [1] https://lkml.org/lkml/2014/6/11/26 [2] >>> https://lkml.org/lkml/2014/6/11/649 >> >> Yeah, I'll go apply that right now while I'm remembering it :) >

[PATCH 1/2] ASoC: max98090: Add max98091 compatible string

2014-06-20 Thread Tushar Behera
Signed-off-by: Doug Anderson Signed-off-by: Tushar Behera --- Picked from https://chromium-review.googlesource.com/#/c/184091/ .../devicetree/bindings/sound/max98090.txt |2 +- sound/soc/codecs/max98090.c|2 ++ 2 files changed, 3 insertions(+), 1 deletion

[PATCH 2/2] ASoC: samsung: Extend snow driver to support MAX98091

2014-06-20 Thread Tushar Behera
Peach-pi board has MAX98091 CODEC. Extend snow machine driver to support this board. Signed-off-by: Tushar Behera --- Documentation/devicetree/bindings/sound/snow.txt |1 + sound/soc/samsung/snow.c |1 + 2 files changed, 2 insertions(+) diff --git

[PATCH 2/2] ASoC: samsung: Extend snow driver to support MAX98091

2014-06-20 Thread Tushar Behera
Peach-pi board has MAX98091 CODEC. Extend snow machine driver to support this board. Signed-off-by: Tushar Behera tusha...@samsung.com --- Documentation/devicetree/bindings/sound/snow.txt |1 + sound/soc/samsung/snow.c |1 + 2 files changed, 2 insertions(+) diff

[PATCH 1/2] ASoC: max98090: Add max98091 compatible string

2014-06-20 Thread Tushar Behera
-by: Wonjoon Lee woojoo@samsung.com Signed-off-by: Doug Anderson diand...@chromium.org Signed-off-by: Tushar Behera tusha...@samsung.com --- Picked from https://chromium-review.googlesource.com/#/c/184091/ .../devicetree/bindings/sound/max98090.txt |2 +- sound/soc/codecs/max98090

Re: [PATCH 0/3] Remove devm_request_and_ioremap()

2014-06-20 Thread Tushar Behera
now while I'm remembering it :) For the patch above: Reviewed-by: Wolfram Sang w...@the-dreams.de If it is still not late, Acked-by: Tushar Behera trbli...@gmail.com - -- Tushar Behera -BEGIN PGP SIGNATURE- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http

[PATCH] usb: misc: usb3503: Update error code in print message

2014-06-17 Thread Tushar Behera
nable to request refclk (%d)\n", err); Signed-off-by: Tushar Behera --- Based on next-20140616. drivers/usb/misc/usb3503.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c index f43c619..652855b 100644 --- a/d

[PATCH] usb: misc: usb3503: Update error code in print message

2014-06-17 Thread Tushar Behera
to request refclk (%d)\n, err); Signed-off-by: Tushar Behera tusha...@samsung.com --- Based on next-20140616. drivers/usb/misc/usb3503.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c index f43c619..652855b 100644

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
on > of using aliases to refer to things in the SoC, like: > > { > status = "okay"; > }; > > _7 { > status = "okay"; > }; > > ...it's not at all obvious in the board file what the base address in > the SoC was. > In case where

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
On Mon, Jun 16, 2014 at 10:19 PM, Doug Anderson wrote: > Tushar, > > On Mon, Jun 16, 2014 at 4:19 AM, Tushar Behera wrote: >> On 06/13/2014 10:33 PM, Doug Anderson wrote: >>> Tushar, >>> >>> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera >>>

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-06-16 Thread Tushar Behera
On 06/11/2014 09:28 PM, Javier Martinez Canillas wrote: > On Wed, Jun 11, 2014 at 7:32 AM, Tushar Behera wrote: >> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. >> As per the user manual, it should be CLK_MAU_EPLL. >> >> The problem surfaced when

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
On 06/13/2014 10:33 PM, Doug Anderson wrote: > Tushar, > > On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: >> Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. > > If you want to be a stickler about it, peach-pi actually has a > max98091. Th

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
On 06/13/2014 10:33 PM, Doug Anderson wrote: Tushar, On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com wrote: Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. If you want to be a stickler about it, peach-pi actually has a max98091. That requires code

Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420

2014-06-16 Thread Tushar Behera
On 06/11/2014 09:28 PM, Javier Martinez Canillas wrote: On Wed, Jun 11, 2014 at 7:32 AM, Tushar Behera tusha...@samsung.com wrote: Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux. As per the user manual, it should be CLK_MAU_EPLL. The problem surfaced when the bootloader

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
On Mon, Jun 16, 2014 at 10:19 PM, Doug Anderson diand...@google.com wrote: Tushar, On Mon, Jun 16, 2014 at 4:19 AM, Tushar Behera trbli...@gmail.com wrote: On 06/13/2014 10:33 PM, Doug Anderson wrote: Tushar, On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com wrote

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
to have an official order to make diffing easier and also to avoid merge conflicts (unlikely someone changing different properties will both add them in the same place in the ordering). -Doug -- Tushar Behera -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-12 Thread Tushar Behera
On Wed, Jun 11, 2014 at 10:20 PM, Kevin Hilman wrote: > Tushar Behera writes: > >> When the output clock of AUDSS mux is disabled, we are getting kernel >> oops while doing a clk_get() on other clocks provided by AUDSS. >> >> Though user manual doesn't specify t

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-12 Thread Tushar Behera
On Wed, Jun 11, 2014 at 10:58 PM, Tomasz Figa wrote: > Hi Tushar, > > On 11.06.2014 07:32, Tushar Behera wrote: >> When the output clock of AUDSS mux is disabled, we are getting kernel >> oops while doing a clk_get() on other clocks provided by AUDSS. Though >>

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-12 Thread Tushar Behera
On Wed, Jun 11, 2014 at 10:20 PM, Mike Turquette wrote: > Quoting Tushar Behera (2014-06-10 22:32:17) >> When the output clock of AUDSS mux is disabled, we are getting kernel >> oops while doing a clk_get() on other clocks provided by AUDSS. Though >> user manual doesn't sp

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-12 Thread Tushar Behera
On Wed, Jun 11, 2014 at 10:20 PM, Mike Turquette mturque...@linaro.org wrote: Quoting Tushar Behera (2014-06-10 22:32:17) When the output clock of AUDSS mux is disabled, we are getting kernel oops while doing a clk_get() on other clocks provided by AUDSS. Though user manual doesn't specify

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-12 Thread Tushar Behera
On Wed, Jun 11, 2014 at 10:58 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Tushar, On 11.06.2014 07:32, Tushar Behera wrote: When the output clock of AUDSS mux is disabled, we are getting kernel oops while doing a clk_get() on other clocks provided by AUDSS. Though user manual doesn't

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-12 Thread Tushar Behera
On Wed, Jun 11, 2014 at 10:20 PM, Kevin Hilman khil...@linaro.org wrote: Tushar Behera tusha...@samsung.com writes: When the output clock of AUDSS mux is disabled, we are getting kernel oops while doing a clk_get() on other clocks provided by AUDSS. Though user manual doesn't specify

  1   2   3   4   5   6   7   8   >