Re: [PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-05 Thread Minchan Kim
On Fri, Mar 05, 2021 at 05:06:17PM +0100, Michal Hocko wrote: > On Wed 03-03-21 12:23:22, Minchan Kim wrote: > > On Wed, Mar 03, 2021 at 01:49:36PM +0100, Michal Hocko wrote: > > > On Tue 02-03-21 13:09:48, Minchan Kim wrote: > > > > LRU pagevec holds refcount of pages until the pagevec are

Re: [PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-05 Thread Michal Hocko
On Wed 03-03-21 12:23:22, Minchan Kim wrote: > On Wed, Mar 03, 2021 at 01:49:36PM +0100, Michal Hocko wrote: > > On Tue 02-03-21 13:09:48, Minchan Kim wrote: > > > LRU pagevec holds refcount of pages until the pagevec are drained. > > > It could prevent migration since the refcount of the page is

Re: [PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-04 Thread Minchan Kim
On Thu, Mar 04, 2021 at 09:07:28AM +0100, David Hildenbrand wrote: > On 03.03.21 21:23, Minchan Kim wrote: > > On Wed, Mar 03, 2021 at 01:49:36PM +0100, Michal Hocko wrote: > > > On Tue 02-03-21 13:09:48, Minchan Kim wrote: > > > > LRU pagevec holds refcount of pages until the pagevec are drained.

Re: [PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-04 Thread David Hildenbrand
On 03.03.21 21:23, Minchan Kim wrote: On Wed, Mar 03, 2021 at 01:49:36PM +0100, Michal Hocko wrote: On Tue 02-03-21 13:09:48, Minchan Kim wrote: LRU pagevec holds refcount of pages until the pagevec are drained. It could prevent migration since the refcount of the page is greater than the

Re: [PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-03 Thread Minchan Kim
On Wed, Mar 03, 2021 at 01:49:36PM +0100, Michal Hocko wrote: > On Tue 02-03-21 13:09:48, Minchan Kim wrote: > > LRU pagevec holds refcount of pages until the pagevec are drained. > > It could prevent migration since the refcount of the page is greater > > than the expection in migration logic. To

Re: [PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-03 Thread kernel test robot
Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on linux/master linus/master v5.12-rc1 next-20210303] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-03 Thread kernel test robot
Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on linux/master linus/master v5.12-rc1 next-20210303] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-03 Thread kernel test robot
Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on linux/master linus/master v5.12-rc1 next-20210303] [cannot apply to hnaz-linux-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-03 Thread Michal Hocko
On Tue 02-03-21 13:09:48, Minchan Kim wrote: > LRU pagevec holds refcount of pages until the pagevec are drained. > It could prevent migration since the refcount of the page is greater > than the expection in migration logic. To mitigate the issue, > callers of migrate_pages drains LRU pagevec via

[PATCH 1/2] mm: disable LRU pagevec during the migration temporarily

2021-03-02 Thread Minchan Kim
LRU pagevec holds refcount of pages until the pagevec are drained. It could prevent migration since the refcount of the page is greater than the expection in migration logic. To mitigate the issue, callers of migrate_pages drains LRU pagevec via migrate_prep or lru_add_drain_all before