Re: [PATCH] cpufreq: cached_resolved_idx can not be negative

On Thu, Jul 30, 2020 at 9:38 AM Viresh Kumar wrote: > > It is not possible for cached_resolved_idx to be invalid here as the > cpufreq core always sets index to a positive value. > > Change its type to unsigned int and fix qcom usage a bit. Shouldn't you fix up idx in

Re: [PATCH v3 2/3] Input: snvs_pwrkey - enable snvs clock as needed

On Wed, Jul 29, 2020 at 09:33:23AM +0200, Marco Felsch wrote: > Hi, > > On 20-07-23 10:43, Horia Geantă wrote: > > From: André Draszik > > > > At the moment, enabling this driver without the SNVS RTC driver > > being active will hang the kernel as soon as the power button > > is pressed. > > >

Re: [PATCH v3 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events

Hi Marco, On Wed, Jul 29, 2020 at 09:55:13AM +0200, Marco Felsch wrote: > Hi, > > On 20-07-23 10:43, Horia Geantă wrote: > > From: André Draszik > > > > The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc. > > > > This driver here should only return IRQ_HANDLED if the

[PATCH] Input: elan_i2c - Add ic type 0x15.

The update firmware flow of ic type 0x15 is same with ic type 0x14. Signed-off-by: Jingle Wu --- drivers/input/mouse/elan_i2c_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index

Re: [RESEND PATCH v5 00/11] ppc64: enable kdump support for kexec_file_load syscall

On 28/07/20 8:02 am, piliu wrote: On 07/27/2020 03:36 AM, Hari Bathini wrote: Sorry! There was a gateway issue on my system while posting v5, due to which some patches did not make it through. Resending... This patch series enables kdump support for kexec_file_load system call (kexec -s

Re: bpfilter logging write errors in dmesg

Ho Rodrigo, please try this patch: diff --git a/net/bpfilter/bpfilter_kern.c b/net/bpfilter/bpfilter_kern.c index 1905e01c3aa9a7..4494ea6056cdb8 100644 --- a/net/bpfilter/bpfilter_kern.c +++ b/net/bpfilter/bpfilter_kern.c @@ -39,7 +39,7 @@ static int __bpfilter_process_sockopt(struct sock *sk,

Re: [PATCH v17 18/21] mm/lru: introduce the relock_page_lruvec function

在 2020/7/30 上午1:52, Alexander Duyck 写道: >> + rcu_read_lock(); >> + locked = mem_cgroup_page_lruvec(page, pgdat) == locked_lruvec; >> + rcu_read_unlock(); >> + >> + if (locked) >> + return locked_lruvec; >> + >> + if (locked_lruvec) >> +

[PATCH 4/8] modules: unexport __module_text_address

__module_text_address is only used by built-in code. Signed-off-by: Christoph Hellwig --- kernel/module.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c index feeaa9629eb179..d241866f9d4a2b 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -4508,7

[PATCH 5/8] modules: unexport __module_address

__module_address is only used by built-in code. Signed-off-by: Christoph Hellwig --- kernel/module.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c index d241866f9d4a2b..54e853c7212f72 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -4469,7 +4469,6 @@

inherit TAINT_PROPRIETARY_MODULE v2

Hi Jessica, we've had a bug in our resolution of _GPL modules since day one, that is a module can claim to be GPL licensed and use _GPL exports, while it also depends on symbols from non-GPL modules. This is used as a circumvention of the _GPL exports by using a small shim module using the _GPL

[PATCH 2/8] modules: mark find_symbol static

find_symbol is only used in module.c. Signed-off-by: Christoph Hellwig --- include/linux/module.h | 11 --- kernel/module.c| 3 +-- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index

Re: [PATCH] cpufreq: cached_resolved_idx can not be negative

On 30-07-20, 11:29, Amit Kucheria wrote: > On Thu, Jul 30, 2020 at 9:38 AM Viresh Kumar wrote: > > > > It is not possible for cached_resolved_idx to be invalid here as the > > cpufreq core always sets index to a positive value. > > > > Change its type to unsigned int and fix qcom usage a bit. >

[PATCH 3/8] modules: mark each_symbol_section static

each_symbol_section is only used inside of module.c. Signed-off-by: Christoph Hellwig --- include/linux/module.h | 9 - kernel/module.c| 3 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index

[PATCH 6/8] modules: rename the licence field in struct symsearch to license

Use the same spelling variant as the rest of the file. Signed-off-by: Christoph Hellwig --- include/linux/module.h | 2 +- kernel/module.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index

[PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag for all modules importing these symbols, and don't allow loading symbols from TAINT_PROPRIETARY_MODULE modules if the module previously imported gplonly symbols. Add a anti-circumvention devices so people don't accidentally get

[PATCH 7/8] modules: return licensing information from find_symbol

Report the GPLONLY status through a new argument. Signed-off-by: Christoph Hellwig --- include/linux/module.h | 2 +- kernel/module.c| 16 +++- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index

[PATCH 1/8] modules: mark ref_module static

ref_module isn't used anywhere outside of module.c. Signed-off-by: Christoph Hellwig --- include/linux/module.h | 1 - kernel/module.c| 6 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index

[PATCH] uacce: fix some coding styles

1. delete some redundant code. 2. modify the module author information. Signed-off-by: Kai Ye --- Changes in V2: deleted extra NULL pointer check in uacce_fops. drivers/misc/uacce/uacce.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git

[PATCH net-next] liquidio: Replace vmalloc with kmalloc in octeon_register_dispatch_fn()

The size of struct octeon_dispatch is too small, it is better to use kmalloc instead of vmalloc. Suggested-by: Joe Perches Signed-off-by: Wang Hai --- drivers/net/ethernet/cavium/liquidio/octeon_device.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

Re: linux-next: build failure after merge of the origin tree

On Thu, Jul 30, 2020 at 05:22:50AM +0200, Willy Tarreau wrote: > On Wed, Jul 29, 2020 at 08:17:48PM -0700, Kees Cook wrote: > > And just another heads-up, the patch[1] (which was never sent to a public > > list) also breaks arm64 (circular header needs?): > (...) > > Definitely, we've just got a

[PATCH 1/1] x86/tsr: Fix tsc frequency enumeration failure on lightning mountain SoC

Frequency descriptor of Lightning Mountain SoC doesn't have all the frequency entries so resulting in the below failure causing kernel hang. [0.00] Error MSR_FSB_FREQ index 15 is unknown [0.00] tsc: Fast TSC calibration failed So, add all the frequency entries in the Lightning

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

[Adding vsprintf maintainers to Cc:] Hello, On Wed, Jul 29, 2020 at 10:06:53PM -0700, Dmitry Torokhov wrote: > On Wed, Jul 29, 2020 at 09:21:45AM +0200, Uwe Kleine-König wrote: > > Hello, > > > > On Tue, Jul 28, 2020 at 11:36:38PM -0700, Dmitry Torokhov wrote: > > > > v9: > > > > -

Re: [PATCH net-next] liquidio: Remove unneeded cast from memory allocation

在 2020/7/28 23:54, Joe Perches 写道: On Tue, 2020-07-28 at 21:38 +0800, wanghai (M) wrote: Thanks for your explanation. I got it. Can it be modified like this? [] +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c @@ -1152,11 +1152,8 @@ octeon_register_dispatch_fn(struct

Re: [PATCH v4 2/4] input: gpio-vibra: Allow to use vcc-supply alone to control the vibrator

Hi Ondrej, On Tue, Jul 14, 2020 at 12:23:01PM +0200, Ondrej Jirman wrote: > Make enable-gpio optional to allow using this driver with boards that > have vibrator connected to a power supply without intermediate gpio > based enable circuitry. > > Also avoid a case where neither regulator nor

RE: [PATCH] remoteproc: virtio: support sharing vdev buffer

Hi Mathieu, > Subject: Re: [PATCH] remoteproc: virtio: support sharing vdev buffer > > Hi Peng, > > On Wed, Jul 22, 2020 at 09:15:43PM +0800, Peng Fan wrote: > > Support sharing vdev buffer between multiple vdevs by using name > > "vdevbuffer". > > > > Reviewed-by: Richard Zhu > >

Re: [PATCH] exfat: retain 'VolumeFlags' properly

Ping.. On 2020/07/15 19:06, Tetsuhiro Kohada wrote: It looks complicated. It would be better to simply set/clear VOLUME DIRTY bit. I think exfat_set_vol_flags() gets a little complicated, because it needs the followings (with bit operation)  a) Set/Clear VOLUME_DIRTY.  b) Set MEDIA_FAILUR.

Re: [PATCH 2/2] thermal: cpufreq_cooling: Reuse effective_cpu_util()

On 17-07-20, 11:46, Vincent Guittot wrote: > On Thu, 16 Jul 2020 at 16:24, Lukasz Luba wrote: > > On 7/16/20 12:56 PM, Peter Zijlstra wrote: > > > Currently cpufreq_cooling appears to estimate the CPU energy usage by > > > calculating the percentage of idle time using the per-cpu cpustat stuff, >

Re: add file system helpers that take kernel pointers for the init code v4

On Wed, Jul 29, 2020 at 08:51:17PM +0100, Al Viro wrote: > On Tue, Jul 28, 2020 at 06:33:53PM +0200, Christoph Hellwig wrote: > > Hi Al and Linus, > > > > currently a lot of the file system calls in the early in code (and the > > devtmpfs kthread) rely on the implicit set_fs(KERNEL_DS) during

Re: [PATCH 1/2] reset-controller: ti: adjust the reset assert and deassert interface

On Wed, 2020-07-29 at 16:02 +0800, Philipp Zabel wrote: > Hi Crystal, Matthias, > > On Wed, 2020-07-29 at 09:48 +0200, Matthias Brugger wrote: > > > > On 29/07/2020 09:39, Crystal Guo wrote: > > > Add ti_syscon_reset() to integrate assert and deassert together, > > > and change return value of

Re: [PATCH] Input: elan_i2c - Add ic type 0x15.

On Thu, Jul 30, 2020 at 02:05:26AM -0400, Jingle Wu wrote: > The update firmware flow of ic type 0x15 is same with ic type 0x14. > > Signed-off-by: Jingle Wu Applied, thank you. -- Dmitry

Re: [PATCH] cpufreq: cached_resolved_idx can not be negative

On Thu, Jul 30, 2020 at 11:40 AM Viresh Kumar wrote: > > On 30-07-20, 11:29, Amit Kucheria wrote: > > On Thu, Jul 30, 2020 at 9:38 AM Viresh Kumar > > wrote: > > > > > > It is not possible for cached_resolved_idx to be invalid here as the > > > cpufreq core always sets index to a positive

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

On Thu, Jul 30, 2020 at 08:16:31AM +0200, Uwe Kleine-König wrote: > [Adding vsprintf maintainers to Cc:] > > Hello, > > On Wed, Jul 29, 2020 at 10:06:53PM -0700, Dmitry Torokhov wrote: > > On Wed, Jul 29, 2020 at 09:21:45AM +0200, Uwe Kleine-König wrote: > > > Hello, > > > > > > On Tue, Jul 28,

[PATCH] s390/test_unwind: fix possible memleak in test_unwind()

test_unwind() misses to call kfree(bt) in an error path. Add the missed function call to fix it. Fixes: 0610154650f1 ("s390/test_unwind: print verbose unwinding results") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- arch/s390/lib/test_unwind.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] cpufreq: cached_resolved_idx can not be negative

On 30-07-20, 12:02, Amit Kucheria wrote: > Looking at this more closely, I found another call site for > cpufreq_frequency_table_target() in cpufreq.c that needs the index to > be unsigned int. > > But then cpufreq_frequency_table_target() returns -EINVAL, so we It returns -EINVAL only in the

[PATCH -next] bnxt_en: Remove superfluous memset()

Fixes coccicheck warning: ./drivers/net/ethernet/broadcom/bnxt/bnxt.c:3730:19-37: WARNING: dma_alloc_coherent use in stats -> hw_stats already zeroes out memory, so memset is not needed dma_alloc_coherent use in status already zeroes out memory, so memset is not needed Reported-by: Hulk Robot

{standard input}:20594: Error: found '(', expected: ')'

Hi Paul, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d3590ebf6f91350192737dd1d1b219c05277f067 commit: 21e3134b3ec09e722cbcda69788f206adc8db1f4 MIPS: barrier: Clean up rmb() & wmb() definitions date: 10 months

Re: [PATCH v3] usb: typec: tcpm: Migrate workqueue to RT priority for processing events

On Wed, Jul 29, 2020 at 07:24:57PM -0700, Badhri Jagan Sridharan wrote: > "tReceiverResponse 15 ms Section 6.6.2 > The receiver of a Message requiring a response Shall respond > within tReceiverResponse in order to ensure that the > sender’s SenderResponseTimer does not expire." > > When the cpu

[PATCH v1 0/3] net: ethernet: use generic power management

Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to upgrade power management in net ethernet drivers. This has been done by upgrading .suspend() and .resume() callbacks. The upgrade makes sure that the involvement of PCI Core does not change the order of

[PATCH v1 1/3] sc92031: use generic power management

Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the

[PATCH v1 3/3] tlan: use generic power management

Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the

[PATCH v1 2/3] sis900: use generic power management

Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

Hi, OTOH, you should have CCed all the (public) lists. On 30. 07. 20, 4:50, 张云海 wrote: > Zhang Xiao points out that the check should use > instead of >=, > otherwise the last line will be skip. > I agree with that, so I modify the patch. > Could you please verify that it is still correct and

[PATCH net] qtnfmac: Missing platform_device_unregister() on error in qtnf_core_mac_alloc()

Add the missing platform_device_unregister() before return from qtnf_core_mac_alloc() in the error handling case. Fixes: 616f5701f4ab ("qtnfmac: assign each wiphy to its own virtual platform device") Reported-by: Hulk Robot Signed-off-by: Wang Hai ---

[PATCH 2/2] reset: imx7: add the cm4 reset for i.MX8MQ

From: Peng Fan Add the cm4 reset used by the remoteproc driver Signed-off-by: Peng Fan --- drivers/reset/reset-imx7.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c index d170fe663210..87b6e2d46fb6 100644 ---

[PATCH 1/2] dt-bindings: reset: imx8mq: add m4 reset

From: Peng Fan Add the m4 reset used by the remoteproc driver Signed-off-by: Peng Fan --- include/dt-bindings/reset/imx8mq-reset.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/dt-bindings/reset/imx8mq-reset.h b/include/dt-bindings/reset/imx8mq-reset.h index

Re: [PATCH 2/3] driver core: Use rwsem for kill_device() serialization

On Wed, Jul 08, 2020 at 03:27:02PM +0200, Lukas Wunner wrote: > kill_device() is currently serialized with driver probing by way of the > device_lock(). We're about to serialize it with device_add() as well > to prevent addition of children below a device which is going away. Why? Who does

RE: [PATCH v2] exfat: integrates dir-entry getting and validation

> Add validation for num, bh and type on getting dir-entry. > ('file' and 'stream-ext' dir-entries are pre-validated to ensure success) > Renamed > exfat_get_dentry_cached() to exfat_get_validated_dentry() due to a change in > functionality. > > Integrate type-validation with simplified. > This

Re: [PATCH 0/3] Fix races on device removal

On Wed, Jul 08, 2020 at 03:27:00PM +0200, Lukas Wunner wrote: > Prevent dynamic SPI device addition below a controller which is > being removed. To do so, set the controller's "dead" flag using > kill_device() (patch [3/3]). Why is the SPI bus allowing this to happen? Don't you have a per-bus

[PATCH v1 3/3] tlan: use generic power management

Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the

[PATCH v1 2/3] sis900: use generic power management

Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the

[PATCH v1 0/3] net: ethernet: use generic power management

Linux Kernel Mentee: Remove Legacy Power Management. The purpose of this patch series is to upgrade power management in net ethernet drivers. This has been done by upgrading .suspend() and .resume() callbacks. The upgrade makes sure that the involvement of PCI Core does not change the order of

[PATCH v1 1/3] sc92031: use generic power management

Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the

RE: [PATCH] exfat: retain 'VolumeFlags' properly

> Ping.. Hi Tetsuhiro, > > On 2020/07/15 19:06, Tetsuhiro Kohada wrote: > >> It looks complicated. It would be better to simply set/clear VOLUME DIRTY > >> bit. > > > > I think exfat_set_vol_flags() gets a little complicated, because it > > needs the followings (with bit operation) > > a)

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

Hello, On Wed, Jul 29, 2020 at 11:34:04PM -0700, Dmitry Torokhov wrote: > On Thu, Jul 30, 2020 at 08:16:31AM +0200, Uwe Kleine-König wrote: > > I suggested that some time ago with limited success, see > > https://lore.kernel.org/lkml/20200129115516.zsvxu56e6h7gh...@pathway.suse.cz/ > > . > > > >

[char-misc-next V2] mei: hdcp: fix mei_hdcp_verify_mprime() input paramter

wired_cmd_repeater_auth_stream_req_in has a variable length array at the end. we use struct_size() overflow macro to determine the size for the allocation and sending size. Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Fixes: c56967d674e3 (mei: hdcp:

Re: [PATCH 08/23] fs: don't change the address limit for ->write_iter in __kernel_write

On Wed, Jul 29, 2020 at 09:50:36PM +0100, Al Viro wrote: > On Tue, Jul 07, 2020 at 07:47:46PM +0200, Christoph Hellwig wrote: > > If we write to a file that implements ->write_iter there is no need > > to change the address limit if we send a kvec down. Implement that > > case, and prefer it over

Re: [PATCH 22/23] fs: default to generic_file_splice_read for files having ->read_iter

On Thu, Jul 30, 2020 at 01:05:44AM +0100, Al Viro wrote: > On Tue, Jul 07, 2020 at 07:48:00PM +0200, Christoph Hellwig wrote: > > If a file implements the ->read_iter method, the iter based splice read > > works and is always preferred over the ->read based one. Use it by > > default in

[PATCH v1] scsi: smartpqi: use generic power management

Drivers using legacy power management .suspen()/.resume() callbacks have to manage PCI states and device's PM states themselves. They also need to take care of standard configuration registers. Switch to generic power management framework using a single "struct dev_pm_ops" variable to take the

Re: [PATCH v9 0/4] driver core: add probe error check helper

On Tue, Jul 28, 2020 at 05:05:03PM +0200, Andrzej Hajda wrote: > Hi Greg, > > Apparently the patchset has no more comments. > > Could you take the patches to your tree? At least 1st and 2nd. All now queued up, thanks! greg k-h

Re: [PATCH 15/23] seq_file: switch over direct seq_read method calls to seq_read_iter

Al Viro writes: > On Fri, Jul 17, 2020 at 11:09:13PM +0200, Thomas Gleixner wrote: >> >> Needs some thought and maybe some cocci help from Julia, but that's way >> better than this brute force sed thing which results in malformed crap >> like this: >> >> static const struct file_operations

Re: bpfilter logging write errors in dmesg

On Mon, Jul 27, 2020 at 04:50:13PM +0200, Christoph Hellwig wrote: > Strange. Can you add this additional debugging patch: Sorry Christoph, didn't mean to leave you waiting. I got pulled into other stuff. Christian > > diff --git a/fs/read_write.c b/fs/read_write.c > index

KASAN: slab-out-of-bounds Read in ath9k_hif_usb_rx_cb (2)

Hello, syzbot found the following issue on: HEAD commit:ab4dc051 usb: mtu3: simplify mtu3_req_complete() git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing console output: https://syzkaller.appspot.com/x/log.txt?x=11c0666c90 kernel config:

Re: [PATCH V3 3/3] pci: imx: Select RESET_IMX7 by default

Hi Anson, On Thu, 2020-07-30 at 02:11 +, Anson Huang wrote: > Hi, Philipp/Rob > > > Subject: Re: [PATCH V3 3/3] pci: imx: Select RESET_IMX7 by default > > > > On Wed, 2020-07-29 at 09:26 -0600, Rob Herring wrote: > > > On Mon, Jul 20, 2020 at 8:26 AM Anson Huang > > wrote: > > > > i.MX7

Re: [patch V5 05/15] entry: Provide infrastructure for work before transitioning to guest mode

Qian Cai writes: > On Wed, Jul 22, 2020 at 11:59:59PM +0200, Thomas Gleixner wrote: > SR-IOV will start trigger a warning below in this commit, > > [ 765.434611] WARNING: CPU: 13 PID: 3377 at include/linux/entry-kvm.h:75 > kvm_arch_vcpu_ioctl_run+0xb52/0x1320 [kvm] Yes, I'm a moron. Fixed it

Re: [PATCH V8 1/6] clk: imx6sl: Use BIT(x) to avoid shifting signed 32-bit value by 31 bits

On Thu, Jul 30, 2020 at 2:03 AM Anson Huang wrote: > > Use readl_relaxed() instead of __raw_readl(), and use BIT(x) > instead of (1 << X) to fix below build warning reported by kernel > test robot: > > drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit > value by 31 bits is

Re: [RFC PATCH] arm64: defconfig: Disable fine-grained task level IRQ time accounting

Hi Vladimir, On Wed Jul 29 2020, Vladimir Oltean wrote: > For more context, here is my original report of the issue: > https://lkml.org/lkml/2020/6/4/1062 > > Just like you, I could not reproduce the RCU stalls and system hang on a > 5.6-rt kernel, just on mainline and derivatives, using the

Re: [PATCH] ASoC: fsl-asoc-card: Remove fsl_asoc_card_set_bias_level function

On Mon, Jul 27, 2020 at 8:58 AM Nicolin Chen wrote: > > On Sun, Jul 26, 2020 at 07:20:17PM +0800, Shengjiu Wang wrote: > > With this case: > > aplay -Dhw:x 16khz.wav 24khz.wav > > There is sound distortion for 24khz.wav. The reason is that setting > > PLL of WM8962 with set_bias_level function,

[PATCH v4] usb: typec: tcpm: Migrate workqueue to RT priority for processing events

"tReceiverResponse 15 ms Section 6.6.2 The receiver of a Message requiring a response Shall respond within tReceiverResponse in order to ensure that the sender’s SenderResponseTimer does not expire." When the cpu complex is busy running other lower priority work items, TCPM's work queue sometimes

[PATCH net] net: ll_temac: Use devm_platform_ioremap_resource_byname()

platform_get_resource() may fail and return NULL, so we had better check its return value to avoid a NULL pointer dereference a bit later in the code. Fix it to use devm_platform_ioremap_resource_byname() instead of calling platform_get_resource_byname() and devm_ioremap(). Fixes: 8425c41d1ef7

Re: [PATCH V7 1/6] clk: imx6sl: Use BIT(x) to avoid shifting signed 32-bit value by 31 bits

On Thu, Jul 30, 2020 at 3:14 AM Anson Huang wrote: > > Subject: Re: [PATCH V7 1/6] clk: imx6sl: Use BIT(x) to avoid shifting signed > > 32-bit value by 31 bits > > or you could read Documentation/process/submit-checklist.rst, > > where rule #1 says: > > > > 1) If you use a facility then #include

Re: [PATCH v3] usb: typec: tcpm: Migrate workqueue to RT priority for processing events

Hi Greg, Yes Guenter's suspicion is right. Mine was conflicting with Han's following patch: commit 5f2b8d87bca528616e04344d1fc4032dc5ec0f3d Author: Hans de Goede Date: Fri Jul 24 19:46:57 2020 +0200 usb: typec: tcpm: Move mod_delayed_work(>vdm_state_machine) call into tcpm_queue_vdm()

Re: [PATCH 01/17] dt-bindings: clocks: imx8mp: Rename audiomix ids clocks to audio_blk_ctrl

On 20-07-29 12:47:26, Stephen Boyd wrote: > Quoting Abel Vesa (2020-07-29 05:07:47) > > In the reference manual the actual name is Audio BLK_CTRL. > > Lets make it more obvious here by renaming from audiomix to audio_blk_ctrl. > > And this is safe because there aren't any users of the defines?

Re: [PATCH 10/17] Documentation: bindings: clk: Add bindings for i.MX BLK_CTRL

On 20-07-29 12:49:41, Stephen Boyd wrote: > Quoting Abel Vesa (2020-07-29 05:07:56) > > diff --git a/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml > > b/Documentation/devicetree/bindings/clock/fsl,imx-blk-ctrl.yaml > > new file mode 100644 > > index ..036d3d3 > > ---

Re: [PATCH] Revert "Bluetooth: btusb: Disable runtime suspend on Realtek devices"

Hi Kai-Heng, >> On Jul 30, 2020, at 07:17, Abhishek Pandit-Subedi >> wrote: >> >> This reverts commit 7ecacafc240638148567742cca41aa7144b4fe1e. >> >> Testing this change on a board with RTL8822CE, I found that enabling >> autosuspend has no effect on the stability of the system. The board >>

Re: [PATCH v2 stable-5.4.y] Revert "dpaa_eth: fix usage as DSA master, try 3"

On Wed, Jun 24, 2020 at 03:45:17PM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > This reverts commit 40a904b1c2e57b22dd002dfce73688871cb0bac8. > > The patch is not wrong, but the Fixes: tag is. It should have been: > > Fixes: 060ad66f9795 ("dpaa_eth: change DMA device") > >

[PATCH net] net: gemini: Fix missing clk_disable_unprepare() in error path of gemini_ethernet_port_probe()

Fix the missing clk_disable_unprepare() before return from gemini_ethernet_port_probe() in the error handling case. Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/cortina/gemini.c | 5

Re: [PATCH v2] checkpatch: Fix the usage of capture group ( ... )

On Thu, 2020-07-30 at 07:58 +0200, Lukas Bulwahn wrote: > Hi Joe, > > did you see this quick fix to checkpatch.pl? Can you comment on the > commit and can we get a quick ack on that fix, please? Yes, in a bit. > General question on patches for ./scripts/checkpatch.pl: > How do they travel to

[PATCH] ACPI / APEI: do memory failure on the physical address reported by ARM processor error section

After the following commit applied, user-mode SEA is preferentially processed by APEI. Do memory failure to recover. But there are some problems: 1) The function apei_claim_sea() has processed an CPER, does not mean that memory failure handling has done. Because the firmware-first RAS error is

Re: [PATCH] s390/test_unwind: fix possible memleak in test_unwind()

On Thu, 2020-07-30 at 14:36 +0800, Wang Hai wrote: > test_unwind() misses to call kfree(bt) in an error path. > Add the missed function call to fix it. > > Fixes: 0610154650f1 ("s390/test_unwind: print verbose unwinding > results") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai > --- >

[PATCH v2] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

In net/packet/af_packet.c, the function packet_snd first reserves a headroom of length (dev->hard_header_len + dev->needed_headroom). Then if the socket is a SOCK_DGRAM socket, it calls dev_hard_header, which calls dev->header_ops->create, to create the link layer header. If the socket is a

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

On 30. 07. 20, 8:46, Jiri Slaby wrote: > Hi, OTOH, you should have CCed all the (public) lists. > > On 30. 07. 20, 4:50, 张云海 wrote: >> Zhang Xiao points out that the check should use > instead of >=, >> otherwise the last line will be skip. >> I agree with that, so I modify the patch. >> Could

[PATCH net] wl1251: fix always return 0 error

wl1251_event_ps_report() should not always return 0 because wl1251_ps_set_mode() may fail. Change it to return 'ret'. Fixes: f7ad1eed4d4b ("wl1251: retry power save entry") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/wireless/ti/wl1251/event.c | 2 +- 1 file changed, 1

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

On Thu, Jul 30, 2020 at 4:00 AM Herbert Xu wrote: > > On Wed, Jul 29, 2020 at 06:04:57PM +0300, Andy Shevchenko wrote: > > On Wed, Jul 29, 2020 at 4:35 PM Waiman Long wrote: > > > On 7/29/20 8:28 AM, Herbert Xu wrote: > > > > ... > > > > > This patch series looks good to me. I just wonder if we

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

On Thu, Jul 30, 2020 at 10:47:16AM +0300, Andy Shevchenko wrote: > > We may ask Synopsys folks to look at this as well. > Vineet, any ideas if we may unify ATOMIC64_INIT() across the architectures? I don't think there is any technical difficulty. The custom atomic64_t simply adds an alignment

linux-next: build failure after merge of the vhost tree

Hi all, After merging the vhost tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/virtio/virtio_vdpa.c: In function 'virtio_vdpa_get': drivers/virtio/virtio_vdpa.c:60:32: warning: unused variable 'ops' [-Wunused-variable] 60 | const struct vdpa_config_ops *ops =

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

On Thu, Jul 30, 2020 at 10:51 AM Herbert Xu wrote: > On Thu, Jul 30, 2020 at 10:47:16AM +0300, Andy Shevchenko wrote: > > > > We may ask Synopsys folks to look at this as well. > > Vineet, any ideas if we may unify ATOMIC64_INIT() across the architectures? > > I don't think there is any technical

Re: [PATCH 1/1] x86/tsr: Fix tsc frequency enumeration failure on lightning mountain SoC

On Thu, Jul 30, 2020 at 9:16 AM Dilip Kota wrote: > > Frequency descriptor of Lightning Mountain SoC doesn't have all the > frequency entries so resulting in the below failure causing kernel hang. > > [0.00] Error MSR_FSB_FREQ index 15 is unknown > [0.00] tsc: Fast TSC calibration

Re: [PATCH v2] scsi: ufs: Fix possible infinite loop in ufshcd_hold

Hi Can, On Wed, 2020-07-29 at 18:53 +0800, Can Guo wrote: > Hi Stanley, > > On 2020-07-29 18:26, Stanley Chu wrote: > > Hi Can, > > > > On Wed, 2020-07-29 at 16:43 +0800, Can Guo wrote: > >> Hi Stanley, > >> > >> On 2020-07-29 10:40, Stanley Chu wrote: > >> > In ufshcd_suspend(), after

[RFC PATCH 3/3] opp: Power on (virtual) power domains managed by the OPP core

dev_pm_opp_attach_genpd() allows attaching an arbitrary number of power domains to an OPP table. In that case, the genpd core will create a virtual device for each of the power domains. At the moment, the OPP core only calls dev_pm_genpd_set_performance_state() on these virtual devices. It does

[RFC PATCH 1/3] opp: Reduce code duplication in _set_required_opps()

Move call to dev_pm_genpd_set_performance_state() to a separate function so we can avoid duplicating the code for the single and multiple genpd case. Signed-off-by: Stephan Gerhold --- drivers/opp/core.c | 40 +--- 1 file changed, 21 insertions(+), 19

RE: [PATCH 2/2] ASoC: Intel: Add period size constraint on strago board

> > Is this patch required if you've already constrained the period sizes for the > platform driver in patch1? Yes or alsa will select 320 as default period size for it. Regards, Brent

Re: [PATCH v2] drivers/net/wan/lapbether: Use needed_headroom instead of hard_header_len

Hi Martin, I'm currently working on a plan to make all X.25 drivers (lapbether.c, x25_asy.c, hdlc_x25.c) to set dev->hard_header_len / dev->needed_headroom correctly. So that upper layers no longer need to guess how much headroom a X.25 device needs with a constant value (as they currently do).

Re: [PATCH] selinux: add tracepoint on denials

On 7/28/20 6:02 PM, Thiébaud Weksteen wrote: > On Tue, Jul 28, 2020 at 5:12 PM Paul Moore wrote: >> Perhaps it would be helpful if you provided an example of how one >> would be expected to use this new tracepoint? That would help put >> things in the proper perspective. > The best example is

[PATCH 5.7 12/20] tcp: allow at most one TLP probe per flight

From: Yuchung Cheng [ Upstream commit 76be93fc0702322179bb0ea87295d820ee46ad14 ] Previously TLP may send multiple probes of new data in one flight. This happens when the sender is cwnd limited. After the initial TLP containing new data is sent, the sender receives another ACK that acks partial

[PATCH 5.7 11/20] rxrpc: Fix sendmsg() returning EPIPE due to recvmsg() returning ENODATA

From: David Howells [ Upstream commit 639f181f0ee20d3249dbc55f740f0167267180f0 ] rxrpc_sendmsg() returns EPIPE if there's an outstanding error, such as if rxrpc_recvmsg() indicating ENODATA if there's nothing for it to read. Change rxrpc_recvmsg() to return EAGAIN instead if there's nothing to

[PATCH 5.7 14/20] sctp: shrink stream outq only when new outcnt < old outcnt

From: Xin Long [ Upstream commit 8f13399db22f909a35735bf8ae2f932e0c8f0e30 ] It's not necessary to go list_for_each for outq->out_chunk_list when new outcnt >= old outcnt, as no chunk with higher sid than new (outcnt - 1) exists in the outqueue. While at it, also move the list_for_each code in

[PATCH 5.7 10/20] rtnetlink: Fix memory(net_device) leak when ->newlink fails

From: Weilong Chen [ Upstream commit cebb69754f37d68e1355a5e726fdac317bcda302 ] When vlan_newlink call register_vlan_dev fails, it might return error with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should free the memory. But currently rtnl_newlink only free the memory which state

[PATCH 5.7 13/20] AX.25: Prevent integer overflows in connect and sendmsg

From: Dan Carpenter [ Upstream commit 17ad73e941b71f3bec7523ea4e9cbc3752461c2d ] We recently added some bounds checking in ax25_connect() and ax25_sendmsg() and we so we removed the AX25_MAX_DIGIS checks because they were no longer required. Unfortunately, I believe they are required to

[PATCH 5.7 15/20] sctp: shrink stream outq when fails to do addstream reconf

From: Xin Long [ Upstream commit 3ecdda3e9ad837cf9cb41b6faa11b1af3a5abc0c ] When adding a stream with stream reconf, the new stream firstly is in CLOSED state but new out chunks can still be enqueued. Then once gets the confirmation from the peer, the state will change to OPEN. However, if the

[PATCH 5.7 03/20] dev: Defer free of skbs in flush_backlog

From: Subash Abhinov Kasiviswanathan [ Upstream commit 7df5cb75cfb8acf96c7f2342530eb41e0c11f4c3 ] IRQs are disabled when freeing skbs in input queue. Use the IRQ safe variant to free skbs here. Fixes: 145dd5f9c88f ("net: flush the softnet backlog in process context") Signed-off-by: Subash

  1   2   3   4   5   6   7   8   9   10   >