Re: [PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-23 Thread Federico Vaga
, + .vidioc_create_bufs = vb2_ioctl_create_bufs, If you want to use create_bufs, then in queue_setup() you need to handle the fmt argument. See e.g. vivi.c for an example. Fixed I will send a patch v3 tomorrow -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH v3 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-24 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Federico Vaga federico.v...@gmail.com --- drivers

[PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-24 Thread Federico Vaga
-by: Federico Vaga federico.v...@gmail.com --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h | 32 4

[PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-24 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga federico.v...@gmail.com Acked-by: Giancarlo Asnaghi

[PATCH v3 4/4] adv7180: remove {query/g_/s_}ctrl

2012-09-24 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/i2c/adv7180.c | 3 --- 1

[PATCH v3 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-25 Thread Federico Vaga
-by: Federico Vaga federico.v...@gmail.com --- drivers/media/v4l2-core/videobuf2-core.c | 11 +++ include/media/videobuf2-core.h | 7 +++ 2 file modificati, 18 inserzioni(+) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index

Re: [PATCH] base/core.c: improve comment of the function device_find_child()

2013-04-15 Thread Federico Vaga
On Friday 12 April 2013 14:51:25 Greg Kroah-Hartman wrote: On Fri, Apr 12, 2013 at 01:59:32PM +0200, Federico Vaga wrote: Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/base/core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/base/core.c b

Re: drivers/base/core.c: about device_find_child() function

2013-04-15 Thread Federico Vaga
to put_device(). But I think that is not a strong argumentation, and later in time someone will propose his own special use of device_for_each_child(). I think that device_for_each_child() is generic enough to cover this problem. -- Federico Vaga -- To unsubscribe from this list: send the line

Re: drivers/base/core.c: about device_find_child() function

2013-04-15 Thread Federico Vaga
it, (after you test it first of course), so that we can apply it? Yes, I can do it and test it. I hope to find the time for a test in these days. -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

[PATCH v2] base/core.c: improve comment of the function device_find_child()

2013-04-15 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/base/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 016312437..3c8512f 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1372,6 +1372,8 @@ int

[PATCH] serial_core.c: add put_device() after device_find_child()

2013-04-15 Thread Federico Vaga
The serial core uses device_find_child() but does not drop the reference to the retrieved child after using it. This patch add the missing put_device(). Signed-off-by: Federico Vaga federico.v...@gmail.com --- What I have done to test this issue. I used a machine with an AMBA PL011 serial

[RFC PATCH] sparc/kernel/vio.c: add put_device() after device_find_child()

2013-04-15 Thread Federico Vaga
The vio_remove() function uses device_find_child() but it does not drop the reference of the retrieved child. Signed-off-by: Federico Vaga federico.v...@gmail.com --- I do not have a SPARC system (and I do not know it), so I cannot test this patch. Please test it. If I'm right

drivers/base/core.c: about device_find_child() function

2013-04-11 Thread Federico Vaga
(). If the driver do not need to get_device() on a child device, it simply does a device_search_child() to retrieve a pointer. -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH] base/core.c: improve comment of the function device_find_child()

2013-04-12 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/base/core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 016312437..eb0c6ea 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1372,6 +1372,10 @@ int

Re: drivers/base/core.c: about device_find_child() function

2013-04-12 Thread Federico Vaga
On Thursday 11 April 2013 06:48:44 Greg Kroah-Hartman wrote: On Thu, Apr 11, 2013 at 01:52:36PM +0200, Federico Vaga wrote: Hello, I'm using the function device_find_child() [drivers/base/core.c] to retrieve a specific child of a device. I see that this function invokes get_device

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-04 Thread Federico Vaga
On Tuesday 04 December 2012 14:15:15 Mauro Carvalho Chehab wrote: Em 24-09-2012 07:58, Federico Vaga escreveu: This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
this. * Copyright (C) 2012 ST Microelectronics * author: Federico Vaga federico.v...@gmail.com * Copyright (C) 2010 WindRiver Systems, Inc. * authors: Andreas Kies andreas.k...@windriver.com * Vlad Lungu vlad.lu...@windriver.com The only way of not preserving

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-12-05 Thread Federico Vaga
On Tuesday 04 December 2012 14:04:22 Mauro Carvalho Chehab wrote: Em 24-09-2012 09:44, Marek Szyprowski escreveu: Hello, On Monday, September 24, 2012 12:59 PM Federico Vaga wrote: The DMA streaming allocator is similar to the DMA contig but it use the DMA streaming interface

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
Ok, I understand. I will write something like this. * Copyright (C) 2012 ST Microelectronics * author: Federico Vaga federico.v...@gmail.com * Copyright (C) 2010 WindRiver Systems, Inc. * authors: Andreas Kies andreas.k...@windriver.com

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
it with due care. Getting other authors's acks on such patch seems to be the only safe way of doing that. Yes I got the point. Thank you -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-05 Thread Federico Vaga
ones from videobuf2 and v4l2_fh Signed-off-by: Federico Vaga federico.v...@gmail.com Acked-by: Giancarlo Asnaghi giancarlo.asna...@st.com --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1073 +-- 2 file modificati, 434

Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-06 Thread Federico Vaga
...), that these are really useful improvements, and that I reviewed the code (as well as I could) and didn't see any problems, I'm giving my ack anyway: Tested every time I sent a patch Acked-by: Hans Verkuil hans.verk...@cisco.com Thank you again -- Federico Vaga -- To unsubscribe from this list: send the line

[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-01-23 Thread Federico Vaga
ones from videobuf2 and v4l2_fh Signed-off-by: Federico Vaga federico.v...@gmail.com Acked-by: Giancarlo Asnaghi giancarlo.asna...@st.com --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1071 +-- 2 file modificati, 432

[PATCH v6 2/2] adv7180: remove {query/g_/s_}ctrl

2013-01-23 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/i2c/adv7180.c | 3 --- 1

[PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-21 Thread federico . vaga
From: Federico Vaga federico.v...@gmail.com This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga federico.v

[PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-21 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Federico Vaga federico.v...@gmail.com --- drivers

[PATCH v2 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-21 Thread Federico Vaga
-by: Federico Vaga federico.v...@gmail.com --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h | 32 4

[PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-21 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga federico.v...@gmail.com Acked-by: Giancarlo Asnaghi

[PATCH v2 4/4] adv7180: remove {query/g_/s_}ctrl

2012-09-21 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit the controls from this subdevice. Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/i2c/adv7180.c | 3

Re: [PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-21 Thread Federico Vaga
. Anyway, I will apply this comment fix. -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-13 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Federico Vaga federico.v...@gmail.com --- drivers

[PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h

[PATCH 2/4] adv7180: remove {query/g_/s_}ctrl

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 45ecf8d..43bc2b9 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c

[PATCH 4/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com Acked-by: Giancarlo Asnaghi giancarlo.asna...@st.com --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1235 ++- 2 file modificati, 411 inserzioni(+), 826 rimozioni

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
to summarize each function. what do you think? -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
On Thursday, September 13, 2012 3:53 PM Federico Vaga wrote: Signed-off-by: Federico Vaga federico.v...@gmail.com A few words explaining why this memory handling module is required or beneficial will definitely improve the commit :) ok, I will write some lines +static void

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
doing in each vb2_mem_ops. I suppose that this is the reason why there are no comments inside the other memory allocator. Maybe I am wrong. -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
In data giovedì 13 settembre 2012 11:45:31, Jonathan Corbet ha scritto: On Thu, 13 Sep 2012 17:46:32 +0200 Federico Vaga federico.v...@gmail.com wrote: A few words explaining why this memory handling module is required or beneficial will definitely improve the commit :) ok, I

Re: Update VIP to videobuf2 and control framework

2012-08-16 Thread Federico Vaga
for critical comments and then I will send patches. -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 2/3] [media] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-08-24 Thread Federico Vaga
. Can I work on these patches? From this page I understand that these patches are not approved yet https://patchwork.kernel.org/project/linux-media/list/?page=2 -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 2/3] [media] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-08-24 Thread Federico Vaga
-- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Update STA2X11 to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
add it to inherit controls from adv7180. -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

[PATCH 1/3 RFC] [media] adv7180: remove {query/g_/s_}ctrl

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/video/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 07bb550..bcc7d60 100644 --- a/drivers/media/video/adv7180.c +++ b/drivers/media/video

Update VIP to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
As suggested I moved the Video Buffer Input (VIP) of the STA2X11 board to the videobuf2. This patch series is an RFC. The first patch is just an update to the adv7180 because the VIP (the only user) now use the control framework so query{g_|s_|ctrl} are not necessery. The second patch adds a new

[PATCH 1/3] [media] adv7180: remove {query/g_/s_}ctrl

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/video/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 07bb550..bcc7d60 100644 --- a/drivers/media/video/adv7180.c +++ b/drivers/media/video

[PATCH 2/3] [media] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/video/Kconfig | 6 +- drivers/media/video/Makefile | 1 + drivers/media/video/videobuf2-dma-streaming.c | 187 ++ include/media/videobuf2-dma-streaming.h

[PATCH 3/3] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com Acked-by: Giancarlo Asnaghi giancarlo.asna...@st.com --- drivers/media/video/sta2x11_vip.c | 1134 ++--- 1 file modificato, 410 inserzioni(+), 724 rimozioni(-) diff --git a/drivers/media/video/sta2x11_vip.c b

Re: [PATCH 1/3] [media] adv7180: remove {query/g_/s_}ctrl

2012-07-31 Thread Federico Vaga
I'm sorry for the email duplication, I press the wrong key on git-send email. Ignore these emails. Sorry -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: Update VIP to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
I use git send-email command to send patches but I think I made a mistake. If something is wrong or confused please tell me and I try to resend all the patches hopefully without mistake. Sorry again. 2012/7/31 Federico Vaga federico.v...@gmail.com: As suggested I moved the Video Buffer Input

Re: Update VIP to videobuf2 and control framework

2012-08-05 Thread Federico Vaga
. -- -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Update VIP to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
using struct v4l2_fh? The version you posted didn't. You need this anyway to implement control events. Yes I'm using it now, it is part of the extra simplification that I did. -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com Acked-by: Giancarlo Asnaghi giancarlo.asna...@st.com --- drivers/media/video/sta2x11_vip.c | 1239 + 1 file modificato, 414 inserzioni(+), 825 rimozioni(-) diff --git a/drivers/media/video/sta2x11_vip.c b

Re: Update VIP to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
In that case I need to see your latest version of the source code to see why it doesn't work. I send it as patch v2 of the previous one -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
. That will be set automatically as soon as v4l2_fh_open is called. I saw unsigned long flags; in the header but without reading the comment :) Thank you. I will test it in these days but I think it's all done. -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [GIT PULL FOR v3.5] Move sta2x11_vip to staging

2012-07-08 Thread Federico Vaga
Any news on this? Hi Hans, I'm on it :) -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH 1/3] adv7180: add support to user controls

2012-07-08 Thread Federico Vaga
If you could do that work, then that would be much appreciated. You have the hardware, after all, so that makes it easier for you. Hi Hans, I'll submit a patch for the control framework on the ADV7180 -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-10 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/video/adv7180.c | 221 + 1 file changed, 90 insertions(+), 131 deletions(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 174bffa..7705456 100644

Re: [PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Federico Vaga
to initialize the controls since v4l2_ctrl_handler_setup does that for you already. Removed -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Federico Vaga
suggest? I re-submit this patch and when sta2x11 is fixed a I submit a new patch to remove these lines; or wait the full conversion of the sta2x11 driver and submit both patch? -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

[PATCH] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/video/adv7180.c | 235 +++-- 1 file changed, 84 insertions(+), 151 deletions(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 174bffa..07bb550 100644

[PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-06 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga federico.v...@gmail.com Acked-by: Giancarlo Asnaghi

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-12-11 Thread Federico Vaga
not a DMA performance expert. I skip this -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

[PATCH RFC] spidev.c: add sysfs attributes for SPI configuration

2012-11-24 Thread Federico Vaga
dd02 spidev spi1.0: setup mode 0, 8 bits/w, 45 Hz max -- 0 spidev spi1.0: 45 Hz (max) Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/spi/spidev.c | 258 +-- 1 file modificato, 208 inserzioni(+), 50 rimozioni

Re: [PATCH RFC] spidev.c: add sysfs attributes for SPI configuration

2012-12-20 Thread Federico Vaga
is the advantage of ioctl through char device? Or what it the issue with sysfs? Thank you very much -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-12-20 Thread Federico Vaga
, but they cannot help me. -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RFC] spidev.c: add sysfs attributes for SPI configuration

2012-12-22 Thread Federico Vaga
not so persuasive :) I can develop a simple program that can write custom tx buf with ioctl -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-03 Thread Federico Vaga
will do it -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-04 Thread Federico Vaga
On Thursday 03 January 2013 17:13:14 Federico Vaga wrote: After all those discussions, I'm ok on adding this new driver, but please add a summary of those discussions at the patch description. As I said, the reason why this driver is needed is not obvious. So, it needs to be very well

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-06 Thread Federico Vaga
. -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags

2013-01-06 Thread Federico Vaga
This is useful when you need to specify specific GFP flags during memory allocation (e.g. GFP_DMA). Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 7 ++- include/media/videobuf2-dma-contig.h | 5 + 2 file modificati, 7

[PATCH V4 2/3] sta2x11_vip: convert to videobuf2 and control framework

2013-01-06 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga federico.v...@gmail.com Acked-by: Giancarlo Asnaghi

[PATCH V4 3/3] adv7180: remove {query/g_/s_}ctrl

2013-01-06 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga federico.v...@gmail.com --- drivers/media/i2c/adv7180.c | 3 --- 1

Re: [PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags

2013-01-08 Thread Federico Vaga
GFP_DMA we can saturate this tiny zone. As you said, this fix the issue with _older_ and _non-standard_ (like sta2x11) systems. But this fix has effect on every other standard and new systems. That's why I preferred to set the flag optionally. -- Federico Vaga -- To unsubscribe from this list: send

Re: [PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags

2013-01-08 Thread Federico Vaga
vb2_alloc_ctx and (at the moment) it is used only by dma-contig -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-16 Thread Federico Vaga
? Or it is work in progress right now (soon), so it is better to wait after the merge? In order to use the s3c-hsotg I must implement a PCI wrapper that uses this driver. It will be accepted in the kernel even if it will be removed sooner or later because of the driver merge? Thank you :) -- Federico Vaga

Re: DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-16 Thread Federico Vaga
Thank you Felipe [add CC Giancarlo from ST] On Tuesday 16 July 2013 15:04:25 Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 02:01:33PM +0200, Federico Vaga wrote: Hello, I have an x86 board made by STMicroelectronics (STA2X11) with the Synopsis USB-OTG DesignWare 2

[RFC] assign some address families for local use

2013-05-16 Thread Federico Vaga
attached to this email the patch that do these stuff. -- Federico VagaFrom 8ce4f2576aa8e95ea22921c31bdffd049460951d Mon Sep 17 00:00:00 2001 From: Federico Vaga federico.v...@gmail.com Date: Wed, 15 May 2013 12:32:03 +0200 Subject: [PATCH] include/linux/socket.h: assign address families for local use

[PATCH] net/core/sock.c: add missing VSOCK string in af_family_*_key_strings

2013-05-28 Thread Federico Vaga
The three arrays of strings: af_family_kay_strings, af_family_slock_key_strings and af_family_clock_key_strings have not VSOCK's string Signed-off-by: Federico Vaga federico.v...@gmail.com --- net/core/sock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/core

[PATCH] dwc2/pci.c: add STMICRO vendor and device ID for STA2X11 board

2013-05-13 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@gmail.com Acked-by: Giancarlo Asnaghi giancarlo.asna...@st.com --- drivers/staging/dwc2/pci.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c index 69c65eb..7029b9f 100644 --- a/drivers

Re: DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-22 Thread Federico Vaga
does it takes because I am really busy at the moment You know the hardware better than me, so: have you other suggestion to point me on the right way? Thank you :) -- Federico Vaga -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

[PATCH] ipoctal: protect only the real critical section

2014-06-26 Thread Federico Vaga
; it means that it is not protected at all. Signed-off-by: Federico Vaga federico.v...@cern.ch --- drivers/ipack/devices/ipoctal.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c index 141094e..69687f1 100644

Re: PCIe bus enumeration

2014-07-07 Thread Federico Vaga
On Friday 04 July 2014 15:26:12 Bjorn Helgaas wrote: On Fri, Jul 04, 2014 at 09:55:20AM +0200, Federico Vaga wrote: I assume these ports don't support hotplug. If they *did* support hotplug, those ports would have to exist because they handle the hotplug events (presence detect, etc

Re: PCIe bus enumeration

2014-07-08 Thread Federico Vaga
your lspci output to the bugzilla (https://bugzilla.kernel.org/show_bug.cgi?id=72681). Maybe you could attach the biosdecode info there, too, and we could see if there's a way we can make this easier. ok -- Federico Vaga-[:00]-+-00.0 +-01.0-[05]00.0 +-02.0

Re: PCIe bus enumeration

2014-07-08 Thread Federico Vaga
On Tuesday 08 July 2014 12:23:39 Bjorn Helgaas wrote: On Tue, Jul 8, 2014 at 1:15 AM, Federico Vaga federico.v...@cern.ch wrote: So, It looks like that some BIOS disable the bridge when there is nothing behind it. Why? Power save? :/ Could be power savings, or possibly to conserve

[PATCH] ipoctal: request_irq after configuration

2014-07-03 Thread Federico Vaga
handler. Signed-off-by: Federico Vaga federico.v...@cern.ch --- drivers/ipack/devices/ipoctal.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c index a7ec6f9..72fd761 100644 --- a/drivers/ipack

PCIe bus enumeration

2014-07-03 Thread Federico Vaga
everything. bfsort : because, maybe, for a bfsort it must assign a number to each bridge at the same level before inspect the next one. noacpi : in order to scan independently from BIOS information The result is always the same (empty buses are not enumerated). Thank you :) -- Federico Vaga

Re: PCIe bus enumeration

2014-07-03 Thread Federico Vaga
(Sorry for double emailing, a sw update changes my configuration to HTML email as default.So, the linux kernel mailing list complains that probably I'm spamming) On Thursday 03 July 2014 13:43:14 Bjorn Helgaas wrote: On Thu, Jul 3, 2014 at 10:45 AM, Federico Vaga federico.v...@gmail.com wrote

Re: PCIe bus enumeration

2014-08-07 Thread Federico Vaga
On Tuesday 08 July 2014 14:27:00 Bjorn Helgaas wrote: On Tue, Jul 8, 2014 at 1:20 PM, Federico Vaga federico.v...@cern.ch wrote: On Tuesday 08 July 2014 12:23:39 Bjorn Helgaas wrote: On Tue, Jul 8, 2014 at 1:15 AM, Federico Vaga federico.v...@cern.ch wrote: So, It looks like

[PATCH] ipoctal: clear break interrupt as soon as it occurs

2014-09-01 Thread Federico Vaga
character '\0' is putted in the fifo we will manage it. We can also unmask the Break interrupt but its bit in ISR is still set on break. So I think is better to keep the registers clean. Signed-off-by: Federico Vaga federico.v...@cern.ch --- drivers/ipack/devices/ipoctal.c |4 +++- 1 file

IPACK - ipack and ipoctal improvements

2014-09-02 Thread Federico Vaga
I tested these patches only on kernel 3.2 and 3.6 because I cannot easly test them on the next branch. I think that there are not important modification in the kernel that can affect the behave of these patches. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH 2/3] ipack: save carrier owner to allow device to get it

2014-09-02 Thread Federico Vaga
There was not any kind of protection against carrier driver removal. In this way, device driver can 'get' the carrier driver when it is using it. Signed-off-by: Federico Vaga federico.v...@cern.ch --- drivers/ipack/carriers/tpci200.c |3 ++- drivers/ipack/ipack.c|4

[PATCH 1/3] ipoctal: reset function istead of duplicate code

2014-09-02 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@cern.ch --- drivers/ipack/devices/ipoctal.c | 35 ++- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c index 90b96a1b..e531379 100644

[PATCH 3/3] ipoctal: get carrier driver to avoid rmmod

2014-09-02 Thread Federico Vaga
Signed-off-by: Federico Vaga federico.v...@cern.ch --- drivers/ipack/devices/ipoctal.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c index e531379..035d544 100644

trace-cmd bug fixes

2017-04-23 Thread Federico Vaga
This set of patches contains some fixes found while studying the trace-cmd code.

[PATCH 4/5] trace-cmd: fix argument parsing minor BUG

2017-04-23 Thread Federico Vaga
arguments. The application will not report the correct invalid argument $ ./trace-cmd list -a list: invalid option -- 'i' Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- trace-cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace-cmd.c b/trace-cmd.c index 1

[PATCH 5/5] trace-cmd: BUG fix malloc() pointer validation

2017-04-23 Thread Federico Vaga
To reproduce the bug mkdir /sys/kernel/debug/tracing/instances/test ./trace-cmd show -B test -s -f Failed to allocate instance path snapshot Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- trace-cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace

[PATCH 2/5] plugin:python: check asprintf() errors

2017-04-23 Thread Federico Vaga
. Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- plugin_python.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/plugin_python.c b/plugin_python.c index d3da8b0..2997679 100644 --- a/plugin_python.c +++ b/plugin_python.c @@ -24,6 +24,7 @@ stat

[PATCH 3/5] trace-cmd:read: BUG initialize input_files item to zero

2017-04-23 Thread Federico Vaga
On allocation the data structure was not initialized. Later on some attribute of this structure are used (e.g. tsoffset) assuming that the default value is zero, but it is not always true. Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- trace-read.c | 1 + 1 file changed, 1 ins

[PATCH 1/5] plugin:python: fix compiler warning

2017-04-23 Thread Federico Vaga
The function `load_plugin` is passed, as argument, to `trace_util_load_plugins()` but the prototype was not exactly the same. Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- plugin_python.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/plugin_pyth

[PATCH V3 1/2] use direname instead of custom code

2017-08-02 Thread Federico Vaga
Prefer well known functions like `dirname(3)` instead of custom implementation for the same functionality Signed-off-by: Federico Vaga <federico.v...@vaga.pv.it> --- trace-record.c | 45 ++--- 1 file changed, 30 insertions(+), 15 deletions(-) diff

  1   2   3   4   5   >