Re: 3.19 on Nokia n900: audio quality awful

2015-01-26 Thread Peter Ujfalusi
On 01/18/2015 02:01 PM, Pavel Machek wrote: Hi! If you have any idea about playback problems, help would be still welcome. I'll have to do bisect, otherwise, and it will not be easy. In 3.18, sound is nice and clear. In 3.19, sound is unusable. It produces nasty tone when it should be

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-06 Thread Peter Ujfalusi
On 02/06/2015 08:32 PM, Peter Zijlstra wrote: On Fri, Feb 06, 2015 at 06:05:32PM +0200, Peter Ujfalusi wrote: Certainly looks much simpler, but it adds quite a bit of data to the omap_hwmod struct, and we have a _lot_ of them for omap2plus configuration. ls -al vmlinux w/o any the lockdep

Re: davinci-mcasp: extension to use AHCLKX pin as external clock source

2015-02-06 Thread Peter Ujfalusi
On 02/06/2015 11:22 AM, Urs Fässler wrote: The AHCLKX pin seems not to be supported as external source. The first patch is a general fix to allow external clock. The second allows you to select the AHCLKX pin as clock source. Patch built against v3.19-rc7 I don't think this series is

Re: [PATCH 2/2] davinci-mcasp: add option to use AHCLKX pin as clock in

2015-02-06 Thread Peter Ujfalusi
On 02/06/2015 11:22 AM, Urs Fässler wrote: Signed-off-by: Urs Fässler urs.fass...@bytesatwork.ch --- .../bindings/sound/davinci-mcasp-audio.txt | 1 + sound/soc/davinci/davinci-mcasp.c | 26 +++--- 2 files changed, 24 insertions(+), 3 deletions(-)

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-06 Thread Peter Ujfalusi
On 02/06/2015 04:13 PM, Peter Zijlstra wrote: On Fri, Feb 06, 2015 at 02:48:34PM +0200, Peter Ujfalusi wrote: Hi, In case when hwmods are used in nested way the lockdep validator will print out a warning message about possible deadlock situation: [4.514882

[PATCH 1/2] ARM: omap2+: omap_hwmod: Use _nested version of spinlock for oh-_lock

2015-02-06 Thread Peter Ujfalusi
select ATL clock as functional clock, which will trigger nested oh-_lock usage. This will trigger false warning from lockdep validator since it is dealing with classes and for it all hwmod clocks are the same class. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-omap2

[PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-06 Thread Peter Ujfalusi
subclass to those hwmods which could be used in nested way. Regards, Peter --- Peter Ujfalusi (2): ARM: omap2+: omap_hwmod: Use _nested version of spinlock for oh-_lock ARM: DRA7: hwmod_data: Change locked_class for atl hwmod arch/arm/mach-omap2/omap_hwmod.c | 16 arch

[PATCH 2/2] ARM: DRA7: hwmod_data: Change locked_class for atl hwmod

2015-02-06 Thread Peter Ujfalusi
The ATL hwmod can be used in nested way when it is selected to be the functional clock for McASP. For this lockdep validator will trigger false positive warning. By assigning separate class to atl locking will sort this out. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach

Re: davinci-mcasp: extension to use AHCLKX pin as external clock source

2015-02-12 Thread Peter Ujfalusi
On 02/10/2015 04:17 PM, Urs Fässler wrote: On 06.02.2015 12:50, Peter Ujfalusi wrote: On 02/06/2015 11:22 AM, Urs Fässler wrote: The AHCLKX pin seems not to be supported as external source. The first patch is a general fix to allow external clock. The second allows you to select the AHCLKX

Re: [PATCH] ASoC: omap-hdmi-audio: Add missing error check for devm_kzalloc

2015-02-12 Thread Peter Ujfalusi
On 02/12/2015 11:08 AM, Kiran Padwal wrote: This patch add a missing check on the return value of devm_kzalloc, which would cause a NULL pointer dereference in a OOM situation. Acked-by: Peter Ujfalusi peter.ujfal...@ti.com Signed-off-by: Kiran Padwal kiran.pad...@smartplayin.com

[PATCH 4/5] ARM: DTS: omap5: Correct the dma controller's property names

2015-02-20 Thread Peter Ujfalusi
According to the Documentation/devicetree/bindings/dma/dma.txt the dma-channels and dma-requests property should not have '#'. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm

[PATCH 1/5] ARM: DTS: omap2: Correct the dma controller's property names

2015-02-20 Thread Peter Ujfalusi
According to the Documentation/devicetree/bindings/dma/dma.txt the dma-channels and dma-requests property should not have '#'. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/boot/dts/omap2.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm

[PATCH 5/5] ARM: DTS: dra7: Correct the dma controller's property names

2015-02-20 Thread Peter Ujfalusi
According to the Documentation/devicetree/bindings/dma/dma.txt the dma-channels and dma-requests property should not have '#'. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/boot/dts/dra7.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot

[PATCH 3/5] ARM: DTS: omap4: Correct the dma controller's property names

2015-02-20 Thread Peter Ujfalusi
According to the Documentation/devicetree/bindings/dma/dma.txt the dma-channels and dma-requests property should not have '#'. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/boot/dts/omap4.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm

[PATCH 2/5] ARM: DTS: omap3: Correct the dma controller's property names

2015-02-20 Thread Peter Ujfalusi
According to the Documentation/devicetree/bindings/dma/dma.txt the dma-channels and dma-requests property should not have '#'. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/boot/dts/omap3.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm

[PATCH 0/5] ARM: DTS: OMAP/DRA7: dma property name correction

2015-02-20 Thread Peter Ujfalusi
are not in use at the moment, but it is going to be needed for the crossbar driver it is better to fix it right now so we do not need to patch .dtsi and .c files at the same time later. Tony: I would really appreciate if this could go in within the current merge window. Thanks, Peter Peter

Re: [PATCH] ASoC: rx51: do not fail if could not get jack detection gpio

2015-01-27 Thread Peter Ujfalusi
On 01/27/2015 03:32 PM, Pavel Machek wrote: On Tue 2015-01-27 15:27:58, Peter Ujfalusi wrote: Hi, On 01/26/2015 10:51 PM, Pali Rohár wrote: qemu does not emulate it Not sure about this... How does qemu emulate tlv320aic3106, tpa6130a2a, McBSP, sDMA for audio to work? What about the other

Re: 3.19 on Nokia n900: audio quality awful

2015-01-29 Thread Peter Ujfalusi
On 01/29/2015 09:35 AM, Jarkko Nikula wrote: On Wed, Jan 28, 2015 at 11:41:44PM +0100, Pavel Machek wrote: On Wed 2015-01-28 20:15:46, Jarkko Nikula wrote: On 01/26/2015 03:20 PM, Peter Ujfalusi wrote: On 01/18/2015 02:01 PM, Pavel Machek wrote: No need to go that far. N900 has been supported

Re: [PATCH 3/3] ARM: edma: Split up header file to platform_data and API file

2015-01-25 Thread Peter Ujfalusi
Hi, On 01/22/2015 03:40 AM, Olof Johansson wrote: Hi, On Thu, Nov 27, 2014 at 2:41 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: include/linux/platform_data/ is not a correct place to keep the API definitions for edma, it is meant to be only for the pdata for the device. Clean up

Re: [PATCH] ASoC: rx51: do not fail if could not get jack detection gpio

2015-01-27 Thread Peter Ujfalusi
Hi, On 01/26/2015 10:51 PM, Pali Rohár wrote: qemu does not emulate it Not sure about this... How does qemu emulate tlv320aic3106, tpa6130a2a, McBSP, sDMA for audio to work? What about the other three GPIOs in this machine driver? The nokia,n900-audio compatible mandates that the

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-09 Thread Peter Ujfalusi
On 02/06/2015 09:26 PM, Peter Ujfalusi wrote: Yeah, I've never really bothered with data too much, its a debug feature. So lock_class_key is 8 bytes, and strictly speaking you could union them over other fields, all we really need is unique addresses, we don't actually use the storage. True

[PATCH 1/7] ARM: davinci: devices-da8xx: Add resource name for the McASP DMA request

2015-02-10 Thread Peter Ujfalusi
Add tx or rx as resource name for the DMA resources. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/devices-da8xx.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c index

[PATCH 2/7] ARM: davinci: devices-da8xx: Add interrupt resource to McASP structs

2015-02-10 Thread Peter Ujfalusi
On da8xx McASP TX/RX interrupt requests are combined. The interrupt can be used for error recovery. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/devices-da8xx.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/mach-davinci/devices-da8xx.c

[PATCH 7/7] ARM: davinci: dm646x: Add interrupt resource for McASPs

2015-02-10 Thread Peter Ujfalusi
The interrupt can be used for error recovery. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/dm646x.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/mach-davinci/dm646x.c b/arch/arm/mach-davinci/dm646x.c index d2a2619aee81

[PATCH 6/7] ARM: davinci: irqs: Correct McASP1 TX interrupt definition for DM646x

2015-02-10 Thread Peter Ujfalusi
McASP1 TX interrupt is 30, not 32 on DM646x DMSoC Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/include/mach/irqs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-davinci/include/mach/irqs.h b/arch/arm/mach-davinci/include/mach

[PATCH 4/7] ARM: davinci: devices-da8xx: Add support for McASP2 on da830

2015-02-10 Thread Peter Ujfalusi
da830 has three McASP blocks. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/asp.h | 7 ++ arch/arm/mach-davinci/devices-da8xx.c | 41 +++ 2 files changed, 48 insertions(+) diff --git a/arch/arm/mach-davinci/asp.h b

[PATCHv2] ARM: omap2+: omap_hwmod: Set unique lock_class_key per hwmod

2015-02-10 Thread Peter Ujfalusi
...@infradead.org Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-omap2/omap_hwmod.c | 1 + arch/arm/mach-omap2/omap_hwmod.h | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 92afb723dcfc..2db380420b6f

[PATCH 5/7] ARM: davinci: dm646x: Clean up the McASP DMA resources

2015-02-10 Thread Peter Ujfalusi
Add names to the DMA resources and remove the RX DMA dummy part for McASP1. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/dm646x.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-davinci/dm646x.c b/arch/arm/mach

[PATCH 3/7] ARM: davinci: devices-da8xx: Clean up and correct the McASP device creation

2015-02-10 Thread Peter Ujfalusi
Both DA830 and DA850 has McASP0 module, so do not restrict the use of McASP0 for da850 only. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/devices-da8xx.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach

[PATCH 0/7] ARM: davinci: McASP related cleanups and fixes

2015-02-10 Thread Peter Ujfalusi
ASoC for da830, which have shared irq line for all it's McASP ip: http://mailman.alsa-project.org/pipermail/alsa-devel/2015-February/087322.html Regards, Peter --- Peter Ujfalusi (7): ARM: davinci: devices-da8xx: Add resource name for the McASP DMA request ARM: davinci: devices-da8xx: Add

Re: [PATCH] mfd: twl6040: match wait_for_completion_timeout return type

2015-03-16 Thread Peter Ujfalusi
On 03/16/2015 10:17 AM, Nicholas Mc Guire wrote: Return type of wait_for_completion_timeout is unsigned long not int. As time_left is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. Acked-by: Peter Ujfalusi peter.ujfal...@ti.com Signed-off

[PATCH 0/2] clk: ti: OMAP3: McBSP clock fixes

2015-03-16 Thread Peter Ujfalusi
a warning for these. In legacy mode we also have 2 hwmods for McBSP2/3. One for the McBSP itself and the other for the sidetone block attached to them. I'll try to look into this one next. Since this series fixes the _wait_target_ready issue, can this be sent for 4.0? Regards, Peter --- Peter Ujfalusi (2

Re: [PATCH v2 0/2] ARM: devicetree: Remove unused ti,codec property

2015-03-16 Thread Peter Ujfalusi
is hardcoded in ASoC driver). Please see reply [1] from Peter Ujfalusi. All: Acked-by: Peter Ujfalusi peter.ujfal...@ti.com Changes from v1: - keep ti,codec property in Documentation as optional that the existing dtbs do not become noncompliant after the change [1]: http

[PATCH 2/2] clk: ti: clk-3xxx-legacy: Correct McBSP related clock aliases

2015-03-16 Thread Peter Ujfalusi
: cannot be enabled for reset (3) Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/clk/ti/clk-3xxx-legacy.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/clk/ti/clk-3xxx-legacy.c b/drivers/clk/ti/clk-3xxx-legacy.c index e0732a4c8f26

[PATCH 1/2] clk: ti: clk-3xxx: Correct McBSP related DT clock definitions

2015-03-16 Thread Peter Ujfalusi
[0.307769] omap_hwmod: mcbsp2: cannot be enabled for reset (3) Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/clk/ti/clk-3xxx.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c index

Re: [PATCH 0/6] dmaengine/dra7x: DMA router (crossbar support)

2015-03-09 Thread Peter Ujfalusi
Hi, On 02/24/2015 04:21 PM, Peter Ujfalusi wrote: Hi, The series adds support for DMA router type of devices. They are used in SoCs which has more peripherals with DMA request lines than the DMA controller can handle. The router itself is not part of the DMA controller and it's operation

regmap: how to support devices with 'nested' pages

2015-03-10 Thread Peter Ujfalusi
Hi Mark, I got a device which registers are arranged in 'books' and pages: book0 page0 page1 ... page127 book1 page0 page1 ... page127 ... book255 page0 page1 ... page127 The pages can be selected via register0 of each page (in a standard way), however the book switching can only be

[RESEND 0/7] ARM: davinci: McASP related cleanups and fixes

2015-03-12 Thread Peter Ujfalusi
Hi, V1 was sent back in 10th of February [1], so resending it rebased on current linux-next. Clean up series of McASP device creation for da8xx and dm646x DMSoCs. [1] https://lkml.org/lkml/2015/2/10/298 Regards, Peter --- Peter Ujfalusi (7): ARM: davinci: devices-da8xx: Add resource name

[RESEND 2/7] ARM: davinci: devices-da8xx: Add interrupt resource to McASP structs

2015-03-12 Thread Peter Ujfalusi
On da8xx McASP TX/RX interrupt requests are combined. The interrupt can be used for error recovery. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/devices-da8xx.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/mach-davinci/devices-da8xx.c

[RESEND 3/7] ARM: davinci: devices-da8xx: Clean up and correct the McASP device creation

2015-03-12 Thread Peter Ujfalusi
Both DA830 and DA850 has McASP0 module, so do not restrict the use of McASP0 for da850 only. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/devices-da8xx.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach

[RESEND 5/7] ARM: davinci: dm646x: Clean up the McASP DMA resources

2015-03-12 Thread Peter Ujfalusi
Add names to the DMA resources and remove the RX DMA dummy part for McASP1. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/dm646x.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-davinci/dm646x.c b/arch/arm/mach

[RESEND 4/7] ARM: davinci: devices-da8xx: Add support for McASP2 on da830

2015-03-12 Thread Peter Ujfalusi
da830 has three McASP blocks. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/asp.h | 7 ++ arch/arm/mach-davinci/devices-da8xx.c | 41 +++ 2 files changed, 48 insertions(+) diff --git a/arch/arm/mach-davinci/asp.h b

[RESEND 6/7] ARM: davinci: irqs: Correct McASP1 TX interrupt definition for DM646x

2015-03-12 Thread Peter Ujfalusi
McASP1 TX interrupt is 30, not 32 on DM646x DMSoC Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/include/mach/irqs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-davinci/include/mach/irqs.h b/arch/arm/mach-davinci/include/mach

[RESEND 1/7] ARM: davinci: devices-da8xx: Add resource name for the McASP DMA request

2015-03-12 Thread Peter Ujfalusi
Add tx or rx as resource name for the DMA resources. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/devices-da8xx.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c index

[RESEND 7/7] ARM: davinci: dm646x: Add interrupt resource for McASPs

2015-03-12 Thread Peter Ujfalusi
The interrupt can be used for error recovery. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-davinci/dm646x.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/mach-davinci/dm646x.c b/arch/arm/mach-davinci/dm646x.c index d2a2619aee81

[PATCH v2 2/7] Documentation: devicetree: dma: Binding documentation for TI DMA crossbar

2015-03-11 Thread Peter Ujfalusi
The DRA7x has more peripherals with DMA requests than the sDMA can handle: 205 vs 127. All DMA requests are routed through the DMA crossbar, which can be configured to route selected incoming DMA requests to specific request line of the DMA controller. Signed-off-by: Peter Ujfalusi peter.ujfal

[PATCH v2 6/7] dmaengine: omap-dma: Remove mapping between virtual channels and requests

2015-03-11 Thread Peter Ujfalusi
channels with HW request lines will make it harder to implement MEM_TO_MEM mode for the driver. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c

[PATCH v2 7/7] ARM: DTS: dra7x: Integrate sDMA crossbar

2015-03-11 Thread Peter Ujfalusi
The sDMA requests are routed through the DMA crossbar and without the crossbar only peripherals using DMA request 0-127 can be used. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/boot/dts/dra7.dtsi | 57 ++--- 1 file changed, 33

[PATCH v2 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available

2015-03-11 Thread Peter Ujfalusi
Use the dma-requests property from DT to get the number of DMA requests. In case of legacy boot or failure to find the property, use the default 127 as number of requests. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 12 +++- 1 file changed, 11

[PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels and request count

2015-03-11 Thread Peter Ujfalusi
Instead of magic numbers in the code, use define for number of logical DMA channels and DMA requests. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma

[PATCH v2 1/7] dmaengine: of_dma: Support for DMA routers

2015-03-11 Thread Peter Ujfalusi
generic enough to be used in different environments. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- Documentation/devicetree/bindings/dma/dma.txt | 28 drivers/dma/dmaengine.c | 7 ++ drivers/dma/of-dma.c | 92

[PATCH v2 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-03-11 Thread Peter Ujfalusi
The DRA7x has more peripherals with DMA requests than the sDMA can handle: 205 vs 127. All DMA requests are routed through the DMA crossbar, which can be configured to route selected incoming DMA requests to specific sDMA request. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers

[PATCH v2 0/7] dmaengine/dra7x: DMA router (crossbar support)

2015-03-11 Thread Peter Ujfalusi
for his version of the crossbar driver: https://lkml.org/lkml/2014/3/7/199 This implementation is not tied to any DMA driver so it is possible to use the framework by other vendors, also ACPI version of binding can be easy enough to be added. Regards, Peter --- Peter Ujfalusi (7): dmaengine

Re: [PATCH 0/2] ARM: devicetree: Remove unused ti,codec property

2015-03-13 Thread Peter Ujfalusi
is hardcoded in ASoC driver). All: Acked-by: Peter Ujfalusi peter.ujfal...@ti.com Please see reply [1] from Peter Ujfalusi. [1]: http://comments.gmane.org/gmane.linux.ports.arm.omap/124273 Marek Belisko (2): ARM: dts: omap3: Remove all references to ti,codec property Documentation

Re: [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property

2015-03-13 Thread Peter Ujfalusi
On 03/13/2015 01:05 PM, Arnd Bergmann wrote: On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt index 1ab6bc8..656165f 100644 ---

Re: linux-next: Tree for Mar 11 (arm build failure, ASoC)

2015-03-12 Thread Peter Ujfalusi
Hi, On 03/11/2015 05:51 PM, Guenter Roeck wrote: On Wed, Mar 11, 2015 at 04:35:58PM +1100, Stephen Rothwell wrote: Hi all, Changes since 20150310: New tree: drm-exynos The sound-asoc tree still had its build failure so I used the version from next-20150306. The regulator tree lost its

Re: [PATCH] EDMA: TI: fixed memory leak when terminating running transfers

2015-03-24 Thread Peter Ujfalusi
On 03/23/2015 05:00 PM, Petr Kulhavy wrote: If edma_terminate_all() was called while a transfer was running (i.e. after edma_execute() but before edma_callback()) the echan-edesc was not freed. This was due to the fact that a running transfer is on none of the vchan lists: desc_submitted,

Re: [PATCH 2/2] EDMA: TI: fixed wrongly initialized data parameter to the edma callback

2015-03-24 Thread Peter Ujfalusi
this would cause troubles. Good catch. This seams to be in the code since the first commit ;) Acked-by: Peter Ujfalusi peter.ujfal...@ti.com Signed-off-by: Petr Kulhavy p...@barix.com --- drivers/dma/edma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma

Re: [PATCH v2 1/7] dmaengine: of_dma: Support for DMA routers

2015-03-26 Thread Peter Ujfalusi
On 03/26/2015 12:50 PM, Vinod Koul wrote: On Wed, Mar 11, 2015 at 03:23:24PM +0200, Peter Ujfalusi wrote: DMA routers are transparent devices used to mux DMA requests from peripherals to DMA controllers. They are used when the SoC integrates more devices with DMA requests then their controller

Re: [PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels and request count

2015-03-26 Thread Peter Ujfalusi
On 03/26/2015 12:57 PM, Vinod Koul wrote: On Wed, Mar 11, 2015 at 03:23:27PM +0200, Peter Ujfalusi wrote: Instead of magic numbers in the code, use define for number of logical DMA channels and DMA requests. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 7

Re: [PATCH v2 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-03-26 Thread Peter Ujfalusi
On 03/26/2015 12:56 PM, Vinod Koul wrote: +#define TI_XBAR_OUTPUTS 127 +#define TI_XBAR_INPUTS 256 Ideally this should be moved to DT. Will next revision of this chip always support these output and inputs? They are coming from DT. I'm using these as fall back values in case we can

Re: [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer

2015-03-28 Thread Peter Ujfalusi
Thanks, On 03/28/2015 05:57 AM, Stephen Warren wrote: On 03/27/2015 05:35 AM, Peter Ujfalusi wrote: The vd-node is removed from the lists when the transfer started so the vchan_get_all_descriptors() will not find it. This results memory leak. Acked-by: Stephen Warren swar...@wwwdotorg.org

Re: [PATCH v3 6/7] dmaengine: omap-dma: Remove mapping between virtual channels and requests

2015-03-31 Thread Peter Ujfalusi
On 03/27/2015 10:22 PM, Russell King - ARM Linux wrote: On Fri, Mar 27, 2015 at 02:26:52PM +0200, Peter Ujfalusi wrote: Do not direct map the virtual channels to sDMA request number. When the sDMA is behind of a crossbar this direct mapping can cause situations when certain channel can

Re: [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available

2015-03-31 Thread Peter Ujfalusi
On 03/27/2015 10:24 PM, Russell King - ARM Linux wrote: On Fri, Mar 27, 2015 at 02:26:51PM +0200, Peter Ujfalusi wrote: +if (!pdev-dev.of_node || of_property_read_u32(pdev-dev.of_node, + dma-requests

[PATCH 4/5] dmaengine: hsu: Fix memory leak when stopping a running transfer

2015-03-27 Thread Peter Ujfalusi
The vd-node is removed from the lists when the transfer started so the vchan_get_all_descriptors() will not find it. This results memory leak. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/hsu/hsu.c | 5 - 1 file

[PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers

2015-03-27 Thread Peter Ujfalusi
), where intense operations on the SD card wasted the device 128MB RAM within a couple of days. Peter Ujfalusi: The issue is even more severe since it affects cyclic (audio) transfers as well. In this case starting/stopping audio will results memory leak. Signed-off-by: Petr Kulhavy p...@barix.com

[PATCH 5/5] dmaengine: moxart-dma: Fix memory leak when stopping a running transfer

2015-03-27 Thread Peter Ujfalusi
The vd-node is removed from the lists when the transfer started so the vchan_get_all_descriptors() will not find it. This results memory leak. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Jonas Jensen jonas.jen...@gmail.com --- drivers/dma/moxart-dma.c | 4 +++- 1 file changed, 3

[PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer

2015-03-27 Thread Peter Ujfalusi
The vd-node is removed from the lists when the transfer started so the vchan_get_all_descriptors() will not find it. This results memory leak. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: Stephen Warren swar...@wwwdotorg.org CC: Lee Jones l...@kernel.org --- drivers/dma/bcm2835-dma.c

[PATCH 0/5] dmaengine: Fix memory leak amongs virt-dma users

2015-03-27 Thread Peter Ujfalusi
, sa11x0-dma, k3dma Others are already doing something to prevent the leak by either directly freeing the desc or by adding back the vdesc-node to a list. Regards, Peter --- Peter Ujfalusi (4): dmaengine: omap-dma: Fix memory leak when terminating running transfer dmaengine: bcm2835-dma: Fix

[PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer

2015-03-27 Thread Peter Ujfalusi
the framework will not going to do that for us. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com CC: sta...@vger.kernel.org CC: linux-o...@vger.kernel.org --- drivers/dma/omap-dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c index 1e646d6c8230

Re: [PATCH v2 1/7] dmaengine: of_dma: Support for DMA routers

2015-03-27 Thread Peter Ujfalusi
On 03/26/2015 05:32 PM, Vinod Koul wrote: I have added the DT binding document since this series adds support for routers for platforms booting with DT: Documentation/devicetree/bindings/dma/dma.txt | 28 I meant the update to Documnetation/dmanegine/ for routers :) I see. In what

[PATCH v3 0/7] dmaengine/dra7x: DMA router (crossbar support)

2015-03-27 Thread Peter Ujfalusi
driver so it is possible to use the framework by other vendors, also ACPI version of binding can be easy enough to be added. Regards, Peter --- Peter Ujfalusi (7): dmaengine: of_dma: Support for DMA routers Documentation: devicetree: dma: Binding documentation for TI DMA crossbar dmaengine

[PATCH v3 6/7] dmaengine: omap-dma: Remove mapping between virtual channels and requests

2015-03-27 Thread Peter Ujfalusi
channels with HW request lines will make it harder to implement MEM_TO_MEM mode for the driver. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c

[PATCH v3 2/7] Documentation: devicetree: dma: Binding documentation for TI DMA crossbar

2015-03-27 Thread Peter Ujfalusi
The DRA7x has more peripherals with DMA requests than the sDMA can handle: 205 vs 127. All DMA requests are routed through the DMA crossbar, which can be configured to route selected incoming DMA requests to specific request line of the DMA controller. Signed-off-by: Peter Ujfalusi peter.ujfal

[PATCH v3 4/7] dmaengine: omap-dma: Use defines for dma channels and request count

2015-03-27 Thread Peter Ujfalusi
Instead of magic numbers in the code, use define for number of logical DMA channels and DMA requests. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma

[PATCH v3 1/7] dmaengine: of_dma: Support for DMA routers

2015-03-27 Thread Peter Ujfalusi
generic enough to be used in different environments. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- Documentation/devicetree/bindings/dma/dma.txt | 28 drivers/dma/dmaengine.c | 7 ++ drivers/dma/of-dma.c | 92

[PATCH v3 7/7] ARM: DTS: dra7x: Integrate sDMA crossbar

2015-03-27 Thread Peter Ujfalusi
The sDMA requests are routed through the DMA crossbar and without the crossbar only peripherals using DMA request 0-127 can be used. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/boot/dts/dra7.dtsi | 57 ++--- 1 file changed, 33

[PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available

2015-03-27 Thread Peter Ujfalusi
Use the dma-requests property from DT to get the number of DMA requests. In case of legacy boot or failure to find the property, use the default 127 as number of requests. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 12 +++- 1 file changed, 11

[PATCH v3 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-03-27 Thread Peter Ujfalusi
The DRA7x has more peripherals with DMA requests than the sDMA can handle: 205 vs 127. All DMA requests are routed through the DMA crossbar, which can be configured to route selected incoming DMA requests to specific sDMA request. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers

Re: [PATCH v3 1/7] dmaengine: of_dma: Support for DMA routers

2015-03-31 Thread Peter Ujfalusi
On 03/28/2015 03:44 AM, Arnd Bergmann wrote: On Friday 27 March 2015, Peter Ujfalusi wrote: +Required property: +- dma-device: phandle of the DMA controller. The router is modifying + the DMA requests for this controller. This property seems rather specific

Re: [PATCH 2/6] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-03-01 Thread Peter Ujfalusi
On 02/28/2015 06:00 PM, Paul Bolle wrote: On Tue, 2015-02-24 at 16:21 +0200, Peter Ujfalusi wrote: The DRA7x has more peripherals with DMA requests than the sDMA can handle: 205 vs 127. All DMA requests are routed through the DMA crossbar, which can be configured to route selected incoming DMA

[PATCH 2/6] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-02-24 Thread Peter Ujfalusi
The DRA7x has more peripherals with DMA requests than the sDMA can handle: 205 vs 127. All DMA requests are routed through the DMA crossbar, which can be configured to route selected incoming DMA requests to specific sDMA request. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers

[PATCH 3/6] dmaengine: omap-dma: Use defines for dma channels and request count

2015-02-24 Thread Peter Ujfalusi
Instead of magic numbers in the code, use define for number of logical DMA channels and DMA requests. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma

[PATCH 0/6] dmaengine/dra7x: DMA router (crossbar support)

2015-02-24 Thread Peter Ujfalusi
to be added. The omap-dma part of changes are based on the dma property name change series: https://lkml.org/lkml/2015/2/20/182 but the code has fallback so it is working w/o the changes in that series. Regards, Peter --- Peter Ujfalusi (6): dmaengine: of_dma: Support for DMA routers dmaengine

[PATCH 1/6] dmaengine: of_dma: Support for DMA routers

2015-02-24 Thread Peter Ujfalusi
generic enough to be used in different environments. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- Documentation/devicetree/bindings/dma/dma.txt | 27 drivers/dma/dmaengine.c | 7 ++ drivers/dma/of-dma.c | 92

[PATCH 4/6] dmaengine: omap-dma: Take DMA request number from DT if it is available

2015-02-24 Thread Peter Ujfalusi
Use the dma-requests property from DT to get the number of DMA requests. In case of legacy boot or failure to find the property, use the default 127 as number of requests. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 11 ++- 1 file changed, 10

[PATCH 6/6] ARM: DTS: dra7x: Integrate sDMA crossbar

2015-02-24 Thread Peter Ujfalusi
The sDMA requests are routed through the DMA crossbar and without the crossbar only peripherals using DMA request 0-127 can be used. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/boot/dts/dra7.dtsi | 57 ++--- 1 file changed, 33

[PATCH 5/6] dmaengine: omap-dma: Remove mapping between virtual channels and requests

2015-02-24 Thread Peter Ujfalusi
channels with HW request lines will make it harder to implement MEM_TO_MEM mode for the driver. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c

Re: [PATCH 4/6] dmaengine: omap-dma: Take DMA request number from DT if it is available

2015-02-24 Thread Peter Ujfalusi
On 02/24/2015 04:25 PM, Russell King - ARM Linux wrote: On Tue, Feb 24, 2015 at 04:21:21PM +0200, Peter Ujfalusi wrote: Use the dma-requests property from DT to get the number of DMA requests. In case of legacy boot or failure to find the property, use the default 127 as number of requests

Re: [PATCH 5/6] dmaengine: omap-dma: Remove mapping between virtual channels and requests

2015-02-24 Thread Peter Ujfalusi
On 02/24/2015 04:28 PM, Russell King - ARM Linux wrote: On Tue, Feb 24, 2015 at 04:21:22PM +0200, Peter Ujfalusi wrote: Do not direct map the virtual channels to sDMA request number. When the sDMA is behind of a crossbar this direct mapping can cause situations when certain channel can

Re: 3.19 on Nokia n900: audio quality awful

2015-01-30 Thread Peter Ujfalusi
On 01/30/2015 02:40 PM, Peter Ujfalusi wrote: On 01/30/2015 12:37 PM, Pavel Machek wrote: Hi! I looked around the diff between 3.18 and 3.19, reverted these, and audio quality is back to reasonable level. Actually, reverting 368494093354ac613a80c2e1d77602aa12473cf0 seems enough. Any

Re: 3.19 on Nokia n900: audio quality awful

2015-01-30 Thread Peter Ujfalusi
On 01/30/2015 12:37 PM, Pavel Machek wrote: Hi! I looked around the diff between 3.18 and 3.19, reverted these, and audio quality is back to reasonable level. Actually, reverting 368494093354ac613a80c2e1d77602aa12473cf0 seems enough. Any quick patches to test? Or should we revert so

[PATCH] dmaengine: omap-dma: Add support for memcpy

2015-04-22 Thread Peter Ujfalusi
The sDMA controller is capable of performing memory copy operation. It need to be configured to software triggered mode and without HW synchronization. The sDMA can copy data which is aligned to 8, 16 or 32 bits. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/dma/omap-dma.c | 51

Re: [PATCH v5 0/8] dmaengine/dra7x: DMA router (crossbar support)

2015-04-22 Thread Peter Ujfalusi
On 04/09/2015 12:35 PM, Peter Ujfalusi wrote: Vinod: is it OK if I send the Documnetation/dmanegine/ update a bit later when I have finished it? Changes since v4: - Comments from Maxime Ripard addressed: - long line fixed in of-dma.c - node leaks has been fixed in ti-dma-crossbar

Re: [PATCH 2/3] dmaenegine: edma: allow pause/resume for non-cyclic mode

2015-04-27 Thread Peter Ujfalusi
, resulting in lost serial data. Acked-by: Peter Ujfalusi peter.ujfal...@ti.com Signed-off-by: John Ogness john.ogn...@linutronix.de --- drivers/dma/edma.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index bf09db7

Re: [PATCH 1/3] ARM: common: edma: clear completion interrupts on stop

2015-04-27 Thread Peter Ujfalusi
. By clearing the completion interrupt for the stopping channel it is ensured that no completion event will be generated after the stop. Acked-by: Peter Ujfalusi peter.ujfal...@ti.com Signed-off-by: John Ogness john.ogn...@linutronix.de --- arch/arm/common/edma.c |3 +++ 1 file changed

Re: [PATCH 13/19] clk: ti: Silence sparse warnings

2015-05-06 Thread Peter Ujfalusi
it be static? drivers/clk/ti/clk-dra7-atl.c:170:39: warning: Using plain integer as NULL pointer Cc: Peter Ujfalusi peter.ujfal...@ti.com Cc: Tero Kristo t-kri...@ti.com Signed-off-by: Stephen Boyd sb...@codeaurora.org Acked-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/clk/ti/clk

Re: [PATCH v5 3/8] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-05-07 Thread Peter Ujfalusi
On 05/04/2015 08:38 AM, Vinod Koul wrote: On Thu, Apr 09, 2015 at 12:35:49PM +0300, Peter Ujfalusi wrote: +int omap_dmaxbar_init(void) +{ +return platform_driver_register(ti_dma_xbar_driver); +} +arch_initcall(omap_dmaxbar_init); All looks fine except this bit, I think I did point out

Re: [PATCH v5 3/8] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-05-08 Thread Peter Ujfalusi
On 05/08/2015 06:41 AM, Vinod Koul wrote: Now as far as this series is concerned, rest of it looks good so I am willing to merge to if you plan to work on defered probe :) I think its a fair bargain! Deal ;) I'll take care of the OMAP/daVinci drivers for omap-dma and edma. -- Péter -- To

Re: [PATCH v5 3/8] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-05-08 Thread Peter Ujfalusi
On 05/08/2015 06:09 PM, Tony Lindgren wrote: * Vinod Koul vinod.k...@intel.com [150508 02:04]: On Fri, May 08, 2015 at 10:05:24AM +0300, Peter Ujfalusi wrote: On 05/08/2015 06:41 AM, Vinod Koul wrote: Now as far as this series is concerned, rest of it looks good so I am willing to merge

  1   2   3   4   5   6   7   8   9   10   >