Re: [PATCH] net: dsa/slave: Fix compilation warnings

2012-10-30 Thread Viresh Kumar
On 30 October 2012 01:29, Ben Hutchings bhutchi...@solarflare.com wrote: On Mon, 2012-10-29 at 22:27 +0530, Viresh Kumar wrote: Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and CONFIG_NET_DSA_TAG_TRAILER is defined, we get following compilation warnings: net/dsa

Re: [PATCH] net: dsa/slave: Fix compilation warnings

2012-10-30 Thread Viresh Kumar
On 30 October 2012 12:15, Viresh Kumar viresh.ku...@linaro.org wrote: And so, if we select NET_DSA from these tagging drivers, then only slave.c will get compiled. Otherwise slave.c dsa.c dsa_core.c wouldn't be compiled and so no warnings. If my above explanation/assumption is correct

Re: [PATCH] net: dsa/slave: Fix compilation warnings

2012-10-30 Thread Viresh Kumar
On 30 October 2012 13:23, Daniel Lezcano daniel.lezc...@linaro.org wrote: From: Viresh Kumar viresh.ku...@linaro.org config NET_DSA_TAG_DSA - bool + bool Original DSA packet tagging format + select NET_DSt typo NET_DSA Unbelievable mistake :( Will fix it after some reviews

Re: [PATCH] net: dsa/slave: Fix compilation warnings

2012-10-30 Thread Viresh Kumar
On 30 October 2012 14:30, Daniel Lezcano daniel.lezc...@linaro.org wrote: It is very curious if we disable all the configs option, a slave creation raise a BUG (cf. dsa_slave_create). IIUC, booting with NET_DSA enabled and none of the NET_DSA_TAG* enabled will raise a BUG in the probe

Re: [PATCH] net: dsa/slave: Fix compilation warnings

2012-10-30 Thread Viresh Kumar
On 30 October 2012 14:56, Daniel Lezcano daniel.lezc...@linaro.org wrote: Well, it is the same here, no ? Except, it is up to the user to disable the option. I didn't wanted to add code like this: + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA !NET_DSA_TAG_TRAILER) Why should we

Re: [PATCH 3/3] MAINTAINERS: add recently created files to dw_dmac section

2012-10-30 Thread viresh kumar
On Tue, Oct 30, 2012 at 6:02 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: The DesignWare DMAC driver is moved to an own directory. The patch updates MAINTAINERS file accordingly. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- MAINTAINERS |3 +-- 1

Re: [PATCH 0/3] dw_dmac: add PCI driver and move dw stuff to its own folder

2012-10-30 Thread viresh kumar
On Tue, Oct 30, 2012 at 6:02 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: This is split of the dw_dmac to support different platform devices with one core driver. It uses platform_driver model and weak link to the parent driver. The pros and cons are still under discussion here:

Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver

2012-10-30 Thread Viresh Kumar
On 30 October 2012 20:35, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Mon, 2012-10-08 at 18:57 +0530, Viresh Kumar wrote: I do agree, we must have as less routines in kernel namespace as possible. But not at the price of over complexity of stuff which isn't required. I didn't

Re: [PATCH V3 0/5] Fix thermal bugs and Upstream ST-Ericsson thermal driver

2012-10-30 Thread viresh kumar
On Tue, Oct 30, 2012 at 10:18 PM, hongbo.zhang hongbo.zh...@linaro.org wrote: From: hongbo.zhang hongbo.zh...@linaro.com V2-V3 Changes: 2. Update ST-Ericsson thermal driver due to review comments from Viresh Kumar and Francesco Lavra. You expect people, who want to know what has changed

Re: [PATCH V3 5/5] Thermal: Add ST-Ericsson DB8500 thermal properties and platform data.

2012-10-30 Thread viresh kumar
-off-by: hongbo.zhang hongbo.zh...@linaro.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org --- arch/arm/boot/dts/dbx5x0.dtsi | 14 + arch/arm/boot/dts/snowball.dts | 31 ++ arch/arm/configs/u8500_defconfig | 4 +++ arch/arm/mach-ux500/board-mop500.c

Re: [PATCH V3 4/5] Thermal: Add ST-Ericsson DB8500 thermal driver.

2012-10-30 Thread Viresh Kumar
-trip_points[i].cdev_name[j], tmp_str); want to check if it is copied or not?? + } + } + return ptrips; + +err_parse_dt: + dev_err(pdev-dev, Parsing device tree data error.\n); + return NULL; +} After these please add my: Reviewed-by: Viresh Kumar

Re: [PATCH V2 0/3] Create sched_select_cpu() and use it in workqueues

2012-10-31 Thread Viresh Kumar
On 15 October 2012 10:08, Viresh Kumar viresh.ku...@linaro.org wrote: I totally understand since last few weeks you guys were very busy as the merge window was around. So, didn't tried to disturb you then :) Can you please share your viewpoint on this patchset now? And also the running timer

[PATCH 0/3] Create sched_select_cpu() and use it in workqueues

2012-09-25 Thread Viresh Kumar
are tracked within the module and results are printed at the end. This gave similar results, with n ranging from 10 to 1000. Viresh Kumar (3): sched: Create sched_select_cpu() to give preferred CPU for power saving workqueue: create __flush_delayed_work to avoid duplicating code

[PATCH 2/3] workqueue: create __flush_delayed_work to avoid duplicating code

2012-09-25 Thread Viresh Kumar
flush_delayed_work() and flush_delayed_work_sync() had major portion of code similar. This patch introduces another routine __flush_delayed_work() which contains the common part to avoid code duplication. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- kernel/workqueue.c | 15

[PATCH 3/3] workqueue: Schedule work on non-idle cpu instead of current one

2012-09-25 Thread Viresh Kumar
CPU details from the scheduler, instead of using current CPU. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- arch/arm/Kconfig | 11 +++ kernel/workqueue.c | 25 ++--- 2 files changed, 29 insertions(+), 7 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm

[PATCH 1/3] sched: Create sched_select_cpu() to give preferred CPU for power saving

2012-09-25 Thread Viresh Kumar
through. If you want to go through all NUMA levels, pass -1 here. This should cover all NUMA levels. This patch reuses the code from get_nohz_timer_target() routine, which had similar implementation. get_nohz_timer_target() is also modified to use sched_select_cpu() now. Signed-off-by: Viresh Kumar

Re: [PATCH 0/3] Create sched_select_cpu() and use it in workqueues

2012-09-25 Thread Viresh Kumar
On 25 September 2012 16:06, Viresh Kumar viresh.ku...@linaro.org wrote: Test case 2: --- I have created a small module, which does following: - Create one work for each CPU (using queue_work_on(), so must schedule on that cpu) - Above work, will queue n works for each cpu

Re: [PATCH 3/3] workqueue: Schedule work on non-idle cpu instead of current one

2012-09-25 Thread Viresh Kumar
On 25 September 2012 16:52, Peter Zijlstra pet...@infradead.org wrote: On Tue, 2012-09-25 at 16:06 +0530, Viresh Kumar wrote: @@ -1066,8 +1076,9 @@ int queue_work(struct workqueue_struct *wq, struct work_struct *work) { int ret; - ret = queue_work_on(get_cpu(), wq, work

Re: [PATCHv3] dw_dmac: autoconfigure data_width or get it via platform data

2012-09-25 Thread viresh kumar
. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- Since v2: - sometimes memory-to-memory test is failed, that's why we need to choose minimum data portion between source and destination limits Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list

Re: [PATCHv1 5/6] MAINTAINERS: fix indentation for Viresh Kumar

2012-09-25 Thread viresh kumar
On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Viresh Kumar viresh.li...@gmail.com --- MAINTAINERS | 16 1 file changed, 8 insertions(+), 8 deletions(-) Acked

Re: [PATCHv1 6/6] MAINTAINERS: add recently created files to dw_dmac section

2012-09-25 Thread viresh kumar
--git a/MAINTAINERS b/MAINTAINERS [] @@ -6007,10 +6007,13 @@ F: drivers/tty/serial SYNOPSYS DESIGNWARE DMAC DRIVER M: Viresh Kumar viresh.li...@gmail.com +M: Andy Shevchenko andriy.shevche...@linux.intel.com S: Maintained F: include/linux/dw_dmac.h F: drivers/dma

Re: [PATCHv1 1/6] dmaengine: dw_dmac: Remove clk API dependency

2012-09-25 Thread viresh kumar
On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com Not all platforms support clk API. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Signed-off-by: Andy Shevchenko

Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-25 Thread viresh kumar
On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com This driver should be usable on all platforms that depend on clk API. This is not what you mentioned in subject :( Signed-off-by: Heikki Krogerus

Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-25 Thread viresh kumar
On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index df32537..e47cc90 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -89,6 +89,15 @@ config DW_DMAC Support the Synopsys

Re: [PATCHv1 3/6] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-25 Thread viresh kumar
On Tue, Sep 25, 2012 at 5:43 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: diff --git a/drivers/dma/dw_dmac_at32.c b/drivers/dma/dw_dmac_at32.c index 7bc7ac4..5c9180e 100644 --- a/drivers/dma/dw_dmac_at32.c +++ b/drivers/dma/dw_dmac_at32.c @@ -12,6 +12,7 @@ * it under the

Re: [PATCH 2/3] workqueue: create __flush_delayed_work to avoid duplicating code

2012-09-25 Thread Viresh Kumar
On 25 September 2012 23:17, Tejun Heo t...@kernel.org wrote: On Tue, Sep 25, 2012 at 04:06:07PM +0530, Viresh Kumar wrote: flush_delayed_work() and flush_delayed_work_sync() had major portion of code similar. This patch introduces another routine __flush_delayed_work() which contains

Re: [PATCHv1 2/6] dmaengine: dw_dmac: add driver for Atmel AT32

2012-09-26 Thread viresh kumar
93abe8e4b13ae9a0428ce940a8a03ac72a7626f1 Author: Viresh Kumar viresh.ku...@st.com Date: Mon Jul 30 14:39:27 2012 -0700 clk: add non CONFIG_HAVE_CLK routines Many drivers are shared between architectures that may or may not have HAVE_CLK selected for them. To remove compilation errors

[PATCH] MAINTAINERS: fix indentation for Viresh Kumar

2012-09-26 Thread Viresh Kumar
From: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org --- MAINTAINERS | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

Re: [PATCH 3/3] workqueue: Schedule work on non-idle cpu instead of current one

2012-09-26 Thread Viresh Kumar
On 25 September 2012 23:26, Tejun Heo t...@kernel.org wrote: On Tue, Sep 25, 2012 at 04:06:08PM +0530, Viresh Kumar wrote: +config MIGRATE_WQ + bool (EXPERIMENTAL) Migrate Workqueues to non-idle cpu + depends on SMP EXPERIMENTAL + help + Workqueues queues work on current

Re: [PATCHv2 1/4] dmaengine: dw_dmac: convert to platform driver

2012-09-26 Thread viresh kumar
On Wed, Sep 26, 2012 at 6:10 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com This driver could be used on different platforms. Thus, we converted it to be a platform driver. The HAVE_CLK dependency is dropped away as well.

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread viresh kumar
Forgot earlier, please keep spear-devel in cc... They will be going to use dw_dmac driver :) On Wed, Sep 26, 2012 at 6:10 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: diff --git a/drivers/dma/dw_dmac_pci.c b/drivers/dma/dw_dmac_pci.c +#include linux/module.h +#include

Re: [PATCHv2 4/4] MAINTAINERS: add recently created files to dw_dmac section

2012-09-26 Thread viresh kumar
..b87cbb1d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5999,10 +5999,10 @@ F: drivers/tty/serial SYNOPSYS DESIGNWARE DMAC DRIVER M: Viresh Kumar viresh.li...@gmail.com +M: Andy Shevchenko andriy.shevche...@linux.intel.com S: Maintained F: include/linux/dw_dmac.h -F

Re: [PATCHv2 4/4] MAINTAINERS: add recently created files to dw_dmac section

2012-09-26 Thread viresh kumar
On Wed, Sep 26, 2012 at 8:15 PM, viresh kumar viresh.ku...@linaro.org wrote: SYNOPSYS DESIGNWARE DMAC DRIVER M: Viresh Kumar viresh.li...@gmail.com +M: Andy Shevchenko andriy.shevche...@linux.intel.com S: Maintained F: include/linux/dw_dmac.h -F: drivers/dma

Re: [PATCHv2 3/4] dma: move dw_dmac driver to an own directory

2012-09-26 Thread viresh kumar
On Wed, Sep 26, 2012 at 6:10 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: The dw_dmac driver contains multiple files. To make a managment of them more convenient move it to an own directory. git format-patch has a option -C or -M or both... that makes such changes easier to

Re: [PATCHv2 1/4] dmaengine: dw_dmac: convert to platform driver

2012-09-26 Thread viresh kumar
On Wed, Sep 26, 2012 at 11:30 PM, Andy Shevchenko andy.shevche...@gmail.com wrote: On Wed, Sep 26, 2012 at 5:13 PM, viresh kumar viresh.ku...@linaro.org wrote: On Wed, Sep 26, 2012 at 6:10 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: From: Heikki Krogerus heikki.kroge

Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver

2012-09-26 Thread viresh kumar
On Thu, Sep 27, 2012 at 1:11 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 26 September 2012, Andy Shevchenko wrote: +#define DRIVER(_is_private, _chan_order, _chan_pri)\ + ((kernel_ulong_t)(struct dw_dma_platform_data) { \ + .is_private =

Re: [PATCHv3 7/7] MAINTAINERS: add recently created files to dw_dmac section

2012-09-27 Thread viresh kumar
changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7dfd0eb..b87cbb1d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5999,10 +5999,10 @@ F:drivers/tty/serial SYNOPSYS DESIGNWARE DMAC DRIVER M: Viresh Kumar viresh.li...@gmail.com +M: Andy Shevchenko

Re: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-09-27 Thread viresh kumar
On Thu, Sep 27, 2012 at 1:10 PM, Felipe Balbi ba...@ti.com wrote: diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c @@ -1700,6 +1700,7 @@ MODULE_DEVICE_TABLE(of, dw_dma_id_table); #endif static struct platform_driver dw_driver = { + .probe = dw_probe, probe's in

Re: [PATCHv3 2/7] dmaengine: dw_dmac: add module alias

2012-09-27 Thread viresh kumar
platform_driver dw_driver = { module_platform_driver(dw_driver); +MODULE_ALIAS(platform:dw_dmac); Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency

2012-09-27 Thread viresh kumar
: commit 93abe8e4b13ae9a0428ce940a8a03ac72a7626f1 Author: Viresh Kumar viresh.ku...@st.com Date: Mon Jul 30 14:39:27 2012 -0700 clk: add non CONFIG_HAVE_CLK routines @Andy: Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCHv3 4/7] dmaengine: dw_dmac: amend description and indentation

2012-09-27 Thread viresh kumar
On Thu, Sep 27, 2012 at 1:15 PM, Felipe Balbi ba...@ti.com wrote: On Thu, Sep 27, 2012 at 10:31:58AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com The driver will be used as a core part for various implementations of the DesignWare DMA device. The patch

Re: [PATCHv3 6/7] dma: move dw_dmac driver to an own directory

2012-09-27 Thread viresh kumar
On Thu, Sep 27, 2012 at 1:02 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: The dw_dmac driver contains multiple files. To make a managment of them more convenient move it to an own directory. Looks readable now :) Acked-by: Viresh Kumar viresh.ku...@linaro.org (After fixing

[PATCH V2 0/3] Create sched_select_cpu() and use it in workqueues

2012-09-27 Thread Viresh Kumar
, removed as it doesn't apply to latest workqueue branch from tejun. - CONFIG_MIGRATE_WQ removed and so is wq_select_cpu() - sched_select_cpu() called only from __queue_work() - got tejun/for-3.7 branch in my tree, before making workqueue changes. Viresh Kumar (3): sched: Create sched_select_cpu

[PATCH V2 3/3] workqueue: Schedule work on non-idle cpu instead of current one

2012-09-27 Thread Viresh Kumar
and is IDLE now. - CPU gets into interrupt handler due to timer and queues a work. As the CPU is currently IDLE, we can queue this work to some other CPU. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH V2 2/3] timer: hrtimer: Don't check idle_cpu() before calling get_nohz_timer_target()

2012-09-27 Thread Viresh Kumar
to idle_cpu() from timer and hrtimer. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- kernel/hrtimer.c | 2 +- kernel/timer.c | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c index 6db7a5e..74bdaf6 100644 --- a/kernel

[PATCH V2 1/3] sched: Create sched_select_cpu() to give preferred CPU for power saving

2012-09-27 Thread Viresh Kumar
only, SD_LOAD_BALANCE must also be set for selected domain. This patch reuses the code from get_nohz_timer_target() routine, which had similar implementation. get_nohz_timer_target() is also modified to use sched_select_cpu() now. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- include

Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver

2012-09-27 Thread viresh kumar
On Thu, Sep 27, 2012 at 3:31 PM, Vinod Koul vinod.k...@linux.intel.com wrote: Let me try again. what does it take to do platform and PCI driver for this: 1. make dma h/w access (read/write) platform independent. which you have already done 2. Device registration: Create two probes, or use

Re: [PATCH V2 2/3] timer: hrtimer: Don't check idle_cpu() before calling get_nohz_timer_target()

2012-09-27 Thread Viresh Kumar
On 27 September 2012 14:34, Viresh Kumar viresh.ku...@linaro.org wrote: #if defined(CONFIG_NO_HZ) defined(CONFIG_SMP) - if (!pinned get_sysctl_timer_migration() idle_cpu(cpu)) + if (!pinned get_sysctl_timer_migration()) cpu = get_nohz_timer_target(); #endif

Re: [PATCH V2 3/3] workqueue: Schedule work on non-idle cpu instead of current one

2012-09-28 Thread Viresh Kumar
On 27 September 2012 14:34, Viresh Kumar viresh.ku...@linaro.org wrote: Workqueues queues work on current cpu, if the caller haven't passed a preferred cpu. This may wake up an idle CPU, which is actually not required. This work can be processed by any CPU and so we must select a non-idle

[PATCH] timers: Avoid finding cpu for migration of running timers in __mod_timer()

2012-09-28 Thread Viresh Kumar
is currently running. This patch tries to avoid it in such cases. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- kernel/timer.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/kernel/timer.c b/kernel/timer.c index 8c5e7b9..6e5bf98 100644 --- a/kernel

Re: [RFC] timer: Migrate running timer

2012-10-03 Thread Viresh Kumar
On 28 September 2012 23:14, Viresh Kumar viresh.ku...@linaro.org wrote: I haven't tested it much till now. I am sending this patch just to check if the initial idea looks fine to you guys or not. Tested with: - ARM Vexpress TC2 - big.LITTLE CPU - Core 0-1: A15, 2-4: A7 - rootfs: linaro-ubuntu

Re: [RFC PATCH 04/10] sched: Introduce priority-based task migration filter

2012-10-03 Thread Viresh Kumar
On 22 September 2012 00:02, morten.rasmus...@arm.com wrote: Hi Morten, I would try to review your patches in coming days. For now, Just reporting a problem which i encountered during routine build. diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 490f1f0..8f0f3b9 100644 ---

Re: [RFC PATCH 02/10] sched: Task placement for heterogeneous systems based on task load-tracking

2012-10-04 Thread Viresh Kumar
Hi Morten, On 22 September 2012 00:02, morten.rasmus...@arm.com wrote: From: Morten Rasmussen morten.rasmus...@arm.com This patch introduces the basic SCHED_HMP infrastructure. Each class of cpus is represented by a hmp_domain and tasks will only be moved between these domains when their

Re: [RFC PATCH 03/10] sched: Forced task migration on heterogeneous systems

2012-10-04 Thread Viresh Kumar
Minor comments here :) On 22 September 2012 00:02, morten.rasmus...@arm.com wrote: diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d80de46..490f1f0 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3744,7 +3744,6 @@ int can_migrate_task(struct task_struct *p,

Re: [RFC PATCH 04/10] sched: Introduce priority-based task migration filter

2012-10-04 Thread Viresh Kumar
On 22 September 2012 00:02, morten.rasmus...@arm.com wrote: +config SCHED_HMP_PRIO_FILTER + bool (EXPERIMENTAL) Filter HMP migrations by task priority + depends on SCHED_HMP Should it depend on EXPERIMENTAL? + help + Enables task priority based HMP migration

Re: [RFC PATCH 06/10] ARM: sched: Use device-tree to provide fast/slow CPU list for HMP

2012-10-04 Thread Viresh Kumar
On 22 September 2012 00:02, morten.rasmus...@arm.com wrote: From: Morten Rasmussen morten.rasmus...@arm.com We can't rely on Kconfig options to set the fast and slow CPU lists for HMP scheduling if we want a single kernel binary to support multiple devices with different CPU topology. E.g.

Re: [RFC PATCH 07/10] ARM: sched: Setup SCHED_HMP domains

2012-10-04 Thread Viresh Kumar
On 22 September 2012 00:02, morten.rasmus...@arm.com wrote: diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c +void __init arch_get_hmp_domains(struct list_head *hmp_domains_list) +{ + struct cpumask hmp_fast_cpu_mask; + struct cpumask hmp_slow_cpu_mask; can

Re: [PATCH] ARM: Push selects for TWD/SCU into machine entries

2012-10-04 Thread viresh kumar
+14,8 @@ config ARCH_SPEAR13XX select CPU_V7 select USE_OF select HAVE_SMP + select HAVE_ARM_SCU if SMP + select HAVE_ARM_TWD if LOCAL_TIMERS select MIGHT_HAVE_CACHE_L2X0 select PINCTRL help For SPEAr: Acked-by: Viresh Kumar

Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver

2012-10-08 Thread Viresh Kumar
On 8 October 2012 15:47, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: This approach has the significant differences to proposed before. I am afraid i didn't get your mail completely. Still i will try based on my understanding. First of all it will export IP-block relevant functions

Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver

2012-10-08 Thread Viresh Kumar
On 8 October 2012 18:16, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Mon, 2012-10-08 at 16:19 +0530, Viresh Kumar wrote: First of all it will export IP-block relevant functions to the kernel namespace. I think it is not a good idea to pollute kernel more. So, few routines

Re: [PATCH] clk: spear: Add stub functions for spear3[0|1|2]0_clk_init()

2012-11-05 Thread viresh kumar
] Error 2 Signed-off-by: Axel Lin axel@ingics.com Thanks.. Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH V2 Resend 0/4] Create sched_select_cpu() and use it for workqueues and timers

2012-11-06 Thread Viresh Kumar
. - CONFIG_MIGRATE_WQ removed and so is wq_select_cpu() - sched_select_cpu() called only from __queue_work() - got tejun/for-3.7 branch in my tree, before making workqueue changes. Viresh Kumar (4): sched: Create sched_select_cpu() to give preferred CPU for power saving timer: hrtimer: Don't check

[PATCH V2 Resend 3/4] workqueue: Schedule work on non-idle cpu instead of current one

2012-11-06 Thread Viresh Kumar
and is IDLE now. - CPU gets into interrupt handler due to timer and queues a work. As the CPU is currently IDLE, we can queue this work to some other CPU. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- kernel/workqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V2 Resend 2/4] timer: hrtimer: Don't check idle_cpu() before calling get_nohz_timer_target()

2012-11-06 Thread Viresh Kumar
to idle_cpu() from timer and hrtimer. This also reduces an extra call to smp_processor_id() when get_nohz_timer_target() is called. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- kernel/hrtimer.c | 2 +- kernel/timer.c | 8 +--- 2 files changed, 6 insertions(+), 4 deletions(-) diff

[PATCH V2 Resend 1/4] sched: Create sched_select_cpu() to give preferred CPU for power saving

2012-11-06 Thread Viresh Kumar
only, SD_LOAD_BALANCE must also be set for selected domain. This patch reuses the code from get_nohz_timer_target() routine, which had similar implementation. get_nohz_timer_target() is also modified to use sched_select_cpu() now. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- include

[PATCH V2 Resend 4/4] timer: Migrate running timer

2012-11-06 Thread Viresh Kumar
in del_timer_sync(). We will clear this flag as soon as the timer is deleted, so that it can be started again after deleting it successfully. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- include/linux/timer.h | 2 ++ kernel/timer.c| 42 +- 2 files

Re: [PATCH Resend V2] dt: add helper function to read u8 u16 variables arrays

2012-11-06 Thread viresh kumar
is fixup for the doc comment missing: commit 00803aed0781de451048df0d15a3e8c814a343c8 Author: Viresh Kumar viresh.ku...@linaro.org Date: Wed Nov 7 09:48:46 2012 +0530 fixup! dt: add helper function to read u8 u16 variables arrays --- drivers/of/base.c | 3 +++ 1 file changed, 3 insertions

Re: [PATCH 2/5] gpiolib-of: staticize the pin range calls

2012-11-06 Thread viresh kumar
of_gpiochip_add_pin_range(struct gpio_chip *chip) {} +static void of_gpiochip_remove_pin_range(struct gpio_chip *chip) {} Maybe static inline?? Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 3/5] gpiolib: remove duplicate pin range code

2012-11-06 Thread viresh kumar
() and gpiochip_remove_pin_ranges(). But the contents are exactly the same so remove the OF one and rely on the range deletion in the core. Signed-off-by: Linus Walleij linus.wall...@linaro.org I can't believe that i did this :( Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list

Re: [PATCH 4/5] gpiolib: call pin removal in chip removal function

2012-11-06 Thread viresh kumar
linus.wall...@linaro.org Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[Query]: sched/fair: prio_changed_fair()

2012-11-06 Thread Viresh Kumar
Hi Ingo/Peter, I am trying to understand the complex scheduler code and just found something incorrect (maybe i am not reading it well): File: kernel/sched/fair.c static void prio_changed_fair(struct rq *rq, struct task_struct *p, int oldprio) { if (!p-se.on_rq) return;

Re: [Query]: sched/fair: prio_changed_fair()

2012-11-06 Thread Viresh Kumar
On 7 November 2012 13:26, Michael Wang wang...@linux.vnet.ibm.com wrote: It's the user nice value I suppose, so it should be reversed when we are talking about weight. Ahh.. I knew it .. How can i miss it. Sorry for the noise :( -- viresh -- To unsubscribe from this list: send the line

Re: [PATCH] mtd: map: Fix compilation warning

2012-11-07 Thread Viresh Kumar
On 29 October 2012 22:47, Viresh Kumar viresh.ku...@linaro.org wrote: This patch is an attempt to fix following compilation warning. In file included from drivers/mtd/chips/cfi_cmdset_0001.c:35:0: drivers/mtd/chips/cfi_cmdset_0001.c: In function 'cfi_intelext_write_words': include/linux/mtd

[PATCH] sched/fair: Set se-vruntime directly in place_entity()

2012-11-08 Thread Viresh Kumar
We are first storing the new vruntime in a variable and then storing it in se-vruntime. Simply update se-vruntime directly. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- kernel/sched/fair.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b

[PATCH 1/3] input: spear-keyboard: Use devm_*() routines

2012-11-08 Thread Viresh Kumar
This patch frees spear-keyboard driver from tension of freeing resources :) devm_* derivatives of multiple routines are used while allocating resources, which would be freed automatically by kernel. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/input/keyboard/spear-keyboard.c

[PATCH 3/3] input: spear-keyboard: Fix for balancing the enable_irq_wake

2012-11-08 Thread Viresh Kumar
-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/input/keyboard/spear-keyboard.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c index 9792924..b8784df 100644 --- a/drivers/input/keyboard

[PATCH 2/3] Input: spear-keyboard: Add clk_{un}prepare() support

2012-11-08 Thread Viresh Kumar
-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/input/keyboard/spear-keyboard.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c index 1d24fb2..9792924 100644 --- a/drivers/input

[PATCH 1/3] rtc: rtc-spear: Use devm_*() routines

2012-11-08 Thread Viresh Kumar
This patch frees rtc-spear driver from tension of freeing resources :) devm_* derivatives of multiple routines are used while allocating resources, which would be freed automatically by kernel. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/rtc/rtc-spear.c | 87

[PATCH 2/3] rtc: rtc-spear: Add clk_{un}prepare() support

2012-11-08 Thread Viresh Kumar
From: Deepak Sikri deepak.si...@st.com clk_{un}prepare is mandatory for platforms using common clock framework. Because for SPEAr we don't do anything in clk_{un}prepare() calls, just call them ones in probe/remove. Signed-off-by: Deepak Sikri deepak.si...@st.com Signed-off-by: Viresh Kumar

[PATCH 3/3] rtc: rtc-spear: Provide flag for no support of UIE mode

2012-11-08 Thread Viresh Kumar
From: Deepak Sikri deepak.si...@st.com The applciations can set the RTC hardware to trigger interrupts in one of three modes: * AIE: Alarm interrupt * UIE: Update interrupt (ie: once per second) * PIE: Periodic interrupt (sub-second irqs) The above defined 3 modes are to be supported

[PATCH 1/2] usb: spear-ehci/ohci: Do clk_get using dev-id

2012-11-08 Thread Viresh Kumar
From: Amardeep Rai amardeep.rai-...@st.com We used to get clk using con-id, but now we have device struct available for these devices as they are probed using DT. And so must get clk using dev-id. Signed-off-by: Amardeep Rai amardeep.rai-...@st.com Signed-off-by: Viresh Kumar viresh.ku

[PATCH 2/2] usb: spear-ehci/ohci: Use devm_*() routines

2012-11-08 Thread Viresh Kumar
This patch frees SPEAr ehci/ohci drivers from tension of freeing resources :) devm_* derivatives of multiple routines are used while allocating resources, which would be freed automatically by kernel. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/usb/host/ehci-spear.c | 37

[PATCH 1/2] mmc: sdhci-spear: Initialize sdhci clk to 50 MHz

2012-11-08 Thread Viresh Kumar
From: Vipul Kumar Samar vipulkumar.sa...@st.com SPEAr sdhci driver expects the clock to be set to 50 MHz for proper functioning. This patch sets clk to 50 MHz in probe. Signed-off-by: Vipul Kumar Samar vipulkumar.sa...@st.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/mmc

[PATCH 2/2] mmc: sdhci-spear: Don't call clk_{un}prepare() in suspend resume

2012-11-08 Thread Viresh Kumar
clk_{un}prepare is mandatory for platforms using common clock framework. Because for SPEAr we don't do anything in clk_{un}prepare() calls, just call them ones in probe/remove. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/mmc/host/sdhci-spear.c | 4 ++-- 1 file changed, 2

[PATCH] ata: pata_arasan: Initialize cf clock to 166MHz

2012-11-08 Thread Viresh Kumar
From: Vipul Kumar Samar vipulkumar.sa...@st.com PATA arasan driver expects the clock to be set to 166 MHz for proper functioning. This patch sets clk to 166 MHz in probe. Signed-off-by: Vipul Kumar Samar vipulkumar.sa...@st.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers

Re: [PATCH] pwm: add spear pwm driver support

2012-10-19 Thread Viresh Kumar
On 19 October 2012 11:29, Shiraz Hashim shiraz.has...@st.com wrote: + clk_disable_unprepare(pc-clk); call only disable from here. Leave it prepared for ever. and unprepare only in _remove. Okay. yes. I need to shut down all active pwms, how else would you suggest that ? I

Re: [PATCH] pwm: add spear pwm driver support

2012-10-19 Thread viresh kumar
On Fri, Oct 19, 2012 at 11:29 AM, Shiraz Hashim shiraz.has...@st.com wrote: On Thu, Oct 18, 2012 at 11:11:06PM +0530, viresh kumar wrote: On Thu, Oct 18, 2012 at 4:58 PM, Shiraz Hashim shiraz.has...@st.com wrote: +static int __devexit spear_pwm_remove(struct platform_device *pdev

Re: [PATCH] pwm: add spear pwm driver support

2012-10-19 Thread Viresh Kumar
On 19 October 2012 15:13, Shiraz Hashim shiraz.has...@st.com wrote: It may not be required as pwms which are not enabled do not have their clocks enabled. Hence, perhaps we can do following, 8--- static int spear_pwm_remove(struct platform_device *pdev) {

Re: [PATCH] pwm: add spear pwm driver support

2012-10-19 Thread Viresh Kumar
On 19 October 2012 15:31, Shiraz Hashim shiraz.has...@st.com wrote: On Fri, Oct 19, 2012 at 11:29:43AM +0530, Shiraz HASHIM wrote: On Thu, Oct 18, 2012 at 11:11:06PM +0530, viresh kumar wrote: On Thu, Oct 18, 2012 at 4:58 PM, Shiraz Hashim shiraz.has...@st.com wrote: + pc-mmio_base

Re: [PATCH V2] PWM: Add SPEAr PWM chip driver support

2012-10-19 Thread Viresh Kumar
On 19 October 2012 15:45, Shiraz Hashim shiraz.has...@st.com wrote: diff --git a/Documentation/devicetree/bindings/pwm/spear-pwm.txt b/Documentation/devicetree/bindings/pwm/spear-pwm.txt +pwm: pwm@a800 { +compatible =st,spear320-pwm; +reg = 0xa800

[PATCH 1/2] cpufreq: return early from __cpufreq_driver_getavg()

2012-10-19 Thread Viresh Kumar
There is no need to do cpufreq_get_cpu() and cpufreq_put_cpu() for drivers that don't support getavg() routine. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/cpufreq.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b

Re: [PATCH 1/2] cpufreq: return early from __cpufreq_driver_getavg()

2012-10-20 Thread Viresh Kumar
Re-sending, as it bounced from the lists :( When i reply to mail from my Samsung S2, it replies in HTML format. Don't know how to fix it :) On 20 October 2012 10:12, Viresh Kumar viresh.ku...@linaro.org wrote: On Oct 20, 2012 3:37 AM, Rafael J. Wysocki r...@sisk.pl wrote: On Saturday 20

Re: [PATCH V3] PWM: Add SPEAr PWM chip driver support

2012-10-21 Thread viresh kumar
race conditions, that might occur. + return pwmchip_remove(pc-chip); +} + After all this please add my: Acked-by: Viresh Kumar viresh.ku...@linaro.org Sorry Shiraz for so late comments, i can understand your frustration :( -- viresh -- To unsubscribe from this list: send the line

Re: [PATCH V3] PWM: Add SPEAr PWM chip driver support

2012-10-22 Thread Viresh Kumar
On 22 October 2012 11:36, Shiraz Hashim shiraz.has...@st.com wrote: On Mon, Oct 22, 2012 at 09:39:21AM +0530, viresh kumar wrote: On Mon, Oct 22, 2012 at 9:21 AM, Shiraz Hashim shiraz.has...@st.com wrote: +static int spear_pwm_remove(struct platform_device *pdev) +{ + struct

Re: [PATCH V3] PWM: Add SPEAr PWM chip driver support

2012-10-22 Thread Viresh Kumar
On 22 October 2012 13:25, Thierry Reding thierry.red...@avionic-design.de wrote: We could probably do that in the core. I've had some discussions about this with Lars-Peter (Cc'ed) who also had doubts about how this is currently handled. What you're proposing is different, however. If we put

Re: [PATCH 2/2] cpufreq: governors: remove redundant code

2012-10-22 Thread Viresh Kumar
On 20 October 2012 01:42, Viresh Kumar viresh.ku...@linaro.org wrote: Initially ondemand governor was written and then using its code conservative governor is written. It used a lot of code from ondemand governor, but copy of code was created instead of using the same routines from both

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-22 Thread Viresh Kumar
manual, present at following[1] location. 1. http://www.st.com/internet/mcu/product/251211.jsp Cc: Thierry Reding thierry.red...@avionic-design.de Signed-off-by: Shiraz Hashim shiraz.has...@st.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: Vipin Kumar vipin.ku...@st.com

Re: [PATCH 2/2] cpufreq: governors: remove redundant code

2012-10-24 Thread Viresh Kumar
On 22 October 2012 14:16, Viresh Kumar viresh.ku...@linaro.org wrote: On 20 October 2012 01:42, Viresh Kumar viresh.ku...@linaro.org wrote: Initially ondemand governor was written and then using its code conservative governor is written. It used a lot of code from ondemand governor, but copy

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-24 Thread Viresh Kumar
On 24 October 2012 11:21, Thierry Reding thierry.red...@avionic-design.de wrote: On Mon, Oct 22, 2012 at 04:36:41PM +0530, Shiraz Hashim wrote: + ret = pwmchip_add(pc-chip); + if (ret 0) { + dev_err(pdev-dev, pwmchip_add() failed: %d\n, ret); + return ret; +

Re: [PATCH V2 3/6] Thermal: fix bug of counting cpu frequencies.

2012-10-24 Thread Viresh Kumar
the index i cannot be referred as cpu frequencies number if there is CPUFREQ_ENTRY_INVALID case. Signed-off-by: hongbo.zhang hongbo.zh...@linaro.com Good one. Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

  1   2   3   4   5   6   7   8   9   10   >