Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-05-01 Thread NeilBrown
On Mon, May 01 2017, Jens Axboe wrote: > On 04/30/2017 11:00 PM, NeilBrown wrote: >> On Mon, Apr 24 2017, Christoph Hellwig wrote: >> >>> On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote: I was following the existing practice exemplified by bioset_create_nobvec(). >>> >>>

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-05-01 Thread NeilBrown
On Mon, May 01 2017, Jens Axboe wrote: > On 04/30/2017 11:00 PM, NeilBrown wrote: >> On Mon, Apr 24 2017, Christoph Hellwig wrote: >> >>> On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote: I was following the existing practice exemplified by bioset_create_nobvec(). >>> >>>

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-05-01 Thread Jens Axboe
On 04/30/2017 11:00 PM, NeilBrown wrote: > On Mon, Apr 24 2017, Christoph Hellwig wrote: > >> On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote: >>> >>> I was following the existing practice exemplified by >>> bioset_create_nobvec(). >> >> Which is pretty ugly to start with.. > > That is

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-05-01 Thread Jens Axboe
On 04/30/2017 11:00 PM, NeilBrown wrote: > On Mon, Apr 24 2017, Christoph Hellwig wrote: > >> On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote: >>> >>> I was following the existing practice exemplified by >>> bioset_create_nobvec(). >> >> Which is pretty ugly to start with.. > > That is

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-04-30 Thread NeilBrown
On Mon, Apr 24 2017, Christoph Hellwig wrote: > On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote: >> >> I was following the existing practice exemplified by >> bioset_create_nobvec(). > > Which is pretty ugly to start with.. That is a matter of personal taste. As such, it is up to the

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-04-30 Thread NeilBrown
On Mon, Apr 24 2017, Christoph Hellwig wrote: > On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote: >> >> I was following the existing practice exemplified by >> bioset_create_nobvec(). > > Which is pretty ugly to start with.. That is a matter of personal taste. As such, it is up to the

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-04-24 Thread Christoph Hellwig
On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote: > > I was following the existing practice exemplified by > bioset_create_nobvec(). Which is pretty ugly to start with.. > By not changing the signature of the function, I can avoid touching > quite a few places where it is called.

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-04-24 Thread Christoph Hellwig
On Mon, Apr 24, 2017 at 11:51:01AM +1000, NeilBrown wrote: > > I was following the existing practice exemplified by > bioset_create_nobvec(). Which is pretty ugly to start with.. > By not changing the signature of the function, I can avoid touching > quite a few places where it is called.

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-04-23 Thread NeilBrown
On Fri, Apr 21 2017, Christoph Hellwig wrote: > On Thu, Apr 20, 2017 at 03:38:48PM +1000, NeilBrown wrote: >> This patch converts bioset_create() and >> bioset_create_nobvec() to not create a workqueue so >> alloctions will never trigger punt_bios_to_rescuer(). It >> also introduces

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-04-23 Thread NeilBrown
On Fri, Apr 21 2017, Christoph Hellwig wrote: > On Thu, Apr 20, 2017 at 03:38:48PM +1000, NeilBrown wrote: >> This patch converts bioset_create() and >> bioset_create_nobvec() to not create a workqueue so >> alloctions will never trigger punt_bios_to_rescuer(). It >> also introduces

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-04-21 Thread Christoph Hellwig
On Thu, Apr 20, 2017 at 03:38:48PM +1000, NeilBrown wrote: > This patch converts bioset_create() and > bioset_create_nobvec() to not create a workqueue so > alloctions will never trigger punt_bios_to_rescuer(). It > also introduces bioset_create_rescued() and > bioset_create_nobvec_rescued()

Re: [PATCH 02/11] blk: make the bioset rescue_workqueue optional.

2017-04-21 Thread Christoph Hellwig
On Thu, Apr 20, 2017 at 03:38:48PM +1000, NeilBrown wrote: > This patch converts bioset_create() and > bioset_create_nobvec() to not create a workqueue so > alloctions will never trigger punt_bios_to_rescuer(). It > also introduces bioset_create_rescued() and > bioset_create_nobvec_rescued()