Re: serial console problems under 2.4.4/5
In article <[EMAIL PROTECTED]>, Narayan Desai <[EMAIL PROTECTED]> wrote: >> "Mike" == Miquel van Smoorenburg <[EMAIL PROTECTED]> writes: > >Mike> In article <[EMAIL PROTECTED]>, >Mike> Narayan Desai <[EMAIL PROTECTED]> wrote: >>> Hi. I have started having serial console problems in the last bunch >>> of kernel releases. I have tried various 2.4.4 and 2.4.5 ac kernels >>> (up to and including 2.4.5-ac4) and the problem has persisted. The >>> problem is basically that serial console doesn't recieve. > >Mike> The serial driver now pays attention to the CREAD bit. Sysvinit >Mike> clears it, so that's where it goes wrong. > >Mike> I don't think this change should have gone into a 'stable' >Mike> kernel version. 2.5.0 would have been fine, not 2.4.4 Okay it was 2.4.3 when it went in >How would I go about resetting this so that serial console worked >again? thanks... Fix sysvinit. Oh and all getty programs etc - everything that mucks around with termios. Alternatively revert the change to drivers/char/serial.c See also http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg42426.html Oh *ahem* I just read the entire thread again and I remembered it wrong. It's not the CREAD handling perse, it's something else that has changed that caused this, but it appears that a solution hasn't been found yet. Except for fixing all user-space programs. Sysvinit, agetty, busybox etc etc Okay so ignore my earlier comments. Sorry. Mike. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems under 2.4.4/5
> "Mike" == Miquel van Smoorenburg <[EMAIL PROTECTED]> writes: Mike> In article <[EMAIL PROTECTED]>, Mike> Narayan Desai <[EMAIL PROTECTED]> wrote: >> Hi. I have started having serial console problems in the last bunch >> of kernel releases. I have tried various 2.4.4 and 2.4.5 ac kernels >> (up to and including 2.4.5-ac4) and the problem has persisted. The >> problem is basically that serial console doesn't recieve. Mike> The serial driver now pays attention to the CREAD bit. Sysvinit Mike> clears it, so that's where it goes wrong. Mike> I don't think this change should have gone into a 'stable' Mike> kernel version. 2.5.0 would have been fine, not 2.4.4 How would I go about resetting this so that serial console worked again? thanks... -nld - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems under 2.4.4/5
In article <[EMAIL PROTECTED]>, Narayan Desai <[EMAIL PROTECTED]> wrote: >Hi. I have started having serial console problems in the last bunch of >kernel releases. I have tried various 2.4.4 and 2.4.5 ac kernels (up >to and including 2.4.5-ac4) and the problem has persisted. The problem >is basically that serial console doesn't recieve. The serial driver now pays attention to the CREAD bit. Sysvinit clears it, so that's where it goes wrong. I don't think this change should have gone into a 'stable' kernel version. 2.5.0 would have been fine, not 2.4.4 Mike. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems under 2.4.4/5
In article [EMAIL PROTECTED], Narayan Desai [EMAIL PROTECTED] wrote: Hi. I have started having serial console problems in the last bunch of kernel releases. I have tried various 2.4.4 and 2.4.5 ac kernels (up to and including 2.4.5-ac4) and the problem has persisted. The problem is basically that serial console doesn't recieve. The serial driver now pays attention to the CREAD bit. Sysvinit clears it, so that's where it goes wrong. I don't think this change should have gone into a 'stable' kernel version. 2.5.0 would have been fine, not 2.4.4 Mike. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems under 2.4.4/5
Mike == Miquel van Smoorenburg [EMAIL PROTECTED] writes: Mike In article [EMAIL PROTECTED], Mike Narayan Desai [EMAIL PROTECTED] wrote: Hi. I have started having serial console problems in the last bunch of kernel releases. I have tried various 2.4.4 and 2.4.5 ac kernels (up to and including 2.4.5-ac4) and the problem has persisted. The problem is basically that serial console doesn't recieve. Mike The serial driver now pays attention to the CREAD bit. Sysvinit Mike clears it, so that's where it goes wrong. Mike I don't think this change should have gone into a 'stable' Mike kernel version. 2.5.0 would have been fine, not 2.4.4 How would I go about resetting this so that serial console worked again? thanks... -nld - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems under 2.4.4/5
In article [EMAIL PROTECTED], Narayan Desai [EMAIL PROTECTED] wrote: Mike == Miquel van Smoorenburg [EMAIL PROTECTED] writes: Mike In article [EMAIL PROTECTED], Mike Narayan Desai [EMAIL PROTECTED] wrote: Hi. I have started having serial console problems in the last bunch of kernel releases. I have tried various 2.4.4 and 2.4.5 ac kernels (up to and including 2.4.5-ac4) and the problem has persisted. The problem is basically that serial console doesn't recieve. Mike The serial driver now pays attention to the CREAD bit. Sysvinit Mike clears it, so that's where it goes wrong. Mike I don't think this change should have gone into a 'stable' Mike kernel version. 2.5.0 would have been fine, not 2.4.4 Okay it was 2.4.3 when it went in How would I go about resetting this so that serial console worked again? thanks... Fix sysvinit. Oh and all getty programs etc - everything that mucks around with termios. Alternatively revert the change to drivers/char/serial.c See also http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg42426.html Oh *ahem* I just read the entire thread again and I remembered it wrong. It's not the CREAD handling perse, it's something else that has changed that caused this, but it appears that a solution hasn't been found yet. Except for fixing all user-space programs. Sysvinit, agetty, busybox etc etc Okay so ignore my earlier comments. Sorry. Mike. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems with 2.4.4
On 03 May 2001 02:15:03 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > > I get the impression that something in 2.4.3 fixed CREAD handling, and we > started noticing the buggy user space. That's my impression too... > > > I wish I knew where the breakage actually occured. > > > > Just look at this diff on serial.c between 2.4.2 and 2.4.3: > > If it was a real diff between 2.4.2 and 2.4.3 I would agree, however it looks > like your attempt to fix 2.4.3. Err... Yes sorry, in fact this was a workaround proposed by Kanoj, the maintener of serial.c (I think)... Regards. -- Fabrice Gautier <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems with 2.4.4
Fabrice Gautier <[EMAIL PROTECTED]> writes:
> On 02 May 2001 10:37:21 -0600
> [EMAIL PROTECTED] (Eric W. Biederman) wrote:
>
> > Fabrice Gautier <[EMAIL PROTECTED]> writes:
> > > So this this probably a sulogin/mingetty problem. They should set the
> > > CREAD flag in your tty c_cflag.
> > >
> > > the patch for busybox repalced the line
> > > tty.c_cflag |= HUPCL|CLOCAL
> > > by
> > > tty.c_cflag |= CREAD|HUPCL|CLOCAL
> > >
> > > Hope this help.
> >
> > This part is correct.
> >
> > However the kernel sets CREAD by default.
>
> Are your sure? Wasn't this the behaviour for 2.4.2 but changed in 2.4.3
init=/bin/bash works fine over a serial console in 2.4.4. So I am
certain.
I get the impression that something in 2.4.3 fixed CREAD handling, and we
started noticing the buggy user space.
> > sysvinit (and possibly other inits) clears CREAD.
>
> In my case I was using busybox as init. So there is no sysinit or any other
> init called before this line.
The busy box init is also clearing CREAD (as of 0.51 anyway).
> > I wish I knew where the breakage actually occured.
>
> Just look at this diff on serial.c between 2.4.2 and 2.4.3:
If it was a real diff between 2.4.2 and 2.4.3 I would agree, however it looks
like your attempt to fix 2.4.3.
Eric
> --- serial.c Sat Apr 21 17:22:53 2001
> +++ ../../../linux-2.4.2/drivers/char/serial.cSat Feb 17 01:02:36 2001
> @@ -1764,8 +1765,8 @@
> /*
>* !!! ignore all characters if CREAD is not set
>*/
> -// if ((cflag & CREAD) == 0)
> -// info->ignore_status_mask |= UART_LSR_DR;
> + if ((cflag & CREAD) == 0)
> + info->ignore_status_mask |= UART_LSR_DR;
> save_flags(flags); cli();
> if (uart_config[info->state->type].flags & UART_STARTECH) {
> serial_outp(info, UART_LCR, 0xBF);
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems with 2.4.4
Fabrice Gautier [EMAIL PROTECTED] writes:
On 02 May 2001 10:37:21 -0600
[EMAIL PROTECTED] (Eric W. Biederman) wrote:
Fabrice Gautier [EMAIL PROTECTED] writes:
So this this probably a sulogin/mingetty problem. They should set the
CREAD flag in your tty c_cflag.
the patch for busybox repalced the line
tty.c_cflag |= HUPCL|CLOCAL
by
tty.c_cflag |= CREAD|HUPCL|CLOCAL
Hope this help.
This part is correct.
However the kernel sets CREAD by default.
Are your sure? Wasn't this the behaviour for 2.4.2 but changed in 2.4.3
init=/bin/bash works fine over a serial console in 2.4.4. So I am
certain.
I get the impression that something in 2.4.3 fixed CREAD handling, and we
started noticing the buggy user space.
sysvinit (and possibly other inits) clears CREAD.
In my case I was using busybox as init. So there is no sysinit or any other
init called before this line.
The busy box init is also clearing CREAD (as of 0.51 anyway).
I wish I knew where the breakage actually occured.
Just look at this diff on serial.c between 2.4.2 and 2.4.3:
If it was a real diff between 2.4.2 and 2.4.3 I would agree, however it looks
like your attempt to fix 2.4.3.
Eric
--- serial.c Sat Apr 21 17:22:53 2001
+++ ../../../linux-2.4.2/drivers/char/serial.cSat Feb 17 01:02:36 2001
@@ -1764,8 +1765,8 @@
/*
* !!! ignore all characters if CREAD is not set
*/
-// if ((cflag CREAD) == 0)
-// info-ignore_status_mask |= UART_LSR_DR;
+ if ((cflag CREAD) == 0)
+ info-ignore_status_mask |= UART_LSR_DR;
save_flags(flags); cli();
if (uart_config[info-state-type].flags UART_STARTECH) {
serial_outp(info, UART_LCR, 0xBF);
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems with 2.4.4
On 03 May 2001 02:15:03 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: I get the impression that something in 2.4.3 fixed CREAD handling, and we started noticing the buggy user space. That's my impression too... I wish I knew where the breakage actually occured. Just look at this diff on serial.c between 2.4.2 and 2.4.3: If it was a real diff between 2.4.2 and 2.4.3 I would agree, however it looks like your attempt to fix 2.4.3. Err... Yes sorry, in fact this was a workaround proposed by Kanoj, the maintener of serial.c (I think)... Regards. -- Fabrice Gautier [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems with 2.4.4
On 02 May 2001 10:37:21 -0600
[EMAIL PROTECTED] (Eric W. Biederman) wrote:
> Fabrice Gautier <[EMAIL PROTECTED]> writes:
> > So this this probably a sulogin/mingetty problem. They should set the
> > CREAD flag in your tty c_cflag.
> >
> > the patch for busybox repalced the line
> > tty.c_cflag |= HUPCL|CLOCAL
> > by
> > tty.c_cflag |= CREAD|HUPCL|CLOCAL
> >
> > Hope this help.
>
> This part is correct.
>
> However the kernel sets CREAD by default.
Are your sure? Wasn't this the behaviour for 2.4.2 but changed in 2.4.3
> sysvinit (and possibly other inits) clears CREAD.
In my case I was using busybox as init. So there is no sysinit or any other
init called before this line.
> I wish I knew where the breakage actually occured.
Just look at this diff on serial.c between 2.4.2 and 2.4.3:
--- serial.cSat Apr 21 17:22:53 2001
+++ ../../../linux-2.4.2/drivers/char/serial.c Sat Feb 17 01:02:36 2001
@@ -1764,8 +1765,8 @@
/*
* !!! ignore all characters if CREAD is not set
*/
-// if ((cflag & CREAD) == 0)
-// info->ignore_status_mask |= UART_LSR_DR;
+ if ((cflag & CREAD) == 0)
+ info->ignore_status_mask |= UART_LSR_DR;
save_flags(flags); cli();
if (uart_config[info->state->type].flags & UART_STARTECH) {
serial_outp(info, UART_LCR, 0xBF);
--
Fabrice Gautier <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems with 2.4.4
Fabrice Gautier <[EMAIL PROTECTED]> writes: > On Wed, 02 May 2001 11:54:11 +0200 > Reto Baettig <[EMAIL PROTECTED]> wrote: > > > Hi > > > > I just installed 2.4.4 on our alpha SMP boxes (ES40) and now I have > > problems with the serial console: > > I get same kind of problem when upgrading from 2.4.2 to 2.4.3 and using > busybox as init/getty > > The problem was a bug in busybox. The console initialisation code was > not correct. > > > > sulogin does not accept input from the serial line > > mingetty does not accept input from the serial line > > agetty works fine > > So this this probably a sulogin/mingetty problem. They should set the > CREAD flag in your tty c_cflag. > > the patch for busybox repalced the line > tty.c_cflag |= HUPCL|CLOCAL > by > tty.c_cflag |= CREAD|HUPCL|CLOCAL > > Hope this help. This part is correct. However the kernel sets CREAD by default. sysvinit (and possibly other inits) clears CREAD. I wish I knew where the breakage actually occured. And then sulogin/mingetty need to reenable it. It's not too big of a deal except the serial code doesn't accept SAK's when CREAD is clear. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems with 2.4.4
On Wed, 02 May 2001 11:54:11 +0200 Reto Baettig <[EMAIL PROTECTED]> wrote: > Hi > > I just installed 2.4.4 on our alpha SMP boxes (ES40) and now I have > problems with the serial console: I get same kind of problem when upgrading from 2.4.2 to 2.4.3 and using busybox as init/getty The problem was a bug in busybox. The console initialisation code was not correct. > > sulogin does not accept input from the serial line > mingetty does not accept input from the serial line > agetty works fine So this this probably a sulogin/mingetty problem. They should set the CREAD flag in your tty c_cflag. the patch for busybox repalced the line tty.c_cflag |= HUPCL|CLOCAL by tty.c_cflag |= CREAD|HUPCL|CLOCAL Hope this help. -- Fabrice Gautier <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
serial console problems with 2.4.4
Hi I just installed 2.4.4 on our alpha SMP boxes (ES40) and now I have problems with the serial console: sulogin does not accept input from the serial line mingetty does not accept input from the serial line agetty works fine Everything works fine for the 2.4.2 kernel. I took the .config file from the 2.4.2 kernel to compile the 2.4.4 kernel. Any ideas? Reto - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems with 2.4.4
On 02 May 2001 10:37:21 -0600
[EMAIL PROTECTED] (Eric W. Biederman) wrote:
Fabrice Gautier [EMAIL PROTECTED] writes:
So this this probably a sulogin/mingetty problem. They should set the
CREAD flag in your tty c_cflag.
the patch for busybox repalced the line
tty.c_cflag |= HUPCL|CLOCAL
by
tty.c_cflag |= CREAD|HUPCL|CLOCAL
Hope this help.
This part is correct.
However the kernel sets CREAD by default.
Are your sure? Wasn't this the behaviour for 2.4.2 but changed in 2.4.3
sysvinit (and possibly other inits) clears CREAD.
In my case I was using busybox as init. So there is no sysinit or any other
init called before this line.
I wish I knew where the breakage actually occured.
Just look at this diff on serial.c between 2.4.2 and 2.4.3:
--- serial.cSat Apr 21 17:22:53 2001
+++ ../../../linux-2.4.2/drivers/char/serial.c Sat Feb 17 01:02:36 2001
@@ -1764,8 +1765,8 @@
/*
* !!! ignore all characters if CREAD is not set
*/
-// if ((cflag CREAD) == 0)
-// info-ignore_status_mask |= UART_LSR_DR;
+ if ((cflag CREAD) == 0)
+ info-ignore_status_mask |= UART_LSR_DR;
save_flags(flags); cli();
if (uart_config[info-state-type].flags UART_STARTECH) {
serial_outp(info, UART_LCR, 0xBF);
--
Fabrice Gautier [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
serial console problems with 2.4.4
Hi I just installed 2.4.4 on our alpha SMP boxes (ES40) and now I have problems with the serial console: sulogin does not accept input from the serial line mingetty does not accept input from the serial line agetty works fine Everything works fine for the 2.4.2 kernel. I took the .config file from the 2.4.2 kernel to compile the 2.4.4 kernel. Any ideas? Reto - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems with 2.4.4
Fabrice Gautier [EMAIL PROTECTED] writes: On Wed, 02 May 2001 11:54:11 +0200 Reto Baettig [EMAIL PROTECTED] wrote: Hi I just installed 2.4.4 on our alpha SMP boxes (ES40) and now I have problems with the serial console: I get same kind of problem when upgrading from 2.4.2 to 2.4.3 and using busybox as init/getty The problem was a bug in busybox. The console initialisation code was not correct. sulogin does not accept input from the serial line mingetty does not accept input from the serial line agetty works fine So this this probably a sulogin/mingetty problem. They should set the CREAD flag in your tty c_cflag. the patch for busybox repalced the line tty.c_cflag |= HUPCL|CLOCAL by tty.c_cflag |= CREAD|HUPCL|CLOCAL Hope this help. This part is correct. However the kernel sets CREAD by default. sysvinit (and possibly other inits) clears CREAD. I wish I knew where the breakage actually occured. And then sulogin/mingetty need to reenable it. It's not too big of a deal except the serial code doesn't accept SAK's when CREAD is clear. Eric - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: serial console problems with 2.4.4
On Wed, 02 May 2001 11:54:11 +0200 Reto Baettig [EMAIL PROTECTED] wrote: Hi I just installed 2.4.4 on our alpha SMP boxes (ES40) and now I have problems with the serial console: I get same kind of problem when upgrading from 2.4.2 to 2.4.3 and using busybox as init/getty The problem was a bug in busybox. The console initialisation code was not correct. sulogin does not accept input from the serial line mingetty does not accept input from the serial line agetty works fine So this this probably a sulogin/mingetty problem. They should set the CREAD flag in your tty c_cflag. the patch for busybox repalced the line tty.c_cflag |= HUPCL|CLOCAL by tty.c_cflag |= CREAD|HUPCL|CLOCAL Hope this help. -- Fabrice Gautier [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
