Re: [PATCH] [media] atmel_isi: allocate memory to store the isi platform data.

2012-08-30 Thread Josh Wu
Hi, all Sorry, My mistake here. After checking the code, this ISI bug doesn't exist in current mainline code. So I will *cancel* this patch. Since current mainline will copy this __initdata isi platform data to one static structure in function at91_add_device_isi(...). Then pass this static

[PATCH v2] media: v4l2-ctrls: add control for dpcm predictor

2012-08-30 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_DPCM_PREDICTOR control of type menu, which determines the dpcm predictor. The predictor can be either simple or advanced. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Cc: Sakari

Re: [PATCH RFC 0/4] V4L2: Vendor specific media bus formats/ frame size control

2012-08-30 Thread Nicolas THERY
Hello, Thanks for your reply. It's good to know your proposal is simply on the back-burner. Best regards, Nicolas On 2012-08-29 20:41, sakari.ai...@iki.fi wrote: Hi Nicolas, On Mon, Aug 27, 2012 at 05:48:43PM +0200, Nicolas THERY wrote: Hello, On 2012-08-23 11:51, Sylwester Nawrocki

Re: [PATCH RFC 0/4] V4L2: Vendor specific media bus formats/ frame size control

2012-08-30 Thread Nicolas THERY
Hello, Thanks for your reply. I overlooked this sensor packages multiple streams in a single DT. It seems indeed that Sakari's RFC would not help. Best regards, On 2012-08-29 23:51, Sylwester Nawrocki wrote: Hi Nicolas, On 08/27/2012 05:48 PM, Nicolas THERY wrote: Hello, On 2012-08-23

[PATCH 1/2] [media] ds3000: Remove useless 'locking'

2012-08-30 Thread Rémi Cardona
Since b9bf2eafaad9c1ef02fb3db38c74568be601a43a, the function ds3000_firmware_ondemand() is called only once during init. This locking scheme may have been useful when the firmware was loaded at each tune. Furthermore, it looks like this 'lock' was put in to prevent concurrent access (and not

[PATCH RFC 0/2] ds3000 firmware loading improvements

2012-08-30 Thread Rémi Cardona
Hi all, Please consider these 2 patches as an RFC, especially the first one. The first patch is something I've found while trying to wrap my head around the driver and I could find no legitimate reason to keep this lock since commit b9bf2ea, as dvb_frontend_init() is now only called in a single

[PATCH 2/2] [media] ds3000: properly report firmware loading issues

2012-08-30 Thread Rémi Cardona
ds3000_readreg() returns negative values in case of i2c failures. The old code would simply return 0 when failing to read the 0xb2 register, misleading ds3000_initfe() into believing that the firmware had been correctly loaded. Signed-off-by: Rémi Cardona remi.card...@smartjog.com ---

Re: [PATCH 2/2] [media] ds3000: properly report firmware loading issues

2012-08-30 Thread Antti Palosaari
On 08/30/2012 12:36 PM, Rémi Cardona wrote: ds3000_readreg() returns negative values in case of i2c failures. The old code would simply return 0 when failing to read the 0xb2 register, misleading ds3000_initfe() into believing that the firmware had been correctly loaded. Signed-off-by: Rémi

Re: [RFC v4] V4L DT bindings

2012-08-30 Thread Nicolas THERY
Hello, I've got a couple of questions regarding lane swapping and polarity inversion. On 2012-08-25 01:27, Guennadi Liakhovetski wrote: Hi all After an initial RFC [1] and taking into consideration an even earlier patch-set [2], Sylwester and I have spent some time discussing V4L DT

Re: [PATCH 2/2] [media] ds3000: properly report firmware loading issues

2012-08-30 Thread Rémi Cardona
Hi Antti, On 08/30/2012 03:39 PM, Antti Palosaari wrote: As I understand firmware downloading failure is coming from the fact that register read fails = fails to detect if firmware is already running or not. Well we actually see 2 cases: - the register read failure (when ds3000_readreg()

Re: [PATCH 2/2] [media] ds3000: properly report firmware loading issues

2012-08-30 Thread Antti Palosaari
On 08/30/2012 06:21 PM, Rémi Cardona wrote: Hi Antti, On 08/30/2012 03:39 PM, Antti Palosaari wrote: As I understand firmware downloading failure is coming from the fact that register read fails = fails to detect if firmware is already running or not. Well we actually see 2 cases: - the

[PATCHv3 3/9] ir-rx51: Trivial fixes

2012-08-30 Thread Timo Kokkonen
-Fix typo -Change pwm_timer_num type to match type in platform data -Remove extra parenthesis -Replace magic constant with proper bit defintions -Remove duplicate exit pointer Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi --- drivers/media/rc/Kconfig | 2 +-

[PATCHv3 1/9] ir-rx51: Adjust dependencies

2012-08-30 Thread Timo Kokkonen
Although this kind of IR diode circuitry is known to exist only in N900 hardware, nothing prevents making similar circuitry on any OMAP based board. The MACH_NOKIA_RX51 dependency is thus not something we want to be there. Also, this should depend on LIRC as it is a LIRC driver. Signed-off-by:

[PATCHv3 2/9] ir-rx51: Handle signals properly

2012-08-30 Thread Timo Kokkonen
The lirc-dev expects the ir-code to be transmitted when the write call returns back to the user space. We should not leave TX ongoing no matter what is the reason we return to the user space. Easiest solution for that is to simply remove interruptible sleeps. The first wait_event_interruptible is

[PATCHv3 7/9] ir-rx51: Convert latency constraints to PM QoS API

2012-08-30 Thread Timo Kokkonen
Convert the driver from the obsolete omap_pm_set_max_mpu_wakeup_lat API to the new PM QoS API. This allows the callback to be removed from the platform data structure. The latency requirements are also adjusted to prevent the MPU from going into sleep mode. This is needed as the GP timers have no

[PATCHv3 8/9] ir-rx51: Remove useless variable from struct lirc_rx51

2012-08-30 Thread Timo Kokkonen
As clearly visible from the patch, this variable has no useful purpose what so ever. Thus, it can be removed altogether without any side effects. Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi --- drivers/media/rc/ir-rx51.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff

[PATCHv3 9/9] ir-rx51: Add missing quote mark in Kconfig text

2012-08-30 Thread Timo Kokkonen
This trivial fix cures the following warning message: drivers/media/rc/Kconfig:275:warning: multi-line strings not supported Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi --- drivers/media/rc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCHv3 6/9] ir-rx51: Replace module_{init,exit} macros with module_platform_driver

2012-08-30 Thread Timo Kokkonen
No reason to avoid using the existing helpers. Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi --- drivers/media/rc/ir-rx51.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/media/rc/ir-rx51.c b/drivers/media/rc/ir-rx51.c index 16b3c1f..6e1ffa6 100644

Re: [PATCH v2] media: v4l2-ctrls: add control for dpcm predictor

2012-08-30 Thread Sakari Ailus
Hi Hans and Prabhakar, Hans Verkuil wrote: Hi Prabhakar! I've got some documentation review comments below... On Thu August 30 2012 00:58:16 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com add V4L2_CID_DPCM_PREDICTOR control of type menu, which determines the dpcm predictor.

[PATCHv3 5/9] ir-rx51: Move platform data checking into probe function

2012-08-30 Thread Timo Kokkonen
This driver is useless without proper platform data. If data is not available, we should not register the driver at all. Once this check is done, the BUG_ON check during device open is no longer needed. Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi --- drivers/media/rc/ir-rx51.c | 4 +++-

[PATCHv3 0/9] Fixes in response to review comments

2012-08-30 Thread Timo Kokkonen
These patches fix most of the issues pointed out in the patch review by Sean Young and Sakari Ailus. The most noticeable change after these patch set is that the IR transmission no longer times out even if the timers are not waking up the MPU as it should be. Now that Jean Pihet kindly instructed

[PATCHv3 4/9] ir-rx51: Clean up timer initialization code

2012-08-30 Thread Timo Kokkonen
Remove a redundant macro definition. This is unneeded and becomes more readable once the actual timer code is refactored a little. Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi --- drivers/media/rc/ir-rx51.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git

cron job: media_tree daily build: WARNINGS

2012-08-30 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu Aug 30 19:00:21 CEST 2012 git hash:79e8c7bebb467bbc3f2514d75bba669a3f354324 gcc version: i686-linux-gcc

Re: [PATCH 0/8] rc-core: patches for 3.7

2012-08-30 Thread Jarod Wilson
On Sat, Aug 25, 2012 at 11:46:47PM +0200, David Härdeman wrote: This is two minor winbond-cir fixes as well as the first six patches from my previous patchbomb. The latter have been modified so that backwards compatibility is retained as much as possible (the format of the sysfs files do not

Re: [RFC v4] V4L DT bindings

2012-08-30 Thread Sylwester Nawrocki
On 08/30/2012 05:19 PM, Nicolas THERY wrote: i2c0: i2c@0xfff2 { ... ov772x_1: ov772x@0x21 { compatible = omnivision,ov772x; reg =0x21; vddio-supply =regulator1;

V4L DT @ plumbers (was Re: [RFC v4] V4L DT bindings)

2012-08-30 Thread Guennadi Liakhovetski
Hi all Do we still want to try to organise a short discussion of this while at plumbers? Maybe tomorrow during or around lunch? Or any other time for that matter? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To

Re: V4L DT @ plumbers (was Re: [RFC v4] V4L DT bindings)

2012-08-30 Thread Laurent Pinchart
Hi Guennadi, On Thursday 30 August 2012 22:58:17 Guennadi Liakhovetski wrote: Hi all Do we still want to try to organise a short discussion of this while at plumbers? Maybe tomorrow during or around lunch? Or any other time for that matter? I'm certainly interested. I have a meeting

Re: V4L DT @ plumbers (was Re: [RFC v4] V4L DT bindings)

2012-08-30 Thread Guennadi Liakhovetski
On Fri, 31 Aug 2012, Laurent Pinchart wrote: Hi Guennadi, On Thursday 30 August 2012 22:58:17 Guennadi Liakhovetski wrote: Hi all Do we still want to try to organise a short discussion of this while at plumbers? Maybe tomorrow during or around lunch? Or any other time for that

Re: V4L DT @ plumbers (was Re: [RFC v4] V4L DT bindings)

2012-08-30 Thread Hans Verkuil
Fine by me! Hans Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 31 Aug 2012, Laurent Pinchart wrote: Hi Guennadi, On Thursday 30 August 2012 22:58:17 Guennadi Liakhovetski wrote: Hi all Do we still want to try to organise a short discussion of this while at