Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-27 Thread Prabhakar Lad
Hi, On Tue, Nov 27, 2012 at 1:21 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/27/2012 8:39 AM, Prabhakar Lad wrote: Hi Marek, On Tue, Nov 27, 2012 at 12:53 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/27/2012 6:59 AM, Prabhakar Lad wrote:

Re: [PATCH 01/15] [media] marvell-ccic: use internal variable replace global frame stats variable

2012-11-27 Thread Guennadi Liakhovetski
Hi Albert On Fri, 23 Nov 2012, Albert Wang wrote: From: Libin Yang lby...@marvell.com This patch replaces the global frame stats variables by using internal variables in mcam_camera structure. Signed-off-by: Albert Wang twan...@marvell.com Signed-off-by: Libin Yang lby...@marvell.com

Re: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
Hi Albert A general question first: is the MIPI CSI-2 implementation common to all ccic variants or specific to your SoC? On Fri, 23 Nov 2012, Albert Wang wrote: From: Libin Yang lby...@marvell.com This patch adds the MIPI support for marvell-ccic. Board driver should determine whether

Re: [PATCH 03/15] [media] marvell-ccic: add clock tree support for marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: From: Libin Yang lby...@marvell.com This patch adds the clock tree support for marvell-ccic. Each board may require different clk enabling sequence. Developer need add the clk_name in correct sequence in board driver to use this feature.

Re: [PATCH 04/15] [media] marvell-ccic: reset ccic phy when stop streaming for stability

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: From: Libin Yang lby...@marvell.com This patch adds the reset ccic phy operation when stop streaming. Without reset ccic phy, the next start streaming may be unstable. Also need add CCIC2 definition when PXA688/PXA2128 support dual ccics.

RE: [PATCH 01/15] [media] marvell-ccic: use internal variable replace global frame stats variable

2012-11-27 Thread Albert Wang
Hi, Guennadi Nice to hear you again after holidays. :) -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 18:16 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 01/15] [media]

Re: [PATCH 05/15] [media] marvell-ccic: refine mcam_set_contig_buffer function

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: From: Libin Yang lby...@marvell.com This patch refines mcam_set_contig_buffer() in mcam core Signed-off-by: Albert Wang twan...@marvell.com Signed-off-by: Libin Yang lby...@marvell.com Looks good in general, just will have to be tested on currently

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Albert Wang
Hi, Guennadi We will update the patch by following your good suggestion! :) -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 18:43 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH

RE: [PATCH 03/15] [media] marvell-ccic: add clock tree support for marvell-ccic driver

2012-11-27 Thread Albert Wang
Hi, Guennadi We will update it soon. -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 18:50 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 03/15] [media] marvell-ccic: add clock

Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-27 Thread Mauro Carvalho Chehab
Em Tue, 27 Nov 2012 14:55:10 +0530 Prabhakar Lad prabhakar.cse...@gmail.com escreveu: Hi, On Tue, Nov 27, 2012 at 1:21 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/27/2012 8:39 AM, Prabhakar Lad wrote: Hi Marek, On Tue, Nov 27, 2012 at 12:53 PM, Marek

RE: [PATCH 04/15] [media] marvell-ccic: reset ccic phy when stop streaming for stability

2012-11-27 Thread Albert Wang
Hi, Guennadi Thanks for your review! -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 18:57 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 04/15] [media] marvell-ccic: reset

RE: [PATCH 05/15] [media] marvell-ccic: refine mcam_set_contig_buffer function

2012-11-27 Thread Albert Wang
Hi, Guennadi -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 19:04 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 05/15] [media] marvell-ccic: refine mcam_set_contig_buffer

Re: [PATCH 06/15] [media] marvell-ccic: add new formats support for marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: From: Libin Yang lby...@marvell.com This patch adds the new formats support for marvell-ccic. Signed-off-by: Albert Wang twan...@marvell.com Signed-off-by: Libin Yang lby...@marvell.com --- drivers/media/platform/marvell-ccic/mcam-core.c | 178

Re: [PATCH 07/15] [media] marvell-ccic: add SOF / EOF pair check for marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: From: Libin Yang lby...@marvell.com This patch adds the SOFx/EOFx pair check for marvell-ccic. When switching format, the last EOF may not arrive when stop streamning. And the EOF will be detected in the next start streaming. Must ensure clear

Re: [PATCH 08/15] [media] marvell-ccic: switch to resource managed allocation and request

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, twan...@marvell.com wrote: From: Libin Yang lby...@marvell.com This patch switchs to resource managed allocation and request in mmp-driver. It can remove free resource operations. Signed-off-by: Albert Wang twan...@marvell.com Signed-off-by: Libin Yang

RE: [PATCH 06/15] [media] marvell-ccic: add new formats support for marvell-ccic driver

2012-11-27 Thread Albert Wang
Thanks Albert Wang 86-21-61092656 -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 19:45 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 06/15] [media] marvell-ccic: add new

RE: [PATCH 08/15] [media] marvell-ccic: switch to resource managed allocation and request

2012-11-27 Thread Albert Wang
Hi, Guennadi -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 20:00 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 08/15] [media] marvell-ccic: switch to resource managed

[PATCH] [media] exynos-gsc: modify number of output/capture buffers

2012-11-27 Thread Shaik Ameer Basha
G-Scaler src buffer count as well as destination buffer count is increased to 32. This is required for G-Scaler to interface with MFC, as MFC demands 32 capture buffers for some H264 streams. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com ---

RE: [PATCH 07/15] [media] marvell-ccic: add SOF / EOF pair check for marvell-ccic driver

2012-11-27 Thread Albert Wang
Hi, Guennadi -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 19:56 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 07/15] [media] marvell-ccic: add SOF / EOF pair check for

Re: [RFC v2 2/5] video: panel: Add DPI panel support

2012-11-27 Thread Tomi Valkeinen
Hi, On 2012-11-22 23:45, Laurent Pinchart wrote: +static void panel_dpi_release(struct display_entity *entity) +{ + struct panel_dpi *panel = to_panel_dpi(entity); + + kfree(panel); +} + +static int panel_dpi_remove(struct platform_device *pdev) +{ + struct panel_dpi *panel

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-11-27 Thread Fabio Estevam
Hi Guennadi/Javier, On Tue, Oct 30, 2012 at 12:57 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Fabio, I wasn't in favour of removing mx25 support initially and I still don't quite fancy it, but the delta is getting too large. If we remove it now you still have the git history, so,

Re: [PATCH] [media] exynos-gsc: propagate timestamps from src to dst buffers

2012-11-27 Thread Laurent Pinchart
Hi Sakari, On Sunday 25 November 2012 14:09:50 Sakari Ailus wrote: On Thu, Nov 22, 2012 at 10:44:22PM +0100, Sylwester Nawrocki wrote: the data will not be displayed before this time, secondary to the nominal frame rate determined by the current video standard in enqueued order.

Re: [RFC v2 1/5] video: Add generic display entity core

2012-11-27 Thread Tomi Valkeinen
Hi, On 2012-11-22 23:45, Laurent Pinchart wrote: +/** + * display_entity_get_modes - Get video modes supported by the display entity + * @entity The display entity + * @modes: Pointer to an array of modes + * + * Fill the modes argument with a pointer to an array of video modes. The array

Re: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts for soc_camera support

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: This patch splits mcam core into 2 parts to prepare for soc_camera support. The first part remains in mcam-core. This part includes the HW operations and vb2 callback functions. The second part is moved to mcam-core-standard.c. This part is relevant

Re: [PATCH v2] media: V4L2: add temporary clock helpers

2012-11-27 Thread Laurent Pinchart
Hello, On Sunday 25 November 2012 13:04:09 Sakari Ailus wrote: Sylwester Nawrocki wrote: On 11/14/2012 02:06 PM, Laurent Pinchart wrote: ... + +static DEFINE_MUTEX(clk_lock); +static LIST_HEAD(v4l2_clk); As Sylwester mentioned, what about s/v4l2_clk/v4l2_clks/ ? Don't you

Re: [PATCH 11/15] [media] marvell-ccic: add soc_camera support in mcam core

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, twan...@marvell.com wrote: From: Albert Wang twan...@marvell.com This patch adds the soc_camera support in mcam core. It creates the file mcam-core-soc.c and mcam-core-soc.h to support soc_camera in mcam core. To use the soc_camera feature, platform driver, such as

RE: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts for soc_camera support

2012-11-27 Thread Albert Wang
Hi, Guennadi -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 22:13 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts for

RE: [PATCH 11/15] [media] marvell-ccic: add soc_camera support in mcam core

2012-11-27 Thread Albert Wang
Hi, Guennadi Thanks a lot for your continuing support! :) -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 23:11 To: Albert Wang Cc: cor...@lwn.net; Linux Media Mailing List; Libin Yang Subject: Re: [PATCH 11/15] [media]

Re: [PATCH 12/15] [media] marvell-ccic: add soc_camera support in mmp driver

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: This patch adds the soc_camera support in the platform driver: mmp-driver.c. Specified board driver also should be modified to support soc_camera by passing some platform datas to platform driver. Currently the soc_camera mode in mmp driver only

Re: [PATCH 13/15] [media] marvell-ccic: add dma burst mode support in marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: This patch adds the dma burst size config support for marvell-ccic. Developer can set the dma burst size in specified board driver. Signed-off-by: Libin Yang lby...@marvell.com Signed-off-by: Albert Wang twan...@marvell.com ---

Re: [PATCH 14/15] [media] marvell-ccic: use unsigned int type replace int type

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: This patch use unsigned int type replace int type in marvell-ccic. These variables: frame number, buf number, irq... should be unsigned. Several issues to be considered here: * most these variables will never take values INT_MAX, so, this isn't

Re: [PATCH v1.2 1/4] v4l: Define video buffer flags for timestamp types

2012-11-27 Thread Laurent Pinchart
Hello, On Thursday 22 November 2012 01:59:00 Sakari Ailus wrote: On Wed, Nov 21, 2012 at 11:53:02PM +0100, Hans Verkuil wrote: On Wed November 21 2012 20:13:22 Sakari Ailus wrote: Define video buffer flags for different timestamp types. Everything up to now have used either realtime

RE: [PATCH 12/15] [media] marvell-ccic: add soc_camera support in mmp driver

2012-11-27 Thread Albert Wang
Hi, Guennadi -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 23:54 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 12/15] [media] marvell-ccic: add soc_camera support in mmp

RE: [PATCH 13/15] [media] marvell-ccic: add dma burst mode support in marvell-ccic driver

2012-11-27 Thread Albert Wang
Hi, Guennadi -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 23:56 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 13/15] [media] marvell-ccic: add dma burst mode support in

RE: [PATCH 14/15] [media] marvell-ccic: use unsigned int type replace int type

2012-11-27 Thread Albert Wang
Hi, Guennadi -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Wednesday, 28 November, 2012 00:02 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 14/15] [media] marvell-ccic: use unsigned int type replace

Re: [RFC] Selections targets at V4L2 video mem-to-mem interface

2012-11-27 Thread Laurent Pinchart
On Thursday 22 November 2012 14:25:18 Shaik Ameer Basha wrote: On Wed, Nov 7, 2012 at 3:52 AM, Sylwester Nawrocki wrote: Hi All, I'd like to clarify the meaning of selection targets on a mem-to-mem video device, in order to document it and to make sure new m2m drivers get it right, and

Re: [PATCH 15/15] [media] marvell-ccic: add 3 frame buffers support in DMA_CONTIG mode

2012-11-27 Thread Guennadi Liakhovetski
On Fri, 23 Nov 2012, Albert Wang wrote: This patch adds support of 3 frame buffers in DMA-contiguous mode. In current DMA_CONTIG mode, only 2 frame buffers can be supported. Actually, Marvell CCIC can support at most 3 frame buffers. Currently 2 frame buffers mode will be used by default.

Re: [yavta PATCH 0/2] Timestamp type support

2012-11-27 Thread Laurent Pinchart
Hi Sakari, On Friday 16 November 2012 00:09:33 Sakari Ailus wrote: Hi, This patchset adds timestamp type printing to yavta. Thank you for the patches. I'll apply them when timestamp type support will reach mainline (I will then update 1/2 with the mainline kernel headers). -- Regards,

Re: [yavta PATCH 2/2] Print v4l2_buffer timestamp type

2012-11-27 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Friday 16 November 2012 00:09:44 Sakari Ailus wrote: Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- yavta.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/yavta.c b/yavta.c index bf3e096..a50f11e 100644 ---

RE: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts for soc_camera support

2012-11-27 Thread Guennadi Liakhovetski
On Tue, 27 Nov 2012, Albert Wang wrote: [snip] you did change a couple of things - like replaced printk() with cam_err(), and actually here: + cam_err(cam, marvell-cam: Cafe can't do S/G I/O, \ + attempting vmalloc mode instead\n); and here +

RE: [PATCH 15/15] [media] marvell-ccic: add 3 frame buffers support in DMA_CONTIG mode

2012-11-27 Thread Albert Wang
Hi, Guennadi Thanks a lot for your review! :) -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Wednesday, 28 November, 2012 00:30 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: Re: [PATCH 15/15] [media]

Re: need help debugging ISP problem

2012-11-27 Thread Laurent Pinchart
Hi Adam, On Monday 05 November 2012 16:02:08 Adam Wozniak wrote: I'm working with a custom board based on an Overo WaterStorm com. The processor is a DM3730. The kernel is 2.6.32 based. 2.6.32 very probably means you're using the old TI driver. Please don't. That's buggy and totally

RE: [PATCH 11/15] [media] marvell-ccic: add soc_camera support in mcam core

2012-11-27 Thread Guennadi Liakhovetski
On Tue, 27 Nov 2012, Albert Wang wrote: [snip] +static int mcam_camera_set_fmt(struct soc_camera_device *icd, +struct v4l2_format *f) +{ +struct soc_camera_host *ici = to_soc_camera_host(icd-parent); +struct mcam_camera *mcam = ici-priv; +const struct

RE: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts for soc_camera support

2012-11-27 Thread Albert Wang
Hi, Guennadi -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Wednesday, 28 November, 2012 00:39 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: RE: [PATCH 10/15] [media] marvell-ccic: split mcam core into 2 parts

RE: [PATCH 11/15] [media] marvell-ccic: add soc_camera support in mcam core

2012-11-27 Thread Albert Wang
Thanks Albert Wang 86-21-61092656 -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Wednesday, 28 November, 2012 00:50 To: Albert Wang Cc: cor...@lwn.net; Linux Media Mailing List; Libin Yang Subject: RE: [PATCH 11/15] [media] marvell-ccic: add

Re: [PATCH 0/15] [media] marvell-ccic: add soc camera support on marvell-ccic

2012-11-27 Thread Guennadi Liakhovetski
Hi Laxman Just a general comment: this patch series is a huge improvement over the previous versions, now it is actually already reviewable! :-) Thanks for keeping on with this work! Best regards Guennadi On Fri, 23 Nov 2012, Albert Wang wrote: The following patches series will add soc

RE: [PATCH 0/15] [media] marvell-ccic: add soc camera support on marvell-ccic

2012-11-27 Thread Albert Wang
Hi, Geunnadi Thank you very much for your review! Your help is very valuable for us. We will work out the next version based on your suggestion! I hope to get back to you on the review of the version 3 patch series next week. :) Have a nice day! Thanks Albert Wang 86-21-61092656

[patch 1/2] [media] rc: unlock on error in show_protocols()

2012-11-27 Thread Dan Carpenter
We recently introduced a new return -ENODEV in this function but we need to unlock before returning. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 601d1ac1..d593bc6 100644 --- a/drivers/media/rc/rc-main.c +++

[patch 2/2] [media] rc: unlock on error in store_protocols()

2012-11-27 Thread Dan Carpenter
This error path is missing the unlock. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 601d1ac1..759a40a 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -890,7 +892,8 @@ static ssize_t

Re: linux-next: Tree for Nov 27 (media/v4l2-core/videobuf2-dma-contig.c)

2012-11-27 Thread Randy Dunlap
On 11/26/2012 10:25 PM, Stephen Rothwell wrote: Hi all, Changes since 20121126: on i386: drivers/media/v4l2-core/videobuf2-dma-contig.c:743:16: error: 'vb2_dc_get_dmabuf' undeclared here (not in a function) Full randconfig file is attached. -- ~Randy # # Automatically generated

cron job: media_tree daily build: ERRORS

2012-11-27 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Tue Nov 27 19:00:24 CET 2012 git hash:c6c22955f80f2db9614b01fe5a3d1cfcd8b3d848 gcc version: i686-linux-gcc

Re: [patch 1/2] [media] rc: unlock on error in show_protocols()

2012-11-27 Thread Douglas Bagnall
On 28/11/12 06:35, Dan Carpenter wrote: We recently introduced a new return -ENODEV in this function but we need to unlock before returning. There is an identical patch here (scroll down): https://patchwork.kernel.org/patch/1284081/ I'm not sure what happened to it. Douglas Signed-off-by:

[PATCH] [media] ngene: fix dvb_pll_attach failure

2012-11-27 Thread Patrice Chotard
Before dvb_pll_attch call, be sure that drxd demodulator was initialized, otherwise, dvb_pll_attach() will always failed. In dvb_pll_attach(), first thing done is to enable the I2C gate control in order to probe the pll by performing a read access. As demodulator was not initialized, every i2c

Re: Tuning problems with em28xx-dvb tda10071 on MIPS-based router board

2012-11-27 Thread Ingo Kofler
Thanks for the info. Then I'll try to fix it by myself and isolate the error by comparing the driver behavior on the PC and my router. I hope I can provide a patch for that afterwards. Are there any hints where I might look first. Since it only works for very few transponders I suppose the error

Re: Tuning problems with em28xx-dvb tda10071 on MIPS-based router board

2012-11-27 Thread Antti Palosaari
On 11/27/2012 10:38 PM, Ingo Kofler wrote: Thanks for the info. Then I'll try to fix it by myself and isolate the error by comparing the driver behavior on the PC and my router. I hope I can provide a patch for that afterwards. Are there any hints where I might look first. Since it only works

[yavta PATCH v1.1 2/2] Print v4l2_buffer timestamp type

2012-11-27 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Fixed. yavta.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/yavta.c b/yavta.c index bf3e096..b4d1df6 100644 --- a/yavta.c +++ b/yavta.c @@ -464,6 +464,7 @@ static int video_alloc_buffers(struct device

Re: [PATCH] v4l: Reset subdev v4l2_dev field to NULL if registration fails

2012-11-27 Thread Sylwester Nawrocki
Hi Laurent, On 11/25/2012 01:41 AM, Laurent Pinchart wrote: When subdev registration fails the subdev v4l2_dev field is left to a non-NULL value. Later calls to v4l2_device_unregister_subdev() will consider the subdev as registered and will module_put() the subdev module without any matching

Re: [PATCH v2 0/3] [media] exynos-gsc: Some fixes and updates

2012-11-27 Thread Sylwester Nawrocki
Hi Sachin, On 11/26/2012 07:20 AM, Sachin Kamat wrote: I have re-organised this series as per your suggestion and included your patch exynos-gsc: Correct clock handling. However, I have created 3 patches as I found making them into 2 a little cumbersome. Hope they look good. This series is

[patch 00/03 v2] driver for Masterkit MA901 usb radio

2012-11-27 Thread Alexey Klimov
Hi all, This is second version of small patch series for ma901 usb radio driver. Initial letter about this usb radio was sent on October 29 and can be found here: http://www.spinics.net/lists/linux-media/msg55779.html Changes: - removed f-type check and set in vidioc_g_frequency()

[patch 01/03 v2] media: add driver for Masterkit MA901 usb radio

2012-11-27 Thread Alexey Klimov
This patch creates a new usb-radio driver, radio-ma901.c, that supports Masterkit MA 901 USB FM radio devices. This device plugs into both the USB and an analog audio input or headphones, so this thing only deals with initialization and frequency setting. Signed-off-by: Alexey Klimov

[patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

2012-11-27 Thread Alexey Klimov
Don't let Masterkit MA901 USB radio be handled by usb hid drivers. This device will be handled by radio-ma901.c driver. Signed-off-by: Alexey Klimov klimov.li...@gmail.com diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 5de3bb3..8e06569 100644 --- a/drivers/hid/hid-core.c

[patch 03/03 v2] MAINTAINERS: add entry for radio-ma901 driver

2012-11-27 Thread Alexey Klimov
This patch adds MAINTAINERS entry for radio-ma901 usb radio driver. Signed-off-by: Alexey Klimov klimov.li...@gmail.com diff --git a/MAINTAINERS b/MAINTAINERS index b623679..a36b29c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4723,6 +4723,13 @@ Q:

Re: [PATCH 0/9] [media] s5p-tv: Checkpatch Fixes and cleanup

2012-11-27 Thread Sylwester Nawrocki
On 11/26/2012 05:48 AM, Sachin Kamat wrote: Build tested based on samsung/for_v3.8 branch of git://linuxtv.org/snawrocki/media.git tree. How about testing it on Origen board ? Tomasz, are you OK with this patch series ? As a side note, for v3.9, when common clock framework support for the

Re: linux-next: Tree for Nov 27 (media/v4l2-core/videobuf2-dma-contig.c)

2012-11-27 Thread Kyungmin Park
Hi, It's fixed already and you will check it at Nov 28 tree http://www.spinics.net/lists/linux-media/msg56830.html Thank you, Kyungmin Park On 11/28/12, Stephen Rothwell s...@canb.auug.org.au wrote: [Just adding some cc's] On Tue, 27 Nov 2012 10:32:15 -0800 Randy Dunlap rdun...@infradead.org

RE: [PATCH 03/15] [media] marvell-ccic: add clock tree support for marvell-ccic driver

2012-11-27 Thread Libin Yang
Hello Guennadi, Thanks for your suggestion, please see my comments below. Best Regards, Libin -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 18:50 To: Albert Wang Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang

em28xx: msi Digivox ATSC board id [0db0:8810]

2012-11-27 Thread Matthew Gyurgyik
Hi, I recently acquired a msi Digivox ATSC tuner. I believe this card has an em28xx chip (the windows driver included is em28xx). Looking at the em28xx wiki page and digging around in the code it does not seem like the em28xx driver has support for this card. Based on my limit (extremely)

anyone here know anyone at ivtvdriver.org? it's been down a few days now

2012-11-27 Thread Brian J. Murrell
I wonder if anyone here has control over or knows anyone who has control over the ivtvdriver.org website and lists. They seem to be down and have been for a bit now. Does anyone know if there is any expectation that this stuff will come back or is headed for moribund-land? Cheers, b.

ivtv driver inputs randomly block

2012-11-27 Thread Brian J. Murrell
I have a machine with a PVR-150 and a PVR-500 in it on a 3.2.0-33-generic (Ubuntu kernel, based on 3.2.1 IIUC) kernel. I am having problems where at random times random /dev/video[0,1,2] inputs will just block on read. It's not the same input every time and it's not even the same card every

Re: [PATCH 0/9] [media] s5p-tv: Checkpatch Fixes and cleanup

2012-11-27 Thread Sachin Kamat
On 28 November 2012 04:57, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 11/26/2012 05:48 AM, Sachin Kamat wrote: Build tested based on samsung/for_v3.8 branch of git://linuxtv.org/snawrocki/media.git tree. How about testing it on Origen board ? I wanted to but could not due to

Re: [PATCH v2 0/3] [media] exynos-gsc: Some fixes and updates

2012-11-27 Thread Sachin Kamat
Hi Sylwester, On 28 November 2012 04:41, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Sachin, On 11/26/2012 07:20 AM, Sachin Kamat wrote: I have re-organised this series as per your suggestion and included your patch exynos-gsc: Correct clock handling. However, I have created

Re: [PATCH 0/9] [media] s5p-tv: Checkpatch Fixes and cleanup

2012-11-27 Thread Sachin Kamat
Hi Sylwester, On 28 November 2012 09:04, Sachin Kamat sachin.ka...@linaro.org wrote: On 28 November 2012 04:57, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 11/26/2012 05:48 AM, Sachin Kamat wrote: Build tested based on samsung/for_v3.8 branch of

RE: [PATCH 12/15] [media] marvell-ccic: add soc_camera support in mmp driver

2012-11-27 Thread Libin Yang
Hello Guennadi, Please see my comments below. Regards, Libin -Original Message- From: Albert Wang Sent: Wednesday, November 28, 2012 12:06 AM To: Guennadi Liakhovetski Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: RE: [PATCH 12/15] [media] marvell-ccic: add

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Libin Yang
Hello Guennadi, Please see my comments below. Best Regards, Libin -Original Message- From: Albert Wang Sent: Tuesday, November 27, 2012 7:21 PM To: Guennadi Liakhovetski Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang Subject: RE: [PATCH 02/15] [media] marvell-ccic: add

RE: [PATCH 03/15] [media] marvell-ccic: add clock tree support for marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
Hi Libin On Tue, 27 Nov 2012, Libin Yang wrote: Hello Guennadi, Thanks for your suggestion, please see my comments below. Best Regards, Libin -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, 27 November, 2012 18:50 To: Albert

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
On Tue, 27 Nov 2012, Libin Yang wrote: Hello Guennadi, Please see my comments below. Best Regards, Libin -Original Message- From: Albert Wang Sent: Tuesday, November 27, 2012 7:21 PM To: Guennadi Liakhovetski Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Libin Yang
Hi Guennadi, -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Wednesday, November 28, 2012 3:14 PM To: Libin Yang Cc: Albert Wang; cor...@lwn.net; linux-media@vger.kernel.org Subject: RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Guennadi Liakhovetski
On Tue, 27 Nov 2012, Libin Yang wrote: Hi Guennadi, -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Wednesday, November 28, 2012 3:14 PM To: Libin Yang Cc: Albert Wang; cor...@lwn.net; linux-media@vger.kernel.org Subject: RE: [PATCH 02/15]

RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver

2012-11-27 Thread Libin Yang
Hi Guennadi, [snip] [Libin] Yes, you are right. We should consider the driver may be reused. I didn't realize it. Another question is: If we use devm_clk_get(), what I understand, the clk will be put when the device is being released. It means the driver will hold the clk all the time the