Re: [PATCH v6 03/17] media: rkisp1: Add user space ABI definitions

On Thu, Mar 8, 2018 at 6:48 PM Jacob Chen wrote: [snip] > +/** > + * struct cifisp_lsc_config - Configuration used by Lens shading correction > + * > + * refer to REF_01 for details > + */ > +struct cifisp_lsc_config { > + __u32 r_data_tbl[CIFISP_LSC_DATA_TBL_SIZE]; >

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Apr 24 05:00:12 CEST 2018 media-tree git hash:a2b2eff6ac2716f499defa590a6ec4ba379d765e media_build

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, On Monday, 16 April 2018 00:26:06 EEST Niklas Söderlund wrote: > Hi Laurent, > > Thanks for your feedback. > > I have addressed all your comment's but one for the next version. Please > indicate if you are fine with this and I can still keep your review tag > > :-) > > On

Re: [PATCH 8/8] drm: connector: Remove DRM_BUS_FLAG_DATA_* flags

Hi Jacopo, Thank you for the patch. On Thursday, 19 April 2018 12:31:09 EEST Jacopo Mondi wrote: > DRM_BUS_FLAG_DATA_* flags, defined in drm_connector.h header file are > used to swap ordering of LVDS RGB format to accommodate DRM objects > that need to handle LVDS components ordering. > > Now

Re: [PATCH v3][RESEND] media: i2c: tda1997: replace codec to component

On Mon, Apr 23, 2018 at 9:52 AM, Mark Brown wrote: > On Mon, Apr 23, 2018 at 09:44:17AM -0700, Tim Harvey wrote: > >> Could you add some detail to the commit explaining why we need to >> replace codec to component? I don't really know what that means. >> Please refer to a

Re: [PATCH v3 02/11] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

Hi Wolfram, On Monday, 23 April 2018 23:36:16 EEST Wolfram Sang wrote: > > SCCB helpers would work too. It would be easy to just move the functions > > defined in this patch to helpers and be done with it. However, there are > > I2C adapters that have native SCCB support, so to take advantage of

Re: How to proceed ? => [PATCH ?] EM28xx driver ?

Em Mon, 23 Apr 2018 22:21:29 +0200 mjs escreveu: > Op Mon, 23 Apr 2018 14:15:59 -0300 > Mauro Carvalho Chehab schreef: > > > Em Mon, 23 Apr 2018 12:35:06 -0400 > > Alexandre-Xavier Labonté-Lamoureux escreveu: > > > >

Re: [PATCH v3 02/11] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

> SCCB helpers would work too. It would be easy to just move the functions > defined in this patch to helpers and be done with it. However, there are I2C > adapters that have native SCCB support, so to take advantage of that feature Ah, didn't notice that so far. Can't find it in

Re: [PATCH 4/7] media: ipu3: allow building it with COMPILE_TEST on non-x86 archs

On Fri, Apr 20, 2018 at 01:42:50PM -0400, Mauro Carvalho Chehab wrote: > Despite depending on ACPI, this driver builds fine on non-x86 > archtecture with COMPILE_TEST, as it doesn't depend on > ACPI-specific functions/structs. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

On Monday, 23 April 2018 23:09:55 EEST Mauro Carvalho Chehab wrote: > Laurent Pinchart escreveu: > > On Monday, 23 April 2018 17:22:27 EEST Mauro Carvalho Chehab wrote: > > > Em Mon, 23 Apr 2018 15:56:53 +0200 Bartlomiej Zolnierkiewicz escreveu: > > > > On

Re: How to proceed ? => [PATCH ?] EM28xx driver ?

Op Mon, 23 Apr 2018 14:15:59 -0300 Mauro Carvalho Chehab schreef: > Em Mon, 23 Apr 2018 12:35:06 -0400 > Alexandre-Xavier Labonté-Lamoureux escreveu: > > > This should give you an idea of what you need to do: > >

Re: [PATCH v3 02/11] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

Hi Wolfram, On Monday, 23 April 2018 23:11:21 EEST Wolfram Sang wrote: > > How about i2c_smbus_xfer_emulated() ? The tricky part will be to handle > > the I2C adapters that implement .smbus_xfer(), as those won't go through > > i2c_smbus_xfer_emulated(). i2c_smbus_xfer_emulated() relies on > >

Re: [PATCH v3 02/11] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

> How about i2c_smbus_xfer_emulated() ? The tricky part will be to handle the > I2C adapters that implement .smbus_xfer(), as those won't go through > i2c_smbus_xfer_emulated(). i2c_smbus_xfer_emulated() relies on > i2c_transfer(), > which itself relies on the I2C adapter's .master_xfer()

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

Em Mon, 23 Apr 2018 22:48:06 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Monday, 23 April 2018 17:22:27 EEST Mauro Carvalho Chehab wrote: > > Em Mon, 23 Apr 2018 15:56:53 +0200 Bartlomiej Zolnierkiewicz escreveu: > > > On Monday, April 23, 2018

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

Hi Mauro, On Monday, 23 April 2018 17:22:27 EEST Mauro Carvalho Chehab wrote: > Em Mon, 23 Apr 2018 15:56:53 +0200 Bartlomiej Zolnierkiewicz escreveu: > > On Monday, April 23, 2018 02:47:28 PM Bartlomiej Zolnierkiewicz wrote: > >> On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote:

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

On 04/23/2018 02:17 PM, Mauro Carvalho Chehab wrote: Em Mon, 23 Apr 2018 14:11:02 -0500 "Gustavo A. R. Silva" escreveu: On 04/23/2018 01:24 PM, Mauro Carvalho Chehab wrote: Em Mon, 23 Apr 2018 12:38:03 -0500 "Gustavo A. R. Silva" escreveu:

Re: [PATCH v3 02/11] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

Hi Mita-san, (CC'ing Wolfram Sang) On Monday, 23 April 2018 18:55:20 EEST Akinobu Mita wrote: > 2018-04-23 18:18 GMT+09:00 Laurent Pinchart: > > On Sunday, 22 April 2018 18:56:08 EEST Akinobu Mita wrote: > >> The ov772x driver only works when the i2c controller have > >>

[PATCH] drivers: media: platform: make VIDEO_VIU depend on I2C

Commit 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") broke compilation without CONFIG_I2C selected. drivers/media/platform/fsl-viu.c: In function ‘viu_of_probe’: drivers/media/platform/fsl-viu.c:1452:7: error: implicit declaration of function ‘i2c_get_adapter’; did

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

Em Mon, 23 Apr 2018 14:11:02 -0500 "Gustavo A. R. Silva" escreveu: > On 04/23/2018 01:24 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 23 Apr 2018 12:38:03 -0500 > > "Gustavo A. R. Silva" escreveu: > > > >> f->index can be controlled by

Re: [PATCH 00/11] fix potential Spectre variant 1 issues

Hi, Please, drop this series. Further analysis is required as it seems all these are False Positives. Sorry for the noise. Thanks -- Gustavo On 04/23/2018 12:37 PM, Gustavo A. R. Silva wrote: This patchset aims to fix various media platform and media usb cases where we have user controlled

Re: [PATCH v2] [media] uvcvideo: Refactor teardown of uvc on USB disconnect

Laurent, Kieran, Can one of you look at this? https://patchwork.linuxtv.org/patch/40941/ BTW, there are a *lot* of old patches delegated to you, Laurent. If neither you or Kieran have time to look at them, then please undelegate them and I can take a bunch of them. I see quite a few simple bug

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

On 04/23/2018 01:24 PM, Mauro Carvalho Chehab wrote: Em Mon, 23 Apr 2018 12:38:03 -0500 "Gustavo A. R. Silva" escreveu: f->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning:

[PATCH 07/11] rcar_drif: fix potential Spectre variant 1

f->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/platform/rcar_drif.c:909 rcar_drif_enum_fmt_sdr_cap() warn: potential spectre issue 'formats' Fix this by sanitizing f->index before using it

[PATCH 05/11] omap_vout: fix potential Spectre variant 1

index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/platform/omap/omap_vout.c:1062 vidioc_enum_fmt_vid_out() warn: potential spectre issue 'omap_formats' Fix this by sanitizing index before using

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

Em Mon, 23 Apr 2018 12:38:03 -0500 "Gustavo A. R. Silva" escreveu: > f->index can be controlled by user-space, hence leading to a > potential exploitation of the Spectre variant 1 vulnerability. > > Smatch warning: > drivers/media/usb/tm6000/tm6000-video.c:879

[PATCH 10/11] vivid-sdr-cap: fix potential Spectre variant 1

band->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/platform/vivid/vivid-sdr-cap.c:323 vivid_sdr_enum_freq_bands() warn: potential spectre issue 'bands_adc' Fix this by sanitizing

[PATCH 09/11] vimc-debayer: fix potential Spectre variant 1

code->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/platform/vimc/vimc-debayer.c:182 vimc_deb_enum_mbus_code() warn: potential spectre issue 'vimc_deb_pix_map_list' Fix this by sanitizing

[PATCH 06/11] rcar-v4l2: fix potential Spectre variant 1

f->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/platform/rcar-vin/rcar-v4l2.c:344 rvin_enum_fmt_vid_cap() warn: potential spectre issue 'rvin_formats' Fix this by sanitizing f->index before

[PATCH 08/11] sh_vou: fix potential Spectre variant 1

fmt->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/platform/sh_vou.c:407 sh_vou_enum_fmt_vid_out() warn: potential spectre issue 'vou_fmt' Fix this by sanitizing fmt->index before using it

[PATCH 04/11] marvell-ccic: mcam-core: fix potential Spectre variant 1

fmt->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/platform/marvell-ccic/mcam-core.c:1323 mcam_vidioc_enum_fmt_vid_cap() warn: potential spectre issue 'mcam_formats' Fix this by sanitizing

[PATCH 01/11] media: tm6000: fix potential Spectre variant 1

f->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/usb/tm6000/tm6000-video.c:879 vidioc_enum_fmt_vid_cap() warn: potential spectre issue 'format' Fix this by sanitizing f->index before using

Re: [PATCH v3 05/13] media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers

On 04/23/2018 12:14 AM, Sakari Ailus wrote: Hi Steve, On Tue, Mar 20, 2018 at 05:37:21PM -0700, Steve Longerbeam wrote: Adds v4l2_async_register_fwnode_subdev(), which is a convenience function for parsing a sub-device's fwnode port endpoints for connected remote sub-devices, registering a

Re: [PATCH v2] [media] uvcvideo: Refactor teardown of uvc on USB disconnect

https://www.spinics.net/lists/linux-media/msg115062.html Thanks for Daniel to fix this old issue. I might overlooked it but I didn't find it in the latest upstream kernel. Are we going to merge this missing patch? Thanks! Best, Li

[PATCH 11/11] vsp1_rwpf: fix potential Spectre variant 1

code->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/platform/vsp1/vsp1_rwpf.c:47 vsp1_rwpf_enum_mbus_code() warn: potential spectre issue 'codes' Fix this by sanitizing code->index before

Re: [PATCH 2/9] cx231xx: Use board profile values for addresses

Hi Matthias, On 2018-04-19 12:10, Matthias Schwarzott wrote: > Am 17.04.2018 um 18:39 schrieb Brad Love: >> Replace all usage of hard coded values with >> the proper field from the board profile. >> > Hi Brad, > > will there be any interference with the usage to configure the analog > tuner via

[PATCH 03/11] fsl-viu: fix potential Spectre variant 1

f->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/platform/fsl-viu.c:587 vidioc_enum_fmt() warn: potential spectre issue 'formats' Fix this by sanitizing f->index before using it to index

[PATCH 02/11] exynos4-is: mipi-csis: fix potential Spectre variant 1

code->index can be controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. Smatch warning: drivers/media/platform/exynos4-is/mipi-csis.c:549 s5pcsis_enum_mbus_code() warn: potential spectre issue 's5pcsis_formats' Fix this by sanitizing

[PATCH 00/11] fix potential Spectre variant 1 issues

This patchset aims to fix various media platform and media usb cases where we have user controlled array dereferences that could be exploited due to the Spectre variant 1 vulnerability. All were reported by Dan Carpenter. Notice that given that speculation windows are large, the policy is to kill

Re: [PATCH 5/9] cx231xx: Switch to using new dvb i2c helpers

Hi Matthias, On 2018-04-19 12:09, Matthias Schwarzott wrote: > Am 17.04.2018 um 18:39 schrieb Brad Love: >> Mostly very straight forward replace of blocks with equivalent code. >> >> Cleanup added at end of dvb_init in case of failure. >> > Hi Brad, > > I have some suggestions. See below. > >

Re: How to proceed ? => [PATCH ?] EM28xx driver ?

Em Mon, 23 Apr 2018 12:35:06 -0400 Alexandre-Xavier Labonté-Lamoureux escreveu: > This should give you an idea of what you need to do: > https://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches Yes. In particular, you should send it against the upstream

Re: [PATCH v3][RESEND] media: i2c: tda1997: replace codec to component

On Mon, Apr 23, 2018 at 09:44:17AM -0700, Tim Harvey wrote: > Could you add some detail to the commit explaining why we need to > replace codec to component? I don't really know what that means. > Please refer to a commit if the ASoC API is changing in some way we > need to catch up with. This

Re: [PATCH v3][RESEND] media: i2c: tda1997: replace codec to component

On Sun, Apr 22, 2018 at 7:10 PM, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > Now we can replace Codec to Component. Let's do it. > > Note: > xxx_codec_xxx() -> xxx_component_xxx() >

Re: How to proceed ? => [PATCH ?] EM28xx driver ?

This should give you an idea of what you need to do: https://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches On Mon, Apr 23, 2018 at 3:18 AM, mjs wrote: > Hello, > > 4 years ago I started to try to make a dvb-t ":ZOLID Hybrid TV Stick" to work > with linux. > >

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

On Mon, Apr 23, 2018 at 12:09 PM, Rui Miguel Silva wrote: > Yes, you are correct, I will fix this, and the dts entry. As this pin has both reset and powerdown functionalities, maybe you can name the property as 'reset-gpios' Thanks

Re: [PATCH v3 02/11] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

2018-04-23 18:18 GMT+09:00 Laurent Pinchart : > Hi Mita-san, > > On Sunday, 22 April 2018 18:56:08 EEST Akinobu Mita wrote: >> The ov772x driver only works when the i2c controller have >> I2C_FUNC_PROTOCOL_MANGLING. However, many i2c controller drivers don't >>

Re: [PATCH v3 01/11] media: dt-bindings: ov772x: add device tree binding

2018-04-23 18:17 GMT+09:00 Laurent Pinchart : > Hi Mita-san, > > On Sunday, 22 April 2018 18:56:07 EEST Akinobu Mita wrote: >> This adds a device tree binding documentation for OV7720/OV7725 sensor. >> >> Cc: Jacopo Mondi >> Cc:

Re: [PATCH v2 06/15] media: staging/imx: add imx7 capture subsystem

On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote: > Add imx7 capture subsystem to imx-media core to allow the use some of the > existing modules for i.MX5/6 with i.MX7 SoC. > > Since i.MX7 does not have an IPU unset the ipu_present flag to differentiate > some runtime behaviors. > >

Re: [PATCH v2 11/15] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote: > This patch adds the device tree nodes for csi, video multiplexer and mipi-csi > besides the graph connecting the necessary endpoints to make the media capture > entities to work in imx7 Warp board. > > Also add the pin control related

Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

Hi Simon, On Wed, Feb 21, 2018 at 07:29:18PM +0100, Simon Horman wrote: > On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote: > > Add Capture Engine Unit (CEU) node to device tree. > > > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Geert Uytterhoeven

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Fabio, Thanks for the review. On Mon 23 Apr 2018 at 14:11, Fabio Estevam wrote: Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: +Optional Properties: +- powerdown-gpios: reference to the GPIO connected to the powerdown pin, +

Re: [RFCv11 PATCH 00/29] Request API

Hi Alexandre, On 04/19/2018 09:48 AM, Paul Kocialkowski wrote: > Hi, > > On Wed, 2018-04-18 at 02:06 +, Alexandre Courbot wrote: >> On Tue, Apr 17, 2018 at 8:41 PM Paul Kocialkowski < >> paul.kocialkow...@bootlin.com> wrote: >> On Tue, 2018-04-17 at 06:17 +, Alexandre Courbot wrote:

Re: [RFCv11 PATCH 27/29] vim2m: support requests

On 04/17/2018 01:42 PM, Paul Kocialkowski wrote: > Hi, > > On Mon, 2018-04-09 at 16:20 +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Add support for requests to vim2m. > > Please find a nit below. > >> Signed-off-by: Hans Verkuil >> ---

Re: [RFCv11 PATCH 27/29] vim2m: support requests

On 04/17/2018 06:37 AM, Alexandre Courbot wrote: > On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > >> From: Hans Verkuil > >> Add support for requests to vim2m. > >> Signed-off-by: Hans Verkuil >> --- >>

Re: [RFCv11 PATCH 20/29] videobuf2-v4l2: integrate with media requests

On 04/17/2018 06:36 AM, Alexandre Courbot wrote: > On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > >> From: Hans Verkuil > >> This implements the V4L2 part of the request support. The main >> change is that vb2_qbuf and vb2_prepare_buf now have

Re: [PATCH v2 1/4] media: v4l2-compat-ioctl32: fix several __user annotations

Hi Mauro, Thanks for the update. Just a few comments below... On Thu, Apr 19, 2018 at 12:33:29PM -0400, Mauro Carvalho Chehab wrote: > Smatch report several issues with bad __user annotations: > > drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: warning: incorrect > type in argument 1

Re: [PATCH 0/5] Remaining COMPILE_TEST and smatch cleanups

Em Mon, 23 Apr 2018 17:09:19 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Thu, Apr 19, 2018 at 07:42:28AM -0300, Mauro Carvalho Chehab wrote: > > Em Wed, 18 Apr 2018 12:04:14 +0300 > > Sakari Ailus escreveu: > > > > > On Tue, Apr 17, 2018 at

Re: [RFCv11 PATCH 07/29] media-request: add media_request_object_find

On 04/17/2018 06:36 AM, Alexandre Courbot wrote: > On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > >> From: Hans Verkuil > >> Add media_request_object_find to find a request object inside a >> request based on ops and/or priv values. > >>

Re: [RFCv11 PATCH 04/29] media-request: core request support

On 04/17/2018 06:35 AM, Alexandre Courbot wrote: > On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > >> From: Hans Verkuil > >> Implement the core of the media request processing. > >> Drivers can bind request objects to a request. These objects

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

Em Mon, 23 Apr 2018 17:11:14 +0300 Tomi Valkeinen escreveu: > On 23/04/18 16:56, Bartlomiej Zolnierkiewicz wrote: > > > Ideally we should be able to build both drivers in the same kernel > > (especially as modules). > > > > I was hoping that it could be fixed easily but

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

Em Mon, 23 Apr 2018 15:56:53 +0200 Bartlomiej Zolnierkiewicz escreveu: > On Monday, April 23, 2018 02:47:28 PM Bartlomiej Zolnierkiewicz wrote: > > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > > > Add stubs for omapfb_dss.h, in the case it is

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: > +Optional Properties: > +- powerdown-gpios: reference to the GPIO connected to the powerdown pin, > +if any. This is an active high signal to the OV2680. I looked at the OV2680

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

On 23/04/18 16:56, Bartlomiej Zolnierkiewicz wrote: > Ideally we should be able to build both drivers in the same kernel > (especially as modules). > > I was hoping that it could be fixed easily but then I discovered > the root source of the problem: > > drivers/gpu/drm/omapdrm/dss/display.o:

Re: [PATCH 0/5] Remaining COMPILE_TEST and smatch cleanups

Hi Mauro, On Thu, Apr 19, 2018 at 07:42:28AM -0300, Mauro Carvalho Chehab wrote: > Em Wed, 18 Apr 2018 12:04:14 +0300 > Sakari Ailus escreveu: > > > On Tue, Apr 17, 2018 at 06:20:10AM -0400, Mauro Carvalho Chehab wrote: > > > There were several interactions at the

Re: [RFCv11 PATCH 04/29] media-request: core request support

Em Mon, 23 Apr 2018 14:23:28 +0200 Hans Verkuil escreveu: > >> + spin_lock_irqsave(>lock, flags); > >> + state = req->state; > >> + spin_unlock_irqrestore(>lock, flags); > > > > IMO, it would be better to use an atomic var for state, having a > > lockless access to it.

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

On Monday, April 23, 2018 02:47:28 PM Bartlomiej Zolnierkiewicz wrote: > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > > Add stubs for omapfb_dss.h, in the case it is included by > > some driver when CONFIG_FB_OMAP2 is not defined, with can > > happen on ARM when DRM_OMAP is

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

Em Mon, 23 Apr 2018 14:47:28 +0200 Bartlomiej Zolnierkiewicz escreveu: > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > > Add stubs for omapfb_dss.h, in the case it is included by > > some driver when CONFIG_FB_OMAP2 is not defined, with can > >

Re: [RFCv11 PATCH 07/29] media-request: add media_request_object_find

On 04/12/2018 02:23 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, Apr 09, 2018 at 04:20:04PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Add media_request_object_find to find a request object inside a >> request based on ops and/or priv values. >> >> Objects

Re: [RFCv11 PATCH 06/29] media-request: add media_request_find

On 04/12/2018 02:08 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, Apr 09, 2018 at 04:20:03PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Add media_request_find() to find a request based on the file >> descriptor. >> >> The caller has to call

[PATCH v2 13/15] ARM: dts: imx7s-warp: add ov2680 sensor node

Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 16 1 file changed, 16 insertions(+) diff --git

[PATCH v2 12/15] ARM: dts: imx7s: add capture subsystem

Add media capture subsystem device to i.MX7 definitions. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 6b49b73053f9..333d9fe6b989

[PATCH v2 11/15] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Also add the pin control related with the mipi_csi in that board. Signed-off-by: Rui Miguel Silva

[PATCH v2 09/15] ARM: dts: imx7s: add mipi phy power domain

Add power domain index 0 related with mipi-phy to imx7s. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 142ea709d296..d913c3f9c284

[PATCH v2 14/15] media: imx7.rst: add documentation for i.MX7 media driver

Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++

[PATCH v2 15/15] media: staging/imx: add i.MX7 entries to TODO file

Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324

[PATCH v2 10/15] ARM: dts: imx7s: add multiplexer controls

The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 9 - 1 file

[PATCH v2 08/15] media: dt-bindings: add bindings for i.MX7 media driver

Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/imx7.txt| 158 ++ 1 file changed, 158 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx7.txt diff

[PATCH v2 07/15] ARM: dts: increase default cma size to 40MB

To support camera in i.MX7 the cma heap is used to allocate frame buffers. The default size of CMA is 16MB which is not enough for higher resolutions (ex: 1600x1200). So, increase the default CMA size to 40MB. Signed-off-by: Rui Miguel Silva ---

[PATCH v2 06/15] media: staging/imx: add imx7 capture subsystem

Add imx7 capture subsystem to imx-media core to allow the use some of the existing modules for i.MX5/6 with i.MX7 SoC. Since i.MX7 does not have an IPU unset the ipu_present flag to differentiate some runtime behaviors. Signed-off-by: Rui Miguel Silva ---

[PATCH v2 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1149 2 files changed, 1150

[PATCH v2 04/15] clk: imx7d: reset parent for mipi csi root

To guarantee that we do not get Overflow in image FIFO the outer bandwidth has to be faster than inputer bandwidth. For that it must be possible to set a faster frequency clock. So set new parent to sys_pfd3 clock for the mipi csi block. Cc: linux-...@vger.kernel.org Signed-off-by: Rui Miguel

[PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent

Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan clock and set the correct parent. before: cat clk_orphan_summary enable prepare protect clock countcountcountrate accuracy phase

[PATCH v2 01/15] media: staging/imx: add support to media dev for no IPU systems

Some i.MX SoC do not have IPU, like the i.MX7, add to the the media device infrastructure support to be used in this type of systems that do not have internal subdevices besides the CSI. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx-media-dev.c |

[PATCH v2 00/15] media: staging/imx7: add i.MX7 media driver

Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it support that case.

[PATCH v2 02/15] media: staging/imx7: add imx7 CSI subdev driver

This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 +

Re: [RFCv11 PATCH 05/29] media-request: add request ioctls

On 04/12/2018 12:40 PM, Sakari Ailus wrote: > Hi Mauro, > > On Tue, Apr 10, 2018 at 07:57:56AM -0300, Mauro Carvalho Chehab wrote: >> Em Mon, 9 Apr 2018 16:20:02 +0200 >> Hans Verkuil escreveu: >> >>> From: Hans Verkuil >>> >>> Implement the

Re: [RFCv11 PATCH 03/29] media-request: allocate media requests

Em Mon, 23 Apr 2018 13:49:11 +0200 Hans Verkuil escreveu: > On 04/10/2018 11:52 AM, Mauro Carvalho Chehab wrote: > > Em Mon, 9 Apr 2018 16:20:00 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Add

Re: [RFCv11 PATCH 02/29] uapi/linux/media.h: add request API

Em Mon, 23 Apr 2018 13:41:31 +0200 Hans Verkuil escreveu: > On 04/10/2018 01:00 PM, Sakari Ailus wrote: > > On Tue, Apr 10, 2018 at 06:38:56AM -0300, Mauro Carvalho Chehab wrote: > >> Em Mon, 9 Apr 2018 16:19:59 +0200 > >> Hans Verkuil escreveu: > >>

Re: [RFCv11 PATCH 27/29] vim2m: support requests

On 04/12/2018 11:15 AM, Tomasz Figa wrote: > Hi Hans, > > On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > >> From: Hans Verkuil > >> Add support for requests to vim2m. > >> Signed-off-by: Hans Verkuil >> --- >>

Re: [RFCv11 PATCH 25/29] media: vim2m: add media device

On 04/12/2018 10:54 AM, Tomasz Figa wrote: > On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > >> From: Alexandre Courbot > >> Request API requires a media node. Add one to the vim2m driver so we can >> use requests with it. > >> This probably

[PATCH] media: siano: be sure to not override devpath size

Right now, at siano driver, all places where devpath is defined has sizeof(devpath) == 32. So, there's no practical risc of going past devpath array anywhere. Still, code changes might cause troubles. It also confuses Coverity: CID 139059 (#1 of 1): Copy into fixed size buffer

Re: [PATCH v2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

On Mon, 2018-04-23 at 08:55 -0300, Fabio Estevam wrote: > Hi Hans, > > Unfortunately this one missed to be applied into 4.17-rc and now the > imx-media-csi driver does not probe. > > Please consider applying it for 4.17-rc3 to avoid the regression. > > Thanks > > On Mon, Apr 16, 2018 at 2:28

Re: [PATCH 4/8] arm64: dts: renesas: eagle: Add thc63 LVDS map

Hi Jacopo, Thank you for the patch. On Thursday, 19 April 2018 12:31:05 EEST Jacopo Mondi wrote: > Add LVDS map mode description property to THC63LVD1024 LVDS decoder in > R-Car V3M-Eagle board device tree. > > Signed-off-by: Jacopo Mondi Reviewed-by: Laurent

Re: [PATCH 5/8] media: Add LE version of RGB LVDS formats

Hi Jacopo, Thank you for the patch. On Thursday, 19 April 2018 12:31:06 EEST Jacopo Mondi wrote: > Some LVDS controller can output swapped versions of LVDS RGB formats. > Define and document them in the list of supported media bus formats I wouldn't introduce those new formats as we don't need

Re: [PATCH 6/8] drm: rcar-du: rcar-lvds: Add bridge format support

Hello, On Monday, 23 April 2018 11:47:28 EEST jacopo mondi wrote: > On Mon, Apr 23, 2018 at 09:59:22AM +0200, Peter Rosin wrote: > > On 2018-04-23 09:28, jacopo mondi wrote: > >> On Sun, Apr 22, 2018 at 10:08:21PM +0200, Peter Rosin wrote: > >>> On 2018-04-19 11:31, Jacopo Mondi wrote: >

Re: [RFCv11 PATCH 22/29] videobuf2-v4l2: add vb2_request_queue helper

On 04/12/2018 10:29 AM, Tomasz Figa wrote: > On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > >> From: Hans Verkuil > >> Generic helper function that checks if there are buffers in >> the request and if so, prepares and queues all objects in the

Re: [RFCv11 PATCH 19/29] videobuf2-core: integrate with media requests

On 04/12/2018 10:13 AM, Tomasz Figa wrote: > Hi Hans, > > On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > >> From: Hans Verkuil > >> Buffers can now be prepared or queued for a request. > >> A buffer is unbound from the request at

Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP

On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > Add stubs for omapfb_dss.h, in the case it is included by > some driver when CONFIG_FB_OMAP2 is not defined, with can > happen on ARM when DRM_OMAP is not 'n'. > > That allows building such driver(s) with COMPILE_TEST. > >

Re: [RFCv11 PATCH 04/29] media-request: core request support

On 04/12/2018 09:11 AM, Sakari Ailus wrote: > On Wed, Apr 11, 2018 at 01:13:44PM -0300, Mauro Carvalho Chehab wrote: >> Em Wed, 11 Apr 2018 18:35:14 +0300 >> Sakari Ailus escreveu: >> >>> On Wed, Apr 11, 2018 at 12:17:27PM -0300, Mauro Carvalho Chehab wrote: Em Wed, 11

Re: [RFCv11 PATCH 05/29] media-request: add request ioctls

On 04/12/2018 09:35 AM, Sakari Ailus wrote: > Hi Tomasz, > > On Tue, Apr 10, 2018 at 08:59:23AM +, Tomasz Figa wrote: >> Hi Hans, >> >> On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: >> >>> From: Hans Verkuil >> >>> Implement the

[PATCH] media: flexcop-i2c: get rid of KERN_CONT

Coverity complains about werid stuff at the debug logic: CID 113542 (#1 of 1): Out-of-bounds access (ARRAY_VS_SINGLETON)10. callee_ptr_arith: Passing buf to function flexcop_i2c_write4 which uses it as an array. This might corrupt or misinterpret adjacent memory

  1   2   >