Re: i.MX6: can't capture on MIPI-CSI2 with DS90UB954

Hi Jean-Michel, On 10/30/2018 06:41 PM, Jean-Michel Hautbois wrote: > Hi there, > > I am using the i.MX6D from Digi (connect core 6 sbc) with a mailine > kernel (well, 4.14 right now) and have an issue with mipi-csi2 > capture. > First I will give brief explanation of my setup, and then I will >

Re: [PATCH v4 2/5] media: dt: bindings: Add binding for NVIDIA Tegra Video Decoder Engine

Hi Dmitry, On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > Add binding documentation for the Video Decoder Engine which is found > on NVIDIA Tegra20/30/114/124/132 SoC's. > > Signed-off-by: Dmitry Osipenko > --- > .../devicetree/bindings/media/nvidia,tegra-vde.txt | 55 >

Re: [PATCH v4 1/5] ARM: tegra: Add device tree node to describe IRAM

Hi Dmitry, On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > From: Vladimir Zapolskiy <v...@mleia.com> > > All Tegra SoCs contain 256KiB IRAM, which is used to store CPU resume code > and by hardware engines like a video decoder. > > Signed-off-by: Vladimir Zapolskiy <

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

Hi Dmitry, I'll add just a couple of minor comments, in general the code looks very good. On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > NVIDIA Tegra20/30/114/124/132 SoC's have video decoder engine that > supports standard set of video formats like H.264 / MPEG-4 / WMV / VC1. > Currently

Re: [PATCH v3 2/2] ARM: dts: tegra20: Add video decoder node

t may lead to conflicts for IRAM resource between users. My proposal is to add a valid device tree node to describe an IRAM region firstly, then reserve a subregion in it by using a new "iram" property. 8< From: Vladimir Zapolskiy <v...@mleia.com> Date: Thu, 12 Oct 2017

Re: [PATCH v8 00/34] i.MX Media Driver

On 06/10/2017 02:26 AM, Hans Verkuil wrote: > On 10/06/17 01:16, Steve Longerbeam wrote: >> >> >> On 06/07/2017 12:02 PM, Hans Verkuil wrote: >>> We're still waiting for an Ack for patch 02/34, right? >>> >> >> Hi Hans, Rub has provided an Ack for patch 2. >> >>> Other than that everything is

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Steve, On 03/28/2017 03:40 AM, Steve Longerbeam wrote: > From: Philipp Zabel > > This driver can handle SoC internal and external video bus multiplexers, > controlled either by register bit fields or by a GPIO. The subdevice > passes through frame interval and mbus

Re: [PATCH v10 1/2] Documentation: DT: Add OV5647 bindings

Hi Ramiro, On 03/06/2017 01:16 PM, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira <roliv...@synopsys.com> The device tree binding description looks perfect from my perspective. Reviewed-by: Vladimir Zapolskiy &

Re: [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor.

roliv...@synopsys.com> All updates are fine, thank you. Feel free to add my Reviewed-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> > --- > MAINTAINERS| 7 + > drivers/media/i2c/Kconfig | 11 + > drivers/media/i2c/Makefile |

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/19/2017 04:22 PM, Russell King - ARM Linux wrote: > On Sun, Mar 19, 2017 at 02:21:10PM +, Russell King - ARM Linux wrote: >> There's a good reason why I dumped a full debug log using GST_DEBUG=*:9, >> analysed it for the cause of the failure, and tried several different >> pipelines,

Re: [PATCH v5 00/39] i.MX Media Driver

Hi Russell, On 03/18/2017 10:43 PM, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >> Can you share your gstreamer pipeline? For now, until >> VIDIOC_ENUM_FRAMESIZES is implemented, try a pipeline that >> does not attempt to specify a frame

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

On 02/22/2017 12:51 PM, Ramiro Oliveira wrote: > Hi Zakari, > > On 2/21/2017 8:36 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/21/2017 06:42 PM, Ramiro Oliveira wrote: >>> Hi Vladimir, >>> >>> Thank you for your feedback >>&

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Ramiro, On 02/22/2017 12:57 PM, Ramiro Oliveira wrote: > Hi Vladimir > > On 2/21/2017 10:37 PM, Vladimir Zapolskiy wrote: >> Hi Sakari, >> >> On 02/21/2017 11:48 PM, Sakari Ailus wrote: >>> Hi, Vladimir! >>> >>> How do you do? :-) >>

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Sakari, On 02/21/2017 11:48 PM, Sakari Ailus wrote: > Hi, Vladimir! > > How do you do? :-) deferring execution of boring tasks by doing code review :) > On Tue, Feb 21, 2017 at 10:48:09PM +0200, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/21/2017 1

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Ramiro, On 02/21/2017 10:13 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback > > On 2/21/2017 3:58 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: >>> Create device tree

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

Hi Ramiro, On 02/21/2017 06:42 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback > > On 2/21/2017 3:54 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> please find some review comments below. >> >> On 02/17/2017 03:14 PM,

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Ramiro, On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira > Acked-by: Rob Herring > --- > .../devicetree/bindings/media/i2c/ov5647.txt | 35 > ++ >

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

Hi Ramiro, please find some review comments below. On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: > The OV5647 sensor from Omnivision supports up to 2592x1944 @ 15 fps, RAW 8 > and RAW 10 output formats, and MIPI CSI-2 interface. > > The driver adds support for 640x480 RAW 8. > >

Re: [PATCH v8 2/2] Add support for OV5647 sensor.

Hi Ramiro, On 02/13/2017 09:14 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback. > > On 2/13/2017 12:21 PM, Vladimir Zapolskiy wrote: >> Hello Ramiro, >> >> On 02/13/2017 01:25 PM, Ramiro Oliveira wrote: >>> Modes supported: >

Re: [PATCH v8 2/2] Add support for OV5647 sensor.

Hello Ramiro, On 02/13/2017 01:25 PM, Ramiro Oliveira wrote: > Modes supported: > - 640x480 RAW 8 > It is a pretty short commit message, please consider to write a couple of words about the sensor. > Signed-off-by: Ramiro Oliveira > --- [snip] > + > +struct cfg_array

Re: [PATCH v2 15/19] media: imx: Add MIPI CSI-2 Receiver subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile| 1 + >

Re: [PATCH v2 14/19] media: imx: Add Camera Interface subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is the camera interface driver that provides the v4l2 > user interface. Frames can be received from various sources: > > - directly from SMFC for capturing unconverted images directly from > camera sensors. > > - from the IC pre-process

Re: [PATCH v2 13/19] media: imx: Add IC subdev drivers

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a set of three media entity subdevice drivers for the i.MX > Image Converter. The i.MX IC module contains three independent > "tasks": > > - Pre-processing Encode task: video frames are routed directly from > the CSI and can be scaled,

Re: [PATCH v2 12/19] media: imx: Add SMFC subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a media entity subdevice driver for the i.MX Sensor Multi-FIFO > Controller module. Video frames are received from the CSI and can > be routed to various sinks including the i.MX Image Converter for > scaling, color-space conversion, motion

Re: [PATCH v2 11/19] media: imx: Add CSI subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a media entity subdevice for the i.MX Camera > Serial Interface module. > > Signed-off-by: Steve Longerbeam > --- [snip] > diff --git a/drivers/staging/media/imx/imx-csi.c >

Re: [PATCH v2 10/19] media: Add i.MX media core driver

Hi Steve, On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam > --- > Documentation/devicetree/bindings/media/imx.txt | 205 + v2 was sent before getting Rob's review comments, but

Re: [PATCH v2 09/19] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the ADV7180 decoder sensor. The ADV7180 connects to the > parallel-bus mux input on ipu1_csi0_mux. > > On the sabreauto, two analog video inputs are routed to the ADV7180, > composite on Ain1, and composite on Ain3. Those inputs are

Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > > The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. > > The OV5640 connects to the input port on the MIPI CSI-2 receiver on > mipi_csi. It is set

Re: [PATCH v2 04/19] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

Hi Steve, On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > Both hang off the same i2c2 bus, so they require different (and non- > default) i2c slave addresses. > > The OV5642 connects to the parallel-bus mux input port

Re: [PATCH v2 1/8] i2c-mux: add common core data for every mux instance

Hi Peter, On 24.03.2016 13:05, Peter Rosin wrote: > Hi Vladimir, > > On 2016-03-24 10:50, Vladimir Zapolskiy wrote: >> Hi Peter, >> >> On 05.01.2016 17:57, Peter Rosin wrote: >>> From: Peter Rosin <p...@axentia.se> >>> >>> The init

Re: [PATCH v2 1/8] i2c-mux: add common core data for every mux instance

Hi Peter, On 05.01.2016 17:57, Peter Rosin wrote: > From: Peter Rosin > > The initial core mux structure starts off small with only the parent > adapter pointer, which all muxes have, and a priv pointer for mux > driver private data. > > Add i2c_mux_alloc function to unify the

Re: [PATCH] media: rc: remove unneeded mutex in rc_register_device

On 16.03.2016 20:53, Heiner Kallweit wrote: > Access to dev->initialized is atomic, therefore we don't have to > protect it with a mutex. Mutexes are used to split the code to mutually exclusive execution blocks, so not arguing about the apparently correct change itself I want to emphasize that

Re: gstreamer and v4l2

On 15.03.2016 12:28, Antonio Ospite wrote: > On Tue, 15 Mar 2016 09:10:59 +0200 > Ran Shalit wrote: > >> Hello, >> >> This is a bit offtopic, so I will understand if you rather not discuss >> that... >> >> I am trying to use gstreamer with v4l2 vivi device, >> I first check

[PATCH] media: i2c/adp1653: fix check of devm_gpiod_get() error code

The devm_gpiod_get() function returns either a valid pointer to struct gpio_desc or ERR_PTR() error value, check for NULL is bogus. Signed-off-by: Vladimir Zapolskiy <v...@mleia.com> --- drivers/media/i2c/adp1653.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH] v4l2-ctrls: remove unclaimed v4l2_ctrl_add_ctrl() interface

Signed-off-by: Vladimir Zapolskiy <v...@mleia.com> --- Documentation/video4linux/v4l2-controls.txt | 1 - drivers/media/v4l2-core/v4l2-ctrls.c| 16 include/media/v4l2-ctrls.h | 12 3 files changed, 29 deletions(-) diff --git a/Documentation/

[PATCH v2 1/2] genalloc: add name arg to gen_pool_get() and devm_gen_pool_create()

gen_pool per device, this implies two possible error codes returned by the function, account it on client side (only misc/sram). This completes client side changes related to genalloc updates. Signed-off-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com Cc: Philipp Zabel p.za...@pengutronix.de Cc

[PATCH v2 0/2] genalloc: add support of multiple gen_pools per device

in of_gen_pool_get() change to respect OF_DYNAMIC - instead of adding two new functions the existing functions gen_pool_get() (at91, imx5m, imx6 and CODA driver clients) and devm_gen_pool_create() (sram client) are updated. Vladimir Zapolskiy (2): genalloc: add name arg to gen_pool_get

[PATCH 1/2] genalloc: add name arg to gen_pool_get() and devm_gen_pool_create()

gen_pool per device, this implies two possible error codes returned by the function, account it on client side (only misc/sram). This completes client side changes related to genalloc updates. Signed-off-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com --- arch/arm/mach-at91/pm.c

[PATCH 2/2] genalloc: rename of_get_named_gen_pool() to of_gen_pool_get()

object. Due to a weak relation and to avoid any confusion (e.g. in future possible scenario if gen_pool objects are named) the suffix is removed. Signed-off-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com --- drivers/dma/mmp_tdma.c| 2 +- drivers/media/platform/coda/coda

[PATCH 1/2] genalloc: rename dev_get_gen_pool() to gen_pool_get()

To be consistent with other genalloc interface namings, rename dev_get_gen_pool() to gen_pool_get(). The original omitted dev_ prefix is removed, since it points to argument type of the function, and so it does not bring any useful information. Signed-off-by: Vladimir Zapolskiy vladimir_zapols

[PATCH 0/2] genalloc: rename dev_get_gen_pool() and of_get_named_gen_pool()

is based and tested on linux-next. Vladimir Zapolskiy (2): genalloc: rename dev_get_gen_pool() to gen_pool_get() genalloc: rename of_get_named_gen_pool() to of_gen_pool_get() arch/arm/mach-at91/pm.c | 2 +- arch/arm/mach-imx/pm-imx5.c | 2 +- arch/arm/mach-imx

Re: [PATCH 1/3] staging: imx-drm: document internal HDMI I2C master controller DT binding

Montag, den 01.12.2014, 17:39 +0200 schrieb Vladimir Zapolskiy: On 01.12.2014 17:11, Philipp Zabel wrote: Am Montag, den 01.12.2014, 16:54 +0200 schrieb Vladimir Zapolskiy: Hi Philipp and Shawn, On 15.11.2014 19:49, Vladimir Zapolskiy wrote: Provide information about how to bind internal iMX6Q/DL

Re: [PATCH 1/3] staging: imx-drm: document internal HDMI I2C master controller DT binding

Hi Philipp and Shawn, On 15.11.2014 19:49, Vladimir Zapolskiy wrote: Provide information about how to bind internal iMX6Q/DL HDMI DDC I2C master controller. The property is set as optional one, because iMX6 HDMI DDC bus may be represented by one of general purpose I2C busses found on SoC

Re: [PATCH 1/3] staging: imx-drm: document internal HDMI I2C master controller DT binding

On 01.12.2014 17:11, Philipp Zabel wrote: Am Montag, den 01.12.2014, 16:54 +0200 schrieb Vladimir Zapolskiy: Hi Philipp and Shawn, On 15.11.2014 19:49, Vladimir Zapolskiy wrote: Provide information about how to bind internal iMX6Q/DL HDMI DDC I2C master controller. The property is set

[PATCH 1/3] staging: imx-drm: document internal HDMI I2C master controller DT binding

Provide information about how to bind internal iMX6Q/DL HDMI DDC I2C master controller. The property is set as optional one, because iMX6 HDMI DDC bus may be represented by one of general purpose I2C busses found on SoC. Signed-off-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com Cc: Wolfram