Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-22 Thread Steffen Trumtrar
On Sat, Oct 20, 2012 at 09:59:51PM +0200, Thierry Reding wrote: On Thu, Oct 04, 2012 at 07:59:19PM +0200, Steffen Trumtrar wrote: [...] diff --git a/include/linux/of_display_timings.h b/include/linux/of_display_timings.h [...] +struct display_timings { + unsigned int num_timings; +

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-20 Thread Thierry Reding
On Thu, Oct 04, 2012 at 07:59:19PM +0200, Steffen Trumtrar wrote: [...] diff --git a/include/linux/of_display_timings.h b/include/linux/of_display_timings.h new file mode 100644 index 000..1ad719e --- /dev/null +++ b/include/linux/of_display_timings.h @@ -0,0 +1,85 @@ +/* + *

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-20 Thread Thierry Reding
On Thu, Oct 04, 2012 at 07:59:19PM +0200, Steffen Trumtrar wrote: [...] diff --git a/include/linux/of_display_timings.h b/include/linux/of_display_timings.h [...] +struct display_timings { + unsigned int num_timings; + unsigned int default_timing; + + struct signal_timing

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-12 Thread Steffen Trumtrar
On Thu, Oct 11, 2012 at 09:31:18PM +0200, Thierry Reding wrote: On Mon, Oct 08, 2012 at 09:49:21AM +0200, Steffen Trumtrar wrote: On Mon, Oct 08, 2012 at 10:07:45AM +0300, Tomi Valkeinen wrote: On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: [...] + +

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-11 Thread Thierry Reding
On Mon, Oct 08, 2012 at 09:49:21AM +0200, Steffen Trumtrar wrote: On Mon, Oct 08, 2012 at 10:07:45AM +0300, Tomi Valkeinen wrote: On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: [...] + + disp-num_timings = 0; + + for_each_child_of_node(timings_np, entry) { +

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Tomi Valkeinen
Hi, On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- .../devicetree/bindings/video/display-timings.txt | 222 drivers/of/Kconfig |5 + drivers/of/Makefile

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Tomi Valkeinen
On Mon, 2012-10-08 at 10:07 +0300, Tomi Valkeinen wrote: Hi, I don't see you setting disp-default_timing to OF_DEFAULT_TIMING in case there's no default_timing found. Or, at least I presume OF_DEFAULT_TIMING is meant to mark non-existing default timing. The name OF_DEFAULT_TIMING is not

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Steffen Trumtrar
On Sun, Oct 07, 2012 at 03:38:25PM +0200, Laurent Pinchart wrote: Hi Steffen, On Friday 05 October 2012 18:38:58 Steffen Trumtrar wrote: On Fri, Oct 05, 2012 at 10:21:37AM -0600, Stephen Warren wrote: On 10/05/2012 10:16 AM, Steffen Trumtrar wrote: On Thu, Oct 04, 2012 at 12:47:16PM

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Steffen Trumtrar
Hi, On Mon, Oct 08, 2012 at 10:07:45AM +0300, Tomi Valkeinen wrote: Hi, On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- .../devicetree/bindings/video/display-timings.txt | 222

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Guennadi Liakhovetski
On Fri, 5 Oct 2012, Stephen Warren wrote: On 10/04/2012 03:35 PM, Guennadi Liakhovetski wrote: Hi Steffen Sorry for chiming in so late in the game, but I've long been wanting to have a look at this and compare with what we do for V4L2, so, this seems a great opportunity to me:-)

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Tomi Valkeinen
On Mon, 2012-10-08 at 10:25 +0200, Guennadi Liakhovetski wrote: In general, I might be misunderstanding something, but don't we have to distinguish between 2 types of information about display timings: (1) is defined by the display controller requirements, is known to the display driver

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Laurent Pinchart
Hi Tomi, On Monday 08 October 2012 12:01:18 Tomi Valkeinen wrote: On Mon, 2012-10-08 at 10:25 +0200, Guennadi Liakhovetski wrote: In general, I might be misunderstanding something, but don't we have to distinguish between 2 types of information about display timings: (1) is defined by the

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Tomi Valkeinen
On Mon, 2012-10-08 at 14:04 +0200, Laurent Pinchart wrote: Hi Tomi, On Monday 08 October 2012 12:01:18 Tomi Valkeinen wrote: On Mon, 2012-10-08 at 10:25 +0200, Guennadi Liakhovetski wrote: In general, I might be misunderstanding something, but don't we have to distinguish between 2

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Stephen Warren
On 10/08/2012 02:25 AM, Guennadi Liakhovetski wrote: On Fri, 5 Oct 2012, Stephen Warren wrote: On 10/04/2012 03:35 PM, Guennadi Liakhovetski wrote: Hi Steffen Sorry for chiming in so late in the game, but I've long been wanting to have a look at this and compare with what we do for V4L2,

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Stephen Warren
On 10/08/2012 06:20 AM, Tomi Valkeinen wrote: On Mon, 2012-10-08 at 14:04 +0200, Laurent Pinchart wrote: On Monday 08 October 2012 12:01:18 Tomi Valkeinen wrote: On Mon, 2012-10-08 at 10:25 +0200, Guennadi Liakhovetski wrote: ... Of course, if this is about describing the hardware, the

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Mitch Bradley
On 10/7/2012 11:01 PM, Tomi Valkeinen wrote: On Mon, 2012-10-08 at 10:25 +0200, Guennadi Liakhovetski wrote: In general, I might be misunderstanding something, but don't we have to distinguish between 2 types of information about display timings: (1) is defined by the display controller

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Laurent Pinchart
Hi Stephen, On Monday 08 October 2012 10:10:31 Stephen Warren wrote: On 10/08/2012 02:25 AM, Guennadi Liakhovetski wrote: On Fri, 5 Oct 2012, Stephen Warren wrote: On 10/04/2012 03:35 PM, Guennadi Liakhovetski wrote: Hi Steffen Sorry for chiming in so late in the game, but I've long

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-07 Thread Laurent Pinchart
Hi Steffen, On Friday 05 October 2012 18:38:58 Steffen Trumtrar wrote: On Fri, Oct 05, 2012 at 10:21:37AM -0600, Stephen Warren wrote: On 10/05/2012 10:16 AM, Steffen Trumtrar wrote: On Thu, Oct 04, 2012 at 12:47:16PM -0600, Stephen Warren wrote: On 10/04/2012 11:59 AM, Steffen Trumtrar

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Robert Schwebel
On Thu, Oct 04, 2012 at 11:35:35PM +0200, Guennadi Liakhovetski wrote: +optional properties: + - hsync-active-high (bool): Hsync pulse is active high + - vsync-active-high (bool): Vsync pulse is active high For the above two we also considered using bool properties but eventually settled

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Steffen Trumtrar
On Thu, Oct 04, 2012 at 12:47:16PM -0600, Stephen Warren wrote: On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: A patch description would be useful for something like this. Yes. Shame on me. diff --git a/Documentation/devicetree/bindings/video/display-timings.txt

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Stephen Warren
On 10/04/2012 03:35 PM, Guennadi Liakhovetski wrote: Hi Steffen Sorry for chiming in so late in the game, but I've long been wanting to have a look at this and compare with what we do for V4L2, so, this seems a great opportunity to me:-) On Thu, 4 Oct 2012, Steffen Trumtrar wrote:

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Stephen Warren
On 10/05/2012 10:16 AM, Steffen Trumtrar wrote: On Thu, Oct 04, 2012 at 12:47:16PM -0600, Stephen Warren wrote: On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: ... + for_each_child_of_node(timings_np, entry) { + struct signal_timing *st; + + st =

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Steffen Trumtrar
On Thu, Oct 04, 2012 at 11:35:35PM +0200, Guennadi Liakhovetski wrote: Hi Steffen Sorry for chiming in so late in the game, but I've long been wanting to have a look at this and compare with what we do for V4L2, so, this seems a great opportunity to me:-) On Thu, 4 Oct 2012, Steffen

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Steffen Trumtrar
On Fri, Oct 05, 2012 at 10:21:37AM -0600, Stephen Warren wrote: On 10/05/2012 10:16 AM, Steffen Trumtrar wrote: On Thu, Oct 04, 2012 at 12:47:16PM -0600, Stephen Warren wrote: On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: ... + for_each_child_of_node(timings_np, entry) { +

[PATCH 1/2 v6] of: add helper to parse display timings

2012-10-04 Thread Steffen Trumtrar
Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- .../devicetree/bindings/video/display-timings.txt | 222 drivers/of/Kconfig |5 + drivers/of/Makefile|1 + drivers/of/of_display_timings.c

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-04 Thread Stephen Warren
On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: A patch description would be useful for something like this. diff --git a/Documentation/devicetree/bindings/video/display-timings.txt b/Documentation/devicetree/bindings/video/display-timings.txt new file mode 100644 ... +Usage in backend

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-04 Thread Guennadi Liakhovetski
Hi Steffen Sorry for chiming in so late in the game, but I've long been wanting to have a look at this and compare with what we do for V4L2, so, this seems a great opportunity to me:-) On Thu, 4 Oct 2012, Steffen Trumtrar wrote: Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de ---