Re: [PATCH 1/3] tuners: si2157: Si2148 support.

2014-11-20 Thread Olli Salonen
On Mon, 17 Nov 2014, Michael Holzer wrote: I'd see merit to show the supported chips explicitly as otherwise users may be confused if a new unsupported chip (lets assume Si2159) appears and the message is generic as proposed Si215x. To get clarity for this case source code reading would be

Re: [PATCH 1/3] tuners: si2157: Si2148 support.

2014-11-20 Thread CrazyCat
No need, because si214x is same si215x without analog filter path. 20.11.2014, 22:10, Olli Salonen olli.salo...@iki.fi: Crazycat, do you think you could change the firmware loading for Si2148 as discussed here though and send a new patch? -- To unsubscribe from this list: send the line

Re: [PATCH 1/3] tuners: si2157: Si2148 support.

2014-11-17 Thread Michael Holzer
Hi Olli, re ' we start to have quite a list of chips there in the printouts (Si2147/Si2148/Si2157/Si2158) and more is coming -... Should we just say Si214x/Si215x there or something?' I'd see merit to show the supported chips explicitly as otherwise users may be confused if a new unsupported

Re: [PATCH 1/3] tuners: si2157: Si2148 support.

2014-11-15 Thread Olli Salonen
What about defining the firmware for Si2148-A20, but since the file is the same as Si2158-A20 just point to the same file? #define SI2148_A20_FIRMWARE dvb-tuner-si2158-a20-01.fw Then if Si2158-A20 would in the future get a new firmware that would not work with Si2148, this would not break

Re: [PATCH 1/3] tuners: si2157: Si2148 support.

2014-11-15 Thread Antti Palosaari
On 11/15/2014 12:41 PM, Olli Salonen wrote: What about defining the firmware for Si2148-A20, but since the file is the same as Si2158-A20 just point to the same file? #define SI2148_A20_FIRMWARE dvb-tuner-si2158-a20-01.fw Then if Si2158-A20 would in the future get a new firmware that would not

Re: [PATCH 1/3] tuners: si2157: Si2148 support.

2014-11-15 Thread Olli Salonen
On Sat, 15 Nov 2014, Antti Palosaari wrote: Assuming you rename possible new firmware: dvb-tuner-si2158-a20-01.fw dvb-tuner-si2158-a20-02.fw ? Basically, you would not like to rename firmware when it is updated if it is compatible with the driver. Lets say firmware gets bug fixes, just

[PATCH 1/3] tuners: si2157: Si2148 support.

2014-11-14 Thread CrazyCat
Si2148-A20 silicon tuner support. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net --- drivers/media/tuners/si2157.c | 10 ++ drivers/media/tuners/si2157.h | 2 +- drivers/media/tuners/si2157_priv.h | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 1/3] tuners: si2157: Si2148 support.

2014-11-14 Thread Antti Palosaari
Hello I wonder if we should define own firmware for Si2148-A20 just for sure. Olli? regards Antti On 11/14/2014 11:19 PM, CrazyCat wrote: Si2148-A20 silicon tuner support. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net --- drivers/media/tuners/si2157.c | 10 ++

Re: [PATCH 1/3] tuners: si2157: Si2148 support.

2014-11-14 Thread CrazyCat
2148 is 2158 without analog support. Same firmware. 15.11.2014, 03:02, Antti Palosaari cr...@iki.fi: I wonder if we should define own firmware for Si2148-A20 just for sure. Olli? -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

Re: [PATCH 1/3] tuners: si2157: Si2148 support.

2014-11-14 Thread Antti Palosaari
On 11/15/2014 03:22 AM, CrazyCat wrote: 2148 is 2158 without analog support. Same firmware. 15.11.2014, 03:02, Antti Palosaari cr...@iki.fi: I wonder if we should define own firmware for Si2148-A20 just for sure. Olli? But still... I have seen one case where even same revision of si2168