RE: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-05-18 Thread Aguirre Rodriguez, Sergio Alberto
...@vger.kernel.org; Jadav, Brijesh R; Hiremath, Vaibhav Subject: Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver Hello Hardik, Reviewing your driver, I found something made me curious. On Wed, Apr 22, 2009 at 3:25 PM, Hardik Shah hardik.s...@ti.com wrote: snip +/* Buffer setup function is called by videobuf

Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-05-18 Thread Dongsoo, Nathaniel Kim
...@vger.kernel.org] On Behalf Of Dongsoo, Nathaniel Kim [dongsoo@gmail.com] Sent: Tuesday, May 19, 2009 7:53 AM To: Shah, Hardik Cc: linux-media@vger.kernel.org; linux-o...@vger.kernel.org; Jadav, Brijesh R; Hiremath, Vaibhav Subject: Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver Hello Hardik, Reviewing

RE: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-05-18 Thread Shah, Hardik
; linux-o...@vger.kernel.org; Jadav, Brijesh R; Hiremath, Vaibhav Subject: Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver Hello Hardik, Reviewing your driver, I found something made me curious. On Wed, Apr 22, 2009 at 3:25 PM, Hardik Shah hardik.s...@ti.com wrote: snip +/* Buffer setup

Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-05-18 Thread Dongsoo, Nathaniel Kim
; Jadav, Brijesh R; Hiremath, Vaibhav Subject: RE: [PATCH 3/3] OMAP2/3 V4L2 Display Driver Hi Nate, I have 1 input regarding your question: From: linux-media-ow...@vger.kernel.org [linux-media-ow...@vger.kernel.org] On Behalf Of Dongsoo, Nathaniel Kim [dongsoo@gmail.com] Sent: Tuesday, May

RE: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-05-12 Thread Shah, Hardik
; Hiremath, Vaibhav Subject: Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver Thank you Shah, Hardik. I have patched your driver through that git. but your patch recognizes video2 layer as video1 device node in case that DSS2 has fb0 and fb1. [Shah, Hardik] There is no need to change the nodes

Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-04-30 Thread InKi Dae
- From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com] Sent: Wednesday, April 22, 2009 1:53 PM To: Shah, Hardik Cc: linux-media@vger.kernel.org; linux-o...@vger.kernel.org; Jadav, Brijesh R; Hiremath, Vaibhav Subject: Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver Hi, On Wed, 2009-04-22

RE: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-04-30 Thread Shah, Hardik
, Brijesh R; Hiremath, Vaibhav Subject: RE: [PATCH 3/3] OMAP2/3 V4L2 Display Driver -Original Message- From: InKi Dae [mailto:daei...@gmail.com] Sent: Thursday, April 30, 2009 11:48 AM To: Shah, Hardik Cc: tomi.valkei...@nokia.com; linux-media@vger.kernel.org; linux- o

Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-04-30 Thread InKi Dae
, Brijesh R; Hiremath, Vaibhav Subject: RE: [PATCH 3/3] OMAP2/3 V4L2 Display Driver -Original Message- From: InKi Dae [mailto:daei...@gmail.com] Sent: Thursday, April 30, 2009 11:48 AM To: Shah, Hardik Cc: tomi.valkei...@nokia.com; linux-media@vger.kernel.org; linux- o

Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-04-22 Thread Tomi Valkeinen
Hi, On Wed, 2009-04-22 at 08:25 +0200, ext Hardik Shah wrote: This is the version 5th of the Driver. Following are the features supported. 1. Provides V4L2 user interface for the video pipelines of DSS 2. Basic streaming working on LCD and TV. 3. Support for various pixel formats like YUV,

RE: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-04-22 Thread Shah, Hardik
-Original Message- From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com] Sent: Wednesday, April 22, 2009 1:53 PM To: Shah, Hardik Cc: linux-media@vger.kernel.org; linux-o...@vger.kernel.org; Jadav, Brijesh R; Hiremath, Vaibhav Subject: Re: [PATCH 3/3] OMAP2/3 V4L2 Display Driver

RE: [Review PATCH 3/3] OMAP2/3 V4L2 Display Driver

2009-04-21 Thread Shah, Hardik
PATCH 3/3] OMAP2/3 V4L2 Display Driver Hi Hardik, Just a few comments on your comments :-) Hi Hans, My Comments inlined, Most of the comments are taken care off. Thanks for review. Hardik, -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent